cron job: media_tree daily build: WARNINGS

2017-09-11 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Sep 12 05:00:15 CEST 2017 media-tree git hash:1efdf1776e2253b77413c997bed862410e4b6aaf media_build

Re: [PATCH 0/2] staging: atomisp: activate ATOMISP2401 support

2017-09-11 Thread Alan Cox
On Mon, 11 Sep 2017 20:49:27 +0200 Vincent Hervieux wrote: > Currently atomisp module supports Intel's Baytrail SoC and contains > some compilation switches to support Intel's Cherrytrail SoC instead. > The patchset aims to : > - 1/2: activate ATOMISP2400 or

[PATCH V2] build: Added missing functions nsecs_to_jiffies(64)

2017-09-11 Thread Jasmin J.
From: Jasmin Jessich Several modules expect the functions nsecs_to_jiffies64 and nsecs_to_jiffies to be available when they get loaded. For Kernels prior to 3.16, this symbol is not exported in time.c . Copied the functions to compat.h, so that they get already resolved during

Re: [PATCH] media: i2c: adv748x: Map v4l2_std_id to the internal reg value

2017-09-11 Thread Simon Yuan
On Tuesday, 12 September 2017 10:26:53 NZST Kieran Bingham wrote: > From: Simon Yuan > > The video standard was not mapped to the corresponding value of the > internal video standard in adv748x_afe_querystd, causing the wrong > video standard to be selected. > > Fixes:

[PATCH] media: i2c: adv748x: Map v4l2_std_id to the internal reg value

2017-09-11 Thread Kieran Bingham
From: Simon Yuan The video standard was not mapped to the corresponding value of the internal video standard in adv748x_afe_querystd, causing the wrong video standard to be selected. Fixes: 3e89586a64df ("media: i2c: adv748x: add adv748x driver") Signed-off-by: Simon Yuan

Re: [PATCH v2 6/8] v4l: vsp1: Adapt entities to configure into a body

2017-09-11 Thread Kieran Bingham
Hi Laurent, On 17/08/17 18:58, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Monday 14 Aug 2017 16:13:29 Kieran Bingham wrote: >> Currently the entities store their configurations into a display list. >> Adapt this such that the code can be configured into a body

Re: [PATCH v2 5/8] v4l: vsp1: Refactor display list configure operations

2017-09-11 Thread Kieran Bingham
Hi Laurent, On 17/08/17 19:13, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Monday 14 Aug 2017 16:13:28 Kieran Bingham wrote: >> The entities provide a single .configure operation which configures the >> object into the target display list, based on the

Re: [PATCH v2 8/8] v4l: vsp1: Reduce display list body size

2017-09-11 Thread Kieran Bingham
On 17/08/17 17:11, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Monday 14 Aug 2017 16:13:31 Kieran Bingham wrote: >> The display list originally allocated a body of 256 entries to store all >> of the register lists required for each frame. >> >> This has now been

Re: IR driver support for tango platforms

2017-09-11 Thread Sean Young
Hi Mason, On Mon, Sep 11, 2017 at 04:37:42PM +0200, Mason wrote: > Hello Sean, > > After a long hiatus, I can now work again on the IR driver support > for tango platforms. I'm still using this driver: > > https://github.com/mansr/linux-tangox/blob/master/drivers/media/rc/tangox-ir.c > > There

Re: [PATCH v9 18/24] as3645a: Switch to fwnode property API

2017-09-11 Thread Jacek Anaszewski
Hi Sakari, On 09/09/2017 11:36 PM, Sakari Ailus wrote: > Hi Jacek, > > On Sat, Sep 09, 2017 at 09:06:41PM +0200, Jacek Anaszewski wrote: >> Hi Sakari, >> >> I've come across this patch only by a chance. I believe that merging >> leds-as3645a.c patches via media tree is not going to be a

Re: [PATCH 1/2] staging: atomisp: add menu entries to choose between ATOMISP_2400 and ATOMISP_2401.

2017-09-11 Thread Dan Carpenter
No changelog. No Signed-off-by line. Without reading too carefully, or trying to do a build, it looks like we're activating the menu items and then fixing the build. It should be the other way around so that we don't break git bisect. People are always doing randconfig and the autobuilders

Re: [PATCH 2/2] staging: atomisp: fix compilation errors in case of ISP2401.

2017-09-11 Thread Dan Carpenter
We always need a changelog. And actually this seems a bit involved so there is stuff to explain. On Mon, Sep 11, 2017 at 08:51:15PM +0200, Vincent Hervieux wrote: > Signed-off-by: Vincent Hervieux > --- > .../media/atomisp/pci/atomisp2/atomisp_cmd.c | 5 ++---

Re: [PATCHv4 3/5] dt-bindings: document the CEC GPIO bindings

2017-09-11 Thread Linus Walleij
On Thu, Aug 31, 2017 at 1:01 PM, Hans Verkuil wrote: > + cec-gpio = < 7 GPIO_OPEN_DRAIN>; Actually if you want to be 100% specific: cec-gpio = < 7 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; (Parens are needed.) But I'm not very picky about that, active high is implicit.

Re: [PATCH] [media] v4l: vsp1: Use generic node name

2017-09-11 Thread Rob Herring
On Wed, Aug 30, 2017 at 11:57:31AM +0200, Geert Uytterhoeven wrote: > Use the preferred generic node name in the example. > > Signed-off-by: Geert Uytterhoeven > --- > Documentation/devicetree/bindings/media/renesas,vsp1.txt | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH v2 2/8] v4l: vsp1: Provide a fragment pool

2017-09-11 Thread Kieran Bingham
Hi Laurent, Thanks for your review, On 17/08/17 13:13, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Monday 14 Aug 2017 16:13:25 Kieran Bingham wrote: >> Each display list allocates a body to store register values in a dma >> accessible buffer from a dma_alloc_wc()

Re: [PATCH v2 3/8] v4l: vsp1: Convert display lists to use new fragment pool

2017-09-11 Thread Kieran Bingham
Hi Laurent, Thanks for the review On 17/08/17 13:13, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Monday 14 Aug 2017 16:13:26 Kieran Bingham wrote: >> Adapt the dl->body0 object to use an object from the fragment pool. >> This greatly reduces the pressure on the TLB

Re: A patch for a bug in adv748x

2017-09-11 Thread Simon Yuan
On Tuesday, 12 September 2017 07:00:33 NZST Kieran Bingham wrote: > Hi Simon, > > On 11/09/17 05:30, Simon Yuan wrote: > > Hi Niklas, > > > > How are you doing? I've picked you as my contact since I met you earlier > > this year at ELC2017. Not sure if you still remember, but we had a very > >

Re: [media] s5p-mfc: Delete an error message for a failed memory allocation in s5p_mfc_probe()

2017-09-11 Thread SF Markus Elfring
> Could you make the commit summary shorter, to keep it > below 70 characters [1]? With that changed feel free to add > > Acked-by: Sylwester Nawrocki … > [1] Documentation/process/submitting-patches.rst Will it be sufficient that a patch committer will adjust the

Re: [media] s5p-mfc: Adjust a null pointer check in four functions

2017-09-11 Thread SF Markus Elfring
>> Date: Fri, 8 Sep 2017 22:37:00 +0200 >> MIME-Version: 1.0 >> Content-Type: text/plain; charset=UTF-8 >> Content-Transfer-Encoding: 8bit > > Can you resend with that 4 lines removed? * Do you care to preserve an information like the author date? * Would you like to support special characters

Re: A patch for a bug in adv748x

2017-09-11 Thread Kieran Bingham
Hi Simon, On 11/09/17 05:30, Simon Yuan wrote: > Hi Niklas, > > How are you doing? I've picked you as my contact since I met you earlier this > year at ELC2017. Not sure if you still remember, but we had a very brief chat > about the status of the adv748x driver. I'll let Niklas reply to this

[PATCH 2/2] staging: atomisp: fix compilation errors in case of ISP2401.

2017-09-11 Thread Vincent Hervieux
Signed-off-by: Vincent Hervieux --- .../media/atomisp/pci/atomisp2/atomisp_cmd.c | 5 ++--- .../media/atomisp/pci/atomisp2/atomisp_v4l2.c | 6 +- .../pci/atomisp2/css2400/ia_css_acc_types.h| 1 + .../css2400/runtime/debug/src/ia_css_debug.c

[PATCH 1/2] staging: atomisp: add menu entries to choose between ATOMISP_2400 and ATOMISP_2401.

2017-09-11 Thread Vincent Hervieux
--- drivers/staging/media/atomisp/pci/Kconfig | 23 ++ .../staging/media/atomisp/pci/atomisp2/Makefile| 10 +- 2 files changed, 32 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/Kconfig

[PATCH 0/2] staging: atomisp: activate ATOMISP2401 support

2017-09-11 Thread Vincent Hervieux
Currently atomisp module supports Intel's Baytrail SoC and contains some compilation switches to support Intel's Cherrytrail SoC instead. The patchset aims to : - 1/2: activate ATOMISP2400 or ATOMISP2401 from the menu. - 2/2: fix compilation errors for ATOMISP2401. I'm not so confident with patch

Re: [PATCH] staging: atomisp: add a driver for ov5648 camera sensor

2017-09-11 Thread Devid Antonio Filoni
On Mon, Sep 11, 2017 at 05:55:29PM +0300, Sakari Ailus wrote: > Hi Devid, > > Please see my comments below. > > Andy: please look for "INT5648". Hi Sakari, I'm replying below to your comments. I'll work on a v2 patch as soon as we get more comments. About "INT5648", I extracted it from the

[PATCH V2] media: v4l2-pci-skeleton: Fix error handling path in 'skeleton_probe()'

2017-09-11 Thread Christophe JAILLET
If this memory allocation fails, we must release some resources, as already done in the code below and above. Signed-off-by: Christophe JAILLET --- v2: linux-media@vger.kernel.org added in cc --- samples/v4l/v4l2-pci-skeleton.c | 6 -- 1 file changed, 4

Re: [PATCH] Staging: atomisp: fix alloc_cast.cocci warnings

2017-09-11 Thread Sakari Ailus
Hi Branislav, On Thu, Sep 07, 2017 at 06:26:42PM +0200, Branislav Radocaj wrote: > Remove casting the values returned by memory allocation functions > like kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc. > > Semantic patch information: > This makes an effort to find cases of casting

Re: [PATCH] staging: atomisp: add a driver for ov5648 camera sensor

2017-09-11 Thread Sakari Ailus
Hi Devid, Please see my comments below. Andy: please look for "INT5648". On Sun, Sep 10, 2017 at 02:23:07PM +0200, Devid Antonio Floni wrote: > The ov5680 5-megapixel camera sensor from OmniVision supports up to 2592x1944 > resolution and MIPI CSI-2 interface. Output format is raw sRGB/Bayer

IR driver support for tango platforms

2017-09-11 Thread Mason
Hello Sean, After a long hiatus, I can now work again on the IR driver support for tango platforms. I'm still using this driver: https://github.com/mansr/linux-tangox/blob/master/drivers/media/rc/tangox-ir.c There are two nits I'd like to discuss. A) When I hold a key on the RC, ir-keytable

Re: [PATCH v10 19/24] v4l: fwnode: Add convenience function for parsing common external refs

2017-09-11 Thread Sakari Ailus
On Mon, Sep 11, 2017 at 01:17:46PM +0200, Pavel Machek wrote: > On Mon 2017-09-11 11:00:03, Sakari Ailus wrote: > > Add v4l2_fwnode_parse_reference_sensor_common for parsing common > > sensor properties that refer to adjacent devices such as flash or lens > > driver chips. > > > > As this is an

Re: [PATCH v10 18/24] v4l: fwnode: Add a helper function to obtain device / interger references

2017-09-11 Thread Sakari Ailus
On Mon, Sep 11, 2017 at 03:34:16PM +0200, Hans Verkuil wrote: > > + u32 val; > > + > > + fwnode_for_each_child_node(fwnode, child) { > > + if (fwnode_property_read_u32(child, *props, > > )) > > +

Re: [PATCH] build: Added missing functions nsecs_to_jiffies(64)

2017-09-11 Thread Hans Verkuil
On 09/11/2017 12:23 AM, Jasmin J. wrote: > From: Jasmin Jessich > > Several modules expect the functions nsecs_to_jiffies64 and > nsecs_to_jiffies to be available when they get loaded. For Kernels prior > to 3.16, this symbol is not exported in time.c . > Copied the functions to

[GIT PULL FOR v4.15] Various fixes

2017-09-11 Thread Hans Verkuil
Hi Mauro, A bunch of small things all over the place. Please note the "media: fix media Kconfig help syntax issues" patch: double check that drivers/media/pci/netup_unidvb/Kconfig is OK. Regards, Hans The following changes since commit 1efdf1776e2253b77413c997bed862410e4b6aaf:

Re: [PATCH v3 01/15] [media] v4l: Document explicit synchronization behaviour

2017-09-11 Thread Hans Verkuil
On 09/11/2017 03:34 PM, Gustavo Padovan wrote: > 2017-09-11 Hans Verkuil : > >> On 09/11/2017 03:18 PM, Gustavo Padovan wrote: >>> 2017-09-11 Hans Verkuil : >>> On 09/11/2017 12:50 PM, Hans Verkuil wrote: > On 09/07/2017 08:42 PM, Gustavo Padovan

Re: [PATCH v10 18/24] v4l: fwnode: Add a helper function to obtain device / interger references

2017-09-11 Thread Hans Verkuil
On 09/11/2017 03:27 PM, Sakari Ailus wrote: > Hi Hans, > > On Mon, Sep 11, 2017 at 02:38:23PM +0200, Hans Verkuil wrote: >> On 09/11/2017 02:28 PM, Sakari Ailus wrote: >>> Hi Hans, >>> >>> Thanks for the review. >>> >>> On Mon, Sep 11, 2017 at 11:38:58AM +0200, Hans Verkuil wrote: Typo in

Re: [PATCH v3 01/15] [media] v4l: Document explicit synchronization behaviour

2017-09-11 Thread Gustavo Padovan
2017-09-11 Hans Verkuil : > On 09/11/2017 03:18 PM, Gustavo Padovan wrote: > > 2017-09-11 Hans Verkuil : > > > >> On 09/11/2017 12:50 PM, Hans Verkuil wrote: > >>> On 09/07/2017 08:42 PM, Gustavo Padovan wrote: > From: Gustavo Padovan

Re: [PATCH 3/3] [media] DaVinci-VPBE-Display: Adjust 12 checks for null pointers

2017-09-11 Thread Lad, Prabhakar
On Fri, Sep 8, 2017 at 1:33 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 8 Sep 2017 14:00:20 +0200 > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > The script

Re: [PATCH v10 18/24] v4l: fwnode: Add a helper function to obtain device / interger references

2017-09-11 Thread Sakari Ailus
Hi Hans, On Mon, Sep 11, 2017 at 02:38:23PM +0200, Hans Verkuil wrote: > On 09/11/2017 02:28 PM, Sakari Ailus wrote: > > Hi Hans, > > > > Thanks for the review. > > > > On Mon, Sep 11, 2017 at 11:38:58AM +0200, Hans Verkuil wrote: > >> Typo in subject: interger -> integer > >> > >> On

Re: [PATCH v3 01/15] [media] v4l: Document explicit synchronization behaviour

2017-09-11 Thread Hans Verkuil
On 09/11/2017 03:18 PM, Gustavo Padovan wrote: > 2017-09-11 Hans Verkuil : > >> On 09/11/2017 12:50 PM, Hans Verkuil wrote: >>> On 09/07/2017 08:42 PM, Gustavo Padovan wrote: From: Gustavo Padovan Add section to VIDIOC_QBUF about

Re: [PATCH 2/3] [media] DaVinci-VPBE-Display: Improve a size determination in two functions

2017-09-11 Thread Lad, Prabhakar
On Fri, Sep 8, 2017 at 1:32 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 8 Sep 2017 10:50:32 +0200 > > Replace the specification of data structures by pointer dereferences > as the parameter for the operator

Re: [PATCH 1/3] [media] DaVinci-VPBE-Display: Delete an error message for a failed memory allocation in init_vpbe_layer()

2017-09-11 Thread Lad, Prabhakar
On Fri, Sep 8, 2017 at 1:31 PM, SF Markus Elfring wrote: > > From: Markus Elfring > Date: Thu, 7 Sep 2017 22:37:16 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using

[PATCH] et8ek8: Add support for flash and lens devices

2017-09-11 Thread Pavel Machek
Parse async sub-devices by using v4l2_subdev_fwnode_reference_parse_sensor_common(). These types devices aren't directly related to the sensor, but are nevertheless handled by the et8ek8 driver due to the relationship of these component to the main part of the camera module --- the sensor.

Re: [PATCH v3 01/15] [media] v4l: Document explicit synchronization behaviour

2017-09-11 Thread Gustavo Padovan
2017-09-11 Hans Verkuil : > On 09/11/2017 12:50 PM, Hans Verkuil wrote: > > On 09/07/2017 08:42 PM, Gustavo Padovan wrote: > >> From: Gustavo Padovan > >> > >> Add section to VIDIOC_QBUF about it > >> > >> v2: > >>- mention that fences are

[GIT PULL FOR v4.15] tc358743: add CEC support

2017-09-11 Thread Hans Verkuil
Add CEC support to the tc358743 HDMI-to-CSI bridge. Tested with my Raspberry Pi 2B and an Auvidea B100 adapter. Regards, Hans The following changes since commit 1efdf1776e2253b77413c997bed862410e4b6aaf: media: leds: as3645a: add V4L2_FLASH_LED_CLASS dependency (2017-09-05 16:32:45

Re: [PATCH v10 18/24] v4l: fwnode: Add a helper function to obtain device / interger references

2017-09-11 Thread Hans Verkuil
On 09/11/2017 02:28 PM, Sakari Ailus wrote: > Hi Hans, > > Thanks for the review. > > On Mon, Sep 11, 2017 at 11:38:58AM +0200, Hans Verkuil wrote: >> Typo in subject: interger -> integer >> >> On 09/11/2017 10:00 AM, Sakari Ailus wrote: >>> v4l2_fwnode_reference_parse_int_prop() will find an

[PATCH] media: platform: VIDEO_QCOM_CAMSS should depend on HAS_DMA

2017-09-11 Thread Geert Uytterhoeven
If NO_DMA=y: warning: (TOUCHSCREEN_SUR40 && VIDEO_TW68 && VIDEO_CX23885 && VIDEO_CX25821 && VIDEO_CX88 && VIDEO_SAA7134 && VIDEO_COBALT && VIDEO_QCOM_CAMSS) selects VIDEOBUF2_DMA_SG which has unmet direct dependencies (MEDIA_SUPPORT && HAS_DMA) and ERROR: "bad_dma_ops"

[PATCHv4 2/4] ARM: tegra: add CEC support to tegra124.dtsi

2017-09-11 Thread Hans Verkuil
From: Hans Verkuil Add support for the Tegra CEC IP to tegra124.dtsi and enable it on the Jetson TK1. Signed-off-by: Hans Verkuil --- arch/arm/boot/dts/tegra124-jetson-tk1.dts | 4 arch/arm/boot/dts/tegra124.dtsi | 12

[PATCHv4 0/4] tegra-cec: add Tegra HDMI CEC support

2017-09-11 Thread Hans Verkuil
From: Hans Verkuil This patch series adds support for the Tegra CEC functionality. This v4 has been rebased to the latest 4.14 pre-rc1 mainline. Please review! Other than for the bindings that are now Acked I have not received any feedback. The first patch documents

[PATCHv4 1/4] dt-bindings: document the tegra CEC bindings

2017-09-11 Thread Hans Verkuil
From: Hans Verkuil This documents the binding for the Tegra CEC module. Signed-off-by: Hans Verkuil Acked-by: Rob Herring --- .../devicetree/bindings/media/tegra-cec.txt| 27 ++ 1 file changed, 27

[PATCHv4 4/4] drm/tegra: add cec-notifier support

2017-09-11 Thread Hans Verkuil
From: Hans Verkuil In order to support CEC the HDMI driver has to inform the CEC driver whenever the physical address changes. So when the EDID is read the CEC driver has to be informed and whenever the hotplug detect goes away. This is done through the cec-notifier

[PATCHv4 3/4] tegra-cec: add Tegra HDMI CEC driver

2017-09-11 Thread Hans Verkuil
From: Hans Verkuil This driver adds support for the Tegra CEC IP. It is based on the NVIDIA drivers/misc/tegra-cec driver in their 3.10 kernel. This has been converted to the CEC framework and cleaned up. Tested with my Jetson TK1 board. It has also been tested with the

Re: [PATCH v10 18/24] v4l: fwnode: Add a helper function to obtain device / interger references

2017-09-11 Thread Sakari Ailus
Hi Hans, Thanks for the review. On Mon, Sep 11, 2017 at 11:38:58AM +0200, Hans Verkuil wrote: > Typo in subject: interger -> integer > > On 09/11/2017 10:00 AM, Sakari Ailus wrote: > > v4l2_fwnode_reference_parse_int_prop() will find an fwnode such that under > > the device's own fwnode, > >

[PATCHv3 1/3] drm: add support for DisplayPort CEC-Tunneling-over-AUX

2017-09-11 Thread Hans Verkuil
From: Hans Verkuil This adds support for the DisplayPort CEC-Tunneling-over-AUX feature that is part of the DisplayPort 1.3 standard. Unfortunately, not all DisplayPort/USB-C to HDMI adapters with a chip that has this capability actually hook up the CEC pin, so even

[PATCHv3 0/3] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2017-09-11 Thread Hans Verkuil
From: Hans Verkuil This patch series adds support for the DisplayPort CEC-Tunneling-over-AUX feature. This patch series is based on the current pre-4.14-rc1 mainline which has all the needed cec 4.14 patches merged. This patch series has been tested with my NUC7i5BNK and

[PATCHv3 3/3] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2017-09-11 Thread Hans Verkuil
From: Hans Verkuil Implement support for this DisplayPort feature. The cec device is created whenever it detects an adapter that has this feature. It is only removed when a new adapter is connected that does not support this. If a new adapter is connected that has

[PATCHv3 2/3] drm-kms-helpers.rst: document the DP CEC helpers

2017-09-11 Thread Hans Verkuil
From: Hans Verkuil Document the Display Port CEC helper functions. Signed-off-by: Hans Verkuil --- Documentation/gpu/drm-kms-helpers.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/gpu/drm-kms-helpers.rst

Re: [PATCH v10 19/24] v4l: fwnode: Add convenience function for parsing common external refs

2017-09-11 Thread Pavel Machek
On Mon 2017-09-11 11:00:03, Sakari Ailus wrote: > Add v4l2_fwnode_parse_reference_sensor_common for parsing common > sensor properties that refer to adjacent devices such as flash or lens > driver chips. > > As this is an association only, there's little a regular driver needs to > know about

Re: [PATCH v10 24/24] arm: dts: omap3: N9/N950: Add flash references to the camera

2017-09-11 Thread Pavel Machek
On Mon 2017-09-11 11:00:08, Sakari Ailus wrote: > Add flash and indicator LED phandles to the sensor node. > > Signed-off-by: Sakari Ailus Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures)

Re: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and flash properties

2017-09-11 Thread Pavel Machek
On Mon 2017-09-11 11:00:04, Sakari Ailus wrote: > Document optional lens-focus and flash properties for the smiapp driver. Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures)

Re: [PATCH] dma-fence: fix dma_fence_get_rcu_safe

2017-09-11 Thread Christian König
Am 11.09.2017 um 12:01 schrieb Chris Wilson: [SNIP] Yeah, but that is illegal with a fence objects. When anybody allocates fences this way it breaks at least reservation_object_get_fences_rcu(), reservation_object_wait_timeout_rcu() and reservation_object_test_signaled_single(). Many, many

Re: [PATCH v10 19/24] v4l: fwnode: Add convenience function for parsing common external refs

2017-09-11 Thread Sakari Ailus
On Mon, Sep 11, 2017 at 11:47:11AM +0200, Hans Verkuil wrote: > On 09/11/2017 10:00 AM, Sakari Ailus wrote: > > Add v4l2_fwnode_parse_reference_sensor_common for parsing common > > sensor properties that refer to adjacent devices such as flash or lens > > driver chips. > > > > As this is an

Re: [PATCH v3 02/15] [media] vb2: add explicit fence user API

2017-09-11 Thread Hans Verkuil
On 09/11/2017 12:55 PM, Hans Verkuil wrote: > On 09/07/2017 08:42 PM, Gustavo Padovan wrote: >> From: Gustavo Padovan >> >> Turn the reserved2 field into fence_fd that we will use to send >> an in-fence to the kernel and return an out-fence from the kernel to >>

Re: [PATCH v3 01/15] [media] v4l: Document explicit synchronization behaviour

2017-09-11 Thread Hans Verkuil
On 09/11/2017 12:50 PM, Hans Verkuil wrote: > On 09/07/2017 08:42 PM, Gustavo Padovan wrote: >> From: Gustavo Padovan >> >> Add section to VIDIOC_QBUF about it >> >> v2: >> - mention that fences are files (Hans) >> - rework for the new API >> >>

Re: [PATCH v3 02/15] [media] vb2: add explicit fence user API

2017-09-11 Thread Hans Verkuil
On 09/07/2017 08:42 PM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Turn the reserved2 field into fence_fd that we will use to send > an in-fence to the kernel and return an out-fence from the kernel to > userspace. > > Two new flags were added,

Re: [PATCH v7] rockchip/rga: v4l2 m2m support

2017-09-11 Thread Jacob Chen
Hi Hans, 2017-08-25 20:09 GMT+08:00 Hans Verkuil : > Hi Jacob, > > As promised, some more (small) review comments below. > > On 03/08/17 07:23, Jacob Chen wrote: >> Rockchip RGA is a separate 2D raster graphic acceleration unit. It >> accelerates 2D graphics operations, such

Re: [PATCH v3 01/15] [media] v4l: Document explicit synchronization behaviour

2017-09-11 Thread Hans Verkuil
On 09/07/2017 08:42 PM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Add section to VIDIOC_QBUF about it > > v2: > - mention that fences are files (Hans) > - rework for the new API > > Signed-off-by: Gustavo Padovan

Re: [PATCH v8 0/4] Add Rockchip RGA V4l2 support

2017-09-11 Thread Jacob Chen
Hi Hans, v4l2-compliance result: v4l2-compliance SHA : not available Driver Info: Driver name : rockchip-rga Card type : rockchip-rga Bus info : platform:rga Driver version: 4.13.0 Capabilities : 0x84208000 Video

[PATCH v8 1/4] rockchip/rga: v4l2 m2m support

2017-09-11 Thread Jacob Chen
Rockchip RGA is a separate 2D raster graphic acceleration unit. It accelerates 2D graphics operations, such as point/line drawing, image scaling, rotation, BitBLT, alpha blending and image blur/sharpness The drvier is mostly based on s5p-g2d v4l2 m2m driver And supports various operations from

[PATCH v8 0/4] Add Rockchip RGA V4l2 support

2017-09-11 Thread Jacob Chen
This patch series add a v4l2 m2m drvier for rockchip RGA direct rendering based 2d graphics acceleration module. Recently I tried to add protduff support for gstreamer on rockchip platform, and i found that API were not very suitable for my purpose. It shouldn't go upstream until we can

[PATCH v8 2/4] ARM: dts: rockchip: add RGA device node for RK3288

2017-09-11 Thread Jacob Chen
This patch add the RGA dt config of rk3288 SoC. Signed-off-by: Jacob Chen Signed-off-by: Yakir Yang --- arch/arm/boot/dts/rk3288.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi

[PATCH v8 3/4] arm64: dts: rockchip: add RGA device node for RK3399

2017-09-11 Thread Jacob Chen
This patch add the RGA dt config of RK3399 SoC. Signed-off-by: Jacob Chen Signed-off-by: Yakir Yang --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi

[PATCH v8 4/4] dt-bindings: Document the Rockchip RGA bindings

2017-09-11 Thread Jacob Chen
Add DT bindings documentation for Rockchip RGA Signed-off-by: Jacob Chen Signed-off-by: Yakir Yang Acked-by: Rob Herring --- .../devicetree/bindings/media/rockchip-rga.txt | 33 ++ 1 file changed, 33

Re: [PATCH] dma-fence: fix dma_fence_get_rcu_safe

2017-09-11 Thread Chris Wilson
Quoting Christian König (2017-09-11 10:57:57) > Am 11.09.2017 um 11:23 schrieb Chris Wilson: > > Quoting Christian König (2017-09-11 10:06:50) > >> Am 11.09.2017 um 10:59 schrieb Chris Wilson: > >>> Quoting Christian König (2017-09-11 09:50:40) > Sorry for the delayed response, but your mail

Re: [PATCH v10 17/24] v4l: fwnode: Add a helper function for parsing generic references

2017-09-11 Thread Sakari Ailus
Hi Hans, Thanks for the review! On Mon, Sep 11, 2017 at 11:14:03AM +0200, Hans Verkuil wrote: > On 09/11/2017 10:00 AM, Sakari Ailus wrote: > > Add function v4l2_fwnode_reference_count() for counting external > > references and v4l2_fwnode_reference_parse() for parsing them as async > >

Re: [PATCH] dma-fence: fix dma_fence_get_rcu_safe

2017-09-11 Thread Christian König
Am 11.09.2017 um 11:23 schrieb Chris Wilson: Quoting Christian König (2017-09-11 10:06:50) Am 11.09.2017 um 10:59 schrieb Chris Wilson: Quoting Christian König (2017-09-11 09:50:40) Sorry for the delayed response, but your mail somehow ended up in the Spam folder. Am 04.09.2017 um 15:40

Re: [PATCH v10 24/24] arm: dts: omap3: N9/N950: Add flash references to the camera

2017-09-11 Thread Hans Verkuil
On 09/11/2017 10:00 AM, Sakari Ailus wrote: > Add flash and indicator LED phandles to the sensor node. > > Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Regards, Hans > --- > arch/arm/boot/dts/omap3-n9.dts | 1 + >

Re: [PATCH v10 23/24] ov13858: Add support for flash and lens devices

2017-09-11 Thread Hans Verkuil
On 09/11/2017 10:00 AM, Sakari Ailus wrote: > Parse async sub-devices by using > v4l2_subdev_fwnode_reference_parse_sensor_common(). > > Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Regards, Hans > --- >

Re: [PATCH v10 22/24] ov5670: Add support for flash and lens devices

2017-09-11 Thread Hans Verkuil
On 09/11/2017 10:00 AM, Sakari Ailus wrote: > Parse async sub-devices by using > v4l2_subdev_fwnode_reference_parse_sensor_common(). > > Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Regards, Hans > --- >

Re: [PATCH v10 21/24] smiapp: Add support for flash and lens devices

2017-09-11 Thread Hans Verkuil
On 09/11/2017 10:00 AM, Sakari Ailus wrote: > Parse async sub-devices by using > v4l2_subdev_fwnode_reference_parse_sensor_common(). > > These types devices aren't directly related to the sensor, but are > nevertheless handled by the smiapp driver due to the relationship of these > component to

Re: [PATCH v10 19/24] v4l: fwnode: Add convenience function for parsing common external refs

2017-09-11 Thread Hans Verkuil
On 09/11/2017 10:00 AM, Sakari Ailus wrote: > Add v4l2_fwnode_parse_reference_sensor_common for parsing common > sensor properties that refer to adjacent devices such as flash or lens > driver chips. > > As this is an association only, there's little a regular driver needs to > know about these

Re: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and flash properties

2017-09-11 Thread Hans Verkuil
On 09/11/2017 10:00 AM, Sakari Ailus wrote: > Document optional lens-focus and flash properties for the smiapp driver. > > Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Regards, Hans > --- >

Re: [PATCH v10 18/24] v4l: fwnode: Add a helper function to obtain device / interger references

2017-09-11 Thread Hans Verkuil
Typo in subject: interger -> integer On 09/11/2017 10:00 AM, Sakari Ailus wrote: > v4l2_fwnode_reference_parse_int_prop() will find an fwnode such that under > the device's own fwnode, Sorry, you lost me here. Which device are we talking about? > it will follow child fwnodes with the given >

Re: [PATCH v3 4/6] [media] exynos-gsc: Add hardware rotation limits

2017-09-11 Thread Sylwester Nawrocki
On 09/08/2017 08:02 AM, Hoegeun Kwon wrote: The hardware rotation limits of gsc depends on SOC (Exynos 5250/5420/5433). Distinguish them and add them to the driver data. Signed-off-by: Hoegeun Kwon --- drivers/media/platform/exynos-gsc/gsc-core.c | 96

Re: [PATCH v10 14/24] v4l: async: Allow binding notifiers to sub-devices

2017-09-11 Thread Sakari Ailus
Hi Hans, Thanks for the review! On Mon, Sep 11, 2017 at 10:57:16AM +0200, Hans Verkuil wrote: > On 09/11/2017 09:59 AM, Sakari Ailus wrote: > > Registering a notifier has required the knowledge of struct v4l2_device > > for the reason that sub-devices generally are registered to the > >

Re: [PATCH] dma-fence: fix dma_fence_get_rcu_safe

2017-09-11 Thread Chris Wilson
Quoting Christian König (2017-09-11 10:06:50) > Am 11.09.2017 um 10:59 schrieb Chris Wilson: > > Quoting Christian König (2017-09-11 09:50:40) > >> Sorry for the delayed response, but your mail somehow ended up in the > >> Spam folder. > >> > >> Am 04.09.2017 um 15:40 schrieb Chris Wilson: > >>>

Re: [PATCH 3/3] [media] s5p-mfc: Adjust a null pointer check in four functions

2017-09-11 Thread Sylwester Nawrocki
On 09/08/2017 10:53 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Fri, 8 Sep 2017 22:37:00 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Can you resend with that 4 lines removed? Are you using git

Re: [PATCH 2/3] [media] s5p-mfc: Improve a size determination in s5p_mfc_alloc_memdev()

2017-09-11 Thread Sylwester Nawrocki
On 09/08/2017 10:52 PM, SF Markus Elfring wrote: Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by

Re: [PATCH 1/3] [media] s5p-mfc: Delete an error message for a failed memory allocation in s5p_mfc_probe()

2017-09-11 Thread Sylwester Nawrocki
On 09/08/2017 10:51 PM, SF Markus Elfring wrote: Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Could you make the commit summary shorter, to keep

Re: [PATCH v10 17/24] v4l: fwnode: Add a helper function for parsing generic references

2017-09-11 Thread Hans Verkuil
On 09/11/2017 10:00 AM, Sakari Ailus wrote: > Add function v4l2_fwnode_reference_count() for counting external > references and v4l2_fwnode_reference_parse() for parsing them as async > sub-devices. > > This can be done on e.g. flash or lens async sub-devices that are not part > of but are

Re: [PATCH] dma-fence: fix dma_fence_get_rcu_safe

2017-09-11 Thread Christian König
Am 11.09.2017 um 10:59 schrieb Chris Wilson: Quoting Christian König (2017-09-11 09:50:40) Sorry for the delayed response, but your mail somehow ended up in the Spam folder. Am 04.09.2017 um 15:40 schrieb Chris Wilson: Quoting Christian König (2017-09-04 14:27:33) From: Christian König

Re: [PATCH] dma-fence: fix dma_fence_get_rcu_safe

2017-09-11 Thread Chris Wilson
Quoting Christian König (2017-09-11 09:50:40) > Sorry for the delayed response, but your mail somehow ended up in the > Spam folder. > > Am 04.09.2017 um 15:40 schrieb Chris Wilson: > > Quoting Christian König (2017-09-04 14:27:33) > >> From: Christian König > >> > >>

Re: [PATCH v10 14/24] v4l: async: Allow binding notifiers to sub-devices

2017-09-11 Thread Hans Verkuil
On 09/11/2017 09:59 AM, Sakari Ailus wrote: > Registering a notifier has required the knowledge of struct v4l2_device > for the reason that sub-devices generally are registered to the > v4l2_device (as well as the media device, also available through > v4l2_device). > > This information is not

Re: [PATCH] dma-fence: fix dma_fence_get_rcu_safe

2017-09-11 Thread Christian König
Sorry for the delayed response, but your mail somehow ended up in the Spam folder. Am 04.09.2017 um 15:40 schrieb Chris Wilson: Quoting Christian König (2017-09-04 14:27:33) From: Christian König The logic is buggy and unnecessary complex. When dma_fence_get_rcu()

Re: [PATCH v9 00/23] Unified fwnode endpoint parser, async sub-device notifier support, N9 flash DTS

2017-09-11 Thread Sakari Ailus
On Sat, Sep 09, 2017 at 11:34:13AM +0200, Pavel Machek wrote: > On Fri 2017-09-08 16:25:07, Sakari Ailus wrote: > > On Fri, Sep 08, 2017 at 04:11:51PM +0300, Sakari Ailus wrote: > > > With this, the as3645a driver successfully registers a sub-device to the > > > media device created by the

Re: [PATCH v9 13/24] v4l: async: Allow async notifier register call succeed with no subdevs

2017-09-11 Thread Sakari Ailus
On Mon, Sep 11, 2017 at 10:05:40AM +0200, Hans Verkuil wrote: > On 09/08/2017 03:18 PM, Sakari Ailus wrote: > > The information on how many async sub-devices would be bindable to a > > notifier is typically dependent on information from platform firmware and > > it's not driver's business to be

Re: [PATCH v9 13/24] v4l: async: Allow async notifier register call succeed with no subdevs

2017-09-11 Thread Hans Verkuil
On 09/08/2017 03:18 PM, Sakari Ailus wrote: > The information on how many async sub-devices would be bindable to a > notifier is typically dependent on information from platform firmware and > it's not driver's business to be aware of that. > > Many V4L2 main drivers are perfectly usable (and

[PATCH v10 00/24] Unified fwnode endpoint parser, async sub-device notifier support, N9 flash DTS

2017-09-11 Thread Sakari Ailus
Hi folks, We have a large influx of new, unmerged, drivers that are now parsing fwnode endpoints and each one of them is doing this a little bit differently. The needs are still exactly the same for the graph data structure is device independent. This is still a non-trivial task and the majority

[PATCH v10 04/24] v4l: async: Add V4L2 async documentation to the documentation build

2017-09-11 Thread Sakari Ailus
The V4L2 async wasn't part of the documentation build. Fix this. Signed-off-by: Sakari Ailus Reviewed-by: Niklas Söderlund Acked-by: Hans Verkuil Reviewed-by: Laurent Pinchart

[PATCH v10 12/24] v4l: async: Register sub-devices before calling bound callback

2017-09-11 Thread Sakari Ailus
Register the sub-device before calling the notifier's bound callback. Doing this the other way around is problematic as the struct v4l2_device has not assigned for the sub-device yet and may be required by the bound callback. Signed-off-by: Sakari Ailus Acked-by:

[PATCH v10 13/24] v4l: async: Allow async notifier register call succeed with no subdevs

2017-09-11 Thread Sakari Ailus
The information on how many async sub-devices would be bindable to a notifier is typically dependent on information from platform firmware and it's not driver's business to be aware of that. Many V4L2 main drivers are perfectly usable (and useful) without async sub-devices and so if there aren't

[PATCH v10 07/24] rcar-vin: Use generic parser for parsing fwnode endpoints

2017-09-11 Thread Sakari Ailus
Instead of using driver implementation, use v4l2_async_notifier_parse_fwnode_endpoints() to parse the fwnode endpoints of the device. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil --- drivers/media/platform/rcar-vin/rcar-core.c | 112

  1   2   >