Re: [PATCH v2 5/5] media: atmel-isc: Rework the format list

2017-09-26 Thread Yang, Wenyou
Hi Hans, Thank  you very much for your review. On 2017/9/25 21:24, Hans Verkuil wrote: Hi Wenyou, On 18/09/17 08:39, Wenyou Yang wrote: To improve the readability of code, split the format array into two, one for the format description, other for the register configuration. Meanwhile, add

cron job: media_tree daily build: ERRORS

2017-09-26 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Sep 27 05:00:15 CEST 2017 media-tree git hash:d5426f4c2ebac8cf05de43988c3fccddbee13d28 media_build

Re: [PATCH v2] scripts: kernel-doc: fix nexted handling

2017-09-26 Thread kbuild test robot
Hi Mauro, [auto build test WARNING on linus/master] [also build test WARNING on v4.14-rc2 next-20170926] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/scripts-kernel-doc

Re: [PATCH 07/10] docs: kernel-doc.rst: add documentation about man pages

2017-09-26 Thread Randy Dunlap
On 09/26/17 10:59, Mauro Carvalho Chehab wrote: > kernel-doc-nano-HOWTO.txt has a chapter about man pages > production. While we don't have a working "make manpages" > target, add it. > > Signed-off-by: Mauro Carvalho Chehab > --- >

Re: [PATCH 02/10] docs: kernel-doc.rst: better describe kernel-doc arguments

2017-09-26 Thread Randy Dunlap
On 09/26/17 10:59, Mauro Carvalho Chehab wrote: > Add a new section to describe kernel-doc arguments, > adding examples about how identation should happen, as failing > to do that causes Sphinx to do the wrong thing. > > Signed-off-by: Mauro Carvalho Chehab > --- >

Re: s5p-mfc - WARNING: possible circular locking dependency detected,[ 4.14.0-rc2

2017-09-26 Thread Shuah Khan
On 09/26/2017 02:10 PM, Shuah Khan wrote: > When running gstreamer pipeline with s5p-mfc → exynos-gsc→ exynos-drm, > I am seeing circular locking dependency detected warning in 4.14-rc2. > This is a regression from 4.13. The pipeline does run to completion > video streaming works. Are you aware of

BUG: Hauppauge USB Live2 audio issues

2017-09-26 Thread Biff Eros
I get some errors loading the driver (modprobe cx231xx): [ 8177.651308] cx231xx 2-3:1.1: New device Hauppauge Hauppauge Device @ 480 Mbps (2040:c200) with 6 interfaces [ 8177.651416] cx231xx 2-3:1.1: can't change interface 3 alt no. to 3: Max. Pkt size = 0 [ 8177.651418] cx231xx 2-3:1.1:

[GIT PULL for 4.15] Camera sensor patches

2017-09-26 Thread Sakari Ailus
Hi Mauro, Here's the first set of camera sensor patches for 4.15. There's one framework patch included, "media: Check for active and has_no_links overrun". Please pull. The following changes since commit d5426f4c2ebac8cf05de43988c3fccddbee13d28: media: staging: atomisp: use clock framework

[PATCH 1/2] media: dvb-usb-v2: lmedm04: Improve logic checking of warm start.

2017-09-26 Thread Malcolm Priestley
Warm start has no check as whether a genuine device has connected and proceeds to next execution path. Check device should read 0x47 at offset of 2 on USB descriptor read and it is the amount requested of 6 bytes. Fix for kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by NULL-ptr

[PATCH 2/2] media: dvb-usb-v2: lmedm04: move ts2020 attach to dm04_lme2510_tuner

2017-09-26 Thread Malcolm Priestley
When the tuner was split from m88rs2000 the attach function is in wrong place. Move to dm04_lme2510_tuner to trap errors on failure and removing a call to lme_coldreset. Prevents driver starting up without any tuner connected. Fixes to trap for ts2020 fail. LME2510(C): FE Found M88RS2000

Re: [PATCH v13 05/25] v4l: fwnode: Support generic parsing of graph endpoints in a device

2017-09-26 Thread Sakari Ailus
On Tue, Sep 19, 2017 at 03:34:00PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > On Tuesday, 19 September 2017 15:11:32 EEST Sakari Ailus wrote: > > On Tue, Sep 19, 2017 at 02:35:01PM +0300, Laurent Pinchart wrote: > > > On Friday, 15 September 2017 17:17:04 EEST Sakari Ailus wrote: > > >> Add

Re: [PATCH 09/10] scripts: kernel-doc: parse next structs/unions

2017-09-26 Thread Mauro Carvalho Chehab
Em Tue, 26 Sep 2017 14:59:19 -0300 Mauro Carvalho Chehab escreveu: > There are several places within the Kernel tree with nested > structs/unions, like this one: > > struct ingenic_cgu_clk_info { > const char *name; > enum { > CGU_CLK_NONE = 0, >

[PATCH 03/20] media: rc: auto load encoder if necessary

2017-09-26 Thread Sean Young
When sending scancodes, load the encoder if we need it. Signed-off-by: Sean Young --- drivers/media/rc/rc-core-priv.h | 1 + drivers/media/rc/rc-ir-raw.c| 2 ++ drivers/media/rc/rc-main.c | 2 +- 3 files changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH 01/20] media: lirc: implement scancode sending

2017-09-26 Thread Sean Young
This introduces a new lirc mode: scancode. Any device which can send raw IR can now also send scancodes. int main() { int mode, fd = open("/dev/lirc0", O_RDWR); mode = LIRC_MODE_SCANCODE; if (ioctl(fd, LIRC_SET_SEND_MODE, )) { // kernel too old or lirc

[PATCH 2/5] ir-ctl: show scancode lirc features

2017-09-26 Thread Sean Young
Report if a lirc devices can receive or send using scancodes. Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.c | 30 -- 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/utils/ir-ctl/ir-ctl.c b/utils/ir-ctl/ir-ctl.c index

[PATCH 4/5] ir-ctl: implement scancode reading

2017-09-26 Thread Sean Young
Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.c| 188 +-- utils/ir-ctl/ir-encode.c | 4 + 2 files changed, 135 insertions(+), 57 deletions(-) diff --git a/utils/ir-ctl/ir-ctl.c b/utils/ir-ctl/ir-ctl.c index f0dcd2a3..f9cf30a3

[PATCH 3/5] ir-ctl: use lirc scancode sending

2017-09-26 Thread Sean Young
Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.c | 79 +-- 1 file changed, 52 insertions(+), 27 deletions(-) diff --git a/utils/ir-ctl/ir-ctl.c b/utils/ir-ctl/ir-ctl.c index 32d7162f..f0dcd2a3 100644 --- a/utils/ir-ctl/ir-ctl.c

[PATCH 5/5] keytable: show lirc device and make test show lirc scancodes

2017-09-26 Thread Sean Young
Now you can see what protocol any remote is using the following command. $ ir-keytable -c -p all -t Old keytable cleared Protocols changed to lirc rc-5 rc-5-sz jvc sony nec sanyo mce_kbd rc-6 sharp xmp Testing events. Please, press CTRL-C to abort. 2124.576099: lirc protocol(rc5): scancode =

[PATCH 1/5] ir-ctl: a pulse space file cannot contain scancode and raw IR

2017-09-26 Thread Sean Young
This simplifies dealing with kernel encoders and raw IR, and does not make much sense anyway. Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.1.in | 7 ++- utils/ir-ctl/ir-ctl.c| 12 +--- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git

[PATCH 08/20] media: lirc: remove LIRCCODE and LIRC_GET_LENGTH

2017-09-26 Thread Sean Young
LIRCCODE is a lirc mode where a driver produces driver-dependent codes for record and transmit. No driver use this any more. The LIRC_GET_LENGTH ioctl was used for this mode only. Signed-off-by: Sean Young --- Documentation/media/uapi/rc/lirc-dev-intro.rst | 15

[PATCH 18/20] media: lirc: introduce LIRC_SET_POLL_MODE

2017-09-26 Thread Sean Young
If you want to poll for both decoded scancodes and raw IR, then this ioctl will help you. int fd = open("/dev/lirc0", O_RDONLY | O_NONBLOCK); for (;;) { unsigned mode = LIRC_MODE_SCANCODE | LIRC_MODE_MODE2; ioctl(fd, LIRC_SET_POLL_MODE, ); poll(&((struct pollfd){ .fd =

[PATCH 12/20] media: lirc: move lirc_dev->attached to rc_dev->registered

2017-09-26 Thread Sean Young
This is done to further remove the lirc kernel api. Ensure that every fops checks for this. Signed-off-by: Sean Young --- drivers/media/rc/ir-lirc-codec.c | 16 ++-- drivers/media/rc/lirc_dev.c | 4 +--- drivers/media/rc/rc-main.c | 8

[PATCH 13/20] media: lirc: do not call rc_close() on unregistered devices

2017-09-26 Thread Sean Young
If a lirc chardev is held open after a device is unplugged, rc_close() will be called after rc_unregister_device(). The driver is not expecting any calls at this point, and the iguanair driver causes an oops in this scenario. Signed-off-by: Sean Young ---

[PATCH 19/20] media: lirc: scancode rc devices should have a lirc device too

2017-09-26 Thread Sean Young
Now that the lirc interface supports scancodes, RC scancode devices can also have a lirc device. Signed-off-by: Sean Young --- drivers/media/rc/ir-lirc-codec.c | 34 ++ drivers/media/rc/lirc_dev.c | 13 ++--- drivers/media/rc/rc-main.c

[PATCH 20/20] media: lirc: document LIRC_MODE_SCANCODE

2017-09-26 Thread Sean Young
Lirc supports a new mode which requires documentation. Signed-off-by: Sean Young --- Documentation/media/lirc.h.rst.exceptions | 49 ++ Documentation/media/uapi/rc/lirc-dev-intro.rst | 25 +++

[PATCH 05/20] media: lirc_zilog: fix variable types and other ugliness

2017-09-26 Thread Sean Young
Cleans up code and makes checkpatch happy. Signed-off-by: Sean Young --- drivers/staging/media/lirc/lirc_zilog.c | 160 +++- 1 file changed, 55 insertions(+), 105 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_zilog.c

[PATCH 10/20] media: lirc: merge lirc_dev_fop_ioctl and ir_lirc_ioctl

2017-09-26 Thread Sean Young
Calculate lirc features when necessary, and add LIRC_{S,G}ET_REC_MODE cases to ir_lirc_ioctl. This makes lirc_dev_fop_ioctl() unnecessary since all cases are already handled by ir_lirc_ioctl(). Signed-off-by: Sean Young --- drivers/media/rc/ir-lirc-codec.c | 85

[PATCH 14/20] media: lirc: create rc-core open and close lirc functions

2017-09-26 Thread Sean Young
Replace the generic kernel lirc api with ones which use rc-core, further reducing the lirc_dev members. Signed-off-by: Sean Young --- drivers/media/rc/ir-lirc-codec.c | 59 -- drivers/media/rc/lirc_dev.c | 68

[PATCH 02/20] media: lirc: use the correct carrier for scancode transmit

2017-09-26 Thread Sean Young
If the lirc device supports it, set the carrier for the protocol. Signed-off-by: Sean Young --- drivers/media/rc/ir-jvc-decoder.c | 1 + drivers/media/rc/ir-lirc-codec.c | 7 +++ drivers/media/rc/ir-mce_kbd-decoder.c | 1 + drivers/media/rc/ir-nec-decoder.c |

[PATCH 09/20] media: lirc: lirc interface should not be a raw decoder

2017-09-26 Thread Sean Young
The lirc user interface exists as a raw decoder, which does not make much sense for transmit-only devices. In addition, we want to have lirc char devices for devices which do not use raw IR, i.e. scancode only devices. Note that rc-code, lirc_dev, ir-lirc-codec are now calling functions of each

[PATCH 17/20] media: lirc: implement reading scancode

2017-09-26 Thread Sean Young
This implements LIRC_MODE_SCANCODE reading from the lirc device. The scancode can be read from the input device too, but with this interface you get the rc protocol, toggle and repeat status in addition too just the scancode. int main() { int fd, mode, rc; fd = open("/dev/lirc0",

[PATCH 07/20] media: promote lirc_zilog out of staging

2017-09-26 Thread Sean Young
Rename to zilog_ir in the process. Signed-off-by: Sean Young --- drivers/media/rc/Kconfig | 12 drivers/media/rc/Makefile | 1 + .../lirc/lirc_zilog.c => media/rc/zilog_ir.c} | 0 drivers/staging/media/Kconfig

[PATCH 15/20] media: lirc: remove name from lirc_dev

2017-09-26 Thread Sean Young
This is a duplicate of rcdev->driver_name. Signed-off-by: Sean Young --- Documentation/media/uapi/rc/lirc-dev-intro.rst | 2 +- drivers/media/rc/ir-lirc-codec.c | 2 -- drivers/media/rc/lirc_dev.c| 9 +++-- include/media/lirc_dev.h

[PATCH 16/20] media: lirc: be gone, lirc kernel api!

2017-09-26 Thread Sean Young
The lirc kernel api sneaked its way in along with the lirc drivers; it was terrible, but now the last step can be done to banish it forever. All future drivers should use the rc-core api. Signed-off-by: Sean Young --- Documentation/media/kapi/rc-core.rst | 5 --

[PATCH 04/20] media: lirc_zilog: remove receiver

2017-09-26 Thread Sean Young
The ir-kbd-i2c module already handles this very well. Signed-off-by: Sean Young --- drivers/staging/media/lirc/lirc_zilog.c | 901 +++- 1 file changed, 76 insertions(+), 825 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_zilog.c

[PATCH 06/20] media: lirc_zilog: port to rc-core using scancode tx interface

2017-09-26 Thread Sean Young
Now that rc-core can send a scancode by rc protocol and scancode, port the lirc_zilog to this interface. The firmware file needs updating to contain the protocol and scancode, so we have haup-ir-blaster-v2.bin for this. The LIRC_MODE_LIRCCODE is no longer supported, and transmit can only be done

[PATCH 11/20] media: lirc: use kfifo rather than lirc_buffer for raw IR

2017-09-26 Thread Sean Young
Since the only mode lirc devices can handle is raw IR, handle this in a plain kfifo. Remove lirc_buffer since this is no longer needed. Signed-off-by: Sean Young --- drivers/media/rc/ir-lirc-codec.c | 75 --- drivers/media/rc/lirc_dev.c | 191

[PATCH 00/20] lirc scancode interface, and more

2017-09-26 Thread Sean Young
Introduce lirc scancode mode, use that to port lirc_zilog to rc-core using that interface, and then remove the lirc kernel api. In summary: - This removes the lirc staging directory. - lirc IR TX can use in-kernel encoders for scancode encoding - lirc_zilog uses the same interface - lirc kapi

s5p-mfc - WARNING: possible circular locking dependency detected,[ 4.14.0-rc2

2017-09-26 Thread Shuah Khan
When running gstreamer pipeline with s5p-mfc → exynos-gsc→ exynos-drm, I am seeing circular locking dependency detected warning in 4.14-rc2. This is a regression from 4.13. The pipeline does run to completion video streaming works. Are you aware of this problem, or would you like it to be

Re: [PATCH v4 9/9] kasan: rework Kconfig settings

2017-09-26 Thread Andrey Ryabinin
On 09/23/2017 12:29 AM, Arnd Bergmann wrote: > We get a lot of very large stack frames using gcc-7.0.1 with the default > -fsanitize-address-use-after-scope --param asan-stack=1 options, which > can easily cause an overflow of the kernel stack, e.g. > > drivers/gpu/drm/i915/gvt/handlers.c:2407:1:

Re: [PATCH] scripts: kernel-doc: parse next structs/unions

2017-09-26 Thread Mauro Carvalho Chehab
Em Tue, 26 Sep 2017 18:56:10 +0200 Markus Heiser escreveu: > > Am 25.09.2017 um 20:22 schrieb Mauro Carvalho Chehab > > : > > > > Jon, > > > > Please let me know what you think about this approach. IMHO, it is a way > > better than what we

Re: [PATCH v2] scripts: kernel-doc: fix nexted handling

2017-09-26 Thread Mauro Carvalho Chehab
Em Tue, 26 Sep 2017 14:45:08 +0200 Markus Heiser escreveu: > > Am 25.09.2017 um 20:41 schrieb Mauro Carvalho Chehab > > : > > >>> + $cont = 1; > >>> + }; > >>> + }; > >>> + # Ignore other nested elements, like enums

[PATCH 05/10] docs: kernel-doc.rst: improve structs chapter

2017-09-26 Thread Mauro Carvalho Chehab
There is a mess on this chapter: it suggests that even enums and unions should be documented with "struct". That's not the way it should be ;-) Fix it and move it to happen earlier. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Mauro Carvalho Chehab

[PATCH 09/10] scripts: kernel-doc: parse next structs/unions

2017-09-26 Thread Mauro Carvalho Chehab
There are several places within the Kernel tree with nested structs/unions, like this one: struct ingenic_cgu_clk_info { const char *name; enum { CGU_CLK_NONE = 0, CGU_CLK_EXT = BIT(0), CGU_CLK_PLL = BIT(1), CGU_CLK_GATE = BIT(2), CGU_CLK_MUX = BIT(3),

[PATCH 10/10] [RFC] w1_netlink.h: add support for nested structs

2017-09-26 Thread Mauro Carvalho Chehab
Describe nested struct/union fields NOTE: This is a pure test patch, meant to validate if the parsing logic for nested structs is working properly. I've no idea if the random text I added there is correct! Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 07/10] docs: kernel-doc.rst: add documentation about man pages

2017-09-26 Thread Mauro Carvalho Chehab
kernel-doc-nano-HOWTO.txt has a chapter about man pages production. While we don't have a working "make manpages" target, add it. Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/kernel-doc.rst | 61 ++ 1 file changed,

[PATCH 01/10] scripts: kernel-doc: get rid of unused output formats

2017-09-26 Thread Mauro Carvalho Chehab
Since there isn't any docbook code anymore upstream, we can get rid of several output formats: - docbook/xml, html, html5 and list formats were used by the old build system; - As ReST is text, there's not much sense on outputting on a different text format. After this patch, only man and rst

[PATCH 00/10] kernel-doc: add supported to document nested structs/unions

2017-09-26 Thread Mauro Carvalho Chehab
Right now, it is not possible to document nested struct and nested unions. kernel-doc simply ignore them. Add support to document them. This series starts with a patch getting rid of the now unused output formats for kernel-doc: since we got rid of all DocBook stuff, we should not need them

[PATCH 08/10] docs: get rid of kernel-doc-nano-HOWTO.txt

2017-09-26 Thread Mauro Carvalho Chehab
Everything there is already described at Documentation/doc-guide/kernel-doc.rst. So, there's no reason why to keep it anymore. Signed-off-by: Mauro Carvalho Chehab --- Documentation/00-INDEX | 2 - Documentation/kernel-doc-nano-HOWTO.txt | 322

[PATCH 06/10] docs: kernel-doc: improve typedef documentation

2017-09-26 Thread Mauro Carvalho Chehab
Add documentation about typedefs for function prototypes and move it to happen earlier. Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/kernel-doc.rst | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git

[PATCH 04/10] docs: kernel-doc.rst: improve function documentation section

2017-09-26 Thread Mauro Carvalho Chehab
Move its contents to happen earlier and improve the description of return values, adding a subsection to it. Most of the contents there came from kernel-doc-nano-HOWTO.txt. Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/kernel-doc.rst | 100

[PATCH 03/10] docs: kernel-doc.rst: improve private members description

2017-09-26 Thread Mauro Carvalho Chehab
The private members section can now be moved to be together with the arguments section. Move it there and add an example about the usage of public: Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/kernel-doc.rst | 56 ++

[PATCH 02/10] docs: kernel-doc.rst: better describe kernel-doc arguments

2017-09-26 Thread Mauro Carvalho Chehab
Add a new section to describe kernel-doc arguments, adding examples about how identation should happen, as failing to do that causes Sphinx to do the wrong thing. Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/kernel-doc.rst | 44

Re: [PATCH] scripts: kernel-doc: parse next structs/unions

2017-09-26 Thread Markus Heiser
> Am 25.09.2017 um 20:22 schrieb Mauro Carvalho Chehab > : > > Jon, > > Please let me know what you think about this approach. IMHO, it is a way > better than what we do right now. This is more a proof of concept, as the > patch is not complete. > > With it, we can

Re: [PATCH 1/6] [media] tda8261: Use common error handling code in tda8261_set_params()

2017-09-26 Thread SF Markus Elfring
>> @@ -129,18 +129,18 @@ static int tda8261_set_params(struct dvb_frontend *fe) >> >> /* Set params */ >> err = tda8261_write(state, buf); >> -if (err < 0) { >> -pr_err("%s: I/O Error\n", __func__); >> -return err; >> -} >> +err =

Re: [PATCH v4 4/9] em28xx: fix em28xx_dvb_init for KASAN

2017-09-26 Thread Andrey Ryabinin
On 09/26/2017 09:47 AM, Arnd Bergmann wrote: > On Mon, Sep 25, 2017 at 11:32 PM, Arnd Bergmann wrote: >> On Mon, Sep 25, 2017 at 7:41 AM, David Laight >> wrote: >>> From: Arnd Bergmann Sent: 22 September 2017 22:29 >>> ... It seems that this

[PATCH 2/3] edid-decode: detailed_block: fix maybe uninitialized warning

2017-09-26 Thread Baruch Siach
Fix the following warnings: edid-decode.c: In function ‘detailed_block’: edid-decode.c:394:2: warning: ‘width’ may be used uninitialized in this function [-Wmaybe-uninitialized] edid-decode.c:394:2: warning: ‘ratio’ may be used uninitialized in this function [-Wmaybe-uninitialized]

[PATCH 1/3] edid-decode: parse_cta: fix maybe uninitialized warning

2017-09-26 Thread Baruch Siach
Fix the following warning: edid-decode.c: In function ‘parse_cta’: edid-decode.c:142:5: warning: ‘v’ may be used uninitialized in this function [-Wmaybe-uninitialized] Signed-off-by: Baruch Siach --- edid-decode.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

[PATCH 3/3] edid-decode: parse_extension: fix maybe uninitialized warning

2017-09-26 Thread Baruch Siach
Fix the following warning: edid-decode.c: In function ‘main’: edid-decode.c:2962:26: warning: ‘conformant_extension’ may be used uninitialized in this function [-Wmaybe-uninitialized] Signed-off-by: Baruch Siach --- edid-decode.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v6 2/2] media: rc: Add driver for tango HW IR decoder

2017-09-26 Thread Måns Rullgård
Marc Gonzalez writes: > On 26/09/2017 15:02, Måns Rullgård wrote: > >> I could continue nit-picking, but I think this is good enough. >> Thanks for being patient. >> >> Signed-off-by: Mans Rullgard > > Smirk. > > If you feel like making a final

Re: usb/media/uvc: warning in uvc_scan_chain_forward/__list_add

2017-09-26 Thread Andrey Konovalov
On Tue, Sep 26, 2017 at 2:50 PM, Laurent Pinchart wrote: > Hi Andrey, > > On Tuesday, 26 September 2017 15:41:45 EEST Andrey Konovalov wrote: >> On Tue, Sep 26, 2017 at 10:43 AM, Laurent Pinchart wrote: >> > On Monday, 25 September 2017 15:40:13 EEST Andrey

Re: [PATCH v6 2/2] media: rc: Add driver for tango HW IR decoder

2017-09-26 Thread Marc Gonzalez
On 26/09/2017 15:02, Måns Rullgård wrote: > I could continue nit-picking, but I think this is good enough. > Thanks for being patient. > > Signed-off-by: Mans Rullgard Smirk. If you feel like making a final round of changes on top of this patch, then go for it. It's your code,

[PATCH 2/2] [media] dmxdev: Improve a size determination in dvb_dmxdev_add_pid()

2017-09-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Sep 2017 15:22:57 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 0/2] [media] dmxdev: Fine-tuning for two function implementations

2017-09-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Sep 2017 15:30:03 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Use common error handling code in dvb_dmxdev_start_feed() Improve a size determination in

[PATCH 1/2] [media] dmxdev: Use common error handling code in dvb_dmxdev_start_feed()

2017-09-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Sep 2017 15:12:47 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

Re: [progress]: dvb_usb_rtl28xxu not tuning "Leadtek Winfast DTV2000 DS PLUS TV"

2017-09-26 Thread Eyal Lebedinsky
On 26/09/17 22:45, Vincent McIntyre wrote: On Tue, Sep 26, 2017 at 02:32:26PM +1000, Eyal Lebedinsky wrote: While the problem persists, I managed to find a way around it for now. I changed the antenna input. Originally I used a powered splitter to feed all the tuners, and it worked well with

Re: [PATCH v6 2/2] media: rc: Add driver for tango HW IR decoder

2017-09-26 Thread Måns Rullgård
Marc Gonzalez writes: > From: Mans Rullgard > > The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. > > Signed-off-by: Marc Gonzalez I could continue nit-picking, but I think this is good enough. Thanks

Re: usb/media/uvc: warning in uvc_scan_chain_forward/__list_add

2017-09-26 Thread Laurent Pinchart
Hi Andrey, On Tuesday, 26 September 2017 15:41:45 EEST Andrey Konovalov wrote: > On Tue, Sep 26, 2017 at 10:43 AM, Laurent Pinchart wrote: > > On Monday, 25 September 2017 15:40:13 EEST Andrey Konovalov wrote: > >> Hi! > >> > >> I've got the following report while fuzzing the kernel with

Re: [PATCH v2] scripts: kernel-doc: fix nexted handling

2017-09-26 Thread Markus Heiser
> Am 25.09.2017 um 20:41 schrieb Mauro Carvalho Chehab > : >>> + $cont = 1; >>> + }; >>> + }; >>> + # Ignore other nested elements, like enums >>> + $members =~ s/({[^\{\}]*})//g; >>> + $nested = $decl_type; >> >> What is the

Re: [progress]: dvb_usb_rtl28xxu not tuning "Leadtek Winfast DTV2000 DS PLUS TV"

2017-09-26 Thread Vincent McIntyre
On Tue, Sep 26, 2017 at 02:32:26PM +1000, Eyal Lebedinsky wrote: > > While the problem persists, I managed to find a way around it for now. > > I changed the antenna input. > > Originally I used a powered splitter to feed all the tuners, and it worked > well with the out-of-kernel driver. This

Re: usb/media/uvc: warning in uvc_scan_chain_forward/__list_add

2017-09-26 Thread Andrey Konovalov
On Tue, Sep 26, 2017 at 10:43 AM, Laurent Pinchart wrote: > Hi Andrey, > > On Monday, 25 September 2017 15:40:13 EEST Andrey Konovalov wrote: >> Hi! >> >> I've got the following report while fuzzing the kernel with syzkaller. > > Thank you for the report. > >>

Re: [progress]: dvb_usb_rtl28xxu not tuning "Leadtek Winfast DTV2000 DS PLUS TV"

2017-09-26 Thread Eyal Lebedinsky
On 26/09/17 14:32, Eyal Lebedinsky wrote: On 18/09/17 14:26, Eyal Lebedinsky wrote: I have just upgraded to f24. I am now using the standard dvb_usb_rtl28xxu fe which logs messages suggesting all is well (I get the /dev/dvb/adapter? etc.) but I get no channels tuned when I run mythfrontend or

usb/media/b2c2: GPF in flexcop_usb_transfer_init

2017-09-26 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit e19b205be43d11bff638cad4487008c48d21c103 (4.14-rc2). It seems that there's no check on the actual number of endpoints. usb 1-1: New USB device strings: Mfr=212, Product=0, SerialNumber=6 usb 1-1: Manufacturer:

Re: [PATCH 1/6] [media] tda8261: Use common error handling code in tda8261_set_params()

2017-09-26 Thread Christoph Böhmwalder
On 26.09.2017 13:27, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 26 Sep 2017 11:01:44 +0200 > > * Add a jump target so that a bit of exception handling can be better > reused at the end of this function. > > This issue was detected by using

[PATCH 6/6] [media] tda8261: Delete an unnecessary variable initialisation in three functions

2017-09-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Sep 2017 12:55:16 +0200 The local variable "err" is reassigned by a statement at the beginning. Thus omit the explicit initialisation in these functions. Signed-off-by: Markus Elfring ---

[PATCH 4/6] [media] tda8261: Delete an unnecessary variable initialisation in tda8261_attach()

2017-09-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Sep 2017 12:24:57 +0200 The local variable "state" is reassigned by a statement at the beginning. Thus omit the explicit initialisation. Signed-off-by: Markus Elfring ---

[PATCH 5/6] [media] tda8261: Adjust three function calls together with a variable assignment

2017-09-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Sep 2017 12:52:24 +0200 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code places. Signed-off-by: Markus Elfring

[PATCH 3/6] [media] tda8261: Return directly after a failed kzalloc() in tda8261_attach()

2017-09-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Sep 2017 12:20:33 +0200 * Return directly after a call of the function "kzalloc" failed at the beginning. * Delete a call of the function "kfree" and the jump target "exit" which became unnecessary with this refactoring.

Re: [PATCH v14 20/28] v4l: fwnode: Add a helper function to obtain device / integer references

2017-09-26 Thread Sakari Ailus
Hi Hans, Thanks for the review. On Tue, Sep 26, 2017 at 10:47:40AM +0200, Hans Verkuil wrote: > On 26/09/17 00:25, Sakari Ailus wrote: > > v4l2_fwnode_reference_parse_int_prop() will find an fwnode such that under > > the device's own fwnode, it will follow child fwnodes with the given > >

[PATCH 2/6] [media] tda8261: Improve a size determination in tda8261_attach()

2017-09-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Sep 2017 12:06:19 +0200 * The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix an affected source code place. * Replace the specification of a data

[PATCH 1/6] [media] tda8261: Use common error handling code in tda8261_set_params()

2017-09-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Sep 2017 11:01:44 +0200 * Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. * The script "checkpatch.pl" pointed

[PATCH 0/6] [media] TDA8261: Fine-tuning for five function implementations

2017-09-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Sep 2017 13:20:12 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (6): Use common error handling code in tda8261_set_params() Improve a size determination in

Re: usb/media/lmedm04: GPF in lme2510_int_read/usb_pipe_endpoint

2017-09-26 Thread Andrey Konovalov
On Mon, Sep 25, 2017 at 3:30 PM, Malcolm Priestley wrote: > > > On 25/09/17 13:39, Andrey Konovalov wrote: >> >> Hi! >> >> I've got the following report while fuzzing the kernel with syzkaller. >> >> On commit e19b205be43d11bff638cad4487008c48d21c103 (4.14-rc2). >> >> usb 1-1:

[PATCH v6 2/2] media: rc: Add driver for tango HW IR decoder

2017-09-26 Thread Marc Gonzalez
From: Mans Rullgard The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. Signed-off-by: Marc Gonzalez --- Changes between v5 and v6 * Move "register fields" macros to top of file * Restore IRQ pending writes --- drivers/media/rc/Kconfig

Re: [PATCH v14 20/28] v4l: fwnode: Add a helper function to obtain device / integer references

2017-09-26 Thread Hans Verkuil
On 26/09/17 00:25, Sakari Ailus wrote: > v4l2_fwnode_reference_parse_int_prop() will find an fwnode such that under > the device's own fwnode, it will follow child fwnodes with the given > property-value pair and return the resulting fwnode. > > Signed-off-by: Sakari Ailus

Re: usb/media/uvc: warning in uvc_scan_chain_forward/__list_add

2017-09-26 Thread Laurent Pinchart
Hi Andrey, On Monday, 25 September 2017 15:40:13 EEST Andrey Konovalov wrote: > Hi! > > I've got the following report while fuzzing the kernel with syzkaller. Thank you for the report. > On commit e19b205be43d11bff638cad4487008c48d21c103 (4.14-rc2). > > list_add double add:

Re: [PATCH v14 22/28] v4l: fwnode: Add a convenience function for registering sensors

2017-09-26 Thread Sakari Ailus
On Tue, Sep 26, 2017 at 10:26:35AM +0200, Hans Verkuil wrote: > On 26/09/17 00:25, Sakari Ailus wrote: > > Add a convenience function for parsing firmware for information on related > > devices using v4l2_async_notifier_parse_fwnode_sensor_common() registering > > the notifier and finally the

[iMX6] HDMI as V4L Video Output Interface?

2017-09-26 Thread David Müller
Hello Is it possible to use the HDMI output as a V4L Video Output Interface or Video Output Overlay Interface using mainline kernels? Dave

Re: [PATCH v14 27/28] ov13858: Add support for flash and lens devices

2017-09-26 Thread Hans Verkuil
On 26/09/17 00:25, Sakari Ailus wrote: > Parse async sub-devices related to the sensor by switching the async > sub-device registration function. > > Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil > --- > drivers/media/i2c/ov13858.c |

Re: [PATCH v14 24/28] smiapp: Add support for flash and lens devices

2017-09-26 Thread Hans Verkuil
On 26/09/17 00:25, Sakari Ailus wrote: > Parse async sub-devices related to the sensor by switching the async > sub-device registration function. > > These types devices aren't directly related to the sensor, but are > nevertheless handled by the smiapp driver due to the relationship of these >

Re: [PATCH v14 26/28] ov5670: Add support for flash and lens devices

2017-09-26 Thread Hans Verkuil
On 26/09/17 00:25, Sakari Ailus wrote: > Parse async sub-devices related to the sensor by switching the async > sub-device registration function. > > Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil > --- > drivers/media/i2c/ov5670.c |

Re: [PATCH v14 25/28] et8ek8: Add support for flash and lens devices

2017-09-26 Thread Hans Verkuil
On 26/09/17 00:25, Sakari Ailus wrote: > Parse async sub-devices related to the sensor by switching the async > sub-device registration function. > > Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil > --- >

Re: [PATCH v14 22/28] v4l: fwnode: Add a convenience function for registering sensors

2017-09-26 Thread Hans Verkuil
On 26/09/17 00:25, Sakari Ailus wrote: > Add a convenience function for parsing firmware for information on related > devices using v4l2_async_notifier_parse_fwnode_sensor_common() registering > the notifier and finally the async sub-device itself. > > This should be useful for sensor drivers

Re: [PATCH v14 22/28] v4l: async: Add a convenience function for registering sensors

2017-09-26 Thread Hans Verkuil
On 26/09/17 00:25, Sakari Ailus wrote: > Add a convenience function for parsing firmware for information on related > devices using v4l2_async_notifier_parse_fwnode_sensor_common() registering > the notifier and finally the async sub-device itself. > > This should be useful for sensor drivers

Re: [PATCH v14 16/28] v4l: async: Ensure only unique fwnodes are registered to notifiers

2017-09-26 Thread Hans Verkuil
On 26/09/17 00:25, Sakari Ailus wrote: > While registering a notifier, check that each newly added fwnode is > unique, and return an error if it is not. Also check that a newly added > notifier does not have the same fwnodes twice. > > Signed-off-by: Sakari Ailus

Re: [PATCH v14 15/28] v4l: async: Allow binding notifiers to sub-devices

2017-09-26 Thread Sakari Ailus
On Tue, Sep 26, 2017 at 01:25:26AM +0300, Sakari Ailus wrote: > Registering a notifier has required the knowledge of struct v4l2_device > for the reason that sub-devices generally are registered to the > v4l2_device (as well as the media device, also available through > v4l2_device). > > This

Re: [PATCH v14 14/28] v4l: async: Prepare for async sub-device notifiers

2017-09-26 Thread Hans Verkuil
On 26/09/17 10:17, Sakari Ailus wrote: > Hi Hans, > > On Tue, Sep 26, 2017 at 10:12:50AM +0200, Hans Verkuil wrote: >> On 26/09/17 00:25, Sakari Ailus wrote: >>> Refactor the V4L2 async framework a little in preparation for async >>> sub-device notifiers. >> >> Perhaps extend this a bit to also

Re: [PATCH v14 14/28] v4l: async: Prepare for async sub-device notifiers

2017-09-26 Thread Sakari Ailus
Hi Hans, On Tue, Sep 26, 2017 at 10:12:50AM +0200, Hans Verkuil wrote: > On 26/09/17 00:25, Sakari Ailus wrote: > > Refactor the V4L2 async framework a little in preparation for async > > sub-device notifiers. > > Perhaps extend this a bit to also state the reason for these changes? Well, the

Re: [PATCH v14 15/28] v4l: async: Allow binding notifiers to sub-devices

2017-09-26 Thread Hans Verkuil
On 26/09/17 00:25, Sakari Ailus wrote: > Registering a notifier has required the knowledge of struct v4l2_device > for the reason that sub-devices generally are registered to the > v4l2_device (as well as the media device, also available through > v4l2_device). > > This information is not

Re: [PATCH v14 14/28] v4l: async: Prepare for async sub-device notifiers

2017-09-26 Thread Hans Verkuil
On 26/09/17 00:25, Sakari Ailus wrote: > Refactor the V4L2 async framework a little in preparation for async > sub-device notifiers. Perhaps extend this a bit to also state the reason for these changes? > > Signed-off-by: Sakari Ailus Anyway, Acked-by: Hans

  1   2   >