Re: [PATCH 6/7] si2168: Announce frontend creation failure

hmmm, IIRC driver core even prints some error when driver probe fails? After that you could enable module debug logging to see more information. So I don't see point for that change. regards Antti On 01/12/2018 06:19 PM, Brad Love wrote: The driver outputs on success, but is silent on

Re: [PATCH 4/7] si2168: Add ts bus coontrol, turn off bus on sleep

Hello And what is rationale here, is there some use case demod must be active and ts set to tristate (disabled)? Just put demod sleep when you don't use it. regards Antti On 01/12/2018 06:19 PM, Brad Love wrote: Includes a function to set TS MODE property os si2168. The function either

Re: [PATCH 3/7] si2157: Add hybrid tuner support

Hello So the use case is to share single tuner with multiple demodulators? Why don't just register single tuner and pass that info to multiple demods? Antti On 01/12/2018 06:19 PM, Brad Love wrote: Add ability to share a tuner amongst demodulators. Addtional demods are attached using

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Jan 16 05:00:17 CET 2018 media-tree git hash:e3ee691dbf24096ea51b3200946b11d68ce75361 media_build

Re: [PATCH 1/2] media: intel-ipu3: cio2: fix a crash with out-of-bounds access

Hi Bingbu, On Tue, Jan 16, 2018 at 1:05 PM, Cao, Bingbu wrote: > I think if set the pages as the DIV_ROUND_UP(vb->planes[0].length, > CIO2_PAGE_SIZE) + 1, the ' if (!pages--)' in loop is not correct. > should be 'if (!--pages)'. > The last page from sg list is the last

RE: [PATCH 1/2] media: intel-ipu3: cio2: fix a crash with out-of-bounds access

I think if set the pages as the DIV_ROUND_UP(vb->planes[0].length, CIO2_PAGE_SIZE) + 1, the ' if (!pages--)' in loop is not correct. should be 'if (!--pages)'. The last page from sg list is the last valid page. __ BRs, Cao, Bingbu > -Original Message- > From:

Re: [PATCH 2/2] media: intel-ipu3: cio2: fix for wrong vb2buf state warnings

On Tue, Jan 16, 2018 at 2:07 AM, Zhi, Yong wrote: > Hi, Tomasz, > > Thanks for reviewing the patch. > >> -Original Message- >> From: Tomasz Figa [mailto:tf...@chromium.org] >> Sent: Friday, January 12, 2018 12:19 AM >> To: Zhi, Yong >> Cc: Linux

Re: [PATCH 1/2] media: intel-ipu3: cio2: fix a crash with out-of-bounds access

Hi Yong, On Tue, Jan 16, 2018 at 2:05 AM, Zhi, Yong wrote: > Hi, Tomasz, > > Thanks for the patch review. > >> -Original Message- >> From: Tomasz Figa [mailto:tf...@chromium.org] >> Sent: Friday, January 12, 2018 12:17 AM >> To: Zhi, Yong >> Cc:

Re: [PATCH v7 1/6] [media] vb2: add is_unordered callback for drivers

On Mon, Jan 15, 2018 at 9:01 PM, Gustavo Padovan wrote: > 2018-01-15 Alexandre Courbot : > >> On Thu, Jan 11, 2018 at 1:07 AM, Gustavo Padovan wrote: >> > From: Gustavo Padovan >> > >> > Explicit

Re: [PATCH v2] vsp1: fix video output on R8A77970

Hi Sergei, On Monday, 15 January 2018 18:06:48 EET Sergei Shtylyov wrote: > On 01/15/2018 03:51 PM, Laurent Pinchart wrote: > > On Tuesday, 26 December 2017 23:14:12 EET Sergei Shtylyov wrote: > >> Laurent has added support for the VSP2-D found on R-Car V3M (R8A77970) > >> but > > > > I'm not

[PATCH] [v4l-utils] buildsystem: Fix not reporting if libjpeg is not being used

Signed-off-by: Chris Mayo --- If configured --without-jpeg, currently see: compile time options summary Host OS: linux-gnu X11: yes GL : yes glu

Re: [RFT PATCH v3 0/6] Asynchronous UVC

Hi Kieran, On Fri, Jan 12, 2018 at 10:19 AM, Kieran Bingham wrote: > This series has been tested on both the ZED and BRIO cameras on arm64 > platforms, however due to the intrinsic changes in the driver I would like to > see it tested with other devices and other

Re: [PATCH v7 1/6] [media] vb2: add is_unordered callback for drivers

2018-01-15 Hans Verkuil : > On 01/15/2018 01:01 PM, Gustavo Padovan wrote: > > 2018-01-15 Alexandre Courbot : > > > >> On Thu, Jan 11, 2018 at 1:07 AM, Gustavo Padovan > >> wrote: > >>> From: Gustavo Padovan

RE: [PATCH 2/2] media: intel-ipu3: cio2: fix for wrong vb2buf state warnings

Hi, Tomasz, Thanks for reviewing the patch. > -Original Message- > From: Tomasz Figa [mailto:tf...@chromium.org] > Sent: Friday, January 12, 2018 12:19 AM > To: Zhi, Yong > Cc: Linux Media Mailing List ; Sakari Ailus >

RE: [PATCH 1/2] media: intel-ipu3: cio2: fix a crash with out-of-bounds access

Hi, Tomasz, Thanks for the patch review. > -Original Message- > From: Tomasz Figa [mailto:tf...@chromium.org] > Sent: Friday, January 12, 2018 12:17 AM > To: Zhi, Yong > Cc: Linux Media Mailing List ; Sakari Ailus >

[PATCH v5 5/9] v4l: vsp1: Use reference counting for bodies

Extend the display list body with a reference count, allowing bodies to be kept as long as a reference is maintained. This provides the ability to keep a cached copy of bodies which will not change, so that they can be re-applied to multiple display lists. Signed-off-by: Kieran Bingham

[PATCH v5 6/9] v4l: vsp1: Refactor display list configure operations

The entities provide a single .configure operation which configures the object into the target display list, based on the vsp1_entity_params selection. This restricts us to a single function prototype for both static configuration (the pre-stream INIT stage) and the dynamic runtime stages for

[PATCH v5 8/9] v4l: vsp1: Move video configuration to a cached dlb

We are now able to configure a pipeline directly into a local display list body. Take advantage of this fact, and create a cacheable body to store the configuration of the pipeline in the video object. vsp1_video_pipeline_run() is now the last user of the pipe->dl object. Convert this function to

[PATCH v5 9/9] v4l: vsp1: Reduce display list body size

The display list originally allocated a body of 256 entries to store all of the register lists required for each frame. This has now been separated into fragments for constant stream setup, and runtime updates. Empirical testing shows that the body0 now uses a maximum of 41 registers for each

[PATCH v5 7/9] v4l: vsp1: Adapt entities to configure into a body

Currently the entities store their configurations into a display list. Adapt this such that the code can be configured into a body directly, allowing greater flexibility and control of the content. All users of vsp1_dl_list_write() are removed in this process, thus it too is removed. A helper,

[PATCH v5 4/9] v4l: vsp1: Convert display lists to use new body pool

Adapt the dl->body0 object to use an object from the body pool. This greatly reduces the pressure on the TLB for IPMMU use cases, as all of the lists use a single allocation for the main body. The CLU and LUT objects pre-allocate a pool containing three bodies, allowing a userspace update before

[PATCH v5 1/9] v4l: vsp1: Reword uses of 'fragment' as 'body'

Throughout the codebase, the term 'fragment' is used to represent a display list body. This term duplicates the 'body' which is already in use. The datasheet references these objects as a body, therefore replace all mentions of a fragment with a body, along with the corresponding pluralised

[PATCH v5 2/9] v4l: vsp1: Protect bodies against overflow

The body write function relies on the code never asking it to write more than the entries available in the list. Currently with each list body containing 256 entries, this is fine, but we can reduce this number greatly saving memory. In preparation of this add a level of protection to catch any

[PATCH v5 0/9] vsp1: TLB optimisation and DL caching

Each display list currently allocates an area of DMA memory to store register settings for the VSP1 to process. Each of these allocations adds pressure to the IPMMU TLB entries. We can reduce the pressure by pre-allocating larger areas and dividing the area across multiple bodies represented as a

[PATCH v5 3/9] v4l: vsp1: Provide a body pool

Each display list allocates a body to store register values in a dma accessible buffer from a dma_alloc_wc() allocation. Each of these results in an entry in the TLB, and a large number of display list allocations adds pressure to this resource. Reduce TLB pressure on the IPMMUs by allocating

Re: [PATCH] media: staging/imx: Checking the right variable in vdic_get_ipu_resources()

Acked-by: Steve Longerbeam On 01/15/2018 12:11 AM, Dan Carpenter wrote: We recently changed this error handling around but missed this error pointer check. We're testing "priv->vdi_in_ch_n" instead of "ch" so the error handling can't be triggered. Fixes:

Re: [PATCH v2] vsp1: fix video output on R8A77970

Hello! On 01/15/2018 03:51 PM, Laurent Pinchart wrote: On Tuesday, 26 December 2017 23:14:12 EET Sergei Shtylyov wrote: Laurent has added support for the VSP2-D found on R-Car V3M (R8A77970) but I'm not sure there's a need to state my name in the commit message. You were the author of

Re: [PATCH 3/4] tsi108_eth: use dma API properly

On Wed, Jan 10, 2018 at 10:09:20PM +0200, Andy Shevchenko wrote: > > + struct platform_device *pdev; > > Do you really need platform_defice reference? > > Perhaps > > struct device *hdev; // hardware device > > > data->hdev = >dev; > > Another idea > > dev->dev.parent = >dev; > > No

Re: MT9M131 on I.MX6DL CSI color issue

Hi Philipp, On 15.01.2018 13:49, Philipp Zabel wrote: > media-ctl propagates video formats downstream, can you try reversing the > order? I did but it does not make a difference. > Also, while the external format is UYVY2X8, internally the IPU only > supports AYUV32, so the last call should be

Re: MT9M131 on I.MX6DL CSI color issue

Hi Florian, On Fri, 2018-01-12 at 01:16 +0100, Florian Boor wrote: > Hello all, > > I have a Phytec VM-009 camera based on MT9M131 connected to CSI0 of a I.MX6DL > based board running mainline 4.13.0 + custom devicetree. Its using the > parallel > interface, 8 bit bus width on pins 12 to 19. >

Re: [PATCH v2] vsp1: fix video output on R8A77970

Hi Sergei, Thank you for the patch. On Tuesday, 26 December 2017 23:14:12 EET Sergei Shtylyov wrote: > Laurent has added support for the VSP2-D found on R-Car V3M (R8A77970) but I'm not sure there's a need to state my name in the commit message. > the video output that VSP2-D sends to DU has

Re: [PATCH v6 4/6] media: i2c: Add TDA1997x HDMI receiver driver

On 12/28/2017 09:09 PM, Tim Harvey wrote: > Add support for the TDA1997x HDMI receivers. > > Cc: Hans Verkuil > Signed-off-by: Tim Harvey > --- > v6: > - fix return on regulator enablei in tda1997x_set_power() (Fabio) > - replace copyright with SPDX

Re: [PATCH v7 1/6] [media] vb2: add is_unordered callback for drivers

On 01/15/2018 01:01 PM, Gustavo Padovan wrote: > 2018-01-15 Alexandre Courbot : > >> On Thu, Jan 11, 2018 at 1:07 AM, Gustavo Padovan wrote: >>> From: Gustavo Padovan >>> >>> Explicit synchronization benefits a lot from

Re: [PATCH v7 1/6] [media] vb2: add is_unordered callback for drivers

2018-01-15 Alexandre Courbot : > On Thu, Jan 11, 2018 at 1:07 AM, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Explicit synchronization benefits a lot from ordered queues, they fit > > better in a pipeline

Re: MT9M131 on I.MX6DL CSI color issue

Hello Anatolij, many thanks for explaining. It changed something at least - see below. On 12.01.2018 11:06, Anatolij Gustschin wrote: > On Fri, 12 Jan 2018 10:58:40 +0100 > Anatolij Gustschin ag...@denx.de wrote: > ... > I forgot the videoconvert, sorry. Try > > gst-launch v4l2src

[PATCH 3/5] auxdisplay: charlcd: add escape sequence for brightness on NEC µPD16314

The NEC µPD16314 can alter the the brightness of the LCD. Make it possible to set this via escape sequence Y0 - Y3. B and R were already taken, so I picked Y for luminance. Signed-off-by: Sean Young --- drivers/auxdisplay/charlcd.c | 20 ++-- 1 file changed, 18

[PATCH 5/5] media: rc: new driver for Sasem Remote Controller VFD/IR

This device is built into the Ahanix D.Vine 5 HTPC case. It has an LCD device, and an IR receiver. The LCD can be controlled via the charlcd driver. Unfortunately the device does not seem to provide a method for accessing the character generator ram. Signed-off-by: Sean Young ---

[PATCH 4/5] media: rc: add keymap for Dign Remote

This is the remote which comes with the Ahanix D.Vine 5 HTPC case. Signed-off-by: Sean Young --- drivers/media/rc/keymaps/Makefile | 1 + drivers/media/rc/keymaps/rc-dign.c | 70 ++ include/media/rc-map.h | 1 + 3 files changed,

[PATCH 2/5] auxdisplay: charlcd: add flush function

The Sasem Remote Controller has an LCD, which is connnected via usb. Multiple write reg or write data commands can be combined into one usb packet. The latency of usb is such that if we send commands one by one, we get very obvious tearing on the LCD. By adding a flush function, we can buffer

[PATCH 0/5] new driver for Ahanix D.Vine 5 IR/VFD

This is a newer driver for this device. It originally supported by the lirc_sasem.c staging driver, which was removed in kernel v4.12. Here a some more information about the hardware and my attempts to understand it: http://www.mess.org/2018/01/17/Ahanix-D-Vine-5-IR-VFD-module/ Sean Young (5):

[PATCH 1/5] auxdisplay: charlcd: no need to call charlcd_gotoxy() if nothing changes

If the line extends beyond the width to the screen, nothing changes. The existing code will call charlcd_gotoxy every time for this case. Signed-off-by: Sean Young --- drivers/auxdisplay/charlcd.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] dma-buf/sw_sync: fix document of sw_sync_create_fence_data

On Mon, Jan 15, 2018 at 11:47:59AM +0800, Shawn Guo wrote: > The structure should really be sw_sync_create_fence_data rather than > sw_sync_ioctl_create_fence which is the function name. > > Signed-off-by: Shawn Guo Applied, thanks for your patch. -Daniel > --- >

Re: [RFC PATCH 6/9] media: vb2: add support for requests in QBUF ioctl

On 01/15/2018 09:24 AM, Alexandre Courbot wrote: > On Fri, Jan 12, 2018 at 8:37 PM, Hans Verkuil wrote: >> On 12/15/17 08:56, Alexandre Courbot wrote: >>> Support the request argument of the QBUF ioctl. >>> >>> Signed-off-by: Alexandre Courbot >>> ---

Re: [RFC PATCH 5/9] media: vb2: add support for requests

On 01/15/2018 09:24 AM, Alexandre Courbot wrote: > On Fri, Jan 12, 2018 at 7:49 PM, Hans Verkuil wrote: >> On 12/15/17 08:56, Alexandre Courbot wrote: >>> Add throttling support for buffers when requests are in use on a given >>> queue. Buffers associated to a request are kept

Re: [RFC PATCH 0/9] media: base request API support

On 01/15/2018 09:24 AM, Alexandre Courbot wrote: > Hi Hans, > > On Fri, Jan 12, 2018 at 8:45 PM, Hans Verkuil wrote: >> Hi Alexandre, >> >> On 12/15/17 08:56, Alexandre Courbot wrote: >>> Here is a new attempt at the request API, following the UAPI we agreed on in >>> Prague.

Re: [RFC PATCH 5/9] media: vb2: add support for requests

On Fri, Jan 12, 2018 at 7:49 PM, Hans Verkuil wrote: > On 12/15/17 08:56, Alexandre Courbot wrote: >> Add throttling support for buffers when requests are in use on a given >> queue. Buffers associated to a request are kept into the vb2 queue until >> the request becomes

Re: [RFC PATCH 4/9] videodev2.h: Add request field to v4l2_buffer

On Fri, Jan 12, 2018 at 7:22 PM, Hans Verkuil wrote: > On 12/15/17 08:56, Alexandre Courbot wrote: >> From: Hans Verkuil >> >> When queuing buffers allow for passing the request ID that >> should be associated with this buffer. >> >> Signed-off-by:

Re: [RFC PATCH 0/9] media: base request API support

Hi Hans, On Fri, Jan 12, 2018 at 8:45 PM, Hans Verkuil wrote: > Hi Alexandre, > > On 12/15/17 08:56, Alexandre Courbot wrote: >> Here is a new attempt at the request API, following the UAPI we agreed on in >> Prague. Hopefully this can be used as the basis to move forward. >>

Re: [RFC PATCH 6/9] media: vb2: add support for requests in QBUF ioctl

On Fri, Jan 12, 2018 at 8:37 PM, Hans Verkuil wrote: > On 12/15/17 08:56, Alexandre Courbot wrote: >> Support the request argument of the QBUF ioctl. >> >> Signed-off-by: Alexandre Courbot >> --- >> drivers/media/v4l2-core/v4l2-ioctl.c | 93 >>

[PATCH] media: staging/imx: Checking the right variable in vdic_get_ipu_resources()

We recently changed this error handling around but missed this error pointer check. We're testing "priv->vdi_in_ch_n" instead of "ch" so the error handling can't be triggered. Fixes: 0b2e9e7947e7 ("media: staging/imx: remove confusing IS_ERR_OR_NULL usage") Signed-off-by: Dan Carpenter