Re: [PATCH] media: uvcvideo: Support realtek's UVC 1.5 device

On May 23, 2018, at 4:32 AM, Laurent Pinchart wrote: Hello, Thank you for the patch. On Wednesday, 9 May 2018 05:13:08 EEST ming_q...@realsil.com.cn wrote: From: ming_qian The length of UVC 1.5 video control is 48, and it id

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed May 23 05:00:14 CEST 2018 media-tree git hash:8ed8bba70b4355b1ba029b151ade84475dd12991 media_build

Re: [PATCH 3/4] venus: add check to make scm calls

Hi Stan, On 2018-05-23 02:27, Stanimir Varbanov wrote: Hi Jordan, On 22.05.2018 22:50, Jordan Crouse wrote: On Tue, May 22, 2018 at 04:04:51PM +0300, Stanimir Varbanov wrote: Hi Vikash, On 05/17/2018 02:32 PM, Vikash Garodia wrote: In order to invoke scm calls, ensure that the platform has

[PATCH 3/6] media: staging: atomisp: Remove useless "ifndef ISP2401"

In atomisp_csi2_set_ffmt(), there is no reason to have "#ifndef ISP2401" condition since code is identical in ifndef and else sections. Hence remove redudent checks. Signed-off-by: Pankaj Bharadiya ---

[PATCH 1/6] media: staging: atomisp: remove redundent check

Assignment asd = >asd[i] can never be null hence remove redundent check. Signed-off-by: Pankaj Bharadiya --- drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 6/6] media: staging: atomisp: Fix potential NULL pointer dereference

In verify_copy_out_frame_format(), "pipe" is being dereferenced before it is null checked. Fix it by moving the "pipe" pointer dereference after it has been properly null checked. Signed-off-by: Pankaj Bharadiya ---

[PATCH 2/6] media: staging: atomisp: Remove useless if statement

Local variable "requeue" is assigned only once to a constant "false" value so "if(requeue)" condition will never be true. Thus remove it. Signed-off-by: Pankaj Bharadiya --- drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c | 14 -- 1

[PATCH 4/6] media: staging: atomisp: Fix potential NULL pointer dereference

In ia_css_pipe_get_primary_binarydesc(), "pipe" is being dereferenced before it is null checked. Fix it by moving the "pipe" pointer dereference after it has been properly null checked. Signed-off-by: Pankaj Bharadiya ---

[PATCH 5/6] media: staging: atomisp: Fix potential NULL pointer dereference

In sh_css_config_input_network(), "stream" is being dereferenced before it is null checked. Fix it by moving the "stream" pointer dereference after it has been properly null checked. Signed-off-by: Pankaj Bharadiya ---

[PATCH 0/6] Fix issues reported by static analysis tool.

This patch series fixes some of the issues reported by static analysis tool. Pankaj Bharadiya (6): media: staging: atomisp: remove redundent check media: staging: atomisp: Remove useless if statement media: staging: atomisp: Remove useless "ifndef ISP2401" media: staging: atomisp: Fix

[PATCH v3 2/2] media: helene: support IF frequency of ISDB-S

This patch enhances maximum IF frequency to 2.072GHz of this tuner for supporting ISDB-S in Japan. Maimum RF center frequency of ISDB-S for right-handed circularly polarized. BSAT BS-23 12.14944GHz N-SAT-110 ND-24 12.731GHz Local frequency of BS/CS converter is typically 10.678GHz.

[PATCH v3 1/2] media: helene: add I2C device probe function

This patch adds I2C probe function to use dvb_module_probe() with this driver. Signed-off-by: Katsuhiro Suzuki --- Changes since v2: - Nothing Changes since v1: - Add documents for dvb_frontend member of helene_config ---

Re: [PATCH] media: dt-bindings: media: rcar_vin: add support for r8a77965

On Sun, May 13, 2018 at 08:58:18PM +0200, Niklas Söderlund wrote: > Signed-off-by: Niklas Söderlund > --- > Documentation/devicetree/bindings/media/rcar_vin.txt | 1 + > 1 file changed, 1 insertion(+) Acked-by: Rob Herring > > diff

Re: [PATCH 3/4] venus: add check to make scm calls

Hi Jordan, On 22.05.2018 22:50, Jordan Crouse wrote: On Tue, May 22, 2018 at 04:04:51PM +0300, Stanimir Varbanov wrote: Hi Vikash, On 05/17/2018 02:32 PM, Vikash Garodia wrote: In order to invoke scm calls, ensure that the platform has the required support to invoke the scm calls in secure

Re: [PATCH] media: rcar-vin: Drop unnecessary register properties from example vin port

On Wed, May 09, 2018 at 08:45:58PM +0200, Simon Horman wrote: > The example vin port node does not have an address and thus does not > need address-cells or address size-properties. > > Signed-off-by: Simon Horman > --- >

Re: [PATCH] media: uvcvideo: Support realtek's UVC 1.5 device

Hello, Thank you for the patch. On Wednesday, 9 May 2018 05:13:08 EEST ming_q...@realsil.com.cn wrote: > From: ming_qian > > The length of UVC 1.5 video control is 48, and it id 34 for UVC 1.1. > Change it to 48 for UVC 1.5 device, > and the UVC 1.5 device can be

Re: [PATCH v3] media: imx319: Add imx319 camera sensor driver

Hello Bingbu, thanks for the patch On Tue, May 22, 2018 at 12:33:01PM +0800, bingbu@intel.com wrote: > From: Bingbu Cao > > Add a V4L2 sub-device driver for the Sony IMX319 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for

Re: [PATCH v3 03/12] media: ov5640: Remove the clocks registers initialization

On Mon, May 21, 2018 at 09:39:02AM +0200, Maxime Ripard wrote: > On Fri, May 18, 2018 at 07:42:34PM -0700, Sam Bobrowicz wrote: > > On Fri, May 18, 2018 at 3:35 AM, Daniel Mack wrote: > > > On Thursday, May 17, 2018 10:53 AM, Maxime Ripard wrote: > > >> > > >> Part of the

Re: [PATCH 3/4] venus: add check to make scm calls

On Tue, May 22, 2018 at 04:04:51PM +0300, Stanimir Varbanov wrote: > Hi Vikash, > > On 05/17/2018 02:32 PM, Vikash Garodia wrote: > > In order to invoke scm calls, ensure that the platform > > has the required support to invoke the scm calls in > > secure world. This code is in preparation to add

Re: [PATCH] media: uvcvideo: Fix driver reference counting

Hi Philipp, Thank you for the patch. On Monday, 21 May 2018 13:24:58 EEST Philipp Zabel wrote: > kref_init initializes the reference count to 1, not 0. This additional > reference is never released since the conversion to reference counters. > As a result, uvc_delete is not called anymore when

Re: [Xen-devel] [RFC 1/3] xen/balloon: Allow allocating DMA buffers

On 05/22/2018 02:27 PM, Oleksandr Andrushchenko wrote: > On 05/22/2018 09:02 PM, Boris Ostrovsky wrote: >> On 05/22/2018 11:00 AM, Oleksandr Andrushchenko wrote: >>> On 05/22/2018 05:33 PM, Boris Ostrovsky wrote: On 05/22/2018 01:55 AM, Oleksandr Andrushchenko wrote: > On 05/21/2018 11:36

Re: [Xen-devel] [RFC 1/3] xen/balloon: Allow allocating DMA buffers

On 05/22/2018 09:02 PM, Boris Ostrovsky wrote: On 05/22/2018 11:00 AM, Oleksandr Andrushchenko wrote: On 05/22/2018 05:33 PM, Boris Ostrovsky wrote: On 05/22/2018 01:55 AM, Oleksandr Andrushchenko wrote: On 05/21/2018 11:36 PM, Boris Ostrovsky wrote: On 05/21/2018 03:13 PM, Oleksandr

Re: [Xen-devel] [RFC 1/3] xen/balloon: Allow allocating DMA buffers

On 05/22/2018 11:00 AM, Oleksandr Andrushchenko wrote: > On 05/22/2018 05:33 PM, Boris Ostrovsky wrote: >> On 05/22/2018 01:55 AM, Oleksandr Andrushchenko wrote: >>> On 05/21/2018 11:36 PM, Boris Ostrovsky wrote: On 05/21/2018 03:13 PM, Oleksandr Andrushchenko wrote: > On 05/21/2018 09:53

Re: [media] duplicate code in media drivers

On 05/21/2018 03:44 PM, Devin Heitmueller wrote: diff -u -p drivers/media/dvb-frontends/au8522_decoder.c /tmp/nothing/media/dvb-frontends/au8522_decoder.c --- drivers/media/dvb-frontends/au8522_decoder.c +++ /tmp/nothing/media/dvb-frontends/au8522_decoder.c @@ -280,14 +280,9 @@ static void

Re: [PATCH] media: video-mux: fix compliance failures

On 22/05/18 18:29, Philipp Zabel wrote: > Limit frame sizes to the [1, UINT_MAX-1] interval, media bus formats to > the available list of formats, and initialize pad and try formats. > > Reported-by: Rui Miguel Silva > Signed-off-by: Philipp Zabel >

Re: [PATCH v10 12/16] vb2: add in-fence support to QBUF

On Tue, 2018-05-22 at 18:48 +0200, Hans Verkuil wrote: > On 22/05/18 18:22, Ezequiel Garcia wrote: > > > > @@ -1615,7 +1762,12 @@ static void __vb2_dqbuf(struct vb2_buffer *vb) > > > > return; > > > > > > > > vb->state = VB2_BUF_STATE_DEQUEUED; > > > > - > > > > +

Re: [PATCH v4 0/3] IR decoding using BPF

Sean, I'd like to echo Matthias's appreciation for your work with this BPF project. I'm very much looking forward to the possibility of using my remotes directly with decoders generated from the existing lircd.conf's. Excited seeing your work progress! Cheers, Derek On Tue, May 22, 2018 at 6:50

Re: [PATCH] au8522: remove duplicate code

Reviewed-by: Devin Heitmueller Devin On Tue, May 22, 2018 at 1:09 PM, Gustavo A. R. Silva wrote: > This code has been there for nine years now, and it has been > working "good enough" since then [1]. > > Remove duplicate code by getting rid

[PATCH] au8522: remove duplicate code

This code has been there for nine years now, and it has been working "good enough" since then [1]. Remove duplicate code by getting rid of the if-else statement. [1] https://marc.info/?l=linux-kernel=152693550225081=2 Cc: Devin Heitmueller Signed-off-by: Gustavo A.

Re: [media] duplicate code in media drivers

Mauro, I already sent some patches based on your comments. Thanks! -- Gustavo On 05/21/2018 03:14 PM, Mauro Carvalho Chehab wrote: Em Mon, 21 May 2018 14:39:51 -0500 "Gustavo A. R. Silva" escreveu: Hi Mauro, I found some duplicate code with the help of Coccinelle

Re: [PATCH v10 12/16] vb2: add in-fence support to QBUF

On 22/05/18 18:22, Ezequiel Garcia wrote: >>> @@ -1615,7 +1762,12 @@ static void __vb2_dqbuf(struct vb2_buffer *vb) >>> return; >>> >>> vb->state = VB2_BUF_STATE_DEQUEUED; >>> - >>> + if (vb->in_fence) { >>> + if (dma_fence_remove_callback(vb->in_fence, >fence_cb))

[PATCH] media: dib0700: add code comment

Add FIXME code comment: /* FIXME: check if it is fe_adap[1] */ It is likely that it should be adap->fe_adap[1].fe in the second clause, but this has never been verified. Suggested-by: Mauro Carvalho Chehab Signed-off-by: Gustavo A. R. Silva ---

[PATCH] media: video-mux: fix compliance failures

Limit frame sizes to the [1, UINT_MAX-1] interval, media bus formats to the available list of formats, and initialize pad and try formats. Reported-by: Rui Miguel Silva Signed-off-by: Philipp Zabel --- drivers/media/platform/video-mux.c | 110

Re: [PATCH v10 12/16] vb2: add in-fence support to QBUF

On Tue, 2018-05-22 at 14:37 +0200, Hans Verkuil wrote: > On 21/05/18 18:59, Ezequiel Garcia wrote: > > From: Gustavo Padovan > > > > Receive in-fence from userspace and add support for waiting on them > > before queueing the buffer to the driver. Buffers can't be

[PATCH] media: dvb-bt8xx: remove duplicate code

The same code is executed regardless of whether c->frequency < 6 or c->frequency < 73000 is true. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/media/pci/bt8xx/dvb-bt8xx.c | 4 1 file changed, 4

Re: [PATCH v6 07/13] media: dt-bindings: add bindings for i.MX7 media driver

On Tue, May 22, 2018 at 03:52:39PM +0100, Rui Miguel Silva wrote: > Add bindings documentation for i.MX7 media drivers. > The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. > > Signed-off-by: Rui Miguel Silva > --- > .../devicetree/bindings/media/imx7-csi.txt| 44

Re: [PATCH v10 11/16] vb2: add explicit fence user API

On Tue, 2018-05-22 at 14:05 +0200, Hans Verkuil wrote: > On 21/05/18 18:59, Ezequiel Garcia wrote: > > From: Gustavo Padovan > > > > Turn the reserved2 field into fence_fd that we will use to send > > an in-fence to the kernel or return an out-fence from the kernel

Re: [PATCH 4/4] media: venus: add PIL support

Hi, On 05/22/2018 04:02 PM, Stanimir Varbanov wrote: > Hi Vikash, > > On 05/17/2018 02:32 PM, Vikash Garodia wrote: >> This adds support to load the video firmware >> and bring ARM9 out of reset. This is useful >> for platforms which does not have trustzone >> to reset the ARM9. >> >>

Re: [PATCH v2 3/4] media: rcar-vin: Handle CLOCKENB pin polarity

Hi Jacopo, Thanks for your patch. On 2018-05-21 19:27:42 +0200, Jacopo Mondi wrote: > Handle CLOCKENB pin polarity, or use HSYNC in its place if polarity is > not specified and we're running on parallel data bus with explicit > synchronism signals. > > While at there, simplify the media bus

Re: [PATCH v2 2/4] dt-bindings: media: rcar-vin: Document data-active

Hi Jacopo, Thanks for your patch. On 2018-05-21 19:27:41 +0200, Jacopo Mondi wrote: > Document 'data-active' property in R-Car VIN device tree bindings. > > Signed-off-by: Jacopo Mondi > > v1 -> v2: > - HSYNC is used in place of data enable signal only when running

Re: [PATCH v2 1/4] dt-bindings: media: rcar-vin: Describe optional ep properties

Hi Jacopo, Thanks for your patch. On 2018-05-21 19:27:40 +0200, Jacopo Mondi wrote: > Describe the optional properties for endpoint nodes of port@0 > and port@1 of the R-Car VIN driver device tree bindings documentation. > > Signed-off-by: Jacopo Mondi > Acked-by:

Re: [Xen-devel] [RFC 1/3] xen/balloon: Allow allocating DMA buffers

On 05/22/2018 05:33 PM, Boris Ostrovsky wrote: On 05/22/2018 01:55 AM, Oleksandr Andrushchenko wrote: On 05/21/2018 11:36 PM, Boris Ostrovsky wrote: On 05/21/2018 03:13 PM, Oleksandr Andrushchenko wrote: On 05/21/2018 09:53 PM, Boris Ostrovsky wrote: On 05/21/2018 01:32 PM, Oleksandr

[PATCH v6 09/13] ARM: dts: imx7s: add multiplexer controls

The IOMUXC General Purpose Register has bitfield to control video bus multiplexer to control the CSI input between the MIPI-CSI2 and parallel interface. Add that register and mask. Signed-off-by: Rui Miguel Silva Reviewed-by: Philipp Zabel ---

[PATCH v6 11/13] ARM: dts: imx7s-warp: add ov2680 sensor node

Warp7 comes with a Omnivision OV2680 sensor, add the node here to make complete the camera data path for this system. Add the needed regulator to the analog voltage supply, the port and endpoints in mipi_csi node and the pinctrl for the reset gpio. Signed-off-by: Rui Miguel Silva

[PATCH v6 12/13] media: imx7.rst: add documentation for i.MX7 media driver

Add rst document to describe the i.MX7 media driver and also a working example from the Warp7 board usage with a OV2680 sensor. Signed-off-by: Rui Miguel Silva --- Documentation/media/v4l-drivers/imx7.rst | 157 ++

[PATCH v6 13/13] media: staging/imx: add i.MX7 entries to TODO file

Add some i.MX7 related entries to TODO file. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/TODO | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/media/imx/TODO b/drivers/staging/media/imx/TODO index aeeb15494a49..6f29b5ca5324

[PATCH v6 10/13] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

This patch adds the device tree nodes for csi, video multiplexer and mipi-csi besides the graph connecting the necessary endpoints to make the media capture entities to work in imx7 Warp board. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s-warp.dts | 51

[PATCH v6 07/13] media: dt-bindings: add bindings for i.MX7 media driver

Add bindings documentation for i.MX7 media drivers. The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva --- .../devicetree/bindings/media/imx7-csi.txt| 44 ++ .../bindings/media/imx7-mipi-csi2.txt | 82 +++

[PATCH v6 08/13] ARM: dts: imx7s: add mipi phy power domain

Add power domain index 0 related with mipi-phy to imx7s. While at it rename pcie power-domain node to remove pgc prefix. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH v6 06/13] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI CSI-2 interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Makefile |1 + drivers/staging/media/imx/imx7-mipi-csis.c | 1134 2 files changed, 1135

[PATCH v6 05/13] clk: imx7d: reset parent for mipi csi root

To guarantee that we do not get Overflow in image FIFO the outer bandwidth has to be faster than inputer bandwidth. For that it must be possible to set a faster frequency clock. So set new parent to sys_pfd3 clock for the mipi csi block. Acked-by: Shawn Guo Signed-off-by:

[PATCH v6 03/13] media: staging/imx7: add imx7 CSI subdev driver

This add the media entity subdevice and control driver for the i.MX7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Kconfig |9 +- drivers/staging/media/imx/Makefile |2 +

[PATCH v6 04/13] clk: imx7d: fix mipi dphy div parent

Fix the mipi dphy root divider to mipi_dphy_pre_div, this would remove a orphan clock and set the correct parent. before: cat clk_orphan_summary enable prepare protect clock countcountcountrate accuracy phase

[PATCH v6 02/13] media: staging/imx: rearrange group id to take in account IPU

Some imx system do not have IPU, so prepare the imx media drivers to support this kind of devices. Rename the group ids to include an _IPU_ prefix, add a new group id to support systems with only a CSI without IPU, and also rename the create internal links to make it clear that only systems with

[PATCH v6 01/13] media: staging/imx: refactor imx media device probe

Refactor and move media device initialization code to a new common module, so it can be used by other devices, this will allow for example a near to introduce imx7 CSI driver, to use this media device. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Makefile

[PATCH v6 00/13] media: staging/imx7: add i.MX7 media driver

Hi, This series introduces the Media driver to work with the i.MX7 SoC. it uses the already existing imx media core drivers but since the i.MX7, contrary to i.MX5/6, do not have an IPU and because of that some changes in the imx media core are made along this series to make it support that case.

Re: cron job: media_tree daily build: ERRORS

On 22/05/18 16:26, Jasmin J. wrote: > Hello Hans! > >> linux-4.9.91-x86_64: ERRORS >> /home/hans/work/build/media_build/v4l/dw9807.c:321:3: error > The build works in my tree ... ?!? > I can't find the file in media_tree: >find . -name "*9807*" > > Can you please check if there is something

Re: [Xen-devel] [RFC 1/3] xen/balloon: Allow allocating DMA buffers

On 05/22/2018 01:55 AM, Oleksandr Andrushchenko wrote: > On 05/21/2018 11:36 PM, Boris Ostrovsky wrote: >> On 05/21/2018 03:13 PM, Oleksandr Andrushchenko wrote: >>> On 05/21/2018 09:53 PM, Boris Ostrovsky wrote: On 05/21/2018 01:32 PM, Oleksandr Andrushchenko wrote: > On 05/21/2018 07:35

Re: cron job: media_tree daily build: ERRORS

Hello Hans! > linux-4.9.91-x86_64: ERRORS > /home/hans/work/build/media_build/v4l/dw9807.c:321:3: error The build works in my tree ... ?!? I can't find the file in media_tree: find . -name "*9807*" Can you please check if there is something wrong with your media_tree version which is used for

Re: [PATCH v4 06/12] media: dt-bindings: add bindings for i.MX7 media driver

On Tue, May 22, 2018 at 02:19:21PM +0100, Rui Miguel Silva wrote: > Hi Sakari, > On Fri 18 May 2018 at 22:13, Sakari Ailus wrote: > > On Fri, May 18, 2018 at 09:27:58AM +0100, Rui Miguel Silva wrote: > > > > > +endpoint node > > > > > +- > > > > > + > > > > > +- data-lanes:

Re: [PATCH] media: pxa_camera: avoid duplicate s_power calls

Dear Mita-san, On Mon, May 21, 2018 at 12:40:38AM +0900, Akinobu Mita wrote: > The open() operation for the pxa_camera driver always calls s_power() > operation to put its subdevice sensor in normal operation mode, and the > release() operation always call s_power() operation to put the subdevice

Re: [PATCH v4 0/3] IR decoding using BPF

Hi Sean, On Fri, May 18, 2018 at 03:07:27PM +0100, Sean Young wrote: > The kernel IR decoders (drivers/media/rc/ir-*-decoder.c) support the most > widely used IR protocols, but there are many protocols which are not > supported[1]. For example, the lirc-remotes[2] repo has over 2700 remotes, >

Re: [PATCH v4 06/12] media: dt-bindings: add bindings for i.MX7 media driver

Hi Sakari, On Fri 18 May 2018 at 22:13, Sakari Ailus wrote: On Fri, May 18, 2018 at 09:27:58AM +0100, Rui Miguel Silva wrote: > > +endpoint node > > +- > > + > > +- data-lanes: (required) an array specifying active > > physical > > MIPI-CSI2 > > + data input lanes and

Re: [PATCH 3/4] venus: add check to make scm calls

Hi Vikash, On 05/17/2018 02:32 PM, Vikash Garodia wrote: > In order to invoke scm calls, ensure that the platform > has the required support to invoke the scm calls in > secure world. This code is in preparation to add PIL > functionality in venus driver. > > Signed-off-by: Vikash Garodia

Re: [PATCH 4/4] media: venus: add PIL support

Hi Vikash, On 05/17/2018 02:32 PM, Vikash Garodia wrote: > This adds support to load the video firmware > and bring ARM9 out of reset. This is useful > for platforms which does not have trustzone > to reset the ARM9. > > Signed-off-by: Vikash Garodia > --- >

Re: [PATCH v10 13/16] vb2: add out-fence support to QBUF

On 21/05/18 18:59, Ezequiel Garcia wrote: > From: Gustavo Padovan > > If V4L2_BUF_FLAG_OUT_FENCE flag is present on the QBUF call we create > an out_fence and send its fd to userspace in the fence_fd field as a > return arg for the QBUF call. > > The fence is

Re: [PATCH v10 12/16] vb2: add in-fence support to QBUF

On 21/05/18 18:59, Ezequiel Garcia wrote: > From: Gustavo Padovan > > Receive in-fence from userspace and add support for waiting on them > before queueing the buffer to the driver. Buffers can't be queued to the > driver before its fences signal. And a buffer

Re: [PATCH v10 11/16] vb2: add explicit fence user API

On 21/05/18 18:59, Ezequiel Garcia wrote: > From: Gustavo Padovan > > Turn the reserved2 field into fence_fd that we will use to send > an in-fence to the kernel or return an out-fence from the kernel to > userspace. > > Two new flags were added,

Re: [PATCH v10 09/16] cobalt: add .is_unordered() for cobalt

On 21/05/18 18:59, Ezequiel Garcia wrote: > From: Gustavo Padovan > > The cobalt driver may reorder the capture buffers so we need to report > it as such. > > v3: set formats as unordered > v2: use vb2_ops_set_unordered() helper > > Signed-off-by: Gustavo Padovan

Re: [PATCH v10 08/16] v4l: mark unordered formats

On 21/05/18 18:59, Ezequiel Garcia wrote: > From: Gustavo Padovan > > Now that we've introduced the V4L2_FMT_FLAG_UNORDERED flag, > mark the appropriate formats. > > v2: Set unordered flag before calling the driver callback. > > Signed-off-by: Gustavo Padovan

Re: [PATCH 2/2] adv7511: fix incorrect clear of CEC receive interrupt

On 22/05/18 13:33, Hans Verkuil wrote: > From: Hans Verkuil > > If a CEC message was received and the RX interrupt was set, but > not yet processed, and a new transmit was issues, then the issues -> issued > transmit code would inadvertently clear the RX interrupt and >

[PATCH 0/2] cec: two CEC bugs, one in core, one in adv7511

From: Hans Verkuil The first patch fixes an inconsistency in the cec core code where wrong status information could be returned if a cec message was canceled. The second patch fixes a CEC adv7511 bug. Regards, Hans Hans Verkuil (2): cec: fix wrong

[PATCH 2/2] adv7511: fix incorrect clear of CEC receive interrupt

From: Hans Verkuil If a CEC message was received and the RX interrupt was set, but not yet processed, and a new transmit was issues, then the transmit code would inadvertently clear the RX interrupt and after that no new messages would ever be received. Instead it should

[PATCH 1/2] cec: fix wrong tx/rx_status values when canceling a msg

From: Hans Verkuil When a message was canceled it could return tx_status with both OK and MAX_RETRIES set, which is illegal. If a canceled message was waiting for a reply, then rx_status wasn't updated, so set that as well. Signed-off-by: Hans Verkuil

Re: [PATCH] gpu: ipu-v3: Fix BT1120 interlaced CCIR codes

Hi Marek, On Fri, 2018-05-18 at 18:21 +0200, Marek Vasut wrote: > On 05/18/2018 05:51 PM, Philipp Zabel wrote: > > Hi Marek, > > > > On Sat, 2018-04-07 at 15:04 +0200, Marek Vasut wrote: > > > The BT1120 interlaced CCIR codes are the same as BT656 ones > > > and different than BT656 progressive

Re: [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header

Hi Simon, On Tue, May 22, 2018 at 11:05 AM, Simon Horman wrote: >> --- a/drivers/media/platform/vsp1/vsp1_regs.h >> +++ b/drivers/media/platform/vsp1/vsp1_regs.h >> @@ -1,4 +1,4 @@ >> -/* SPDX-License-Identifier: GPL-2.0 */ >> +/* SPDX-License-Identifier: GPL-2.0+ */ > >

Re: i.MX6 IPU CSI analog video input on Ventana

Hi, Steve Longerbeam writes: > Hi Krzysztof, I've been on vacation, just returned today. I will > find the time this week to attempt to reproduce your results on > a SabreAuto quad with the adv7180. Great. Please let me know if I can assist you somehow. > Btw, if you

[GIT PULL for 4.18] More sensor driver patches

Hi Mauro, Here's another set of sensro driver patches for 4.18. There's DT support for the ov772x sensors as well as a new driver for imx258. Please pull. The following changes since commit 8ed8bba70b4355b1ba029b151ade84475dd12991: media: imx274: remove non-indexed pointers from mode_table

Re: [PATCHv3 1/5] videobuf2-core: don't call memop 'finish' when queueing

On 22/05/18 11:35, Sakari Ailus wrote: > Hi Hans, > > On Tue, May 22, 2018 at 10:14:47AM +0200, Hans Verkuil wrote: >> From: Hans Verkuil >> >> When a buffer is queued or requeued in vb2_buffer_done, then don't >> call the finish memop. In this case the buffer is only

Re: ir-keytable protocol setup broken and no ir events

On Mon, May 21, 2018 at 11:37:10AM +0300, just me wrote: > Package: ir-keytable > Version: 1.14.2-1, 1.12.3-1 > System: > Host: ryzenpc Kernel: 4.16.0-rc7+ x86_64 bits: 64 Desktop: Xfce > 4.12.4 Distro: Debian GNU/Linux buster/sid > > I have 3 usb dvb-t sticks: Alink DTU ( driver

Re: i.MX6 IPU CSI analog video input on Ventana

Hey, * Krzysztof Hałasa, 2018-05-21 10:09: > I wonder... perhaps to get an interlaced frame I need to route the data > through VDIC (ipu2_vdic, the deinterlacer)? I have the same problem here, though not investigated nearly as thoroughly as you did, down to the IPU register values. But I also

Re: [PATCHv3 1/5] videobuf2-core: don't call memop 'finish' when queueing

Hi Hans, On Tue, May 22, 2018 at 10:14:47AM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > When a buffer is queued or requeued in vb2_buffer_done, then don't > call the finish memop. In this case the buffer is only returned to vb2, > not to userspace. > > Calling

Re: [PATCH 06/20] omap4iss: Add video_device and vb2_queue locks

On 18/05/18 20:51, Ezequiel Garcia wrote: > video_device and vb2_queue locks are now both > mandatory. Add them, remove driver ad-hoc locks, > and implement wait_{prepare, finish}. > > To stay on the safe side, this commit uses a single mutex > for both locks. Better latency can be obtained by

Re: [PATCH v2] v4l: vsp1: Fix vsp1_regs.h license header

On Sun, May 20, 2018 at 10:24:37AM +0300, Laurent Pinchart wrote: > All source files of the vsp1 driver are licensed under the GPLv2+ except > for vsp1_regs.h which is licensed under GPLv2. This is caused by a bad > copy that dates back from the initial version of the driver. Fix > it. > > Cc:

Re: [PATCH v4 3/5] mfd: cros-ec: Introduce CEC commands and events definitions.

Hi Neil, 2018-05-21 16:21 GMT+02:00 Neil Armstrong : > The EC can expose a CEC bus, this patch adds the CEC related definitions > needed by the cros-ec-cec driver. > Having a 16 byte mkbp event size makes it possible to send CEC > messages from the EC to the AP directly

Re: [PATCH 5/6] ARM: dts: rcar-gen2: Remove unused VIN properties

On Thu, May 17, 2018 at 11:01:10AM +0200, jacopo mondi wrote: > Hi Niklas, > > On Thu, May 17, 2018 at 12:13:07AM +0200, Niklas Söderlund wrote: > > Hi Jacopo, > > > > Thanks for your work. > > > > On 2018-05-16 18:32:31 +0200, Jacopo Mondi wrote: > > > The 'bus-width' and 'pclk-sample'

Re: [PATCHv2 0/4] gspca: convert to vb2gspca: convert to vb2

On 18/05/18 19:51, Ezequiel Garcia wrote: > On 13 May 2018 at 06:47, Hans Verkuil wrote: >> From: Hans Verkuil >> >> The first patch converts the gspca driver to the vb2 framework. >> It was much easier to do than I expected and it saved almost 600 >>

[PATCHv3 2/5] gspca: convert to vb2

From: Hans Verkuil Signed-off-by: Hans Verkuil Reviewed-by: Hans de Goede --- drivers/media/usb/gspca/Kconfig| 1 + drivers/media/usb/gspca/gspca.c| 906 -

[PATCHv3 4/5] v4l2-ioctl: clear fields in s_parm

From: Hans Verkuil Zero the reserved capture/output array. Zero the extendedmode (it is never used in drivers). Clear all flags in capture/outputmode except for V4L2_MODE_HIGHQUALITY, as that is the only valid flag. Signed-off-by: Hans Verkuil

[PATCHv3 3/5] gspca: fix g/s_parm handling

From: Hans Verkuil Fix v4l2-compliance error: s_parm never set V4L2_CAP_TIMEPERFRAME. Also various g/s_parm-related cleanups. Signed-off-by: Hans Verkuil Reviewed-by: Hans de Goede --- drivers/media/usb/gspca/gspca.c | 29

[PATCHv3 0/5] gspca: convert to vb2gspca: convert to vb2

From: Hans Verkuil The first patch fixes a bug in videobuf2-core.c: the finish memop should not be called when vb2_buffer_done is called with state QUEUED or REQUEUEING. Doing so leads to one finish too many and an 'UNBALANCED' error is logged. Discovered since some of

[PATCHv3 1/5] videobuf2-core: don't call memop 'finish' when queueing

From: Hans Verkuil When a buffer is queued or requeued in vb2_buffer_done, then don't call the finish memop. In this case the buffer is only returned to vb2, not to userspace. Calling 'finish' here will cause an unbalance when the queue is canceled, since the core will

[PATCHv3 5/5] v4l2-ioctl: delete unused v4l2_disable_ioctl_locking

From: Hans Verkuil The last user of this 'feature' was the gspca driver. Now that that driver has been converted to vb2 we can delete this code. Signed-off-by: Hans Verkuil Reviewed-by: Hans de Goede ---