Re: [RFC PATCH v2] media: i2c: add SCCB helpers

2018-06-14 Thread Wolfram Sang
> > It sounds tempting, yet I am concerned about regressions. From that > > point of view, it is safer to introduce i2c_lock_segment() and convert the > > users which would benefit from that. How many drivers would be affected? > > Right, there is also the aspect that changing a function like thi

Re: [RFC PATCH v2] media: i2c: add SCCB helpers

2018-06-14 Thread Peter Rosin
On 2018-06-14 17:41, Wolfram Sang wrote: > >> So, maybe the easier thing to do is change i2c_lock_adapter to only >> lock the segment, and then have the callers beneath drivers/i2c/ >> (plus the above mlx90614 driver) that really want to lock the root >> adapter instead of the segment adapter call

cron job: media_tree daily build: OK

2018-06-14 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Jun 15 05:00:18 CEST 2018 media-tree git hash:f2809d20b9250c675fca8268a0f6274277cca7ff media_build gi

Re: [PATCH v1 2/2] v4l: Document Intel IPU3 meta data uAPI

2018-06-14 Thread kbuild test robot
Hi Yong, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.17 next-20180614] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Yong

Re: [PATCH v4 2/2] media: ak7375: Add ak7375 lens voice coil driver

2018-06-14 Thread Bing Bu Cao
On 2018年06月14日 21:02, Sakari Ailus wrote: > Hi Bingbu, > > Thanks for the update. A few comments below; then I think we're done... > > On Thu, Jun 07, 2018 at 11:50:33AM +0800, bingbu@intel.com wrote: >> From: Bingbu Cao >> >> Add a v4l2 sub-device driver for the ak7375 lens voice coil. >>

[PATCH v1 0/2] Document Intel IPU3 ImgU driver and uAPI

2018-06-14 Thread Yong Zhi
Hi, All, This patch set adds documentation on Intel IPU3 ImgU driver and its uAPI, based on the feedback received for v1 RFC below and ImgU driver patch series: v1 RFC: https://patchwork.kernel.org/patch/10321897/> ImgU v6: https://patchwork.kernel.org/patch/10316739/> Few unused structs have b

[PATCH v1 1/2] doc-rst: Add Intel IPU3 documentation

2018-06-14 Thread Yong Zhi
From: Rajmohan Mani This patch adds the details about the IPU3 Imaging Unit driver. Signed-off-by: Rajmohan Mani Signed-off-by: Tian Shu Qiu --- Documentation/media/v4l-drivers/index.rst | 1 + Documentation/media/v4l-drivers/ipu3.rst | 304 ++ 2 files changed,

[PATCH v1 2/2] v4l: Document Intel IPU3 meta data uAPI

2018-06-14 Thread Yong Zhi
These meta formats are used on Intel IPU3 ImgU video queues to carry 3A statistics and ISP pipeline parameters. V4L2_META_FMT_IPU3_3A V4L2_META_FMT_IPU3_PARAMS Signed-off-by: Yong Zhi Signed-off-by: Chao C Li Signed-off-by: Rajmohan Mani --- Documentation/media/uapi/v4l/meta-formats.rst

Re: [PATCH] gpu: ipu-v3: Allow negative offsets for interlaced scanning

2018-06-14 Thread Steve Longerbeam
Hi Krzysztof, On 06/14/2018 02:39 AM, Krzysztof Hałasa wrote: Reporting from the field :-) The fix-csi-interlaced.3 branch is still a bit off the track I guess: Yes, it's still a WIP. A couple things are remaining: - fix interweave with negative offsets for planar pixel formats. - update th

Re: [RFC PATCH v2] media: i2c: add SCCB helpers

2018-06-14 Thread Wolfram Sang
> So, maybe the easier thing to do is change i2c_lock_adapter to only > lock the segment, and then have the callers beneath drivers/i2c/ > (plus the above mlx90614 driver) that really want to lock the root > adapter instead of the segment adapter call a new function named > i2c_lock_root (or somet

[PATCH 1/3] mem2mem: Remove unused v4l2_m2m_ops .lock/.unlock

2018-06-14 Thread Ezequiel Garcia
Commit f1a81afc98e3 ("[media] m2m: fix bad unlock balance") removed the last use of v4l2_m2m_ops.lock and v4l2_m2m_ops.unlock hooks. They are not actually used anymore. Remove them. Signed-off-by: Ezequiel Garcia --- drivers/media/platform/coda/coda-common.c | 26 --

[PATCH 2/3] mem2mem: Make .job_abort optional

2018-06-14 Thread Ezequiel Garcia
Implementing job_abort() does not make sense on some drivers. This is not a problem, as the abort is not required to wait for the job to finish. Quite the opposite, drivers are encouraged not to wait. Demote v4l2_m2m_ops.job_abort from required to optional, and clean all drivers with dummy or wron

[PATCH 0/3] mem2mem low-hanging fruit removal

2018-06-14 Thread Ezequiel Garcia
While working with memory-to-memory drivers, noticed some minor cleaning opportunities. First, the lock/unlock v4l2_m2m_ops are no longer in use, and can be dropped. Second, the job_abort v4l2_m2m_ops is not really used by some drivers, and so it makes sense to make it optional. This series is b

[PATCH 3/3] rcar_vpu: Drop unneeded job_ready

2018-06-14 Thread Ezequiel Garcia
It is not required to implement job_ready(). Since this one is dummy, we can drop it. Signed-off-by: Ezequiel Garcia --- drivers/media/platform/rcar_jpu.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/media/platform/rcar_jpu.c b/drivers/media/platform/rcar_jpu.c index 10d24dd

Re: [RFC PATCH v2] media: i2c: add SCCB helpers

2018-06-14 Thread Wolfram Sang
On Wed, Jun 13, 2018 at 12:34:46AM +0900, Akinobu Mita wrote: > (This is 2nd version of SCCB helpers patch. After 1st version was > submitted, I sent alternative patch titled "i2c: add I2C_M_FORCE_STOP". > But it wasn't accepted because it makes the I2C core code unreadable. > I couldn't find out

Re: [PATCH v3 02/14] drivers: soc: sunxi: Add dedicated compatibles for the A13, A20 and A33

2018-06-14 Thread Paul Kocialkowski
Hi, On Fri, 2018-05-11 at 12:20 +0200, Maxime Ripard wrote: > On Thu, May 10, 2018 at 10:05:33PM -0700, Chen-Yu Tsai wrote: > > On Mon, May 7, 2018 at 5:44 AM, Paul Kocialkowski > > wrote: > > > This introduces platform-specific compatibles for the A13, A20 and A33 > > > SRAM driver. No particula

Re: [PATCH v4 2/2] media: ak7375: Add ak7375 lens voice coil driver

2018-06-14 Thread Sakari Ailus
Hi Bingbu, Thanks for the update. A few comments below; then I think we're done... On Thu, Jun 07, 2018 at 11:50:33AM +0800, bingbu@intel.com wrote: > From: Bingbu Cao > > Add a v4l2 sub-device driver for the ak7375 lens voice coil. > This is a voice coil module using the i2c bus to control

[PATCH v3 0/2] Support rotation property for smia sensors

2018-06-14 Thread Sakari Ailus
Hi folks, This is an earlier patch "smiapp: Support the "upside-down" property" split into two -- the DT binding change and a driver change. The only change is in DT bindings --- an added reference to video-interfaces.txt in rotation property documentation. Sakari Ailus (2): dt-bindings: smia:

[PATCH v3 2/2] smiapp: Support the "rotation" property

2018-06-14 Thread Sakari Ailus
Use the "rotation" property to tell that the sensor is mounted upside down. This reverses the behaviour of the VFLIP and HFLIP controls as well as the pixel order. Signed-off-by: Sakari Ailus Reviewed-by: Sebastian Reichel --- drivers/media/i2c/smiapp/smiapp-core.c | 16 1 file

[PATCH v3 1/2] dt-bindings: smia: Add "rotation" property

2018-06-14 Thread Sakari Ailus
Add the rotation property to list of optional properties for the smia sensors. Signed-off-by: Sakari Ailus Reviewed-by: Sebastian Reichel Acked-by: Rob Herring --- Documentation/devicetree/bindings/media/i2c/nokia,smia.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/de

Re: [PATCH] gpu: ipu-v3: Allow negative offsets for interlaced scanning

2018-06-14 Thread Krzysztof Hałasa
Reporting from the field :-) The fix-csi-interlaced.3 branch is still a bit off the track I guess: media-ctl -V "'adv7180 2-0020':0 [fmt:UYVY2X8/576 field:seq-tb]" media-ctl -V "'ipu2_csi1_mux':2 [fmt:UYVY2X8/720x576]" media-ctl -V "'ipu2_csi1':2 [fmt:AYUV32/720x576 field:interlaced-tb]"