cron job: media_tree daily build: ERRORS

2018-07-02 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Jul 3 05:00:13 CEST 2018 media-tree git hash:3c4a737267e89aafa6308c6c456d2ebea3fcd085 media_build

Re: [PATCH v6 04/17] omap3isp: Add vb2_queue lock

2018-07-02 Thread Laurent Pinchart
Hi Ezequiel, (CC'ing Sakari) Thank you for the patch. On Friday, 22 June 2018 06:53:58 EEST Ezequiel Garcia wrote: > vb2_queue locks is now mandatory. Add it, remove driver ad-hoc locks, > and implement wait_{prepare, finish}. > > Also, remove stream_lock mutex. Since the ioctls operations >

[GIT PULL FOR v4.19] Various fixes/improvements

2018-07-02 Thread Hans Verkuil
Fix a long-standing bug in v4l2-ctrls.c, mark all interface links as IMMUTABLE and add helpers to configure an MC for mem-to-mem devices and use that in vim2m. Note regarding the v4l2-ctrls.c fix: I've decided not to backport this. It's a dark corner of the spec that few people use and that

[PATCH v5 0/2] Memory-to-memory media controller topology

2018-07-02 Thread Ezequiel Garcia
As discussed on IRC, memory-to-memory need to be modeled properly in order to be supported by the media controller framework, and thus to support the Request API. First commit introduces a register/unregister API, that creates/destroys all the entities and pads needed, and links them. The second

[PATCH v5 1/2] media: add helpers for memory-to-memory media controller

2018-07-02 Thread Ezequiel Garcia
A memory-to-memory pipeline device consists in three entities: two DMA engine and one video processing entities. The DMA engine entities are linked to a V4L interface. This commit add a new v4l2_m2m_{un}register_media_controller API to register this topology. For instance, a typical mem2mem

[PATCH v5 2/2] vim2m: add media device

2018-07-02 Thread Ezequiel Garcia
From: Hans Verkuil Request API requires a media node. Add one to the vim2m driver so we can use requests with it. Signed-off-by: Hans Verkuil Signed-off-by: Ezequiel Garcia --- drivers/media/platform/vim2m.c | 41 ++ 1 file changed, 37 insertions(+), 4

Re: [PATCHv15 07/35] v4l2-dev: lock req_queue_mutex

2018-07-02 Thread Hans Verkuil
On 02/07/18 15:06, Tomasz Figa wrote: > Hi Hans, > > On Mon, Jun 4, 2018 at 8:48 PM Hans Verkuil wrote: > [snip] >> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c >> b/drivers/media/v4l2-core/v4l2-ioctl.c >> index 965fd301f617..27a893aa0664 100644 >> ---

Re: [PATCHv15 07/35] v4l2-dev: lock req_queue_mutex

2018-07-02 Thread Tomasz Figa
Hi Hans, On Mon, Jun 4, 2018 at 8:48 PM Hans Verkuil wrote: [snip] > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c > b/drivers/media/v4l2-core/v4l2-ioctl.c > index 965fd301f617..27a893aa0664 100644 > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c >

Re: [PATCHv15 06/35] v4l2-device.h: add v4l2_device_supports_requests() helper

2018-07-02 Thread Sakari Ailus
On Mon, Jun 04, 2018 at 01:46:19PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > Add a simple helper function that tests if the driver supports > the request API. > > Signed-off-by: Hans Verkuil Acked-by: Sakari Ailus -- Sakari Ailus e-mail: sakari.ai...@iki.fi

Re: [PATCH 1/2] media: i2c: ov5640: Re-work MIPI start sequence

2018-07-02 Thread Maxime Ripard
On Fri, Jun 29, 2018 at 06:42:39PM +0200, Jacopo Mondi wrote: > From: Jacopo Mondi > > Change the MIPI CSI-2 interface startup sequence to the following: > > Initialization: > 0x3019 = 0x70 : Lane1, Lane2 and clock in LP11 when in 'sleep mode' > 0x300e = 0x58 : 2 lanes mode, power down TX and

Re: [PATCH] media: mark entity-intf links as IMMUTABLE

2018-07-02 Thread Sakari Ailus
On Mon, Jul 02, 2018 at 02:43:02PM +0200, Hans Verkuil wrote: > Currently links between entities and an interface are just marked as > ENABLED. But (at least today) these links cannot be disabled by userspace > or the driver, so they should also be marked as IMMUTABLE. > > It might become

[PATCH] media: mark entity-intf links as IMMUTABLE

2018-07-02 Thread Hans Verkuil
Currently links between entities and an interface are just marked as ENABLED. But (at least today) these links cannot be disabled by userspace or the driver, so they should also be marked as IMMUTABLE. It might become possible that drivers can disable such links (if for some reason the device

Re: [PATCHv15 05/35] media-request: add media_request_object_find

2018-07-02 Thread Hans Verkuil
On 02/07/18 14:33, Tomasz Figa wrote: > Hi Hans, > On Mon, Jun 4, 2018 at 8:48 PM Hans Verkuil wrote: >> >> From: Hans Verkuil >> >> Add media_request_object_find to find a request object inside a >> request based on ops and/or priv values. > > Current code seems to always find based on both

Re: [PATCHv15 05/35] media-request: add media_request_object_find

2018-07-02 Thread Tomasz Figa
Hi Hans, On Mon, Jun 4, 2018 at 8:48 PM Hans Verkuil wrote: > > From: Hans Verkuil > > Add media_request_object_find to find a request object inside a > request based on ops and/or priv values. Current code seems to always find based on both ops and priv values. Best regards, Tomasz

Re: [RFC] Make entity to interface links immutable

2018-07-02 Thread Mauro Carvalho Chehab
Em Mon, 2 Jul 2018 12:38:23 +0200 Hans Verkuil escreveu: > On 02/07/18 11:41, Mauro Carvalho Chehab wrote: > > Em Mon, 2 Jul 2018 10:18:37 +0200 > > Hans Verkuil escreveu: > > > >> While working on v4l2-compliance I noticed that entity to interface links > >> have just the

Re: [PATCHv15 02/35] media-request: implement media requests

2018-07-02 Thread Hans Verkuil
On 02/07/18 12:56, Tomasz Figa wrote: > Hi Hans, > > On Mon, Jun 4, 2018 at 8:47 PM Hans Verkuil wrote: > [snip] >> +static void media_request_object_release(struct kref *kref) >> +{ >> + struct media_request_object *obj = >> + container_of(kref, struct media_request_object,

Re: [PATCHv15 02/35] media-request: implement media requests

2018-07-02 Thread Tomasz Figa
On Mon, Jul 2, 2018 at 6:11 PM Hans Verkuil wrote: > > On 02/07/18 10:58, Tomasz Figa wrote: > > Hi Hans, > > > > On Fri, Jun 15, 2018 at 4:09 PM Hans Verkuil wrote: > >> > >> On 04/06/18 13:46, Hans Verkuil wrote: > >>> From: Hans Verkuil > >>> > >>> Add initial media request support: > >>> >

Re: [PATCHv15 02/35] media-request: implement media requests

2018-07-02 Thread Tomasz Figa
Hi Hans, On Mon, Jun 4, 2018 at 8:47 PM Hans Verkuil wrote: [snip] > +static void media_request_object_release(struct kref *kref) > +{ > + struct media_request_object *obj = > + container_of(kref, struct media_request_object, kref); > + struct media_request *req =

Re: [RFC] Make entity to interface links immutable

2018-07-02 Thread Hans Verkuil
On 02/07/18 11:41, Mauro Carvalho Chehab wrote: > Em Mon, 2 Jul 2018 10:18:37 +0200 > Hans Verkuil escreveu: > >> While working on v4l2-compliance I noticed that entity to interface links >> have just the MEDIA_LNK_FL_ENABLED flag set. >> >> Shouldn't we also set the MEDIA_LNK_FL_IMMUTABLE?

Re: [PATCH] v4l2-ctrls.c: fix broken auto cluster handling

2018-07-02 Thread Hugues FRUCHET
Many thanks Hans, This fix my issue with ov5640, Best regards, Hugues. On 06/29/2018 12:12 PM, Hans Verkuil wrote: > When you switch from auto to manual mode for an auto-cluster (e.g. > autogain+gain controls), then the current HW value has to be copied > to the current control value. However,

Re: [RFC] Make entity to interface links immutable

2018-07-02 Thread Mauro Carvalho Chehab
Em Mon, 2 Jul 2018 10:18:37 +0200 Hans Verkuil escreveu: > While working on v4l2-compliance I noticed that entity to interface links > have just the MEDIA_LNK_FL_ENABLED flag set. > > Shouldn't we also set the MEDIA_LNK_FL_IMMUTABLE? After all, you cannot change > an entity-interface link. It

[GIT PULL FOR v4.19] Various fixes

2018-07-02 Thread Hans Verkuil
Hi Mauro, The usual 'various fixes'. A bunch of coda fixes, and I cherry-picked from Ezequiel's https://www.spinics.net/lists/linux-media/msg136223.html patch series. Regards, Hans The following changes since commit 3c4a737267e89aafa6308c6c456d2ebea3fcd085: media: ov5640: fix frame

Re: [PATCHv15 02/35] media-request: implement media requests

2018-07-02 Thread Hans Verkuil
On 02/07/18 10:58, Tomasz Figa wrote: > Hi Hans, > > On Fri, Jun 15, 2018 at 4:09 PM Hans Verkuil wrote: >> >> On 04/06/18 13:46, Hans Verkuil wrote: >>> From: Hans Verkuil >>> >>> Add initial media request support: >>> >>> 1) Add MEDIA_IOC_REQUEST_ALLOC ioctl support to media-device.c >>> 2)

Re: [PATCHv15 02/35] media-request: implement media requests

2018-07-02 Thread Tomasz Figa
Hi Hans, On Fri, Jun 15, 2018 at 4:09 PM Hans Verkuil wrote: > > On 04/06/18 13:46, Hans Verkuil wrote: > > From: Hans Verkuil > > > > Add initial media request support: > > > > 1) Add MEDIA_IOC_REQUEST_ALLOC ioctl support to media-device.c > > 2) Add struct media_request to store request

Re: [PATCH] media: coda: add SPS fixup code for frame sizes that are not multiples of 16

2018-07-02 Thread Hans Verkuil
On 28/06/18 18:47, Philipp Zabel wrote: > The CODA firmware does not set the VUI frame cropping fields to properly > describe coded h.264 streams with frame sizes that are not a multiple of > the macroblock size. > This adds RBSP parsing code and a SPS fixup routine to manually replace > the

Re: [PATCH v4 03/17] omap4iss: Add vb2_queue lock

2018-07-02 Thread Hans Verkuil
On 15/06/18 21:07, Ezequiel Garcia wrote: > vb2_queue lock is now mandatory. Add it, remove driver ad-hoc > locks, and implement wait_{prepare, finish}. I don't see any wait_prepare/finish implementation?! Regards, Hans > > Signed-off-by: Ezequiel Garcia > --- >

[RFC] Make entity to interface links immutable

2018-07-02 Thread Hans Verkuil
While working on v4l2-compliance I noticed that entity to interface links have just the MEDIA_LNK_FL_ENABLED flag set. Shouldn't we also set the MEDIA_LNK_FL_IMMUTABLE? After all, you cannot change an entity-interface link. It feels inconsistent not to have this flag. I also propose that

Re: [PATCH v6 12/12] intel-ipu3: Add imgu top level pci device driver

2018-07-02 Thread Tomasz Figa
Hi Yong, On Fri, Mar 30, 2018 at 11:15 AM Yong Zhi wrote: > +/* > + * Queue as many buffers to CSS as possible. If all buffers don't fit into > + * CSS buffer queues, they remain unqueued and will be queued later. > + */ > +int imgu_queue_buffers(struct imgu_device *imgu, bool initial) > +{ > +

Re: [PATCH v3 03/13] media: v4l2: async: Add v4l2_async_notifier_add_subdev

2018-07-02 Thread Sakari Ailus
On Tue, Jun 26, 2018 at 01:47:45PM -0700, Steve Longerbeam wrote: > > > On 06/26/2018 12:12 AM, Sakari Ailus wrote: > > On Wed, May 09, 2018 at 04:06:32PM -0700, Steve Longerbeam wrote: > > > > > > On 05/08/2018 03:12 AM, Sakari Ailus wrote: > > > > On Fri, Apr 20, 2018 at 10:12:33AM -0700,

Re: [PATCH v6 11/12] intel-ipu3: Add v4l2 driver based on media framework

2018-07-02 Thread Tomasz Figa
Hi Yong, On Fri, Mar 30, 2018 at 11:15 AM Yong Zhi wrote: [snip] > +static int ipu3_vidioc_enum_input(struct file *file, void *fh, > + struct v4l2_input *input) > +{ > + if (input->index > 0) > + return -EINVAL; > + strlcpy(input->name,

Re: [PATCH v3 05/13] media: v4l2-fwnode: Add a convenience function for registering subdevs with notifiers

2018-07-02 Thread Sakari Ailus
Hi Steve, On Tue, May 08, 2018 at 08:55:04PM -0700, Steve Longerbeam wrote: > > > On 05/08/2018 03:28 AM, Sakari Ailus wrote: > > Hi Steve, > > > > Again, sorry about the delay. This thread got buried in my inbox. :-( > > Please see my reply below. > > > > On Mon, Apr 23, 2018 at 11:00:22AM

Re: [PATCH] media: v4l2-ctrls: Fix CID base conflict between MAX217X and IMX

2018-07-02 Thread Sakari Ailus
On Wed, Jun 27, 2018 at 11:39:43AM -0700, Steve Longerbeam wrote: > When the imx-media driver was initially merged, there was a conflict > with 8d67ae25 ("media: v4l2-ctrls: Reserve controls for MAX217X") which > was not fixed up correctly, resulting in V4L2_CID_USER_MAX217X_BASE and >

Re: [PATCH v6 06/12] intel-ipu3: css: Add support for firmware management

2018-07-02 Thread Tomasz Figa
Hi Yong, Continuing my review. Sorry for the delay. On Fri, Mar 30, 2018 at 11:15 AM Yong Zhi wrote: > > Introduce functions to load and install ImgU FW blobs. > > Signed-off-by: Yong Zhi > --- > drivers/media/pci/intel/ipu3/ipu3-abi.h| 1888 > >