cron job: media_tree daily build: ERRORS

2018-10-05 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Oct 6 05:00:13 CEST 2018 media-tree git hash:557c97b5133669297be561e6091da9ab6e488e65 media_build

[PATCH 1/2] dw9714: Remove useless error message

2018-10-05 Thread Sakari Ailus
If probe fails, the kernel will print the error code. There's no need to driver to do that. Signed-off-by: Sakari Ailus --- drivers/media/i2c/dw9714.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/dw9714.c b/drivers/media/i2c/dw9714.c index

[PATCH 0/2] dw9807 driver fix, dw9714 cleanup

2018-10-05 Thread Sakari Ailus
Hi Raj, others, One fix and one cleanup for the dw9807 and dw9714 drivers. The dw9807 driver had the same issue than what you fixed in dw9714. Sakari Ailus (2): dw9714: Remove useless error message dw9807: Fix probe error handling drivers/media/i2c/dw9714.c | 2 +-

[PATCH 2/2] dw9807-vcm: Fix probe error handling

2018-10-05 Thread Sakari Ailus
v4l2_async_unregister_subdev() may not be called without v4l2_async_register_subdev() being called first. Fix this. Signed-off-by: Sakari Ailus --- drivers/media/i2c/dw9807-vcm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/dw9807-vcm.c

Re: [PATCH] MAINTAINERS: Remove stale file entry for the Atmel ISI driver

2018-10-05 Thread Mauro Carvalho Chehab
Em Thu, 04 Oct 2018 23:06:02 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > On Thursday, 4 October 2018 21:45:05 EEST Mauro Carvalho Chehab wrote: > > Em Tue, 2 Oct 2018 08:35:47 +0200 Ludovic Desroches escreveu: > > > On Mon, Oct 01, 2018 at 01:51:01PM -0300, Mauro Carvalho Chehab wrote:

Re: [PATCH v6 0/6] Add Rockchip VPU JPEG encoder

2018-10-05 Thread Ezequiel Garcia
On Fri, 2018-10-05 at 13:49 -0300, Mauro Carvalho Chehab wrote: > Em Fri, 05 Oct 2018 12:37:43 -0300 > Ezequiel Garcia escreveu: > > > On Fri, 2018-10-05 at 09:10 -0300, Mauro Carvalho Chehab wrote: > > > Em Thu, 04 Oct 2018 20:39:31 -0300 > > > Ezequiel Garcia escreveu: > > > > > > > On

Re: [PATCH v6 0/6] Add Rockchip VPU JPEG encoder

2018-10-05 Thread Mauro Carvalho Chehab
Em Fri, 05 Oct 2018 12:37:43 -0300 Ezequiel Garcia escreveu: > On Fri, 2018-10-05 at 09:10 -0300, Mauro Carvalho Chehab wrote: > > Em Thu, 04 Oct 2018 20:39:31 -0300 > > Ezequiel Garcia escreveu: > > > > > On Mon, 2018-10-01 at 14:54 -0300, Ezequiel Garcia wrote: > > > > On Fri, 2018-09-28

Re: [PATCH v6 0/6] Add Rockchip VPU JPEG encoder

2018-10-05 Thread Ezequiel Garcia
On Fri, 2018-10-05 at 09:10 -0300, Mauro Carvalho Chehab wrote: > Em Thu, 04 Oct 2018 20:39:31 -0300 > Ezequiel Garcia escreveu: > > > On Mon, 2018-10-01 at 14:54 -0300, Ezequiel Garcia wrote: > > > On Fri, 2018-09-28 at 14:33 +0200, Hans Verkuil wrote: > > > > On 09/17/2018 07:30 PM, Ezequiel

Re: [PATCH v2 0/6] media: video-i2c: support changing frame interval and runtime PM

2018-10-05 Thread Sakari Ailus
On Mon, Sep 24, 2018 at 01:34:46AM +0900, Akinobu Mita wrote: > This patchset adds support for changing frame interval and runtime PM for > video-i2c driver. This also adds an helper macro to v4l2 common > internal API that is used to to find a suitable frame interval. > > There are a couple of

Re: [PATCH RESEND] Revert "media: dvbsky: use just one mutex for serializing device R/W ops"

2018-10-05 Thread Mauro Carvalho Chehab
Em Fri, 5 Oct 2018 16:34:28 +0200 Oliver Freyermuth escreveu: > Dear Mauro, > > thanks! Just to clarify, the issue I described in > https://bugzilla.kernel.org/show_bug.cgi?id=199323 > was on an Intel x86_64 system, with an onboard USB Controller handled by the > standard xhci driver, > so

[PATCH] mceusb: Include three Hauppauge USB dvb device with IR rx

2018-10-05 Thread Brad Love
The three following Hauppauge USB DVB devices have IR receivers, but lacked the support in mceusb to enable it: - WinTV-HVR-935C - WinTV-HVR-955Q - WinTV-HVR-975 Tested HVR-955Q and HVR-975 plus RC5 remote and irw, works as intended. Signed-off-by: Brad Love --- drivers/media/rc/mceusb.c | 9

Re: [PATCH v2 1/6] media: video-i2c: avoid accessing released memory area when removing driver

2018-10-05 Thread Sakari Ailus
Hi Mita-san, On Fri, Oct 05, 2018 at 11:59:20PM +0900, Akinobu Mita wrote: > 2018年10月5日(金) 18:36 Sakari Ailus : > > > > Hi Hans, > > > > On Mon, Oct 01, 2018 at 11:40:00AM +0200, Hans Verkuil wrote: > > > On 09/23/2018 06:34 PM, Akinobu Mita wrote: > > > > The video_i2c_data is allocated by

Re: [PATCH v2 1/6] media: video-i2c: avoid accessing released memory area when removing driver

2018-10-05 Thread Akinobu Mita
2018年10月5日(金) 18:36 Sakari Ailus : > > Hi Hans, > > On Mon, Oct 01, 2018 at 11:40:00AM +0200, Hans Verkuil wrote: > > On 09/23/2018 06:34 PM, Akinobu Mita wrote: > > > The video_i2c_data is allocated by kzalloc and released by the video > > > device's release callback. The release callback is

Re: [PATCH RESEND] Revert "media: dvbsky: use just one mutex for serializing device R/W ops"

2018-10-05 Thread Oliver Freyermuth
Dear Mauro, thanks! Just to clarify, the issue I described in https://bugzilla.kernel.org/show_bug.cgi?id=199323 was on an Intel x86_64 system, with an onboard USB Controller handled by the standard xhci driver, so this does not affect RPi alone. Cheers and thanks, Oliver Am 05.10.18

[PATCH RESEND] Revert "media: dvbsky: use just one mutex for serializing device R/W ops"

2018-10-05 Thread Mauro Carvalho Chehab
As pointed at: https://bugzilla.kernel.org/show_bug.cgi?id=199323 This patch causes a bad effect on RPi. I suspect that the root cause is at the USB RPi driver, with uses high priority interrupts instead of normal ones. Anyway, as this patch is mostly a cleanup, better to revert it. This

[PATCH] Revert "media: dvbsky: use just one mutex for serializing device R/W ops"

2018-10-05 Thread Mauro Carvalho Chehab
As pointed at: https://bugzilla.kernel.org/show_bug.cgi?id=199323 This patch causes a bad effect on RPi. I suspect that the root cause is at the USB RPi driver, with uses high priority interrupts instead of normal ones. Anyway, as this patch is mostly a cleanup, better to revert it. This

[PATCH] media: imx355: fix a few coding style issues

2018-10-05 Thread Mauro Carvalho Chehab
Function alignments are off by 1 space, as reported by checkpatch.pl --strict. Fix those. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/imx355.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/media/i2c/imx355.c

[PATCH] media: imx319: fix a few coding style issues

2018-10-05 Thread Mauro Carvalho Chehab
Function alignments are off by 1 space, as reported by checkpatch.pl --strict. Fix those. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/imx319.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/media/i2c/imx319.c

[GIT PULL FOR v4.20] Various cec fixes

2018-10-05 Thread Hans Verkuil
This pull request fixes various CEC bugs. The following patches are also CCed to stable for 4.18: cec: add new tx/rx status bits to detect aborts/timeouts adv7604: when the EDID is cleared, unconfigure CEC as well adv7842: when the EDID is cleared, unconfigure CEC as well

[GIT PULL for 4.20] Ov7670 and ov9650 fixes

2018-10-05 Thread Sakari Ailus
Hi Mauro, Here are fixes for the Omnivision sensor drivers. Please pull. The following changes since commit f492fb4f5b41e8e62051e710369320e9ffa7a1ea: media: MAINTAINERS: Fix entry for the renamed dw9807 driver (2018-10-05 08:40:00 -0400) are available in the git repository at:

Re: [RFC] V4L2_PIX_FMT_MJPEG vs V4L2_PIX_FMT_JPEG

2018-10-05 Thread Hans de Goede
Hi, On 05-10-18 13:55, Mauro Carvalho Chehab wrote: Em Mon, 1 Oct 2018 18:19:21 +0100 Dave Stevenson escreveu: Hi All, On Mon, 1 Oct 2018 at 17:32, Ezequiel Garcia wrote: Hi Hans, Thanks for looking into. I remember MJPEG vs. JPEG being a source of confusion for me a few years ago, so

[GIT PULL v2 for 4.20] Unlocked V4L2 control grab, imx{319, 355} drivers

2018-10-05 Thread Sakari Ailus
Hi Mauro, Here are drivers for Sony imx319 and imx355 sensors and an unlocked version of v4l2_ctrl_grab() which is used by the driver. Since v1, I've rebased this on the current master --- with the fwnode patches. Please pull. The diff is here and effectively the same for both drivers: diff

Re: [PATCH v7 4/6] media: Add JPEG_RAW format

2018-10-05 Thread Mauro Carvalho Chehab
Em Fri, 05 Oct 2018 08:53:14 -0300 Ezequiel Garcia escreveu: > On Fri, 2018-10-05 at 08:09 -0300, Mauro Carvalho Chehab wrote: > > Em Thu, 4 Oct 2018 21:12:24 -0300 > > Ezequiel Garcia escreveu: > > > > > From: Shunqian Zheng > > > > > > Add V4L2_PIX_FMT_JPEG_RAW format that does not

Re: [PATCH v6 0/6] Add Rockchip VPU JPEG encoder

2018-10-05 Thread Mauro Carvalho Chehab
Em Thu, 04 Oct 2018 20:39:31 -0300 Ezequiel Garcia escreveu: > On Mon, 2018-10-01 at 14:54 -0300, Ezequiel Garcia wrote: > > On Fri, 2018-09-28 at 14:33 +0200, Hans Verkuil wrote: > > > On 09/17/2018 07:30 PM, Ezequiel Garcia wrote: > > > > This series adds support for JPEG encoding via the

Re: [PATCH v7 2/6] ARM: dts: rockchip: add VPU device node for RK3288

2018-10-05 Thread Heiko Stuebner
Am Freitag, 5. Oktober 2018, 02:12:22 CEST schrieb Ezequiel Garcia: > Add the Video Processing Unit node for RK3288 SoC. > > Fix the VPU IOMMU node, which was disabled and lacking > its power domain property. > > Signed-off-by: Ezequiel Garcia applied for 4.20 (may possibly move to 4.21

Re: [PATCH v7 3/6] arm64: dts: rockchip: add VPU device node for RK3399

2018-10-05 Thread Heiko Stuebner
Am Freitag, 5. Oktober 2018, 02:12:23 CEST schrieb Ezequiel Garcia: > Add the Video Processing Unit node for the RK3399 SoC. > > Also, fix the VPU IOMMU node, which was disabled and lacking > its power domain property. > > Signed-off-by: Ezequiel Garcia applied for 4.20 (may possibly move to

Re: [RFC] V4L2_PIX_FMT_MJPEG vs V4L2_PIX_FMT_JPEG

2018-10-05 Thread Mauro Carvalho Chehab
Em Mon, 1 Oct 2018 18:19:21 +0100 Dave Stevenson escreveu: > Hi All, > > On Mon, 1 Oct 2018 at 17:32, Ezequiel Garcia wrote: > > > > Hi Hans, > > > > Thanks for looking into. I remember MJPEG vs. JPEG being a source > > of confusion for me a few years ago, so clarification is greatly > >

Re: [PATCH v7 4/6] media: Add JPEG_RAW format

2018-10-05 Thread Ezequiel Garcia
On Fri, 2018-10-05 at 08:09 -0300, Mauro Carvalho Chehab wrote: > Em Thu, 4 Oct 2018 21:12:24 -0300 > Ezequiel Garcia escreveu: > > > From: Shunqian Zheng > > > > Add V4L2_PIX_FMT_JPEG_RAW format that does not contain > > JPEG header in the output frame. > > > > Signed-off-by: Shunqian Zheng

Re: [RFC] V4L2_PIX_FMT_MJPEG vs V4L2_PIX_FMT_JPEG

2018-10-05 Thread Mauro Carvalho Chehab
Em Mon, 01 Oct 2018 08:42:56 -0400 Nicolas Dufresne escreveu: > Hello Hans, > > Le lundi 01 octobre 2018 à 10:43 +0200, Hans Verkuil a écrit : > > It turns out that we have both JPEG and Motion-JPEG pixel formats defined. > > > > Furthermore, some drivers support one, some the other and some

[PATCH -next] [media] media: drop pointless static qualifier in vpfe_ipipeif_init()

2018-10-05 Thread YueHaibing
There is no need to have the 'resource_size_t res_len' variable static since new value always be assigned before use it. Signed-off-by: YueHaibing --- drivers/staging/media/davinci_vpfe/dm365_ipipeif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH -next] [media] media: drop pointless static qualifier in vpfe_resizer_init()

2018-10-05 Thread YueHaibing
There is no need to have the 'resource_size_t res_len' variable static since new value always be assigned before use it. Signed-off-by: YueHaibing --- drivers/staging/media/davinci_vpfe/dm365_resizer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v7 4/6] media: Add JPEG_RAW format

2018-10-05 Thread Mauro Carvalho Chehab
Em Thu, 4 Oct 2018 21:12:24 -0300 Ezequiel Garcia escreveu: > From: Shunqian Zheng > > Add V4L2_PIX_FMT_JPEG_RAW format that does not contain > JPEG header in the output frame. > > Signed-off-by: Shunqian Zheng > Signed-off-by: Ezequiel Garcia > --- >

Re: [RFC PATCH 00/11] Convert last remaining g/s_crop/cropcap drivers

2018-10-05 Thread Niklas Söderlund
Hi Hans, I like this series, nice work! On 2018-10-05 09:49:00 +0200, Hans Verkuil wrote: > From: Hans Verkuil > > This patch series converts the last remaining drivers that use g/s_crop and > cropcap to g/s_selection. > > The first two patches do some minor code cleanup. > > The third patch

Re: [RFC PATCH 11/11] vidioc_cropcap -> vidioc_g_pixelaspect

2018-10-05 Thread Niklas Söderlund
Hi Hans, Thanks for your patch. On 2018-10-05 09:49:11 +0200, Hans Verkuil wrote: > From: Hans Verkuil > > Now vidioc_cropcap is only used to return the pixelaspect, so > rename it accordingly. > > Signed-off-by: Hans Verkuil For the v4l2 and rcar-vin changes: Reviewed-by: Niklas Söderlund

Re: [RFC PATCH 10/11] v4l2-ioctl: remove unused vidioc_g/s_crop

2018-10-05 Thread Hans Verkuil
On 10/05/18 12:47, Niklas Söderlund wrote: > Hi Hans, > > Thanks for your work. > > On 2018-10-05 09:49:10 +0200, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Now that all drivers have dropped vidioc_g/s_crop we can remove >> support for them in the V4L2 core. >> >> Signed-off-by: Hans

Re: [RFC PATCH 10/11] v4l2-ioctl: remove unused vidioc_g/s_crop

2018-10-05 Thread Niklas Söderlund
Hi Hans, Thanks for your work. On 2018-10-05 09:49:10 +0200, Hans Verkuil wrote: > From: Hans Verkuil > > Now that all drivers have dropped vidioc_g/s_crop we can remove > support for them in the V4L2 core. > > Signed-off-by: Hans Verkuil If the quirk patch hurt my head this makes me smile!

Re: [RFC PATCH 03/11] v4l2-ioctl: add QUIRK_INVERTED_CROP

2018-10-05 Thread Niklas Söderlund
Hi Hans, Thanks for your patch. On 2018-10-05 09:49:03 +0200, Hans Verkuil wrote: > From: Hans Verkuil > > Some old Samsung drivers use the legacy crop API incorrectly: > the crop and compose targets are swapped. Normally VIDIOC_G_CROP > will return the CROP rectangle of a CAPTURE stream and

Re: [PATCH v2 1/3] media: v4l2-core: cleanup coding style at V4L2 async/fwnode

2018-10-05 Thread Sakari Ailus
Hi Mauro, On Fri, Oct 05, 2018 at 06:29:36AM -0400, Mauro Carvalho Chehab wrote: > There are several coding style issues at those definitions, > and the previous patchset added even more. > > Address the trivial ones by first calling: > > ./scripts/checkpatch.pl --strict --fix-inline >

Re: [PATCH 2/3] media: v4l2-fwnode: cleanup functions that parse endpoints

2018-10-05 Thread Mauro Carvalho Chehab
Em Fri, 5 Oct 2018 13:08:25 +0300 Sakari Ailus escreveu: > > > This is still over 80 here. I think we could think of abbreviating what's > > > in the function name, not limiting to the endpoint. I think I'd prefer to > > > leave that for 4.21 as there's not much time anymore. > > > > Yes, I

Re: [PATCH 3/3] media: v4l2-fwnode: simplify v4l2_fwnode_reference_parse_int_props() call

2018-10-05 Thread Mauro Carvalho Chehab
Em Fri, 5 Oct 2018 13:06:04 +0300 Sakari Ailus escreveu: > > > > - unsigned int i; > > > > > > I'd like to keep this here. > > > > Why? IMHO, it makes harder to read (yet, if you insist, I'm ok with > > both ways). > > Generally loop, temporary, return etc. variables are nice

Re: [RFC PATCH 02/11] v4l2-common.h: put backwards compat defines under #ifndef __KERNEL__

2018-10-05 Thread Niklas Söderlund
Hi Hans, Thanks for your patch. On 2018-10-05 09:49:02 +0200, Hans Verkuil wrote: > From: Hans Verkuil > > This ensures that they won't be used in kernel code. > > Signed-off-by: Hans Verkuil Reviewed-by: Niklas Söderlund > --- > include/uapi/linux/v4l2-common.h | 28

[PATCH v2 1/3] media: v4l2-core: cleanup coding style at V4L2 async/fwnode

2018-10-05 Thread Mauro Carvalho Chehab
There are several coding style issues at those definitions, and the previous patchset added even more. Address the trivial ones by first calling: ./scripts/checkpatch.pl --strict --fix-inline include/media/v4l2-async.h include/media/v4l2-fwnode.h include/media/v4l2-mediabus.h

[PATCH v2 0/3] Coding style cleanups after the fwnode patchset

2018-10-05 Thread Mauro Carvalho Chehab
The fwnode patchset added a several new warnings, as identified by checkpatch.pl --strict. Those are at the core stuff, and makes harder to review patches there. In order to fully address checkpatch.pl, we still need to: - Add SPDX headers; - Rename functions. Let's do those on

[PATCH v2 3/3] media: v4l2-fwnode: simplify v4l2_fwnode_reference_parse_int_props() call

2018-10-05 Thread Mauro Carvalho Chehab
The v4l2_fwnode_reference_parse_int_props() has a big name, causing it to cause coding style warnings. Also, it depends on a const struct embedded indide a function. Rearrange the logic in order to move the struct declaration out of such function and use it inside this function. That cleans up

[PATCH v2 2/3] media: v4l2-fwnode: cleanup functions that parse endpoints

2018-10-05 Thread Mauro Carvalho Chehab
There is already a typedef for the parse endpoint function. However, instead of using it, it is redefined at the C file (and on one of the function headers). Replace them by the function typedef, in order to cleanup several related coding style warnings. Signed-off-by: Mauro Carvalho Chehab ---

Re: [PATCH 1/3] media: v4l2-core: cleanup coding style at V4L2 async/fwnode

2018-10-05 Thread Sakari Ailus
Hi Mauro, On Fri, Oct 05, 2018 at 07:12:02AM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 5 Oct 2018 10:55:58 +0300 > Sakari Ailus escreveu: ... > > > @@ -436,8 +437,7 @@ static int __v4l2_fwnode_endpoint_parse(struct > > > fwnode_handle *fwnode, > > > if (mbus_type !=

Re: [PATCH] MAINTAINERS: update videobuf2 entry

2018-10-05 Thread Sakari Ailus
Hi Marek, On Fri, Oct 05, 2018 at 10:01:41AM +0200, Marek Szyprowski wrote: > Commits 03fbdb2fc2b8 ("media: move videobuf2 to drivers/media/common") > and 7952be9b6ece ("media: drivers/media/common/videobuf2: rename from > videobuf") moved videobuf2 framework source code finally to >

Re: [RFC PATCH 01/11] v4l2-ioctl: don't use CROP/COMPOSE_ACTIVE

2018-10-05 Thread Niklas Söderlund
Hi Hans, Thanks for your work. On 2018-10-05 09:49:01 +0200, Hans Verkuil wrote: > From: Hans Verkuil > > Drop the deprecated _ACTIVE part. > > Signed-off-by: Hans Verkuil Reviewed-by: Niklas Söderlund > --- > drivers/media/v4l2-core/v4l2-ioctl.c | 8 > 1 file changed, 4

Re: [PATCH 1/3] media: v4l2-core: cleanup coding style at V4L2 async/fwnode

2018-10-05 Thread Mauro Carvalho Chehab
Em Fri, 5 Oct 2018 10:55:58 +0300 Sakari Ailus escreveu: > Hi Mauro, > > On Thu, Oct 04, 2018 at 06:13:46PM -0400, Mauro Carvalho Chehab wrote: > > There are several coding style issues at those definitions, > > and the previous patchset added even more. > > > > Address the trivial ones by

Re: [PATCH 2/3] media: v4l2-fwnode: cleanup functions that parse endpoints

2018-10-05 Thread Sakari Ailus
On Fri, Oct 05, 2018 at 06:52:20AM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 5 Oct 2018 11:01:18 +0300 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > Feel free to ignore the comments on the first patch regarding the functions > > below. There are other issues there though. > > > > On

Re: [PATCH 3/3] media: v4l2-fwnode: simplify v4l2_fwnode_reference_parse_int_props() call

2018-10-05 Thread Sakari Ailus
On Fri, Oct 05, 2018 at 06:54:49AM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 5 Oct 2018 11:03:10 +0300 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > On Thu, Oct 04, 2018 at 06:13:48PM -0400, Mauro Carvalho Chehab wrote: > > > The v4l2_fwnode_reference_parse_int_props() has a big name,

Re: [PATCH 3/3] media: v4l2-fwnode: simplify v4l2_fwnode_reference_parse_int_props() call

2018-10-05 Thread Mauro Carvalho Chehab
Em Fri, 5 Oct 2018 11:03:10 +0300 Sakari Ailus escreveu: > Hi Mauro, > > On Thu, Oct 04, 2018 at 06:13:48PM -0400, Mauro Carvalho Chehab wrote: > > The v4l2_fwnode_reference_parse_int_props() has a big name, causing > > it to cause coding style warnings. Also, it depends on a const > > struct

Re: [PATCH 2/3] media: v4l2-fwnode: cleanup functions that parse endpoints

2018-10-05 Thread Mauro Carvalho Chehab
Em Fri, 5 Oct 2018 11:01:18 +0300 Sakari Ailus escreveu: > Hi Mauro, > > Feel free to ignore the comments on the first patch regarding the functions > below. There are other issues there though. > > On Thu, Oct 04, 2018 at 06:13:47PM -0400, Mauro Carvalho Chehab wrote: > > There is already a

Re: [PATCH v2 1/6] media: video-i2c: avoid accessing released memory area when removing driver

2018-10-05 Thread Sakari Ailus
Hi Hans, On Mon, Oct 01, 2018 at 11:40:00AM +0200, Hans Verkuil wrote: > On 09/23/2018 06:34 PM, Akinobu Mita wrote: > > The video_i2c_data is allocated by kzalloc and released by the video > > device's release callback. The release callback is called when > > video_unregister_device() is

Re: [PATCH] media: cec: name for RC passthrough device does not need 'RC for'

2018-10-05 Thread Sean Young
On Fri, Oct 05, 2018 at 09:37:11AM +0200, Hans Verkuil wrote: > On 10/05/2018 12:21 AM, Sean Young wrote: > > An RC device is does not need to be called 'RC for'. Simply the name > > will suffice. > > > > Signed-off-by: Sean Young > > Reviewed-by: Hans Verkuil > > OK if I take this patch? I

Re: [PATCH v2 1/6] media: video-i2c: avoid accessing released memory area when removing driver

2018-10-05 Thread Hans Verkuil
On 10/02/18 18:17, Akinobu Mita wrote: > 2018年10月1日(月) 18:40 Hans Verkuil : >> >> On 09/23/2018 06:34 PM, Akinobu Mita wrote: >>> The video_i2c_data is allocated by kzalloc and released by the video >>> device's release callback. The release callback is called when >>> video_unregister_device()

Re: s5p_mfc and H.264 frame cropping question

2018-10-05 Thread Tomasz Figa
On Fri, Oct 5, 2018 at 5:38 PM Hans Verkuil wrote: > > On 10/05/2018 10:16 AM, Tomasz Figa wrote: > > On Fri, Oct 5, 2018 at 3:58 PM Hans Verkuil wrote: > >> > >> On 10/05/2018 05:12 AM, Tomasz Figa wrote: > >>> Hi Hans, > >>> > >>> On Fri, Oct 5, 2018 at 5:02 AM Hans Verkuil wrote: > >

Re: s5p_mfc and H.264 frame cropping question

2018-10-05 Thread Hans Verkuil
On 10/05/2018 10:16 AM, Tomasz Figa wrote: > On Fri, Oct 5, 2018 at 3:58 PM Hans Verkuil wrote: >> >> On 10/05/2018 05:12 AM, Tomasz Figa wrote: >>> Hi Hans, >>> >>> On Fri, Oct 5, 2018 at 5:02 AM Hans Verkuil wrote: Hi all, I'm looking at removing the last users of

[GIT PULL FOR v4.20] Add Rockchip VPU JPEG encoder

2018-10-05 Thread Hans Verkuil
This adds the Rockchip VPU JPEG encoder staging driver. Note: this goes on top of the request_api branch! It does not use the request API as such, but it would otherwise conflict with that series, so it is easier to just base it on top of the request_api branch. You will get a linker warning

Re: s5p_mfc and H.264 frame cropping question

2018-10-05 Thread Tomasz Figa
On Fri, Oct 5, 2018 at 3:58 PM Hans Verkuil wrote: > > On 10/05/2018 05:12 AM, Tomasz Figa wrote: > > Hi Hans, > > > > On Fri, Oct 5, 2018 at 5:02 AM Hans Verkuil wrote: > >> > >> Hi all, > >> > >> I'm looking at removing the last users of vidioc_g/s_crop from the driver > >> and > >> I came

Re: [PATCH 2/3] media: v4l2-fwnode: cleanup functions that parse endpoints

2018-10-05 Thread Sakari Ailus
Hi Mauro, Feel free to ignore the comments on the first patch regarding the functions below. There are other issues there though. On Thu, Oct 04, 2018 at 06:13:47PM -0400, Mauro Carvalho Chehab wrote: > There is already a typedef for the parse endpoint function. > However, instead of using it,

Re: [PATCH 3/3] media: v4l2-fwnode: simplify v4l2_fwnode_reference_parse_int_props() call

2018-10-05 Thread Sakari Ailus
Hi Mauro, On Thu, Oct 04, 2018 at 06:13:48PM -0400, Mauro Carvalho Chehab wrote: > The v4l2_fwnode_reference_parse_int_props() has a big name, causing > it to cause coding style warnings. Also, it depends on a const > struct embedded indide a function. > > Rearrange the logic in order to move

[PATCH] MAINTAINERS: update videobuf2 entry

2018-10-05 Thread Marek Szyprowski
Commits 03fbdb2fc2b8 ("media: move videobuf2 to drivers/media/common") and 7952be9b6ece ("media: drivers/media/common/videobuf2: rename from videobuf") moved videobuf2 framework source code finally to drivers/media/common/videobuf2 directory, so update relevant paths in MAINTAINERS file.

Re: [PATCH 1/3] media: v4l2-core: cleanup coding style at V4L2 async/fwnode

2018-10-05 Thread Sakari Ailus
Hi Mauro, On Thu, Oct 04, 2018 at 06:13:46PM -0400, Mauro Carvalho Chehab wrote: > There are several coding style issues at those definitions, > and the previous patchset added even more. > > Address the trivial ones by first calling: > > ./scripts/checkpatch.pl --strict --fix-inline >

[RFC PATCH 05/11] cropcap/g_selection split

2018-10-05 Thread Hans Verkuil
From: Hans Verkuil If g_selection is implemented, then the v4l2-ioctl cropcap code assumes that cropcap just implements the pixelaspect part and that g_selection provides the crop bounds and default rectangles. There are still some drivers that only implement cropcap and not g_selection. Split

[RFC PATCH 00/11] Convert last remaining g/s_crop/cropcap drivers

2018-10-05 Thread Hans Verkuil
From: Hans Verkuil This patch series converts the last remaining drivers that use g/s_crop and cropcap to g/s_selection. The first two patches do some minor code cleanup. The third patch adds a new video_device flag to indicate that the driver inverts the normal usage of g/s_crop/cropcap. This

[RFC PATCH 06/11] exynos-gsc: replace v4l2_crop by v4l2_selection

2018-10-05 Thread Hans Verkuil
From: Hans Verkuil Replace the use of struct v4l2_crop by struct v4l2_selection. Also drop the unused gsc_g_crop function. Signed-off-by: Hans Verkuil --- drivers/media/platform/exynos-gsc/gsc-core.c | 57 drivers/media/platform/exynos-gsc/gsc-core.h | 3 +-

[RFC PATCH 04/11] davinci/vpbe: drop unused g_cropcap

2018-10-05 Thread Hans Verkuil
From: Hans Verkuil This function/callback is never used. Drop it. Signed-off-by: Hans Verkuil --- drivers/media/platform/davinci/vpbe.c | 23 --- include/media/davinci/vpbe.h | 4 2 files changed, 27 deletions(-) diff --git

[RFC PATCH 08/11] exynos4-is: convert g/s_crop to g/s_selection

2018-10-05 Thread Hans Verkuil
From: Hans Verkuil Replace g/s_crop by g/s_selection and set the V4L2_FL_QUIRK_INVERTED_CROP flag since this is one of the old drivers that predates the selection API. Those old drivers allowed g_crop when it really shouldn't have since g_crop returns a compose rectangle instead of a crop

[RFC PATCH 02/11] v4l2-common.h: put backwards compat defines under #ifndef __KERNEL__

2018-10-05 Thread Hans Verkuil
From: Hans Verkuil This ensures that they won't be used in kernel code. Signed-off-by: Hans Verkuil --- include/uapi/linux/v4l2-common.h | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/include/uapi/linux/v4l2-common.h

[RFC PATCH 03/11] v4l2-ioctl: add QUIRK_INVERTED_CROP

2018-10-05 Thread Hans Verkuil
From: Hans Verkuil Some old Samsung drivers use the legacy crop API incorrectly: the crop and compose targets are swapped. Normally VIDIOC_G_CROP will return the CROP rectangle of a CAPTURE stream and the COMPOSE rectangle of an OUTPUT stream. The Samsung drivers do the opposite. Note that

[RFC PATCH 07/11] s5p_mfc_dec.c: convert g_crop to g_selection

2018-10-05 Thread Hans Verkuil
From: Hans Verkuil The g_crop really implemented composition for the CAPTURE stream. Replace g_crop by g_selection and set the V4L2_FL_QUIRK_INVERTED_CROP flag since this is one of the old drivers that predates the selection API. Those old drivers allowed g_crop when it really shouldn't have

[RFC PATCH 09/11] s5p-g2d: convert g/s_crop to g/s_selection

2018-10-05 Thread Hans Verkuil
From: Hans Verkuil Replace g/s_crop by g/s_selection and set the V4L2_FL_QUIRK_INVERTED_CROP flag since this is one of the old drivers that predates the selection API. Those old drivers allowed g_crop when it really shouldn't have since g_crop returns a compose rectangle instead of a crop

[RFC PATCH 11/11] vidioc_cropcap -> vidioc_g_pixelaspect

2018-10-05 Thread Hans Verkuil
From: Hans Verkuil Now vidioc_cropcap is only used to return the pixelaspect, so rename it accordingly. Signed-off-by: Hans Verkuil --- drivers/media/pci/bt8xx/bttv-driver.c | 12 +-- drivers/media/pci/cobalt/cobalt-v4l2.c| 10 +

[RFC PATCH 01/11] v4l2-ioctl: don't use CROP/COMPOSE_ACTIVE

2018-10-05 Thread Hans Verkuil
From: Hans Verkuil Drop the deprecated _ACTIVE part. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-ioctl.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c index

[RFC PATCH 10/11] v4l2-ioctl: remove unused vidioc_g/s_crop

2018-10-05 Thread Hans Verkuil
From: Hans Verkuil Now that all drivers have dropped vidioc_g/s_crop we can remove support for them in the V4L2 core. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-dev.c | 4 ++-- drivers/media/v4l2-core/v4l2-ioctl.c | 4 include/media/v4l2-ioctl.h | 8

Re: [PATCH] media: cec: name for RC passthrough device does not need 'RC for'

2018-10-05 Thread Hans Verkuil
On 10/05/2018 12:21 AM, Sean Young wrote: > An RC device is does not need to be called 'RC for'. Simply the name > will suffice. > > Signed-off-by: Sean Young Reviewed-by: Hans Verkuil OK if I take this patch? I have a cec pull request upcoming anyway. Regards, Hans > --- >

Re: s5p_mfc and H.264 frame cropping question

2018-10-05 Thread Hans Verkuil
On 10/05/2018 05:12 AM, Tomasz Figa wrote: > Hi Hans, > > On Fri, Oct 5, 2018 at 5:02 AM Hans Verkuil wrote: >> >> Hi all, >> >> I'm looking at removing the last users of vidioc_g/s_crop from the driver and >> I came across vidioc_g_crop in drivers/media/platform/s5p-mfc/s5p_mfc_dec.c. >> >>