Re: [PATCH v1 1/1] media: atmel-isc: Add safety checks for NULL isc->raw_fmt struct

2018-11-20 Thread Eugen.Hristev
On 20.11.2018 22:43, Ken Sloat wrote: > From: Ken Sloat > > In some usages isc->raw_fmt will not be initialized. If this > is the case, it is very possible that a NULL struct de-reference > will occur, as this member is referenced many times. Hello Ken, Do you have any confidence that just

cron job: media_tree daily build: WARNINGS

2018-11-20 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Nov 21 05:00:13 CET 2018 media-tree git hash:5200ab6a32d6055428896a49ec9e3b1652c1a100 media_build

[PATCH v9 3/3] media: add Rockchip VPU JPEG encoder driver

2018-11-20 Thread Ezequiel Garcia
Add a mem2mem driver for the VPU available on Rockchip SoCs. Currently only JPEG encoding is supported, for RK3399 and RK3288 platforms. Signed-off-by: Ezequiel Garcia --- MAINTAINERS | 7 + drivers/staging/media/Kconfig | 2 +

[PATCH v9 2/3] arm64: dts: rockchip: add VPU device node for RK3399

2018-11-20 Thread Ezequiel Garcia
Add the Video Processing Unit node for the RK3399 SoC. Also, fix the VPU IOMMU node, which was disabled and lacking its power domain property. Signed-off-by: Ezequiel Garcia --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff

[PATCH v9 1/3] ARM: dts: rockchip: add VPU device node for RK3288

2018-11-20 Thread Ezequiel Garcia
Add the Video Processing Unit node for RK3288 SoC. Fix the VPU IOMMU node, which was disabled and lacking its power domain property. Signed-off-by: Ezequiel Garcia --- arch/arm/boot/dts/rk3288.dtsi | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git

[PATCH v9 0/3] Add Rockchip VPU JPEG encoder

2018-11-20 Thread Ezequiel Garcia
Hi everyone, This is a quick respin addressing Hans' feedback on the v8 version (see previous series for more details [1]). Long story short: This new version supports V4L2_PIX_FMT_JPEG capture format, which means standard userspace can be used, such as gstreamer: gst-launch-1.0 videotestsrc

[PATCH v1 1/1] media: atmel-isc: Add safety checks for NULL isc->raw_fmt struct

2018-11-20 Thread Ken Sloat
From: Ken Sloat In some usages isc->raw_fmt will not be initialized. If this is the case, it is very possible that a NULL struct de-reference will occur, as this member is referenced many times. To prevent this, add safety checks for this member and handle situations accordingly.

Re: [PATCH v8 3/3] media: add Rockchip VPU JPEG encoder driver

2018-11-20 Thread Ezequiel Garcia
On Tue, 2018-11-20 at 14:52 +0100, Hans Verkuil wrote: > On 11/19/2018 04:29 PM, Ezequiel Garcia wrote: > > Add a mem2mem driver for the VPU available on Rockchip SoCs. > > Currently only JPEG encoding is supported, for RK3399 and RK3288 > > platforms. > > > > Signed-off-by: Ezequiel Garcia > >

Re: [PATCH v5 01/11] media: ov5640: Adjust the clock based on the expected rate

2018-11-20 Thread jacopo mondi
Hi Maxime, On Tue, Nov 20, 2018 at 10:48:39AM +0100, Maxime Ripard wrote: > Hi Jacopo, > > On Wed, Nov 14, 2018 at 08:48:47PM +0100, jacopo mondi wrote: > > On Tue, Nov 13, 2018 at 02:03:15PM +0100, Maxime Ripard wrote: > > > The clock structure for the PCLK is quite obscure in the documentation,

Re: [PATCH] media: video-i2c: don't use msleep for 1ms - 20ms

2018-11-20 Thread Sakari Ailus
On Wed, Nov 21, 2018 at 12:27:40AM +0900, Akinobu Mita wrote: > Documentation/timers/timers-howto.txt says: > > "msleep(1~20) may not do what the caller intends, and will often sleep > longer (~20 ms actual sleep for any value given in the 1~20ms range)." > > So replace msleep(2) by

[PATCH] media: video-i2c: don't use msleep for 1ms - 20ms

2018-11-20 Thread Akinobu Mita
Documentation/timers/timers-howto.txt says: "msleep(1~20) may not do what the caller intends, and will often sleep longer (~20 ms actual sleep for any value given in the 1~20ms range)." So replace msleep(2) by usleep_range(2000, 3000). Reported-by: Hans Verkuil Cc: Matt Ranostay Cc: Sakari

RE: MICROCHIP ISC DRIVER Bug: Possible NULL struct pointer dereference case

2018-11-20 Thread Ken Sloat
> Hello Ken, > > Indeed this is a bug, I saw it before as well, but so far, this has not > appeared with the sensors we have connected. I have been trying to get around > to fix it, but it's not a simple fix, much rather a rework of the driver part > that handles the raw > formats. > > Feel

Re: [PATCH v8 3/3] media: add Rockchip VPU JPEG encoder driver

2018-11-20 Thread Hans Verkuil
On 11/19/2018 04:29 PM, Ezequiel Garcia wrote: > Add a mem2mem driver for the VPU available on Rockchip SoCs. > Currently only JPEG encoding is supported, for RK3399 and RK3288 > platforms. > > Signed-off-by: Ezequiel Garcia > --- > MAINTAINERS | 7 + >

Re: 'bad remote port parent' warnings

2018-11-20 Thread Fabio Estevam
Hi Sakari, On Tue, Nov 20, 2018 at 10:15 AM Sakari Ailus wrote: > Where's the DT source for the board? Board dts is arch/arm/boot/dts/imx6qdl-wandboard.dtsi SoC dtsi is arch/arm/boot/dts/imx6q.dtsi Also, since 4.20-rc the following errors are seen: [3.449564] imx-ipuv3 240.ipu:

Re: 'bad remote port parent' warnings

2018-11-20 Thread Sakari Ailus
On Tue, Nov 20, 2018 at 10:10:57AM -0200, Fabio Estevam wrote: > Hi, > > On a imx6q-wandboard running linux-next 20181120 there the following warnings: > > [4.327794] video-mux 20e.iomuxc-gpr:ipu1_csi0_mux: bad remote > port parent > [4.336118] vid

'bad remote port parent' warnings

2018-11-20 Thread Fabio Estevam
Hi, On a imx6q-wandboard running linux-next 20181120 there the following warnings: [4.327794] video-mux 20e.iomuxc-gpr:ipu1_csi0_mux: bad remote port parent [4.336118] video-mux 20e.iomuxc-gpr:ipu2_csi1_mux: bad remote port parent Is there anything we should do to prevent

Re: [PATCH] videodev2.h: add V4L2_BUF_CAP_SUPPORTS_PREPARE_BUF/CREATE_BUFS

2018-11-20 Thread kbuild test robot
Hi Hans, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.20-rc3 next-20181120] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

Re: [PATCH] videodev2.h: add V4L2_BUF_CAP_SUPPORTS_PREPARE_BUF/CREATE_BUFS

2018-11-20 Thread kbuild test robot
Hi Hans, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.20-rc3 next-20181120] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH v2 for v4.4 1/1] v4l: event: Add subscription to list before calling "add" operation

2018-11-20 Thread Mauro Carvalho Chehab
Em Tue, 20 Nov 2018 12:49:46 +0200 Sakari Ailus escreveu: > Hi Greg, > > On Mon, Nov 19, 2018 at 06:46:21PM +0100, Greg Kroah-Hartman wrote: > > On Mon, Nov 19, 2018 at 07:03:54PM +0200, Sakari Ailus wrote: > > > Hi Greg, > > > > > > On Mon, Nov 19, 2018 at 04:14:00PM +0100, Greg

Re: [PATCH v2 for v4.4 1/1] v4l: event: Add subscription to list before calling "add" operation

2018-11-20 Thread Sakari Ailus
Hi Greg, On Mon, Nov 19, 2018 at 06:46:21PM +0100, Greg Kroah-Hartman wrote: > On Mon, Nov 19, 2018 at 07:03:54PM +0200, Sakari Ailus wrote: > > Hi Greg, > > > > On Mon, Nov 19, 2018 at 04:14:00PM +0100, Greg Kroah-Hartman wrote: > > > On Wed, Nov 14, 2018 at 11:37:46AM +0200, Sakari Ailus

[GIT PULL for 4.21] Sensor and CSI driver patches

2018-11-20 Thread Sakari Ailus
Hi Mauro, Here are a bunch of sensor driver improvements as well as a driver for the Allwinner CSI parallel bridge. Finally, a small uAPI documentation fix to better document the metadata capture buffers. Please pull. The following changes since commit fbe57dde7126d1b2712ab5ea93fb9d15f89de708:

[PATCH 1/3] media: dvb_frontend: don't print function names twice

2018-11-20 Thread Mauro Carvalho Chehab
The dvb_frontend dprintk() macro already prints __func__. So, we don't need to add it again at the printed message. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_frontend.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 2/3] media: dvb_frontend: add debug message for frequency intervals

2018-11-20 Thread Mauro Carvalho Chehab
As we did an internal change inside the subsystem to always represent min/max frequencies in Hz, add a debug message, as this would help to discover bugs on drivers, if any. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_frontend.c | 3 +++ 1 file changed, 3 insertions(+)

[PATCH 3/3] media: dvb-pll: fix tuner frequency ranges

2018-11-20 Thread Mauro Carvalho Chehab
Tuners should report frequencies in Hz. That works fine on most drivers, but, in the case of dvb-pll, some settings are for satellite tuners, while others are for terrestrial/cable ones. The code was trying to solve it at probing time, but that doesn't work, as, when _attach is called, the

[PATCH for v4.20] gspca: fix frame overflow error

2018-11-20 Thread Hans Verkuil
When converting gspca to vb2 I missed that fact that the buffer sizes were rounded up to the next page size. As a result some gspca drivers (spca561 being one of them) reported frame overflows. Modify the code to align the buffer sizes to the next page size, just as the original code did. Fixes:

Re: [PATCH] videodev2.h: add V4L2_BUF_CAP_SUPPORTS_PREPARE_BUF/CREATE_BUFS

2018-11-20 Thread Sakari Ailus
On Tue, Nov 20, 2018 at 10:41:42AM +0100, Hans Verkuil wrote: > On 11/20/2018 10:27 AM, Sakari Ailus wrote: > > Hi Hans, > > > > On Tue, Nov 20, 2018 at 09:58:43AM +0100, Hans Verkuil wrote: > >> Add new buffer capability flags to indicate if the VIDIOC_PREPARE_BUF or > >> VIDIOC_CREATE_BUFS

Re: [PATCH v5 01/11] media: ov5640: Adjust the clock based on the expected rate

2018-11-20 Thread Maxime Ripard
Hi Jacopo, On Wed, Nov 14, 2018 at 08:48:47PM +0100, jacopo mondi wrote: > On Tue, Nov 13, 2018 at 02:03:15PM +0100, Maxime Ripard wrote: > > The clock structure for the PCLK is quite obscure in the documentation, and > > was hardcoded through the bytes array of each and every mode. > > > > This

Re: [PATCH] videodev2.h: add V4L2_BUF_CAP_SUPPORTS_PREPARE_BUF/CREATE_BUFS

2018-11-20 Thread Hans Verkuil
On 11/20/2018 10:27 AM, Sakari Ailus wrote: > Hi Hans, > > On Tue, Nov 20, 2018 at 09:58:43AM +0100, Hans Verkuil wrote: >> Add new buffer capability flags to indicate if the VIDIOC_PREPARE_BUF or >> VIDIOC_CREATE_BUFS ioctls are supported. > > Are there practical benefits from the change for

Re: [PATCH] videodev2.h: add V4L2_BUF_CAP_SUPPORTS_PREPARE_BUF/CREATE_BUFS

2018-11-20 Thread Sakari Ailus
Hi Hans, On Tue, Nov 20, 2018 at 09:58:43AM +0100, Hans Verkuil wrote: > Add new buffer capability flags to indicate if the VIDIOC_PREPARE_BUF or > VIDIOC_CREATE_BUFS ioctls are supported. Are there practical benefits from the change for the user space? > > Signed-off-by: Hans Verkuil > --- >

How are you today?

2018-11-20 Thread Ms.Amelia Halona
Good Day Dear, I'm Ms Amelia and am new here looking for a serious relationship with someone i can spend the rest of my life with, someone who is loving, caring, honest and faithful to spend the rest of my life with, i came across your profile and its very interesting to me and i would like

[GIT PULL FOR v4.21] mem2mem, venus and vb2 fixes/improvements

2018-11-20 Thread Hans Verkuil
The following changes since commit fbe57dde7126d1b2712ab5ea93fb9d15f89de708: media: ov7740: constify structures stored in fields of v4l2_subdev_ops structure (2018-11-06 07:17:02 -0500) are available in the Git repository at: git://linuxtv.org/hverkuil/media_tree.git tags/br-v4.21e for

[PATCH] videodev2.h: add V4L2_BUF_CAP_SUPPORTS_PREPARE_BUF/CREATE_BUFS

2018-11-20 Thread Hans Verkuil
Add new buffer capability flags to indicate if the VIDIOC_PREPARE_BUF or VIDIOC_CREATE_BUFS ioctls are supported. Signed-off-by: Hans Verkuil --- Note: the flag bits will change since there are two other patches that add flags, so the numbering will change. --- diff --git

Re: [PATCH 2/2] media: video-i2c: add Melexis MLX90640 thermal camera support

2018-11-20 Thread Hans Verkuil
On 11/19/2018 09:54 PM, Matt Ranostay wrote: > On Mon, Nov 19, 2018 at 6:26 AM Hans Verkuil wrote: >> >> On 11/01/2018 05:15 AM, Matt Ranostay wrote: >>> Add initial support for MLX90640 thermal cameras which output an 32x24 >>> greyscale pixel image along with 2 rows of coefficent data. >>> >>>