Re: [REGRESSION: wm8775, ivtv] Please revert commit fcb9757333df37cf4a7feccef7ef6f5300643864

2011-01-10 Thread Andy Walls
On Sat, 2011-01-08 at 19:45 +0100, Lawrence Rust wrote: On Sat, 2011-01-08 at 09:22 -0500, Andy Walls wrote: Thanks for the info on the PVR-150. It largely confirmed what I had surmised - that the two cards disagree about serial audio data format. Before my patch, the wm8775 was programmed

Re: [REGRESSION: wm8775, ivtv] Please revert commit fcb9757333df37cf4a7feccef7ef6f5300643864

2011-01-08 Thread Andy Walls
On Sat, 2011-01-08 at 13:09 +0100, Lawrence Rust wrote: On Mon, 2011-01-03 at 17:34 -0500, Andy Walls wrote: On Sun, 2011-01-02 at 23:00 -0500, Eric Sharkey wrote: On Fri, Dec 31, 2010 at 7:55 PM, Andy Walls awa...@md.metrocast.net wrote: Mauro, Please revert at least

Re: [PATCH 11/32] v4l/cx18: update workqueue usage

2011-01-08 Thread Andy Walls
with alloc_ordered_workqueue() without WQ_MEM_RECLAIM. Signed-off-by: Tejun Heo t...@kernel.org Cc: Andy Walls awa...@md.metrocast.net Cc: linux-media@vger.kernel.org --- Only compile tested. Please feel free to take it into the subsystem tree or simply ack - I'll route it through the wq

Re: user accesses in ivtv-fileops.c:ivtv_v4l2_write ?

2011-01-08 Thread Andy Walls
On Sun, 2011-01-09 at 00:34 +, Dr. David Alan Gilbert wrote: Hi Andy, It looks like we missed something in that copy from user patch from the end of last year: +void ivtv_write_vbi_from_user(struct ivtv *itv, + const struct v4l2_sliced_vbi_data __user

Re: [RFC/PATCH v7 01/12] media: Media device node support

2011-01-06 Thread Andy Walls
Why, yes, there is a standard: http://pubs.opengroup.org/onlinepubs/009695399/functions/xsh_chap02_03.html A somewhat verbose description of the errnos is in section 2.3. -Andy Hans Verkuil hverk...@xs4all.nl wrote: On Thursday, January 06, 2011 23:19:12 Greg KH wrote: snip +static

Re: [RFC/PATCH v7 01/12] media: Media device node support

2011-01-06 Thread Andy Walls
Yeah well, lame-o default email client on my Android phone. -Andy Greg KH gre...@suse.de wrote: A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Jan 06, 2011 at 07:24:27PM -0500, Andy Walls wrote: Why, yes, there is a standard: http

Re: [PATCH 1/3] hdpvr: Add I2C and ir-kdb-i2c registration of the Zilog Z8 IR chip

2011-01-05 Thread Andy Walls
On Wed, 2011-01-05 at 13:50 +0100, Jean Delvare wrote: On Tue, 28 Dec 2010 20:46:13 -0500, Andy Walls wrote: Add I2C registration of the Zilog Z8F0811 IR microcontroller for either lirc_zilog or ir-kbd-i2c to use. This is a required step in removing lirc_zilog's use of the deprecated

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-05 Thread Andy Walls
On Wed, 2011-01-05 at 15:45 +0100, Jean Delvare wrote: Hi Andy, On Tue, 28 Dec 2010 20:49:50 -0500, Andy Walls wrote: Remove use of deprecated struct i2c_adapter.id field. In the process, perform different detection of the HD PVR's Z8 IR microcontroller versus the other Hauppauge cards

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2011-01-05 Thread Andy Walls
On Wed, 2011-01-05 at 20:02 -0200, Mauro Carvalho Chehab wrote: Em 05-01-2011 19:51, Jean Delvare escreveu: Hi Mauro, On Wed, 05 Jan 2011 15:34:28 -0200, Mauro Carvalho Chehab wrote: Hi Jean, Thanks for your acks for patches 1 and 2. I've already applied the patches on my tree and

Re: [REGRESSION: wm8775, ivtv] Please revert commit fcb9757333df37cf4a7feccef7ef6f5300643864

2011-01-04 Thread Andy Walls
On Tue, 2011-01-04 at 08:10 +0100, Hans Verkuil wrote: On Monday, January 03, 2011 23:34:16 Andy Walls wrote: On Sun, 2011-01-02 at 23:00 -0500, Eric Sharkey wrote: On Fri, Dec 31, 2010 at 7:55 PM, Andy Walls awa...@md.metrocast.net wrote: Mauro, Please revert at least

Re: [PATCH 11/32] v4l/cx18: update workqueue usage

2011-01-04 Thread Andy Walls
On Tue, 2011-01-04 at 09:36 +0100, Tejun Heo wrote: Hello, On Mon, Jan 03, 2011 at 07:54:56PM -0500, Andy Walls wrote: 2. To prevent work items being handled by keventd/n from being delayed too long, as the deferred work in question can involve a bit of sleeping due to contention

Re: [REGRESSION: wm8775, ivtv] Please revert commit fcb9757333df37cf4a7feccef7ef6f5300643864

2011-01-03 Thread Andy Walls
On Sun, 2011-01-02 at 23:00 -0500, Eric Sharkey wrote: On Fri, Dec 31, 2010 at 7:55 PM, Andy Walls awa...@md.metrocast.net wrote: Mauro, Please revert at least the wm8775.c portion of commit fcb9757333df37cf4a7feccef7ef6f5300643864: http://git.kernel.org/?p=linux/kernel/git/torvalds

Re: Summary of REGRESSIONS which are being ignored?! (Re: Summary of the pending patches up to Dec, 31 (26 patches))

2011-01-03 Thread Andy Walls
On Mon, 2011-01-03 at 09:49 -0200, Mauro Carvalho Chehab wrote: Em 02-01-2011 17:30, Andy Walls escreveu: I don't see this patch on it's way upstream: https://patchwork.kernel.org/patch/376612/ (Sent on 5 Dec 2010) http://www.spinics.net/lists/linux-media/msg26649.html (Resent on 19

Re: [PATCH 11/32] v4l/cx18: update workqueue usage

2011-01-03 Thread Andy Walls
with alloc_ordered_workqueue() without WQ_MEM_RECLAIM. Signed-off-by: Tejun Heo t...@kernel.org Cc: Andy Walls awa...@md.metrocast.net Cc: linux-media@vger.kernel.org Tejun, I have a question about cmwq, but to ask it, I need to give the context. The non-system out_work_queue in cx18 had two

Summary of REGRESSIONS which are being ignored?! (Re: Summary of the pending patches up to Dec, 31 (26 patches))

2011-01-02 Thread Andy Walls
On Fri, 2010-12-31 at 10:41 -0200, Mauro Carvalho Chehab wrote: Dear Developers, I'm enclosing the current list of patches that I have on my queue. I did an effort to apply a large amount of patches during the past two weeks, in order to be ready for the 2.6.38 merge window, expected to be

Re: [PATCH 14/18] cx25840: Fix subdev registration in cx25840-core.c

2011-01-01 Thread Andy Walls
Igor, The proper fix is here: https://patchwork.kernel.org/patch/376612/ So, NAK on your particular patch. Mauro, I do not see the above patch at linux next. And I couldn't find it in your kernel.org tree. What is its status? This fixes a regression that is known to break cx23885 hardware

Adaptec AVC-2410 remote codes

2010-12-31 Thread Andy Walls
Mauro, Here is the lirc config file for the Adaptec AVC-2410: http://lirc.git.sourceforge.net/git/gitweb.cgi?p=lirc/lirc;a=blob;f=remotes/adaptec/lircd.conf.AVC-2410;h=3f6c5f08c8fef187d6015f4c1abe930464aa0d78;hb=HEAD The 16 bit button codes are obviously in a command:command' data payload like

[REGRESSION: wm8775, ivtv] Please revert commit fcb9757333df37cf4a7feccef7ef6f5300643864

2010-12-31 Thread Andy Walls
Mauro, Please revert at least the wm8775.c portion of commit fcb9757333df37cf4a7feccef7ef6f5300643864: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=fcb9757333df37cf4a7feccef7ef6f5300643864 It completely trashes baseband line-in audio for PVR-150 cards, and

Re: [PATCH 3/4] [media] ivtv: Add Adaptec Remote Controller

2010-12-30 Thread Andy Walls
On Thu, 2010-12-30 at 09:45 -0200, Mauro Carvalho Chehab wrote: lirc-i2c implements a get key logic for the Adaptec Remote Controller, at address 0x6b. The only driver that seems to have an Adaptec device is ivtv: $ git grep -i adaptec drivers/media drivers/media/video/cs53l32a.c: *

Re: [PATCH 3/4] [media] ivtv: Add Adaptec Remote Controller

2010-12-30 Thread Andy Walls
On Thu, 2010-12-30 at 09:45 -0200, Mauro Carvalho Chehab wrote: As we'll remove lirc_i2c from kernel, move the getkey code to ivtv driver, and use it for AVC2410. Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com diff --git a/drivers/media/video/ivtv/ivtv-i2c.c

Re: [PATCH v2] [media] ivtv: Add Adaptec Remote Controller

2010-12-30 Thread Andy Walls
On Thu, 2010-12-30 at 11:05 -0200, Mauro Carvalho Chehab wrote: From f4b19dd8ac2d15666975f262cc1bdf461d48e687 Mon Sep 17 00:00:00 2001 From: Mauro Carvalho Chehab mche...@redhat.com Date: Thu, 30 Dec 2010 09:31:10 -0200 Subject: [PATCH] [media] ivtv: Add Adaptec Remote Controller lirc-i2c

Re: [PATCH 3/4] [media] ivtv: Add Adaptec Remote Controller

2010-12-30 Thread Andy Walls
On Thu, 2010-12-30 at 11:29 -0200, Mauro Carvalho Chehab wrote: Em 30-12-2010 10:46, Andy Walls escreveu: On Thu, 2010-12-30 at 09:45 -0200, Mauro Carvalho Chehab wrote: As we'll remove lirc_i2c from kernel, move the getkey code to ivtv driver, and use it for AVC2410. Signed

Re: [PATCH 3/4] [media] ivtv: Add Adaptec Remote Controller

2010-12-30 Thread Andy Walls
On Thu, 2010-12-30 at 11:30 -0200, Mauro Carvalho Chehab wrote: Em 30-12-2010 10:36, Andy Walls escreveu: Thanks for the review. Version 3 of the patch enclosed. Still one little mistake that matters, otherwise it looks good. See below... commit 8576bd14361ec75c91ddfb49cc2df389143cf06a

Re: [PATCH 1/3] hdpvr: Add I2C and ir-kdb-i2c registration of the Zilog Z8 IR chip

2010-12-29 Thread Andy Walls
On Wed, 2010-12-29 at 09:08 -0200, Mauro Carvalho Chehab wrote: Em 28-12-2010 23:46, Andy Walls escreveu: Add I2C registration of the Zilog Z8F0811 IR microcontroller for either lirc_zilog or ir-kbd-i2c to use. This is a required step in removing lirc_zilog's use of the deprecated

Re: [PATCH 2/3] ir-kbd-i2c: Add HD PVR IR Rx support to ir-kbd-i2c

2010-12-29 Thread Andy Walls
On Wed, 2010-12-29 at 09:12 -0200, Mauro Carvalho Chehab wrote: Em 28-12-2010 23:47, Andy Walls escreveu: Add HD PVR IR Rx support to ir-kbd-i2c Hmm... I know nothing about the hardware designs used on hd-pvr, but it seems wrong to have both lirc-zilog and ir-kbd-i2c registering for RX

Re: [PATCH 0/8] Fix V4L/DVB/RC warnings

2010-12-28 Thread Andy Walls
On Tue, 2010-12-28 at 01:12 -0200, Mauro Carvalho Chehab wrote: Em 27-12-2010 21:55, Andy Walls escreveu: I have hardware for lirc_zilog. I can look later this week. That would be great! It shouldn't be hard to fix up the lirc_zilog.c use of adap-id but it may require a change to the hdpvr

Re: [PATCH 0/8] Fix V4L/DVB/RC warnings

2010-12-28 Thread Andy Walls
On Tue, 2010-12-28 at 12:45 -0200, Mauro Carvalho Chehab wrote: Em 28-12-2010 12:14, Andy Walls escreveu: On Tue, 2010-12-28 at 01:12 -0200, Mauro Carvalho Chehab wrote: Em 27-12-2010 21:55, Andy Walls escreveu: I have hardware for lirc_zilog. I can look later this week. That would

[PATCH 1/3] hdpvr: Add I2C and ir-kdb-i2c registration of the Zilog Z8 IR chip

2010-12-28 Thread Andy Walls
Add I2C registration of the Zilog Z8F0811 IR microcontroller for either lirc_zilog or ir-kbd-i2c to use. This is a required step in removing lirc_zilog's use of the deprecated struct i2c_adapter.id field. Signed-off-by: Andy Walls awa...@md.metrocast.net --- drivers/media/video/hdpvr/hdpvr

[PATCH 2/3] ir-kbd-i2c: Add HD PVR IR Rx support to ir-kbd-i2c

2010-12-28 Thread Andy Walls
Add HD PVR IR Rx support to ir-kbd-i2c Signed-off-by: Andy Walls awa...@md.metrocast.net --- drivers/media/video/ir-kbd-i2c.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/ir-kbd-i2c.c b/drivers/media/video/ir-kbd-i2c.c index dd54c3d..c87b6bc

[PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

2010-12-28 Thread Andy Walls
-by: Andy Walls awa...@md.metrocast.net --- drivers/staging/lirc/lirc_zilog.c | 47 1 files changed, 31 insertions(+), 16 deletions(-) diff --git a/drivers/staging/lirc/lirc_zilog.c b/drivers/staging/lirc/lirc_zilog.c index 52be6de..ad29bb1 100644 --- a/drivers

Re: [PATCH 0/8] Fix V4L/DVB/RC warnings

2010-12-27 Thread Andy Walls
I have hardware for lirc_zilog. I can look later this week. I also have hardware that lirc_i2c handles but not all the hardware it handles. IIRC lirc_i2c is very much like ir-kbd-i2c, so do we need it anymore? I'm not able to check for myself at the moment. Regards, Andy Mauro Carvalho

Re: [GIT PULL FOR 2.6.37] uvcvideo: BKL removal

2010-12-23 Thread Andy Walls
On Thu, 2010-12-23 at 10:02 +0100, Laurent Pinchart wrote: Hi Hans, On Monday 20 December 2010 14:09:40 Hans Verkuil wrote: On Monday, December 20, 2010 13:48:51 Laurent Pinchart wrote: What if the application wants to change the resolution during capture ? It will have to stop

[GIT PULL for 2.6.38] ivtv and cx18 fixes

2010-12-23 Thread Andy Walls
a merge conflict with v4l2_i2c_new_subdev_board changes (2010-12-11 09:07:52 -0200) are available in the git repository at: ssh://linuxtv.org/git/awalls/media_tree.git ivtv-cx18-for-38 Andy Walls (4): ivtv, cx18: Make ioremap failure messages more useful for users cx18: Only allocate

Re: smatch report: cx231xx: incorrect check in cx231xx_write_i2c_data()

2010-12-23 Thread Andy Walls
On Thu, 2010-12-23 at 19:43 +0300, Dan Carpenter wrote: Hi, I was doing an audit and I came across this. drivers/media/video/cx231xx/cx231xx-core.c +1644 cx231xx_write_i2c_data(14) warn: 'saddr_len' is non-zero. Did you mean 'saddr' 1642 if (saddr_len == 0) 1643

[RFC/PATCH] v4l2-ctrls: eliminate lockdep false alarms for struct v4l2_ctrl_handler.lock

2010-12-23 Thread Andy Walls
[a045f490] cx2341x:1534:(hdl)-lock Signed-off-by: Andy Walls awa...@md.metrocast.net diff --git a/drivers/media/video/v4l2-ctrls.c b/drivers/media/video/v4l2-ctrls.c index 9d2502c..8b7de34 100644 --- a/drivers/media/video/v4l2-ctrls.c +++ b/drivers/media/video/v4l2-ctrls.c @@ -761,10 +761,9

Re: Power frequency detection.

2010-12-19 Thread Andy Walls
Theodore, Aside from detect measurment of the power line, isn't a camera the best sort of sensor for this measurment anyway? Just compute the average image luminosity over several frames and look for (10 Hz ?) periodic variation (beats), indicating a mismatch. Sure you could just ask the

Re: Power frequency detection.

2010-12-19 Thread Andy Walls
On Sun, 2010-12-19 at 13:21 -0500, Andy Walls wrote: Theodore, Gah. I need to learn how to type or wear my glasses more often. Aside from detect measurment of the power line, isn't a camera the ^ direct measurement best sort of sensor

[RESEND] [PATCH for 2.6.37 REGRESSION] cx25840: Prevent device probe failure due to volume control ERANGE error

2010-12-19 Thread Andy Walls
driver has an unusual mapping from register values to v4l2 volume control values. Enforce the mapping limits, so that the default volume control setting does not fall out of bounds to prevent the cx25840 module device probe from failing. Signed-off-by: Andy Walls awa...@md.metrocast.net Cc: Hans

[RESEND] [PATCH for 2.6.37] cx23885, cx25840: Provide IR Rx timeout event reports

2010-12-19 Thread Andy Walls
-by: Andy Walls awa...@md.metrocast.net --- drivers/media/video/cx23885/cx23888-ir.c | 12 drivers/media/video/cx25840/cx25840-ir.c | 12 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/media/video/cx23885/cx23888-ir.c b/drivers/media/video

Re: Power frequency detection.

2010-12-19 Thread Andy Walls
On Sun, 2010-12-19 at 18:21 -0600, Theodore Kilgore wrote: If the controls are locked while the workqueue is doing the streaming, then probably that does fix the problem? Most likely, that is the simplest thing to do. Drivers are allowed to return -EBUSY per the V4L2 spec.

Re: Power frequency detection.

2010-12-19 Thread Andy Walls
On Sun, 2010-12-19 at 18:13 -0600, Theodore Kilgore wrote: On Sun, 19 Dec 2010, Andy Walls wrote: The Software for our Sakar branded Jeilin camera was a little smarter. Oh. So _you_ had a Sakar branded camera. This was one of the things that causes problems recently. In gspca.txt we

Re: tm6000 and IR

2010-12-18 Thread Andy Walls
On Fri, 2010-12-17 at 22:24 -0200, Mauro Carvalho Chehab wrote: Despite all discussions, we didn't reach an agreement yet. There are some points to consider whatever solution we do: 1) A keycode table should be able to work with a generic raw decoder. So, on all drivers, the bit order

Re: Volunteers needed: BKL removal: replace .ioctl by .unlocked_ioctl

2010-12-18 Thread Andy Walls
can tackle one or more of those, please respond. Unfortunately, those are among the hardest to convert :-( Driver list: saa7146 (Hans Verkuil) mem2mem_testdev (Pawel Osciak or Marek Szyprowski) cx23885 (Steve Toth) cx18-alsa (Andy Walls) Ack. This thing has locking problems between ALSA

Re: TeVii S470 dvb-s2 issues - 2nd try ,)

2010-12-18 Thread Andy Walls
On Sat, 2010-12-18 at 14:40 +0100, Boris Cuber wrote: Am Friday 17 December 2010 schrieben Sie: On Fri, 2010-12-17 at 12:19 +0100, Boris Cuber wrote: Hello linux-media people! I have to problems with my dvb card (TeVii S470). I already filed 2 bug reports some time ago, but no one

Re: TeVii S470 dvb-s2 issues - 2nd try ,)

2010-12-17 Thread Andy Walls
On Fri, 2010-12-17 at 12:19 +0100, Boris Cuber wrote: Hello linux-media people! I have to problems with my dvb card (TeVii S470). I already filed 2 bug reports some time ago, but no one seems to have noticed/read them, so i'm trying it here now. If you need a full dmesg, then please take a

Re: [PATCH] [media] cx231xx: Fix inverted bits for RC on PV Hybrid

2010-12-17 Thread Andy Walls
On Fri, 2010-12-17 at 15:22 -0200, Mauro Carvalho Chehab wrote: At Pixelview SBTVD Hybrid, the bits sent by the IR are inverted. Due to that, the existing keytables produce wrong codes. Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com diff --git

Re: Simple request : mini-pcie analog TV capture card

2010-12-14 Thread Andy Walls
Fernando, You should send questions to linux-media@vger.kernel.org as the video4linux list is mostly dead. The Yuan MPC718 is supported by the cx18 driver, but it is mini-pci (not mini-pcie) and has hardware mpeg2 encoding, which may be overkill for your needs. Regards, Andy Fernando

Re: [RFC/PATCH 03/19] cx18: Use the control framework.

2010-12-13 Thread Andy Walls
On Mon, 2010-12-13 at 08:32 +0100, Hans Verkuil wrote: On Sunday, December 12, 2010 19:46:33 Andy Walls wrote: Hi Hans, 1. Why set the vol step to 655, when the volume will actaully step at increments of 512? The goal of the exercise is to convert to the control framework. I don't like

Re: [RFC/PATCH 03/19] cx18: Use the control framework.

2010-12-12 Thread Andy Walls
Hans, This has at least the same two problems the change for cx25840 had: 1. Volume control init should use 65535 not 65335 2. You cannot trust reg 0x8d4 to have a value in it for the default volume that won't give an ERANGE error when you go to init the volume control. Subdev probe will

Re: [RFC/PATCH 03/19] cx18: Use the control framework.

2010-12-12 Thread Andy Walls
a working device without user controls in case of user control init failure. Regards, Andy Hans Verkuil hverk...@xs4all.nl wrote: On Sunday, December 12, 2010 19:09:36 Andy Walls wrote: Hans, This has at least the same two problems the change for cx25840 had: 1. Volume control init should

Re: user accesses in ivtv-fileops.c:ivtv_v4l2_write ?

2010-12-11 Thread Andy Walls
copy_from_user() to read the VBI data provided via user buffers. This should resolve an sparse build warning reported by Dave Gilbert. Reported-by: Dr. David Alan Gilbert li...@treblig.org Signed-off-by: Andy Walls awa...@md.metrocast.net diff --git a/drivers/media/video/ivtv/ivtv-fileops.c b

[RESEND][PATCH for stable 2.6.36 REGRESSION] cx25840: Prevent device probe failure due to volume control ERANGE error]

2010-12-10 Thread Andy Walls
The volume control scale in the cx25840 driver has an unusual mapping from register values to v4l2 volume control values. Enforce the mapping limits, so that the default volume control setting does not fall out of bounds to prevent the cx25840 module device probe from failing. Signed-off-by: Andy

Re: [stable] [RESEND][PATCH for stable 2.6.36 REGRESSION] cx25840: Prevent device probe failure due to volume control ERANGE error]

2010-12-10 Thread Andy Walls
On Fri, 2010-12-10 at 10:16 -0800, Greg KH wrote: On Fri, Dec 10, 2010 at 08:19:57AM -0500, Andy Walls wrote: Resending, since this didn't appear to make its way into in 2.6.36.2. That's because it's not in Linus's tree, right? I have to wait for that to happen before I can add

Re: Hauppauge HVR-2200 analog

2010-12-07 Thread Andy Walls
On Tue, 2010-12-07 at 12:04 +0100, Julian Scheel wrote: Hi, is there any progress on adding analog support to the HVR-2200? It seems support for the used chipsets in general is already in the kernel? It appears to be in the media_tree.git repository on the staging/for_v2.6.37-rc1 branch:

[PATCH for stable 2.6.36 REGRESSION] cx25840: Prevent device probe failure due to volume control ERANGE error

2010-12-05 Thread Andy Walls
-by: Andy Walls awa...@md.metrocast.net Cc: Hans Verkuil hverk...@xs4all.nl Cc: Mauro Carvalho Chehab mche...@redhat.com Cc: sta...@kernel.org --- drivers/media/video/cx25840/cx25840-core.c | 19 +-- 1 files changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/media/video

[PATCH for 2.6.37 REGRESSION] cx25840: Prevent device probe failure due to volume control ERANGE error

2010-12-05 Thread Andy Walls
control values. Enforce the mapping limits, so that the default volume control setting does not fall out of bounds to prevent the cx25840 module device probe from failing. Signed-off-by: Andy Walls awa...@md.metrocast.net Cc: Hans Verkuil hverk...@xs4all.nl Cc: Mauro Carvalho Chehab mche

Re: [GIT PATCHES for 2.6.38] broken cx25840 probe and CX2388[578] IR receive timeoouts

2010-12-05 Thread Andy Walls
On Sun, 2010-11-28 at 20:06 -0500, Andy Walls wrote: Mauro, Please pull the following changes for 2.6.38. Hi Mauro, Please disregard this PULL request. I have sent the cx25840 fix as a patch to the list for both 2.6.36 (stable) and 2.6.37. Regards, Andy The cx25840 module has a bad bug

[PATCH for 2.6.37] cx23885, cx25840: Provide IR Rx timeout event reports

2010-12-05 Thread Andy Walls
Provide CX2388[578] IR receive timeout (RTO) reports in the final space raw event sent up the chain to the raw IR pulse decoders. This should allow the lirc decoder to actually measure the inter-transmission gap properly. Signed-off-by: Andy Walls awa...@md.metrocast.net --- drivers/media/video

Re: [RFC v6 2/9] Documentation:DocBook:v4l: Update the controls.xml for TI FM driver

2010-12-03 Thread Andy Walls
Em 03-12-2010 10:50, manjunatha_ha...@ti.com escreveu: From: Manjunatha Halli manjunatha_ha...@ti.com Added entries for following 2 new CID's which are added for TI FM driver: - V4L2_CID_RSSI_THRESHOLD - V4L2_CID_TUNE_AF Signed-off-by: Manjunatha Halli manjunatha_ha...@ti.com

Re: Unsafe to reinsert HVR-1850 kernel modules?

2010-12-02 Thread Andy Walls
On Wed, 2010-12-01 at 21:52 -0800, David Liontooth wrote: On 11/29/2010 04:38 AM, Andy Walls wrote: On Sun, 2010-11-28 at 23:49 -0800, David Liontooth wrote: For a quick band-aid, use pci=nomsi on your kernel command line, and reboot to reset the CX23888 hardware. The problem is MSI

Re: [PATCH] media: rc: ir-lirc-codec: fix potential integer overflow

2010-12-02 Thread Andy Walls
64 bit value / 4 = 62 bit value, right? Jarod Wilson ja...@redhat.com wrote: On Thu, Dec 02, 2010 at 07:51:26AM +0300, Dan Carpenter wrote: On Fri, Nov 26, 2010 at 08:06:35PM +0300, Vasiliy Kulikov wrote: count = n / sizeof(int); - if (count LIRCBUF_SIZE || count % 2 == 0) + if

Re: [PATCH 3/7] v4l: videobuf2: add vmalloc allocator

2010-12-01 Thread Andy Walls
On Tue, 2010-11-30 at 21:57 +0100, Laurent Pinchart wrote: Hi Marek, On Tuesday 30 November 2010 11:39:41 Marek Szyprowski wrote: On Monday, November 29, 2010 10:51 AM Laurent Pinchart wrote: On Friday 19 November 2010 16:55:40 Marek Szyprowski wrote: From: Pawel Osciak

Re: Unsafe to reinsert HVR-1850 kernel modules?

2010-11-29 Thread Andy Walls
On Sun, 2010-11-28 at 23:49 -0800, David Liontooth wrote: My HVR-1850 card occasionally jams, meaning it still tunes (according to gnutv), but no mpeg stream comes through. This heals on reboot, but I figured it should also heal on module reinsertion. However, when I remove the CX23885

Re: user accesses in ivtv-fileops.c:ivtv_v4l2_write ?

2010-11-29 Thread Andy Walls
Dr. David Alan Gilbert wrote: Hi, Sparse pointed me at the following line in ivtv-fileops.c's ivtv_v4l2_write: ivtv_write_vbi(itv, (const struct v4l2_sliced_vbi_data *)user_buf, elems); Now user_buf is a parameter: const char __user *user_buf, so that is losing

[GIT PATCHES for 2.6.38] broken cx25840 probe and CX2388[578] IR receive timeoouts

2010-11-28 Thread Andy Walls
unnecessary lock around atomic clear_bit (2010-11-26 18:41:02 -0200) are available in the git repository at: ssh://linuxtv.org/git/awalls/media_tree.git ir-38 Andy Walls (2): cx25840: Prevent device probe failure due to volume control ERANGE error cx23885, cx25840: Provide an IR Rx

Re: [PATCH] ir-nec-decoder: fix extended NEC scancodes

2010-11-26 Thread Andy Walls
You might want to check the handling against this NEC datasheet http://www.datasheetcatalog.org/datasheet/nec/UPD6122G-002.pdf The datasheet calls the address bytes custom code (high byte apparently) and custom code' (low byte apparently) with both bytes sent lsb first. It appears the high

Re: [RFC/PATCH v6 02/12] media: Media device

2010-11-25 Thread Andy Walls
The signedness of char is ambiguous for 8 bit data, which is why an API would normally use u8 (or s8, I guess). Since this is known to be character data, I would think char would be fine. I am assuming C compilers would never assume multibyte chars. Regards, Andy Laurent Pinchart

Re: What should poll() return when a device is unregistered ? (was media: Media device node support)

2010-11-22 Thread Andy Walls
On Mon, 2010-11-22 at 12:36 +0100, Hans Verkuil wrote: On Monday, November 22, 2010 11:41:27 Laurent Pinchart wrote: Hi Hans, On Monday 22 November 2010 10:08:06 Hans Verkuil wrote: On Monday, November 22, 2010 00:35:54 Laurent Pinchart wrote: Hi Jonathan, This doesn't really

Re: What should poll() return when a device is unregistered ? (was media: Media device node support)

2010-11-22 Thread Andy Walls
On Mon, 2010-11-22 at 17:19 +0100, Laurent Pinchart wrote: Hi Andy, On Monday 22 November 2010 13:51:37 Andy Walls wrote: On Mon, 2010-11-22 at 12:36 +0100, Hans Verkuil wrote: On Monday, November 22, 2010 11:41:27 Laurent Pinchart wrote: Hi Hans, On Monday 22 November 2010

Re: [linux-dvb] cx23885 crashes with TeVii S470

2010-11-18 Thread Andy Walls
Try reverting the change that enabled MSI in cx23885. R, Andy Hans Houwaard h...@ginder.xs4all.nl wrote: My issue was that the only PCIe 1X slot shared an IRQ with the onboard Sound card and that caused all kinds of problems. Also I had to power off my machine if I ever had problems with the

Re: [RFC PATCH 0/8] V4L BKL removal: first round

2010-11-16 Thread Andy Walls
On Tue, 2010-11-16 at 19:38 +0100, Hans Verkuil wrote: On Tuesday, November 16, 2010 17:49:05 Hans Verkuil wrote: On Tuesday, November 16, 2010 17:01:36 Arnd Bergmann wrote: On Tuesday 16 November 2010, Hans Verkuil wrote: I think there is a misunderstanding. One V4L device (e.g. a TV

Re: [RFCv2 PATCH 15/15] cx18: convert to unlocked_ioctl.

2010-11-16 Thread Andy Walls
On Tue, 2010-11-16 at 22:56 +0100, Hans Verkuil wrote: Signed-off-by: Hans Verkuil hverk...@xs4all.nl --- drivers/media/video/cx18/cx18-streams.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/cx18/cx18-streams.c

Re: An article on the media controller

2010-11-16 Thread Andy Walls
On Tue, 2010-11-16 at 15:18 -0700, Jonathan Corbet wrote: I've just spent a fair while looking through the September posting of the media controller code (is there a more recent version?). The result is a high-level review which interested people can read here:

Re: Hauppauge WinTV MiniStick IR in 2.6.36 - [PATCH]

2010-11-15 Thread Andy Walls
On Mon, 2010-11-15 at 12:27 +0100, Richard Zidlicky wrote: Hi, for some users (thats at least one user in Italy and me) the following is required: --- linux-2.6.36/drivers/media/dvb/siano/sms-cards.c.rz 2010-11-15 11:16:56.0 +0100 +++

Re: Hauppauge WinTV MiniStick IR in 2.6.36 - [PATCH]

2010-11-15 Thread Andy Walls
On Mon, 2010-11-15 at 16:09 +0100, Richard Zidlicky wrote: On Mon, Nov 15, 2010 at 07:35:06AM -0500, Andy Walls wrote: On Mon, 2010-11-15 at 12:27 +0100, Richard Zidlicky wrote: http://git.linuxtv.org/v4l-utils.git?a=tree;f=utils/keytable;h=e599a8b5288517fc7fe58d96f44f28030b04afbc;hb=HEAD

Re: new_build on ubuntu (dvbdev.c)

2010-11-14 Thread Andy Walls
On Sun, 2010-11-14 at 20:26 +1100, Vincent McIntyre wrote: On 11/14/10, Andy Walls awa...@md.metrocast.net wrote: On Sun, 2010-11-14 at 09:08 +1100, Vincent McIntyre wrote: noop_llseek() is a newer kernl function that provided a trivial llseek() implmenetation for drivers that don't

Re: new_build on ubuntu (dvbdev.c)

2010-11-13 Thread Andy Walls
On Sun, 2010-11-14 at 09:08 +1100, Vincent McIntyre wrote: Hi, I'm trying to build on 2.6.32 (ubuntu lucid i386). I followed the instructions for building from git[1] Shouldn't you be building from: http://git.linuxtv.org/mchehab/new_build.git for backward compat builds? (I'm not

Re: Bounty for the first Open Source driver for Kinect

2010-11-10 Thread Andy Walls
IFixit has a tear down mentioning all the chips and a reference design http://www.ifixit.com/Teardown/Microsoft-Kinect-Teardown/4066/1 There's two camera sensors, an ir illuminator, four microphones, a motor, and apparently a built in usb hub. It supposedly consumes more power than a standard

RE: Format of /dev/video0 data for HVR-4000 frame grabber

2010-11-09 Thread Andy Walls
On Tue, 2010-11-09 at 10:34 +0100, Michael PARKER wrote: Daniel, Many thanks for your mail. Please excuse the naivety of my questions - I'm a h/w guy and a nube to the s/w world. Do you know which of these is the default format or how to determine the format I'm seeing coming out of

Re: [PATCH] Patch for cx18 module with added support of GoTView PCI DVD3 Hybrid tuner

2010-10-30 Thread Andy Walls
On Fri, 2010-10-29 at 01:12 +0400, Alexey Chernov wrote: Hello, I've got code which adds support of GoTView PCI DVD3 Hybrid tuner in cx18 module and Andy Walls in ivtv mailing-list gave me some advice on making a patch and sending it here. So here's the patch against staging/2.6.37-rc1 branch

Re: [PATCH] Patch for cx18 module with added support of GoTView PCI DVD3 Hybrid tuner

2010-10-30 Thread Andy Walls
On Sat, 2010-10-30 at 22:25 +0400, Alexey Chernov wrote: Hi, Andy, On Saturday 30 October 2010 20:46:26 Andy Walls wrote: Does this card have an EEPROM? I couldn't tell from pictures on the internet. (Maybe one of the chips designated U2, SU3, or SU1 is an EEPROM.) Do you happen

Re: [PATCH] Patch for cx18 module with added support of GoTView PCI DVD3 Hybrid tuner

2010-10-30 Thread Andy Walls
On Sat, 2010-10-30 at 23:28 +0400, 4ernov wrote: Thank you very much! You're welcome. It looks like patchwork picked up your patch properly: https://patchwork.kernel.org/patch/292362/ So I'll let Mauro pick it up out of patchwork and merge it, the next time he goes through the patchwork

Re: [PATCH] bttv driver memory corruption

2010-10-30 Thread Andy Walls
On Sun, 2010-10-31 at 01:40 +0200, Daniel Glöckner wrote: On Mon, Oct 25, 2010 at 11:34:40AM -0400, Laurent Birtz wrote: I've observed that the poison was corrupted at some random pages, but always in the first four bytes. The value of those bytes is 0x23232323. This byte sequence often

Re: Old patches sent via the Mailing list

2010-10-20 Thread Andy Walls
On Wed, 2010-10-20 at 07:19 +0200, Sven Barth wrote: Am 18.10.2010 08:15, schrieb Mauro Carvalho Chehab: Em 17-10-2010 21:36, Andy Walls escreveu: The last time I sent this list, I was about to travel, and I may have missed some comments, or maybe I may just forgot to update. But I

Re: [PATCH/RFC v3 0/7] Videobuf2 framework

2010-10-20 Thread Andy Walls
On Wed, 2010-10-20 at 16:18 +0900, Kyungmin Park wrote: On Wed, Oct 20, 2010 at 4:14 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Wednesday, October 20, 2010 08:41:06 Marek Szyprowski wrote: Hello, As I promissed I continue the development of the VideoBuf2 at Samsung until Pawel finds

Re: Unloading cx8802 results in crash of ir_core:ir_unregister_class

2010-10-20 Thread Andy Walls
On Wed, 2010-10-20 at 12:31 +0200, Hans-Peter Jansen wrote: Hi Mauro, since you got your fingers dirty with ir, I would like to direct this issue towards you. Unfortunately, unloading all the dvb drivers is not possible, because unloading cx8802 leads to this oops: Welcome to

Re: cx23888 board setup

2010-10-19 Thread Andy Walls
Fred, You should send mail to the linux-media list; the video4linux list is mostly dead. Analog support in the cx23885 driver is not complete. You can contact Steve Toth at kernellabs, if your company needs something in a certain timeframe and is willing to sponsor getting the functionality

Re: Old patches sent via the Mailing list

2010-10-17 Thread Andy Walls
On Sun, 2010-10-17 at 19:20 -0200, Mauro Carvalho Chehab wrote: Hi, I did a large effort during this weekend to handle the maximum amount of patches, in order to have them ready for 2.6.37. While there are still some patches marked as NEW at patchwork, and a few pending pull requests

Re: [GIT PATCHES FOR 2.6.36] Fix msp3400 regression causing mute audio

2010-10-17 Thread Andy Walls
. The original code attempted to set the volume control to its current value in order to have the set-volume control code to be called that handles the volume and muting. However, the framework will not call that code unless the new volume value is different from the old. Thanks to Andy Walls

Re: [PATCH 0/3] Remaining patches in my queue for IR

2010-10-16 Thread Andy Walls
On Sun, 2010-10-17 at 00:56 +0200, Maxim Levitsky wrote: Hi, This series is rebased on top of media_tree/staging/v2.6.37 only. Really this time, sorry for cheating, last time :-) The first patch like we agreed extends the raw packets. It touches all drivers (except imon as it isn't a raw

Bisected MSP34xx PVR-250/PVR-350 no audio in 2.6.36

2010-10-16 Thread Andy Walls
Hans, Shane Shrybman reported that in the 2.6.36 kernel, after the first capture on his PVR-250, TV audio from the RF input no longer works. I verified that RF TV audio never works with a PVR-350. I bisected the problem to this change to the msp3400 driver:

Re: [RFC PATCH] Rename video_device et al to v4l2_devnode

2010-09-26 Thread Andy Walls
Sounds good to me. I'm not to sure why you even bothered with the backward compat on the names. I think it can only lead to trouble; but it does make merging out standing patchsets easier I guess. I haven't looked at the patchset, are there any other users outside the drivers/media tree? R,

Re: RFC: BKL, locking and ioctls

2010-09-19 Thread Andy Walls
The device node isn't even the right place for drivers that provide multiple device nodes that can possibly access the same underlying data or register sets. Any core/infrastructure approach is likely doomed in the general case. It's trying to protect data and registers in a driver it knows

Re: HVR 1600 Distortion

2010-09-19 Thread Andy Walls
Try a DTV STB or VCR with an RF out on channel 3. Your card might not be bad. Your signal looks overdriven from the new MPEG you sent. I'll discuss more when I'm not typing on my smartphone's tiny little keyboard. R, Andy Josh Borke joshbo...@gmail.com wrote: On Sat, Sep 18, 2010 at 11:06

Re: RFC: BKL, locking and ioctls

2010-09-19 Thread Andy Walls
On Sun, 2010-09-19 at 18:10 +0200, Hans Verkuil wrote: On Sunday, September 19, 2010 17:38:18 Andy Walls wrote: The device node isn't even the right place for drivers that provide multiple device nodes that can possibly access the same underlying data or register sets. Any core

Re: RFC: BKL, locking and ioctls

2010-09-19 Thread Andy Walls
On Sun, 2010-09-19 at 08:43 -0300, Mauro Carvalho Chehab wrote: Hi Hans, A per-dev lock may not be good on devices where you have lots of interfaces, and that allows more than one stream per interface. So, I did a different implementation, implementing the mutex pointer per file

Re: HVR 1600 Distortion

2010-09-19 Thread Andy Walls
On Sun, 2010-09-19 at 15:10 -0400, Josh Borke wrote: On Sun, Sep 19, 2010 at 11:54 AM, Andy Walls awa...@md.metrocast.net wrote: Try a DTV STB or VCR with an RF out on channel 3. Your card might not be bad. Your signal looks overdriven from the new MPEG you sent. R, Andy Josh

Re: RFC: BKL, locking and ioctls

2010-09-19 Thread Andy Walls
On Sun, 2010-09-19 at 17:20 -0300, Mauro Carvalho Chehab wrote: Em 19-09-2010 16:06, Hans Verkuil escreveu: On Sunday, September 19, 2010 20:29:58 Mauro Carvalho Chehab wrote: Em 19-09-2010 11:58, Hans Verkuil escreveu: On Sunday, September 19, 2010 13:43:43 Mauro Carvalho Chehab wrote:

Re: HVR 1600 Distortion

2010-09-18 Thread Andy Walls
On Fri, 2010-09-17 at 18:23 -0400, Josh Borke wrote: Thanks for the response! Replies are in line. On Thu, Sep 16, 2010 at 6:48 PM, Andy Walls awa...@md.metrocast.net wrote: On Wed, 2010-09-15 at 22:54 -0400, Josh Borke wrote: I've recently noticed some distortion coming from my hvr1600

Re: RFC: control framework enhancements

2010-09-18 Thread Andy Walls
On Sat, 2010-09-18 at 14:19 +0200, Hans Verkuil wrote: Hi all, This weekend I started converting drivers to the new control framework. While doing that I realized that the control framework needs a few enhancements. Since both subdevs may have identical controls (e.g. both may have a

<    1   2   3   4   5   6   7   8   9   10   >