RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-26 Thread Chen, Ping-chung
Hi, >-Original Message- >From: Yeh, Andy >Sent: Wednesday, September 26, 2018 11:19 PM >To: Sakari Ailus ; Chen, Ping-chung > >Hi Sakari, PC, >sensors that do need >digital gain applied, too --- assuming it'd be >combined with the TRY_EXT_CTRLS roundi

RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-25 Thread Chen, Ping-chung
Hi Sakari, >-Original Message- >From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] >Sent: Wednesday, September 26, 2018 5:55 AM >Hi Ping-chung, >On Tue, Sep 25, 2018 at 10:17:48AM +0000, Chen, Ping-chung wrote: >... > > > > Controls that have a

RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-25 Thread Chen, Ping-chung
Hi Sakari, >-Original Message- >From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] >Sent: Tuesday, September 25, 2018 5:25 PM >To: Chen, Ping-chung >Cc: Ricardo Ribalda Delgado ; Laurent Pinchart >Subject: Re: [PATCH v5] media: imx208: Add imx208 camera senso

RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-21 Thread Chen, Ping-chung
Typo. -Original Message- From: Chen, Ping-chung Sent: Friday, September 21, 2018 3:07 PM To: 'Ricardo Ribalda Delgado' ; Laurent Pinchart Cc: Sakari Ailus ; tf...@chromium.org; Sakari Ailus ; sylwester.nawro...@gmail.com; linux-media ; Yeh, Andy ; Lai, Jim ; grund...@chromium.org

RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-21 Thread Chen, Ping-chung
Hi Sakari, >-Original Message- >From: Ricardo Ribalda Delgado [mailto:ricardo.riba...@gmail.com] >Sent: Friday, September 21, 2018 5:55 AM >HI On Thu, Sep 20, 2018 at 11:13 PM Laurent Pinchart wrote: > > Hi Sakari, > > On Thursday, 20 September 2018 23:56:59 EEST Sakari Ailus wrote: >

RE: [RESEND PATCH v4] media: imx208: Add imx208 camera sensor driver

2018-08-02 Thread Chen, Ping-chung
Hi Tomasz, >On Fri, Aug 3, 2018 at 11:57 AM Ping-chung Chen >wrote: > > From: "Chen, Ping-chung" > > Add a V4L2 sub-device driver for the Sony IMX208 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data.

RE: [PATCH v3] media: imx208: Add imx208 camera sensor driver

2018-08-01 Thread Chen, Ping-chung
Hi Tomasz, Please see my comments. -Original Message- >Hi Ping-chung, >On Wed, Aug 1, 2018 at 11:31 AM Ping-chung Chen >wrote: > > From: "Chen, Ping-chung" > > Add a V4L2 sub-device driver for the Sony IMX208 image sensor. > This is a camera se

RE: [PATCH v2] media: imx208: Add imx208 camera sensor driver

2018-07-31 Thread Chen, Ping-chung
Hi Tomasz, Please check my comments below. >Hi Ping-chung, >On Mon, Jul 30, 2018 at 6:19 PM Ping-chung Chen >wrote: > > From: "Chen, Ping-chung" > > Add a V4L2 sub-device driver for the Sony IMX208 image sensor. > This is a camera sensor using the I2C b

RE: [PATCH v2] media: imx208: Add imx208 camera sensor driver

2018-07-30 Thread Chen, Ping-chung
Hi Tomasz, >-Original Message- > +/* Get bayer order based on flip setting. */ static __u32 > +imx208_get_format_code(struct imx208 *imx208) >Why not just "u32"? Its return value will be assigned to the variable code which belongs to the structure v4l2_subdev_mbus_code_enum, and the

RE: [PATCH v2] media: imx208: Add imx208 camera sensor driver

2018-07-30 Thread Chen, Ping-chung
Hi Sakari, We will test the new flow on Atlas. If everything is fine we will merge the code into patch v3 or v4. Thanks, PC Chen -Original Message- From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] Sent: Monday, July 30, 2018 6:39 PM To: Chen, Ping-chung Cc: linux-media

RE: [PATCH] media: imx208: Add imx208 camera sensor driver

2018-07-17 Thread Chen, Ping-chung
Hi Sakari, Some of suggestions below has been added in to [PATCH v2] or [PATCH v3]. We will fix others in PATCH v4 soon. Thanks, PC -Original Message- From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] Sent: Monday, July 16, 2018 11:59 PM To: Chen, Ping-chung Cc: linux-media