}
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
tree: git://linuxtv.org/snawrocki/samsung.git for-v3.16
head: 13b46c7a03adbcc347b77a13ed27066bc92d515c
commit: 192292403147877c7d5f737a3cc751ded397aef7 [45/81] [media] em28xx: add
[2013:025f] PCTV tripleStick (292e)
drivers/media/dvb-frontends/si2168.c:47 si2168_cmd_execute() warn: add some
There was a mix of 4 space and tab indenting here which was confusing.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
v3: Just fix all the surrounding indents as well.
v2: At first I thought the code was buggy and was missing curly braces
but it was just the indenting which
From: Pali Rohár pali.ro...@gmail.com
This patch fixes an off by one check in bcm2048_set_region().
Reported-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Pali Rohár pali.ro...@gmail.com
Signed-off-by: Pavel Machek pa...@ucw.cz
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
On Tue, Apr 22, 2014 at 11:38:36AM +0200, Pavel Machek wrote:
Feel free to resubmit the patch yourself.
No problem. Happy to help.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More
From: Pali Rohár pali.ro...@gmail.com
This patch fixes an off by one check in bcm2048_set_region().
Reported-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Pali Rohár pali.ro...@gmail.com
Signed-off-by: Pavel Machek pa...@ucw.cz
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
What ever happened with this?
regards,
dan carpenter
On Wed, Nov 06, 2013 at 07:13:43PM +0300, Dan Carpenter wrote:
Hello Philipp Zabel,
This is a semi-automatic email about new static checker warnings.
The patch 5677e3b04d3b: [media] coda: update CODA7541 to firmware
1.4.50 from Jun 21
The two subjects are really close to being the same. You should choose
better subjects. Like:
[PATCH 2/2] staging: media: omap24xx: use pr_info() instead of KERN_INFO
(All the checkpatch.pl people use the exact same subject for everything
though, so you're not alone in this).
regards,
dan
a patch for a single style issue in the
staging tree. All newbies... Hoping to be back with more substantial
contributions soon.
Yeah, I know about eudyptula. No worries. Newbies are welcome in
staging.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux
Whatever happened with this btw? Also are you sure we don't need a
second check after line 457?
regards,
dan carpenter
On Tue, Aug 27, 2013 at 04:26:07PM +0200, Sylwester Nawrocki wrote:
On 08/27/2013 04:19 PM, Dan Carpenter wrote:
On Sun, Aug 25, 2013 at 02:23:18PM +0200, Sylwester Nawrocki
,
+__func__);
It should be pr_err() or something. But actually ir can't be NULL so
just delete the whole condition.
return -EINVAL;
}
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message
On Wed, Apr 02, 2014 at 02:49:03AM -0700, Daeseok Youn wrote:
ir is already checked before calling unregister_from_lirc().
Reviewed-by: Dan Carpenter dan.carpen...@oracle.com
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body
.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
Reviewed-by: Antti Palosaari cr...@iki.fi
---
This is a static checker fix and I haven't tested it but the security
implications are quite bad so we should fix this.
diff --git a/drivers/media/dvb-core/dvb_frontend.c
b/drivers/media/dvb-core
Oops. I send this to Mauro's old email address. Sorry about that.
regards,
dan carpenter
On Tue, Apr 01, 2014 at 05:38:07PM +0300, Dan Carpenter wrote:
I'd like to send this patch except that it breaks
cx24116_send_diseqc_msg(). The cx24116 driver accepts -msg_len values
up to 24
The else statement here is not aligned with the correct if statement.
I think the code works as intended and it's just the indenting which is
wrong. Also kernel style says we should use curly braces here so I have
added those.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
This patch
On Fri, Mar 07, 2014 at 05:46:28PM +0100, Frank Schäfer wrote:
Am 05.03.2014 12:09, schrieb Dan Carpenter:
This code is correct but the indenting is wrong and triggers a static
checker warning add curly braces?.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
v2: in v1 I
Hi Mauro,
FYI, there are new smatch warnings show up in
tree: git://linuxtv.org/media_tree.git master
head: 59432be1c7fbf2a4f608850855ff649bee0f7b3b
commit: b240eacdd536bac23c9d48dfc3d527ed6870ddad [463/499] [media] drx-j: get
rid of drx_driver.c
New smatch warnings:
Hi Mauro,
FYI, there are new smatch warnings show up in
tree: git://linuxtv.org/media_tree.git master
head: 59432be1c7fbf2a4f608850855ff649bee0f7b3b
commit: b78359a6894ac3451bec3fde5d0499fba87b8b67 [467/499] [media] drx-j: get
rid of the remaining drx generic functions
New smatch warnings:
This code is correct but the indenting is wrong and triggers a static
checker warning add curly braces?.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
v2: in v1 I added curly braces.
diff --git a/drivers/media/usb/em28xx/em28xx-cards.c
b/drivers/media/usb/em28xx/em28xx-cards.c
index
ARRAY_SIZE(buf) (8 elements) was intended instead of sizeof(buf) (16
bytes). But this is just a sanity check and the callers always pass
valid values so this doesn't cause a problem.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/pci/ttpci/av7110_hw.c
b
intput-fe can't be NULL because if demod_attach_drxk()
fails to allocate it, then we would have return an error code.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/pci/ddbridge/ddbridge-core.c
b/drivers/media/pci/ddbridge/ddbridge-core.c
index 9375f30d9a81
Thank you so much for the review. I should have noticed that myself...
I will send a patch to correct the indenting instead.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info
reviewed this code for some time to see if something
else was intended, but have concluded that it was simply an oversight
and should be removed. Removing this duplicative check gains us an
third indent level.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
v2: add the returns
Guys, what Manu is saying is purest nonsense. The lock variable is a
stack variable, it's not a demodulator Read-modify-Write register.
The implications of changing if (!lock) to if (lock) are simple and
obvious.
He's not reviewing patches, he's just NAKing them. It's not helpful.
regards,
dan
On Thu, Feb 20, 2014 at 11:24:21AM +0100, Hans Verkuil wrote:
Hi Dan,
This can be improved even more:
Sure. Thanks. I will send v2 tomorrow.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord
On Tue, Feb 18, 2014 at 09:25:36AM +0530, Manu Abraham wrote:
Hi Dan,
On Thu, Feb 6, 2014 at 2:58 PM, Dan Carpenter dan.carpen...@oracle.com
wrote:
1) We can flip the if (!lock) check to if (lock) return lock; and
then remove a big chunk of indenting.
2) There is a redundant
err is zero here so we don't need to check again.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c
b/drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c
index bf3e5c317a26..e60cbb3aa609 100644
--- a/drivers/media/usb/gspca/stv06xx
On Wed, Feb 19, 2014 at 10:52:32AM +0530, Manu Abraham wrote:
On Tue, Feb 18, 2014 at 2:26 PM, Dan Carpenter dan.carpen...@oracle.com
wrote:
On Tue, Feb 18, 2014 at 09:25:36AM +0530, Manu Abraham wrote:
Hi Dan,
On Thu, Feb 6, 2014 at 2:58 PM, Dan Carpenter dan.carpen...@oracle.com
There were some missing curly braces so it always says that the transfer
mode changed even if it didn't. Also the indenting uses spaces instead
of tabs.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/usb/em28xx/em28xx-cards.c
b/drivers/media/usb/em28xx/em28xx
No need to check lock twice here.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/dvb-frontends/stv0900_sw.c
b/drivers/media/dvb-frontends/stv0900_sw.c
index 0a40edfad739..4ce1d260b3eb 100644
--- a/drivers/media/dvb-frontends/stv0900_sw.c
+++ b/drivers/media/dvb
1) We can flip the if (!lock) check to if (lock) return lock; and
then remove a big chunk of indenting.
2) There is a redundant if (!lock) which we can remove since we
already know that lock is zero. This removes another indent level.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
From the context this should be hex 0x80 instead of decimal 80.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
Untested.
diff --git a/drivers/media/dvb-frontends/tda18271c2dd.c
b/drivers/media/dvb-frontends/tda18271c2dd.c
index 2c54586ac07f..de0a1c110972 100644
--- a/drivers/media
ret is an error code here, we already tested that.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/dvb-frontends/tda10071.c
b/drivers/media/dvb-frontends/tda10071.c
index 8ad3a57cf640..a76df29c4973 100644
--- a/drivers/media/dvb-frontends/tda10071.c
+++ b
break;
4681 }
4682 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Mauro,
FYI, there are new smatch warnings show up in
tree: git://linuxtv.org/media_tree.git master
head: 587d1b06e07b4a079453c74ba9edf17d21931049
commit: 587d1b06e07b4a079453c74ba9edf17d21931049 [499/499] [media] rc-core:
reuse device numbers
drivers/media/rc/rc-main.c:1201
by the firmware?
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
if (fw == NULL)
^^
Check.
555 return NULL;
556
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
)
^^^
This would be cleaner if it were if (on == state-power)
1044 goto out;
1045
1046 if (on) {
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info
On Wed, Jan 08, 2014 at 12:58:35PM +0100, Andrzej Hajda wrote:
On 01/08/2014 10:58 AM, Dan Carpenter wrote:
Hello Andrzej Hajda,
The patch 7d459937dc09: [media] Add driver for Samsung S5K5BAF
camera sensor from Dec 5, 2013, leads to the following
static checker warning
This driver won't link without USB support.
Reported-by: Jim Davis jim.ep...@gmail.com
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/staging/media/sn9c102/Kconfig
b/drivers/staging/media/sn9c102/Kconfig
index d8ae2354b626..3ab9c81173da 100644
--- a/drivers/staging
There are several error paths which don't unlock on error.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/i2c/lm3560.c b/drivers/media/i2c/lm3560.c
index ab5857d66f2d..fd96cfd6a9ec 100644
--- a/drivers/media/i2c/lm3560.c
+++ b/drivers/media/i2c/lm3560.c
and the bug doesn't cause
problems in real life.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/staging/media/omap4iss/iss_video.c
b/drivers/staging/media/omap4iss/iss_video.c
index 766491e6a8d0..c9b71c750b15 100644
--- a/drivers/staging/media/omap4iss/iss_video.c
+++ b/drivers
is a no-op.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/staging/media/omap4iss/iss_csi2.c
b/drivers/staging/media/omap4iss/iss_csi2.c
index 0ee8381c738d..7ab05126be5d 100644
--- a/drivers/staging/media/omap4iss/iss_csi2.c
+++ b/drivers/staging/media/omap4iss
scratch_get(usbvision, strip_data, strip_len);
^
Then we scribble on the stack here because strip_data only has
USBVISION_STRIP_LEN_MAX bytes. It is a security problem.
regards,
dan carpenter
--
To unsubscribe from this list: send the line
merging
and branches. Is it still better/suitable/possible to sync some bug fix
patches from staging brach to next brach?
next syncs with everyone once a day.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord
state-status = FE_STATUS_TUNE_FAILED;
3183 }
3184 break;
3185
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Btw, the MAINTAINERS file says the ivtv list is moderated but actually
it's a subscriber only list... Sucks.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
We introduced a couple new error paths which are missing unlocks.
Fixes: 7760e148350b ('[media] af9035: Don't use dynamic static allocation')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/usb/dvb-usb-v2/af9035.c
b/drivers/media/usb/dvb-usb-v2/af9035.c
index
It upsets static checkers when we don't check for allocation failure. I
moved the memset() of tv earlier so we don't use uninitialized data on
error.
Fixes: 1d212cf0c2d8 ('[media] cx18: struct i2c_client is too big for stack')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git
We recently introduced some new error paths which are missing their
unlocks.
Fixes: 64f7ef8afbf8 ('[media] cxusb: Don't use dynamic static allocation')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/usb/dvb-usb/cxusb.c
b/drivers/media/usb/dvb-usb/cxusb.c
index
We recently introduced some new error paths but the unlocks are missing.
Fixes: 0065a79a8698 ('[media] dw2102: Don't use dynamic static allocation')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/usb/dvb-usb/dw2102.c
b/drivers/media/usb/dvb-usb/dw2102.c
index
.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Nov 11, 2013 at 12:46:24PM +0100, Michal Nazarewicz wrote:
go variable is initialised only after the switch case so it cannot be
dereferenced prior to that happening.
Signed-off-by: Michal Nazarewicz min...@mina86.com
Looks good. Thanks. :)
regards,
dan carpenter
There are 3 other uses before go gets initialized.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
should actually be (0xf 28).
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/platform/exynos4-is/mipi-csis.c
b/drivers/media/platform/exynos4-is/mipi-csis.c
index 9fc2af6..31dfc50 100644
--- a/drivers/media/platform/exynos4-is/mipi-csis.c
+++ b/drivers/media/platform
devm_ioremap() returns NULL on error, it doesn't return an ERR_PTR.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/platform/ti-vpe/vpe.c
b/drivers/media/platform/ti-vpe/vpe.c
index 4e58069..e163466 100644
--- a/drivers/media/platform/ti-vpe/vpe.c
+++ b/drivers
if (ctx-codec-src_fourcc == V4L2_PIX_FMT_H264
^^
Patch introduces a new unchecked dereference.
1531 dev-devtype-product != CODA_DX6)
1532 ctx-internal_frames[i].size += ysize/4;
regards,
dan carpenter
;
There are several other uses of go before it has been initialized.
Probably you will just want to change these back to pr_info(). Some of
the messages are not very useful like:
dev_info(go-dev, Sensoray 2250 found\n);
You can delete that one.
regards,
dan carpenter
--
To unsubscribe from
cx23885_set_frontend_hook(port, fe0-dvb.frontend);
^
Dereference.
1151 break;
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord
We dereference dev after it has already been freed.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/usb/cx231xx/cx231xx-cards.c
b/drivers/media/usb/cx231xx/cx231xx-cards.c
index e9d017b..528cce9 100644
--- a/drivers/media/usb/cx231xx/cx231xx-cards.c
+++ b
.
Yeah... Pull request get far less review. I never bother reviewing
them, honestly. I feel bad for that.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
:
media_entity_pipeline_stop(video-video.entity);
err_media_entity_pipeline_start:
if (video-iss-pdata-set_constraints)
video-iss-pdata-set_constraints(video-iss, false);
video-queue = NULL;
mutex_unlock(video-stream_lock);
return ret;
}
regards,
dan carpenter
CX23885_BOARD_HAUPPAUGE_HVR1255:
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
spin_lock_irq().
It's called from __enqueue_in_driver().
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
v2: The first version changed everything to irq_save/restore() but that
wasn't right because we wanted IRQs enabled and not simply restored.
diff --git a/drivers/media/platform
On Sun, Aug 25, 2013 at 02:23:18PM +0200, Sylwester Nawrocki wrote:
On 08/23/2013 11:46 AM, Dan Carpenter wrote:
[ Going through some old warnings... ]
Hello Sylwester Nawrocki,
This is a semi-automatic email about new static checker warnings.
The patch babde1c243b2: [media] V4L: Add
The check is off by one so we could read one space past the end of the
array.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/i2c/s5k6aa.c b/drivers/media/i2c/s5k6aa.c
index 789c02a..629a5cd 100644
--- a/drivers/media/i2c/s5k6aa.c
+++ b/drivers/media/i2c/s5k6aa.c
The should be = otherwise we read one space beyond the end of the
array.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/i2c/ov9650.c b/drivers/media/i2c/ov9650.c
index 1dbb811..4da90c6 100644
--- a/drivers/media/i2c/ov9650.c
+++ b/drivers/media/i2c/ov9650.c
offset = S5PCSIS_PKTDATA_EVEN;
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
There is a stray '!' character so the error message never gets printed.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
Static checker stuff. Not tested.
diff --git a/drivers/media/platform/exynos4-is/fimc-is-regs.c
b/drivers/media/platform/exynos4-is/fimc-is-regs.c
index 63c68ec
Because i is unsigned then i-- = 0 is always true. If we don't
find what we are looking for then we loop forever.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
Why do we count backwards anyway? Counting upwards is easier.
diff --git a/drivers/media/platform/s3c-camif/camif-regs.c
There is a return in the middle where we haven't restored the IRQs to
their original state.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/platform/soc_camera/mx3_camera.c
b/drivers/media/platform/soc_camera/mx3_camera.c
index 1047e3e..4bae910 100644
;
^^
Dereference.
461 }
462
463 if (fmt == NULL)
^^^
Check.
464 return -EINVAL;
465 *num_planes = 1;
regards,
dan carpenter
The i part of the i ARRAY_SIZE() condition was missing.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/platform/sh_vou.c b/drivers/media/platform/sh_vou.c
index 7a9c5e9..41f612c 100644
--- a/drivers/media/platform/sh_vou.c
+++ b/drivers/media/platform
The | operation has higher precedence that ?: so this couldn't
return both flags set at once as intended.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
Static checker stuff. Untested.
diff --git a/drivers/media/radio/radio-sf16fmr2.c
b/drivers/media/radio/radio-sf16fmr2.c
index
the
bug then we are hiding real problems and making them more difficult
to find.
Just drop this chunk.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
p_ca_slot_info was allocated with kmalloc() so we need to clear it
before passing it to the user.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/pci/bt8xx/dst_ca.c b/drivers/media/pci/bt8xx/dst_ca.c
index 0e788fc..6b9dc3f 100644
--- a/drivers/media/pci/bt8xx
On Thu, Jul 25, 2013 at 07:29:09PM +0200, walter harms wrote:
Am 25.07.2013 18:46, schrieb Dan Carpenter:
p_ca_slot_info was allocated with kmalloc() so we need to clear it
before passing it to the user.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers
I have reorganized the error handling into a simpler and more canonical
format.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/staging/media/lirc/lirc_igorplugusb.c
b/drivers/staging/media/lirc/lirc_igorplugusb.c
index 2faa391..4cf3933 100644
--- a/drivers/staging
On Wed, Jun 26, 2013 at 11:00:40AM +0300, Andy Shevchenko wrote:
On Wed, 2013-06-26 at 10:53 +0300, Dan Carpenter wrote:
I have reorganized the error handling into a simpler and more canonical
format.
Since you reorganize error handling, might be worth to convert it to
devm_*?
If you
On Wed, Jun 26, 2013 at 05:37:36PM +0300, Andy Shevchenko wrote:
From: Dan Carpenter dan.carpen...@oracle.com
We have reorganized the error handling into a simpler and more canonical
format.
Additionally we removed extra empty lines, switched to devm_kzalloc(), and
substitute 'minor
On Wed, Jun 26, 2013 at 06:29:12PM +0300, Andy Shevchenko wrote:
On Wed, 2013-06-26 at 18:10 +0300, Dan Carpenter wrote:
On Wed, Jun 26, 2013 at 05:37:36PM +0300, Andy Shevchenko wrote:
From: Dan Carpenter dan.carpen...@oracle.com
We have reorganized the error handling into a simpler
Ping?
regards,
dan carpenter
On Sat, Apr 13, 2013 at 12:32:15PM +0300, Dan Carpenter wrote:
These structs have holes and reserved struct members which aren't
cleared. I've added a memset() so we don't leak stack information.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff
The last part of the u_ent.name buffer isn't cleared so it still has
uninitialized stack memory.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
index 99b80b6..1957c0d 100644
--- a/drivers/media/media-device.c
+++ b
On Sun, Apr 21, 2013 at 01:51:56PM +0200, walter harms wrote:
Am 21.04.2013 13:10, schrieb Dan Carpenter:
The last part of the u_ent.name buffer isn't cleared so it still has
uninitialized stack memory.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers
duplication in si476x_radio_read_rsq_blob and
si476x_radio_read_rsq_primary_blob.
* Add some BUG_ON statements for function pointers that should never be NULL
Signed-off-by: Andrey Smirnov andrew.smir...@gmail.com
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
This should be a Reported
The test as written is always false. It looks like the intent was to
test that the bit was not set.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/tuners/r820t.c b/drivers/media/tuners/r820t.c
index 905a106..ba033fd 100644
--- a/drivers/media/tuners/r820t.c
I've moved the kfree(fe-tuner_priv) one line earlier, otherwise it is
a no-op.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
This is a static checker fix and I have not tested it.
diff --git a/drivers/media/tuners/r820t.c b/drivers/media/tuners/r820t.c
index ba033fd..36ddbf1 100644
Sparse complains that these are dubious one-bit signed bitfields and
the comment says it was intended to be 1 and 0 instead of -1 and 0.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/dvb-frontends/lg2160.h
b/drivers/media/dvb-frontends/lg2160.h
index a5f0368
: dubious one-bit signed
bitfield
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/staging/media/go7007/go7007-priv.h
b/drivers/staging/media/go7007/go7007-priv.h
index 8bde187..6e16af7 100644
--- a/drivers/staging/media/go7007/go7007-priv.h
+++ b/drivers/staging/media
Any feedback on this?
I forgot to CC Steven Toth last time because he would know about the
cx24116 driver. I've looked at it again and it still looks like
cx24116_send_diseqc_msg() is copying garbage into the
state-dsec_cmd.args[] array.
regards,
dan carpenter
On Tue, Apr 02, 2013 at 10:51
These structs have holes and reserved struct members which aren't
cleared. I've added a memset() so we don't leak stack information.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
index 99b80b6..450c0d1 100644
.
The one place where that's not true is when we check -rds_blckcnt
instead of -rsq_status. In those cases, we would want to call
-rsq_status but we instead return -ENOENT.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
Please review this carefully. I don't have the hardware to test
On Tue, Apr 09, 2013 at 07:20:19AM +0200, Julia Lawall wrote:
On Tue, 9 Apr 2013, Dan Carpenter wrote:
We should unlock here and do some cleanup before returning.
We can't actually hit this return path with the current code, so this
patch is a basically a cleanup and doesn't change how
that it doesn't match the debug code.
My main concern is that we limit the size of pktlen but then we only
use it for debug output.
642 break;
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord
We should unlock here and do some cleanup before returning.
We can't actually hit this return path with the current code, so this
patch is a basically a cleanup and doesn't change how the code works.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/staging/media
.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/dvb-core/dvb_frontend.c
b/drivers/media/dvb-core/dvb_frontend.c
index 57601c0..3d1eee6 100644
--- a/drivers/media/dvb-core/dvb_frontend.c
+++ b/drivers/media/dvb-core/dvb_frontend.c
@@ -2265,7 +2265,13 @@ static int
this code is doing. Instead of sizeof(*buf) it should be something
like buflen, msg[i].len, msg[i].len + 1 or msg[i].len + 3.
I'm not sure which is correct here or what it's doing, sorry.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body
On Tue, Mar 26, 2013 at 10:04:15AM +0300, Dan Carpenter wrote:
On Tue, Mar 26, 2013 at 02:42:47PM +0800, Wei Yongjun wrote:
From: Wei Yongjun yongjun_...@trendmicro.com.cn
sizeof() when applied to a pointer typed expression gives the
size of the pointer, not that of the pointed data
Smatch complains that cmdbuf[cmdcount - length] might go past the end
of the array. It's an easy warning to silence by moving the limit
check earlier.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c
index bdd1ed8..5b5b6e6
On Tue, Feb 12, 2013 at 01:20:36PM -0800, Joe Perches wrote:
His email bounces and he hasn't done work on
these sections in a couple of years.
I've added him to the CC list.
Can we just update MAINTAINERS with the correct email address? It's
been useful to CC him on stuff.
regards,
dan
301 - 400 of 680 matches
Mail list logo
