[RFC PATCH] Add new value for V4L2_CID_MPEG_STREAM_VBI_FMT for userdata GOP

2013-01-30 Thread Devin Heitmueller
Add a new possible value to the V4L2 API for embedded VBI data, which allows for embedding of CC and teletext data in the userdata section of the GOP. This allows for compatibility with applications such as VLC which already have code to read captions out of the userdata area for ATSC A/53

Re: [RFC PATCH] em28xx: fix bytesperline calculation in TRY_FMT

2013-01-29 Thread Devin Heitmueller
-by: Devin Heitmueller dheitmuel...@kernellabs.com -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [RFCv1 PATCH 00/20] cx231xx: v4l2-compliance fixes

2013-01-29 Thread Devin Heitmueller
On Tue, Jan 29, 2013 at 11:32 AM, Hans Verkuil hverk...@xs4all.nl wrote: I will take a closer look at the vbi support, though.. It would be nice to get that working. FYI: I had the VBI support working when I submitted the driver upstream (at least for NTSC CC). If it doesn't work, then

Re: [PATCH RFCv10 00/15] DVB QoS statistics API

2013-01-15 Thread Devin Heitmueller
On Tue, Jan 15, 2013 at 10:21 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Lets say SS, SNR, BER, UCB are queried, but only SS and SNR are ready to be returned, whilst rest are not possible? As I remember DVBv5 API is broken by design and cannot return error code per request. The

Re: Problem between DMB-TH USB dongle drivers and Frontend broken (DVBv3 migrate to DVBv5)

2013-01-14 Thread Devin Heitmueller
On Mon, Jan 14, 2013 at 1:01 PM, nise.design nise.des...@gmail.com wrote: After google search I think the problem may be come from connection between DMB-TH drivers and dvb_frontend.c broken. I wanted to know any example code or instruction about DVBv3 driver connect to dvb_frontend.c. Thank

Re: em28xx, sound problems, STV40, linux 3.7.1

2013-01-08 Thread Devin Heitmueller
On Tue, Jan 8, 2013 at 12:54 PM, Frank Schäfer fschaefer@googlemail.com wrote: Thank you for reporting this issue. Is there any known kernel version where this has been working ? Regards, Frank Frank, Just an FYI: I'm already actively looking into this. Devin -- Devin J. Heitmueller

Re: [PATCH 15/15] em28xx: convert to videobuf2

2013-01-08 Thread Devin Heitmueller
On Tue, Jan 8, 2013 at 1:40 PM, Frank Schäfer fschaefer@googlemail.com wrote: Bad news. :( The patch seems to break USB bulk transfer mode. The framerate is zero. I've tested with the Silvercrest webcam and the Cinergy 200. Both devices work fine when selecting isoc transfers. I'll take a

Re: [PATCH RFCv9 1/4] dvb: Add DVBv5 stats properties for Quality of Service

2013-01-08 Thread Devin Heitmueller
On Tue, Jan 8, 2013 at 6:18 PM, Simon Farnsworth simon.farnswo...@onelan.com wrote: The wireless folk use dBm (reference point 1 milliwatt), as that's the reference point used in the 802.11 standard. Perhaps we need an extra FE_SCALE constant; FE_SCALE_DECIBEL has no reference point (so

[GIT PULL FOR 3.9] em28xx videobuf2 support and v4l2-compliance fixes

2013-01-04 Thread Devin Heitmueller
) Devin Heitmueller (1): em28xx: convert to videobuf2 Hans Verkuil (14): em28xx: fix querycap. em28xx: remove bogus input/audio ioctls for the radio device. em28xx: fix VIDIOC_DBG_G_CHIP_IDENT compliance errors

Re: [GIT PULL FOR 3.9] em28xx videobuf2 support and v4l2-compliance fixes

2013-01-04 Thread Devin Heitmueller
On Fri, Jan 4, 2013 at 2:59 PM, Ezequiel Garcia elezegar...@gmail.com wrote: Maybe I'm wrong, but weren't **all** changes supposed to be sent as a PATCH to the mailing list for community review, before the PULL request was sent? No, you are correct. I did a PULL specifically because Mauro

[PATCH 00/15] em28xx VBI2 port and v4l2-compliance fixes

2013-01-04 Thread Devin Heitmueller
This patch series converts the em28xx driver to videobuf2 and fixes a number of issues found with v4l2-compliance on em28xx. Devin Heitmueller (1): em28xx: convert to videobuf2 Hans Verkuil (14): em28xx: fix querycap. em28xx: remove bogus input/audio ioctls for the radio device. em28xx

[PATCH 01/15] em28xx: fix querycap.

2013-01-04 Thread Devin Heitmueller
Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/usb/em28xx/em28xx-video.c | 42 ++- 1 file changed, 19 insertions(+), 23 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx

[PATCH 02/15] em28xx: remove bogus input/audio ioctls for the radio device.

2013-01-04 Thread Devin Heitmueller
Radio devices should not implement those ioctls. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/usb/em28xx/em28xx-video.c | 35 --- 1 file changed, 35 deletions(-) diff --git

[PATCH 04/15] em28xx: fix tuner/frequency handling

2013-01-04 Thread Devin Heitmueller
v4l2-compliance found problems with frequency clamping that wasn't reported correctly and missing tuner index checks. Also removed unnecessary tuner type checks (these are now done by the v4l2 core). Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Devin Heitmueller dheitmuel

[PATCH 06/15] em28xx: convert to the control framework.

2013-01-04 Thread Devin Heitmueller
Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/usb/em28xx/em28xx-cards.c | 24 +++ drivers/media/usb/em28xx/em28xx-video.c | 248 +++ drivers/media/usb/em28xx/em28xx.h |6

[PATCH 07/15] em28xx: convert to v4l2_fh, fix priority handling.

2013-01-04 Thread Devin Heitmueller
Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/usb/em28xx/em28xx-video.c |5 + drivers/media/usb/em28xx/em28xx.h |2 ++ 2 files changed, 7 insertions(+) diff --git a/drivers/media/usb/em28xx

[PATCH 10/15] em28xx: fix broken TRY_FMT.

2013-01-04 Thread Devin Heitmueller
-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/usb/em28xx/em28xx-video.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb/em28xx/em28xx-video.c

[PATCH 12/15] em28xx: std fixes: don't implement in webcam mode, and fix std changes.

2013-01-04 Thread Devin Heitmueller
When in webcam mode the STD API shouldn't be implemented. When changing the standard the resolution wasn't updated, and there was no check against streaming-in-progress. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers

[PATCH 13/15] em28xx: remove sliced VBI support.

2013-01-04 Thread Devin Heitmueller
into that driver. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/usb/em28xx/em28xx-video.c | 49 ++- 1 file changed, 2 insertions(+), 47 deletions(-) diff --git a/drivers/media/usb

[PATCH 03/15] em28xx: fix VIDIOC_DBG_G_CHIP_IDENT compliance errors.

2013-01-04 Thread Devin Heitmueller
Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/usb/em28xx/em28xx-video.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb/em28xx/em28xx

[PATCH 11/15] tvp5150: remove compat control ops.

2013-01-04 Thread Devin Heitmueller
No longer needed now that em28xx has been converted to the control framework. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/i2c/tvp5150.c |7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/media

[PATCH 15/15] em28xx: convert to videobuf2

2013-01-04 Thread Devin Heitmueller
This patch converts the em28xx driver over to videobuf2. It is likely that em28xx_fh can go away entirely, but that will come in a separate patch. [mche...@redhat.com: fix a non-trivial merge conflict with some VBI patches] Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com

[PATCH 14/15] em28xx: zero vbi_format reserved array and add try_vbi_fmt.

2013-01-04 Thread Devin Heitmueller
Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/usb/em28xx/em28xx-video.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb/em28xx/em28xx-video.c

[PATCH 05/15] v4l2-ctrls: add a notify callback.

2013-01-04 Thread Devin Heitmueller
Sometimes platform/bridge drivers need to be notified when a control from a sub-device changes value. In order to support this a notify callback was added. djh - fix merge conflict in v4l2-ctrls.c Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Devin Heitmueller dheitmuel

[PATCH 08/15] em28xx: add support for control events.

2013-01-04 Thread Devin Heitmueller
Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/usb/em28xx/em28xx-video.c | 38 +-- 1 file changed, 26 insertions(+), 12 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx

[PATCH 09/15] em28xx: fill in readbuffers and fix incorrect return code.

2013-01-04 Thread Devin Heitmueller
g/s_parm should fill in readbuffers. For non-webcams s_parm should return -ENOTTY instead of -EINVAL. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/usb/em28xx/em28xx-video.c |4 +++- 1 file changed, 3

Re: [PATCH 00/15] em28xx VBI2 port and v4l2-compliance fixes

2013-01-04 Thread Devin Heitmueller
On Fri, Jan 4, 2013 at 3:59 PM, Devin Heitmueller dheitmuel...@kernellabs.com wrote: This patch series converts the em28xx driver to videobuf2 and fixes a number of issues found with v4l2-compliance on em28xx. There was a typo on my part. It's VB2 (videobuf2), not VBI2. Devin -- Devin J

Re: [PATCH RFCv3] dvb: Add DVBv5 properties for quality parameters

2012-12-29 Thread Devin Heitmueller
On Fri, Dec 28, 2012 at 6:56 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: The DVBv3 quality parameters are limited on several ways: - Doesn't provide any way to indicate the used measure; - Userspace need to guess how to calculate the measure; - Only a limited

Re: ABI breakage due to Unsupported formats in TRY_FMT/S_FMT recommendation

2012-12-29 Thread Devin Heitmueller
On Sat, Dec 29, 2012 at 6:53 AM, Hans Verkuil hverk...@xs4all.nl wrote: In my opinion these are application bugs, and not ABI breakages. I'm not sure if you saw the email, but Linus seems to disagree with your assertion quite strongly: https://lkml.org/lkml/2012/12/23/75 The change as proposed

Re: ABI breakage due to Unsupported formats in TRY_FMT/S_FMT recommendation

2012-12-29 Thread Devin Heitmueller
On Sat, Dec 29, 2012 at 9:23 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: On a tvtime compiled without libv4l, the cx18 driver will fail with the current logic, as it doesn't return an error when format doesn't match. So, tvtime will fail anyway with 50% of the TV drivers that don't

ABI breakage due to Unsupported formats in TRY_FMT/S_FMT recommendation

2012-12-28 Thread Devin Heitmueller
Hi there, So I noticed that one of the V4L2 ambiguities discussed at the Media Workshop relates to expected behavior with TRY_FMT/S_FMT. Specifically (from http://www.linuxtv.org/news.php?entry=2012-12-28.mchehab): === 1.4. Unsupported formats in TRY_FMT/S_FMT What should a driver return in

Re: [PATCH 0/9] em28xx: refactor the frame data processing code

2012-12-14 Thread Devin Heitmueller
Yes, there will likely be heavy merge conflicts... In which tree are the videobuf2 patches ? It's in a private tree right now, and it doesn't support VBI currently. Once I've setup a public tree with yours and Hans changes, I'll start merging in my changes. I suggest to do the conversion

Re: [PATCH] [media] ngene: fix dvb_pll_attach failure

2012-12-14 Thread Devin Heitmueller
On Fri, Dec 14, 2012 at 6:02 PM, Antti Palosaari cr...@iki.fi wrote: That one is better solution... but it is clearly DRXD driver bug - it should offer working I2C gate control after attach() :-( I looked quickly DRXD driver and there is clearly some other places to enhance too. But I

Re: [PATCH 0/9] em28xx: refactor the frame data processing code

2012-12-13 Thread Devin Heitmueller
On Thu, Dec 13, 2012 at 12:56 PM, Frank Schäfer fschaefer@googlemail.com wrote: Am 13.12.2012 18:36, schrieb Devin Heitmueller: On Sat, Dec 8, 2012 at 10:31 AM, Frank Schäfer fschaefer@googlemail.com wrote: This patch series refactors the frame data processing code in em28xx-video.c

Re: em28xx: msi Digivox ATSC board id [0db0:8810]

2012-12-10 Thread Devin Heitmueller
On Mon, Dec 10, 2012 at 10:39 AM, Frank Schäfer fschaefer@googlemail.com wrote: Am 09.12.2012 18:53, schrieb Matthew Gyurgyik: On 12/09/2012 12:06 PM, Frank Schäfer wrote: Forget this sh... (never do multiple things at the same time ;) ) Reg 0x50 is set to according to rc_type specified

Re: em28xx: msi Digivox ATSC board id [0db0:8810]

2012-12-10 Thread Devin Heitmueller
On Mon, Dec 10, 2012 at 11:01 AM, Frank Schäfer Adding a new property to the RC profile certainly seems to be the cleanest solution. Do all protocols have paritiy checking ? Otherwise we could add a new type RC_TYPE_NEC_NO_PARITY. OTOH, introducing a new bitfield in struct rc_map might be

Re: EM2800 and audio via USB ?

2012-12-10 Thread Devin Heitmueller
On Mon, Dec 10, 2012 at 2:32 PM, Frank Schäfer fschaefer@googlemail.com wrote: a Terratec Cinergy 200 USB Most of those really old devices don't actually make the PCM audio available over the USB. That's why they provide an audio out connector - you're supposed to connect it to the line-in

Re: em28xx: msi Digivox ATSC board id [0db0:8810]

2012-12-09 Thread Devin Heitmueller
On Sun, Dec 9, 2012 at 9:50 AM, Matthew Gyurgyik matt...@pyther.net wrote: Just to make sure I'm not misunderstanding, the messages should get logged to dmesg, correct? I wrote the original IR support for the em2874, but it seems to have changed a bit since I submitted it. One thing that jumps

Re: em28xx: msi Digivox ATSC board id [0db0:8810]

2012-12-06 Thread Devin Heitmueller
On Thu, Dec 6, 2012 at 4:49 PM, Frank Schäfer fschaefer@googlemail.com wrote: Am 06.12.2012 03:16, schrieb Matthew Gyurgyik: On 12/05/2012 07:55 PM, Antti Palosaari wrote: It was good snoop. I didn't saw nothing very interesting. But, I think I found the reason. Just add that one

Re: em28xx: msi Digivox ATSC board id [0db0:8810]

2012-12-06 Thread Devin Heitmueller
On Thu, Dec 6, 2012 at 5:01 PM, Frank Schäfer fschaefer@googlemail.com wrote: That's possible, because Matthews log doesn't show any access to this register. If it is not used, the question is if writing 0x07 to this register can cause any trouble... Historically speaking, on that family

Re: em28xx: msi Digivox ATSC board id [0db0:8810]

2012-12-06 Thread Devin Heitmueller
On Thu, Dec 6, 2012 at 8:40 PM, Matthew Gyurgyik matt...@pyther.net wrote: I was able to do a bit of testing tonight and this is what I found. A channel scan was unsuccessful: http://pyther.net/a/digivox_atsc/dec06/scan.txt (no errors in dmesg) Changing channels by pressing h in mplayer

Re: [PATCH 1/2] au0828: remove forced dependency of VIDEO_AU0828 on VIDEO_V4L2

2012-12-04 Thread Devin Heitmueller
On Tue, Dec 4, 2012 at 11:07 AM, Michael Krufky mkru...@linuxtv.org wrote: This patch removes the dependendency of VIDEO_AU0828 on VIDEO_V4L2 by creating a new Kconfig option, VIDEO_AU0828_V4L2, which enables analog video capture support and depends on VIDEO_V4L2 itself. With

Re: [PATCH 1/2] au0828: remove forced dependency of VIDEO_AU0828 on VIDEO_V4L2

2012-12-04 Thread Devin Heitmueller
On Tue, Dec 4, 2012 at 11:25 AM, Michael Krufky mkru...@linuxtv.org wrote: Do you have any issues with these two patches as-is? Any suggestions? If not, is it OK with you if I request that Mauro merge this for v3.9 ? I have no specific issues with the patch as-is. Reviewed-by: Devin

Re: How to use multiple video devices simultaneously

2012-12-03 Thread Devin Heitmueller
On Mon, Dec 3, 2012 at 5:02 AM, Dmitriy Alekseev alexe...@yahoo.com wrote: Hello. I have a pair of capture dongles Avermedia DVD EZMaker 7 (C039) which have cx231xx chip. Now using vlc and gst-launch-0.10 I can watch/stream video only from one of them simultaneously. For example videolan

Re: em28xx: msi Digivox ATSC board id [0db0:8810]

2012-12-03 Thread Devin Heitmueller
On Mon, Dec 3, 2012 at 9:15 PM, Matthew Gyurgyik matt...@pyther.net wrote: Although, it looked like tuning was semi-successful, I tried the following * cat /dev/dvb/adapter0/dvr0 (no output) * mplayer /dev/dvb/adapter0/dvr0 (no output) * cat /dev/dvb/adapter0/dvr0 test.mpg (test.mpg

Re: em28xx: msi Digivox ATSC board id [0db0:8810]

2012-12-03 Thread Devin Heitmueller
On Mon, Dec 3, 2012 at 9:42 PM, Matthew Gyurgyik matt...@pyther.net wrote: I would try running lsusb -v and send the output. Make sure that it's not expecting to use bulk mode for DVB (which would require driver changes to support). Devin Here is the output of lsusb -v

Re: LGDT3305 configuration questions

2012-12-02 Thread Devin Heitmueller
Hi Frank, I might be able to help out here a bit. On Sun, Dec 2, 2012 at 6:53 AM, Frank Schäfer fschaefer@googlemail.com wrote: 1) When should deny_i2c_rptr in struct lgdt3305_config be set ? I can see what the code does, but I'm unsure which value to use. What's the i2c repeater / i2c

Re: Poor HVR 1600 Video Quality

2012-11-24 Thread Devin Heitmueller
On Sat, Nov 24, 2012 at 12:31 PM, Bob Lightfoot boblf...@gmail.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dear Linux Media Community: I am struggling with what has changed in recent {past 6-9 months} of kernel releases as related to the HVR-1600 Tuner Card and Analog Signal

Re: Poor HVR 1600 Video Quality - Feedback for Devin Heitmueller 2012-11-24

2012-11-24 Thread Devin Heitmueller
On Sat, Nov 24, 2012 at 11:08 PM, Bob Lightfoot boblf...@gmail.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Devin : Let me see if I can answer some of your questions. 1. lspci -nn -vvv returns the following for the HVR-1600 Card 01:00.0 Multimedia video controller [0400]:

Re: Poor HVR 1600 Video Quality - Feedback for Devin Heitmueller 2012-11-24

2012-11-24 Thread Devin Heitmueller
On Sat, Nov 24, 2012 at 11:08 PM, Bob Lightfoot boblf...@gmail.com wrote: Hope you can shed an idea or three. My end goal it to again record analog video in MythTV. Two other questions: Have you tried dropping the card into a Windows box to make sure your hardware isn't just dead? I know you

Re: The em28xx driver error

2012-11-15 Thread Devin Heitmueller
On Thu, Nov 15, 2012 at 11:31 AM, Frank Schäfer fschaefer@googlemail.com wrote: Hmm... I've made some experiments to find out what gcc does on x86 and it seems to ignore bit shifting 32. I also noticed that this line has been removed in 3.7-rc. So we do NOT want to halve the height for

Re: The em28xx driver error

2012-11-14 Thread Devin Heitmueller
On Wed, Nov 14, 2012 at 11:58 AM, Frank Schäfer fschaefer@googlemail.com wrote: This looks indeed like a bug. a = b means a = a b, which in this case means shifting height 480 or 576 bits to the right... height 1 means height /= 2 which seems to be sane for interlaced devices. OTOH, I

Re: Color problem with MPX-885 card (cx23885)

2012-11-13 Thread Devin Heitmueller
On Tue, Nov 13, 2012 at 9:10 AM, Neuer User auslands...@gmx.de wrote: Hello First of all, I don't know, if this is the right mailing list. I haven't found any other. The video4linux list seems to be abandoned. I am testing a Commell MPX-885 mini-pcie card, which is based on a cx23885 chip.

Re: Color problem with MPX-885 card (cx23885)

2012-11-13 Thread Devin Heitmueller
On Tue, Nov 13, 2012 at 11:39 AM, Neuer User auslands...@gmx.de wrote: I had looked through the linux-media GIT tree for any commits that have cx23885 in the description. The last ones I found were from mid 2011. Yeah, the changes were actually made to the cx25840 driver, which is used/shared

Re: Color problem with MPX-885 card (cx23885)

2012-11-13 Thread Devin Heitmueller
On Tue, Nov 13, 2012 at 1:02 PM, Neuer User auslands...@gmx.de wrote: The HSYNC problem is bigger than I thought. I compared the captured image with an image from another (USB) video digitizer and it is obvious that the image has lost about 10-20% on the right side and on the bottom. Can

Re: Color problem with MPX-885 card (cx23885)

2012-11-13 Thread Devin Heitmueller
On Tue, Nov 13, 2012 at 2:03 PM, Neuer User auslands...@gmx.de wrote: Thanks, you probably hinted me into the right direction. I use mplayer to play the video stream and mplayer does indeed recognize a 640x480 video stream. I am not using any crop settings for these tests. But maybe it is

Re: [PATCH v2 21/21] em28xx: add module parameter for selection of the preferred USB transfer type

2012-11-09 Thread Devin Heitmueller
On Fri, Nov 9, 2012 at 11:00 AM, Frank Schäfer fschaefer@googlemail.com wrote: Well, I deliberately called the module 'prefer_bulk' (and not 'use_bulk', 'force_bulk' ...) which should imply that nothing is guaranteed. And selecting bulk transfers for a device which actually doesn not

Re: [PATCH v2 21/21] em28xx: add module parameter for selection of the preferred USB transfer type

2012-11-08 Thread Devin Heitmueller
On Thu, Nov 8, 2012 at 1:37 PM, Frank Schäfer fschaefer@googlemail.com wrote: at least the Silvercrest Webcam 1.3mpix (board 71) exposes both endpoint types (0x82=isoc and 0x84=bulk). Ah, interesting. It might be worthwhile to log a warning in dmesg if the user sets the modprobe option but

Re: [PATCH 00/23] em28xx: add support fur USB bulk transfers

2012-10-30 Thread Devin Heitmueller
On Tue, Oct 30, 2012 at 12:06 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Did a git bisect. The last patch where the bug doesn't occur is this changeset: em28xx: add module parameter for selection of the preferred USB transfer type That means that this changeset broke it:

Re: [PATCH 00/23] em28xx: add support fur USB bulk transfers

2012-10-21 Thread Devin Heitmueller
Hi Frank, On Sun, Oct 21, 2012 at 12:52 PM, Frank Schäfer fschaefer@googlemail.com wrote: This patch series adds support for USB bulk transfers to the em28xx driver. This is a welcome change that some users have been asking about for a while. Patch 1 is a bugfix for the image data

Re: How to add support for the em2765 webcam Speedlink VAD Laplace to the kernel ?

2012-10-06 Thread Devin Heitmueller
On Sat, Oct 6, 2012 at 7:56 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: AFAIKT, newer em28xx chips are using this concept. The em28xx-i2c code require changes to support two I2C buses, and to handle 16 bit eeproms. We never cared of doing that because we never needed, so far, to read

Re: hvr-1600 fails frequently on multiple recordings

2012-10-04 Thread Devin Heitmueller
On Thu, Oct 4, 2012 at 7:58 AM, Brian J. Murrell br...@interlinx.bc.ca wrote: I have a fairly new HVR-1600 which I have seen fail quite a number of times now when it's asked to record more than one channel on a clearqam multiplex. This time it was 3 recordings at once. There's nothing at all

Re: [PATCH RFC] em28xx: PCTV 520e switch tda18271 to tda18271c2dd

2012-10-01 Thread Devin Heitmueller
On Mon, Oct 1, 2012 at 8:52 PM, Antti Palosaari cr...@iki.fi wrote: New drxk firmware download does not work with tda18271. Actual reason is more drxk driver than tda18271. Anyhow, tda18271c2dd will work as it does not do as much I/O during attach than tda18271. Root of cause is tuner I/O

Re: DiBcom 7000PC: Not able to scan for services on Raspberry Pi

2012-09-29 Thread Devin Heitmueller
On Sat, Sep 29, 2012 at 3:34 PM, Ladislav Józsa l.jo...@gmail.com wrote: Running the same on my x86_64 machine works and tvheadend sees multiplexes. What else information do you need from me in order to track the problem? Recompile your kernel with debug info so we can see the symbols for the

Re: [PATCH] Support for Asus MyCinema U3100Mini Plus

2012-09-20 Thread Devin Heitmueller
On Thu, Sep 20, 2012 at 2:54 PM, Oliver Schinagl oliver+l...@schinagl.nl wrote: dvbscan and dvbv5-scan does constantly say 'tuning failed' but it does say that on my terratec too. It does work fine however, so probably a bug in driver/tool unrelated to this patch. Just to be clear, the message

Re: [PATCH] Support for Asus MyCinema U3100Mini Plus

2012-09-19 Thread Devin Heitmueller
On Wed, Sep 19, 2012 at 2:44 PM, oli...@schinagl.nl wrote: From: Oliver Schinagl oli...@schinagl.nl This is initial support for the Asus MyCinema U3100Mini Plus. The driver in its current form gets detected and loads properly. Scanning using dvbscan works without problems, Locking onto a

Re: Terratec Cinergy T PCIe Dual doesn;t work nder the Xen hypervisor

2012-09-18 Thread Devin Heitmueller
On Tue, Sep 18, 2012 at 2:34 PM, Javier Marcet jmar...@gmail.com wrote: I can't say how happy I am that you were wrong in your guess. Quoting Konrad Rzeszutek Wilk: Well, you haven't proven me wrong yet. :-) The issue as I understand is that the DVB drivers allocate their buffers from

Re: Terratec Cinergy T PCIe Dual doesn;t work nder the Xen hypervisor

2012-09-17 Thread Devin Heitmueller
On Mon, Sep 17, 2012 at 8:05 PM, Javier Marcet jmar...@gmail.com wrote: Initially I thought Xen would be the cause of the problem, but after having written on the Xen development mailing list and talked about it with a couple developers, it isn't very clear where the problem is. So far I

Re: hdpvr and HD PVR 2 Gaming Edition from Haoppauge

2012-09-13 Thread Devin Heitmueller
On Thu, Sep 13, 2012 at 2:28 PM, Thomas Seilund t...@netmaster.dk wrote: Do you know if anybody plans to make a driver? I have not heard of any such plans. It's a brand new device though, so it's possible that somebody will step up to do such (especially if the original HD-PVR stops being

Re: hdpvr and HD PVR 2 Gaming Edition from Haoppauge

2012-09-12 Thread Devin Heitmueller
On Wed, Sep 12, 2012 at 11:37 AM, Thomas Seilund t...@netmaster.dk wrote: Hi All, I just bought the HD PVR 2 Gaming Edition from Hauppauge. It there any change this device will be supported by the hdpvr kernel driver. (Or any other driver for that matter!) No. It is a totally different

Re: [RFCv2 API PATCH 00/28] Full series of API fixes from the 2012 Media Workshop

2012-09-07 Thread Devin Heitmueller
On Fri, Sep 7, 2012 at 9:29 AM, Hans Verkuil hverk...@xs4all.nl wrote: I have also tested this patch series (actually a slightly older version) with em28xx. That driver needed a lot of changes to get it to pass the v4l2-compliance tests. Those can be found here:

Re: Fwd: [PATCH, RFC] Fix DVB ioctls failing if frontend open/closed too fast

2012-09-01 Thread Devin Heitmueller
On Sat, Sep 1, 2012 at 12:13 PM, Antti Palosaari cr...@iki.fi wrote: Is there anyone caring to review that carefully? I am quite out with semaphores (up/down_interruptible) and also frontend is so complex... I would rather design / write whole dvb-frontend from the scratch :] (not doing that

Re: [media] rc-core: move timeout and checks to lirc

2012-08-20 Thread Devin Heitmueller
On Mon, Aug 20, 2012 at 6:02 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: So, IMO, it makes sense to have a high end API that accepts writing keystrokes like above, working with both raw drivers using some kernel IR protocol encoders, and with devices that can accept processed

Re: RFC: V4L2 API ambiguities

2012-08-13 Thread Devin Heitmueller
On Mon, Aug 13, 2012 at 4:27 PM, Walter Van Eetvelt wal...@van.eetvelt.be wrote: For me there is a an issue in the V4L specs for the support of DVB-S/C/T devices where the CI device is decoupled from the Tuners. At the moment there is no standard solution on which device drivers implementers

Re: RFC: V4L2 API ambiguities

2012-08-13 Thread Devin Heitmueller
On Mon, Aug 13, 2012 at 5:39 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: No, it is not out of scope. The thing is that none of the developers that are going to be there proposed a DVB-specific themes, unfortunately. Yet, there are two themes there that are not V4L only: the userspace

Re: [PATCH, RFC] Fix DVB ioctls failing if frontend open/closed too fast

2012-08-11 Thread Devin Heitmueller
On Sat, Aug 11, 2012 at 10:15 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: Devin/Antti, As Juergen mentioned your help on this patch, do you mind helping reviewing and testing it? I guided Juergen through the creation of the patch via #linuxtv a couple of weeks ago. While I'm

Re: [PATCH 17/24] au0828: fix possible race condition in usage of dev-ctrlmsg

2012-08-09 Thread Devin Heitmueller
On Thu, Aug 9, 2012 at 7:48 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em 06-08-2012 23:47, Devin Heitmueller escreveu: The register read function is referencing the dev-ctrlmsg structure outside of the dev-mutex lock, which can cause corruption of the value if multiple callers

Re: [PATCH 00/24] Various HVR-950q and xc5000 fixes

2012-08-07 Thread Devin Heitmueller
On Tue, Aug 7, 2012 at 2:26 AM, Hans Verkuil hverk...@xs4all.nl wrote: Since you're working on the au0828 would it perhaps be possible to have that driver use unlocked_ioctl instead of ioctl? It would be really nice if we can get rid of the ioctl v4l2_operation at some point in the future. Hi

Re: tda18271 driver power consumption

2012-08-06 Thread Devin Heitmueller
On Mon, Aug 6, 2012 at 2:19 PM, Antti Palosaari cr...@iki.fi wrote: You should understand from DVB driver model: * attach() called only once when driver is loaded * init() called to wake-up device * sleep() called to sleep device What I would like to say is that there is very big risk to

[PATCH 00/24] Various HVR-950q and xc5000 fixes

2012-08-06 Thread Devin Heitmueller
significantly improved, and we now have a redistributable version for the xc5000c firmware. Devin Heitmueller (24): au8522: fix intermittent lockup of analog video decoder au8522: Fix off-by-one in SNR table for QAM256 au8522: properly recover from the au8522 delivering misaligned TS streams

[PATCH 01/24] au8522: fix intermittent lockup of analog video decoder

2012-08-06 Thread Devin Heitmueller
other than NTSC-M, just disable the video-standard autodetection logic and force it to always be NTSC-M. Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/dvb/frontends/au8522_decoder.c |6 +++- drivers/media/dvb/frontends/au8522_priv.h| 28

[PATCH 02/24] au8522: Fix off-by-one in SNR table for QAM256

2012-08-06 Thread Devin Heitmueller
with register reads). Fix the table so that 40.0 dB is properly represented. Cc: Steven Toth st...@kernellabs.com Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/dvb/frontends/au8522_dig.c | 96 +++--- 1 files changed, 48 insertions(+), 48 deletions

[PATCH 04/24] au0828: Make the s_reg and g_reg advanced debug calls work against the bridge

2012-08-06 Thread Devin Heitmueller
The g_reg and s_reg calls worked properly if acting on subdev registers (such as the au8522), but didn't work against the au0828 itself. Copy the logic over from em28xx. Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/video/au0828/au0828-video.c | 11

[PATCH 05/24] xc5000: properly show quality register values

2012-08-06 Thread Devin Heitmueller
The quality register only has relevant data in bits 2-0, so discard the other bits (which results in a value being printed that is consistent with the expected 0-7 range). Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/common/tuners/xc5000.c |2 +- 1 files

[PATCH 07/24] xc5000: properly report i2c write failures

2012-08-06 Thread Devin Heitmueller
The logic as written would *never* actually return an error condition, since the loop would run until the counter hit zero but the check was for a value less than zero. Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/common/tuners/xc5000.c |2 +- 1 files

[PATCH 08/24] au0828: fix race condition that causes xc5000 to not bind for digital

2012-08-06 Thread Devin Heitmueller
since I copied all the locking logic from that driver when I added analog support). Reproduce Mauro's fix from the em28xx driver in au0828. Reported-by: Rick Harding rhard...@mitechie.com Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/video/au0828/au0828-core.c

[PATCH 10/24] au8522: fix regression in logging introduced by separation of modules

2012-08-06 Thread Devin Heitmueller
The au8522 driver was broken into three modules (dig, decoder, common), and as a result the debug modprobe option doesn't work for any of the common functions. Copy the module macros over to the common module so that the debug option works again. Signed-off-by: Devin Heitmueller dheitmuel

[PATCH 11/24] xc5000: don't invoke auto calibration unless we really did reset tuner

2012-08-06 Thread Devin Heitmueller
calibration if reset and firmware load was performed. Also because the called function is now a no-op if the firmware is already loaded, the caller no longer needs to invoke is_firmware_loaded(). Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/common/tuners/xc5000.c | 40

[PATCH 12/24] au0828: prevent i2c gate from being kept open while in analog mode

2012-08-06 Thread Devin Heitmueller
for a board that has the au0828/au8522 but doesn't have digital support implemented (because the i2c_gate_ctrl callback is being set in the DVB attach). However given how few different models are in circulation, this can be deferred until such a situation arises (if ever). Signed-off-by: Devin

[PATCH 18/24] xc5000: reset device if encountering PLL lock failure

2012-08-06 Thread Devin Heitmueller
in the event that the PLL is in an unlocked state. This solution was provided by the engineer at CrestaTech (the company that acquired Xceive). Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/common/tuners/xc5000.c | 58 ++--- 1 files

[PATCH 19/24] xc5000: add support for firmware load check and init status

2012-08-06 Thread Devin Heitmueller
v2.3. Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/common/tuners/xc5000.c | 39 ++ 1 files changed, 39 insertions(+), 0 deletions(-) diff --git a/drivers/media/common/tuners/xc5000.c b/drivers/media/common/tuners/xc5000.c index

[PATCH 22/24] au0828: fix a couple of missed edge cases for i2c gate with analog

2012-08-06 Thread Devin Heitmueller
This patch addresses a couple of cases where I forgot to pop open the gate when in analog mode (a correlary to fix the change made in patch 1c58d5b4a5fca42dce5428bd79b9405878017735). Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/video/au0828/au0828-video.c | 16

[PATCH 24/24] xc5000: change filename to production/redistributable xc5000c firmware

2012-08-06 Thread Devin Heitmueller
://kernellabs.com/firmware/xc5000/dvb-fe-xc5000c-4.1.30.7.fw Thanks to Ramon Cazares from Cresta Technology for making the firmware available as well as working out the licensing issues. Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com Cc: Michael Krufky mkru...@kernellabs.com --- drivers/media

[PATCH 13/24] au0828: fix case where STREAMOFF being called on stopped stream causes BUG()

2012-08-06 Thread Devin Heitmueller
...@gmail.com Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/video/au0828/au0828-video.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/au0828/au0828-video.c b/drivers/media/video/au0828/au0828-video.c index

[PATCH 15/24] au0828: remove control buffer from send_control_msg

2012-08-06 Thread Devin Heitmueller
There are no cases where a control message is ever sent to the au0828 with an actual buffer defined. Remove the reference to dev-ctrlmsg, which currently requires us to hold a mutex since it is shared with the read function. Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com

[PATCH 20/24] au0828: tweak workaround for i2c clock stretching bug

2012-08-06 Thread Devin Heitmueller
manifested itself as the xc5000 firmware version and PLL lock register intermittently showing garbage values. Slow down the i2c bus from 30 KHz to 20 KHz to accommodate. Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/video/au0828/au0828-cards.c |4 ++-- drivers

[PATCH 23/24] au0828: make xc5000 firmware speedup apply to the xc5000c as well

2012-08-06 Thread Devin Heitmueller
Make the firmware speedup work for the 5000c as well as the original xc5000. This cuts firmware load time in half. Thanks to John Casey at Hauppauge for loaning me a board for testing. Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/video/au0828/au0828-i2c.c

[PATCH 21/24] xc5000: show debug version fields in decimal instead of hex

2012-08-06 Thread Devin Heitmueller
-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/common/tuners/xc5000.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/common/tuners/xc5000.c b/drivers/media/common/tuners/xc5000.c index 3e5f8cd..4bb20fa 100644 --- a/drivers/media

[PATCH 17/24] au0828: fix possible race condition in usage of dev-ctrlmsg

2012-08-06 Thread Devin Heitmueller
(and it is already logged). Signed-off-by: Devin Heitmueller dheitmuel...@kernellabs.com --- drivers/media/video/au0828/au0828-core.c | 40 +- 1 files changed, 12 insertions(+), 28 deletions(-) diff --git a/drivers/media/video/au0828/au0828-core.c b/drivers/media/video/au0828

[PATCH 14/24] au0828: speed up i2c clock when doing xc5000 firmware load

2012-08-06 Thread Devin Heitmueller
Put a hack in place to speed up the firmware load in the case that the xc5000 has just been reset. The chip can safely do 400 KHz in this mode, while in normal operation it can only do 100 KHz. This reduces the firmware load time from 6.9 seconds to 4.2. Signed-off-by: Devin Heitmueller

<    1   2   3   4   5   6   7   8   9   10   >