Re: [patch 1/2] [media] rc: unlock on error in show_protocols()

2012-11-27 Thread Douglas Bagnall
On 28/11/12 06:35, Dan Carpenter wrote: > We recently introduced a new return -ENODEV in this function but we need > to unlock before returning. There is an identical patch here (scroll down): https://patchwork.kernel.org/patch/1284081/ I'm not sure what happened to it. Douglas > Signed-off-by:

[PATCH] [media] Unlock the rc_dev lock when the raw device is missing

2012-08-07 Thread Douglas Bagnall
h could have a Reported-by line added. OK. Here it is again, with CC: stable, Reported-by Ben, and Herton's Acked-by. thanks, Douglas >From 47aadfdaa5a6e5c3d8f1bf2b5be4c4a4156085ee Mon Sep 17 00:00:00 2001 From: Douglas Bagnall Date: Tue, 7 Aug 2012 19:30:36 +1200 Subject: [PATCH] Unlock

Re: [3.0.y+] [media] Avoid sysfs oops when an rc_dev's raw device is absent

2012-08-07 Thread Douglas Bagnall
7bcbb4e9af588618 Mon Sep 17 00:00:00 2001 From: Douglas Bagnall Date: Tue, 7 Aug 2012 19:30:36 +1200 Subject: [PATCH] Unlock the rc_dev lock when the raw device is missing As pointed out by Ben Hutchings, after commit 720bb6436, the lock was being taken and not released when an rc_dev has a NULL

Re: [PATCH v2] Avoid sysfs oops when an rc_dev's raw device is absent

2012-07-06 Thread Douglas Bagnall
ignores the issue of how this state of affairs came about in the first place. Version 2 incorporates changes recommended by Mauro Carvalho Chehab (-ENODEV instead of -EINVAL, and a signed-off-by). Signed-off-by: Douglas Bagnall --- drivers/media/rc/rc-main.c |4 +++- 1 file changed, 3

Re: [PATCH] Avoid sysfs oops when an rc_dev's raw device is absent

2012-06-24 Thread Douglas Bagnall
hi, I probably should have sent that in reply to http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/49740 which is the problem it fixes. Some things which might be of interest: 1. I innocently followed the instructions on http://www.linuxtv.org/wiki/index.php/Maintaining

[PATCH] Avoid sysfs oops when an rc_dev's raw device is absent

2012-06-24 Thread Douglas Bagnall
For some reason, when the lirc daemon learns that a usb remote control has been unplugged, it wants to read the sysfs attributes of the disappearing device. This is useful for uncovering transient inconsistencies, but less so for keeping the system running when such inconsistencies exist. Under so

Oops when unplugging Hauppauge WinTV MiniStick USB DVB-T device

2012-06-20 Thread Douglas Bagnall
= 0 Jun 20 12:41:52 kip kernel: [56969.966260] IR LIRC bridge handler initialized I reported this to Ubuntu at https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1015836 which includes more (probably irrelevant) information about my system. What can I do to help? regards, Douglas Bagnall -