Re: [RFC 2/2] vim2m: add media device

Hi Ezequiel, On Tue, Jun 12, 2018 at 07:48:27AM -0300, Ezequiel Garcia wrote: > @@ -1013,10 +1016,10 @@ static int vim2m_probe(struct platform_device *pdev) > vfd->lock = >dev_mutex; > vfd->v4l2_dev = >v4l2_dev; > > - ret = video_register_device(vfd, VFL_TYPE_GRABBER, 0); > +

Re: [PATCH 1/8] clk: Add clk_bulk_alloc functions

HI Maciej, Just sharing a couple of fly-by ideas - please don't read too much into them. On 19 February 2018 at 15:43, Maciej Purski wrote: > When a driver is going to use clk_bulk_get() function, it has to > initialize an array of clk_bulk_data, by filling its id fields.

Re: [PATCHv3 17/22] staging: android: ion: Collapse internal header files

Hi Laura, Couple of trivial nitpicks below. On 3 April 2017 at 19:57, Laura Abbott wrote: > --- a/drivers/staging/android/ion/ion.h > +++ b/drivers/staging/android/ion/ion.h > @@ -1,5 +1,5 @@ > /* > - * drivers/staging/android/ion/ion.h > + *

Re: [RFC PATCH 06/12] staging: android: ion: Remove crufty cache support

On 6 March 2017 at 10:29, Daniel Vetter wrote: > On Fri, Mar 03, 2017 at 10:46:03AM -0800, Laura Abbott wrote: >> On 03/03/2017 08:39 AM, Laurent Pinchart wrote: >> > Hi Daniel, >> > >> > On Friday 03 Mar 2017 10:56:54 Daniel Vetter wrote: >> >> On Thu, Mar 02, 2017 at 01:44:38PM

Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn

On 23 February 2017 at 17:18, Joe Perches wrote: > On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote: >> On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches wrote: >> > There are ~4300 uses of pr_warn and ~250 uses of the older >> > pr_warning in the kernel source

Re: [PATCH v7 1/3] create SMAF module

On 17 May 2016 at 22:29, Daniel Vetter wrote: > Please don't use __kernel_size_t, it's only for backwards compat if you > already botched an ioctl definition ;-) > That explains why I've not seen it in (m)any other UAPI headers but our legacy ones. Thank you ! Emil -- To

Re: [PATCH v7 1/3] create SMAF module

On 17 May 2016 at 14:50, Benjamin Gaignard wrote: > Hello Emil, > > thanks for your review. > I have understand most of your remarks and I'm fixing them > but some points aren't obvious for me... > Sure thing. Thanks for being honest. > > No because a device could

Re: [PATCH v7 3/3] SMAF: add fake secure module

Hi Benjamin, On 9 May 2016 at 16:07, Benjamin Gaignard wrote: > This module is allow testing secure calls of SMAF. > "Add fake secure module" does sound like something not (m)any people want to hear ;-) Have you considered calling it 'dummy', 'test' or similar ? >

Re: [PATCH v7 2/3] SMAF: add CMA allocator

Hi Benjamin, On 9 May 2016 at 16:07, Benjamin Gaignard wrote: > SMAF CMA allocator implement helpers functions to allow SMAF > to allocate contiguous memory. > > match() each if at least one of the attached devices have coherent_dma_mask > set to DMA_BIT_MASK(32). >

Re: [PATCH v7 1/3] create SMAF module

Hi Benjamin, I'd suspect you're interested in some feedback on these, so here is a few :-) Sadly (ideally?) nothing serious, but a bunch minor suggestions, plus the odd bug. On 9 May 2016 at 16:07, Benjamin Gaignard wrote: > --- /dev/null > +++

Re: [PATCH v3] libgencec: Add userspace library for the generic CEC kernel interface

Hi Kamil, There are a couple of bits that I've missed out previously. All but the missing install of libgencec.pc are general cleanups. On 6 May 2015 at 13:37, Kamil Debski k.deb...@samsung.com wrote: --- /dev/null +++ b/.gitignore @@ -0,0 +1,26 @@ +/ar-lib You can drop this (see the

Re: [PATCH] libgencec: Add userspace library for the generic CEC kernel interface

, From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Emil Velikov Sent: Wednesday, April 29, 2015 5:00 PM Hi Kamil, Allow me to put a few suggestions: On 29 April 2015 at 11:02, Kamil Debski k.deb...@samsung.com wrote: diff --git a/m4

Re: [PATCH] libgencec: Add userspace library for the generic CEC kernel interface

Hi Kamil, Allow me to put a few suggestions: On 29 April 2015 at 11:02, Kamil Debski k.deb...@samsung.com wrote: This is the first version of the libGenCEC library. It was designed to act as an interface between the generic CEC kernel API and userspace applications. It provides a simple