Re: [PATCH v4 3/5] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-22 Thread Enric Balletbo Serra
Hi Neil, 2018-05-21 16:21 GMT+02:00 Neil Armstrong : > The EC can expose a CEC bus, this patch adds the CEC related definitions > needed by the cros-ec-cec driver. > Having a 16 byte mkbp event size makes it possible to send CEC > messages from the EC to the AP directly

Re: [PATCH v2 3/5] mfd: cros-ec: Introduce CEC commands and events definitions.

2018-05-18 Thread Enric Balletbo Serra
Hi Neil, 2018-05-18 15:05 GMT+02:00 Neil Armstrong : > The EC can expose a CEC bus, this patch adds the CEC related definitions > needed by the cros-ec-cec driver. > Having a 16 byte mkbp event size makes it possible to send CEC > messages from the EC to the AP directly

Re: [PATCH v2 5/5] media: platform: Add Chrome OS EC CEC driver

2018-05-18 Thread Enric Balletbo Serra
Hi Neil, 2018-05-18 15:05 GMT+02:00 Neil Armstrong : > The Chrome OS Embedded Controller can expose a CEC bus, this patch add the A minor nit, there is a "consensus" on tell cros-ec as "ChromeOS Embedded Controller" or "ChromeOS EC". Yes, I know that you can see in the

Re: [PATCH v2 0/5] Add ChromeOS EC CEC Support

2018-05-18 Thread Enric Balletbo Serra
Hi Neil, 2018-05-18 15:04 GMT+02:00 Neil Armstrong : > Hi All, > > The new Google "Fizz" Intel-based ChromeOS device is gaining CEC support > through it's Embedded Controller, to enable the Linux CEC Core to communicate > with it and get the CEC Physical Address from the

Re: [PATCH v2 4/5] mfd: cros_ec_dev: Add CEC sub-device registration

2018-05-18 Thread Enric Balletbo Serra
2018-05-18 15:05 GMT+02:00 Neil Armstrong : > The EC can expose a CEC bus, thus add the cros-ec-cec MFD sub-device > when the CEC feature bit is present. > > Signed-off-by: Neil Armstrong > --- > drivers/mfd/cros_ec_dev.c | 16 >

Re: [PATCH v2 4/5] mfd: cros_ec_dev: Add CEC sub-device registration

2018-05-15 Thread Enric Balletbo Serra
Hi Neil, I suspect that this patch will conflict with some patches that will be queued for 4.18 that also introduces new devices, well, for now I don't see these merged in the Lee's tree. Based on some reviews I got when I send a patch to this file ... 2018-05-15 17:29 GMT+02:00 Hans Verkuil

Re: [RFC PATCH 04/11] v4l2-ctrls: add config store support

2015-12-02 Thread Enric Balletbo Serra
Dear Hans, 2014-11-17 9:46 GMT+01:00 Hans Verkuil : > On 11/14/2014 04:44 PM, Sakari Ailus wrote: >> Hi Hans, >> >> Some comments below. >> >> On Sun, Sep 21, 2014 at 04:48:22PM +0200, Hans Verkuil wrote: >>> From: Hans Verkuil >>> >>> Signed-off-by:

Re: [RFC PATCH 04/11] v4l2-ctrls: add config store support

2015-12-02 Thread Enric Balletbo Serra
2015-12-02 13:33 GMT+01:00 Hans Verkuil <hverk...@xs4all.nl>: > On 12/02/15 13:03, Enric Balletbo Serra wrote: >> Dear Hans, >> >> We've a driver that uses your confstore stuff and we'd like to push >> upstream. I'm wondering if there is any plan to

Re: [GIT PULL FOR v3.16] mt9p031 fixes

2014-07-21 Thread Enric Balletbo Serra
Hi Laurent, 2014-07-10 0:29 GMT+02:00 Laurent Pinchart laurent.pinch...@ideasonboard.com: Hi Enric, On Wednesday 09 July 2014 17:56:59 Enric Balletbo Serra wrote: 2014-05-16 2:45 GMT+02:00 Laurent Pinchart wrote: Hi Mauro, The following changes since commit

Re: [GIT PULL FOR v3.16] mt9p031 fixes

2014-07-09 Thread Enric Balletbo Serra
Hi Laurent, 2014-05-16 2:45 GMT+02:00 Laurent Pinchart laurent.pinch...@ideasonboard.com: Hi Mauro, The following changes since commit ba0d342ecc21fbbe2f6c178f4479944d1fb34f3b: saa7134-alsa: include vmalloc.h (2014-05-13 23:05:15 -0300) are available in the git repository at:

omap3isp: possible circular locking dependency

2013-03-27 Thread Enric Balletbo Serra
Hi all, I've a problem running OMAP3 ISP with current 3.9-rc4. I tried to run the Laurent's live application to capture data from my mt9v034 sensor but kernel shows a possible circular locking dependency. Also the captured images are wrong and I see garbage. The same environment worked for me

Re: [PATCH] [media] v4l: Add mt9v034 sensor driver

2012-12-05 Thread Enric Balletbo Serra
Hi all, Thanks for all your comments 2012/12/2 Sakari Ailus sakari.ai...@iki.fi: Hi Enric, Thanks for the patch. (Removing my old e-mail address from cc.) On Fri, Oct 05, 2012 at 12:34:47PM +0200, Enric Balletbo i Serra wrote: From: Enric Balletbo i Serra eballe...@iseebcn.com The

Re: Using omap3-isp-live example application on beagleboard with DVI

2012-10-19 Thread Enric Balletbo Serra
Hi Laurent, 2012/10/19 Laurent Pinchart laurent.pinch...@ideasonboard.com: Hi Enric, On Wednesday 17 October 2012 11:35:37 Enric Balletbo Serra wrote: 2012/10/17 Laurent Pinchart laurent.pinch...@ideasonboard.com: [snip] Instead of failing what would be more interesting would be to get

Re: Using omap3-isp-live example application on beagleboard with DVI

2012-10-17 Thread Enric Balletbo Serra
Hi Laurent, 2012/10/17 Laurent Pinchart laurent.pinch...@ideasonboard.com: Hi Enric, On Monday 15 October 2012 14:03:20 Enric Balletbo Serra wrote: 2012/10/11 Laurent Pinchart laurent.pinch...@ideasonboard.com: On Thursday 11 October 2012 10:14:26 Enric Balletbò i Serra wrote: 2012/10/10

Re: Using omap3-isp-live example application on beagleboard with DVI

2012-10-15 Thread Enric Balletbo Serra
Hi Laurent, 2012/10/11 Laurent Pinchart laurent.pinch...@ideasonboard.com: Hi Enric, On Thursday 11 October 2012 10:14:26 Enric Balletbò i Serra wrote: 2012/10/10 Enric Balletbò i Serra eballe...@gmail.com: 2012/9/6 John Weber rjohnwe...@gmail.com: Hello, My goal is to better