Re: [PATCH v2 3/3] mt9v022: set y_skip_top field to zero as default

2012-09-28 Thread Eric Miao
to me. Sorry for the delay. Acked-by: Eric Miao eric.y.m...@gmail.com Thanks Guennadi On Fri, 28 Sep 2012, Anatolij Gustschin wrote: Set y_skip_top to zero and revise comment as I do not see this line corruption on two different mt9v022 setups. The first read-out line is perfectly

Re: [PATCH 0/3] pxa_camera: remove init() callback

2009-11-28 Thread Eric Miao
On Sat, Nov 28, 2009 at 4:39 AM, Antonio Ospite osp...@studenti.unina.it wrote: On Tue, 17 Nov 2009 23:04:20 +0100 Antonio Ospite osp...@studenti.unina.it wrote: Hi, this series removes the init() callback from pxa_camera_platform_data, and fixes its users to do initialization statically at

Re: [PATCH 2/3 v2] pcm990-baseboard: don't use pxa_camera init() callback

2009-11-28 Thread Eric Miao
On Sat, Nov 28, 2009 at 4:31 AM, Antonio Ospite osp...@studenti.unina.it wrote: pxa_camera init() is ambiguous, it's better to configure PXA CIF pins statically in machine init function. Signed-off-by: Antonio Ospite osp...@studenti.unina.it I'll grab this and get it exposed to next -rc

Re: [PATCH 1/3 v3] Add camera support for A780 and A910 EZX phones

2009-11-11 Thread Eric Miao
On Wed, Nov 11, 2009 at 7:01 PM, Antonio Ospite osp...@studenti.unina.it wrote: Signed-off-by: Bart Visscher ba...@thisnet.nl Signed-off-by: Antonio Ospite osp...@studenti.unina.it --- Changes since v2:  - Bart's SOB goes first, as he is the original author.  - Add MFP_LPM_DRIVE_HIGH to

Re: [PATCH 1/3] ezx: Add camera support for A780 and A910 EZX phones

2009-11-10 Thread Eric Miao
On Tue, Nov 10, 2009 at 8:48 PM, Antonio Ospite osp...@studenti.unina.it wrote: On Wed, 4 Nov 2009 14:38:40 +0800 Eric Miao eric.y.m...@gmail.com wrote: Hi Antonio, Patch looks generally OK except for the MFP/GPIO usage... Eric, while I was at it I also checked the original code Motorola

Re: [PATCH 3/8] ARM: convert pcm990 to the new platform-device soc-camera interface

2009-04-27 Thread Eric Miao
On Mon, Apr 27, 2009 at 5:55 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Mon, 27 Apr 2009, Eric Miao wrote: It looks to me the change to the platform code is to move the I2C board info registration into 'struct soc_camera_link'. Are there any specific reason to do so? I'm

Re: [PATCH 3/8] ARM: convert pcm990 to the new platform-device soc-camera interface

2009-04-26 Thread Eric Miao
It looks to me the change to the platform code is to move the I2C board info registration into 'struct soc_camera_link'. Are there any specific reason to do so? I'm assuming the original code works equally well, and lists all the i2c devices in a central place is straight forward. On Sat, Apr 25,

Re: [PATCH 1/5] soc-camera: add a free_bus method to struct soc_camera_link

2009-04-15 Thread Eric Miao
an explicit free_bus method and using it in mt9m001 and mt9v022 drivers fixes these problems. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- Eric, need your ack for the arch/arm/mach-pxa part. Sascha's wouldn't hurt either:-) Yes, the mach-pxa/ part looks OK to me. Acked-by: Eric