Re: 'bad remote port parent' warnings

Hi Steve, On Fri, Nov 23, 2018 at 8:37 PM Steve Longerbeam wrote: > Yes, this is a regression caused by the imx subdev notifier patches. > I've already sent a patch to the list for this, see > > https://www.spinics.net/lists/linux-media/msg141809.html Thanks, this fixes it. Hopefully it will

Re: 'bad remote port parent' warnings

Hi Sakari, On Fri, Nov 23, 2018 at 10:35 AM Sakari Ailus wrote: > Makes sense. This is not necessarily a fatal error. Could you send a patch? Yes, I have just sent it. Thanks

[PATCH] media: v4l2-fwnode: Demote warning to debug level

debug level and make the wording a bit less misleading. Suggested-by: Philipp Zabel Signed-off-by: Fabio Estevam --- drivers/media/v4l2-core/v4l2-fwnode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c in

Re: 'bad remote port parent' warnings

Hi Philipp, On Thu, Nov 22, 2018 at 2:27 PM Philipp Zabel wrote: > There are empty endpoint nodes (without remote-endpoint property) > labeled ipu1_csi[01]_mux_from_parallel_sensor in the i.MX6 device trees > for board DT implementers' convenience. See commit 2539f517acbdc ("ARM: > dts:

Re: 'bad remote port parent' warnings

Hi Sakari, On Tue, Nov 20, 2018 at 10:15 AM Sakari Ailus wrote: > Where's the DT source for the board? Board dts is arch/arm/boot/dts/imx6qdl-wandboard.dtsi SoC dtsi is arch/arm/boot/dts/imx6q.dtsi Also, since 4.20-rc the following errors are seen: [3.449564] imx-ipuv3 240.ipu:

'bad remote port parent' warnings

this from happening? Thanks, Fabio Estevam

[PATCH v3 2/3] media: imx-pxp: Check for pxp_soft_reset() error

pxp_soft_reset() may fail with a timeout, so it is better to propagate the error in this case. Signed-off-by: Fabio Estevam Reviewed-by: Philipp Zabel --- Changes since v2: - Jump to err_clck when pxp_soft_reset() fails. (Philipp) drivers/media/platform/imx-pxp.c | 12 +--- 1 file

[PATCH v3 1/3] media: imx-pxp: Check the return value from clk_prepare_enable()

clk_prepare_enable() may fail, so we should better check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam Reviewed-by: Philipp Zabel --- Changes since v2: - None drivers/media/platform/imx-pxp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion

[PATCH v3 3/3] media: imx-pxp: Improve pxp_soft_reset() error message

Improve the pxp_soft_reset() error message by moving it to the caller function, associating it with a proper device and also by displaying the error code. Signed-off-by: Fabio Estevam Reviewed-by: Philipp Zabel --- Changes since v2: - None (only rebased against the change made in 2/3) drivers

[PATCH v2 1/3] media: imx-pxp: Check the return value from clk_prepare_enable()

clk_prepare_enable() may fail, so we should better check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam --- Changes since v1: - Properly enumerate the series drivers/media/platform/imx-pxp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

[PATCH v2 2/3] media: imx-pxp: Check for pxp_soft_reset() error

pxp_soft_reset() may fail with a timeout, so it is better to propagate the error in this case. Signed-off-by: Fabio Estevam --- Changes since v1: - None drivers/media/platform/imx-pxp.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/imx

[PATCH v2 3/3] media: imx-pxp: Improve pxp_soft_reset() error message

Improve the pxp_soft_reset() error message by moving it to the caller function, associating it with a proper device and also by displaying the error code. Signed-off-by: Fabio Estevam --- Changes since v1: - Newly introduced in this version drivers/media/platform/imx-pxp.c | 8 1 file

[PATCH 2/2] media: imx-pxp: Check for pxp_soft_reset() error

pxp_soft_reset() may fail with a timeout, so it is better to propagate the error in this case. Signed-off-by: Fabio Estevam --- drivers/media/platform/imx-pxp.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/imx-pxp.c b/drivers/media

[PATCH] media: imx-pxp: Check the return value from clk_prepare_enable()

clk_prepare_enable() may fail, so we should better check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam --- drivers/media/platform/imx-pxp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/imx-pxp.c b/drivers

Re: [PATCH v2 3/4] media: imx-pxp: add i.MX Pixel Pipeline driver

Hi Philipp, On Wed, Sep 5, 2018 at 7:00 AM, Philipp Zabel wrote: > index ..2f90c692f3fe > --- /dev/null > +++ b/drivers/media/platform/imx-pxp.c > @@ -0,0 +1,1774 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later The recommended SPDX format in this case is: //

Re: [PATCH 0/4] media: ov2680: follow up from initial version

Hi Rui, On Tue, May 8, 2018 at 10:52 AM, Rui Miguel Silva wrote: > So, my understand is that the patches will be applied or are already > applied to someone tree (strange patchwork does not send who or which > tree), but since I do not want to break someone workflow I will

Re: [PATCH 0/4] media: ov2680: follow up from initial version

Hi Rui, On Mon, May 7, 2018 at 12:56 PM, Rui Miguel Silva wrote: > Sorry I have Out-of-Office some part of last week, I had v6 of the original > series ready but since I have received the notification from patchwork that > the > v5 was accepted, I am sending this as a

Re: [PATCH v3 12/14] ARM: dts: imx7s-warp: add ov2680 sensor node

Hi Rui, On Mon, May 7, 2018 at 1:21 PM, Rui Miguel Silva wrote: > + reg_peri_3p15v: regulator-peri-3p15v { > + compatible = "regulator-fixed"; > + regulator-name = "peri_3p15v_reg"; > + regulator-min-microvolt = <315>; >

Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

Hi Rui, On Thu, Apr 19, 2018 at 8:00 AM, Rui Miguel Silva wrote: > Add device tree binding documentation for the OV2680 camera sensor. > > Reviewed-by: Rob Herring > CC: devicet...@vger.kernel.org > Signed-off-by: Rui Miguel Silva >

Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

On Mon, Apr 23, 2018 at 12:09 PM, Rui Miguel Silva wrote: > Yes, you are correct, I will fix this, and the dts entry. As this pin has both reset and powerdown functionalities, maybe you can name the property as 'reset-gpios' Thanks

Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680

Hi Rui, On Thu, Apr 19, 2018 at 8:00 AM, Rui Miguel Silva wrote: > +Optional Properties: > +- powerdown-gpios: reference to the GPIO connected to the powerdown pin, > +if any. This is an active high signal to the OV2680. I looked at the OV2680

Re: [PATCH v2] media: imx-media-csi: Fix inconsistent IS_ERR and PTR_ERR

Hi Hans, Unfortunately this one missed to be applied into 4.17-rc and now the imx-media-csi driver does not probe. Please consider applying it for 4.17-rc3 to avoid the regression. Thanks On Mon, Apr 16, 2018 at 2:28 PM, Fabio Estevam <feste...@gmail.com> wrote: > From: From: Gus

[PATCH RESEND 2/3] media: ov5695: Remove owner assignment from i2c_driver

From: Fabio Estevam <fabio.este...@nxp.com> Structure i2c_driver does not need to set the owner field, as this will be populated by the driver core. Generated by scripts/coccinelle/api/platform_no_drv_owner.cocci. Cc: Shunqian Zheng <zhen...@rock-chips.com> Signed-off-by: F

[PATCH RESEND 3/3] media: ov13858: Remove owner assignment from i2c_driver

From: Fabio Estevam <fabio.este...@nxp.com> Structure i2c_driver does not need to set the owner field, as this will be populated by the driver core. Generated by scripts/coccinelle/api/platform_no_drv_owner.cocci. Cc: Sakari Ailus <sakari.ai...@linux.intel.com> Signed-off-by: F

Re: imx-media: MT9P031 Capture issues on IMX6

On Thu, Apr 19, 2018 at 1:55 PM, Ibtsam Ul-Haq wrote: > I can see by using a logic analyzer that the PIXCLK does not look > nice. It looks similar to the issue mentioned here: > https://community.nxp.com/thread/454467 > > except that in my case it looks pulled up

Re: [PATCH v3 1/2] media: imx-media-csi: Fix inconsistent IS_ERR and PTR_ERR

On Mon, Apr 16, 2018 at 10:16 AM, Philipp Zabel wrote: > The second patch is applied now, but this part is still missing in > v4.17-rc1, causing the CSI subdev probe to fail: > > imx-ipuv3-csi: probe of imx-ipuv3-csi.0 failed with error -1369528304 > imx-ipuv3-csi:

[PATCH v2] media: imx-media-csi: Fix inconsistent IS_ERR and PTR_ERR

n't initialize vars that won't be used") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> Acked-by: Philipp Zabel <p.za...@pengutronix.de> --- Changes since v1: - Rebased against 4.17-rc1 drivers/staging/med

Re: IMX6 Media dev node not created

Hi Ibtsam, On Thu, Apr 5, 2018 at 11:52 AM, Ibtsam Ul-Haq wrote: > That worked like a charm! Thanks a lot guys, I would have never thought of > that! Excellent! If you have a chance, please submit the the dts patch that enables the camera to the linux-arm-kernel

Re: IMX6 Media dev node not created

Hi Ibtsam, [Adding Steve and Philipp in case they can provide some suggestions] On Thu, Apr 5, 2018 at 9:30 AM, Ibtsam Ul-Haq wrote: > Greetings everyone, > > I'm running Linux 4.14.31 on an IMX6 QuadPlus based Phytec board > (PCM-058). I have connected an mt9p031

[PATCH 3/3] media: ov13858: Remove owner assignment from i2c_driver

From: Fabio Estevam <fabio.este...@nxp.com> Structure i2c_driver does not need to set the owner field, as this will be populated by the driver core. Generated by scripts/coccinelle/api/platform_no_drv_owner.cocci. Cc: Sakari Ailus <sakari.ai...@linux.intel.com> Signed-off-by: F

[PATCH 1/3] media: si2165: Remove owner assignment from i2c_driver

From: Fabio Estevam <fabio.este...@nxp.com> Structure i2c_driver does not need to set the owner field, as this will be populated by the driver core. Generated by scripts/coccinelle/api/platform_no_drv_owner.cocci. Cc: Matthias Schwarzott <z...@gentoo.org> Signed-off-by: F

[PATCH 2/3] media: ov5695: Remove owner assignment from i2c_driver

From: Fabio Estevam <fabio.este...@nxp.com> Structure i2c_driver does not need to set the owner field, as this will be populated by the driver core. Generated by scripts/coccinelle/api/platform_no_drv_owner.cocci. Cc: Shunqian Zheng <zhen...@rock-chips.com> Signed-off-by: F

Re: [PATCH v3 2/2] media: imx-media-csi: Do not propagate the error when pinctrl is not found

Hi Mauro and Hans, On Sat, Mar 10, 2018 at 12:53 PM, Fabio Estevam <feste...@gmail.com> wrote: > Hi, > > On Sat, Mar 3, 2018 at 9:56 AM, Fabio Estevam <feste...@gmail.com> wrote: >> From: Fabio Estevam <fabio.este...@nxp.com> >> >> Since commit 52e

Re: [PATCH 1/3] dt-bindings: display: dw_hdmi.txt

Hi Hans, On Mon, Mar 19, 2018 at 8:43 AM, Hans Verkuil wrote: > From: Hans Verkuil It seems the Subject line is missing some content?

[PATCH v2] media: ov2685: Remove owner assignment from i2c_driver

From: Fabio Estevam <fabio.este...@nxp.com> Structure i2c_driver does not need to set the owner field, as this will be populated by the driver core. Generated by scripts/coccinelle/api/platform_no_drv_owner.cocci. Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- Changes s

[PATCH] media: ov2685: Remove owner assignment from platform_driver

From: Fabio Estevam <fabio.este...@nxp.com> platform_driver does not need to set the owner field, as this will be populated by the driver core. Generated by scripts/coccinelle/api/platform_no_drv_owner.cocci. Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- drivers/media/

Re: [PATCH v2] media: staging/imx: fill vb2_v4l2_buffer sequence entry

Hi Peter, On Tue, Mar 13, 2018 at 7:34 PM, Peter Seiderer wrote: > Signed-off-by: Peter Seiderer Could you please resend with a commit log explaining the reason for this patch? Tahnks

Re: coda: i.MX6 decoding performance issues for multi-streaming

Hi Javier, On Mon, Mar 12, 2018 at 1:54 PM, Javier Martin wrote: > Hi, > we have an i.MX6 Solo based board running the latest mainline kernel > (4.15.3). > > As part of our development we were measuring the decoding performance of the > i.MX6 coda chip. > > For that

Re: [PATCH v3 2/2] media: imx-media-csi: Do not propagate the error when pinctrl is not found

Hi, On Sat, Mar 3, 2018 at 9:56 AM, Fabio Estevam <feste...@gmail.com> wrote: > From: Fabio Estevam <fabio.este...@nxp.com> > > Since commit 52e17089d185 ("media: imx: Don't initialize vars that > won't be used") imx_csi_probe(

Re: [PATCH] media: ov5640: fix get_/set_fmt colorspace related fields

Hi Sakari, On Wed, Mar 7, 2018 at 5:13 AM, Sakari Ailus wrote: >> @@ -2497,16 +2504,22 @@ static int ov5640_probe(struct i2c_client *client, >> struct fwnode_handle *endpoint; >> struct ov5640_dev *sensor; >> int ret; >> + struct v4l2_mbus_framefmt

Re: [PATCH] media: dvbdev: fix building on ia64

macro takes care of both built-in and module as it will expand to: #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE) and that's the reason why IS_ENABLE() fixes the build problem. Regards, Fabio Estevam

[PATCH v3 2/2] media: imx-media-csi: Do not propagate the error when pinctrl is not found

From: Fabio Estevam <fabio.este...@nxp.com> Since commit 52e17089d185 ("media: imx: Don't initialize vars that won't be used") imx_csi_probe() fails to probe after propagating the devm_pinctrl_get_select_default() error. devm_pinctrl_get_select_default() may return -ENODEV when

[PATCH v3 1/2] media: imx-media-csi: Fix inconsistent IS_ERR and PTR_ERR

nitialize vars that won't be used") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> Acked-by: Philipp Zabel <p.za...@pengutronix.de> --- Changes since v2: - None Changes since v1: - None drivers/staging/media/imx/i

[PATCH v2 1/2] media: imx-media-csi: Fix inconsistent IS_ERR and PTR_ERR

nitialize vars that won't be used") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> Acked-by: Philipp Zabel <p.za...@pengutronix.de> --- Changes since v1: - None drivers/staging/media/imx/imx-media-csi.c | 2

[PATCH v2 2/2] media: imx-media-csi: Do not propagate the error when pinctrl is not found

From: Fabio Estevam <fabio.este...@nxp.com> Since commit 52e17089d185 ("media: imx: Don't initialize vars that won't be used") imx_csi_probe() fails to probe after propagating the devm_pinctrl_get_select_default() error. devm_pinctrl_get_select_default() may return -ENODEV when

[PATCH 2/2] media: imx-media-csi: Do not propagate the error when pinctrl is not found

From: Fabio Estevam <fabio.este...@nxp.com> Since commit 52e17089d185 ("media: imx: Don't initialize vars that won't be used") imx_csi_probe() fails to probe after propagating the devm_pinctrl_get_select_default() error. devm_pinctrl_get_select_default() may return -ENODEV when

[PATCH 1/2] media: imx-media-csi: Fix inconsistent IS_ERR and PTR_ERR

nitialize vars that won't be used") Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> Acked-by: Philipp Zabel <p.za...@pengutronix.de> --- drivers/staging/media/imx/imx-media-csi.c | 2 +- 1 file changed, 1 in

Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

On Thu, Mar 1, 2018 at 1:27 PM, Philipp Zabel wrote: > Oh, this only works for csi ports that have pinctrl in their csi port > node, like: > > _csi0 { > pinctrl-names = "default"; > pinctrl-0 = <_ipu1_csi0>; > }; This is the case for imx6qdl-sabresd.dtsi

Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

Steve, Phiipp, On Thu, Mar 1, 2018 at 1:02 PM, Fabio Estevam <feste...@gmail.com> wrote: > So imx_csi_probe() does not succeed anymore since > devm_pinctrl_get_select_default() always fails. > > Not sure I understand the comments that explain the need for pinctrl > handl

Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR

On Thu, Mar 1, 2018 at 1:09 AM, Gustavo A. R. Silva wrote: > Fix inconsistent IS_ERR and PTR_ERR in imx_csi_probe. > The proper pointer to be passed as argument is pinctrl > instead of priv->vdev. > > This issue was detected with the help of Coccinelle. > > Fixes:

Re: [PATCH 1/2] media: ov2680: dt: Add bindings for OV2680

On Thu, Feb 22, 2018 at 7:23 AM, Rui Miguel Silva wrote: > Add device tree binding documentation for the OV5640 camera sensor. s/OV5640/OV2680

[PATCH v3 1/2] media: imx-media-internal-sd: Use empty initializer

From: Fabio Estevam <fabio.este...@nxp.com> {0} explicitly assigns 0 to the first member of the structure. The first element of the platform_device_info struct is a pointer and when writing 0 to a pointer the following sparse error is seen: drivers/staging/media/imx/imx-media-internal-sd

[PATCH v3 2/2] media: imx-ic-prpencvf: Use empty initializer

From: Fabio Estevam <fabio.este...@nxp.com> {0} explicitly assigns 0 to the first member of the structure. Even though the first member of the v4l2_subdev_format structure is of _u32 type, make the initialization more robust by using the empty initializer. This way in case someday the

Re: i.MX53 using imx-media to capture analog video through ADV7180

[Adding Steve and Philipp in case they could provide some suggestions] On Wed, Feb 14, 2018 at 1:21 PM, Matthew Starr wrote: > I have successfully modified device tree files in the mainline 4.15.1 kernel > to get a display product using the i.MX53 processor to initialize

Re: [PATCH v2] media: imx-media-internal-sd: Use empty initializer

Hi Steve, On Fri, Feb 9, 2018 at 9:42 PM, Steve Longerbeam wrote: > There is one other case of the use of "{0}" to initialize a stack/local > struct, in prp_enum_frame_size(). It should be fixed there as well, to > be consistent. Yes, just sent a patch as you suggested.

[PATCH] media: imx-ic-prpencvf: Use empty initializer to clear all struct members

From: Fabio Estevam <fabio.este...@nxp.com> {0} only cleans the first member of the structure. Use {} instead, which cleans all the members of the structure. Reported-by: Steve Longerbeam <slongerb...@gmail.com> Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- drivers

[PATCH v2] media: imx-media-internal-sd: Use empty initializer

From: Fabio Estevam <fabio.este...@nxp.com> When building with W=1 the following warning shows up: drivers/staging/media/imx/imx-media-internal-sd.c:274:49: warning: Using plain integer as NULL pointer Fix this problem by using an empty initializer, which guarantees that all struct m

[PATCH] media: imx-media-internal-sd: Use memset to clear pdevinfo struct

When building with W=1 the following warning shows up: drivers/staging/media/imx/imx-media-internal-sd.c:274:49: warning: Using plain integer as NULL pointer Fix this problem by using memset() to clear the pdevinfo structure. Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- d

Re: [PATCH v2 9/9] media: i2c: tw9910: Remove soc_camera dependencies

On Wed, Jan 3, 2018 at 3:37 PM, jacopo mondi wrote: >> Initially the rest GPIO was doing: >> >> - gpio_set_value(GPIO_PTT3, 0); >> - mdelay(10); >> - gpio_set_value(GPIO_PTT3, 1); >> - mdelay(10); /* wait to let chip come out of reset */ > > And that's

Re: [PATCH v2 9/9] media: i2c: tw9910: Remove soc_camera dependencies

Hi Jacopo, On Wed, Jan 3, 2018 at 3:13 PM, jacopo mondi wrote: > That would be true if I would have declared the GPIO to be ACTIVE_LOW. > See patch [5/9] in this series and search for "rstb". The GPIO (which > is shared between two devices) is said to be active high... Just

[PATCH] media: ov5640: Check the return value from clk_prepare_enable()

clk_prepare_enable() may fail, so we should better check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- drivers/media/i2c/ov5640.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov56

Re: [PATCH v2 9/9] media: i2c: tw9910: Remove soc_camera dependencies

Hi Jacopo, On Thu, Dec 28, 2017 at 12:01 PM, Jacopo Mondi wrote: > + if (priv->rstb_gpio) { > + gpiod_set_value(priv->rstb_gpio, 0); > + usleep_range(500, 1000); > + gpiod_set_value(priv->rstb_gpio, 1); > +

Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver

On Tue, Dec 19, 2017 at 11:43 AM, Sakari Ailus wrote: > Both seem to exist. See e.g. c3a3d1d6b8b363a02234e5564692db3647f183e6 . This patch fixes .h files to use /* SPDX style comment, which is the recommendation. .c files should use // SPDX style.

Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver

Hi Sakari, On Tue, Dec 19, 2017 at 11:05 AM, Sakari Ailus wrote: > I guess it depends on who do you ask and when. Looking at what has been > recently merged to media tree master, the latter is preferred. Just did 'git grep SPDX drivers/media' and it consistently shows //

Re: [PATCH v9 2/2] media: i2c: Add the ov7740 image sensor driver

Hi Sakari, On Tue, Dec 19, 2017 at 7:22 AM, Sakari Ailus wrote: > On Mon, Dec 11, 2017 at 09:31:46AM +0800, Wenyou Yang wrote: >> The ov7740 (color) image sensor is a high performance VGA CMOS >> image snesor, which supports for output formats: RAW RGB and YUV >> and image

[PATCH] [media] coda/imx-vdoa: Remove irq member from vdoa_data struct

From: Fabio Estevam <fabio.este...@nxp.com> The 'irq' member of the vdoa_data struct is only used inside probe, so there is no need for it. Use a local variable 'ret' instead. Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- drivers/media/platform/coda/imx-vdoa.c | 8

Re: [PATCH v2 2/2] media: coda: Add i.MX51 (CodaHx4) support

facts. > > Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Reviewed-by: Fabio Estevam <fabio.este...@nxp.com>

Re: [alsa-devel] [PATCH 3/5] media: i2c: Add TDA1997x HDMI receiver driver

Hi Tim, On Thu, Nov 9, 2017 at 4:45 PM, Tim Harvey wrote: > +static int tda1997x_set_power(struct tda1997x_state *state, bool on) > +{ > + int ret = 0; > + > + if (on) { > + ret = regulator_bulk_enable(TDA1997X_NUM_SUPPLIES, > +

Re: [PATCH v2 3/4] media: ov5640: add support of DVP parallel interface

Hi Hugues, On Wed, Nov 29, 2017 at 3:11 PM, Hugues Fruchet wrote: > Add support of DVP parallel mode in addition of > existing MIPI CSI mode. The choice between two modes > and configuration is made through device tree. What about explaining how to select between the two

Re: [PATCH v2 2/4] media: ov5640: check chip id

Hi Hugues, On Wed, Nov 29, 2017 at 3:11 PM, Hugues Fruchet wrote: > /* read exposure, in number of line periods */ > static int ov5640_get_exposure(struct ov5640_dev *sensor) > { > @@ -1562,6 +1586,10 @@ static int ov5640_set_power(struct ov5640_dev *sensor, > bool

Re: [PATCH][MEDIA]i.MX6 CSI: Fix MIPI camera operation in RAW/Bayer mode

On Tue, Oct 17, 2017 at 11:53 AM, Russell King - ARM Linux wrote: > I do wish the patch was merged (which fixes a real problem) rather than > hanging around for optimisation questions. We can always increase it > in the future if it's deemed that a larger burst size is

Re: [PATCH][MEDIA]i.MX6 CSI: Fix MIPI camera operation in RAW/Bayer mode

Hi Krzysztof, On Tue, Oct 17, 2017 at 4:27 AM, Krzysztof Hałasa wrote: > Without this fix, in 8-bit Y/Bayer mode, every other 8-byte group > of pixels is lost. > Not sure about possible side effects, though. > > Signed-off-by: Krzysztof Hałasa > > ---

Re: [PATCH 1/3] drm: bridge: synopsys/dw-hdmi: Enable cec clock

external CEC clock then. Regards, Fabio Estevam

Re: [PATCH 1/3] drm: bridge: synopsys/dw-hdmi: Enable cec clock

Hi Pierre-Hugues, On Fri, Oct 13, 2017 at 7:53 PM, Pierre-Hugues Husson wrote: > The documentation already mentions "cec" optional clock, but > currently the driver doesn't enable it. The cec clock is enabled at dw_hdmi_cec_enable().

Re: [PATCH 1/1] v4l: async: Fix notifier complete callback error handling

Hi Russell, On Mon, Oct 2, 2017 at 7:12 PM, Russell King - ARM Linux wrote: >> > > Any chance of sending me that patch so I can test this patch? I'd > rather not manually de-html-ise the above patch. You can

Re: IMX6 ADV7180 no /dev/media

On Fri, Sep 15, 2017 at 8:46 PM, Fabio Estevam <feste...@gmail.com> wrote: > Tim, > > Care to send the patch enabling CONFIG_VIDEO_MUX? Nevermind. I have just sent it.

Re: IMX6 ADV7180 no /dev/media

Hi Steve, On Fri, Sep 15, 2017 at 8:39 PM, Steve Longerbeam wrote: > Agreed, but I notice now that CONFIG_MEDIA_CONTROLLER and > CONFIG_VIDEO_V4L2_SUBDEV_API are not enabled there anymore. I do see them enabled in mainline with imx_v6_v7_defconfig. Tim, Care to send

[PATCH 1/4] [media] max2175: Propagate the real error on devm_clk_get() failure

From: Fabio Estevam <fabio.este...@nxp.com> When devm_clk_get() fails we should return the real error code instead of always returning -ENODEV. This allows defer probe to happen in the case the clock provider has not been enabled by the time max2175 driver gets probed. Signed-off-by:

[PATCH 3/4] [media] ov2640: Propagate the real error on devm_clk_get() failure

From: Fabio Estevam <fabio.este...@nxp.com> devm_clk_get() may return different error codes other than -EPROBE_DEFER, so it is better to return the real error code instead. Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- drivers/media/i2c/ov2640.c | 2 +- 1 file changed,

[PATCH 2/4] [media] mt9m111: Propagate the real error on v4l2_clk_get() failure

From: Fabio Estevam <fabio.este...@nxp.com> v4l2_clk_get() may return different error codes other than -EPROBE_DEFER, so it is better to return the real error code instead. Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- drivers/media/i2c/mt9m111.c | 2 +- 1 file changed,

[PATCH 4/4] [media] ov2640: Check the return value from clk_prepare_enable()

From: Fabio Estevam <fabio.este...@nxp.com> clk_prepare_enable() may fail, so we should better check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- drivers/media/i2c/ov2640.c | 4 +++- 1 file changed, 3 insertions(+)

[PATCH] [media] mx2_emmaprp: Check for platform_get_irq() error

From: Fabio Estevam <fabio.este...@nxp.com> platform_get_irq() may fail, so we should better check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- drivers/media/platform/mx2_emmaprp.c | 2 ++ 1 file changed, 2 inserti

[PATCH] [media] coda/imx-vdoa: Check for platform_get_resource() error

From: Fabio Estevam <fabio.este...@nxp.com> platform_get_resource() may fail and in this case a NULL dereference will occur. Prevent this from happening by returning an error on platform_get_resource() failure. Fixes: b0444f18e0b18abce ("[media] coda: add i.MX6 VDOA driver&q

Re: [PATCH 1/2] [media] ov7670: Return the real error code

Hi Sakari, On Tue, Aug 8, 2017 at 8:24 AM, Sakari Ailus wrote: > I don't think -EPROBE_DEFER is returned by clk_get() if the clock can't be > found. The clock providers often are e.g. ISP drivers that may well be Yes, it is. Please check: commit

[PATCH] [media] ov5640: Remove unneeded gpiod NULL check

From: Fabio Estevam <fabio.este...@nxp.com> The gpiod API checks for NULL descriptors, so there is no need to duplicate the check in the driver. Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- drivers/media/i2c/ov5640.c | 3 +-- 1 file changed, 1 insertion(+), 2 deleti

[PATCH 2/2] [media] ov7670: Check the return value from clk_prepare_enable()

From: Fabio Estevam <fabio.este...@nxp.com> clk_prepare_enable() may fail, so we should better check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- drivers/media/i2c/ov7670.c | 4 +++- 1 file changed, 3 insertions(+)

[PATCH 1/2] [media] ov7670: Return the real error code

From: Fabio Estevam <fabio.este...@nxp.com> When devm_clk_get() fails the real error code should be propagated, instead of always returning -EPROBE_DEFER. Signed-off-by: Fabio Estevam <fabio.este...@nxp.com> --- drivers/media/i2c/ov7670.c | 2 +- 1 file changed, 1 insertion(+)

Re: coda 2040000.vpu: firmware request failed

Hi Jagan, On Fri, Jul 7, 2017 at 9:45 AM, Jagan Teki wrote: > Hi, > > I'm observing firmware request failure with i.MX6Q board, This is with > latest linux-next (4.12) with firmware from, [1] and converted > v4l-coda960-imx6q.bin using [2]. There is no need to do the

Re: Shawn Guo: your attetion is needed here Re: [PATCH v8 00/34] i.MX Media Driver

On Tue, Jun 20, 2017 at 5:29 AM, Pavel Machek wrote: > Hmm. I changed the subject to grab Shawn's attetion. > > But his acks should not be needed for forward progress. Yes, it would > be good, but he does not react -- so just reorder the series so that > dts changes come last, then

Re: how to link up audio bus from media controller driver to soc dai bus?

Hi Tim, On Mon, Jun 12, 2017 at 4:15 PM, Tim Harvey wrote: > Greetings, > > I'm working on a media controller driver for the tda1997x HDMI > receiver which provides an audio bus supporting I2S/SPDIF/OBA/HBR/DST. > I'm unclear how to bind the audio bus to a SoC's audio bus,

Re: [PATCH v5 07/39] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

On Fri, Mar 10, 2017 at 6:57 PM, Pavel Machek wrote: > And it should not depend on configuration. Hardware vendor should be > able to ship board with working device tree... We are talking about pin conflict here. Please read the commit log of this patch for details.

Re: [PATCH v5 07/39] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

On Fri, Mar 10, 2017 at 3:59 PM, Troy Kisky wrote: > On 3/9/2017 8:52 PM, Steve Longerbeam wrote: >> There is a pin conflict with GPIO_6. This pin functions as a power >> input pin to the OV5642 camera sensor, but ENET uses it as the h/w >> workaround for erratum

Re: [PATCH] [media] coda: restore original firmware locations

an old firmware location > off the list. > > Fixes: 8af7779f3cbc ("[media] coda: add Freescale firmware compatibility > location") > Cc: Baruch Siach <bar...@tkos.co.il> > Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> Reviewed-by: Fabio Estevam <fabio.este...@nxp.com>

Re: [PATCH v4 07/36] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors

Hi Steve, On Thu, Feb 16, 2017 at 12:19 AM, Steve Longerbeam wrote: > Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. > > The OV5642 connects to the parallel-bus mux input port on ipu1_csi0_mux. > > The OV5640 connects to the input port on the

Re: [git:media_tree/master] [media] coda: add Freescale firmware compatibility location

r: Baruch Siach <bar...@tkos.co.il> > Date:Sun Jan 15 08:33:53 2017 -0200 > > The Freescale provided imx-vpu looks for firmware files under > /lib/firmware/vpu > by default. Make coda look there for firmware files to ease the update path. > > Cc: Fabio Estevam <fes

Re: [PATCH v3] [media] coda: add Freescale firmware compatibility location

On Sun, Jan 15, 2017 at 8:33 AM, Baruch Siach <bar...@tkos.co.il> wrote: > The Freescale provided imx-vpu looks for firmware files under > /lib/firmware/vpu > by default. Make coda look there for firmware files to ease the update path. > > Cc: Fabio Estevam <feste...

Re: [PATCH v2 05/19] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors

On Tue, Jan 3, 2017 at 6:57 PM, Steve Longerbeam wrote: > + camera: ov5642@3c { > + compatible = "ovti,ov5642"; > + pinctrl-names = "default"; > + pinctrl-0 = <_ov5642>; > + clocks = < IMX6QDL_CLK_CKO>; > +

Re: [PATCH v2 00/19] i.MX Media Driver

; - added a few missing Signed-off-by's. Tested the series on a mx6qsabresd, so: Tested-by: Fabio Estevam <fabio.este...@nxp.com> -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/20] i.MX Media Driver

eference platforms. > > This patchset includes the OF graph layout as proposed by Philipp Zabel, > with only minor changes which are enumerated in the patch header. Patches 13, 14 and 19 miss your Signed-off-by tag. Tested the whole series on a mx6qsabresd: Tested-by: Fabio Estevam <fabio.este

Re: [PATCH v2 00/21] Basic i.MX IPUv3 capture support

Hi Jean-Michel, On Mon, Jan 2, 2017 at 12:59 PM, Jean-Michel Hautbois wrote: > Steve: which branch is the correct one on your github ? I have tested imx-media-staging-md-v2 (based on 4.9-rc) and also imx-media-staging-md-v4 branch, which is based on 4.10-rc1.

  1   2   3   >