Re: [PATCH v4 5/5] media: ov2640: dt: add the device tree binding document

2014-12-18 Thread Fabio Estevam
Hi Sylwester, On Thu, Dec 18, 2014 at 10:13 AM, Sylwester Nawrocki wrote: > Hi Josh, > > On 18/12/14 03:27, Josh Wu wrote: >> Add the document for ov2640 dt. >> >> Cc: devicet...@vger.kernel.org >> Signed-off-by: Josh Wu > > Acked-by: Sylwester Nawrocki > > It seems "ovti" is not in the list of

[PATCH 1/2] [media] adv7180: Simplify PM hooks

2014-12-16 Thread Fabio Estevam
The macro SIMPLE_DEV_PM_OPS already takes care of the CONFIG_PM_SLEEP=n case, so move it out of the CONFIG_PM_SLEEP 'if' block and remove the unneeded ADV7180_PM_OPS definition to make the code simpler. Signed-off-by: Fabio Estevam --- drivers/media/i2c/adv7180.c | 9 ++--- 1 fi

[PATCH 2/2] [media] adv7180: Remove the unneeded 'err' label

2014-12-16 Thread Fabio Estevam
There is no need to jump to the 'err' label as we can simply return the error code directly and make the code shorter. Signed-off-by: Fabio Estevam --- drivers/media/i2c/adv7180.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/adv7180.c

[PATCH] coda: coda-common: Remove mx53 entry from coda_platform_ids

2014-12-11 Thread Fabio Estevam
From: Fabio Estevam As mx53 is a dt-only architecture we can safely remove its entry from the coda_platform_ids[] structure. Signed-off-by: Fabio Estevam --- drivers/media/platform/coda/coda-common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/coda/coda

coda: not generating EOS event

2014-12-11 Thread Fabio Estevam
Hi, I am running Gstreamer 1.4.4 with on a imx6q-sabresd board and I am able to decode a video through the coda driver. The pipeline I use is: gst-launch-1.0 filesrc location=/home/H264_test1_Talkinghead_mp4_480x360.mp4 ! qtdemux ! h264parse ! v4l2video1dec ! videoconvert ! fbdevsink It plays th

Re: VPU on iMX51 babbage board

2014-12-10 Thread Fabio Estevam
3ff4000.vpu: Initialized CODA7541. [1.373572] coda 83ff4000.vpu: Firmware version: 1.4.50 [1.396695] coda 83ff4000.vpu: codec registered as /dev/video[0-3] Also, no sure if we need to distinguish mx51 versus mx53 in the coda driver. Adding Philipp in case he can comment. Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/5] media: ov2640: add a master clock for sensor

2014-12-08 Thread Fabio Estevam
On Mon, Dec 8, 2014 at 9:29 AM, Josh Wu wrote: > + priv->master_clk = devm_clk_get(&client->dev, "xvclk"); > + if (IS_ERR(priv->master_clk)) > + return -EINVAL; You should return PTR_ERR(priv->master_clk) instead. -- To unsubscribe from this list: send the line "unsubsc

Re: Using the coda driver with Gstreamer

2014-12-01 Thread Fabio Estevam
pipeline: gst-launch-1.0 filesrc location=/home/H264_test1_Talkinghead_mp4_480x360.mp4 ! qtdemux ! h264parse ! v4l2video1dec ! videoconvert ! fbdevsink (Still on Gstreamer 1.4.1 version though, as I was not able to upgrade it yet). Regards, Fabio Estevam -- To unsubscribe from this list: send t

Re: i.MX6 CODA960 encoder

2014-11-27 Thread Fabio Estevam
On Thu, Nov 27, 2014 at 3:54 PM, Jean-Michel Hautbois wrote: > I don't have the same behaviour, but I may have missed a patch. > I have taken linux-next and rebased my work on it. I have some issues, > but nothing to be worried about, no link with coda. > I get the following : > $> v4l2-ctl -d0 -

[PATCH 1/2] of: Add new compatibles for CODA bindings

2014-11-26 Thread Fabio Estevam
m the i.MX6Q/D version. Signed-off-by: Philipp Zabel Signed-off-by: Fabio Estevam --- Documentation/devicetree/bindings/media/coda.txt | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/media/coda.txt b/Documentation/devicetree/bindings/

[PATCH 2/2] of: Add named interrupts to CODA bindings

2014-11-26 Thread Fabio Estevam
From: Philipp Zabel This patch documents named interrupt bindings for the CODA video processing units. Signed-off-by: Philipp Zabel Signed-off-by: Fabio Estevam --- Documentation/devicetree/bindings/media/coda.txt | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a

Re: Using the coda driver with Gstreamer

2014-11-18 Thread Fabio Estevam
On Mon, Nov 17, 2014 at 5:58 PM, Fabio Estevam wrote: >> Just a wild guess - we usually test here with dmabuf capable devices and >> without X. As you are using gstglimagesink, the code around >> ext/gl/gstglimagesink.c (453) looks like gst_gl_context_create() went >>

Re: Using the coda driver with Gstreamer

2014-11-17 Thread Fabio Estevam
sts. I will give it a try. Thanks for the suggestions. Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Using the coda driver with Gstreamer

2014-11-17 Thread Fabio Estevam
Hi Andrey, On Mon, Nov 17, 2014 at 3:48 PM, Andrey Utkin wrote: > could you give `lspci -v` so that i see what module is a driver for > that component? I am using a mx6 processor that has a built-in hardware video encoder/decoder. The driver is located at drivers/media/platform/coda/ Thanks --

Re: Using the coda driver with Gstreamer

2014-11-17 Thread Fabio Estevam
Hi Nicolas, On Mon, Nov 17, 2014 at 3:45 PM, Nicolas Dufresne wrote: > Note, I'm only commenting about the GStreamer side... > > Le 2014-11-17 12:29, Fabio Estevam a écrit : >> Hi, >> >> I am running linux-next 20141117 on a mx6qsabresd board and trying to >>

Using the coda driver with Gstreamer

2014-11-17 Thread Fabio Estevam
server for file:///mnt/nfs/sample.mp4 ERROR debug information: /code/yocto/dizzy/build/tmp/work/cortexa9hf-vfp-neon-mx6qdl-poky-linux-gnueabi/gstreamer1.0-plugins-bad/1.4.1-r0/gst-plugins-bad-1.4.1/ext/gl/gstglimagesink.c(453): _ensure_gl_setup (): /GstPlayBin:playbin/GstPlaySink:playsink/GstBi

[PATCH 2/3] [media] coda: Unregister v4l2 upon alloc_workqueue() error

2014-10-04 Thread Fabio Estevam
From: Fabio Estevam If alloc_workqueue() fails, we should go to the 'err_v4l2_register' label, which will unregister the v4l2 device. Signed-off-by: Fabio Estevam --- drivers/media/platform/coda/coda-common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dri

[PATCH 3/3] [media] coda: Remove devm_kzalloc() error message

2014-10-04 Thread Fabio Estevam
From: Fabio Estevam Core code already prints on OOM errors, so no need to keep this here. Signed-off-by: Fabio Estevam --- drivers/media/platform/coda/coda-common.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/media/platform/coda/coda-common.c b/drivers

[PATCH 1/3] [media] coda: Call v4l2_device_unregister() from a single location

2014-10-04 Thread Fabio Estevam
From: Fabio Estevam Instead of calling v4l2_device_unregister() in multiple locations within the error paths, let's call it from a single location to make the error handling simpler. Signed-off-by: Fabio Estevam --- drivers/media/platform/coda/coda-common.c | 14 -- 1 file ch

Re: [PATCH 13/18] [media] s5p_mfc_opr_v5: Fix lots of warnings on x86_64

2014-09-24 Thread Fabio Estevam
On Wed, Sep 24, 2014 at 7:27 PM, Mauro Carvalho Chehab wrote: > - mfc_debug(2, "buf_size1: %d, buf_size2: %d\n", buf_size1, buf_size2); > + mfc_debug(2, "buf_size1: %zd, buf_size2: %zd\n", buf_size1, > buf_size2); This should be %zu. Same for other %zd ocurrences. -- To unsubscribe

Re: [PATCH 15/18] [media] s5p_mfc_opr: Fix warnings

2014-09-24 Thread Fabio Estevam
Hi Mauro, On Wed, Sep 24, 2014 at 7:27 PM, Mauro Carvalho Chehab wrote: > drivers/media//platform/s5p-mfc/s5p_mfc_opr.c:44:2: warning: format ‘%d’ > expects argument of type ‘int’, but argument 4 has type ‘size_t’ [-Wformat=] ... > - mfc_debug(3, "Allocating priv: %d\n", b->size); > +

[PATCH] [media] coda: coda-bit: Include ""

2014-09-19 Thread Fabio Estevam
From: Fabio Estevam coda-bit uses kmalloc/kfree functions, so the slab header needs to be included in order to fix the following build errors: drivers/media/platform/coda/coda-bit.c: In function 'coda_fill_bitstream': drivers/media/platform/coda/coda-bit.c:231:4: error: implicit decl

Re: [PATCHv2 2/3] [media] s5p-jpeg: Fix compilation with COMPILE_TEST

2014-09-09 Thread Fabio Estevam
On Tue, Sep 9, 2014 at 1:10 PM, Mauro Carvalho Chehab wrote: > ERROR: "__bad_ndelay" [drivers/media/platform/s5p-jpeg/s5p-jpeg.ko] undefined! > > That happens because asm-generic doesn't like any ndelay time > bigger than 20us. > > Currently, usleep_range() couldn't simply be used, since > exynos4

Re: [PATCH v2 00/11] CODA encoder/decoder device split

2014-08-01 Thread Fabio Estevam
Hi Mauro, On Tue, Jul 29, 2014 at 5:27 AM, Philipp Zabel wrote: > Hi, > > Am Freitag, den 18.07.2014, 12:22 +0200 schrieb Philipp Zabel: >> Hi, >> >> the following patches add a few fixes and cleanups and split the >> coda video4linux2 device into encoder and decoder. >> Following the principle o

Re: [PATCH v2 06/29] [media] coda: Add encoder/decoder support for CODA960

2014-07-25 Thread Fabio Estevam
Hi Robert, On Mon, Jul 21, 2014 at 4:07 AM, Robert Schwebel wrote: > Hi Fabio, > > On Fri, Jul 11, 2014 at 02:33:18PM +0200, Robert Schwebel wrote: >> On Wed, Jul 02, 2014 at 09:16:42PM +0200, Robert Schwebel wrote: >> > > It would be really nice if the firmware was available in the >> > > linux-

Re: [PATCH v2 06/29] [media] coda: Add encoder/decoder support for CODA960

2014-07-11 Thread Fabio Estevam
Hi Robert, On Fri, Jul 11, 2014 at 9:33 AM, Robert Schwebel wrote: > Hi Fabio, > > On Wed, Jul 02, 2014 at 09:16:42PM +0200, Robert Schwebel wrote: >> > It would be really nice if the firmware was available in the >> > linux-firmware repository. Do you think this would be possible? >> > >> > Best

[PATCH v2 1/2] [media] coda: Return the real error on platform_get_irq()

2014-06-04 Thread Fabio Estevam
From: Fabio Estevam No need to return a 'fake' return value on platform_get_irq() failure. Propagate the real error instead. Signed-off-by: Fabio Estevam Acked-by: Philipp Zabel --- Changes since v1: - None. Only rebased against latest tree drivers/media/platform/coda.c | 2

[PATCH v2 2/2] [media] coda: Propagate the correct error on devm_request_threaded_irq()

2014-06-04 Thread Fabio Estevam
From: Fabio Estevam If devm_request_threaded_irq() fails, we should better propagate the real error. Also, print out the error code in the dev_err message. Signed-off-by: Fabio Estevam Acked-by: Philipp Zabel --- Changes since v1: - None. Only rebased against latest tree drivers/media

Re: au0828 (950Q) kernel OOPS 3.10.30 imx6

2014-04-29 Thread Fabio Estevam
On Tue, Apr 29, 2014 at 4:50 PM, Carl Michal wrote: > Hello, > > I'm trying to use a Hauppage HVR-950Q ATSC tv stick with a Cubox-i running > geexbox. > > It works great, until it doesn't. After its been up and running for a few > hours (sometimes minutes), I start to get kernel OOPs, example past

Re: [media] coda: update CODA7541 to firmware 1.4.50

2014-04-11 Thread Fabio Estevam
Hi Dan/Philipp, On Fri, Apr 11, 2014 at 8:08 AM, Dan Carpenter wrote: > What ever happened with this? > > regards, > dan carpenter > > On Wed, Nov 06, 2013 at 07:13:43PM +0300, Dan Carpenter wrote: >> Hello Philipp Zabel, >> >> This is a semi-automatic email about new static checker warnings. >>

Re: How to enable "CONFIG_V4L2_MEM2MEM_DEV"

2014-01-06 Thread Fabio Estevam
M_DEV=y" in the generated .config. > > But when I try to add 'CONFIG_VIDEO_SAMSUNG_S5P_JPEG=y' to > imx_v6_v7_defconfig and re'make, I don't see > CONFIG_VIDEO_SAMSUNG_S5P_JPEG=y in the generated .config. CONFIG_VIDEO_SAMSUNG_S5P_JPEG is to be used with Samsu

Re: How to enable "CONFIG_V4L2_MEM2MEM_DEV"

2014-01-06 Thread Fabio Estevam
7;CONFIG_V4L_TEST_DRIVERS=y' in .config when I do "make ARCH=arm > CROSS_COMPILE=/usr/bin/arm-linux-gnueabi- imx_v6_v7_defconfig" > > I am not sure why CONFIG_V4L2_MEM2MEM_DEV is not being set when I put > 'CONFIG_V4L2_MEM2MEM_DEV=y' Can you try the latest 3.13-rc7? I just tried i

Re: imx27.dtsi usbotg/usbh2 oops in fsl_usb2_mph_dr_of_probe

2013-10-28 Thread Fabio Estevam
On Mon, Oct 28, 2013 at 10:42 AM, Chris Ruehl wrote: > I didn't get USB detected with > > compatible ="fsl,imx27-usb" > > nothing happen. You probably need a mx27 entry into drivers/usb/chipidea/usbmisc_imx.c. Again, this is offtopic to this list, so please start a new thread at linux-usb, -- T

Re: imx27.dtsi usbotg/usbh2 oops in fsl_usb2_mph_dr_of_probe

2013-10-28 Thread Fabio Estevam
On Mon, Oct 28, 2013 at 10:17 AM, Chris Ruehl wrote: > Hi, > > when tried to activate the USB-OTG or USBH2 with the FDT the system oops You should have posted this to the linux-usb list instead :-) > config: (imx27.dtsi) > > usbotg: usb@10024000 { > compatible = "fsl

[PATCH] [media] platform: Kconfig: Select SRAM for VIDEO_CODA

2013-09-30 Thread Fabio Estevam
Running the coda driver without CONFIG_SRAM selected leads to the following probe error: coda 63ff4000.vpu: iram pool not available coda: probe of 63ff4000.vpu failed with error -12 In order to avoid it, select CONFIG_SRAM inside VIDEO_CODA. Signed-off-by: Fabio Estevam --- drivers/media

Re: [PATCH v2 1/4] [media] lirc_bt829: Fix physical address type

2013-09-04 Thread Fabio Estevam
= 0; > if (my_dev->resource[0].flags & IORESOURCE_MEM) { > pci_addr_phys = my_dev->resource[0].start; > - pr_info("memory at 0x%08X\n", > - (unsigned int)pci_addr_phys); > +

Re: [PATCH 2/4] [media] lirc_bt829: Fix physical address type

2013-09-01 Thread Fabio Estevam
On Sun, Sep 1, 2013 at 10:41 PM, Ben Hutchings wrote: > On Sun, 2013-09-01 at 22:37 -0300, Fabio Estevam wrote: >> On Sun, Sep 1, 2013 at 9:39 PM, Ben Hutchings wrote: >> >> > pci_addr_phys = pdev->resource[0].start; >> > - dev_

Re: [PATCH 2/4] [media] lirc_bt829: Fix physical address type

2013-09-01 Thread Fabio Estevam
On Sun, Sep 1, 2013 at 9:39 PM, Ben Hutchings wrote: > pci_addr_phys = pdev->resource[0].start; > - dev_info(&pdev->dev, "memory at 0x%08X\n", > -(unsigned int)pci_addr_phys); > + dev_info(&pdev->dev, "memory at 0x%08llX\n", > +(unsigned long lo

[PATCH v7 1/3] [media] coda: Fix error paths

2013-08-21 Thread Fabio Estevam
From: Fabio Estevam Some resources were not being released in the error path and some were released in the incorrect order. Signed-off-by: Fabio Estevam --- Changes since v6: - Rebased against correct branch drivers/media/platform/coda.c | 43 +-- 1

[PATCH v7 2/3] [media] coda: Check the return value from clk_prepare_enable()

2013-08-21 Thread Fabio Estevam
From: Fabio Estevam clk_prepare_enable() may fail, so let's check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam --- Changes since v6: - Rebased against correct branch drivers/media/platform/coda.c | 27 ++- 1 file change

[PATCH v7 3/3] [media] coda: No need to check the return value of platform_get_resource()

2013-08-21 Thread Fabio Estevam
From: Fabio Estevam When using devm_ioremap_resource(), we do not need to check the return value of platform_get_resource(), so just remove it. Signed-off-by: Fabio Estevam Acked-by: Philipp Zabel --- Changes since v6: - Rebased against correct branch drivers/media/platform/coda.c | 5

[PATCH v6 2/3] [media] coda: Check the return value from clk_prepare_enable()

2013-08-20 Thread Fabio Estevam
clk_prepare_enable() may fail, so let's check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam --- Changes since v5: - Rebased against latest Kamil's tree drivers/media/platform/coda.c | 27 ++- 1 file changed, 22 insert

[PATCH v6 3/3] [media] coda: No need to check the return value of platform_get_resource()

2013-08-20 Thread Fabio Estevam
When using devm_ioremap_resource(), we do not need to check the return value of platform_get_resource(), so just remove it. Signed-off-by: Fabio Estevam Acked-by: Philipp Zabel --- Changes since v5: - Rebased against latest Kamil's tree drivers/media/platform/coda.c | 5 - 1 file ch

[PATCH v6 1/3] [media] coda: Fix error paths

2013-08-20 Thread Fabio Estevam
Some resources were not being released in the error path and some were released in the incorrect order. Signed-off-by: Fabio Estevam --- Changes since v5: - Rebased against latest Kamil's tree drivers/media/platform/coda.c | 43 +-- 1 file change

[PATCH v4 1/3] [media] coda: Fix error paths

2013-07-23 Thread Fabio Estevam
Some resources were not being released in the error path and some were released in the incorrect order. Signed-off-by: Fabio Estevam --- Changes since v3: - Only disable the clocks after v4l2_m2m_ctx_release() Changes since v2: - Newly introduced in this series drivers/media/platform/coda.c

[PATCH v4 2/3] [media] coda: Check the return value from clk_prepare_enable()

2013-07-23 Thread Fabio Estevam
clk_prepare_enable() may fail, so let's check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam --- Changes since v3: - Adapt it to make error handling easier Changes since v2: - Release the previously acquired resources Changes since v1: - Add missin

[PATCH v4 3/3] [media] coda: No need to check the return value of platform_get_resource()

2013-07-23 Thread Fabio Estevam
When using devm_ioremap_resource(), we do not need to check the return value of platform_get_resource(), so just remove it. Signed-off-by: Fabio Estevam Acked-by: Philipp Zabel --- Changes since v3: - None Changes since v2: - None Changes since v1: - None drivers/media/platform/coda.c | 5

[PATCH v3 2/3] [media] coda: Check the return value from clk_prepare_enable()

2013-07-22 Thread Fabio Estevam
From: Fabio Estevam clk_prepare_enable() may fail, so let's check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam --- - Changes since v2: - Release the previously acquired resources Changes since v1: - Add missing 'if' drivers/media/platf

[PATCH v3 3/3] [media] coda: No need to check the return value of platform_get_resource()

2013-07-22 Thread Fabio Estevam
From: Fabio Estevam When using devm_ioremap_resource(), we do not need to check the return value of platform_get_resource(), so just remove it. Signed-off-by: Fabio Estevam Acked-by: Philipp Zabel --- Changes since v2: - None Changes since v1: - None drivers/media/platform/coda.c | 5

[PATCH v3 1/3] [media] coda: Fix error paths

2013-07-22 Thread Fabio Estevam
From: Fabio Estevam Some resources were not being released in the error path and some were released in the incorrect order. Signed-off-by: Fabio Estevam --- Changes since v2: - Newly introduced in this series drivers/media/platform/coda.c | 32 1 file changed

[PATCH 2/2] [media] coda: No need to check the return value of platform_get_resource()

2013-07-20 Thread Fabio Estevam
From: Fabio Estevam When using devm_ioremap_resource(), we do not need to check the return value of platform_get_resource(), so just remove it. Signed-off-by: Fabio Estevam --- Changes since v1: - None drivers/media/platform/coda.c | 5 - 1 file changed, 5 deletions(-) diff --git a

[PATCH v2 1/2] [media] coda: Check the return value from clk_prepare_enable()

2013-07-20 Thread Fabio Estevam
From: Fabio Estevam clk_prepare_enable() may fail, so let's check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam --- Changes since v1: - Add missing 'if' drivers/media/platform/coda.c | 11 +-- 1 file changed, 9 insertions(

[PATCH 1/2] [media] coda: Check the return value from clk_prepare_enable()

2013-07-20 Thread Fabio Estevam
From: Fabio Estevam clk_prepare_enable() may fail, so let's check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam --- drivers/media/platform/coda.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/c

[PATCH 2/2] [media] coda: No need to check the return value of platform_get_resource()

2013-07-20 Thread Fabio Estevam
From: Fabio Estevam When using devm_ioremap_resource(), we do not need to check the return value of platform_get_resource(), so just remove it. Signed-off-by: Fabio Estevam --- drivers/media/platform/coda.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/media/platform/coda.c

Re: imx27 coda interface no capture output

2013-06-21 Thread Fabio Estevam
Hi Chris, On Fri, Jun 21, 2013 at 4:38 AM, Chris Ruehl wrote: > Hi All, > > After Freescale was so kind and forward the v4l-codadx6-imx27.bin > the firmware loaded properly and I see a /dev/video1 the v4l_ctrl looks > promising > > root@gtsir-nand:~# v4l2-ctl --list-formats -d /dev/video1 > ioctl

Re: [PATCH] mt9p031: Use bulk regulator API

2013-06-08 Thread Fabio Estevam
On Sat, Jun 8, 2013 at 10:20 AM, Fabio Estevam wrote: > On Sat, Jun 8, 2013 at 4:55 AM, Laurent Pinchart > wrote: > >> - if (IS_ERR(mt9p031->vaa) || IS_ERR(mt9p031->vdd) || >> - IS_ERR(mt9p031->vdd_io)) { >> + ret = devm_regulat

Re: [PATCH] mt9p031: Use bulk regulator API

2013-06-08 Thread Fabio Estevam
On Sat, Jun 8, 2013 at 4:55 AM, Laurent Pinchart wrote: > - if (IS_ERR(mt9p031->vaa) || IS_ERR(mt9p031->vdd) || > - IS_ERR(mt9p031->vdd_io)) { > + ret = devm_regulator_bulk_get(&client->dev, 3, mt9p031->regulators); > + if (ret < 0) { > dev_err(&client-

Re: [PATCH] media: coda: Fix compile breakage

2013-04-27 Thread Fabio Estevam
Alexander/Arnd, On Sat, Apr 27, 2013 at 12:33 PM, Arnd Bergmann wrote: > On Saturday 27 April 2013, Alexander Shiyan wrote: >> Patch adds GENERIC_ALLOCATOR, if "coda" is selected. >> >> drivers/built-in.o: In function `coda_remove': >> :(.text+0x110634): undefined reference to `gen_pool_free' >>

Re: [PATCH 2/2] dvb_frontend: Simplify the emulation logic

2013-03-18 Thread Fabio Estevam
ntent > + * parameters are compatible with DVB-S spec. > + */ > +static int emulate_delivery_system(struct dvb_frontend *fe, u32 delsys) Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [media] coda: Fix build due to iram.h rename

2013-01-07 Thread Fabio Estevam
ve it to > include/linux/platform_data/imx-iram.h instead. This is an intermediate > solution > until the i.MX iram allocator is converted to the generic SRAM allocator. > > Signed-off-by: Sascha Hauer > --- > > Based on an earlier version from Fabio Estevam, but this one m

Re: [PATCH 1/4] media: mx2_camera: Remove i.mx25 support.

2013-01-02 Thread Fabio Estevam
d not be able to further debug this driver. Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] media: mx2_camera: Remove i.mx25 support.

2013-01-02 Thread Fabio Estevam
.html ,and have only verified that camera probe worked on mx25pdk. Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RFC 07/11] it913x: make remote controller optional

2013-01-01 Thread Fabio Estevam
913x.c > @@ -308,6 +308,7 @@ static struct i2c_algorithm it913x_i2c_algo = { > }; > > /* Callbacks for DVB USB */ > +#if defined(CONFIG_RC_CORE) || defined(CONFIG_RC_CORE_MODULE) Maybe you could use: #if IS_ENABLED(CONFIG_RC_CORE) Regards, Fabio Estevam -- To unsubscribe from this lis

Re: [PATCH] [media] mx2_camera: Convert it to platform driver

2012-12-17 Thread Fabio Estevam
Hi Guennadi, On Fri, Nov 30, 2012 at 1:06 PM, Fabio Estevam wrote: > Converting it to platform code can make the code smaller. > > Signed-off-by: Fabio Estevam Does this patch look good? Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH] [media] coda: Fix build due to iram.h rename

2012-12-03 Thread Fabio Estevam
Hi Mauro, On Wed, Nov 14, 2012 at 11:04 AM, Fabio Estevam wrote: > commit c045e3f13 (ARM: imx: include iram.h rather than mach/iram.h) changed > the > location of iram.h, which causes the following build error when building the > coda > driver: > > drivers/media/platfor

[PATCH] [media] mx2_camera: Convert it to platform driver

2012-11-30 Thread Fabio Estevam
Converting it to platform code can make the code smaller. Signed-off-by: Fabio Estevam --- drivers/media/platform/soc_camera/mx2_camera.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/media/platform/soc_camera/mx2_camera.c b/drivers/media

Re: [PATCH 1/4] media: mx2_camera: Remove i.mx25 support.

2012-11-27 Thread Fabio Estevam
driver detached from camera 0 mx2-camera imx25-camera.0: MX2 Camera (CSI) driver probed, clock frequency: 2216 Could we please keep the mx25 support? Thanks, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@v

[PATCH] [media] soc_camera: mx3_camera: Constify v4l2_crop

2012-11-17 Thread Fabio Estevam
tion from incompatible pointer type Signed-off-by: Fabio Estevam --- drivers/media/platform/soc_camera/mx3_camera.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/soc_camera/mx3_camera.c b/drivers/media/platform/soc_camera/mx3_camera.c index 64d39b

[PATCH] [media] soc_camera: mx2_camera: Constify v4l2_crop

2012-11-17 Thread Fabio Estevam
From: Fabio Estevam Since commit 4f996594ce ([media] v4l2: make vidioc_s_crop const), set_crop should receive a 'const struct v4l2_crop *' argument type. Adapt to this new format and get rid of the following build warning: drivers/media/platform/soc_camera/mx2_camera.c:152

Re: [PATCH v4 2/2] mx2_camera: Fix regression caused by clock conversion

2012-11-14 Thread Fabio Estevam
your tree? Thanks, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] [media] coda: Fix build due to iram.h rename

2012-11-14 Thread Fabio Estevam
ers/media/platform/coda.c:2024: error: implicit declaration of function 'iram_free Since the content of iram.h is not imx specific, move it to include/linux/iram.h instead. Signed-off-by: Fabio Estevam --- arch/arm/mach-imx/iram_alloc.c |3 +-- drivers/media/platform/coda.c

Re: [PATCH v4 1/2] ARM: clk-imx27: Add missing clock for mx2-camera

2012-10-31 Thread Fabio Estevam
ing platform_device_id), which changes from mx2_camera.0 to imx27-camera.0. So it seems to be better to merge this via arm tree to avoid such conflict. Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to m

Re: [PATCH 1/4] media: mx2_camera: Remove i.mx25 support.

2012-10-30 Thread Fabio Estevam
Javier, On Tue, Oct 30, 2012 at 10:16 AM, Javier Martin wrote: > i.MX25 support has been broken for several releases > now and nobody seems to care about it. I will work on fixing camera support for mx25. Please do not remove its support. Thanks, Fabio Estevam -- To unsubscribe from thi

[PATCH v4 1/2] ARM: clk-imx27: Add missing clock for mx2-camera

2012-10-30 Thread Fabio Estevam
ver Signed-off-by: Fabio Estevam Acked-by: Sascha Hauer --- Changes since v3: - Use imx27-camera.0 instead of mx2-camera.0, due to recent changes in the imx27 clock (commit 27b76486a3: media: mx2_camera: remove cpu_is_xxx by using platform_device_id) arch/arm/mach-imx/clk-imx27.c |1 +

[PATCH v4 2/2] mx2_camera: Fix regression caused by clock conversion

2012-10-30 Thread Fabio Estevam
again. Tested-by: Gaëtan Carlier Tested-by: Javier Martin Signed-off-by: Fabio Estevam --- Changes since v3: - Drop unneeded clk_unprepare calls as pointed out by Guennadi Changes since v2: - Fix clock error handling code as pointed out by Russell King Changes since v1: - Rebased against linux

Re: [PATCH 1/2] ARM: clk-imx27: Add missing clock for mx2-camera

2012-10-25 Thread Fabio Estevam
s change, the better, IMHO, is > to send both via the same tree. If you decide to do so, please get arm > maintainer's ack, instead, and we can merge both via my tree. Can you please send your Ack to this series so that Mauro can merge it via his tree? Thanks, Fabio Estevam -- To unsubscr

[PATCH] [media] ivtv: ivtv-driver: Replace 'flush_work_sync()'

2012-10-24 Thread Fabio Estevam
From: Fabio Estevam Since commit 43829731d (workqueue: deprecate flush[_delayed]_work_sync()), flush_work() should be used instead of flush_work_sync(). Signed-off-by: Fabio Estevam --- drivers/media/pci/ivtv/ivtv-driver.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [PATCH v3 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-22 Thread Fabio Estevam
i.MX25? But you're saying it's for > i.MX27. Confused... I provide this mx27 clock in the first patch of the series: http://patchwork.linuxtv.org/patch/14915/ Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a me

[PATCH] [media] coda: Fix 'driver_data' for mx53

2012-10-09 Thread Fabio Estevam
From: Fabio Estevam CODA_7541 is the coda_product type for mx53. The 'driver_data' for mx53 is CODA_IMX53 instead. Signed-off-by: Fabio Estevam --- drivers/media/platform/coda.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/coda.c

[PATCH] [media] coda: Do not use __cancel_delayed_work()

2012-10-09 Thread Fabio Estevam
From: Fabio Estevam commit 136b5721d (workqueue: deprecate __cancel_delayed_work()) made __cancel_delayed_work deprecated. Use cancel_delayed_work instead and get rid of the following warning: drivers/media/platform/coda.c:1543: warning: '__cancel_delayed_work' is deprecated (d

[PATCH v3 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-09 Thread Fabio Estevam
again. Tested-by: Gaëtan Carlier Tested-by: Javier Martin Signed-off-by: Fabio Estevam --- Changes since v2: - Fix clock error handling code as pointed out by Russell King Changes since v1: - Rebased against linux-next 20121008. drivers/media/platform/soc_camera/mx2_camera.c | 50

Re: [PATCH v2 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-09 Thread Fabio Estevam
t? It seems that you are camera works by pure luck without this patch. Maybe you are turning per4 in the bootloader or you get the clock to your camera from somewhere else. Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v2 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-08 Thread Fabio Estevam
From: Fabio Estevam Since mx27 transitioned to the commmon clock framework in 3.5, the correct way to acquire the csi clock is to get csi_ahb and csi_per clocks separately. By not doing so the camera sensor does not probe correctly: soc-camera-pdrv soc-camera-pdrv.0: Probing soc-camera-pdrv.0

Re: [PATCH 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-08 Thread Fabio Estevam
l2Src:v4l2src0: Failed to get attributes for norm 0 on devide '/dev/video0'. (61 - No data available) Setting pipeline to NULL ... Freeing pipeline ... Does anyone have any ideas? Thanks, Fabio Estevam --- drivers/media/platform/soc_camera/mx2_camera.c | 47 +--

[PATCH 2/2] [media]: mx2_camera: Fix regression caused by clock conversion

2012-10-05 Thread Fabio Estevam
again. Signed-off-by: Fabio Estevam --- drivers/media/platform/soc_camera/mx2_camera.c | 42 1 file changed, 29 insertions(+), 13 deletions(-) diff --git a/drivers/media/platform/soc_camera/mx2_camera.c b/drivers/media/platform/soc_camera/mx2_camera.c index 0c0dd74

[PATCH 1/2] ARM: clk-imx27: Add missing clock for mx2-camera

2012-10-05 Thread Fabio Estevam
er. Signed-off-by: Fabio Estevam --- arch/arm/mach-imx/clk-imx27.c |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-imx/clk-imx27.c b/arch/arm/mach-imx/clk-imx27.c index 3b6b640..5ef0f08 100644 --- a/arch/arm/mach-imx/clk-imx27.c +++ b/arch/arm/mach-imx/clk-imx27.c @@ -2

Re: Camera not detected on linux-next

2012-09-05 Thread Fabio Estevam
Hi Sylwester, On Wed, Sep 5, 2012 at 1:17 PM, Sylwester Nawrocki wrote: > Maybe this is about the sensor/host driver linking order. > If so, then this patch should help Excellent! This fixed the problem! Thanks, Fabio Estevam -- To unsubscribe from this list: send the line "unsubs

Camera not detected on linux-next

2012-09-05 Thread Fabio Estevam
w if there is anything obvious I am missing. Also tested on a mx27pdk and ov2640 could not be probed there as well. Thanks, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More maj

Re: [RFC] Support for 'Coda' video codec IP.

2012-07-03 Thread Fabio Estevam
On Mon, Jul 2, 2012 at 10:48 AM, javier Martin wrote: > However, it would be great if Fabio could confirm that codadx6 in the > i.MX27 supports MJPG too. As far as I recall it does not. I will check it and if I heard differently I will reply back here. Regards, Fabio Estevam -- To unsub

Re: [RFC] Support for 'Coda' video codec IP.

2012-06-19 Thread Fabio Estevam
ork. > > A public git repository is available too: > git://github.com/jmartinc/video_visstrim.git I will give it a try and I have some questions: - How did you generate the VPU firmware? - Which userspace application did you use for testing the encoding? Is Gstreamer OK to test it? Th

Re: [PATCH] Revert "[media] media: mx2_camera: Fix mbus format handling"

2012-06-18 Thread Fabio Estevam
ror: (Each undeclared identifier is > reported only once > drivers/media/video/mx2_camera.c:937: error: for each function it appears in.) Can this be applied? It is breaking mxs_defconfig for one month now. Thanks, Fabio Estevam -- To unsubscribe from this list: send the line "u

Re: [PATCH] media: mx2_camera: Add YUYV output format.

2012-06-07 Thread Fabio Estevam
rder to fix that problem? I will need to check this next week when I am back to the office. Thanks, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 06/15] video: mx1_camera: Use clk_prepare_enable/clk_disable_unprepare

2012-06-06 Thread Fabio Estevam
hat were not converted, so this patch series aim to address the clock conversion for the remaining imx drivers. I think this is 3.5 material. Sascha, would you agree? Thanks, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a mess

Re: [PATCH 06/15] video: mx1_camera: Use clk_prepare_enable/clk_disable_unprepare

2012-06-05 Thread Fabio Estevam
Guennadi, On Tue, May 29, 2012 at 6:20 AM, Sascha Hauer wrote: > On Fri, May 25, 2012 at 08:14:47PM -0300, Fabio Estevam wrote: >> From: Fabio Estevam >> >> Prepare the clock before enabling it. >> >> Cc: Guennadi Liakhovetski >> Cc: >> Signed-off-

Re: [PATCH] media: mx2_camera: Add YUYV output format.

2012-06-05 Thread Fabio Estevam
On Tue, Jun 5, 2012 at 11:14 AM, javier Martin wrote: > No, I'm still working on it in my spare time. Progress is rather slow. Ok, great. If you want to collaborate on this task, I will be glad to help. Let me know if you have a git tree with your work in progress. Saludos, Fabio

Re: [PATCH] [media] em28xx: Show a warning if the board does not support remote controls

2012-05-29 Thread Fabio Estevam
On Tue, May 29, 2012 at 6:26 PM, Martin Blumenstingl wrote: > Hello Fabio, > > I can use dev_err if you want. Or maybe dev_warn is better since this is a warning. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More m

Re: [PATCH] [media] em28xx: Show a warning if the board does not support remote controls

2012-05-29 Thread Fabio Estevam
On Tue, May 29, 2012 at 6:08 PM, Martin Blumenstingl wrote: > This simply shows a little warning if the board does not have remote > control support. This should make it easier for users to see if they > have misconfigured their system or if the driver simply does not have > rc-support for their c

[PATCH 08/15] video: mx2_emmaprp: Use clk_prepare_enable/clk_disable_unprepare

2012-05-25 Thread Fabio Estevam
From: Fabio Estevam Prepare the clock before enabling it. Cc: Guennadi Liakhovetski Cc: Signed-off-by: Fabio Estevam --- drivers/media/video/mx2_emmaprp.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/mx2_emmaprp.c b/drivers/media/video

[PATCH 06/15] video: mx1_camera: Use clk_prepare_enable/clk_disable_unprepare

2012-05-25 Thread Fabio Estevam
From: Fabio Estevam Prepare the clock before enabling it. Cc: Guennadi Liakhovetski Cc: Signed-off-by: Fabio Estevam --- drivers/media/video/mx1_camera.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/mx1_camera.c b/drivers/media/video

[PATCH 07/15] video: mx2_camera: Use clk_prepare_enable/clk_disable_unprepare

2012-05-25 Thread Fabio Estevam
From: Fabio Estevam Prepare the clock before enabling it. Cc: Guennadi Liakhovetski Cc: Signed-off-by: Fabio Estevam --- drivers/media/video/mx2_camera.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/media/video/mx2_camera.c b/drivers/media

<    1   2   3   4   >