Re: [PATCH 00/23] em28xx: add support fur USB bulk transfers

2012-10-28 Thread Frank Schäfer
Am 21.10.2012 19:52, schrieb Frank Schäfer: This patch series adds support for USB bulk transfers to the em28xx driver. Patch 1 is a bugfix for the image data processing with non-interlaced devices (webcams) that should be considered for stable (see commit message). Patches 2-21 extend

Re: [PATCH v2, RESEND] libv4lconvert: clarify the behavior and resulting restrictions of v4lconvert_convert()

2012-10-28 Thread Frank Schäfer
Am 21.10.2012 19:58, schrieb Frank Schäfer: Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- lib/include/libv4lconvert.h | 20 ++-- 1 Datei geändert, 18 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/lib/include/libv4lconvert.h b/lib/include

Re: [PATCH 00/23] em28xx: add support fur USB bulk transfers

2012-10-28 Thread Frank Schäfer
Am 28.10.2012 16:08, schrieb Mauro Carvalho Chehab: Em 28-10-2012 11:00, Frank Schäfer escreveu: Am 21.10.2012 19:52, schrieb Frank Schäfer: This patch series adds support for USB bulk transfers to the em28xx driver. Mauro, I sent this patches to you because you are listed as the maintainer

Re: [PATCH 00/23] em28xx: add support fur USB bulk transfers

2012-10-23 Thread Frank Schäfer
Hi, Am 21.10.2012 21:13, schrieb Devin Heitmueller: Hi Frank, On Sun, Oct 21, 2012 at 12:52 PM, Frank Schäfer fschaefer@googlemail.com wrote: This patch series adds support for USB bulk transfers to the em28xx driver. This is a welcome change that some users have been asking about

[PATCH 03/23] em28xx: rename isoc packet number constants and parameters

2012-10-21 Thread Frank Schäfer
. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c |2 +- drivers/media/usb/em28xx/em28xx-core.c |8 drivers/media/usb/em28xx/em28xx-dvb.c |5 +++-- drivers/media/usb/em28xx/em28xx-video.c |4 ++-- drivers/media/usb/em28xx

[PATCH 04/23] em28xx: rename struct em28xx_usb_isoc_bufs to em28xx_usb_bufs

2012-10-21 Thread Frank Schäfer
It will be used for USB bulk transfers, too. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-core.c |8 drivers/media/usb/em28xx/em28xx.h | 10 +- 2 Dateien geändert, 9 Zeilen hinzugefügt(+), 9 Zeilen entfernt(-) diff

[PATCH 05/23] em28xx: rename struct em28xx_usb_isoc_ctl to em28xx_usb_ctl

2012-10-21 Thread Frank Schäfer
Also rename the corresponding field isoc_ctl in struct em28xx to usb_ctl. We will use this struct for USB bulk transfers, too. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-core.c | 24 drivers/media/usb/em28xx/em28xx

[PATCH 06/23] em28xx: remove obsolete #define EM28XX_URB_TIMEOUT

2012-10-21 Thread Frank Schäfer
It isn't used anymore and uses constants which no longer exist. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx.h |4 1 Datei geändert, 4 Zeilen entfernt(-) diff --git a/drivers/media/usb/em28xx/em28xx.h b/drivers/media/usb/em28xx/em28xx.h

[PATCH 07/23] em28xx: update description of em28xx_irq_callback

2012-10-21 Thread Frank Schäfer
em28xx_irq_callback can be used for isoc and bulk transfers. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-core.c |3 ++- 1 Datei geändert, 2 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/drivers/media/usb/em28xx/em28xx-core.c b

[PATCH 08/23] em28xx: rename function em28xx_uninit_isoc to em28xx_uninit_usb_xfer

2012-10-21 Thread Frank Schäfer
This function will be used to uninitialize USB bulk transfers, too. Also rename the local variable isoc_bufs to usb_bufs. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c |4 +-- drivers/media/usb/em28xx/em28xx-core.c | 43

[PATCH 09/23] em28xx: create a common function for isoc and bulk URB allocation and setup

2012-10-21 Thread Frank Schäfer
Rename the existing function for isoc transfers em28xx_init_isoc to em28xx_init_usb_xfer and extend it. URB allocation and setup is now done depending on the USB transfer type, which is selected with a new function parameter. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers

[PATCH 10/23] em28xx: create a common function for isoc and bulk USB transfer initialization

2012-10-21 Thread Frank Schäfer
- rename em28xx_init_isoc to em28xx_init_usb_xfer - add parameter for isoc/bulk transfer selection which is passed to em28xx_alloc_urbs - rename local variable isoc_buf to usb_bufs Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-core.c | 30

[PATCH 10/23] em28xx: create a common function for isoc and bulk USB transfer initialization

2012-10-21 Thread Frank Schäfer
- rename em28xx_init_isoc to em28xx_init_usb_xfer - add parameter for isoc/bulk transfer selection which is passed to em28xx_alloc_urbs - rename local variable isoc_buf to usb_bufs Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-core.c | 30

[PATCH 12/23] em28xx: remove double checks for urb-status == -ENOENT in urb_data_copy functions

2012-10-21 Thread Frank Schäfer
This check is already done in the URB handler em28xx_irq_callback before calling these functions. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-dvb.c |5 + drivers/media/usb/em28xx/em28xx-video.c | 10 ++ 2 Dateien geändert, 3

[PATCH 13/23] em28xx: rename function em28xx_isoc_copy and extend for USB bulk transfers

2012-10-21 Thread Frank Schäfer
The URB data processing for bulk transfers is very similar to what is done with isoc transfers, so create a common function that works with both transfer types based on the existing isoc function. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx

[PATCH 15/23] em28xx: rename function em28xx_dvb_isoc_copy and extend for USB bulk transfers

2012-10-21 Thread Frank Schäfer
-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-dvb.c | 44 +++-- 1 Datei geändert, 31 Zeilen hinzugefügt(+), 13 Zeilen entfernt(-) diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c b/drivers/media/usb/em28xx/em28xx-dvb.c index

[PATCH 17/23] em28xx: rename some USB parameter fields in struct em28xx to clarify their role

2012-10-21 Thread Frank Schäfer
Also improve the comments. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c | 20 +++- drivers/media/usb/em28xx/em28xx-core.c |8 drivers/media/usb/em28xx/em28xx-dvb.c |4 ++-- drivers/media/usb/em28xx

[PATCH 18/23] em28xx: add fields for analog and DVB USB transfer type selection to struct em28xx

2012-10-21 Thread Frank Schäfer
Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx.h |4 1 Datei geändert, 4 Zeilen hinzugefügt(+) diff --git a/drivers/media/usb/em28xx/em28xx.h b/drivers/media/usb/em28xx/em28xx.h index 8b96413..f013650 100644 --- a/drivers/media/usb/em28xx

[PATCH 11/23] em28xx: clear USB halt/stall condition in em28xx_init_usb_xfer when using bulk transfers

2012-10-21 Thread Frank Schäfer
Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-core.c | 11 +++ 1 Datei geändert, 11 Zeilen hinzugefügt(+) diff --git a/drivers/media/usb/em28xx/em28xx-core.c b/drivers/media/usb/em28xx/em28xx-core.c index d8a8e8b..8b8f783 100644

[PATCH 19/23] em28xx: set USB alternate settings for analog video bulk transfers properly

2012-10-21 Thread Frank Schäfer
Extend function em28xx_set_alternate: - use alternate setting 0 for bulk transfers as default - respect module parameter 'alt'=0 for bulk transfers - set max_packet_size to 512 bytes for bulk transfers Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx

[PATCH 20/23] em28xx: improve USB endpoint logic, also use bulk transfers

2012-10-21 Thread Frank Schäfer
0x84, bulk = analog or digital** (*: audio should always be isoc) (**: analog, if ep 0x82 is isoc, otherwise digital) Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c | 97 +-- drivers/media/usb/em28xx

[PATCH 22/23] em28xx: use common urb data copying function for vbi and non-vbi devices

2012-10-21 Thread Frank Schäfer
em28xx_urb_data_copy_vbi is actually an extended version of em28xx_urb_data_copy. With some minor fixes applied, it can be used for non-vbi-devices, too, without any performance impacts. Tested with a non-VBI device only. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers

[PATCH 23/23] em28xx: enable VBI-support for em2840 devices

2012-10-21 Thread Frank Schäfer
I just noticed that the eMPIA hardware specification from 02/01/2004 says that the em2840 supports VBI, too. I don't have this device, so this patch is compilation tested only ! Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-core.c |3 ++- 1

[PATCH 21/23] em28xx: add module parameter for selection of the preferred USB transfer type

2012-10-21 Thread Frank Schäfer
By default, isoc transfers are used if possible. With the new module parameter, bulk can be selected as the preferred USB transfer type. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c |9 +++-- 1 Datei geändert, 7 Zeilen hinzugefügt

[PATCH 16/23] em28xx: rename usb debugging module parameter and macro

2012-10-21 Thread Frank Schäfer
Rename module parameter isoc_debug to usb_debug and macro em28xx_isocdbg to em28xx_usb dbg to reflect that they are used for isoc and bulk USB transfers. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-video.c | 58

[PATCH v2, RESEND] libv4lconvert: clarify the behavior and resulting restrictions of v4lconvert_convert()

2012-10-21 Thread Frank Schäfer
Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- lib/include/libv4lconvert.h | 20 ++-- 1 Datei geändert, 18 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/lib/include/libv4lconvert.h b/lib/include/libv4lconvert.h index 167b57d..509655e 100644 --- a/lib

Re: [PATCH] qv4l2: avoid empty titles for the video control tabs

2012-10-10 Thread Frank Schäfer
Am 09.10.2012 17:24, schrieb Hans Verkuil: On Tue October 9 2012 16:46:04 Frank Schäfer wrote: The video control class names are used as titles for the GUI-tabs. The current code relies on the driver enumerating the control classes properly when using V4L2_CTRL_FLAG_NEXT_CTRL. But the UVC

[PATCH] qv4l2: avoid empty titles for the video control tabs

2012-10-09 Thread Frank Schäfer
sure we always have a control class title: If the driver didn't enumrate a class along with the controls, call VIDIOC_QUERYCTRL for the class explicitly. If that fails, fall back to an internal string list. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- utils/qv4l2/ctrl-tab.cpp

Re: How to add support for the em2765 webcam Speedlink VAD Laplace to the kernel ?

2012-10-08 Thread Frank Schäfer
Am 07.10.2012 18:08, schrieb Mauro Carvalho Chehab: snip Ist that correct ? Mauro, could you please elaborate your plan ? What exactly do you want me to do to get this device supported by the kernel ? Basically, the core em28xx module will have: drivers/media/usb/em28xx/em28xx-cards.c

Re: How to add support for the em2765 webcam Speedlink VAD Laplace to the kernel ?

2012-10-07 Thread Frank Schäfer
Am 06.10.2012 13:56, schrieb Mauro Carvalho Chehab: Em Sun, 23 Sep 2012 16:03:25 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: Ping ! Sorry, too busy those days. No problem. Am 26.08.2012 20:53, schrieb Frank Schäfer: Sorry for the delayed reply, I got distracted by something

Re: How to add support for the em2765 webcam Speedlink VAD Laplace to the kernel ?

2012-10-07 Thread Frank Schäfer
Am 07.10.2012 04:56, schrieb Devin Heitmueller: On Sat, Oct 6, 2012 at 7:56 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: AFAIKT, newer em28xx chips are using this concept. The em28xx-i2c code require changes to support two I2C buses, and to handle 16 bit eeproms. We never cared of

Re: [PATCH] libv4lconvert: clarify the behavior and resulting restrictions of v4lconvert_convert()

2012-10-07 Thread Frank Schäfer
. ;) I didn't have much time yet to work on further libv4lconvert patches, too. Regards, Frank Regards, Hans On 10/03/2012 06:48 PM, Frank Schäfer wrote: Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- lib/include/libv4lconvert.h | 20 ++-- 1 Datei geändert

Re: qv4l2-bug / libv4lconvert API issue

2012-10-03 Thread Frank Schäfer
Hi Hans, Am 30.09.2012 11:54, schrieb Hans de Goede: Hi, On 09/28/2012 07:09 PM, Frank Schäfer wrote: Hi, Am 27.09.2012 21:41, schrieb Hans de Goede: Hi, On 09/27/2012 03:20 PM, Frank Schäfer wrote: snip What you've found is a qv4l2 bug (do you have the latest version?) Of course

Re: qv4l2-bug / libv4lconvert API issue

2012-10-03 Thread Frank Schäfer
Am 03.10.2012 15:32, schrieb Hans Verkuil: On Wed 3 October 2012 12:22:48 Frank Schäfer wrote: Hi Hans, Am 30.09.2012 11:54, schrieb Hans de Goede: Hi, On 09/28/2012 07:09 PM, Frank Schäfer wrote: Hi, Am 27.09.2012 21:41, schrieb Hans de Goede: Hi, On 09/27/2012 03:20 PM, Frank

[PATCH] libv4lconvert: clarify the behavior and resulting restrictions of v4lconvert_convert()

2012-10-03 Thread Frank Schäfer
Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- lib/include/libv4lconvert.h | 20 ++-- 1 Datei geändert, 18 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/lib/include/libv4lconvert.h b/lib/include/libv4lconvert.h index 167b57d..509655e 100644 --- a/lib

Re: qv4l2-bug / libv4lconvert API issue

2012-09-28 Thread Frank Schäfer
Hi, Am 27.09.2012 21:41, schrieb Hans de Goede: Hi, On 09/27/2012 03:20 PM, Frank Schäfer wrote: snip What you've found is a qv4l2 bug (do you have the latest version?) Of course, I'm using the latest developer version. Even if this is just a qv4l2-bug: how do you want to fix

Re: qv4l2-bug / libv4lconvert API issue

2012-09-27 Thread Frank Schäfer
Hi, Am 27.09.2012 12:26, schrieb Hans de Goede: Hi, On 09/26/2012 11:04 PM, Frank Schäfer wrote: Hi, I've noticed the following issues/bugs while playing with qv4l: 1.) with pac7302-webcams, only the RGB3 (RGB24) format is working. BGR3, YU12 and YV12 are broken 2.) for upside-down

Re: qv4l2-bug / libv4lconvert API issue

2012-09-27 Thread Frank Schäfer
Am 27.09.2012 15:20, schrieb Frank Schäfer: Hi, Am 27.09.2012 12:26, schrieb Hans de Goede: Hi, On 09/26/2012 11:04 PM, Frank Schäfer wrote: Hi, I've noticed the following issues/bugs while playing with qv4l: 1.) with pac7302-webcams, only the RGB3 (RGB24) format is working. BGR3, YU12

Re: qv4l2-bug / libv4lconvert API issue

2012-09-27 Thread Frank Schäfer
Am 27.09.2012 16:47, schrieb Hans Verkuil: On Thu 27 September 2012 15:20:21 Frank Schäfer wrote: Hi, Am 27.09.2012 12:26, schrieb Hans de Goede: Hi, On 09/26/2012 11:04 PM, Frank Schäfer wrote: Hi, I've noticed the following issues/bugs while playing with qv4l: 1.) with pac7302-webcams

qv4l2-bug / libv4lconvert API issue

2012-09-26 Thread Frank Schäfer
Hi, I've noticed the following issues/bugs while playing with qv4l: 1.) with pac7302-webcams, only the RGB3 (RGB24) format is working. BGR3, YU12 and YV12 are broken 2.) for upside-down-mounted devices with an entry in libv4lconvert, automatic h/v-flipping doesn't work with some formats I've

[PATCH 1/3] ov2640: select sensor register bank before applying h/v-flip settings

2012-09-23 Thread Frank Schäfer
We currently don't select the register bank in ov2640_s_ctrl, so we can end up writing to DSP register 0x04 instead of sensor register 0x04. This happens for example when calling ov2640_s_ctrl after ov2640_s_fmt. Signed-off-by: Frank Schäfer fschaefer@googlemail.com Cc: sta...@kernel.org

[PATCH 2/3] ov2640: add support for V4L2_MBUS_FMT_YUYV8_2X8, V4L2_MBUS_FMT_RGB565_2X8_BE

2012-09-23 Thread Frank Schäfer
This is the result of experimenting with the SpeedLink VAD Laplace webcam. The register sequence for V4L2_MBUS_FMT_YUYV8_2X8 has been identified by analyzing USB-logs of this device running on MS Windows. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/i2c/soc_camera

[PATCH 3/3] ov2640: simplify single register writes

2012-09-23 Thread Frank Schäfer
Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/i2c/soc_camera/ov2640.c | 21 - 1 Datei geändert, 12 Zeilen hinzugefügt(+), 9 Zeilen entfernt(-) diff --git a/drivers/media/i2c/soc_camera/ov2640.c b/drivers/media/i2c/soc_camera/ov2640.c index

Re: [PATCH 4/4] gspca_pac7302: add support for green balance adjustment

2012-09-23 Thread Frank Schäfer
Hi, Am 20.09.2012 13:54, schrieb Frank Schäfer: Hi, Am 20.09.2012 11:08, schrieb Hans de Goede: Hi, Hans, it seems like you didn't pick up these patches up yet... Is there anything wrong with them ? I've somehow completely missed them. Can you resend the entire set please? No problem

[PATCH 1/4] gspca_pac7302: correct register documentation

2012-09-23 Thread Frank Schäfer
R,G,B balance registers are 0x01-0x03 instead of 0x02-0x04, which lead to the wrong conclusion that values are inverted. Exposure is controlled via page 3 registers and this is already documented. Also fix a whitespace issue. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers

[PATCH 2/4] gspca_pac7302: use registers 0x01 and 0x03 for red and blue balance controls

2012-09-23 Thread Frank Schäfer
Currently used registers 0xc5 and 0xc7 provide only a very coarse adjustment possibility within a very small value range (0-3). With registers 0x01 and 0x03, a fine grained adjustment with 255 steps is possible. This is also what the Windows driver does. Signed-off-by: Frank Schäfer fschaefer

Re: How to add support for the em2765 webcam Speedlink VAD Laplace to the kernel ?

2012-09-23 Thread Frank Schäfer
Ping ! Am 26.08.2012 20:53, schrieb Frank Schäfer: Sorry for the delayed reply, I got distracted by something with higher prority. Am 22.08.2012 20:15, schrieb Mauro Carvalho Chehab: Em 22-08-2012 04:53, Frank Schäfer escreveu: Am 21.08.2012 19:29, schrieb Mauro Carvalho Chehab: Hmm

Re: [PATCH 3/3] ov2640: simplify single register writes

2012-09-23 Thread Frank Schäfer
Am 23.09.2012 15:07, schrieb Frank Schäfer: Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/i2c/soc_camera/ov2640.c | 21 - 1 Datei geändert, 12 Zeilen hinzugefügt(+), 9 Zeilen entfernt(-) diff --git a/drivers/media/i2c/soc_camera/ov2640.c

[PATCH v2 1/3] ov2640: select sensor register bank before applying h/v-flip settings

2012-09-23 Thread Frank Schäfer
We currently don't select the register bank in ov2640_s_ctrl, so we can end up writing to DSP register 0x04 instead of sensor register 0x04. This happens for example when calling ov2640_s_ctrl after ov2640_s_fmt. Signed-off-by: Frank Schäfer fschaefer@googlemail.com Cc: sta...@kernel.org

[PATCH v2 2/3] ov2640: add support for V4L2_MBUS_FMT_YUYV8_2X8, V4L2_MBUS_FMT_RGB565_2X8_BE

2012-09-23 Thread Frank Schäfer
This is the result of experimenting with the SpeedLink VAD Laplace webcam. The register sequence for V4L2_MBUS_FMT_YUYV8_2X8 has been identified by analyzing USB-logs of this device running on MS Windows. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/i2c/soc_camera

[PATCH v2 3/3] ov2640: simplify single register writes

2012-09-23 Thread Frank Schäfer
Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/i2c/soc_camera/ov2640.c | 17 - 1 Datei geändert, 8 Zeilen hinzugefügt(+), 9 Zeilen entfernt(-) diff --git a/drivers/media/i2c/soc_camera/ov2640.c b/drivers/media/i2c/soc_camera/ov2640.c index 182d5a1

Re: [PATCH v2 1/3] ov2640: select sensor register bank before applying h/v-flip settings

2012-09-23 Thread Frank Schäfer
Am 23.09.2012 23:21, schrieb Guennadi Liakhovetski: Hi Frank On Sun, 23 Sep 2012, Frank Schäfer wrote: We currently don't select the register bank in ov2640_s_ctrl, so we can end up writing to DSP register 0x04 instead of sensor register 0x04. This happens for example when calling

Re: [PATCH v2 3/3] ov2640: simplify single register writes

2012-09-23 Thread Frank Schäfer
Am 23.09.2012 23:43, schrieb Guennadi Liakhovetski: On Sun, 23 Sep 2012, Frank Schäfer wrote: Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/i2c/soc_camera/ov2640.c | 17 - 1 Datei geändert, 8 Zeilen hinzugefügt(+), 9 Zeilen entfernt(-) diff

[PATCH] ov2640: select sensor register bank before applying h/v-flip settings

2012-09-23 Thread Frank Schäfer
We currently don't select the register bank in ov2640_s_ctrl, so we can end up writing to DSP register 0x04 instead of sensor register 0x04. This happens for example when calling ov2640_s_ctrl after ov2640_s_fmt. Signed-off-by: Frank Schäfer fschaefer@googlemail.com Cc: sta...@kernel.org

Re: [PATCH v2 3/3] ov2640: simplify single register writes

2012-09-23 Thread Frank Schäfer
Am 24.09.2012 00:23, schrieb Guennadi Liakhovetski: On Sun, 23 Sep 2012, Frank Schäfer wrote: Am 23.09.2012 23:43, schrieb Guennadi Liakhovetski: On Sun, 23 Sep 2012, Frank Schäfer wrote: Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/i2c/soc_camera/ov2640.c

Re: [PATCH] ov2640: select sensor register bank before applying h/v-flip settings

2012-09-23 Thread Frank Schäfer
Am 24.09.2012 00:33, schrieb Guennadi Liakhovetski: On Sun, 23 Sep 2012, Frank SchÀfer wrote: We currently don't select the register bank in ov2640_s_ctrl, so we can end up writing to DSP register 0x04 instead of sensor register 0x04. This happens for example when calling ov2640_s_ctrl

Re: [PATCH 4/4] gspca_pac7302: add support for green balance adjustment

2012-09-20 Thread Frank Schäfer
Hi, Am 20.09.2012 11:08, schrieb Hans de Goede: Hi, Hans, it seems like you didn't pick up these patches up yet... Is there anything wrong with them ? I've somehow completely missed them. Can you resend the entire set please? No problem, but I can't do that before weekend (I'm currently

Re: [PATCH 4/4] gspca_pac7302: add support for green balance adjustment

2012-09-19 Thread Frank Schäfer
Am 16.09.2012 18:00, schrieb Frank Schäfer: Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/gspca/pac7302.c | 23 ++- 1 files changed, 22 insertions(+), 1 deletions(-) diff --git a/drivers/media/usb/gspca/pac7302.c b/drivers/media/usb

Re: [PATCH 4/4] gspca_pac7302: add support for green balance adjustment

2012-09-19 Thread Frank Schäfer
Am 19.09.2012 22:34, schrieb Hans de Goede: Hi, On 09/19/2012 07:25 PM, Frank Schäfer wrote: Am 16.09.2012 18:00, schrieb Frank Schäfer: Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/gspca/pac7302.c | 23 ++- 1 files changed, 22

Re: pac7302-webcams and libv4lconvert interaction

2012-09-16 Thread Frank Schäfer
Hi, Am 13.09.2012 14:05, schrieb Hans de Goede: Hi, On 09/12/2012 04:36 PM, Frank Schäfer wrote: snip And a negative side effect is, that unknown pac7302 devices (with no V4LCONTROL_ROTATED_90_JPEG entry in libv4lconvert) do not work. With a consistent API behavior, they would work fine

[PATCH 2/4] gspca_pac7302: use registers 0x01 and 0x03 for red and blue balance controls

2012-09-16 Thread Frank Schäfer
Currently used registers 0xc5 and 0xc7 provide only a very coarse adjustment possibility within a very small value range (0-3). With registers 0x01 and 0x03, a fine grained adjustment with 255 steps is possible. This is also what the Windows driver does. Signed-off-by: Frank Schäfer fschaefer

[PATCH 3/4] v4l2-ctrl: add a control for green balance

2012-09-16 Thread Frank Schäfer
standard control. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- Documentation/DocBook/media/v4l/controls.xml |5 + drivers/media/v4l2-core/v4l2-ctrls.c |2 ++ include/linux/videodev2.h|4 +++- 3 files changed, 10 insertions(+), 1 deletions

[PATCH 4/4] gspca_pac7302: add support for green balance adjustment

2012-09-16 Thread Frank Schäfer
Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/gspca/pac7302.c | 23 ++- 1 files changed, 22 insertions(+), 1 deletions(-) diff --git a/drivers/media/usb/gspca/pac7302.c b/drivers/media/usb/gspca/pac7302.c index 8a0f4d6..9b62b74 100644

Re: pac7302-webcams and libv4lconvert interaction

2012-09-12 Thread Frank Schäfer
Am 11.09.2012 09:29, schrieb Hans de Goede: Hi, On 09/10/2012 10:24 PM, Frank Schäfer wrote: snip Ok, I understand what that means... libv4lconvert should be modifed to do the rotation regardless of what comes out of the kernel whenever V4LCONTROL_ROTATED flag is set. This way

Re: pac7302-webcams and libv4lconvert interaction

2012-09-10 Thread Frank Schäfer
Hi Hans, Am 09.09.2012 23:20, schrieb Hans de Goede: Hi, On 09/06/2012 05:13 PM, Frank Schäfer wrote: Hi, I'm currently looking into the gspca_pac7302-driver and how it interacts with libv4lconvert. This is how it currently works - driver announces v4l2_pix_format 640x480 (width x

Re: [PATCH 2/3] libv4lconvert: pac7302-devices: remove unneeded flag V4LCONTROL_WANTS_WB

2012-09-10 Thread Frank Schäfer
Am 09.09.2012 23:24, schrieb Hans de Goede: Hi, On 09/09/2012 08:36 PM, Frank Schäfer wrote: The gspca_pac7302 driver already provides this control. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- lib/libv4lconvert/control/libv4lcontrol.c | 12 1 files

Re: pac7302-webcams and libv4lconvert interaction

2012-09-10 Thread Frank Schäfer
Hi, Am 10.09.2012 20:31, schrieb Hans de Goede: Hi, On 09/10/2012 05:36 PM, Frank Schäfer wrote: Hi Hans, Am 09.09.2012 23:20, schrieb Hans de Goede: Hi, On 09/06/2012 05:13 PM, Frank Schäfer wrote: Hi, I'm currently looking into the gspca_pac7302-driver and how it interacts

Re: [PATCH 2/3] libv4lconvert: pac7302-devices: remove unneeded flag V4LCONTROL_WANTS_WB

2012-09-10 Thread Frank Schäfer
Am 10.09.2012 20:33, schrieb Hans de Goede: Hi, On 09/10/2012 05:41 PM, Frank Schäfer wrote: Am 09.09.2012 23:24, schrieb Hans de Goede: Hi, On 09/09/2012 08:36 PM, Frank Schäfer wrote: The gspca_pac7302 driver already provides this control. Signed-off-by: Frank Schäfer fschaefer

[PATCH 1/6] gspca_pac7302: add support for device 1ae7:2001 Speedlink Snappy Microphone SL-6825-SBK

2012-09-09 Thread Frank Schäfer
Signed-off-by: Frank Schäfer fschaefer@googlemail.com Cc: sta...@kernel.org --- drivers/media/usb/gspca/pac7302.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/usb/gspca/pac7302.c b/drivers/media/usb/gspca/pac7302.c index 4877f7a..e906f56 100644

[PATCH 2/6] gspca_pac7302: make red balance and blue balance controls work again

2012-09-09 Thread Frank Schäfer
Fix a regression from kernel 3.4 which has been introduced with the conversion of the gspca driver to the v4l2 control framework. Signed-off-by: Frank Schäfer fschaefer@googlemail.com Cc: sta...@kernel.org --- drivers/media/usb/gspca/pac7302.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 3/6] gspca_pac7302: add sharpness control

2012-09-09 Thread Frank Schäfer
The Windows driver uses page 0 register 0xb6 for sharpness adjustment. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/gspca/pac7302.c | 25 - 1 files changed, 24 insertions(+), 1 deletions(-) diff --git a/drivers/media/usb/gspca/pac7302

[PATCH 4/6] gspca_pac7302: increase default value for white balance temperature

2012-09-09 Thread Frank Schäfer
The current white balance temperature default value is 4, which is much too small (possible values are 0-255). Improve the picture quality by increasing the default value to 55, which is the default value used by the Windows driver. Signed-off-by: Frank Schäfer fschaefer@googlemail.com

[PATCH 5/6] gspca_pac7302: avoid duplicate calls of the image quality adjustment functions on capturing start

2012-09-09 Thread Frank Schäfer
There is no need to call the image quality adjustment functions in sd_start. The gspca main driver calls v4l2_ctrl_handler_setup in gspca_init_transfer, which already applies all image control values. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/gspca/pac7302.c

[PATCH 6/6] gspca_pac7302: extend register documentation

2012-09-09 Thread Frank Schäfer
Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/gspca/pac7302.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/media/usb/gspca/pac7302.c b/drivers/media/usb/gspca/pac7302.c index 71fa5a4..2d5c6d83 100644 --- a/drivers

[PATCH 1/3] libv4lconvert: fix format of the error messages concerning jpeg frame size mismatch

2012-09-09 Thread Frank Schäfer
Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- lib/libv4lconvert/jpeg.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/libv4lconvert/jpeg.c b/lib/libv4lconvert/jpeg.c index e088a90..aa9cace 100644 --- a/lib/libv4lconvert/jpeg.c +++ b/lib

[PATCH 2/3] libv4lconvert: pac7302-devices: remove unneeded flag V4LCONTROL_WANTS_WB

2012-09-09 Thread Frank Schäfer
The gspca_pac7302 driver already provides this control. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- lib/libv4lconvert/control/libv4lcontrol.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/lib/libv4lconvert/control/libv4lcontrol.c b/lib

[PATCH 3/3] libv4lconvert: update the list of pac7302 webcams

2012-09-09 Thread Frank Schäfer
All pac7302 webcams need image rotation, so synchronize the list with the driver. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- lib/libv4lconvert/control/libv4lcontrol.c | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/lib/libv4lconvert

pac7302-webcams and libv4lconvert interaction

2012-09-06 Thread Frank Schäfer
Hi, I'm currently looking into the gspca_pac7302-driver and how it interacts with libv4lconvert. This is how it currently works - driver announces v4l2_pix_format 640x480 (width x height) - the frames (jpeg) passed to userspace are encoded as 480x640 and this complies with the jpeg-header we

Re: gspca_pac7302 driver broken ?

2012-09-03 Thread Frank Schäfer
Am 02.09.2012 22:08, schrieb Ezequiel Garcia: Hi Frank, On Sun, Sep 2, 2012 at 2:15 PM, Frank Schäfer fschaefer@googlemail.com wrote: Hi, can anyone who owns such a device confirm that the gspca_pac7302 driver (kernel 3.6.0-rc1+) is fine ? It's working here with latest media-tree

gspca_pac7302 driver broken ?

2012-09-02 Thread Frank Schäfer
working. When I started capturing, the LED turned on for about a second and then off again. No frames are received. There were no error messages. I didn't have enough time for looking into this deeper today, but I think I could borrow this device again in a few days. Regards, Frank Schäfer

Re: How to add support for the em2765 webcam Speedlink VAD Laplace to the kernel ?

2012-08-26 Thread Frank Schäfer
Sorry for the delayed reply, I got distracted by something with higher prority. Am 22.08.2012 20:15, schrieb Mauro Carvalho Chehab: Em 22-08-2012 04:53, Frank Schäfer escreveu: Am 21.08.2012 19:29, schrieb Mauro Carvalho Chehab: Hmm... before reading the rest of this email... I found some

Re: How to add support for the em2765 webcam Speedlink VAD Laplace to the kernel ?

2012-08-22 Thread Frank Schäfer
. And according to the chip id, it's none of the devices we already know. I wouldn't hesitate to open my device to verify it, if the chance to damage the device wouldn't be that high... Em 21-08-2012 13:04, Frank Schäfer escreveu: Am 21.08.2012 14:32, schrieb Mauro Carvalho Chehab: Em 21-08-2012 08:35

Re: How to add support for the em2765 webcam Speedlink VAD Laplace to the kernel ?

2012-08-21 Thread Frank Schäfer
Am 20.08.2012 21:21, schrieb Mauro Carvalho Chehab: Em 20-08-2012 10:02, Hans de Goede escreveu: Hi, On 08/20/2012 01:41 PM, Frank Schäfer wrote: Hi, after a break of 2 1/2 kernel releases (sorry, I was busy with another project), I would like to bring up again the question how to add

Re: How to add support for the em2765 webcam Speedlink VAD Laplace to the kernel ?

2012-08-21 Thread Frank Schäfer
Am 21.08.2012 14:32, schrieb Mauro Carvalho Chehab: Em 21-08-2012 08:35, Frank Schäfer escreveu: Am 20.08.2012 21:21, schrieb Mauro Carvalho Chehab: Em 20-08-2012 10:02, Hans de Goede escreveu: Hi, On 08/20/2012 01:41 PM, Frank Schäfer wrote: Hi, after a break of 2 1/2 kernel releases

Re: How to add new chip ids to v4l2-chip-ident.h ?

2012-08-20 Thread Frank Schäfer
Am 18.08.2012 17:06, schrieb Hans Verkuil: On Sat August 18 2012 16:19:26 Frank Schäfer wrote: Hi, I would like to know how to add new chip ids to v4l2-chip-ident.h. Ist there a kind of policy for choosing numbers ? Using numbers that match the chip number is recommended, but if that can't

How to add support for the em2765 webcam Speedlink VAD Laplace to the kernel ?

2012-08-20 Thread Frank Schäfer
for testing. What do you think ? Regards, Frank Schäfer -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

How to add new chip ids to v4l2-chip-ident.h ?

2012-08-18 Thread Frank Schäfer
Hi, I would like to know how to add new chip ids to v4l2-chip-ident.h. Ist there a kind of policy for choosing numbers ? Which numbers would be approriate for the em25xx/em26xx/em27xx/em28xx chips ? Unfortunately 2700 is already used by V4L2_IDENT_VP27SMPX... Regards, Frank Schäfer

Re: [Regression 3.1-3.2, bisected] UVC-webcam: kernel panic when starting capturing

2012-07-16 Thread Frank Schäfer
Am 16.07.2012 01:24, schrieb Laurent Pinchart: Hi Frank, On Sunday 15 July 2012 21:39:47 Frank Schäfer wrote: Am 15.07.2012 14:07, schrieb Laurent Pinchart: On Thursday 12 July 2012 21:07:56 Frank Schäfer wrote: Hi, when I start capturing from the UVC-webcam 2232:1005 (WebCam SCB-0385N

Re: [Regression 3.1-3.2, bisected] UVC-webcam: kernel panic when starting capturing

2012-07-15 Thread Frank Schäfer
Am 15.07.2012 14:07, schrieb Laurent Pinchart: Hi Frank, Thanks for the report. On Thursday 12 July 2012 21:07:56 Frank Schäfer wrote: Hi, when I start capturing from the UVC-webcam 2232:1005 (WebCam SCB-0385N) of my netbook, I get a kernel panic. You can find a screenshot

[regression 3.4-3.5, bisected] kernel oops when starting capturing from gspca-sn9c20x webcams

2012-07-08 Thread Frank Schäfer
for sensors which don't have an implementation for them. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com Should I open a bug report at bugzilla, too ? Regards, Frank

Re: [regression 3.4-3.5, bisected] kernel oops when starting capturing from gspca-sn9c20x webcams

2012-07-08 Thread Frank Schäfer
Am 08.07.2012 19:43, schrieb Hans de Goede: Hi, Thanks for reporting this! On 07/08/2012 06:25 PM, Frank Schäfer wrote: Hi, running kernel 3.5.rc6 with the two gspca-sn9c20x webcams 0c45:62b3 Microdia PC Camera with Microphone (SN9C202 + OV9655) 0c45:6270 Microdia PC Camera (SN9C201

Re: [PATCH] [RFT/RFC] Add gspca subdriver for Speedlink VAD Laplace (EM2765+OV2640)

2012-03-21 Thread Frank Schäfer
Am 17.03.2012 14:11, schrieb Jean-Francois Moine: On Fri, 16 Mar 2012 23:15:45 +0100 Frank Schäfer fschaefer@googlemail.com wrote: Anyway, I would be glad to get some feedback concerning form and content of the code, becausse I'm still a newbie to kernel programming. Hi Frank, I agree

Re: Move em27xx/em28xx webcams to a gspca subdriver ?

2012-03-21 Thread Frank Schäfer
Am 16.03.2012 23:18, schrieb Frank Schäfer: [Was: eMPIA EM2710 Webcam (em28xx) and LIRC] Continue this part of the discussion in a new thread... Am 15.03.2012 14:05, schrieb Mauro Carvalho Chehab: Em 15-03-2012 09:34, Frank Schäfer escreveu: ... I would like to bring up the question

Re: Move em27xx/em28xx webcams to a gspca subdriver ?

2012-03-16 Thread Frank Schäfer
[Was: eMPIA EM2710 Webcam (em28xx) and LIRC] Continue this part of the discussion in a new thread... Am 15.03.2012 14:05, schrieb Mauro Carvalho Chehab: Em 15-03-2012 09:34, Frank Schäfer escreveu: ... I would like to bring up the question, if it wouldn't make sense to move support

Re: eMPIA EM2710 Webcam (em28xx) and LIRC

2012-03-15 Thread Frank Schäfer
for testing/discussion soon). I have no strong opinion about this, but I somehow feel that the em28xx driver gets bloated more and more... Regards, Frank Schäfer -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo

Re: em2874 bulk endpoint support

2012-01-06 Thread Frank Schäfer
Am 06.01.2012 01:52, schrieb Devin Heitmueller: On Thu, Jan 5, 2012 at 6:16 PM, Dmitriy Fitisovdmit...@radier.ca wrote: Hello everyone, I know, Devin Heitmueller was about to add support for em2874 bulk endpoint. Is that still in plans? The project that I was slated to do this work for got

Re: Question about USB interface index restriction in gspca

2011-09-19 Thread Frank Schäfer
Am 16.09.2011 08:33, schrieb Jean-Francois Moine: On Thu, 15 Sep 2011 23:46:57 +0200 Frank Schäferfschaefer@googlemail.com wrote: For webcam devices, the interface class is meaningful only when set to USB_CLASS_VIDEO (UVC). Otherwise, I saw many different values. Does that mean that

Re: Question about USB interface index restriction in gspca

2011-09-15 Thread Frank Schäfer
Am 14.09.2011 08:25, schrieb Jean-Francois Moine: On Tue, 13 Sep 2011 21:14:28 +0200 Frank Schäferfschaefer@googlemail.com wrote: I have a question about the following code in gspca.c: in function gspca_dev_probe(...): ... /* the USB video interface must be the first one */

Question about USB interface index restriction in gspca

2011-09-13 Thread Frank Schäfer
Hi, I have a question about the following code in gspca.c: in function gspca_dev_probe(...): ... /* the USB video interface must be the first one */ if (dev-config-desc.bNumInterfaces != 1 intf-cur_altsetting-desc.bInterfaceNumber != 0) return -ENODEV; ... Is

Re: [PATCH] gspca_sn9c20x: device 0c45:62b3: fix status LED

2011-08-30 Thread Frank Schäfer
Am 27.08.2011 13:55, schrieb Hans de Goede: Hi, On 08/22/2011 11:27 PM, Frank Schäfer wrote: Ping ... what happened to this patch ? ;-) I think it has fallen through the cracks. I've added it to my tree for 3.1 / 3.2 (more likely will be 3.2) Regards, Hans Thank you Hans. I will check

<    3   4   5   6   7   8   9   >