Re: Discussion: How to deal with radio tuners which can tune to multiple bands

2012-05-26 Thread Hans de Goede
Hi, On 05/26/2012 06:40 PM, Hans Verkuil wrote: On Sat May 26 2012 18:02:34 Hans de Goede wrote: Hi, On 05/24/2012 09:12 PM, Hans de Goede wrote: Hi, On 05/24/2012 05:00 PM, Hans Verkuil wrote: I think / hope that covers everything we need. Suggestions ? Comments ? Modulators

Re: Discussion: How to deal with radio tuners which can tune to multiple bands

2012-05-26 Thread Hans de Goede
Hi, On 05/26/2012 08:22 PM, Hans Verkuil wrote: On Sat May 26 2012 20:09:53 Hans de Goede wrote: Hi, On 05/26/2012 06:40 PM, Hans Verkuil wrote: On Sat May 26 2012 18:02:34 Hans de Goede wrote: Hi, On 05/24/2012 09:12 PM, Hans de Goede wrote: Hi, On 05/24/2012 05:00 PM, Hans Verkuil

Re: Discussion: How to deal with radio tuners which can tune to multiple bands

2012-05-24 Thread Hans de Goede
Hi, On 05/24/2012 05:00 PM, Hans Verkuil wrote: On Wed 23 May 2012 20:29:20 Hans de Goede wrote: snip ### So given all of the above I would like to propose the following: 1) Add a band field to struct v4l2_tuner, and a capability indicating if the driver understands / uses this field

[PATCH] gspca-core: Fix buffers staying in queued state after a stream_off

2012-05-23 Thread Hans de Goede
This fixes a regression introduced by commit f7059ea and should be backported to all supported stable kernels which have this commit. Signed-off-by: Hans de Goede hdego...@redhat.com Tested-by: Antonio Ospite osp...@studenti.unina.it CC: sta...@kernel.org --- drivers/media/video/gspca/gspca.c

Re: Problems with the gspca_ov519 driver

2012-05-23 Thread Hans de Goede
Hi, On 05/22/2012 11:02 PM, Antonio Ospite wrote: snip I feel I can add a: Tested-by: Antonio Ospiteosp...@studenti.unina.it Thanks added to the commit message. I can backport the change to older kernels and even CC linux-stable if you think it is appropriate, that's the least I can do to

[PATCH] gspca-core: Fix buffers staying in queued state after a stream_off

2012-05-23 Thread Hans de Goede
This fixes a regression introduced by commit f7059ea and should be backported to all supported stable kernels which have this commit. Signed-off-by: Hans de Goede hdego...@redhat.com Tested-by: Antonio Ospite osp...@studenti.unina.it CC: sta...@vger.kernel.org --- drivers/media/video/gspca

Re: [PATCH] gspca-core: Fix buffers staying in queued state after a stream_off

2012-05-23 Thread Hans de Goede
sorry for the spam, I had to resend it because I got the stable email address wrong. On 05/23/2012 10:20 AM, Hans de Goede wrote: This fixes a regression introduced by commit f7059ea and should be backported to all supported stable kernels which have this commit. Signed-off-by: Hans de

[GIT PULL FIXES FOR 3.5]: gspca radio fixes (updated 2x)

2012-05-23 Thread Hans de Goede
to 762f29a93eb229279f59bc2b102f194688f8e47e: gspca-core: Fix buffers staying in queued state after a stream_off (2012-05-23 10:20:24 +0200) Antonio Ospite (1): gspca_ov534: make AGC and AWB controls independent Hans de

Discussion: How to deal with radio tuners which can tune to multiple bands

2012-05-23 Thread Hans de Goede
Hi, As discussed before 2 different use-cases have come up where we want some knowledge of there being different radio bands added to the v4l2 API. In Manjunatha Halli's case, if I understand things correctly, he wants to limit hw_freq_seek to a certain band, rather then the receiver happily

Re: Discussion: How to deal with radio tuners which can tune to multiple bands

2012-05-23 Thread Hans de Goede
Hi, On 05/23/2012 09:24 PM, halli manjunatha wrote: On Wed, May 23, 2012 at 1:29 PM, Hans de Goedehdego...@redhat.com wrote: snip my super long proposal intro :) ### So given all of the above I would like to propose the following: 1) Add a band field to struct v4l2_tuner, and a

[GIT PULL FIXES FOR 3.5]: gspca radio fixes

2012-05-22 Thread Hans de Goede
): gspca_ov534: make AGC and AWB controls independent Hans de Goede (9): radio/si470x: Add support for the Axentia ALERT FM USB Receiver snd_tea575x: Report correct frequency range for EU/US versus JA models snd_tea575x: Make the module using snd_tea575x the fops owner

Re: Problems with the gspca_ov519 driver

2012-05-22 Thread Hans de Goede
talked about this on irc, attached it a patch which should fix this, feedback appreciated. Regards, Hans From b0eefa00c72e9dfe9eaa5f425c0d346b19ea01cd Mon Sep 17 00:00:00 2001 From: Hans de Goede hdego...@redhat.com Date: Tue, 22 May 2012 16:24:05 +0200 Subject: [PATCH] gspca-core: Fix buffers

Re: Problems with the gspca_ov519 driver

2012-05-22 Thread Hans de Goede
lines. Regards, Hans Regards, Lluís. On Tue, May 22, 2012 at 04:39:17PM +0200, Hans de Goede wrote: Hi, On 05/22/2012 04:08 PM, Paulo Assis wrote: Hi, This bug also causes the camera to crash when changing fps in guvcview, uvc devices (at least all the ones I tested) require the stream

Re: RFC: V4L2 API and radio devices with multiple tuners

2012-05-22 Thread Hans de Goede
Hi, On 05/22/2012 06:26 PM, Rémi Denis-Courmont wrote: Le samedi 19 mai 2012 21:36:23 Antti Palosaari, vous avez écrit : On 19.05.2012 21:20, Hans de Goede wrote: Currently the V4L2 API does not allow for radio devices with more then 1 tuner, which is a bit of a historical oversight, since

[PATCH] bttv: Use btv-has_radio rather then the card info

2012-05-20 Thread Hans de Goede
I've been spending some time playing with radio receivers under Linux, and I noticed that my bttv's radio reception was not working. The patch in the next message fixes the 1st of 3 problems related to this, can you review this patch please and also let me know if it is ok to send patch though my

[PATCH] bttv: Use btv-has_radio rather then the card info when registering the tuner

2012-05-20 Thread Hans de Goede
then the const value in the tvcards array. This fixes the radio not working on my Hauppauge WinTV. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/bt8xx/bttv-cards.c |4 ++-- drivers/media/video/bt8xx/bttv-driver.c |5 + 2 files changed, 7 insertions(+), 2

Re: RFC: V4L2 API and radio devices with multiple tuners

2012-05-20 Thread Hans de Goede
with apps not clearing the reserved fields we could use for a proper subidx again. I personally prefer just using a separate field for it. On Sat May 19 2012 20:20:57 Hans de Goede wrote: Hi Hans et all, Currently the V4L2 API does not allow for radio devices with more then 1 tuner, which is a bit

RFC: V4L2 API and radio devices with multiple tuners

2012-05-19 Thread Hans de Goede
Hi Hans et all, Currently the V4L2 API does not allow for radio devices with more then 1 tuner, which is a bit of a historical oversight, since many radio devices have 2 tuners/demodulators 1 for FM and one for AM. Trying to model this as 1 tuner really does not work well, as they have 2

Re: RFC: V4L2 API and radio devices with multiple tuners

2012-05-19 Thread Hans de Goede
Hi, On 05/19/2012 08:30 PM, Ondrej Zary wrote: On Saturday 19 May 2012 20:20:57 Hans de Goede wrote: Hi Hans et all, Currently the V4L2 API does not allow for radio devices with more then 1 tuner, which is a bit of a historical oversight, since many radio devices have 2 tuners/demodulators 1

[PATCH 0/6] snd_tea575x: Various patches

2012-05-19 Thread Hans de Goede
Hi All, This patch series contains various patches for the tea575x driver to prepare for adding support for the Griffin radioSHARK device. The 6th patch adds support for tuning AM, which depends on the discussions surrounding the v4l2 API and radio devices with multiple tuners. I plan to add

[PATCH 1/6] snd_tea575x: Add write_/read_val operations

2012-05-19 Thread Hans de Goede
Some devices which use the tea575x tuner chip don't allow bit banging the lines, instead they offer a method to directly set / get the contents of the 25 bit shift-register in the chip. Notably the Griffin radioSHARK USB radio receiver does this. Signed-off-by: Hans de Goede hdego...@redhat.com

[PATCH 3/6] snd_tea575x: Report correct frequency range for EU/US versus JA models

2012-05-19 Thread Hans de Goede
-off-by: Hans de Goede hdego...@redhat.com CC: Ondrej Zary li...@rainbow-software.org --- sound/i2c/other/tea575x-tuner.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/i2c/other/tea575x-tuner.c b/sound/i2c/other/tea575x-tuner.c index da49dd4..ddc08a8 100644

[PATCH 5/6] snd_tea575x: set_freq: update cached freq to the actual achieved frequency

2012-05-19 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com CC: Ondrej Zary li...@rainbow-software.org --- sound/i2c/other/tea575x-tuner.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/sound/i2c/other/tea575x-tuner.c b/sound/i2c/other/tea575x-tuner.c index 8c142e5..d16f7b7

[PATCH 6/6] snd_tea575x: Add support for tuning AM

2012-05-19 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com CC: Ondrej Zary li...@rainbow-software.org --- include/sound/tea575x-tuner.h |3 + sound/i2c/other/tea575x-tuner.c | 164 --- 2 files changed, 121 insertions(+), 46 deletions(-) diff --git a/include/sound

[PATCH 2/6] snd_tea575x: Add a cannot_mute flag

2012-05-19 Thread Hans de Goede
Some devices which use the tea575x tuner chip don't allow direct control over the IO pins, and thus cannot mute the audio output. Signed-off-by: Hans de Goede hdego...@redhat.com CC: Ondrej Zary li...@rainbow-software.org --- include/sound/tea575x-tuner.h |1 + sound/i2c/other/tea575x

[PATCH 4/6] snd_tea575x: Make the module using snd_tea575x the fops owner

2012-05-19 Thread Hans de Goede
to also somehow increase the refcount of the snd-tea575x-tuner module itself, since any drivers using it will have symbolic references to it. Signed-off-by: Hans de Goede hdego...@redhat.com CC: Ondrej Zary li...@rainbow-software.org --- drivers/media/radio/radio-maxiradio.c |2 +- drivers/media

Re: [PATCH 0/3] gspca: kinect cleanup, ov534 port to control framework

2012-05-18 Thread Hans de Goede
Hi, Thanks for the patches. I've added them all to my tree, so they will be included in my next pull-req. In the mean time you can find them (unmodified) here: http://git.linuxtv.org/hgoede/gspca.git/shortlog/refs/heads/media-for_v3.5-wip On 05/16/2012 11:42 PM, Antonio Ospite wrote: Hi,

Re: How I must report that a driver has been broken?

2012-05-12 Thread Hans de Goede
Hi On 05/12/2012 06:26 AM, Alfredo Jesús Delaiti wrote: Hi New features of the driver has left a card does not work. How I must report that a driver has been broken? Well this list would be a good place for starters, please send a *detailed* bug report to this list, including things like

Re: How I must report that a driver has been broken?

2012-05-12 Thread Hans de Goede
Hi, On 05/12/2012 09:26 PM, Alfredo Jesús Delaiti wrote: Hi Thanks for your response Hans and Patrick Maybe I doing wrong this, because it reports twice: http://www.mail-archive.com/linux-media@vger.kernel.org/msg45199.html

Re: Advice on extending libv4l for media controller support

2012-05-11 Thread Hans de Goede
Hi, On 05/10/2012 05:09 PM, Ivan T. Ivanov wrote: Hi Sergio, On Thu, 2012-05-10 at 08:54 -0500, Sergio Aguirre wrote: +Atsuo On Wed, May 9, 2012 at 7:08 PM, Sergio Aguirre sergio.a.agui...@gmail.com wrote: Hi Hans, I'm interested in using libv4l along with my omap4 camera project to

Re: [PATCH] uvcvideo: Fix V4L2 button controls that share the same UVC control

2012-05-11 Thread Hans de Goede
looks good, ack. Acked-by: Hans de Goede hdego...@redhat.com On 05/11/2012 03:55 PM, Laurent Pinchart wrote: The Logitech pan/tilt reset UVC control contains two V4L2 button controls to reset pan and tilt. As the UVC control is not marked as auto-update, the button bits are set but never reset

Re: [RFCv1 PATCH 1/5] v4l2-dev: make it possible to skip locking for selected ioctls.

2012-05-10 Thread Hans de Goede
Hi, Looks good, ack. Acked-by: Hans de Goede hdego...@redhat.com Regards, Hans On 05/10/2012 09:05 AM, Hans Verkuil wrote: From: Hans Verkuilhans.verk...@cisco.com Using the V4L2 core lock is a very robust method that is usually very good at doing the right thing. But some drivers

Re: [RFCv1 PATCH 2/5] v4l2-dev/ioctl: determine the valid ioctls upfront.

2012-05-10 Thread Hans de Goede
Hi, Comments inline. On 05/10/2012 09:05 AM, Hans Verkuil wrote: From: Hans Verkuilhans.verk...@cisco.com Rather than testing whether an ioctl is implemented in the driver or not every time the ioctl is called, do it upfront when the device is registered. This also allows a driver to disable

Re: [RFCv1 PATCH 3/5] tea575x-tuner: mark VIDIOC_S_HW_FREQ_SEEK as an invalid ioctl.

2012-05-10 Thread Hans de Goede
Hi, Looks good, ack. Acked-by: Hans de Goede hdego...@redhat.com Regards, Hans On 05/10/2012 09:05 AM, Hans Verkuil wrote: From: Hans Verkuilhans.verk...@cisco.com The tea575x-tuner framework can support the VIDIOC_S_HW_FREQ_SEEK for only some of the tea575x-based boards. Mark this ioctl

Re: [RFCv1 PATCH 4/5] v4l2-ioctl: handle priority handling based on a table lookup.

2012-05-10 Thread Hans de Goede
Hi, Looks good, ack. Acked-by: Hans de Goede hdego...@redhat.com Regards, Hans On 05/10/2012 09:05 AM, Hans Verkuil wrote: From: Hans Verkuilhans.verk...@cisco.com Rather than checking the priority for each ioctl that needs to, just mark such ioctls in the table and do it only once

Re: [RFCv1 PATCH 5/5] v4l2-dev: add flag to have the core lock all file operations.

2012-05-10 Thread Hans de Goede
Hi, Looks good, ack. Acked-by: Hans de Goede hdego...@redhat.com Regards, Hans On 05/10/2012 09:05 AM, Hans Verkuil wrote: From: Hans Verkuilhans.verk...@cisco.com This used to be the default if the lock pointer was set, but now that lock is by default only used for ioctl serialization

Re: Advice on extending libv4l for media controller support

2012-05-10 Thread Hans de Goede
Hi, I somehow missed the original mail. This is in essence the same problem as with the omap3 and Laurent and Sakari and I did a design for that in Brussels in the last quarter of 2011, Laurent and Sakari would work on fleshing that out, so it is probably best to talk to them about this.

Re: [GIT PULL FOR v3.5] Update v4l2-dev/ioctl.c to add gspca locking requirements

2012-05-10 Thread Hans de Goede
Hi, On 05/10/2012 05:35 PM, Laurent Pinchart wrote: Hi Hans, On Thursday 10 May 2012 13:59:34 Hans Verkuil wrote: Hi Mauro, Here is the pull request for this. HdG's gspca work depends on this and he likes to get this in for 3.5. I think these are pretty good improvements and for 3.6 I intend

Re: [PATCH for v3.5] v4l2-event: fix regression with initial event handling.

2012-05-08 Thread Hans de Goede
Hi, Good one, ACK. Acked-by: Hans de Goede hdego...@redhat.com Regards, Hans On 05/07/2012 10:53 PM, Hans Verkuil wrote: From: Hans Verkuilhans.verk...@cisco.com If the V4L2_EVENT_SUB_FL_SEND_INITIAL was set, then the application expects to receive an initial event of the initial value

Re: [ 3960.758784] 1 lock held by motion/7776: [ 3960.758788] #0: (queue-mutex){......}, at: [ffffffff815c62d2] uvc_queue_enable+0x32/0xc0

2012-05-07 Thread Hans de Goede
Hi, On 05/07/2012 01:44 PM, Hans Verkuil wrote: On Monday 07 May 2012 13:06:01 Laurent Pinchart wrote: Hi Sanser, On Sunday 06 May 2012 16:54:40 Sander Eikelenboom wrote: Hello Laurent / Mauro, I have updated to latest 3.4-rc5-tip, running multiple video grabbers. I don't see anything

[PATCH 23/23] gspca_gl860: Add a present check to sd_stop0

2012-05-07 Thread Hans de Goede
The sensor specific dev_post_unset_alt functions all try to write to the bridge, and none free any memory, so they should be skipped if stop0 is called on disconnection. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/gspca/gl860/gl860.c |3 +++ 1 file changed, 3

[PATCH 16/23] gspca: Use req_events in poll

2012-05-07 Thread Hans de Goede
So that we don't start a read stream when an app is only polling for control events. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/gspca/gspca.c | 44 ++--- 1 file changed, 26 insertions(+), 18 deletions(-) diff --git a/drivers/media

[PATCH 06/23] gscpa: use v4l2_fh and add G/S_PRIORITY support.

2012-05-07 Thread Hans de Goede
From: Hans Verkuil hans.verk...@cisco.com In order to support control event gspca has to use struct v4l2_fh. As a bonus feature this also gives priority handling for free. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video

[PATCH 12/23] gspca_zc3xx: Disable the highest quality setting as it is not usable

2012-05-07 Thread Hans de Goede
Even with BRC the highest quality setting is not usable, BRC strips so much data from each MCU that the quality becomes worse then using a lower quality setting to begin with. Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media

[PATCH 03/23] v4l2-framework.txt: add paragraph on driver locking and the control framework.

2012-05-07 Thread Hans de Goede
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans de Goede hdego...@redhat.com --- Documentation/video4linux/v4l2-framework.txt |8 1 file changed, 8 insertions(+) diff --git a/Documentation/video4linux/v4l2

[PATCH 21/23] gspca-stv06xx: convert to the control framework.

2012-05-07 Thread Hans de Goede
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/gspca/stv06xx/stv06xx.c| 24 +- drivers/media/video/gspca/stv06xx/stv06xx.h|4 + drivers/media/video/gspca

gspca: allow use of control framework and other fixes (v3)

2012-05-07 Thread Hans de Goede
Hi all, Here is version 3 of the patchset the 2 Hans-s have been working on to move gspca over to the control framework. Note that this also includes some resulting v4l2-core patches! Comments very much welcome. Regards, Hans -- To unsubscribe from this list: send the line unsubscribe

[PATCH 01/23] v4l2-dev: make it possible to skip locking for selected ioctls.

2012-05-07 Thread Hans de Goede
...@cisco.com Signed-off-by: Hans de Goede hdego...@redhat.com --- Documentation/video4linux/v4l2-framework.txt | 27 +++- drivers/media/video/v4l2-dev.c | 14 +- drivers/media/video/v4l2-ioctl.c | 183 ++ include/media/v4l2-dev.h

[PATCH 14/23] gspca: Switch to V4L2 core locking, except for the buffer queuing ioctls

2012-05-07 Thread Hans de Goede
hans.verk...@cisco.com Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/gspca/gspca.c | 237 + 1 file changed, 59 insertions(+), 178 deletions(-) diff --git a/drivers/media/video/gspca/gspca.c b/drivers/media/video/gspca/gspca.c index 2c61f58

[PATCH 18/23] gspca: Set gspca_dev-usb_err to 0 at the begin of gspca_stream_off

2012-05-07 Thread Hans de Goede
Just a small cleanup. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/gspca/gspca.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/media/video/gspca/gspca.c b/drivers/media/video/gspca/gspca.c index 8c344c1..142fd5f 100644

[PATCH 09/23] gspca_zc3xx: Fix setting of jpeg quality while streaming

2012-05-07 Thread Hans de Goede
When the user changes the JPEG quality while the camera is streaming, the driver should not only change the JPEG headers send to userspace, but also actually tell the camera to use a different quantization table. Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Hans Verkuil

[PATCH 08/23] gspca: fix querycap and incorrect return codes.

2012-05-07 Thread Hans de Goede
From: Hans Verkuil hans.verk...@cisco.com Add V4L2_CAP_DEVICE_CAPS support to querycap and replace -EINVAL by -ENOTTY whenever an ioctl is not supported. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/gspca/gspca.c

[PATCH 20/23] gcpca-sn9c20x: convert to the control framework.

2012-05-07 Thread Hans de Goede
From: Hans Verkuil hans.verk...@cisco.com HdG: Small fix: don't register some controls for sensors which don't have an implementation for them. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/gspca/sn9c20x.c | 496

[PATCH 19/23] gspca-zc3xx: convert to the control framework.

2012-05-07 Thread Hans de Goede
From: Hans Verkuil hans.verk...@cisco.com The initial version was done by HV, corrections were made by HdG, and some final small changes again by HV. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/gspca/zc3xx.c | 439

[PATCH 22/23] gspca-mars: convert to the control framework.

2012-05-07 Thread Hans de Goede
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/gspca/mars.c | 293 +- 1 file changed, 127 insertions(+), 166 deletions(-) diff --git

[PATCH 05/23] gspca: use video_drvdata(file) instead of file-private_data.

2012-05-07 Thread Hans de Goede
From: Hans Verkuil hans.verk...@cisco.com Prepare for control events: free up file-private_data by using video_drvdata(file) to get to the gspca_dev struct. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/gspca/gspca.c

[PATCH 13/23] gspca: Fix locking issues related to suspend/resume.

2012-05-07 Thread Hans de Goede
in all touched drivers. I plan to do this everywhere in the future, and most relevant lines in the touched drivers are already modified by this patch. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/gspca

[PATCH 11/23] gspca_zc3xx: Always automatically adjust BRC as needed

2012-05-07 Thread Hans de Goede
, as that is not needed and leads to ugly flashes when it is changed. Note that before this patch-set the quality was never changed either due to the bugs in the quality handling fixed in previous patches in this set. Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Hans Verkuil hans.verk

[PATCH 10/23] gspca_zc3xx: Fix JPEG quality setting code

2012-05-07 Thread Hans de Goede
in poor image quality. 75% is a good default to use for all scenarios. Signed-off-by: Hans de Goede hdego...@redhat.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/video/gspca/zc3xx.c | 64 + 1 file changed, 22 insertions(+), 42 deletions

[PATCH 04/23] gspca: allow subdrivers to use the control framework.

2012-05-07 Thread Hans de Goede
. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/gspca/gspca.c | 25 + drivers/media/video/gspca/gspca.h |1 + 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/drivers/media/video

[PATCH 07/23] gspca: add support for control events.

2012-05-07 Thread Hans de Goede
From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/gspca/gspca.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/media/video/gspca/gspca.c b/drivers/media/video

[PATCH 02/23] v4l2-dev: make it possible to skip locking for non ioctl fops

2012-05-07 Thread Hans de Goede
Just like with some ioctls some drivers may want to prevent the core from taking the V4L2 core lock on other fops. Signed-off-by: Hans de Goede hdego...@redhat.com --- Documentation/video4linux/v4l2-framework.txt |7 ++-- drivers/media/video/v4l2-dev.c | 45

[PATCH 15/23] gspca: Don't use the global video_dev lock for fops other then ioctl

2012-05-07 Thread Hans de Goede
Otherwise we can get an undesirable high latency on poll(). Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/gspca/gspca.c | 25 - drivers/media/video/gspca/gspca.h |8 ++-- 2 files changed, 26 insertions(+), 7 deletions(-) diff --git

[PATCH 17/23] gspca: Call sd_stop0 on disconnect

2012-05-07 Thread Hans de Goede
that now stream_off will never be called on a disconnected device, and the present check can thus be removed from stream_off. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/gspca/gspca.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff

Re: [RFCv2 PATCH 13/17] gspca: switch to V4L2 core locking, except for the buffer queuing ioctls.

2012-05-06 Thread Hans de Goede
Hi Hans, The entire series looks great, I do have a few remarks wrt this patch, which I have fixed in my own tree (new version attached, note untested sofar). On 05/06/2012 02:28 PM, Hans Verkuil wrote: From: Hans Verkuilhans.verk...@cisco.com Due to latency concerns the VIDIOC_QBUF, DQBUF

Re: [RFCv2 PATCH 13/17] gspca: switch to V4L2 core locking, except for the buffer queuing ioctls.

2012-05-06 Thread Hans de Goede
Hi, On 05/06/2012 05:51 PM, Hans Verkuil wrote: On Sun May 6 2012 17:25:55 Hans de Goede wrote: snip snip Notice that usb_lock is unlocked before video_unregister_device gets called, which means that any ioctl or other fops waiting for usb_lock can run before video_unregister_device runs

Re: gspca zc3xx - JPEG quality / frame overflow

2012-05-06 Thread Hans de Goede
Hi, On 05/05/2012 08:54 PM, Jean-Francois Moine wrote: Hi Hans, I quickly looked at your patches about the changes for the JPEG quality, and I have some remarks. Indeed, as I don't have any zc3xx webcam nor a lot of documentation about the zc3xx bridge, my information come only from USB trace

Re: [RFCv1 PATCH 0/7] gspca: allow use of control framework and other fixes

2012-05-05 Thread Hans de Goede
Hi, On 05/01/2012 12:28 PM, Jean-Francois Moine wrote: On Mon, 30 Apr 2012 13:13:59 +0200 Hans de Goedehdego...@redhat.com wrote: I'll review this and add these to my tree. Jean-Francois, is it ok for these changes to go upstream through my tree? The reason I'm asking is that I plan to

Re: [RFCv1 PATCH 2/7] zc3xx: convert to the control framework.

2012-05-05 Thread Hans de Goede
in the series now, hopefully that one will go quicker :) Regards, Hans From 78fd672b2b87177ceff710ca26d9ae15420e66e7 Mon Sep 17 00:00:00 2001 From: Hans de Goede hdego...@redhat.com Date: Sat, 5 May 2012 12:31:48 +0200 Subject: [PATCH 1/6] gspca_zc3xx: Fix setting of jpeg quality while streaming

Re: [RFCv1 PATCH 1/7] gspca: allow subdrivers to use the control framework.

2012-05-05 Thread Hans de Goede
Hi, On 05/05/2012 11:14 AM, Hans Verkuil wrote: On Sat May 5 2012 09:43:01 Hans de Goede wrote: Hi, I'm slowly working my way though this series today (both review, as well as some tweaks and testing). More comments inline... On 04/28/2012 05:09 PM, Hans Verkuil wrote: From: Hans

Re: [RFCv1 PATCH 1/7] gspca: allow subdrivers to use the control framework.

2012-05-05 Thread Hans de Goede
Hi, On 05/05/2012 10:34 AM, Hans Verkuil wrote: On Sat May 5 2012 09:43:01 Hans de Goede wrote: Hi, I'm slowly working my way though this series today (both review, as well as some tweaks and testing). Thanks for that! One note: I initialized the controls in sd_init. That's wrong

Re: [RFCv1 PATCH 1/7] gspca: allow subdrivers to use the control framework.

2012-05-05 Thread Hans de Goede
Hi, On 05/05/2012 04:50 PM, Hans Verkuil wrote: On Sat May 5 2012 16:46:32 Hans de Goede wrote: Hi, On 05/05/2012 10:34 AM, Hans Verkuil wrote: On Sat May 5 2012 09:43:01 Hans de Goede wrote: Hi, I'm slowly working my way though this series today (both review, as well as some tweaks

Re: [RFCv1 PATCH 1/7] gspca: allow subdrivers to use the control framework.

2012-05-05 Thread Hans de Goede
Hi, On 05/05/2012 04:44 PM, Hans de Goede wrote: Hi, On 05/05/2012 11:14 AM, Hans Verkuil wrote: So you get: vidioc_foo() lock(mylock) v4l2_ctrl_s_ctrl(ctrl, val) s_ctrl(ctrl, val) lock(mylock) Easy solution here, remove the first lock(mylock), since we are not using v4l2-dev's locking

Re: [RFCv1 PATCH 1/7] gspca: allow subdrivers to use the control framework.

2012-05-05 Thread Hans de Goede
Hi, Oops, forgot the attachment it is here now... Regards, Hans On 05/05/2012 05:05 PM, Hans de Goede wrote: Hi, On 05/05/2012 04:44 PM, Hans de Goede wrote: Hi, On 05/05/2012 11:14 AM, Hans Verkuil wrote: So you get: vidioc_foo() lock(mylock) v4l2_ctrl_s_ctrl(ctrl, val) s_ctrl(ctrl

Re: [RFCv1 PATCH 1/7] gspca: allow subdrivers to use the control framework.

2012-05-05 Thread Hans de Goede
Hi, On 05/05/2012 05:02 PM, Hans Verkuil wrote: BTW, this is getting messy: both of us producing patches for the same driver :-) For those reading along on the mailinglist, we've got together on irc and coordinated how we are going to handle this there. Regards, Hans -- To unsubscribe from

Re: logitech quickcam 9000 uvcdynctrl broken since kernel 3.2 - PING

2012-05-04 Thread Hans de Goede
...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From 72d835008c1712a8b19427e540de82527d75 Mon Sep 17 00:00:00 2001 From: Hans de Goede hdego...@redhat.com Date: Sun, 16 May 2010 11:17:22 +0200 Subject: [PATCH 01/10] Support mapping button controls

Re: logitech quickcam 9000 uvcdynctrl broken since kernel 3.2 - PING

2012-05-04 Thread Hans de Goede
p.s. Some of my commit messages talk about them needing some kernel changes / fixes. These are all long in place now (since before the uvcvideo.h header become an official userspace available kernel header). Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-media

[GIT PULL FOR 3.5] gspca_pac73XX improvements + misc fixes

2012-05-04 Thread Hans de Goede
: Remove this deprecated driver (2012-05-04 11:38:43 +0200) Hans de Goede (13): stk-webcam: Don't flip the image by default gspca/autogain_functions.h: Allow users to declare what they want gspca_pac73xx: Remove comments

Re: [RFCv1 PATCH 0/7] gspca: allow use of control framework and other fixes

2012-04-30 Thread Hans de Goede
Hi, On 04/28/2012 05:09 PM, Hans Verkuil wrote: Hi all, Here is a patch series that makes it possible to use the control framework in gspca. The gspca core changes are very minor but as a bonus give you priority support as well. The hard work is in updating the subdrivers. I've done two, and

Re: [PATCH v2] tinyjpeg: Dynamic luminance quantization table for Pixart JPEG

2012-04-28 Thread Hans de Goede
Hi, On 04/25/2012 06:09 PM, Jean-Francois Moine wrote: Hi Hans, snip BTW, I don't think the exposure and gain controls use the right registers as they are coded in the actual gspca pac7302 subdriver. The ms-windows driver uses the registers (3-80 / 3-03), (3-05 / 3-04), 3-03, 3-04 and

[GIT PULL FOR 3.5] gspca_pac73XX improvements + misc fixes

2012-04-28 Thread Hans de Goede
repository at: git://linuxtv.org/hgoede/gspca.git media-for_v3.5 for you to fetch changes up to c9b5378afdfc2fa3eecae2cf8d2e20c40e60496c: gspca_pac7302: Improve the gain control (2012-04-28 15:37:59 +0200) Hans de Goede (12

[GIT PULL FOR 3.5] gspca_pac73XX improvements + misc fixes

2012-04-28 Thread Hans de Goede
repository at: git://linuxtv.org/hgoede/gspca.git media-for_v3.5 for you to fetch changes up to c9b5378afdfc2fa3eecae2cf8d2e20c40e60496c: gspca_pac7302: Improve the gain control (2012-04-28 15:37:59 +0200) Hans de Goede (12

Re: [RFC PATCH 3/3] [media] gspca - main: implement vidioc_g_ext_ctrls and vidioc_s_ext_ctrls

2012-04-27 Thread Hans de Goede
Hi, On 04/27/2012 11:24 AM, Jean-Francois Moine wrote: On Fri, 27 Apr 2012 10:20:23 +0200 Hans Verkuilhverk...@xs4all.nl wrote: I might have some time (no guarantees yet) to help with this. It would certainly be interesting to add support for the control framework in the gspca core. Hmm,

Re: [PATCH v2] tinyjpeg: Dynamic luminance quantization table for Pixart JPEG

2012-04-27 Thread Hans de Goede
Hi, On 04/25/2012 06:09 PM, Jean-Francois Moine wrote: Hi Hans, On Wed, 25 Apr 2012 16:19:57 +0200 Hans de Goedehdego...@redhat.com wrote: You say that the marker cannot be in the range 0..31 (index 0..7), but I have never seen a value lower than 68 (index 17). If you change register 0x80

Re: [PATCH/RFC v3 03/14] V4L: Add an extended camera white balance control

2012-04-27 Thread Hans de Goede
Hi, Looks good! Acked-by: Hans de Goede hdego...@redhat.com Regards, Hans On 04/27/2012 04:23 PM, Sylwester Nawrocki wrote: This patch adds V4L2_CID_AUTO_N_PRESET_WHITE_BALANCE control which is an extended version of the V4L2_CID_AUTO_WHITE_BALANCE control, including white balance presets

Re: [PATCH v2] tinyjpeg: Dynamic luminance quantization table for Pixart JPEG

2012-04-25 Thread Hans de Goede
Hi, On 04/24/2012 12:34 PM, Jean-Francois Moine wrote: On Mon, 23 Apr 2012 23:34:05 +0200 Hans de Goedehdego...@redhat.com wrote: Thanks for your work on this! I've just spend almost 4 days wrestling which the Pixart JPEG decompression code to try to better understand these cams, and I have

Re: [PATCH v2] uvcvideo: Send control change events for slave ctrls when the master changes

2012-04-24 Thread Hans de Goede
Hi, Good optimization, ACK. Regards, Hans On 04/24/2012 12:48 AM, Laurent Pinchart wrote: From: Hans de Goedehdego...@redhat.com This allows v4l2 control UI-s to update the inactive state (ie grey-ing out of controls) for slave controls when the master control changes. Signed-off-by: Hans

Re: Fwd: Re: [PATCH 04/15] V4L: Add camera white balance preset control

2012-04-23 Thread Hans de Goede
Hi, On 04/22/2012 05:41 PM, Sylwester Nawrocki wrote: Hi, snip long discussion coming down to consensus to fold manual/auto/preset1-# into 1 new (for ABI reasons) awb menu control So I'm going to rework patch 04/15, to remove V4L2_WHITE_BALANCE_PRESET_NONE and add AUTO, MANUAL entries.

Re: [PATCH 04/15] V4L: Add camera white balance preset control

2012-04-17 Thread Hans de Goede
Hi, On 04/17/2012 12:09 PM, Sylwester Nawrocki wrote: Add V4L2_CID_WHITE_BALANCE_PRESET control for camera white balance presets. The following items are defined: - V4L2_WHITE_BALANCE_NONE, - V4L2_WHITE_BALANCE_INCANDESCENT, - V4L2_WHITE_BALANCE_FLUORESCENT, -

Re: [PATCH] stk-webcam: Don't flip the image by default

2012-04-09 Thread Hans de Goede
Hi, On 04/09/2012 09:27 AM, Jaime Velasco wrote: 2012/4/8 Hans de Goede hdego...@redhat.com mailto:hdego...@redhat.com Prior to this patch the stk-webcam driver was enabling the vflip and mirror bits in the sensor by default. Which only is the right thing to do if the sensor

Re: stk webcam driver needs DMI upside down table

2012-04-08 Thread Hans de Goede
Hi, On 04/06/2012 06:04 PM, Gregor Jasny wrote: Hello, I recently received a webcam upside down report from a ASUS Z96Fm owner. Usually we add the USB id and DMI information to the libv4l upside down table. Except for webcam drivers that can flip images in hardware. By looking at stk-webcam.c

Re: [PATCH 09/10] uvcvideo: Properly report the inactive flag for inactive controls

2012-04-08 Thread Hans de Goede
Hi, On 03/28/2012 11:12 AM, Laurent Pinchart wrote: Hi Hans, Thanks for the patch. On Sunday 25 March 2012 13:56:49 Hans de Goede wrote: Note the unused in this patch slave_ids addition to the mappings will get used in a follow up patch to generate control change events for the slave ctrls

[PATCH 00/10] uvcvideo: Add support for control events (v2)

2012-04-08 Thread Hans de Goede
Here is v2 of my uvcvideo ctrl events patchset. It hopefully addresses all remarks you had wrt the previous version. As discussed before this also contains some none uvcvideo changes, which are necessary for the uvcvideo ctrl event support. Since these patches have already been reviewed and they

[PATCH 01/10] media/radio: use v4l2_ctrl_subscribe_event where possible

2012-04-08 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/radio/radio-isa.c | 10 +- drivers/media/radio/radio-keene.c | 14 +- 2 files changed, 2 insertions(+), 22 deletions(-) diff --git a/drivers/media/radio/radio-isa.c b/drivers/media/radio/radio-isa.c

[PATCH 03/10] v4l2-ctrls: Use v4l2_subscribed_event_ops

2012-04-08 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/video/ivtv/ivtv-ioctl.c |3 +- drivers/media/video/v4l2-ctrls.c | 58 ++--- drivers/media/video/v4l2-event.c | 39

[PATCH 10/10] uvcvideo: Drop unused ctrl member from struct uvc_control_mapping

2012-04-08 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/uvc/uvc_ctrl.c |1 - drivers/media/video/uvc/uvcvideo.h |2 -- 2 files changed, 3 deletions(-) diff --git a/drivers/media/video/uvc/uvc_ctrl.c b/drivers/media/video/uvc/uvc_ctrl.c index 38d633a..d520c5c 100644

[PATCH 09/10] uvcvideo: Send control change events for slave ctrls when the master changes

2012-04-08 Thread Hans de Goede
This allows v4l2 control UI-s to update the inactive state (ie grey-ing out of controls) for slave controls when the master control changes. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/uvc/uvc_ctrl.c | 57 ++-- 1 file changed, 54

[PATCH 08/10] uvcvideo: Properly report the inactive flag for inactive controls

2012-04-08 Thread Hans de Goede
Note the unused in this patch slave_ids addition to the mappings will get used in a follow up patch to generate control change events for the slave ctrls when their flags change due to the master control changing value. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/uvc

[PATCH 02/10] v4l2-event: Add v4l2_subscribed_event_ops

2012-04-08 Thread Hans de Goede
Just like with ctrl events, drivers may want to get called back on listener add / remove for other event types too. Rather then special casing all of this in subscribe / unsubscribe event it is better to use ops for this. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Hans Verkuil

[PATCH 07/10] uvcvideo: Add support for control events

2012-04-08 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/uvc/uvc_ctrl.c | 120 +++- drivers/media/video/uvc/uvc_v4l2.c | 43 ++--- drivers/media/video/uvc/uvcvideo.h | 20

<    1   2   3   4   5   6   7   8   9   10   >