[PATCH 06/10] uvcvideo: Move __uvc_ctrl_get() up

2012-04-08 Thread Hans de Goede
This avoids the need for doing a forward declaration of __uvc_ctrl_get (which is a static function) in later patches in this series. Note to reviewers this patch does not change a single line of code, it just moves the function up in uvc_ctrl.c a bit. Signed-off-by: Hans de Goede hdego

[PATCH 05/10] uvcvideo: Refactor uvc_ctrl_get and query

2012-04-08 Thread Hans de Goede
This is a preparation patch for adding ctrl event support. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/uvc/uvc_ctrl.c | 77 +++- 1 file changed, 49 insertions(+), 28

[PATCH] stk-webcam: Don't flip the image by default

2012-04-08 Thread Hans de Goede
supports, one for an ASUSTeK Computer Inc. A3H laptop with a build in 174f:a311 webcam, and one for an To Be Filled By O.E.M. Z96FM laptop with a build in 05e1:0501 webcam. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/stk-webcam.c |8 1 file changed, 4

Re: [PATCH] tinyjpeg: Better luminance quantization table for Pixart JPEG

2012-04-07 Thread Hans de Goede
Hi, Thanks for the patch, I've pushed it to v4l-utils master and I will cherry-pick it into the stable-0.8 branch after this mail. I noticed while testing with a pac7302 camera, that under certain circumstances the jpeg decompression still goes wrong. When you point the camera at a high

Re: Startup delay needed for a Sonix camera

2012-03-29 Thread Hans de Goede
Hi, On 03/29/2012 08:27 AM, Rafał Rzepecki wrote: Hi, I've tried to reach Jean-Francois with this a week ago, but I still haven't received an answer, so I'm sending it to the mailing list. I'd appreciate a CC of any follow-ups. I've been having problems with my ID 0c45:6128 Microdia PC Camera

Re: [PATCH 09/10] uvcvideo: Properly report the inactive flag for inactive controls

2012-03-28 Thread Hans de Goede
Hi, Thanks for the reviews! On 03/28/2012 11:12 AM, Laurent Pinchart wrote: Hi Hans, Thanks for the patch. On Sunday 25 March 2012 13:56:49 Hans de Goede wrote: Note the unused in this patch slave_ids addition to the mappings will get used in a follow up patch to generate control change

Re: [PATCH 10/10] uvcvideo: Send control change events for slave ctrls when the master changes

2012-03-28 Thread Hans de Goede
Hi, On 03/28/2012 11:34 AM, Laurent Pinchart wrote: Hi Hans, Thanks for the patch. On Sunday 25 March 2012 13:56:50 Hans de Goede wrote: This allows v4l2 control UI-s to update the inactive state (ie grey-ing out of controls) for slave controls when the master control changes. Signed-off

uvc pwc: Add support for control events (v2)

2012-03-25 Thread Hans de Goede
Hi All, This patch series adds supports for control events to the uvc and pwc drivers. Note: -This series depends on Hans Verkuil's poll work, the latest version of -which can be found here: http://git.linuxtv.org/hgoede/gspca.git/shortlog/refs/heads/poll_req_events -This series has been

[PATCH 01/10] pwc: Add support for control events

2012-03-25 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/pwc/pwc-v4l.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/video/pwc/pwc-v4l.c b/drivers/media/video/pwc/pwc-v4l.c index 2834e3e..c1ba1a0 100644 --- a/drivers/media/video/pwc/pwc-v4l.c +++ b

[PATCH 02/10] media/radio: use v4l2_ctrl_subscribe_event where possible

2012-03-25 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/radio/radio-isa.c | 10 +- drivers/media/radio/radio-keene.c | 14 +- 2 files changed, 2 insertions(+), 22 deletions(-) diff --git a/drivers/media/radio/radio-isa.c b/drivers/media/radio/radio-isa.c

[PATCH 04/10] v4l2-ctrls: Use v4l2_subscribed_event_ops

2012-03-25 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/video/ivtv/ivtv-ioctl.c |3 +- drivers/media/video/v4l2-ctrls.c | 58 ++--- drivers/media/video/v4l2-event.c | 39

[PATCH 06/10] uvcvideo: Refactor uvc_ctrl_get and query

2012-03-25 Thread Hans de Goede
This is a preparation patch for adding ctrl event support. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/uvc/uvc_ctrl.c | 69 1 file changed, 46 insertions(+), 23 deletions(-) diff --git a/drivers/media/video/uvc/uvc_ctrl.c b

[PATCH 07/10] uvcvideo: Move __uvc_ctrl_get() up

2012-03-25 Thread Hans de Goede
This avoids the need for doing a forward declaration of __uvc_ctrl_get (which is a static function) in later patches in this series. Note to reviewers this patch does not change a single line of code, it just moves the function up in uvc_ctrl.c a bit. Signed-off-by: Hans de Goede hdego

[PATCH 08/10] uvcvideo: Add support for control events

2012-03-25 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/uvc/uvc_ctrl.c | 119 +++- drivers/media/video/uvc/uvc_v4l2.c | 42 ++--- drivers/media/video/uvc/uvcvideo.h | 18 -- 3 files changed, 165 insertions(+), 14 deletions(-) diff

[PATCH 09/10] uvcvideo: Properly report the inactive flag for inactive controls

2012-03-25 Thread Hans de Goede
Note the unused in this patch slave_ids addition to the mappings will get used in a follow up patch to generate control change events for the slave ctrls when their flags change due to the master control changing value. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/uvc

[PATCH 10/10] uvcvideo: Send control change events for slave ctrls when the master changes

2012-03-25 Thread Hans de Goede
This allows v4l2 control UI-s to update the inactive state (ie grey-ing out of controls) for slave controls when the master control changes. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/uvc/uvc_ctrl.c | 55 ++-- 1 file changed, 52

[PATCH 03/10] v4l2-event: Add v4l2_subscribed_event_ops

2012-03-25 Thread Hans de Goede
Just like with ctrl events, drivers may want to get called back on listener add / remove for other event types too. Rather then special casing all of this in subscribe / unsubscribe event it is better to use ops for this. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Hans Verkuil

[PATCH 05/10] uvcvideo: Fix a ignoring return value of ‘__clear_user’ warning

2012-03-25 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/uvc/uvc_v4l2.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/video/uvc/uvc_v4l2.c b/drivers/media/video/uvc/uvc_v4l2.c index ff2cddd..8db90ef 100644 --- a/drivers/media/video/uvc

[PATCH 1/6] pwc: Add support for control events

2012-03-23 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/pwc/pwc-v4l.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/video/pwc/pwc-v4l.c b/drivers/media/video/pwc/pwc-v4l.c index 2834e3e..c1ba1a0 100644 --- a/drivers/media/video/pwc/pwc-v4l.c +++ b

uvc pwc: Add support for control events

2012-03-23 Thread Hans de Goede
Hi All, This patch series adds supports for control events to the uvc and pwc drivers. Note: -This series depends on Hans Verkuil's poll work, the latest version of -which can be found here: http://git.linuxtv.org/hgoede/gspca.git/shortlog/refs/heads/poll_req_events -This series has been

[PATCH 2/6] media/radio: use v4l2_ctrl_subscribe_event where possible

2012-03-23 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/radio/radio-isa.c | 10 +- drivers/media/radio/radio-keene.c | 14 +- 2 files changed, 2 insertions(+), 22 deletions(-) diff --git a/drivers/media/radio/radio-isa.c b/drivers/media/radio/radio-isa.c

[PATCH 3/6] v4l2-event: Add v4l2_subscribed_event_ops

2012-03-23 Thread Hans de Goede
Just like with ctrl events, drivers may want to get called back on listener add / remove for other event types too. Rather then special casing all of this in subscribe / unsubscribe event it is better to use ops for this. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Hans Verkuil

[PATCH 5/6] uvcvideo: Refactor uvc_ctrl_get and query

2012-03-23 Thread Hans de Goede
This is a preparation patch for adding ctrl event support. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/uvc/uvc_ctrl.c | 62 +--- 1 file changed, 43 insertions(+), 19 deletions(-) diff --git a/drivers/media/video/uvc/uvc_ctrl.c b

[PATCH 1/6] pwc: Add support for control events

2012-03-23 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/pwc/pwc-v4l.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/video/pwc/pwc-v4l.c b/drivers/media/video/pwc/pwc-v4l.c index 2834e3e..c1ba1a0 100644 --- a/drivers/media/video/pwc/pwc-v4l.c +++ b

[PATCH 4/6] v4l2-ctrls: Use v4l2_subscribed_event_ops

2012-03-23 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/video/ivtv/ivtv-ioctl.c |3 +- drivers/media/video/v4l2-ctrls.c | 58 ++--- drivers/media/video/v4l2-event.c | 39

[PATCH 6/6] uvcvideo: Add support for control events

2012-03-23 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/uvc/uvc_ctrl.c | 114 +++- drivers/media/video/uvc/uvc_v4l2.c | 30 +- drivers/media/video/uvc/uvcvideo.h | 21 +-- 3 files changed, 157 insertions(+), 8 deletions(-) diff

[GIT PATCHES FOR 3.4] poll: add poll_requested_events() and poll_does_not_wait() functions related patches

2012-03-22 Thread Hans de Goede
for pending events. vivi: let vb2_poll handle events. Hans de Goede (1): pwc: poll(): Check that the device has not beem claimed for streaming already drivers/media/video/ivtv/ivtv-fileops.c |6 ++-- drivers/media/video/pwc/pwc-if.c|9 ++ drivers/media/video/videobuf

[PATCH 0/1] poll: add poll_requested_events() and poll_does_not_wait()

2012-03-13 Thread Hans de Goede
Hi All, I'm re-submitting this patch on behalf of Hans Verkuil, who currently is unavailable for kernel work due to personal circumstances and has asked me to get this patch upstream for 3.4-rc1. This patch has been posted and discussed multiple times, a previous version has been reviewed by Al

[PATCH] poll: add poll_requested_events() and poll_does_not_wait() functions

2012-03-13 Thread Hans de Goede
...@xmailserver.org Signed-off-by: Hans de Goede hdego...@redhat.com --- fs/eventpoll.c | 18 +++--- fs/select.c | 40 ++-- include/linux/poll.h | 37 +++-- include/net/sock.h |2 +- net/unix/af_unix.c

Re: A second easycap driver implementation

2012-03-07 Thread Hans de Goede
Hi, On 03/06/2012 10:04 PM, Ezequiel García wrote: Hello, After some research on v4l2 and videbuf2, and considering that easycap driver is pretty outdated I've decided to start writing a new driver from scratch. I am using the excellent vivi driver and some usb video capture drivers as a

Re: My Microdia (SN9C201) webcam doesn't work properly in Linux anymore

2012-03-06 Thread Hans de Goede
Hi, On 03/06/2012 01:44 AM, Xavion wrote: Hi Guys Thanks very much for the follow-up emails. Our time-zone differences prevented me from replying sooner. I'm guessing you guys are both in Europe, whereas I'm down and across in Australia. As I plan to use this webcam for home security, I

Re: My Microdia (SN9C201) webcam doesn't work properly in Linux anymore

2012-03-05 Thread Hans de Goede
Hi, On 03/04/2012 10:58 PM, Xavion wrote: Hi Jean-Francois I can confirm that GSPCA v2.15.1 removes the bad pixels when I use Cheese or VLC. However, I'm sorry to report that the Motion problems unfortunately still remain. Is there something else I must do to overcome the below errors? I'm

Re: My Microdia (SN9C201) webcam doesn't work properly in Linux anymore

2012-03-05 Thread Hans de Goede
Hi, On 03/05/2012 01:03 PM, Jean-Francois Moine wrote: On Mon, 05 Mar 2012 09:33:18 +0100 Hans de Goedehdego...@redhat.com wrote: I guess that motion is using the JPG compressed frames rather then the i420 like special format these cameras also support, and it looks like we don't reserve

Re: My Microdia (SN9C201) webcam doesn't work properly in Linux anymore

2012-03-02 Thread Hans de Goede
Hi, On 03/03/2012 01:23 AM, Xavion wrote: My Microdia (SN9C201) webcam was working in Linux, but it has been failing lately. Take a look at the attached snapshot to see what I mean. It's like that all the time in Linux these days, but it works perfectly in Windows. Thanks for the picture

Re: v4l-utils migrated to autotools

2012-01-17 Thread Hans de Goede
Hi, On 01/15/2012 10:37 PM, Gregor Jasny wrote: Hello, I'm Gregor the Debian (and thus Ubuntu) Maintainer of v4l-utils. I took the challenge to convert the Makefile based build system into an autotools one. This weekend I polished the last bits and submitted my changes. If you build v4l-utils

[GIT PATCHES FOR 3.3] More pwc cleanups and fixes

2012-01-11 Thread Hans de Goede
://linuxtv.org/hgoede/gspca.git media-for_v3.3 Hans de Goede (8): pwc: Make fps runtime configurable through s_parm, drop fps module param pwc: Make decoder data part of the main pwc struct pwc: Fix pixfmt handling pwc: Avoid sending mode info to the camera when it is not needed

Re: [PATCH] libv4l: add hflip quirk for dealextreme cam sku #44507

2012-01-03 Thread Hans de Goede
Hi, Thanks for the patch. I'm sorry, but a quick google shows that your cam has a usb id used by various generic cameras, including some microscopes, see: http://blog.littleimpact.de/index.php/2011/10/16/using-biolux-nv-on-ubuntu-linux/ Enabling flipping on all these models because one has

Re: [PATCH for 3.2 URGENT] gspca: Fix bulk mode cameras no longer working (regression fix)

2012-01-02 Thread Hans de Goede
Hi, On 12/31/2011 08:08 PM, Theodore Kilgore wrote: snip Jean-Francois, Hans, Without addressing finer points, please let me add the following: 1. I figured out what was holding me back from getting 3.2 to work (it was a config error, apparently originating between keyboard and chair). 2.

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2011-12-30 Thread Hans de Goede
Hi, On 12/30/2011 07:35 AM, HeungJun, Kim wrote: Hi Sakari, Thanks for the comments! Your comments help me to order my thoughts and re-send RFC. snip The value of the new control would have an effect as long as automatic white balance is enabled. No, it's a kind of Manual White Balance,

[GIT PATCHES FOR 3.3] gspca patches and new jl2005bcd driver

2011-12-30 Thread Hans de Goede
: Add support for DVB-C Annex C (2011-12-20 14:01:08 -0200) are available in the git repository at: git://linuxtv.org/hgoede/gspca.git media-for_v3.3 Hans de Goede (3): gspca: Fix bulk mode cameras no longer working (regression fix) gspca_pac207: Raise max exposure + various autogain

Re: [PATCH for 3.2 URGENT] gspca: Fix bulk mode cameras no longer working (regression fix)

2011-12-30 Thread Hans de Goede
Hi, On 12/30/2011 11:21 AM, Jean-Francois Moine wrote: On Thu, 29 Dec 2011 21:36:42 +0100 Hans de Goedehdego...@redhat.com wrote: The new iso bandwidth calculation code accidentally has broken support for bulk mode cameras. This has broken the following drivers: finepix, jeilinj, ovfx2,

Re: [GIT PATCHES FOR 3.3] gspca patches and new jl2005bcd driver

2011-12-30 Thread Hans de Goede
Hi, On 12/30/2011 11:24 AM, Jean-Francois Moine wrote: On Fri, 30 Dec 2011 10:29:56 +0100 Hans de Goedehdego...@redhat.com wrote: [snip] The following changes since commit 1a5cd29631a6b75e49e6ad8a770ab9d69cda0fa2: [media] tda10021: Add support for DVB-C Annex C (2011-12-20

[GIT PATCHES FOR 3.3] gspca patches

2011-12-30 Thread Hans de Goede
send earlier for 3.2). The following changes since commit 1a5cd29631a6b75e49e6ad8a770ab9d69cda0fa2: [media] tda10021: Add support for DVB-C Annex C (2011-12-20 14:01:08 -0200) are available in the git repository at: git://linuxtv.org/hgoede/gspca.git media-for_v3.3 Hans de Goede (3

Re: [GIT PATCHES FOR 3.3] gspca patches and new jl2005bcd driver

2011-12-30 Thread Hans de Goede
Hi, On 12/30/2011 12:26 PM, Jean-Francois Moine wrote: On Fri, 30 Dec 2011 11:56:38 +0100 Hans de Goedehdego...@redhat.com wrote: I took it as is from Theodore, I guess we should do a separate cleanup patch on top to preserve the history / authorship. Since I'm busy testing the new isoc

Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control

2011-12-30 Thread Hans de Goede
Hi, On 12/30/2011 07:42 PM, 'Sakari Ailus' wrote: Hi Hans, On Fri, Dec 30, 2011 at 09:41:57AM +0100, Hans de Goede wrote: ... Right, so the above is exactly why I ended up making the pwc whitebalance control the way it is, the user can essentially choice between a number of options: 1) auto

[PATCH for 3.2 URGENT] gspca: Fix falling back to lower isoc alt

2011-12-30 Thread Hans de Goede
Hi Mauro et all, I'm afraid my recent work on gscpa has uncovered another regression in the gspca core. It no longer properly falls back to a lower alt setting if there is not enough bandwidth for the initially choosen one. This is a problem when usb1 devices are plugged into a usb2 hub, or into

[PATCH for 3.2 URGENT] gspca: Fix falling back to lower isoc alt settings

2011-12-30 Thread Hans de Goede
-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/gspca/gspca.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/gspca/gspca.c b/drivers/media/video/gspca/gspca.c index 7fb90ae..c27dc09 100644 --- a/drivers/media/video/gspca/gspca.c +++ b

[PATCH for 3.2 URGENT 0/1] Fix major regression in gspca

2011-12-29 Thread Hans de Goede
Hi all, Unfortunately the new iso bandwidth calculation code in gspca has accidentally broken support for bulk mode cameras, breaking support for a wide range of chipsets (see the patch for a full list). Mauro, please send this patch to Linus asap, so that 3.2 won't ship with this regression.

[PATCH for 3.2 URGENT] gspca: Fix bulk mode cameras no longer working (regression fix)

2011-12-29 Thread Hans de Goede
cams. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/gspca/gspca.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/gspca/gspca.c b/drivers/media/video/gspca/gspca.c index 271be98..5ce3557 100644 --- a/drivers/media/video

Re: [PATCH] [media] gspca: replaced static allocation by video_device_alloc/video_device_release

2011-11-19 Thread Hans de Goede
Hi, On 11/19/2011 07:50 PM, Ezequiel wrote: Pushed video_device initialization into a separate function. Replaced static allocation of struct video_device by video_device_alloc/video_device_release usage. NACK! I see a video_device_release call here, but not a video_device_alloc, also you're

[GIT FIXES FOR 3.2 resend] Fixes for event framework

2011-11-07 Thread Hans de Goede
://linuxtv.org/hgoede/gspca.git eventfixes Hans de Goede (3): v4l2-event: Deny subscribing with a type of V4L2_EVENT_ALL v4l2-event: Remove pending events from fh event queue when unsubscribing v4l2-event: Don't set sev-fh to NULL on unsubscribe drivers/media/video/v4l2-ctrls.c |4

Re: [PATCH 4/6] v4l2-event: Don't set sev-fh to NULL on unsubscribe

2011-11-02 Thread Hans de Goede
resend with correct subject, sorry for the confusing wrong subject with the previous mail Hi, hverkuil wrote: On Thursday, October 27, 2011 13:18:01 Hans de Goede wrote: 1: There is no reason for this after v4l2_event_unsubscribe releases the spinlock nothing is holding a reference

Re: [PATCH 5/6] v4l2-event: Add v4l2_subscribed_event_ops

2011-11-02 Thread Hans de Goede
Hi, hverkuil wrote: + if (sev-ops sev-ops-add) { + int ret = sev-ops-add(sev); + if (ret) { + sev-ops = NULL; + v4l2_event_unsubscribe(fh, sub); + return ret; + } The problem here

Various ctrl and event frame work patches (version 3)

2011-11-02 Thread Hans de Goede
Hi All, This patch set obsoletes my previous add v4l2_subscribed_event_ops set, while working on adding support for ctrl-events to the uvc driver I found a few bugs in the event code, which this patchset fixes. Changes since version 1: 4/5 v4l2-event: Add

[PATCH 1/5] v4l2-event: Deny subscribing with a type of V4L2_EVENT_ALL

2011-11-02 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/video/v4l2-event.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2

[PATCH 2/5] v4l2-event: Remove pending events from fh event queue when unsubscribing

2011-11-02 Thread Hans de Goede
on unsubscription. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/v4l2-event.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2-event.c b/drivers/media/video/v4l2-event.c index 9f56f18..4d01f17 100644 --- a/drivers/media

[PATCH 3/5] v4l2-event: Don't set sev-fh to NULL on unsubscribe

2011-11-02 Thread Hans de Goede
the ev_subs list 13) v4l2_ctrls del_event releases the ctrl lock 14) v4l2_event_unsubscribe frees the sev, to which no references are being held anymore Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/v4l2-ctrls.c |4 ++-- drivers/media/video/v4l2-event.c |1 - 2 files

[PATCH 5/5] v4l2-ctrls: Use v4l2_subscribed_event_ops

2011-11-02 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/video/ivtv/ivtv-ioctl.c |3 +- drivers/media/video/pwc/pwc-v4l.c |2 +- drivers/media/video/v4l2-ctrls.c | 56 +++-- drivers/media/video

[PATCH 4/5] v4l2-event: Add v4l2_subscribed_event_ops

2011-11-02 Thread Hans de Goede
Just like with ctrl events, drivers may want to get called back on listener add / remove for other event types too. Rather then special casing all of this in subscribe / unsubscribe event it is better to use ops for this. Signed-off-by: Hans de Goede hdego...@redhat.com --- Documentation

Re: Various ctrl and event frame work patches (version 3)

2011-11-02 Thread Hans de Goede
Hi Hans V., Thanks for the review and the acks. So do you want to get these patches in through my tree, or through yours? I believe we should get patches 1-3 into 3.2, 4 5 could also go to 3.2, or we can delay them to 3.3 . Regards, Hansg -- To unsubscribe from this list: send the line

[GIT FIXES FOR 3.2] Fixes for event framework

2011-11-02 Thread Hans de Goede
://linuxtv.org/hgoede/gspca.git eventfixes Hans de Goede (3): v4l2-event: Deny subscribing with a type of V4L2_EVENT_ALL v4l2-event: Remove pending events from fh event queue when unsubscribing v4l2-event: Don't set sev-fh to NULL on unsubscribe drivers/media/video/v4l2-ctrls.c |4

Re: Various ctrl and event frame work patches (version 2)

2011-11-01 Thread Hans de Goede
Hi, On 10/31/2011 05:17 PM, Hans Verkuil wrote: Hi Hans! On Monday, October 31, 2011 16:16:43 Hans de Goede wrote: Hi All, This patch set obsoletes my previous add v4l2_subscribed_event_ops set, while working on adding support for ctrl-events to the uvc driver I found a few bugs in the event

Re: [PATCH 3/6] v4l2-event: Remove pending events from fh event queue when unsubscribing

2011-11-01 Thread Hans de Goede
Hi, hverkuil wrote: This patch fixes these dangling pointers in the available queue by removing all matching pending events on unsubscription. The idea is fine, but the implementation is inefficient. Instead of the list_for_each_entry_safe you can just do: for (i = 0; i

[GIT PATCHES FOR 3.2] pwc driver ctrl events + fixes + pac207 exposure fix

2011-10-31 Thread Hans de Goede
in the git repository at: git://linuxtv.org/hgoede/gspca.git media-for_v3.2 Hans de Goede (7): pwc: Add support for control events pwc: properly mark device_hint as unused in all probe error paths pwc: Make auto white balance speed and delay available as v4l2 controls pwc

Re: [PATCH] Increase max exposure value to 255 from 26.

2011-10-31 Thread Hans de Goede
Hi, Thanks for the patch, I've taken a look at this, and the way the pac207's exposure control works is it sets the fps according to the formula of: 90 / exposure reg value. So the old max setting gave you a max exposure time of 90 / 26 = 3.46 fps or 288.9 milliseconds. 3.46 fps already is

Various ctrl and event frame work patches (version 2)

2011-10-31 Thread Hans de Goede
Hi All, This patch set obsoletes my previous add v4l2_subscribed_event_ops set, while working on adding support for ctrl-events to the uvc driver I found a few bugs in the event code, which this patchset fixes. Changes since version 1: -Added a documentation update (update v4l2-framework.txt)

[PATCH 1/6] v4l2-ctrl: Send change events to all fh for auto cluster slave controls

2011-10-31 Thread Hans de Goede
Otherwise the fh changing the master control won't get the inactive state change event for the slave controls. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/v4l2-ctrls.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2

[PATCH 2/6] v4l2-event: Deny subscribing with a type of V4L2_EVENT_ALL

2011-10-31 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/v4l2-event.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2-event.c b/drivers/media/video/v4l2-event.c index 53b190c..9f56f18 100644 --- a/drivers/media/video/v4l2-event.c

[PATCH 3/6] v4l2-event: Remove pending events from fh event queue when unsubscribing

2011-10-31 Thread Hans de Goede
on unsubscription. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/v4l2-event.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2-event.c b/drivers/media/video/v4l2-event.c index 9f56f18..01cbb7f 100644 --- a/drivers

[PATCH 4/6] v4l2-event: Don't set sev-fh to NULL on unsubcribe

2011-10-31 Thread Hans de Goede
of this series, since this op needs a way to get to its own data structures, and typically this will be done by using container_of on an embedded v4l2_fh struct. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/v4l2-event.c |1 - 1 files changed, 0 insertions(+), 1 deletions

[PATCH 5/6] v4l2-event: Add v4l2_subscribed_event_ops

2011-10-31 Thread Hans de Goede
Just like with ctrl events, drivers may want to get called back on listener add / remove for other event types too. Rather then special casing all of this in subscribe / unsubscribe event it is better to use ops for this. Signed-off-by: Hans de Goede hdego...@redhat.com --- Documentation

[PATCH 6/6] v4l2-ctrls: Use v4l2_subscribed_event_ops

2011-10-31 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/ivtv/ivtv-ioctl.c |3 +- drivers/media/video/pwc/pwc-v4l.c |2 +- drivers/media/video/v4l2-ctrls.c | 56 +++-- drivers/media/video/v4l2-event.c | 39

Re: [PATCH 4/6] v4l2-event: Don't set sev-fh to NULL on unsubcribe

2011-10-28 Thread Hans de Goede
Hi, Thanks for the reviews! On 10/27/2011 02:20 PM, Laurent Pinchart wrote: Hi Hans, On Thursday 27 October 2011 13:18:01 Hans de Goede wrote: 1: There is no reason for this after v4l2_event_unsubscribe releases the spinlock nothing is holding a reference to the sev anymore except

Re: [PATCH 5/6] v4l2-event: Add v4l2_subscribed_event_ops

2011-10-28 Thread Hans de Goede
Hi, On 10/27/2011 02:30 PM, Laurent Pinchart wrote: Hi Hans, On Thursday 27 October 2011 13:18:02 Hans de Goede wrote: Just like with ctrl events, drivers may want to get called back on listener add / remove for other event types too. Rather then special casing all of this in subscribe

Various ctrl and event frame work patches

2011-10-27 Thread Hans de Goede
Hi All, This patch set obsoletes my previous add v4l2_subscribed_event_ops set, while working on adding support for ctrl-events to the uvc driver I found a few bugs in the event code, which this patchset fixes. Regards, Hans -- To unsubscribe from this list: send the line unsubscribe

[PATCH 1/6] v4l2-ctrl: Send change events to all fh for auto cluster slave controls

2011-10-27 Thread Hans de Goede
Otherwise the fh changing the master control won't get the inactive state change event for the slave controls. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/v4l2-ctrls.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2

[PATCH 5/6] v4l2-event: Add v4l2_subscribed_event_ops

2011-10-27 Thread Hans de Goede
Just like with ctrl events, drivers may want to get called back on listener add / remove for other event types too. Rather then special casing all of this in subscribe / unsubscribe event it is better to use ops for this. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video

[PATCH 6/6] v4l2-ctrls: Use v4l2_subscribed_event_ops

2011-10-27 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/ivtv/ivtv-ioctl.c |3 +- drivers/media/video/pwc/pwc-v4l.c |2 +- drivers/media/video/v4l2-ctrls.c | 56 +++-- drivers/media/video/v4l2-event.c | 39

uvcvideo: Add support for control events

2011-10-27 Thread Hans de Goede
Hi All, This patch set adds support for control events to the uvcvideo driver. Note this patch set depends on the Various ctrl and event frame work patches set which I just send out. Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message

[PATCH 1/2] uvcvideo: Refactor uvc_ctrl_get and query

2011-10-27 Thread Hans de Goede
This is a preparation patch for adding ctrl event support. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/uvc/uvc_ctrl.c | 62 +--- 1 files changed, 43 insertions(+), 19 deletions(-) diff --git a/drivers/media/video/uvc/uvc_ctrl.c b

[PATCH 2/2] uvcvideo: Add support for control events

2011-10-27 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/uvc/uvc_ctrl.c | 104 drivers/media/video/uvc/uvc_v4l2.c | 51 - drivers/media/video/uvc/uvcvideo.h |9 +++ 3 files changed, 161 insertions(+), 3 deletions(-) diff

Add v4l2_subscribed_event_ops

2011-10-24 Thread Hans de Goede
Hi Hans et all, As discussed at the kernel summit. Note I have only compile tested this as I've no control event capable hardware with me (until I'm done with adding support for ctrl events to the UVC driver). Regards, Hans -- To unsubscribe from this list: send the line unsubscribe

[PATCH 1/3] v4l2-event: Deny subscribing with a type of V4L2_EVENT_ALL

2011-10-24 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/v4l2-event.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/v4l2-event.c b/drivers/media/video/v4l2-event.c index 53b190c..9f56f18 100644 --- a/drivers/media/video/v4l2-event.c

[PATCH 3/3] v4l2-ctrls: Use v4l2_subscribed_event_ops

2011-10-24 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video/ivtv/ivtv-ioctl.c |3 +- drivers/media/video/pwc/pwc-v4l.c |2 +- drivers/media/video/v4l2-ctrls.c | 56 +++-- drivers/media/video/v4l2-event.c | 39

[PATCH 2/3] v4l2-event: Add v4l2_subscribed_event_ops

2011-10-24 Thread Hans de Goede
Just like with ctrl events, drivers may want to get called back on listener add / remove for other event types too. Rather then special casing all of this in subscribe / unsubscribe event it is better to use ops for this. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/media/video

Re: [RFC] Merge v4l-utils. dvb-apps and mediactl to media-utils.git

2011-10-08 Thread Hans de Goede
Hi, On 10/07/2011 03:46 PM, Mauro Carvalho Chehab wrote: Em 07-10-2011 10:05, Hans de Goede escreveu: Hi, On 10/07/2011 03:02 PM, Mauro Carvalho Chehab wrote: Em 07-10-2011 03:05, Hans Verkuil escreveu: On Friday, October 07, 2011 04:07:38 Mauro Carvalho Chehab wrote: Em 06-10-2011 14:24

Re: libv4l2 misbehavior after calling S_STD or S_DV_PRESET

2011-10-07 Thread Hans de Goede
. Regards, Hans From a5abaaa08602b540c88ae4776f557a3b0c34b24d Mon Sep 17 00:00:00 2001 From: Hans de Goede hdego...@redhat.com Date: Fri, 7 Oct 2011 09:18:39 +0200 Subject: [PATCH 1/2] libv4l2: Move s_fmt handling code into a helper function Signed-off-by: Hans de Goede hdego...@redhat.com --- lib

Re: [RFC] Merge v4l-utils. dvb-apps and mediactl to media-utils.git

2011-10-07 Thread Hans de Goede
Hi, On 10/06/2011 02:23 PM, Hans Verkuil wrote: Currently we have three repositories containing libraries and utilities that are relevant to the media drivers: dvb-apps (http://linuxtv.org/hg/dvb-apps/) v4l-utils (http://git.linuxtv.org/v4l-utils.git) media-ctl

Re: libv4l2 misbehavior after calling S_STD or S_DV_PRESET

2011-10-07 Thread Hans de Goede
Hi, On 10/07/2011 11:06 AM, Hans Verkuil wrote: On Friday 07 October 2011 09:57:42 Hans de Goede wrote: Hi, Hmm, nasty... On 10/06/2011 01:13 PM, Hans Verkuil wrote: Hi Hans! I've been looking into a problem with libv4l2 that occurs when you change TV standard or video preset using

Re: [RFC] Merge v4l-utils. dvb-apps and mediactl to media-utils.git

2011-10-07 Thread Hans de Goede
Hi, On 10/07/2011 03:02 PM, Mauro Carvalho Chehab wrote: Em 07-10-2011 03:05, Hans Verkuil escreveu: On Friday, October 07, 2011 04:07:38 Mauro Carvalho Chehab wrote: Em 06-10-2011 14:24, Mauro Carvalho Chehab escreveu: Em 06-10-2011 10:27, Mauro Carvalho Chehab escreveu: Em 06-10-2011

Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-07 Thread Hans de Goede
Hi, Lots of good stuff in this thread! It seems Mauro has answered most things, so I'm just going to respond to this bit. On 09/07/2011 05:37 AM, Devin Heitmueller wrote: Snip We've added a parameter for that on xawtv3 (--alsa-latency). We've parametrized it at the alsa stream function call.

Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-06 Thread Hans de Goede
Hi, On 09/06/2011 06:24 PM, Devin Heitmueller wrote: snip I've been thinking for a while that perhaps the project should be renamed (or I considered prepending kl onto the front resulting in it being called kl-tvtime). This isn't out of vanity but rather my concern that the fork will get

Re: [PATCH 01/10] alsa_stream: port changes made on xawtv3

2011-09-06 Thread Hans de Goede
Hi, On 09/06/2011 08:35 PM, Michael Krufky wrote: On Tue, Sep 6, 2011 at 2:19 PM, Hans de Goedehdego...@redhat.com wrote: Hi, On 09/06/2011 06:24 PM, Devin Heitmueller wrote: snip I've been thinking for a while that perhaps the project should be renamed (or I considered prepending kl onto

Re: [RFCv2 PATCH 0/8] Add V4L2_CTRL_FLAG_VOLATILE and change volatile autocluster handling.

2011-08-27 Thread Hans de Goede
Looks good ACK series. Acked-by: Hans de Goede hdego...@redhat.com On 08/26/2011 02:00 PM, Hans Verkuil wrote: This is the second patch for this. The first is here: http://comments.gmane.org/gmane.linux.drivers.video-input-infrastructure/36650 This second version changes the pwc code

Re: [PATCH] gspca_sn9c20x: device 0c45:62b3: fix status LED

2011-08-27 Thread Hans de Goede
Hi, On 08/22/2011 11:27 PM, Frank Schäfer wrote: Ping ... what happened to this patch ? ;-) I think it has fallen through the cracks. I've added it to my tree for 3.1 / 3.2 (more likely will be 3.2) Regards, Hans Am 01.07.2011 12:19, schrieb Frank Schaefer: gspca_sn9c20x: device

Re: [RFC PATCH] Modify volatile auto cluster handling as per earlier discussions

2011-08-25 Thread Hans de Goede
Hi, First of all thanks for doing this! Overall it looks good, see below for several (small) remarks which I have. On 08/09/2011 06:40 PM, Hans Verkuil wrote: This patch modifies the way autoclusters work when the 'foo' controls are volatile if autofoo is on. E.g.: if autogain is true, then

Re: USB mini-summit at LinuxCon Vancouver

2011-08-12 Thread Hans de Goede
Hi, On 08/11/2011 10:32 PM, Mauro Carvalho Chehab wrote: snip stuff I agree with instead of using the V4L2 device node to access the stored images, it probably makes more sense to use a separate device for that, that will handle a separate set of ioctl's, and just use read() to retrieve the

Re: USB mini-summit at LinuxCon Vancouver

2011-08-12 Thread Hans de Goede
Hi, On 08/11/2011 04:56 PM, Alan Stern wrote: On Thu, 11 Aug 2011, Hans de Goede wrote: The alternative seems to be to define a device-sharing protocol for USB drivers. Kernel drivers would implement a new callback (asking them to give up control of the device), and usbfs would implement new

Re: USB mini-summit at LinuxCon Vancouver

2011-08-11 Thread Hans de Goede
Hi, On 08/11/2011 01:04 AM, Adam Baker wrote: On Tuesday 09 August 2011, Hans de Goede wrote: Hi, On 08/09/2011 10:31 PM, Adam Baker wrote: On Tuesday 09 August 2011, Hans de Goede wrote: snip It has also just occured to me that it might be possible to solve the issues we are facing just

Re: USB mini-summit at LinuxCon Vancouver

2011-08-11 Thread Hans de Goede
Hi, On 08/10/2011 06:09 PM, Alan Stern wrote: On Wed, 10 Aug 2011, Theodore Kilgore wrote: Okay, I didn't realize that the different cameras used different webcam drivers as well as different stillcam drivers. Oh, yes. They are Proprietary devices. And that means what it says. :-) And all

<    1   2   3   4   5   6   7   8   9   10   >