_device in the system.
It also facilitates other implementations of different nodes without
touching the core code and remove the need of a header file for each
type of node.
Signed-off-by: Helen Koike
---
Changes in v4:
[media] vimc: Subdevices as modules
- Rebase without [media] vimc
Allow user space to change the image format as the frame size, the
media bus pixel format, colorspace, quantization, field YCbCr encoding
and the transfer function
Signed-off-by: Helen Koike
---
Changes in v4:
[media] vimc: sen: Support several image formats
- use
- remove vsd struct
- add IS_SRC and IS_SINK macros
- add sca_mult as a parameter of the module
- check set_fmt default parameters for quantization, colorspace ...
- add more dev_dbg
Helen Koike (11):
[media] vimc: sen: Integrate the tpg on the sensor
[m
Hi Hans,
On 2017-06-13 03:49 AM, Hans Verkuil wrote:
On 06/12/2017 10:35 PM, Helen Koike wrote:
Hi Hans,
Thank you for your review. Please check my comments below
On 2017-06-12 07:37 AM, Hans Verkuil wrote:
On 06/03/2017 04:58 AM, Helen Koike wrote:
+static struct component_match
Hi Hans,
Thank you for your review. Please check my comments below
On 2017-06-12 07:37 AM, Hans Verkuil wrote:
On 06/03/2017 04:58 AM, Helen Koike wrote:
Change the core structure for adding subdevices in the topology.
Instead of calling the specific create function for each subdevice,
inject
Hi Hans,
Thank you for your review
On 2017-06-12 07:03 AM, Hans Verkuil wrote:
On 06/03/2017 04:58 AM, Helen Koike wrote:
Add a parameter called vsen_tpg, if true then vimc will work as before:
frames will be generated in the sensor nodes then propagated through the
pipe and processed by each
Hi Hans,
Thanks for your review, just a question below
On 2017-06-12 06:50 AM, Hans Verkuil wrote:
On 06/03/2017 04:58 AM, Helen Koike wrote:
All links will be checked in the same way. Adding a helper function for
that
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: common
colorspace, ycbcr_enc, quantization and xfer_func must match
across the link.
Check if they match in v4l2_subdev_link_validate_default
unless they are set as _DEFAULT.
Signed-off-by: Helen Koike
---
Hi,
As discussed previously, I added a warn message instead of returning
error to give drivers
Hi
On 2017-06-08 08:41 AM, Mauro Carvalho Chehab wrote:
Em Tue, 6 Jun 2017 19:15:34 -0300
Helen Koike escreveu:
Hi Sakari,
Thanks for replying
On 2017-05-31 03:31 AM, Sakari Ailus wrote:
Hi Helen,
On Tue, May 30, 2017 at 04:08:08PM -0300, Helen Koike wrote:
colorspace, ycbcr_enc
Hi Sakari,
Thanks for replying
On 2017-05-31 03:31 AM, Sakari Ailus wrote:
Hi Helen,
On Tue, May 30, 2017 at 04:08:08PM -0300, Helen Koike wrote:
colorspace, ycbcr_enc, quantization and xfer_func must match across the
link.
Check if they match in v4l2_subdev_link_validate_default unless
Hi All,
Just reviving this discussion
On 2017-04-07 06:53 AM, Laurent Pinchart wrote:
Hi Hans,
On Friday 07 Apr 2017 11:46:48 Hans Verkuil wrote:
On 04/04/2017 03:22 PM, Sakari Ailus wrote:
On Mon, Apr 03, 2017 at 12:11:54PM -0300, Helen Koike wrote:
On 2017-03-31 06:57 AM, Mauro Carvalho
On 2017-06-02 11:58 PM, Helen Koike wrote:
Add a parameter called vsen_tpg, if true then vimc will work as before:
frames will be generated in the sensor nodes then propagated through the
pipe and processed by each node until a capture node is reached.
If vsen_tpg is false, then the frame is
I forgot to mention that this patch series is also available here
https://github.com/helen-fornazier/opw-staging/tree/z/sent/vimc/vpu/v3
On 2017-06-02 11:58 PM, Helen Koike wrote:
This patch series improves the current video processing units in vimc
(by adding more controls to the sensor and
ping
On 2017-04-10 07:53 PM, Helen Koike wrote:
Hi,
Continuing the discussion about the API of the vimc driver, I made some
changes
based on the previous comments, please see below and let me know your
opinion about it.
Helen
/***
Configfs considerations
Move the vimc_cap_pipeline_s_stream from the vimc-cap.c to vimc-common.c
as this core will be reused by other subdevices to activate the stream
in their directly connected nodes
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: Add vimc_pipeline_s_stream in the core
- add it
As all the subdevices in the topology will be initialized in the same
way, to avoid code repetition the vimc_ent_sd_{register, unregister}
helper functions were created
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: Add vimc_ent_sd_* helper functions
- add it in vimc
Initialize the test pattern generator on the sensor
Generate a colored bar image instead of a grey one
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: sen: Integrate the tpg on the sensor
- Declare frame_size as a local variable
- Set tpg frame format before
Remove helper functions from vimc-core and add it in vimc-common to
clean up the core.
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: Move common code from the core
- This is a new patch in the series
Changes in v2: None
---
drivers/media/platform/vimc/Makefile
Allow user space to change the image format as the frame size, the
media bus pixel format, colorspace, quantization, field YCbCr encoding
and the transfer function
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: sen: Support several image formats
- remove support for
Allow user space to change the image format as the frame size, the
pixel format, colorspace, quantization, field YCbCr encoding
and the transfer function
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: cap: Support several image formats
- use *_DEFAULT macros for
the capture node, thus saving intermediate memory buffers
and process time, allowing a higher frame rate.
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: Optimize frame generation through the pipe
- This is a new patch in the series
Changes in v2: None
---
drivers/media
Implement scaler and integrated with the core
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: sca: Add scaler
- Declare frame_size as a local variable
- s_stream(sd, 1): return 0 if stream is already enabled
- s_stream(sd, 0): return 0 if stream is already
Implement the debayer filter and integrate it with the core
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: deb: Add debayer filter
- Declare frame_size as a local variable
- s_stream(sd, 1): return 0 if stream is already enabled
- s_stream(sd, 0): return 0
_device in the system.
It also facilitates other implementations of different nodes without
touching the core code and remove the need of a header file for each
type of node.
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: Subdevices as modules
- This is a new patch in the serie
All links will be checked in the same way. Adding a helper function for
that
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: common: Add vimc_link_validate
- this is a new patch in the series
Changes in v2: None
---
drivers/media/platform/vimc/vimc-capture.c | 78
default parameters for quantization, colorspace ...
- add more dev_dbg
Helen Koike (11):
[media] vimc: sen: Integrate the tpg on the sensor
[media] vimc: Move common code from the core
[media] vimc: common: Add vimc_ent_sd_* helper
[media] vimc: common: Add vimc_pipeline_s_stream helper
colorspace, ycbcr_enc, quantization and xfer_func must match across the
link.
Check if they match in v4l2_subdev_link_validate_default unless they are
set as _DEFAULT.
Signed-off-by: Helen Koike
---
Hi,
I think we should validate colorimetry as having different colorimetry
across a link
Hi Hans,
Thank you for your review. I just have a question for this one.
On 2017-05-08 08:53 AM, Hans Verkuil wrote:
On 04/08/2017 12:37 AM, Helen Koike wrote:
Allow user space to change the image format as the frame size, the
pixel format, colorspace, quantization, field YCbCr encoding
and
Hi,
On 2017-04-12 08:00 AM, Milan Čížek wrote:
How to remove your product from my kernel? I tried make rmmod
rminstall but this message stills in my syslog.
Sorry for question, I'm linux newbie.
[ 15.753993] WARNING: You are using an experimental version of the
media stack.
As
Hi,
Continuing the discussion about the API of the vimc driver, I made some
changes
based on the previous comments, please see below and let me know your
opinion about it.
Helen
/***
Configfs considerations:
/
Informal definitions:
subsyst
Allow user space to change the image format as the frame size, the
pixel format, colorspace, quantization, field YCbCr encoding
and the transfer function
Signed-off-by: Helen Koike
---
Changes in v2:
[media] vimc: cap: Support several image formats
- this is a new commit in the serie
Implement scaler and integrated with the core
Signed-off-by: Helen Koike
---
Changes in v2:
[media] vimc: sca: Add scaler
- Add function MEDIA_ENT_F_IO_V4L
- remove v4l2_dev and dev
- s/sink_mbus_fmt/sink_fmt
- remove BUG_ON, remove redundant if else, rewrite
Implement the debayer filter and integrate it with the core
Signed-off-by: Helen Koike
---
Changes in v2:
[media] vimc: deb: Add debayer filter
- Using MEDIA_ENT_F_ATV_DECODER in function
- remove v4l2_dev and dev from vimc_deb_device struct
- src fmt propagates from
As all the subdevices in the topology will be initialized in the same
way, to avoid code repetition the vimc_ent_sd_{register, unregister}
helper functions were created
Signed-off-by: Helen Koike
---
Changes in v2:
[media] vimc: Add vimc_ent_sd_* helper functions
- Comments in
heck pad types on create
- return EBUSY when trying to set the format while stream is on
- remove vsd struct
- add IS_SRC and IS_SINK macros
- add sca_mult as a parameter of the module
- check set_fmt default parameters for quantization, colorspace ...
- add more
Initialize the test pattern generator on the sensor
Generate a colored bar image instead of a grey one
Signed-off-by: Helen Koike
---
Changes in v2:
[media] vimc: sen: Integrate the tpg on the sensor
- Fix include location
- Select V4L2_TPG in Kconfig
- configure tpg on
Allow user space to change the image format as the frame size, the
media bus pixel format, colorspace, quantization, field YCbCr encoding
and the transfer function
Signed-off-by: Helen Koike
---
Changes in v2:
[media] vimc: sen: Support several image formats
- this is a new commit in
Move the vimc_cap_pipeline_s_stream from the vimc-cap.c to vimc-core.c
as this core will be reused by other subdevices to activate the stream
in their directly connected nodes
Signed-off-by: Helen Koike
---
Changes in v2:
[media] vimc: Add vimc_pipeline_s_stream in the core
- Use
First version of the Virtual Media Controller.
Add a simple version of the core of the driver, the capture and
sensor nodes in the topology, generating a grey image in a hardcoded
format.
Signed-off-by: Helen Koike
Reviewed-by: Hans Verkuil
---
Patch based in media/master tree, and available
Hi Sakari,
On 2017-04-07 04:40 AM, Sakari Ailus wrote:
Hi Helen,
On Thu, Apr 06, 2017 at 04:32:00PM -0300, Helen Koike wrote:
Fix kernel Oops NULL pointer deference
Call dev_dbg_obj only after checking if gobj->mdev is not NULL
Signed-off-by: Helen Koike
---
drivers/media/media-entit
Fix kernel Oops NULL pointer deference
Call dev_dbg_obj only after checking if gobj->mdev is not NULL
Signed-off-by: Helen Koike
---
drivers/media/media-entity.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/media-entity.c b/drivers/media/media-entit
Fix kernel Oops NULL pointer deference
Call dev_dbg_obj only after checking if gobj->mdev is not NULL
Signed-off-by: Helen Koike
---
drivers/media/media-entity.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/media-entity.c b/drivers/media/media-entit
Hi,
There are two points below that I'll change in v10. I'll wait for your
comments in the rest of the code so I can send all the requested changes
in v10
On 2017-04-03 07:16 PM, Helen Koike wrote:
First version of the Virtual Media Controller.
Add a simple version of the core of
First version of the Virtual Media Controller.
Add a simple version of the core of the driver, the capture and
sensor nodes in the topology, generating a grey image in a hardcoded
format.
Signed-off-by: Helen Koike
---
Patch based in media/master tree, and available here:
https://github.com
Hi,
On 2017-03-31 06:57 AM, Mauro Carvalho Chehab wrote:
Em Fri, 31 Mar 2017 10:29:04 +0200
Hans Verkuil escreveu:
On 30/03/17 18:02, Helen Koike wrote:
Add V4L2_INPUT_TYPE_DEFAULT and helpers functions for input ioctls to be
used when no inputs are available in the device
Signed-off-by
On 2017-03-30 11:39 PM, Helen Koike wrote:
Hi Laurent,
Thanks for reviewing
On 2017-03-30 04:56 PM, Laurent Pinchart wrote:
Hi Helen,
Thank you for the patch.
On Thursday 30 Mar 2017 13:02:17 Helen Koike wrote:
Add V4L2_INPUT_TYPE_DEFAULT and helpers functions for input ioctls to be
used
Hi Laurent,
Thanks for reviewing
On 2017-03-30 04:56 PM, Laurent Pinchart wrote:
Hi Helen,
Thank you for the patch.
On Thursday 30 Mar 2017 13:02:17 Helen Koike wrote:
Add V4L2_INPUT_TYPE_DEFAULT and helpers functions for input ioctls to be
used when no inputs are available in the device
add documentation for V4L2_INPUT_TYPE_DEFAULT
Signed-off-by: Helen Koike
---
Documentation/media/uapi/v4l/vidioc-enuminput.rst | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/media/uapi/v4l/vidioc-enuminput.rst
b/Documentation/media/uapi/v4l/vidioc-enuminput.rst
index
Add V4L2_INPUT_TYPE_DEFAULT and helpers functions for input ioctls to be
used when no inputs are available in the device
Signed-off-by: Helen Koike
---
drivers/media/v4l2-core/v4l2-ioctl.c | 27 +++
include/media/v4l2-ioctl.h | 26
Hi Sakari,
On 2017-03-26 10:31 AM, Sakari Ailus wrote:
Hi Helen,
...
+static int vimc_cap_enum_input(struct file *file, void *priv,
+ struct v4l2_input *i)
+{
+ /* We only have one input */
+ if (i->index > 0)
+ return -EINVAL;
+
+ i
First version of the Virtual Media Controller.
Add a simple version of the core of the driver, the capture and
sensor nodes in the topology, generating a grey image in a hardcoded
format.
Signed-off-by: Helen Koike
---
Patch based in media/master tree, and available here:
https://github.com
On 2017-03-25 02:11 PM, Helen Koike wrote:
First version of the Virtual Media Controller.
Add a simple version of the core of the driver, the capture and
sensor nodes in the topology, generating a grey image in a hardcoded
format.
Signed-off-by: Helen Koike
---
Patch based in media/master
First version of the Virtual Media Controller.
Add a simple version of the core of the driver, the capture and
sensor nodes in the topology, generating a grey image in a hardcoded
format.
Signed-off-by: Helen Koike
---
Patch based in media/master tree, and available here:
https://github.com
Hi Sakari,
Thanks for your review, I have some questions below:
On 2017-01-25 11:03 AM, Sakari Ailus wrote:
Hi Helen,
My apologies for the long review time!
Please see my comments below.
On Sun, Sep 04, 2016 at 05:02:18PM -0300, Helen Koike wrote:
From: Helen Fornazier
First version of
Hi Hans,
On 2017-03-10 10:08 AM, Hans Verkuil wrote:
Hi Helen,
On 11/01/17 02:30, Helen Koike wrote:
>
> Thank you for the review, I'll update the patch accordingly and re-submit it.
>
> Helen
Do you know when you have a v7 ready?
Thanks for your interest. I don't
Hi Laurent,
On 2017-01-10 04:54 PM, Laurent Pinchart wrote:
Hi Helen,
(CC'ing Sakari as there's a question specifically for him)
Thank you for the patch, and so sorry for the late review.
On Sunday 04 Sep 2016 17:02:18 Helen Koike wrote:
From: Helen Fornazier
First version of t
The format was only being propagated to the subdevices directly
connected to the node being changed.
Continue propagating the format to all the subdevices in the video pipe.
Signed-off-by: Helen Koike
---
Only one level of propagation was not that useful for me so I made it to
completely
Signed-off-by: Helen Koike
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0a16a82..43e0eb4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12540,6 +12540,14 @@ W: https://linuxtv.org
S: Maintained
F: drivers/media/platform
18/2016 12:09 AM, Helen Koike wrote:
From: Helen Fornazier
First version of the Virtual Media Controller.
Add a simple version of the core of the driver, the capture and
sensor nodes in the topology, generating a grey image in a hardcoded
format.
Signed-off-by: Helen Koike
+
From: Helen Fornazier
First version of the Virtual Media Controller.
Add a simple version of the core of the driver, the capture and
sensor nodes in the topology, generating a grey image in a hardcoded
format.
Signed-off-by: Helen Koike
---
Patch based in media/master tree, and available
From: Helen Fornazier
First version of the Virtual Media Controller.
Add a simple version of the core of the driver, the capture and
sensor nodes in the topology, generating a grey image in a hardcoded
format.
Signed-off-by: Helen Koike
---
Patch based in media/master tree, and available
Hi Hans
On 01-07-2016 09:39, Hans Verkuil wrote:
Hi Helen,
Better late than never, but I finally have time for a review, mostly with a eye
for V4L2 issues.
Thank you for your review, I'll incorporate your suggestions in v5.
I am also preparing a patch series that integrates the tpg and have
From: Helen Fornazier
First version of the Virtual Media Controller.
Add a simple version of the core of the driver, the capture and
sensor nodes in the topology, generating a grey image in a hardcoded
format.
Signed-off-by: Helen Fornazier
---
Changes since v3: fix rmmod crash and built-in co
Hi Jeremy,
On 24-05-2016 21:00, Jeremy Gebben wrote:
Helen,
I am more of a v4l2 newb than a reviewer, but I got your driver working
on a qemu arm64 system. Using it to play with mediactl -p was
a good way to get started.
I did have 2 minor include path problems. Maybe they come in implicitly
o
If *nplanes is not zero, it should use the requested size if valid
Signed-off-by: Helen Koike
---
drivers/media/usb/stk1160/stk1160-v4l.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/usb/stk1160/stk1160-v4l.c
b/drivers/media/usb/stk1160/stk1160-v4l.c
index 77131fd
In case of failure, print "q.create_bufs(node, 1, &fmt) != EINVAL" instead
of "ret != EINVAL"
Signed-off-by: Helen Koike
---
Hello,
I was wondering, why the q.create_bufs is expected to should return EINVAL in
this test? The height and size are set to half of the
Hi Mauro,
Please pull the following patches correcting the returned error codes
and respective docs in the pipeline validation.
Regards,
Helen
The following changes since commit 45c175c4ae9695d6d2f30a45ab7f3866cfac184b:
[media] tw686x: avoid going past array (2016-04-26 06:38:53 -0300)
ar
Hi
On 01/04/2016 15:22, Mauro Carvalho Chehab wrote:
Hi Helen,
This is just a quick look on it. See below.
Em Fri, 1 Apr 2016 14:18:13 -0300
Helen Mae Koike Fornazier escreveu:
The test pattern generator will be used by other drivers as the virtual
media controller (vimc)
Signed-off-by: He
101 - 168 of 168 matches
Mail list logo