Re: [PATCH] media: xilinx-video: fix bad of_node_put() on endpoint error

2018-11-07 Thread Hyun Kwon
: Switch to > v4l2_async_notifier_add_subdev") > Cc: Steve Longerbeam > Cc: Hyun Kwon > Cc: Laurent Pinchart > Cc: Mauro Carvalho Chehab > Signed-off-by: Akinobu Mita This looks good to me, Reviewed-by: Hyun Kwon Thanks, -hyun > --- > drivers/media/platfo

Re: [PATCH v5 0/8] Add support for multi-planar formats and 10 bit formats

2018-05-08 Thread Hyun Kwon
Hi Hans, On Tue, 2018-05-08 at 00:57:25 -0700, Hans Verkuil wrote: > On 05/07/2018 07:45 PM, Hyun Kwon wrote: > > Hi Hans, > > > > Thanks for the comment. > > > > On Mon, 2018-05-07 at 05:59:39 -0700, Hans Verkuil wrote: > >> Hi Satish, > >> &

Re: [PATCH v5 0/8] Add support for multi-planar formats and 10 bit formats

2018-05-07 Thread Hyun Kwon
Hi Hans, Thanks for the comment. On Mon, 2018-05-07 at 05:59:39 -0700, Hans Verkuil wrote: > Hi Satish, > > On 03/05/18 04:42, Satish Kumar Nagireddy wrote: > > The patches are for xilinx v4l. The patcheset enable support to handle > > multiplanar > > formats and 10 bit formats. Single

Re: [PATCH v4 10/10] v4l: xilinx: dma: Add support for 10 bit formats

2018-05-01 Thread Hyun Kwon
Hi Satish, Thanks for that patch. On Mon, 2018-04-30 at 18:35:13 -0700, Satish Kumar Nagireddy wrote: > This patch adds xvip_format_plane_width_bytes function to > calculate number of bytes for a macropixel formats and also > adds new 10 bit pixel formats to video descriptor table. > >

Re: [PATCH v4 09/10] v4l: xilinx: dma: Add multi-planar support

2018-05-01 Thread Hyun Kwon
On Mon, 2018-04-30 at 18:35:12 -0700, Satish Kumar Nagireddy wrote: > The current v4l driver supports single plane formats. This patch > adds support to handle multi-planar formats. Driver can handle > both single and multi-planar formats. > > Signed-off-by: Satish Kumar Nagireddy

Re: [PATCH v4 08/10] v4l: xilinx: dma: Update video format descriptor

2018-05-01 Thread Hyun Kwon
Hi Satish, Thanks for the patch. On Mon, 2018-04-30 at 18:35:11 -0700, Satish Kumar Nagireddy wrote: > This patch updates video format descriptor to help information > viz., number of planes per color format and chroma sub sampling > factors. > > Signed-off-by: Satish Kumar Nagireddy

Re: [PATCH v4 07/10] media: Add new dt-bindings/vf_codes for supported formats

2018-05-01 Thread Hyun Kwon
On Mon, 2018-04-30 at 18:35:10 -0700, Satish Kumar Nagireddy wrote: > From: Rohit Athavale > > This commit adds new entries to the exisiting vf_codes that are used > to describe the media bus formats in the DT bindings. The newly added > 8-bit and 10-bit color depth related

Re: [PATCH v4 05/10] uapi: media: New fourcc codes needed by Xilinx Video IP

2018-05-01 Thread Hyun Kwon
Hi Satish, Thanks for the patch. On Mon, 2018-04-30 at 18:35:08 -0700, Satish Kumar Nagireddy wrote: > From: Jeffrey Mouroux > > The Xilinx Video Framebuffer DMA IP supports video memory formats > that are not represented in the current V4L2 fourcc library. This > patch

Re: [PATCH v4 02/10] xilinx: v4l: dma: Use the dmaengine_terminate_all() wrapper

2018-05-01 Thread Hyun Kwon
Hi Satish, Thanks for the patch. On Mon, 2018-04-30 at 18:35:05 -0700, Satish Kumar Nagireddy wrote: > From: Laurent Pinchart > > Calling dmaengine_device_control() to terminate transfers is an internal > API that will disappear, use the stable API wrapper

Re: [PATCH v3 9/9] v4l: xilinx: dma: Get scaling and padding factor to calculate DMA params

2018-02-16 Thread Hyun Kwon
Hi Satish, Thanks for that patch. On Wed, 2018-02-14 at 22:43:00 -0800, Satish Kumar Nagireddy wrote: > Get multiplying factor to calculate bpp especially > in case of 10 bit formats. > Get multiplying factor to calculate padding width > > Signed-off-by: Satish Kumar Nagireddy

Re: [PATCH v3 8/9] v4l: xilinx: dma: Add scaling and padding factor functions

2018-02-16 Thread Hyun Kwon
Hi Satish, Thanks for the patch. On Wed, 2018-02-14 at 22:42:50 -0800, Satish Kumar Nagireddy wrote: > scaling_factor function returns multiplying factor to calculate > bytes per component based on color format. > For eg. scaling factor of YUV420 8 bit format is 1 > so multiplying factor is 1

Re: [PATCH v3 7/9] v4l: xilinx: dma: Add multi-planar support

2018-02-16 Thread Hyun Kwon
Hi Satish, Thanks for the patch. On Wed, 2018-02-14 at 22:42:43 -0800, Satish Kumar Nagireddy wrote: > The current v4l driver supports single plane formats. This patch > will add support to handle multi-planar formats. Updated driver > capabilities to multi-planar, where it can handle both

Re: [PATCH v3 6/9] v4l: xilinx: dma: Update video format descriptor

2018-02-16 Thread Hyun Kwon
On Wed, 2018-02-14 at 22:42:36 -0800, Satish Kumar Nagireddy wrote: > This patch updates video format descriptor to help information > viz., number of planes per color format and chroma sub sampling > factors. > > This commit adds the various 8-bit and 10-bit that are supported > to the table

Re: [PATCH v3 5/9] [media] Add documentation for YUV420 bus format

2018-02-16 Thread Hyun Kwon
Hi Satish, Thanks for the patch. On Wed, 2018-02-14 at 22:42:28 -0800, Satish Kumar Nagireddy wrote: > The code is MEDIA_BUS_FMT_VYYUYY8_1X24 > > Signed-off-by: Satish Kumar Nagireddy > --- > Documentation/media/uapi/v4l/subdev-formats.rst | 34 >

Re: [PATCH v3 3/9] uapi: media: New fourcc codes needed by Xilinx Video IP

2018-02-16 Thread Hyun Kwon
Hi Satish, Thanks for the patch. On Wed, 2018-02-14 at 22:42:11 -0800, Satish Kumar Nagireddy wrote: > From: Jeffrey Mouroux > > The Xilinx Video Framebuffer DMA IP supports video memory formats > that are not represented in the current V4L2 fourcc library. This > patch

RE: [PATCH v2 3/8] media: v4l2-async: simplify v4l2_async_subdev structure

2017-12-19 Thread Hyun Kwon
.@kernel.org>; Todor Tomov <todor.to...@linaro.org>; > Niklas Söderlund <niklas.soderl...@ragnatech.se>; Ramesh > Shanmugasundaram <ramesh.shanmugasunda...@bp.renesas.com>; > Guennadi Liakhovetski <g.liakhovet...@gmx.de>; Maxime Coquelin > <mcoquelin.st...@gm

RE: [patch] [media] v4l: xilinx: missing error code

2015-06-24 Thread Hyun Kwon
Hi Dan, Thanks for the patch. -Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Wednesday, June 24, 2015 7:29 AM To: Hyun Kwon Cc: Laurent Pinchart; Mauro Carvalho Chehab; Michal Simek; Soren Brinkmann; linux-media@vger.kernel.org; kernel-janit