[PATCH/RFC v9 14/19] media: Add registration helpers for V4L2 flash sub-devices

2014-12-03 Thread Jacek Anaszewski
will be used. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Sakari Ailus sakari.ai...@iki.fi Cc: Hans Verkuil hans.verk...@cisco.com --- drivers/media/v4l2-core/Kconfig | 11 + drivers/media/v4l2-core/Makefile |2 + drivers/media

[PATCH/RFC v9 15/19] Documentation: leds: Add description of v4l2-flash sub-device

2014-12-03 Thread Jacek Anaszewski
This patch extends LED Flash class documention by the description of interactions with v4l2-flash sub-device. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Sakari Ailus sakari.ai...@linux.intel.com Cc: Bryan Wu coolo

[PATCH/RFC v9 07/19] dt-binding: mfd: max77693: Add DT binding related macros

2014-12-03 Thread Jacek Anaszewski
Add macros for max77693 led part related binding. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Lee Jones lee.jo...@linaro.org Cc: Chanwoo Choi cw00.c...@samsung.com --- include/dt-bindings/mfd/max77693.h | 38

[PATCH/RFC v9 16/19] exynos4-is: Add support for v4l2-flash subdevs

2014-12-03 Thread Jacek Anaszewski
This patch adds suppport for external v4l2-flash devices. The support includes parsing camera-flash DT property and asynchronous subdevice registration. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Sylwester Nawrocki s.nawro

[PATCH/RFC v9 13/19] v4l2-ctrls: Add V4L2_CID_FLASH_SYNC_STROBE control

2014-12-03 Thread Jacek Anaszewski
Add V4L2_CID_FLASH_SYNC_STROBE control for determining whether a flash device strobe has to be synchronized with other flash leds controller by the same device. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Sakari Ailus sakari.ai

[PATCH/RFC v9 10/19] DT: Add documentation for the Skyworks AAT1290

2014-12-03 Thread Jacek Anaszewski
This patch adds device tree binding documentation for 1.5A Step-Up Current Regulator for Flash LEDs. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net Cc: Rob Herring robh

[PATCH/RFC v9 05/19] leds: Add support for max77693 mfd flash cell

2014-12-03 Thread Jacek Anaszewski
This patch adds led-flash support to Maxim max77693 chipset. A device can be exposed to user space through LED subsystem sysfs interface. Device supports up to two leds which can work in flash and torch mode. The leds can be triggered externally or by software. Signed-off-by: Jacek Anaszewski

[PATCH/RFC v9 08/19] leds: Add driver for AAT1290 current regulator

2014-12-03 Thread Jacek Anaszewski
This patch adds a driver for the 1.5A Step-Up Current Regulator for Flash LEDs. The device is programmed through a Skyworks proprietary AS2Cwire serial digital interface. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo

[PATCH/RFC v9 12/19] v4l2-async: add V4L2_ASYNC_MATCH_CUSTOM_OF matching type

2014-12-03 Thread Jacek Anaszewski
V4L2_ASYNC_MATCH_CUSTOM_OF matching type to declare this type of matching. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com Cc: Hans Verkuil

[PATCH/RFC v9 02/19] Documentation: leds: Add description of LED Flash class extension

2014-12-03 Thread Jacek Anaszewski
The documentation being added contains overall description of the LED Flash Class and the related sysfs attributes. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net

[PATCH/RFC v9 00/19] LED / flash API integration

2014-12-03 Thread Jacek Anaszewski
facilities from the LED Flash Class and provided external_strobe_set op in v4l2-flash. LED subsystem should be strobe provider agnostic. Thanks, Jacek Anaszewski Jacek Anaszewski (19): leds: Add LED Flash class extension to the LED subsystem Documentation: leds: Add description of LED

[PATCH/RFC v9 01/19] leds: Add LED Flash class extension to the LED subsystem

2014-12-03 Thread Jacek Anaszewski
. The design assumes that V4L2 sub-device can take of the LED class device control and communicate with it through the kernel internal interface. When V4L2 Flash sub-device file is opened, the LED class device sysfs interface is made unavailable. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com

Re: [PATCH/RFC v8 04/14] v4l2-async: change custom.match callback argument type

2014-12-01 Thread Jacek Anaszewski
Hi Laurent, On 11/29/2014 05:38 PM, Laurent Pinchart wrote: Hi Jacek, Thank you for the patch. On Friday 28 November 2014 10:17:56 Jacek Anaszewski wrote: It is useful to have an access to the async sub-device being matched, not only to the related struct device. Change match callback

Re: [PATCH/RFC v4 05/11] mediactl: Add media device graph helpers

2014-12-01 Thread Jacek Anaszewski
Hi Sakari, Thanks for a review. On 11/28/2014 06:06 PM, Sakari Ailus wrote: Hi Jacek, On Fri, Nov 21, 2014 at 05:14:34PM +0100, Jacek Anaszewski wrote: Add new graph helpers useful for video pipeline discovering. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin

Re: [PATCH/RFC v8 02/14] Documentation: leds: Add description of LED Flash class extension

2014-12-01 Thread Jacek Anaszewski
fault modes in future... Faults are cleared by reading the attribute. I will add this note. There can be more than one fault at a time. I think that the bitmask is a flexible solution. I don't see any troubles related to adding new fault modes in the future, do you? Best Regards, Jacek Anaszewski

Re: [PATCH/RFC v8 12/14] leds: Add driver for AAT1290 current regulator

2014-12-01 Thread Jacek Anaszewski
Hi Pavel, Thanks for a review. On 11/29/2014 08:05 PM, Pavel Machek wrote: Hi! @@ -0,0 +1,472 @@ +/* + * LED Flash class driver for the AAT1290 + * 1.5A Step-Up Current Regulator for Flash LEDs + * + * Copyright (C) 2014, Samsung Electronics Co., Ltd. + * Author: Jacek

Re: [PATCH/RFC v8 09/14] mfd: max77693: adjust max77693_led_platform_data

2014-12-01 Thread Jacek Anaszewski
Hi Lee, Thanks for the review. On 12/01/2014 12:34 PM, Lee Jones wrote: On Fri, 28 Nov 2014, Jacek Anaszewski wrote: Add label array for Device Tree strings with the name of a LED device and make flash_timeout a two element array, for caching the sub-led related flash timeout

Re: [PATCH/RFC v8 11/14] DT: Add documentation for the mfd Maxim max77693

2014-12-01 Thread Jacek Anaszewski
in the binding. Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH/RFC v8 11/14] DT: Add documentation for the mfd Maxim max77693

2014-12-01 Thread Jacek Anaszewski
Hi Pavel, On 12/01/2014 02:02 PM, Pavel Machek wrote: Hi! Is this one needed? Just ommit child note if it is not there. It is needed because you can have one led connected two both outputs. This allows to describe such a design. Ok. +- maxim,trigger-type : Array of trigger types in

Re: [PATCH/RFC v8 02/14] Documentation: leds: Add description of LED Flash class extension

2014-12-01 Thread Jacek Anaszewski
codes. Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH/RFC v4 05/11] mediactl: Add media device graph helpers

2014-12-01 Thread Jacek Anaszewski
Hi Sakari, On 12/01/2014 01:30 PM, Sakari Ailus wrote: Hi Jacek, Jacek Anaszewski wrote: ... +int media_get_busy_pads_by_entity(struct media_device *media, +struct media_entity *entity, +unsigned int type, +struct media_pad **busy_pads

Re: [PATCH/RFC v8 06/14] media: Add registration helpers for V4L2 flash sub-devices

2014-12-01 Thread Jacek Anaszewski
On 11/28/2014 10:17 AM, Jacek Anaszewski wrote: This patch adds helper functions for registering/unregistering LED Flash class devices as V4L2 sub-devices. The functions should be called from the LED subsystem device driver. In case the support for V4L2 Flash sub-devices is disabled

[PATCH/RFC v8 13/14] of: Add Skyworks Solutions, Inc. vendor prefix

2014-11-28 Thread Jacek Anaszewski
Use skyworks as the vendor prefix for the Skyworks Solutions, Inc. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m...@arm.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Ian Campbell

[PATCH/RFC v8 14/14] DT: Add documentation for the Skyworks AAT1290

2014-11-28 Thread Jacek Anaszewski
This patch adds device tree binding documentation for 1.5A Step-Up Current Regulator for Flash LEDs. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net Cc: Rob Herring robh

[PATCH/RFC v8 12/14] leds: Add driver for AAT1290 current regulator

2014-11-28 Thread Jacek Anaszewski
This patch adds a driver for the 1.5A Step-Up Current Regulator for Flash LEDs. The device is programmed through a Skyworks proprietary AS2Cwire serial digital interface. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo

[PATCH/RFC v8 09/14] mfd: max77693: adjust max77693_led_platform_data

2014-11-28 Thread Jacek Anaszewski
Add label array for Device Tree strings with the name of a LED device and make flash_timeout a two element array, for caching the sub-led related flash timeout. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Signed-off-by: Andrzej Hajda a.ha...@samsung.com Acked-by: Kyungmin Park

[PATCH/RFC v8 10/14] leds: Add support for max77693 mfd flash cell

2014-11-28 Thread Jacek Anaszewski
. The leds can be triggered externally or by software. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Signed-off-by: Andrzej Hajda a.ha...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Lee Jones lee.jo...@linaro.org Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur

[PATCH/RFC v8 11/14] DT: Add documentation for the mfd Maxim max77693

2014-11-28 Thread Jacek Anaszewski
This patch adds device tree binding documentation for the flash cell of the Maxim max77693 multifunctional device. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Signed-off-by: Andrzej Hajda a.ha...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Lee Jones lee.jo

[PATCH/RFC v8 08/14] DT: Add documentation for exynos4-is 'flashes' property

2014-11-28 Thread Jacek Anaszewski
This patch adds a description of 'flashes' property to the samsung-fimc.txt. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Sylwester Nawrocki s.nawro...@samsung.com Cc: Rob Herring robh...@kernel.org Cc: Pawel Moll pawel.m

[PATCH/RFC v8 07/14] exynos4-is: Add support for v4l2-flash subdevs

2014-11-28 Thread Jacek Anaszewski
This patch adds suppport for external v4l2-flash devices. The support includes parsing flashes Device Tree property and asynchronous subdevice registration. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Sylwester Nawrocki s.nawro

[PATCH/RFC v8 04/14] v4l2-async: change custom.match callback argument type

2014-11-28 Thread Jacek Anaszewski
It is useful to have an access to the async sub-device being matched, not only to the related struct device. Change match callback argument from struct device to struct v4l2_subdev. It will allow e.g. for matching a sub-device by its name property. Signed-off-by: Jacek Anaszewski j.anaszew

[PATCH/RFC v8 05/14] v4l2-ctrls: Add V4L2_CID_FLASH_SYNC_STROBE control

2014-11-28 Thread Jacek Anaszewski
Add V4L2_CID_FLASH_SYNC_STROBE control for determining whether a flash device strobe has to be synchronized with other flash leds controller by the same device. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Sakari Ailus sakari.ai

[PATCH/RFC v8 06/14] media: Add registration helpers for V4L2 flash sub-devices

2014-11-28 Thread Jacek Anaszewski
will be used. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Sakari Ailus sakari.ai...@iki.fi Cc: Hans Verkuil hans.verk...@cisco.com --- drivers/media/v4l2-core/Kconfig | 11 + drivers/media/v4l2-core/Makefile |2 + drivers/media

[PATCH/RFC v8 03/14] Documentation: leds: Add description of v4l2-flash sub-device

2014-11-28 Thread Jacek Anaszewski
This patch extends LED Flash class documention by the description of interactions with v4l2-flash sub-device. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net

[PATCH/RFC v8 02/14] Documentation: leds: Add description of LED Flash class extension

2014-11-28 Thread Jacek Anaszewski
The documentation being added contains overall description of the LED Flash Class and the related sysfs attributes. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net

[PATCH/RFC v8 00/14] LED / flash API integration

2014-11-28 Thread Jacek Anaszewski
op in v4l2-flash. LED subsystem should be strobe provider agnostic. Thanks, Jacek Anaszewski [1] https://lkml.org/lkml/2014/7/11/914 Jacek Anaszewski (14): leds: Add LED Flash class extension to the LED subsystem Documentation: leds: Add description of LED Flash class extension

[PATCH/RFC v8 01/14] leds: Add LED Flash class extension to the LED subsystem

2014-11-28 Thread Jacek Anaszewski
. The design assumes that V4L2 sub-device can take of the LED class device control and communicate with it through the kernel internal interface. When V4L2 Flash sub-device file is opened, the LED class device sysfs interface is made unavailable. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com

Re: [PATCH/RFC v7 2/3] leds: Add LED Flash Class wrapper to LED subsystem

2014-11-28 Thread Jacek Anaszewski
the rounddown() macro. I.e. rounddown(v - s-min, s-step) + s-min; I took this code snippet from v4l2-ctrls.c. It allows for aligning the control value to the nearest step - top or bottom, whereas rounddown only to the bottom one. Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line

Re: [PATCH/RFC v8 08/14] DT: Add documentation for exynos4-is 'flashes' property

2014-11-28 Thread Jacek Anaszewski
On 11/28/2014 12:14 PM, Mark Rutland wrote: On Fri, Nov 28, 2014 at 09:18:00AM +, Jacek Anaszewski wrote: This patch adds a description of 'flashes' property to the samsung-fimc.txt. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com

[PATCH] s5p-jpeg: Fix possible NULL pointer dereference in s_fmt

2014-11-28 Thread Jacek Anaszewski
Some formats are not supported in encoding or decoding mode for given type of buffer (e.g. V4L2_PIX_FMT_JPEG is supported on output buffer only while in decoding mode). Make S_FMT failing if not suitable format is found. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com --- drivers/media

Re: [PATCH/RFC v4 11/11] Add a libv4l plugin for Exynos4 camera

2014-11-28 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 11/27/2014 09:41 AM, Sakari Ailus wrote: Hi Jacek, On Fri, Nov 21, 2014 at 05:14:40PM +0100, Jacek Anaszewski wrote: The plugin provides support for the media device on Exynos4 SoC. It performs single plane - multi plane API conversion, video pipeline

Re: [PATCH/RFC v8 08/14] DT: Add documentation for exynos4-is 'flashes' property

2014-11-28 Thread Jacek Anaszewski
On 11/28/2014 01:30 PM, Mark Rutland wrote: On Fri, Nov 28, 2014 at 12:09:14PM +, Jacek Anaszewski wrote: On 11/28/2014 12:14 PM, Mark Rutland wrote: On Fri, Nov 28, 2014 at 09:18:00AM +, Jacek Anaszewski wrote: This patch adds a description of 'flashes' property to the samsung

Re: [PATCH 6/6] media/platform: fix querycap

2014-11-25 Thread Jacek Anaszewski
. These were already slated for removal, so it's time to do so. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Lad, Prabhakar prabhakar.cse...@gmail.com Cc: Kamil Debski k.deb...@samsung.com Cc: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Jacek Anaszewski j.anaszew...@samsung.com

Re: [PATCH/RFC v4 01/11] mediactl: Introduce v4l2_subdev structure

2014-11-25 Thread Jacek Anaszewski
Hi Sakari, On 11/25/2014 12:36 PM, Sakari Ailus wrote: Hi Jacek, Thank you for the updated patchset. On Fri, Nov 21, 2014 at 05:14:30PM +0100, Jacek Anaszewski wrote: Add struct v4l2_subdev as a representation of the v4l2 sub-device related to a media entity. Add sd property, the pointer

[PATCH/RFC v4 00/11] Add a plugin for Exynos4 camera

2014-11-21 Thread Jacek Anaszewski
-raw,width=960,height=720 ! fbdevsink In order to avoid fbdevsink element failure the fix [4] for exynos-drm driver is required. Thanks, Jacek Anaszewski [1] https://patchwork.linuxtv.org/patch/26366/ [2] https://patchwork.linuxtv.org/patch/26367/ [3] https://patchwork.linuxtv.org/patch/26368/ [4

[PATCH/RFC v4 01/11] mediactl: Introduce v4l2_subdev structure

2014-11-21 Thread Jacek Anaszewski
Add struct v4l2_subdev as a representation of the v4l2 sub-device related to a media entity. Add sd property, the pointer to the newly introduced structure, to the struct media_entity and move fd property to it. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park

[PATCH/RFC v4 03/11] mediactl: Separate entity and pad parsing

2014-11-21 Thread Jacek Anaszewski
Sometimes it's useful to be able to parse the entity independent of the pad. Separate entity parsing into media_parse_entity(). Signed-off-by: Sakari Ailus sakari.ai...@linux.intel.com --- utils/media-ctl/libmediactl.c | 28 utils/media-ctl/mediactl.h| 14

[PATCH/RFC v4 05/11] mediactl: Add media device graph helpers

2014-11-21 Thread Jacek Anaszewski
Add new graph helpers useful for video pipeline discovering. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- utils/media-ctl/libmediactl.c | 174 + utils/media-ctl/mediactl.h| 121

[PATCH/RFC v4 02/11] mediactl: Add support for v4l2 controls

2014-11-21 Thread Jacek Anaszewski
-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- utils/media-ctl/libmediactl.c | 11 +++ utils/media-ctl/libv4l2subdev.c | 60 ++- utils/media-ctl/mediactl-priv.h |3 ++ utils/media-ctl/v4l2subdev.h

[PATCH/RFC v4 04/11] mediatext: Add library

2014-11-21 Thread Jacek Anaszewski
...@linux.intel.com Signed-off-by: Teemu Tuominen teemu.tuomi...@intel.com Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com --- utils/media-ctl/Makefile.am| 10 +- utils/media-ctl/libmediatext.pc.in | 10 ++ utils/media-ctl/mediatext-test.c | 66 + utils/media-ctl/mediatext.c

[PATCH/RFC v4 10/11] mediactl: Add media device ioctl API

2014-11-21 Thread Jacek Anaszewski
Ioctls executed on complex media devices need special handling. E.g. S_FMT requires negotiation for the whole pipeline of sub-devices. On the other hand some ioctls need to be targeted for specific sub-devices. The API being introduced address such requirements. Signed-off-by: Jacek Anaszewski

[PATCH/RFC v4 11/11] Add a libv4l plugin for Exynos4 camera

2014-11-21 Thread Jacek Anaszewski
-exynos4-camera/libv4l-exynos4-camera.c @@ -0,0 +1,595 @@ +/* + * Copyright (c) 2014 Samsung Electronics Co., Ltd. + * http://www.samsung.com + * + * Author: Jacek Anaszewski j.anaszew...@samsung.com + * + * This program is free software; you can redistribute it and/or modify + * it under

[PATCH/RFC v4 09/11] mediactl: Close only pipeline sub-devices

2014-11-21 Thread Jacek Anaszewski
it contained, which was undesirable behavior as there might exist other initialized plugins which had opened the same media_device and initialized a pipeline. With this patch only the sub-devices that belong to the pipeline of current media_device instance will be closed. Signed-off-by: Jacek Anaszewski

[PATCH/RFC v4 08/11] mediactl: Add support for media device pipelines

2014-11-21 Thread Jacek Anaszewski
Add infrastructure for linking media entities, discovering pipelines of media entities and opening/closing all sub-devices in the pipeline at one go. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- utils/media-ctl/libmediactl.c

[PATCH/RFC v4 06/11] mediactl: Add media_device creation helpers

2014-11-21 Thread Jacek Anaszewski
Add helper functions that allow for easy instantiation of media_device object basing on whether the media device contains video device with given node name. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- utils/media-ctl

[PATCH/RFC v4 07/11] media-ctl: libv4l2subdev: add VYUY8_2X8 mbus code

2014-11-21 Thread Jacek Anaszewski
The VYUY8_2X8 media bus format is the only one supported by the S5C73M3 camera sensor, that is a part of the media device on the Exynos4412-trats2 board. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- utils/media-ctl/libv4l2subdev.c

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-20 Thread Jacek Anaszewski
Hi Pavel, Sakari, On 11/19/2014 06:53 PM, Sakari Ailus wrote: Hi Jacek and Pavel, Jacek Anaszewski wrote: Hi Pavel, Sakari, On 11/18/2014 05:51 PM, Pavel Machek wrote: Hi! If the hardware LED changes with one that needs different current, the block for the adp1653 stays the same

Re: [PATCH/RFC v6 1/2] media: Add registration helpers for V4L2 flash

2014-11-20 Thread Jacek Anaszewski
Hi Sakari, On 11/20/2014 10:36 AM, Sakari Ailus wrote: Hi Jacek, Thank you for your thoughtful writing on the subject. I am just doing my best to bring it to a successful end :) Jacek Anaszewski wrote: Hi Sakari, On 09/22/2014 05:21 PM, Jacek Anaszewski wrote: This patch adds helper

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-20 Thread Jacek Anaszewski
On 11/19/2014 10:45 AM, Jacek Anaszewski wrote: Hi Pavel, Sakari, On 11/18/2014 05:51 PM, Pavel Machek wrote: Hi! If the hardware LED changes with one that needs different current, the block for the adp1653 stays the same, but white LED block should be updated with different value. I think

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-20 Thread Jacek Anaszewski
Hi Pavel, On 11/20/2014 01:12 PM, Pavel Machek wrote: Hi! I would also swap the segments of a property name to follow the convention as in case of regulator-max-microamp. Updated version: == Optional properties for child nodes: -

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-19 Thread Jacek Anaszewski
Hi Pavel, Sakari, On 11/18/2014 05:51 PM, Pavel Machek wrote: Hi! If the hardware LED changes with one that needs different current, the block for the adp1653 stays the same, but white LED block should be updated with different value. I think that you are talking about sub nodes. Indeed I

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-18 Thread Jacek Anaszewski
more, remove the printks. Anything else obviously wrong? Jacek Anaszewski is working on flash support for LED devices. I think it'd be good to sync the DT bindings for the two, as the types of devices supported by the LED API and the V4L2 flash API are quite similar. Cc Jacek. I've already

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-18 Thread Jacek Anaszewski
On 11/18/2014 09:46 AM, Pavel Machek wrote: On Tue 2014-11-18 09:09:09, Jacek Anaszewski wrote: Hi Pavel, Sakari, On 11/17/2014 03:58 PM, Sakari Ailus wrote: Hi Pavel, On Sun, Nov 16, 2014 at 08:59:28AM +0100, Pavel Machek wrote: For device tree people: Yes, I know I'll have to create file

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-18 Thread Jacek Anaszewski
On 11/18/2014 12:32 PM, Pavel Machek wrote: I've already submitted a patch [1] that updates leds common bindings. I hasn't been merged yet, as the related LED Flash class patch [2] still needs some indicator leds related discussion [3]. I think this is a good moment to discuss the flash

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-18 Thread Jacek Anaszewski
Hi Pavel, On 11/18/2014 02:21 PM, Pavel Machek wrote: Hi! @@ -19,5 +30,10 @@ Examples: system-status { label = Status; linux,default-trigger = heartbeat; + iout-torch = 500 500; + iout-flash = 1000 1000; + iout-indicator =

Re: [PATCH/RFC v6 1/2] media: Add registration helpers for V4L2 flash

2014-11-17 Thread Jacek Anaszewski
Hi Sakari, On 09/22/2014 05:21 PM, Jacek Anaszewski wrote: This patch adds helper functions for registering/unregistering LED class flash devices as V4L2 subdevs. The functions should be called from the LED subsystem device driver. In case the support for V4L2 Flash sub-devices is disabled

Re: [PATCH/RFC v7 3/3] Documentation: leds: Add description of LED Flash Class extension

2014-11-14 Thread Jacek Anaszewski
Hi Bryan, Thanks for a review. On 11/13/2014 07:58 PM, Bryan Wu wrote: On Wed, Nov 12, 2014 at 8:09 AM, Jacek Anaszewski j.anaszew...@samsung.com wrote: The documentation being added contains overall description of the LED Flash Class and the related sysfs attributes. Signed-off-by: Jacek

[PATCH/RFC v7 1/3] leds: Add support for setting brightness in a synchronous way

2014-11-12 Thread Jacek Anaszewski
led_set_brightness_sync API is added. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net --- drivers/leds/led-class.c | 10 ++ drivers/leds/led-core.c

[PATCH/RFC v7 0/3] LED / flash API integration - LED Flash Class

2014-11-12 Thread Jacek Anaszewski
external strobe facilities from the LED Flash Class and provided external_strobe_set op in v4l2-flash. LED subsystem should be strobe provider agnostic. Thanks, Jacek Anaszewski [1] https://lkml.org/lkml/2014/7/11/914 Jacek Anaszewski (3): leds: Add support for setting brightness

[PATCH/RFC v7 2/3] leds: Add LED Flash Class wrapper to LED subsystem

2014-11-12 Thread Jacek Anaszewski
sub-device can take of the LED class device control and communicate with it through the kernel internal interface. When V4L2 Flash sub-device file is opened, the LED class device sysfs interface is made unavailable. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park

[PATCH/RFC v7 3/3] Documentation: leds: Add description of LED Flash Class extension

2014-11-12 Thread Jacek Anaszewski
The documentation being added contains overall description of the LED Flash Class and the related sysfs attributes. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net

[v4l-utils RFC v3 02/11] mediactl: Separate entity and pad parsing

2014-11-06 Thread Jacek Anaszewski
From: Sakari Ailus sakari.ai...@linux.intel.com Sometimes it's useful to be able to parse the entity independent of the pad. Separate entity parsing into media_parse_entity(). Signed-off-by: Sakari Ailus sakari.ai...@linux.intel.com --- utils/media-ctl/libmediactl.c | 28

[v4l-utils RFC v3 00/11] Add a plugin for the Exynos4 camera

2014-11-06 Thread Jacek Anaszewski
=720 ! fbdevsink In order to avoid fbdevsink element failure the fix [4] for exynos-drm driver is required. Thanks, Jacek Anaszewski [1] https://patchwork.linuxtv.org/patch/26366/ [2] https://patchwork.linuxtv.org/patch/26367/ [3] https://patchwork.linuxtv.org/patch/26368/ [4] http

[v4l-utils RFC v3 07/11] mediactl: Add VYUY8_2X8 media bus format

2014-11-06 Thread Jacek Anaszewski
The VYUY8_2X8 media bus format is the only one supported by the S5C73M3 camera sensor, that is a part of the media device on the Exynos4412-trats2 board. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- utils/media-ctl/libv4l2subdev.c

[v4l-utils RFC v3 06/11] mediactl: Add subdev_fmt property to the media_entity

2014-11-06 Thread Jacek Anaszewski
Add subdev_fmt field to the structure media_entity. Added is also API for setting the media_entity format and comparing two subdev formats. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- utils/media-ctl/libmediactl.c |6

[v4l-utils RFC v3 05/11] mediactl: Add media_device creation helpers

2014-11-06 Thread Jacek Anaszewski
Add helper functions that allow for easy instantiation of media_device object basing on whether the media device contains video device with given node name. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- utils/media-ctl

[v4l-utils RFC v3 11/11] Add a libv4l plugin for Exynos4 camera

2014-11-06 Thread Jacek Anaszewski
+++ b/lib/libv4l-exynos4-camera/libv4l-exynos4-camera.c @@ -0,0 +1,599 @@ +/* + * Copyright (c) 2014 Samsung Electronics Co., Ltd. + * http://www.samsung.com + * + * Author: Jacek Anaszewski j.anaszew...@samsung.com + * + * This program is free software; you can redistribute

[v4l-utils RFC v3 01/11] mediactl: Introduce ctrl_to_subdev configuration

2014-11-06 Thread Jacek Anaszewski
Add an infrastructure for a ctrl_to_subdev configuration data. The ctrl_to_subdev config entry is designed for conveying information about the target sub-device in the media device pipeline for a v4l2 control related ioctl calls. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked

[v4l-utils RFC v3 03/11] mediatext: Add library

2014-11-06 Thread Jacek Anaszewski
...@linux.intel.com Signed-off-by: Teemu Tuominen teemu.tuomi...@intel.com Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com --- libmediatext.pc.in | 10 ++ utils/media-ctl/Makefile.am| 10 +- utils/media-ctl/libmediatext.pc.in | 10 ++ utils/media-ctl/mediatext-test.c

[v4l-utils RFC v3 08/11] mediactl: Add support for media device pipelines

2014-11-06 Thread Jacek Anaszewski
Add infrastructure for linking media entities, discovering pipelines of media entities and opening/closing all sub-devices in the pipeline at one go. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- utils/media-ctl/libmediactl.c

[v4l-utils RFC v3 04/11] mediactl: Add media device graph helpers

2014-11-06 Thread Jacek Anaszewski
Add new graph helpers useful for video pipeline discovering. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- utils/media-ctl/libmediactl.c | 184 + utils/media-ctl/mediactl.h| 132

[v4l-utils RFC v3 09/11] mediactl: Add media device ioctl API

2014-11-06 Thread Jacek Anaszewski
Ioctls executed on complex media devices need special handling. E.g. S_FMT requires negotiation for the whole pipeline of sub-devices. On the other hand some ioctls need to be targeted for specific sub-devices. The API being introduced address such requirements. Signed-off-by: Jacek Anaszewski

[v4l-utils RFC v3 10/11] mediactl: Close only pipeline sub-devices

2014-11-06 Thread Jacek Anaszewski
it contained, which was undesirable behavior as there might exist other initialized plugins which had opened the same media_device and initialized a pipeline. With this patch only the sub-devices that belong to the pipeline of current media_device instance will be closed. Signed-off-by: Jacek Anaszewski

Re: [PATCH/RFC v6 3/3] leds: Add LED Flash Class wrapper to LED subsystem

2014-11-04 Thread Jacek Anaszewski
Hi Bryan, Thanks for a review. On 11/04/2014 02:34 AM, Bryan Wu wrote: On Mon, Sep 22, 2014 at 8:21 AM, Jacek Anaszewski j.anaszew...@samsung.com wrote: Some LED devices support two operation modes - torch and flash. I got several terms here: flash, torch and indicator. And we have 3 CAPs

Re: [v4l-utils RFC 0/2] libmediatext library

2014-10-23 Thread Jacek Anaszewski
to figure out how to use its API in my plugin and what parts of my code could be added to it. Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH/RFC v2 1/4] Add a media device configuration file parser.

2014-10-21 Thread Jacek Anaszewski
Hi Sakari, On 10/20/2014 11:44 PM, Sakari Ailus wrote: Hi Jacek, On Fri, Oct 17, 2014 at 04:54:39PM +0200, Jacek Anaszewski wrote: This patch adds a parser for a media device configuration file. The parser expects the configuration file containing links end v4l2-controls definitions

Re: [PATCH/RFC v2 1/4] Add a media device configuration file parser.

2014-10-21 Thread Jacek Anaszewski
Hi Sakari, On 10/21/2014 11:26 AM, Sakari Ailus wrote: Hi Jacek, On Tue, Oct 21, 2014 at 09:17:00AM +0200, Jacek Anaszewski wrote: ... + * The V4L2 control group format: + * + * v4l2-controls { + * TABcontrol1_name: entity_nameLF + * TABcontrol2_name: entity_nameLF

[PATCH/RFC v2 0/4] Libv4l: Add a plugin for the Exynos4 camera

2014-10-17 Thread Jacek Anaszewski
! video/x-raw,width=960,height=720 ! fbdevsink In order to avoid fbdevsink element failure the fix [4] for exynos-drm driver is required. Thanks, Jacek Anaszewski [1] https://patchwork.linuxtv.org/patch/26366/ [2] https://patchwork.linuxtv.org/patch/26367/ [3] https://patchwork.linuxtv.org/patch

[PATCH/RFC v2 1/4] Add a media device configuration file parser.

2014-10-17 Thread Jacek Anaszewski
-devices for particular user controls related ioctl calls. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Mauro Carvalho Chehab mche...@osg.samsung.com Cc: Hans Verkuil hans.verk...@cisco.com --- lib/include/libv4l2-media-conf-parser.h

[PATCH/RFC v2 3/4] Add wrappers for media device related ioctl calls.

2014-10-17 Thread Jacek Anaszewski
-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Mauro Carvalho Chehab mche...@osg.samsung.com Cc: Hans Verkuil hans.verk...@cisco.com --- lib/include/libv4l2-mdev-ioctl.h | 45 ++ lib/libv4l2/libv4l2-mdev-ioctl.c | 329

[PATCH/RFC v2 4/4] Add a libv4l plugin for Exynos4 camera

2014-10-17 Thread Jacek Anaszewski
-camera.c new file mode 100644 index 000..150c700 --- /dev/null +++ b/lib/libv4l-exynos4-camera/libv4l-exynos4-camera.c @@ -0,0 +1,569 @@ +/* + * Copyright (c) 2014 Samsung Electronics Co., Ltd. + * http://www.samsung.com + * + * Author: Jacek Anaszewski j.anaszew...@samsung.com

[PATCH/RFC v2 2/4] Add media device related data structures and API.

2014-10-17 Thread Jacek Anaszewski
Add helpers for retrieving media device topology and manipulating its configuration. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Mauro Carvalho Chehab mche...@osg.samsung.com Cc: Hans Verkuil hans.verk...@cisco.com --- lib

Re: [PATCH/RFC 1/1] Add a libv4l plugin for Exynos4 camera

2014-10-10 Thread Jacek Anaszewski
Hi, On 10/09/2014 10:20 AM, Hans de Goede wrote: Hi, On 10/08/2014 03:22 PM, Jacek Anaszewski wrote: Hi Hans, On 10/08/2014 02:42 PM, Hans de Goede wrote: snip +} + +/* refresh device topology data after linking */ +release_entities(mdev); + +ret = get_device_topology

Re: [PATCH/RFC 0/1] Libv4l: Add a plugin for the Exynos4 camera

2014-10-10 Thread Jacek Anaszewski
Hi, On 10/09/2014 07:46 PM, Gregor Jasny wrote: Hi, On 08/10/14 10:46, Jacek Anaszewski wrote: This patch adds a plugin for the Exynos4 camera. I wanted to split at least the parser part to the separate module but encountered some problems with autotools configuration and therefore I'd like

[PATCH] s5p-jpeg: Avoid -Wuninitialized warning in s5p_jpeg_parse_hdr

2014-10-10 Thread Jacek Anaszewski
Initialize components variable in order to avoid the possibility of using it uninitialized. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com --- drivers/media/platform/s5p-jpeg/jpeg-core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p

Re: [PATCH/RFC 1/1] Add a libv4l plugin for Exynos4 camera

2014-10-10 Thread Jacek Anaszewski
Hi Hans, On 10/10/2014 10:54 AM, Hans Verkuil wrote: Hi Jacek, I didn't do an in-depth review, but one thing caught my eye: On 10/08/2014 10:46 AM, Jacek Anaszewski wrote: The plugin provides support for the media device on Exynos4 SoC. Added is also a media device configuration file parser

Re: [PATCH/RFC 1/1] Add a libv4l plugin for Exynos4 camera

2014-10-09 Thread Jacek Anaszewski
On 10/08/2014 05:49 PM, Antonio Ospite wrote: On Wed, 08 Oct 2014 15:22:43 +0200 Jacek Anaszewski j.anaszew...@samsung.com wrote: Hi Hans, On 10/08/2014 02:42 PM, Hans de Goede wrote: Hi, On 10/08/2014 10:46 AM, Jacek Anaszewski wrote: The plugin provides support for the media device

[PATCH/RFC 1/1] Add a libv4l plugin for Exynos4 camera

2014-10-08 Thread Jacek Anaszewski
to a particular sub-device. The plugin performs single plane - multi plane API conversion, video pipeline linking and takes care of automatic data format negotiation for the whole pipeline, after intercepting VIDIOC_S_FMT or VIDIOC_TRY_FMT ioctls. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked

[PATCH 2/3] exynos4-is: Add support for asynchronous sub-devices power on

2014-10-08 Thread Jacek Anaszewski
From: Sylwester Nawrocki s.nawro...@samsung.com Schedule sub-devices power up in separate thread to speed up video device open and to allow some ioctls, like VIDIOC_REQBUFS to be run in parallel. We synchronize with completion of the power up sequence before starting streaming on subdevices, as

[PATCH/RFC 0/1] Libv4l: Add a plugin for the Exynos4 camera

2014-10-08 Thread Jacek Anaszewski
Anaszewski [1] http://www.spinics.net/lists/dri-devel/msg66494.html Jacek Anaszewski (1): Add a libv4l plugin for Exynos4 camera configure.ac |1 + lib/Makefile.am|5 +- lib/libv4l-exynos4-camera/Makefile.am

<    1   2   3   4   5   6   7   8   >