Re: [GIT PATCHES FOR 2.6.37] Remove v4l2-i2c-drv.h and most of i2c-id.h

2010-09-16 Thread Jean Delvare
subsystem. Once we fixed these remaining users of the i2c-id.h defines, then Jean can remove that header together with the adapter's 'id' field. That would be very great. In all honesty I didn't expect it to happen so fast, but if that happens, I'll be very happy! :) Thanks! -- Jean Delvare

[PATCH 2/5] cx22702: Drop useless initializations to 0

2010-09-10 Thread Jean Delvare
These variables are either unconditionally set right afterward, or already set to 0 by kzalloc. Signed-off-by: Jean Delvare kh...@linux-fr.org Cc: Steven Toth st...@kernellabs.com --- drivers/media/dvb/frontends/cx22702.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- linux

[PATCH 4/5] cx22702: Some things never change

2010-09-10 Thread Jean Delvare
The init sequence never changes so it can be marked const. Likewise, cx22702_ops is a template and can thus be made read-only. Signed-off-by: Jean Delvare kh...@linux-fr.org Cc: Steven Toth st...@kernellabs.com --- drivers/media/dvb/frontends/cx22702.c |6 +++--- 1 file changed, 3 insertions

[PATCH 1/5 v2] cx22702: Clean up register access functions

2010-09-10 Thread Jean Delvare
Hi Mauro, On Fri, 10 Sep 2010 12:13:32 -0300, Mauro Carvalho Chehab wrote: Em 10-09-2010 10:27, Jean Delvare escreveu: * Avoid temporary variables. * Optimize success paths. * Make error messages consistently verbose. Signed-off-by: Jean Delvare kh...@linux-fr.org Cc: Steven Toth st

Re: [PATCH 8/8] v4l: radio: si470x: fix unneeded free_irq() call

2010-09-06 Thread Jean Delvare
-by: Kyungmin Park kyungmin.p...@samsung.com CC: Tobias Lorenz tobias.lor...@gmx.net CC: Joonyoung Shim jy0922.s...@samsung.com CC: Douglas Schilling Landgraf dougsl...@redhat.com CC: Jean Delvare kh...@linux-fr.org --- drivers/media/radio/si470x/radio-si470x-i2c.c |2 +- 1 files changed, 1

Re: [PATCH 04/17] cx25840: Make cx25840 i2c register read transactions atomic

2010-07-20 Thread Jean Delvare
is not released until the register read is done. Signed-off-by: Andy Walls awa...@md.metrocast.net Good catch. Acked-by: Jean Delvare kh...@linux-fr.org Note that cx25840_and_or() still has a (smaller and less dangerous) race window. If several calls to cx25840_and_or() happen in parallel

Re: [PATCH 04/17] cx25840: Make cx25840 i2c register read transactions atomic

2010-07-20 Thread Jean Delvare
On Tue, 20 Jul 2010 08:35:26 -0400, Andy Walls wrote: On Tue, 2010-07-20 at 08:42 +0200, Jean Delvare wrote: Hi Andy, On Mon, 19 Jul 2010 21:11:46 -0400, Andy Walls wrote: There was a small window between writing the cx25840 register address over the i2c bus and reading the register

[PATCH 1/2] V4L/DVB: cx88: Move I2C IR initialization

2010-06-28 Thread Jean Delvare
to disable IR support (coming soon.) Signed-off-by: Jean Delvare kh...@linux-fr.org --- drivers/media/video/cx88/cx88-cards.c |1 + drivers/media/video/cx88/cx88-i2c.c |6 +- drivers/media/video/cx88/cx88.h |1 + 3 files changed, 7 insertions(+), 1 deletion(-) --- linux-2.6.34-rc3

[PATCH 2/2] V4L/DVB: cx88: Let the user disable IR support

2010-06-28 Thread Jean Delvare
It might be useful to be able to disable the IR support, either for debugging purposes, or just for users who know they won't use the IR remote control anyway. On many cards, IR support requires expensive polling/sampling which is better avoided if never needed. Signed-off-by: Jean Delvare kh

Re: [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-16 Thread Jean Delvare
On Tue, 15 Jun 2010 09:20:39 -0700, David Daney wrote: On 06/15/2010 04:40 AM, Jean Delvare wrote: __process_new_adapter() calls i2c_do_add_adapter() which always returns 0. Why should I check the return value of bus_for_each_drv() when I know it will always be 0 by construction? Also

Re: [PATCH 7/8]ieee1394/sdp2 Fix warning: variable 'unit_characteristics' set but not used

2010-06-15 Thread Jean Delvare
? ud-model_id : SBP2_ROM_VALUE_MISSING; -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-15 Thread Jean Delvare
Hi David, On Mon, 14 Jun 2010 14:28:57 -0700, David Daney wrote: On 06/14/2010 01:53 PM, Jean Delvare wrote: Hi Justin, On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote: could be a right solution, could be wrong here is the warning: CC drivers/i2c/i2c-core.o

Re: [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-15 Thread Jean Delvare
Hi Justin, On Mon, 14 Jun 2010 14:06:12 -0700, Justin P. Mattock wrote: On 06/14/2010 01:53 PM, Jean Delvare wrote: Hi Justin, On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote: could be a right solution, could be wrong here is the warning: CC drivers/i2c/i2c-core.o

Re: [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-14 Thread Jean Delvare
of warning gcc 4.6.0 generates. Depends which warnings we value more, as we can't sanely have both. mutex_unlock(core_lock); return 0; -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 2/2] V4L/DVB: Use custom I2C probing function mechanism

2010-06-09 Thread Jean Delvare
Hi Wolfram, On Wed, 9 Jun 2010 17:05:40 +0200, Wolfram Sang wrote: Hi Jean, On Tue, Jun 08, 2010 at 10:01:00AM +0200, Jean Delvare wrote: Now that i2c-core offers the possibility to provide custom probing function for I2C devices, let's make use of it. Signed-off-by: Jean Delvare kh

[PATCH 1/2] i2c: Add support for custom probe function

2010-06-08 Thread Jean Delvare
The probe method used by i2c_new_probed_device() may not be suitable for all cases. Let the caller provide its own, optional probe function. Signed-off-by: Jean Delvare kh...@linux-fr.org Acked-by: Mauro Carvalho Chehab mche...@redhat.com --- Documentation/i2c/instantiating-devices |2

[PATCH 2/2] V4L/DVB: Use custom I2C probing function mechanism

2010-06-08 Thread Jean Delvare
Now that i2c-core offers the possibility to provide custom probing function for I2C devices, let's make use of it. Signed-off-by: Jean Delvare kh...@linux-fr.org Acked-by: Mauro Carvalho Chehab mche...@redhat.com --- drivers/i2c/i2c-core.c|7 +++ drivers/media/video

Re: [PATCH RESEND] FusionHDTV: Use quick reads for I2C IR device probing

2010-06-04 Thread Jean Delvare
Mauro, On Wed, 26 May 2010 15:05:11 +0200, Jean Delvare wrote: IR support on FusionHDTV cards is broken since kernel 2.6.31. One side effect of the switch to the standard binding model for IR I2C devices was to let i2c-core do the probing instead of the ir-kbd-i2c driver. There is a slight

Re: [PATCH] drivers: remove all i2c_set_clientdata(client, NULL)

2010-06-01 Thread Jean Delvare
e4a7b9b04de15f6b63da5ccdd373ffa3057a3681 to fix the faulty drivers. As there is no need anymore to clear the clientdata-pointer, remove all current occurrences in the drivers to simplify the code and prevent confusion. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Jean Delvare kh...@linux-fr.org

Re: [PATCH] drivers: remove all i2c_set_clientdata(client, NULL)

2010-05-31 Thread Jean Delvare
it all in one go. If I take the patch in my i2c tree, the aim is to merge it upstream immediately, so merge issues won't exist. -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [patch] video/saa7134: potential null dereferences in debug code

2010-05-29 Thread Jean Delvare
On Sat, 29 May 2010 01:29:54 -0300, Mauro Carvalho Chehab wrote: Em Sat, 22 May 2010 22:59:21 +0200 Jean Delvare kh...@linux-fr.org escreveu: I would have used (null) instead of null for consistency with lib/vsprintf.c:string(). But more importantly, I suspect that a better fix would

Re: [patch v3 1/2] video/saa7134: change dprintk() to i2cdprintk()

2010-05-26 Thread Jean Delvare
Hi Dan, On Tue, 25 May 2010 11:19:53 +0200, Dan Carpenter wrote: The problem is that dprintk() dereferences dev which is null here. The i2cdprintk() uses ir so that's OK. Signed-off-by: Dan Carpenter erro...@gmail.com --- v2: Jean Delvare suggested that I use i2cdprintk() instead

Re: [patch v3 2/2] video/saa7134: remove duplicate break

2010-05-26 Thread Jean Delvare
On Tue, 25 May 2010 11:21:50 +0200, Dan Carpenter wrote: The original code had two break statements in a row. Signed-off-by: Dan Carpenter erro...@gmail.com Acked-by: Jean Delvare kh...@linux-fr.org --- v3: Put this in a seperate patch. diff --git a/drivers/media/video/saa7134/saa7134

[PATCH RESEND] FusionHDTV: Use quick reads for I2C IR device probing

2010-05-26 Thread Jean Delvare
a custom probing function. Signed-off-by: Jean Delvare kh...@linux-fr.org Tested-by: Timothy D. Lenz tl...@vorgon.com --- This fix applies to kernels 2.6.31 to 2.6.34. Should be sent to Linus quickly. I had already sent on March 29th, but apparently it was overlooked. I have further i2c patches which

Re: [patch] video/saa7134: potential null dereferences in debug code

2010-05-22 Thread Jean Delvare
() could be replaced with i2cdprintk (which is misnamed IMHO, BTW.) -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] V4L/DVB: Use custom I2C probing function mechanism

2010-04-09 Thread Jean Delvare
Hi Mauro, On Fri, 09 Apr 2010 01:09:08 -0300, Mauro Carvalho Chehab wrote: Jean Delvare wrote: There are no other probing functions yet, this is the first one. I have added the mechanism to i2c-core for these very IR chips. Putting all probe functions together would mean moving them

Re: [PATCH 2/2] V4L/DVB: Use custom I2C probing function mechanism

2010-04-06 Thread Jean Delvare
Hi Mauro, On Tue, 06 Apr 2010 02:34:46 -0300, Mauro Carvalho Chehab wrote: Jean Delvare wrote: On Mon, 05 Apr 2010 15:26:32 -0300, Mauro Carvalho Chehab wrote: Please, don't add new things at ir-common module. It basically contains the decoding functions for RC5 and pulse/distance, plus

Re: [PATCH 2/2] V4L/DVB: Use custom I2C probing function mechanism

2010-04-05 Thread Jean Delvare
Hi Andy, On Sun, 04 Apr 2010 21:54:39 -0400, Andy Walls wrote: On Sun, 2010-04-04 at 16:14 +0200, Jean Delvare wrote: Now that i2c-core offers the possibility to provide custom probing function for I2C devices, let's make use of it. Signed-off-by: Jean Delvare kh...@linux-fr.org

Re: [PATCH 2/2] V4L/DVB: Use custom I2C probing function mechanism

2010-04-05 Thread Jean Delvare
Hi Mauro, On Mon, 05 Apr 2010 15:26:32 -0300, Mauro Carvalho Chehab wrote: Jean Delvare wrote: Now that i2c-core offers the possibility to provide custom probing function for I2C devices, let's make use of it. Signed-off-by: Jean Delvare kh...@linux-fr.org --- I wasn't too sure

[PATCH 1/2] i2c: Add support for custom probe function

2010-04-04 Thread Jean Delvare
The probe method used by i2c_new_probed_device() may not be suitable for all cases. Let the caller provide its own, optional probe function. Signed-off-by: Jean Delvare kh...@linux-fr.org --- Documentation/i2c/instantiating-devices |2 drivers/i2c/i2c-core.c| 65

[PATCH 2/2] V4L/DVB: Use custom I2C probing function mechanism

2010-04-04 Thread Jean Delvare
Now that i2c-core offers the possibility to provide custom probing function for I2C devices, let's make use of it. Signed-off-by: Jean Delvare kh...@linux-fr.org --- I wasn't too sure where to put the custom probe function: in each driver, in the ir-common module or in the v4l2-common module. I

cx88 remote control event device

2010-03-31 Thread Jean Delvare
. Can't we have the cx88 driver poll the remote control only when the device node is opened? I believe this would save some power by allowing the CPU to stay in higher C states. Thanks, -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message

Re: cx88 remote control event device

2010-03-31 Thread Jean Delvare
Hi Mauro, On Wed, 31 Mar 2010 14:46:37 -0300, Mauro Carvalho Chehab wrote: Hi Jean, Jean Delvare wrote: Hi Andrzej, Last year, you submitted a fix for the cx88 remote control not behaving properly on some cards. The fix works fine for me and lets me use my remote control, and I am

Re: [PATCH] FusionHDTV: Use quick reads for I2C IR device probing

2010-03-29 Thread Jean Delvare
Can the fix below please be picked quickly? This is a regression, the fix should go upstream ASAP. Thanks. On Fri, 19 Mar 2010 14:42:50 +0100, Jean Delvare wrote: IR support on FusionHDTV cards is broken since kernel 2.6.31. One side effect of the switch to the standard binding model for IR I2C

Re: i2c interface bugs in dvb drivers

2010-03-24 Thread Jean Delvare
. This is sufficient in most cases in my experience. If not, these tools can certainly get extended, at least to cover all of SMBus. -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 12/24] media/video: fix dangling pointers

2010-03-22 Thread Jean Delvare
Replying to myself... On Sun, 21 Mar 2010 14:46:55 +0100, Jean Delvare wrote: I get the feeling that this would be a job for managed resources as some drivers already do for I/O ports and IRQs. Managed resources don't care about symmetry of allocation and freeing, by design (so it can violate

Re: [PATCH 12/24] media/video: fix dangling pointers

2010-03-21 Thread Jean Delvare
but not in saa7115.c, which has exactly the same construct? For that matter, I think almost all v4l i2c drivers do this. That I can't say, sorry. -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo

[PATCH] FusionHDTV: Use quick reads for I2C IR device probing

2010-03-19 Thread Jean Delvare
On Tue, 16 Mar 2010 12:05:02 +0100, Jean Delvare wrote: Executive summary (as I understand it): the card that no longer works is a DViCO FusionHDTV7 Dual Express (CX23885_BOARD_DVICO_FUSIONHDTV_7_DUAL_EXP), bridge driver cx23885. It has 2 xc5000 chips at I2C address 0x64 (on 2 different I2C

Re: [PATCH] saa7134: Fix IR support of some ASUS TV-FM 7135 variants

2010-03-14 Thread Jean Delvare
parameter to the driver. If you ever need to remove the patch, use: $ cd ~/src/linux-2.6.32 $ patch -p2 -R ~/download/saa7134-Fix-IR-support-of-some-ASUS-TV-FM-7135-variants.patch I hope my instructions are clear enough, if you have any problem, just ask. Thanks, -- Jean Delvare

Re: [PATCH] saa7134: Fix IR support of some ASUS TV-FM 7135 variants

2010-03-14 Thread Jean Delvare
On Sun, 14 Mar 2010 20:34:34 +0100, Daro wrote: W dniu 14.03.2010 09:26, Jean Delvare pisze: It will be easier with the kernel you compiled yourself. First of all, download the patch from: http://patchwork.kernel.org/patch/75883/raw/ Then, move to the source directory of your 2.6.32.2

Re: [PATCH] saa7134: Fix IR support of some ASUS TV-FM 7135 variants

2010-03-12 Thread Jean Delvare
upstream without it, and if it takes too long, I'll probably just discard the patch and move to other tasks. -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [IR RC, REGRESSION] Didn't work IR RC

2010-03-10 Thread Jean Delvare
, so I admit I don't quite understand how I my i2c changes could be responsible for the regression. Anyway, glad that you managed to fix it. -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo

Re: [IR RC, REGRESSION] Didn't work IR RC

2010-03-09 Thread Jean Delvare
) on it. The getkey function will need to return the full code as well. Sorry for the late reply. Is the problem solved by now, or is my help still needed? -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] bttv: fix compiler warning before kernel 2.6.30

2010-03-06 Thread Jean Delvare
function Signed-off-by: Márton Németh nm...@freemail.hu Good catch. Acked-by: Jean Delvare kh...@linux-fr.org Douglas, please apply quickly. --- diff -r 41c5482f2dac linux/drivers/media/video/bt8xx/bttv-i2c.c --- a/linux/drivers/media/video/bt8xx/bttv-i2c.c Thu Mar 04 02:49:46 2010 -0300

Re: Status of the patches under review (29 patches)

2010-02-25 Thread Jean Delvare
On Wed, 24 Feb 2010 10:10:16 -0300, Mauro Carvalho Chehab wrote: Hi Jean, Jean Delvare wrote: I have 3 patches pending which aren't in your list. I can see them in patchwork: http://patchwork.kernel.org/patch/79755/ http://patchwork.kernel.org/patch/79754/ http

Re: [PATCH] saa7134: Fix IR support of some ASUS TV-FM 7135 variants

2010-02-25 Thread Jean Delvare
for different LNA stuff after the Hauppauge/Pinnacle merge until now. If you claim to know it better, please share with us. I'm not claiming anything, and to be honest, I have no idea what you're talking about. -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux

[PATCH 1/2] bttv: Move I2C IR initialization

2010-02-16 Thread Jean Delvare
. This fixes bug #15184: http://bugzilla.kernel.org/show_bug.cgi?id=15184 Signed-off-by: Jean Delvare kh...@linux-fr.org --- As this fixes a regression, I suggest pushing to Linus quickly. This is a candidate for 2.6.32-stable too. linux/drivers/media/video/bt8xx/bttv-driver.c |1 + linux

Re: [PATCH] saa7134: Fix IR support of some ASUS TV-FM 7135 variants

2010-02-10 Thread Jean Delvare
it would be good to make sure it fixes your problem before actually applying it. Thanks! -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] saa7134: Fix IR support of some ASUS TV-FM 7135 variants

2010-02-10 Thread Jean Delvare
Hi Mauro, On Tue, 02 Feb 2010 17:09:05 -0200, Mauro Carvalho Chehab wrote: From: Jean Delvare kh...@linux-fr.org Subject: saa7134: Fix IR support of some ASUS TV-FM 7135 variants Some variants of the ASUS TV-FM 7135 are handled as the ASUSTeK P7131 Analog (card=146). However

Re: [PATCH] saa7134: Fix IR support of some ASUS TV-FM 7135 variants

2010-02-10 Thread Jean Delvare
. If you don't like it and prefer the second proposal even though I think it's more of a workaround than a proper fix, it's really up to you. You're maintaining the subsystem and I am not, so you're the one deciding. Thanks, -- Jean Delvare -- To unsubscribe from this list: send the line

Re: [PATCH] saa7134: Fix IR support of some ASUS TV-FM 7135 variants

2010-02-10 Thread Jean Delvare
On Wed, 10 Feb 2010 16:40:03 -0200, Mauro Carvalho Chehab wrote: Jean Delvare wrote: Under the assumption that saa7134_hwinit1() only touches GPIOs connected to IR receivers (and it certainly looks like this to me) I fail to see how these pins not being initialized could have any effect

[PATCH] adv7180 builds since kernel 2.6.26

2010-02-05 Thread Jean Delvare
VIDEO_ADV7180 is listed twice in v4l/versions.txt: once in [2.6.31] and once in [2.6.26]. As I have tested that it builds fine in 2.6.26, drop the former entry. Signed-off-by: Jean Delvare kh...@linux-fr.org --- v4l/versions.txt |1 - 1 file changed, 1 deletion(-) --- v4l-dvb.orig/v4l

Re: [PATCH] saa7134: Fix IR support of some ASUS TV-FM 7135 variants

2010-02-01 Thread Jean Delvare
had to fake anything? What I'd like to know is simply if my first patch had any negative effect on other cards. -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] saa7134: Fix IR support of some ASUS TV-FM 7135 variants

2010-02-01 Thread Jean Delvare
Hi Hermann, On Tue, 02 Feb 2010 02:47:53 +0100, hermann pitton wrote: Hi Jean, Am Montag, den 01.02.2010, 10:56 +0100 schrieb Jean Delvare: Hi Hermann, On Mon, 01 Feb 2010 02:16:35 +0100, hermann pitton wrote: For now, I only faked a P7131 Dual with a broken IR receiver on a 2.6.29

Re: [PATCH] saa7134: Fix IR support of some ASUS TV-FM 7135 variants

2010-01-30 Thread Jean Delvare
Hi Mauro, Hermann, On Sat, 30 Jan 2010 01:47:41 +0100, hermann pitton wrote: Am Freitag, den 29.01.2010, 13:40 -0200 schrieb Mauro Carvalho Chehab: Jean Delvare wrote: From: Jean Delvare kh...@linux-fr.org Subject: saa7134: Fix IR support of some ASUS TV-FM 7135 variants Some

Re: I2C transaction questions: irq context and client locking

2010-01-17 Thread Jean Delvare
of i2c_transfer() won't please you. Either it sleeps, or it returns -EAGAIN, which you'll have to handle. If you retry forever without sleeping, it might take long before you can proceed, and performance will suffer. Hope that helps, -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe

Re: IR device at I2C address 0x7a

2010-01-10 Thread Jean Delvare
On Sun, 10 Jan 2010 00:18:46 +0100, hermann pitton wrote: Hi, Am Samstag, den 09.01.2010, 17:14 +0100 schrieb Jean Delvare: On Sat, 09 Jan 2010 13:08:36 +0100, Daro wrote: W dniu 06.01.2010 21:21, Jean Delvare pisze: On Wed, 06 Jan 2010 18:58:58 +0100, Daro wrote

Re: IR device at I2C address 0x7a

2010-01-09 Thread Jean Delvare
On Sat, 09 Jan 2010 13:08:36 +0100, Daro wrote: W dniu 06.01.2010 21:21, Jean Delvare pisze: On Wed, 06 Jan 2010 18:58:58 +0100, Daro wrote: It is not the error message itself that bothers me but the fact that IR remote control device is not detected and I cannot use it (I checked

Re: IR device at I2C address 0x7a

2010-01-06 Thread Jean Delvare
with no known IR setup. It doesn't imply your board has any I2C device at address 0x7a. So chances are that the message is harmless and you can simply ignore it. -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

Re: IR device at I2C address 0x7a:

2010-01-06 Thread Jean Delvare
it. -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: IR device at I2C address 0x7a

2010-01-06 Thread Jean Delvare
On Wed, 06 Jan 2010 20:10:30 +0100, Daro wrote: W dniu 06.01.2010 19:40, Jean Delvare pisze: On Wed, 06 Jan 2010 18:58:58 +0100, Daro wrote: It is not the error message itself that bothers me but the fact that IR remote control device is not detected and I cannot use it (I checked

Re: [PATCH 10/10] media/dvb: add __init/__exit macros to drivers/media/dvb/bt8xx/bt878.c

2010-01-05 Thread Jean Delvare
it through your tree, or please ack' it so Jiri can pull it through the trivial tree. Patch against linux-next-tree, 22. Dez 08:38:18 CET 2009 but also present in linus tree. Signed-off-by: Peter Huewe peterhu...@gmx.de Acked-by: Jean Delvare kh...@linux-fr.org --- drivers/media/dvb/bt8xx/bt878

Re: IR Receiver on an Tevii S470

2009-11-23 Thread Jean Delvare
On Sun, 22 Nov 2009 19:17:59 -0500, Andy Walls wrote: On Sun, 2009-11-22 at 21:32 +0100, Jean Delvare wrote: The fact that 0x30-0x37 and 0x50-0x5f all reply suggest that the bus driver erroneously returns success to SMBus receive byte transactions even when no device acks. This is a bug

Re: IR Receiver on an Tevii S470

2009-11-22 Thread Jean Delvare
to live in the lm-sensors package (up to 2.10.x) but is now in i2c-tools: http://www.lm-sensors.org/wiki/I2CTools With that information, I should be able to figure out what I2C address that microcontroller is listening to. -- Jean Delvare -- To unsubscribe from this list: send the line

Re: IR Receiver on an Tevii S470

2009-11-22 Thread Jean Delvare
commands for all the addresses. Beware though that some chips are known to not like it at all (in particular the infamous AT24RF08... not that I expect to ever see one on a TV adapter but you never know.) At least the above scan has already found 3 chips. -- Jean Delvare -- To unsubscribe from

Re: Details about DVB frontend API

2009-11-17 Thread Jean Delvare
calls are taken from the same original register value. One advantage is that we thus did not have to map the API to the hardware register constraints and thus have the guarantee that all hardware designs fit. I don't know if a similar logic would help for DVB. -- Jean Delvare -- To unsubscribe

Re: Details about DVB frontend API

2009-10-23 Thread Jean Delvare
Hi Devin, On Thu, 22 Oct 2009 15:27:20 -0400, Devin Heitmueller wrote: On Thu, Oct 22, 2009 at 3:13 PM, Jean Delvare kh...@linux-fr.org wrote: Hi folks, I am looking for details regarding the DVB frontend API. I've read linux-dvb-api-1.0.0.pdf, it roughly explains what the FE_READ_BER

Re: Details about DVB frontend API

2009-10-23 Thread Jean Delvare
On Thu, 22 Oct 2009 21:13:30 +0200, Jean Delvare wrote: For example, the signal strength. All I know so far is that this is a 16-bit value. But then what? Do greater values represent stronger signal or weaker signal? Are 0x and 0x special values? Is the returned value meaningful even

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-05 Thread Jean Delvare
support fast I2C, up to 400 kHz but limited to 250 kHz by the i2c-algo-bit implementation. -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-05 Thread Jean Delvare
: i2c write to 71 failed Oct 5 11:41:16 moon kernel: [45431.031468] ivtv0: i2c: Slave did not ack That would be I2C probe attempts such as the ones done by ir-kbd-i2c. Nothing to be afraid of. -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-05 Thread Jean Delvare
Hi Andy, On Sun, 04 Oct 2009 16:11:32 -0400, Andy Walls wrote: On Sun, 2009-10-04 at 10:54 +0200, Jean Delvare wrote: On Sat, 03 Oct 2009 11:44:20 -0400, Andy Walls wrote: /* This array should match the IVTV_HW_ defines */ @@ -126,7 +131,8 @@ wm8739, vp27smpx, m52790

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-04 Thread Jean Delvare
this in the details reply I'm writing right now. -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [REVIEW] ivtv, ir-kbd-i2c: Explicit IR support for the AVerTV M116 for newer kernels

2009-10-04 Thread Jean Delvare
adapters then it makes some sense to move the definitions into ir-kbd-i2c. But if devices are heavily adapter-dependent, and moving the definitions into ir-kbd-i2c doesn't allow for any code refactoring, then I don't quite see the point. -- Jean Delvare -- To unsubscribe from this list: send the line

Re: [2.6.31] ir-kbd-i2c oops.

2009-10-03 Thread Jean Delvare
Hi Pawel, On Sat, 3 Oct 2009 12:08:36 +0200, Paweł Sikora wrote: On Thursday 01 October 2009 13:43:43 Jean Delvare wrote: Pawel, please give a try to the following patch. Please keep the debug patches apply too, in case we need additional info. the second patch helps. here's a dmesg log

Re: [2.6.31] ir-kbd-i2c oops.

2009-10-03 Thread Jean Delvare
these messages? -- Jean Delvare http://khali.linux-fr.org/wishlist.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] i2c_board_info can be local

2009-10-02 Thread Jean Delvare
saa7134_dev { /* I2C keyboard data */ #if LINUX_VERSION_CODE = KERNEL_VERSION(2, 6, 30) - struct i2c_board_info info; struct IR_i2c_init_datainit_data; #endif -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

[PATCH] Fix wrong sizeof

2009-10-02 Thread Jean Delvare
Which is why I have always preferred sizeof(struct foo) over sizeof(var). Signed-off-by: Jean Delvare kh...@linux-fr.org --- linux/drivers/media/dvb/dvb-usb/ce6230.c|2 +- linux/drivers/media/video/saa7164/saa7164-cmd.c |2 +- 2 files changed, 2 insertions(+), 2 deletions

IR device at I2C address 0x7a

2009-10-02 Thread Jean Delvare
should be limited to the hardware in question. If we only have to care about the Upmost Purple TV, then the following patch should solve the problem: * * * * * From: Jean Delvare kh...@linux-fr.org Subject: saa7134: Fix IR support for Purple TV The i2c core prevents us from probing I2C address

Re: [2.6.31] ir-kbd-i2c oops.

2009-10-01 Thread Jean Delvare
Hi Andy, On Wed, 30 Sep 2009 19:42:46 -0400, Andy Walls wrote: On Wed, 2009-09-30 at 12:57 +0200, Jean Delvare wrote: Not sure why you look at address 0x83e? The stack trace says +0x64. As function ir_input_init() starts at 0x800, the oops address would be 0x864, which is: 864

Re: [2.6.31] ir-kbd-i2c oops.

2009-10-01 Thread Jean Delvare
On Thu, 01 Oct 2009 12:17:20 +0200, Paweł Sikora wrote: Dnia 01-10-2009 o 12:06:09 Jean Delvare kh...@linux-fr.org napisał(a): I'm not sure if it is the problem here, but it may be prudent to check that there's no mismatch between the module and the structure definitions being pulled

Re: [2.6.31] ir-kbd-i2c oops.

2009-10-01 Thread Jean Delvare
ts; struct saa7134_dmaqueuets_q; -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [2.6.31] ir-kbd-i2c oops.

2009-09-30 Thread Jean Delvare
Hi Pawel, I am removing the linux-i2c list from Cc, because it seems clear that your problem is related to specific media drivers and not the i2c subsystem. On Wed, 30 Sep 2009 10:16:15 +0200, Paweł Sikora wrote: On Tuesday 29 September 2009 16:16:29 Jean Delvare wrote: On Wed, 16 Sep 2009 10

Re: [2.6.31] ir-kbd-i2c oops.

2009-09-30 Thread Jean Delvare
On Wed, 30 Sep 2009 13:52:27 +0200, Paweł Sikora wrote: On Wednesday 30 September 2009 12:57:37 Jean Delvare wrote: Are you running distribution kernels or self-compiled ones? Any local patches applied? Would you be able to apply debug patches and rebuild your kernel? yes, i'm using

[PATCH] Fix adv7180 build failures with old kernels

2009-09-26 Thread Jean Delvare
The adv7180 driver is a new-style i2c driver, unconditionally using struct i2c_device_id. As such, it can't be built on kernels older than 2.6.26. Signed-off-by: Jean Delvare kh...@linux-fr.org --- v4l/versions.txt |1 + 1 file changed, 1 insertion(+) --- v4l-dvb.orig/v4l/versions.txt

Re: [2.6.31] ir-kbd-i2c oops.

2009-09-16 Thread Jean Delvare
2.6.31 would be affected, 2.6.30 wouldn't be. -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PULL] http://linuxtv.org/hg/~awalls/v4l-dvb

2009-09-06 Thread Jean Delvare
On Sun, 06 Sep 2009 12:31:24 -0400, Andy Walls wrote: On Sat, 2009-09-05 at 20:46 +0200, Jean Delvare wrote: Hi Andy, On Sat, 05 Sep 2009 10:13:41 -0400, Andy Walls wrote: Mauro, Please pull from http://linuxtv.org/hg/~awalls/v4l-dvb for the following changeset: 01

Re: [PULL] http://linuxtv.org/hg/~awalls/v4l-dvb

2009-09-05 Thread Jean Delvare
kernel for me. Thanks go to Brian Rogers for pointing out the solution in the context of submitting a patch for a few other drivers. Good catch. Acked-by: Jean Delvare kh...@linux-fr.org As far as I can see, the em28xx and saa7134 drivers have the exact same problem. Is there anyone working

Re: ir-kbd-i2c: Drop irrelevant inline keywords

2009-07-21 Thread Jean Delvare
On Mon, 20 Jul 2009 20:09:44 -0400, Andy Walls wrote: On Sun, 2009-07-19 at 14:59 +0200, Jean Delvare wrote: Functions which are referenced by their address can't be inlined by definition. Signed-off-by: Jean Delvare kh...@linux-fr.org Jean, Looks godd to me, but you forgot to add

Re: [PATCH 1/3] ir-kbd-i2c: Allow use of ir-kdb-i2c internal get_key funcs and set ir_type

2009-07-21 Thread Jean Delvare
Hi Andy, On Mon, 20 Jul 2009 20:07:50 -0400, Andy Walls wrote: On Sun, 2009-07-19 at 14:47 +0200, Jean Delvare wrote: Hi Andy, On Fri, 17 Jul 2009 16:35:37 -0400, Andy Walls wrote: This patch augments the init data passed by bridge drivers to ir-kbd-i2c so that the ir_type can

Re: [PATCH 1/3] ir-kbd-i2c: Allow use of ir-kdb-i2c internal get_key funcs and set ir_type

2009-07-19 Thread Jean Delvare
regression. This is bad. If there a bugzilla entry? If not, where can I read more details / get in touch with an affected user? -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 1/3] ir-kbd-i2c: Allow use of ir-kdb-i2c internal get_key funcs and set ir_type

2009-07-19 Thread Jean Delvare
)(struct IR_i2c*, u32*, u32*); + enum ir_kbd_get_key_fn internal_get_key_func; }; #endif -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 2/3] 2/3: cx18: Add i2c initialization for Z8F0811/Hauppage IR transceivers

2009-07-19 Thread Jean Delvare
*/ sd = v4l2_i2c_new_subdev(cx-v4l2_dev, adap, mod, type, hw_addrs[idx]); if (sd != NULL) sd-grp_id = hw; The rest looks OK. -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

Re: [PATCH 1/3] ir-kbd-i2c: Allow use of ir-kdb-i2c internal get_key funcs and set ir_type

2009-07-19 Thread Jean Delvare
On Sun, 19 Jul 2009 09:17:30 -0400, Mark Lord wrote: Mark Lord wrote: Jean Delvare wrote: Hi Mark, On Sun, 19 Jul 2009 08:52:09 -0400, Mark Lord wrote: While you folks are looking into ir-kbd-i2c, perhaps one of you will fix the regressions introduced in 2.6.31-* ? The drive

Re: [PATCH 1/3] ir-kbd-i2c: Allow use of ir-kdb-i2c internal get_key funcs and set ir_type

2009-07-19 Thread Jean Delvare
they first try 2.6.31 after release ? Where does lsinput get the string from? What exactly was it before, and what is it exactly in 2.6.31? -- Jean Delvare -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 3/3] ir-kbd-i2c: Add support for Z8F0811/Hauppage IR transceivers

2009-07-19 Thread Jean Delvare
entry for any IR receiver */ { ir_video, 0 }, - /* IR device specific entries could be added here */ + /* IR device specific entries should be added here */ + { ir_rx_z8f0811_haup, 0 }, { } }; Yes, looks good. -- Jean Delvare -- To unsubscribe from this list: send

Re: Regression 2.6.31: ioctl(EVIOCGNAME) no longer returns device name

2009-07-19 Thread Jean Delvare
On Sun, 19 Jul 2009 15:20:50 -0400, Mark Lord wrote: Mark Lord wrote: (resending.. somebody trimmed linux-kernel from the CC: earlier) FWIW I don't think it was there in the first place. Jean Delvare wrote: On Sun, 19 Jul 2009 10:38:37 -0400, Mark Lord wrote: I'm debugging various other

Re: [RFC] Anticipating lirc breakage

2009-07-09 Thread Jean Delvare
On Thu, 9 Jul 2009 11:44:46 -0400, Jarod Wilson wrote: On Tuesday 07 April 2009 08:36:17 Jean Delvare wrote: So, let's just forget the workarounds and go straight to the point: focus on merging lirc-i2c drivers. Will this happen next week? I fear not. Which is why I can't wait

Re: [PATCH 1/2] Compatibility layer for hrtimer API

2009-07-05 Thread Jean Delvare
Hi Trent, On Sun, 5 Jul 2009 01:13:14 -0700 (PDT), Trent Piepho wrote: On Fri, 3 Jul 2009, Jean Delvare wrote: Kernels 2.6.22 to 2.6.24 (inclusive) need some compatibility quirks for the hrtimer API. For older kernels, some required functions were not exported so there's nothing we can do

Re: [PATCH] cx88: High resolution timer for Remote Controls

2009-07-03 Thread Jean Delvare
On Thu, 2 Jul 2009 16:50:35 +0200, Jean Delvare wrote: From: Andrzej Hajda andrzej.ha...@wp.pl Patch solves problem of missed keystrokes on some remote controls, as reported on http://bugzilla.kernel.org/show_bug.cgi?id=9637 . Signed-off-by: Andrzej Hajda andrzej.ha...@wp.pl Signed-off

[PATCH 2/2] cx88: High resolution timer for Remote Controls

2009-07-03 Thread Jean Delvare
Patch solves problem of missed keystrokes on some remote controls, as reported on http://bugzilla.kernel.org/show_bug.cgi?id=9637 . Signed-off-by: Andrzej Hajda andrzej.ha...@wp.pl Signed-off-by: Jean Delvare kh...@linux-fr.org --- Changes: * Driver no longer builds on kernels 2.6.22, so add

<    1   2   3   4   >