Re: [PATCH] dma-fence: fix dma_fence_get_rcu_safe

2017-09-29 Thread Joonas Lahtinen
ence->ops->release into call_rcu() to keep the whole RCU handling outside > > of the individual drivers. > > Hm, I entirely dropped the ball on this, I kinda assumed that we managed > to get some agreement on this between i915 and dma_fence. Adding a pile > more people. > >

Re: [Intel-gfx] [PATCH] dma-buf: Release module reference on creation failure

2016-03-31 Thread Joonas Lahtinen
TR(ret); Labels could really be err_dmabuf (/ out_dmabuf). That's more in line with rest of the codebase and kernel coding style: 'An example of a good name could be "out_buffer:" if the goto frees "buffer".' "free_dmabuf" does sound to me like it could also be execu