On 1/13/2015 11:05 PM, Nicolas Ferre wrote:
Le 04/01/2015 10:02, Josh Wu a écrit :
This patch series add ISI and ov2640 support on dts files.
As the ov2640 driver dt is still in review. The patch is in:
https://patchwork.linuxtv.org/patch/27554/
So I want to send this dt patch early for a
According to v4l2 dt document, we add:
a camera host: ISI port.
a i2c camera sensor: ov2640 port.
to sama5d3xmb.dtsi.
The ov2640 node defines the pinctrls, clocks and refer to isi port.
The ISI node also has a reference to the ov2640 port.
Signed-off-by: Josh Wu
---
v1 -> v2:
1. move
Signed-off-by: Josh Wu
Acked-by: Alexandre Belloni
---
arch/arm/configs/sama5_defconfig | 6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig
index b58fb32..92f1d71 100644
--- a/arch/arm/configs/sama5_defconfig
+++ b/arch
Hi, Guennadi and Laurent
On 1/9/2015 6:47 AM, Laurent Pinchart wrote:
Hi Guennadi and Josh,
On Thursday 08 January 2015 23:37:58 Guennadi Liakhovetski wrote:
On Wed, 7 Jan 2015, Josh Wu wrote:
On 1/7/2015 6:17 AM, Guennadi Liakhovetski wrote:
On Tue, 6 Jan 2015, Josh Wu wrote:
Hi, Guennadi
Hi, Guennadi
On 1/7/2015 6:17 AM, Guennadi Liakhovetski wrote:
Hi Josh,
On Tue, 6 Jan 2015, Josh Wu wrote:
Hi, Guennadi
After look deep into this patch, I found you miss one line that should be
changed as well.
It's In function v4l2_clk_get(), there still has one line code c
Hi, Guennadi
On 1/7/2015 6:17 AM, Guennadi Liakhovetski wrote:
Hi Josh,
On Tue, 6 Jan 2015, Josh Wu wrote:
Hi, Guennadi
After look deep into this patch, I found you miss one line that should be
changed as well.
It's In function v4l2_clk_get(), there still has one line code c
dup(id, GFP_KERNEL);
clk->dev_id = kstrdup(dev_id, GFP_KERNEL);
- if ((id && !clk->id) || !clk->dev_id) {
+ if (!clk->dev_id) {
ret = -ENOMEM;
goto ealloc;
}
@@ -205,7 +205,7 @@ struct v4l2_clk *v4l2_clk_register(const struct
v4l2_cl
Hi, Guennadi
On 1/5/2015 5:28 PM, Guennadi Liakhovetski wrote:
Hi Josh,
On Mon, 5 Jan 2015, Josh Wu wrote:
Hi, Guennadi
On 1/2/2015 7:48 PM, Guennadi Liakhovetski wrote:
All uses of the v4l2_clk API so far only register one clock with a fixed
name. This allows us to get rid of it, which
On 1/5/2015 5:36 PM, Guennadi Liakhovetski wrote:
On Mon, 5 Jan 2015, Josh Wu wrote:
Hi, Guennadi
On 1/3/2015 4:18 AM, Guennadi Liakhovetski wrote:
From aeaee56e04d023f3a019d2595ef5128015acdb06 Mon Sep 17 00:00:00 2001
From: Guennadi Liakhovetski
Date: Fri, 2 Jan 2015 12:26:41 +0100
herwise there is no error
reported if we use IS_ERR(ccf_clk).
Best Regards,
Josh Wu
+
+ if (!IS_ERR(ccf_clk)) {
+ clk = kzalloc(sizeof(struct v4l2_clk), GFP_KERNEL);
+ if (!clk) {
+ clk_put(ccf_clk);
+
4l2 clock with id is NULL?
How about define a SOC_CAMERA_HOST_CLK_ID in soc_camera.h, like:
#define SOC_CAMERA_HOST_CLK_IDNULL
then we can rewrite this block code to:
clk->ops = ops;
clk->priv = priv;
+ clk->id = SOC_CAMERA_HOST_CLK_ID;
atomic_set(&cl
. I will test these patches tomorrow.
Best Regards,
Josh Wu
Thanks
Guennadi
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
sensor's
DT node.
Signed-off-by: Josh Wu
---
new added in v2.
arch/arm/boot/dts/sama5d3xmb.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/sama5d3xmb.dtsi
b/arch/arm/boot/dts/sama5d3xmb.dtsi
index db47f8b..d9464fc 100644
--- a/arch/arm/boo
From: Bo Shen
The mck is decided by the board design, move it to mb related
dtsi file.
Signed-off-by: Bo Shen
Acked-by: Nicolas Ferre
Acked-by: Alexandre Belloni
Signed-off-by: Josh Wu
---
arch/arm/boot/dts/sama5d3.dtsi| 5 -
arch/arm/boot/dts/sama5d3xmb.dtsi | 5 +
2 files
pinctrl from ISI's
DT node. We will add these two pinctrl to sensor's DT node.
Signed-off-by: Josh Wu
---
v1 -> v2:
1. only do things that mentioned in commit message.
arch/arm/boot/dts/sama5d3xmb.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch
From: Bo Shen
The ISI has 12 data lines, add the missing two data lines.
Signed-off-by: Bo Shen
Acked-by: Nicolas Ferre
Acked-by: Alexandre Belloni
---
arch/arm/boot/dts/sama5d3.dtsi | 6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/
Add ISI peripheral clock in sama5d3.dtsi.
Signed-off-by: Josh Wu
Acked-by: Alexandre Belloni
---
arch/arm/boot/dts/sama5d3.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi
index 5f4144d..61746ef 100644
--- a/arch/arm
From: Bo Shen
As the ISI has 12 data lines, however we only use 8 data lines with
sensor module. So, split the data line into two groups which make
it can be choosed depends on the hardware design.
Signed-off-by: Bo Shen
Acked-by: Nicolas Ferre
Acked-by: Alexandre Belloni
Signed-off-by: Josh
mck pin to mb
Josh Wu (5):
ARM: at91: dts: sama5d3: add isi clock
ARM: at91: dts: sama5d3: change name of pinctrl_isi_{power,reset}
ARM: at91: dts: sama5d3: change name of pinctrl of ISI_MCK
ARM: at91: dts: sama5d3: add ov2640 camera sensor support
ARM: at91: sama5: enable atmel-isi
urent Pinchart wrote:
Hi Guennadi,
On Friday 26 December 2014 11:38:11 Guennadi Liakhovetski wrote:
On Fri, 26 Dec 2014, Laurent Pinchart wrote:
On Friday 26 December 2014 10:14:26 Guennadi Liakhovetski wrote:
On Fri, 26 Dec 2014, Laurent Pinchart wrote:
On Friday 26 December 2014 14:37:14 Jo
Hi, Laurent
On 12/30/2014 8:15 AM, Laurent Pinchart wrote:
Hi Josh,
On Monday 29 December 2014 16:28:02 Josh Wu wrote:
On 12/26/2014 6:06 PM, Laurent Pinchart wrote:
On Friday 26 December 2014 10:14:26 Guennadi Liakhovetski wrote:
On Fri, 26 Dec 2014, Laurent Pinchart wrote:
On Friday 26
Hi, Laurent and Guennadi
On 12/26/2014 6:06 PM, Laurent Pinchart wrote:
Hi Guennadi,
On Friday 26 December 2014 10:14:26 Guennadi Liakhovetski wrote:
On Fri, 26 Dec 2014, Laurent Pinchart wrote:
On Friday 26 December 2014 14:37:14 Josh Wu wrote:
On 12/25/2014 6:39 AM, Guennadi Liakhovetski
Hi, Guennadi
Thanks for the reply.
And Merry Christmas and happy new year.
On 12/25/2014 6:39 AM, Guennadi Liakhovetski wrote:
Hi Josh,
On Mon, 22 Dec 2014, Josh Wu wrote:
Hi, Guennadi
On 12/20/2014 6:16 AM, Guennadi Liakhovetski wrote:
On Fri, 19 Dec 2014, Josh Wu wrote:
Hi, Guennadi
Hi, Sylwester
On 12/18/2014 8:13 PM, Sylwester Nawrocki wrote:
Hi Josh,
On 18/12/14 03:27, Josh Wu wrote:
Add the document for ov2640 dt.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu
Acked-by: Sylwester Nawrocki
Thanks.
It seems "ovti" is not in the list of vendo
Hi, Guennadi
On 12/20/2014 6:16 AM, Guennadi Liakhovetski wrote:
On Fri, 19 Dec 2014, Josh Wu wrote:
Hi, Guennadi
Thanks for the review.
On 12/19/2014 5:59 AM, Guennadi Liakhovetski wrote:
Hi Josh,
Thanks for your patches!
On Thu, 18 Dec 2014, Josh Wu wrote:
To support async probe for
Hi, Alexandre
Thanks for the review.
On 12/20/2014 5:05 AM, Alexandre Belloni wrote:
On 18/12/2014 at 16:51:06 +0800, Josh Wu wrote :
According to v4l2 dt document, we add:
a camera host: ISI port.
a i2c camera sensor: ov2640 port.
to sama5d3xmb.dtsi.
In the ov2640 node, it defines the
Hi, Guennadi
Thanks for the review.
On 12/19/2014 5:59 AM, Guennadi Liakhovetski wrote:
Hi Josh,
Thanks for your patches!
On Thu, 18 Dec 2014, Josh Wu wrote:
To support async probe for ov2640, we need remove the code to get 'mclk'
in ov2640_probe() function. oterwise, if soc_came
Hi, Laurent
On 12/18/2014 8:32 PM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Thursday 18 December 2014 16:51:06 Josh Wu wrote:
According to v4l2 dt document, we add:
a camera host: ISI port.
a i2c camera sensor: ov2640 port.
to sama5d3xmb.dtsi.
In the ov2640 node
Signed-off-by: Josh Wu
---
arch/arm/configs/sama5_defconfig | 6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig
index b58fb32..92f1d71 100644
--- a/arch/arm/configs/sama5_defconfig
+++ b/arch/arm/configs/sama5_defconfig
According to v4l2 dt document, we add:
a camera host: ISI port.
a i2c camera sensor: ov2640 port.
to sama5d3xmb.dtsi.
In the ov2640 node, it defines the pinctrls, clocks and isi port.
In the ISI node, it also reference to a ov2640 port.
Signed-off-by: Josh Wu
---
arch/arm/boot/dts
For sama5d3xmb board, the pins: pinctrl_isi_{power,reset} is used to
power-down or reset camera sensor.
So we should let camera sensor instead of ISI to configure the pins.
This patch will change pinctrl name from pinctrl_isi_{power,reset} to
pinctrl_sensor_{power,reset}.
Signed-off-by: Josh Wu
From: Bo Shen
The mck is decided by the board design, move it to mb related
dtsi file.
Signed-off-by: Bo Shen
Acked-by: Nicolas Ferre
Signed-off-by: Josh Wu
---
arch/arm/boot/dts/sama5d3.dtsi| 5 -
arch/arm/boot/dts/sama5d3xmb.dtsi | 5 +
2 files changed, 5 insertions(+), 5
Add ISI peripheral clock in sama5d3.dtsi.
Signed-off-by: Josh Wu
---
arch/arm/boot/dts/sama5d3.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi
index 5f4144d..61746ef 100644
--- a/arch/arm/boot/dts/sama5d3.dtsi
+++ b/arch
From: Bo Shen
As the ISI has 12 data lines, however we only use 8 data lines with
sensor module. So, split the data line into two groups which make
it can be choosed depends on the hardware design.
Signed-off-by: Bo Shen
Acked-by: Nicolas Ferre
Signed-off-by: Josh Wu
---
arch/arm/boot/dts
From: Bo Shen
The ISI has 12 data lines, add the missing two data lines.
Signed-off-by: Bo Shen
Acked-by: Nicolas Ferre
---
arch/arm/boot/dts/sama5d3.dtsi | 6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi
index 595609f..b
: sama5d3: add missing pins of isi
ARM: at91: dts: sama5d3: move the isi mck pin to mb
Josh Wu (4):
ARM: at91: dts: sama5d3: add isi clock
ARM: at91: dts: sama5d3: change name of pinctrl_isi_{power,reset}
ARM: at91: dts: sama5d3: add ov2640 camera sensor support
ARM: at91: sama5: enable atmel
Add the document for ov2640 dt.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu
---
v3 -> v4:
1. remove aggsigned-clocks as it's general.
2. refine the explation.
v2 -> v3:
1. fix incorrect description.
2. Add assigned-clocks & assigned-clock-rates.
3. reset
The master clock (xvclk) is mandatory. It's a common clock framework clock.
It can make sensor output a pixel clock to the camera interface.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu
Acked-by: Laurent Pinchart
---
v3 -> v4:
1. Add Laurent's acked by.
v2 -> v3:
Add device tree support for ov2640.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu
Acked-by: Laurent Pinchart
---
v3 -> v4:
1.modify the code comment.
2. Add Laurent's acked by.
v2 -> v3:
1. fix gpiod usage.
2. refine the ov2640_probe() function.
v1 -> v2:
1.
getting code to ov2640_s_power()
function. That make ov2640 survive, as we can pass a NULL (priv-clk) to
soc_camera_set_power() function.
And if soc_camera host is probed, the when ov2640_s_power() is called,
then we can get the 'mclk' and that make us enable/disable soc_camera
host&
icd->control is the sub device dev, i.e. i2c device.
icd->pdev is the soc camera device's device.
To be consitent with power() function, we will call reset() with
icd->control as well.
Signed-off-by: Josh Wu
---
v3->v4:
none
v2->v3:
1. check whether icd->control is
ree binding document.
v1 -> v2:
1. modified the dt bindings according to Laurent's suggestion.
2. add a fix patch for soc_camera. Otherwise the .reset() function won't work.
Josh Wu (5):
media: soc-camera: use icd->control instead of icd->pdev for reset()
media: ov2640: ad
Hi, Laurent
On 12/12/2014 10:17 AM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Thursday 11 December 2014 15:35:39 Josh Wu wrote:
Add the document for ov2640 dt.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu
---
v2 -> v3:
1. fix incorrect description.
2.
Hi, Laurent
On 12/11/2014 4:10 PM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
I only have three minor comments. After fixing them,
Acked-by: Laurent Pinchart
Thanks for the review.
On Thursday 11 December 2014 15:35:37 Josh Wu wrote:
Add device tree support for ov2640
Add the document for ov2640 dt.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu
---
v2 -> v3:
1. fix incorrect description.
2. Add assigned-clocks & assigned-clock-rates.
3. resetb pin should be ACTIVE_LOW.
v1 -> v2:
1. change the compatible string to be consistent w
The master clock (xvclk) is mandatory. It's a common clock framework clock.
It can make sensor output a pixel clock to the camera interface.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu
---
v2 -> v3:
1. should return PTR_ERR().
v1 -> v2:
1. change the clock's nam
Add device tree support for ov2640.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu
---
v2 -> v3:
1. fix gpiod usage.
2. refine the ov2640_probe() function.
v1 -> v2:
1. use gpiod APIs.
2. change the gpio pin's name according to datasheet.
3. reduce the delay
getting code to ov2640_s_power()
function. That make ov2640 survive, as we can pass a NULL (priv-clk) to
soc_camera_set_power() function.
And if soc_camera host is probed, the when ov2640_s_power() is called,
then we can get the 'mclk' and that make us enable/disable soc_camera
host&
icd->control is the sub device dev, i.e. i2c device.
icd->pdev is the soc camera device's device.
To be consitent with power() function, we will call reset() with
icd->control as well.
Signed-off-by: Josh Wu
---
v2->v3:
1. check whether icd->control is NULL or not.
dr
rent's suggestion.
2. add a fix patch for soc_camera. Otherwise the .reset() function won't work.
Josh Wu (5):
media: soc-camera: use icd->control instead of icd->pdev for reset()
media: ov2640: add async probe function
media: ov2640: add primary dt support
media: ov2640:
Hi, Laurent
On 12/9/2014 2:59 AM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Monday 08 December 2014 19:29:07 Josh Wu wrote:
Add the document for ov2640 dt.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu
---
v1 -> v2:
1. change the compatible string to
Hi, Laurent
On 12/9/2014 2:39 AM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Monday 08 December 2014 19:29:05 Josh Wu wrote:
Add device tree support for ov2640.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu
---
v1 -> v2:
1. use gpiod APIs.
2. change the g
Hi, Fabio
On 12/8/2014 11:10 PM, Fabio Estevam wrote:
On Mon, Dec 8, 2014 at 9:29 AM, Josh Wu wrote:
+ priv->master_clk = devm_clk_get(&client->dev, "xvclk");
+ if (IS_ERR(priv->master_clk))
+ return -EINVAL;
You should return PTR_ERR(pr
Add the document for ov2640 dt.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu
---
v1 -> v2:
1. change the compatible string to be consistent with verdor file.
2. change the clock and pins' name.
3. add missed pinctrl in example.
.../devicetree/bindings/media/i2c/ov
icd->control is the sub device dev, i.e. i2c device.
icd->pdev is the soc camera device's device.
To be consitent with power() function, we will call reset() with
icd->control as well.
Signed-off-by: Josh Wu
---
drivers/media/platform/soc_camera/soc_camera.c | 10 ++
1 f
The master clock (xvclk) is mandatory. It's a common clock framework clock.
It can make sensor output a pixel clock to the camera interface.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu
---
v1 -> v2:
1. change the clock's name.
2. Make the clock is mandatory.
driv
Add device tree support for ov2640.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu
---
v1 -> v2:
1. use gpiod APIs.
2. change the gpio pin's name according to datasheet.
3. reduce the delay for .reset() function.
drivers/media/i2c/soc_camera/ov264
This patch series add device tree support for ov2640. And also add
the document for the devicetree properties.
v1 -> v2:
1. modified the dt bindings according to Laurent's suggestion.
2. add a fix patch for soc_camera. Otherwise the .reset() function won't work.
Josh Wu (5):
getting code to ov2640_s_power()
function. That make ov2640 survive, as we can pass a NULL (priv-clk) to
soc_camera_set_power() function.
And if soc_camera host is probed, the when ov2640_s_power() is called,
then we can get the 'mclk' and that make us enable/disable soc_camera
host&
Hi, Laurent
On 12/2/2014 6:33 AM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Friday 28 November 2014 18:28:25 Josh Wu wrote:
Add device tree support for ov2640.
Cc:devicet...@vger.kernel.org
Signed-off-by: Josh Wu
---
drivers/media/i2c/soc_camera/ov2640.c | 95
Hi, Laurent
On 12/2/2014 6:26 AM, Laurent Pinchart wrote:
Hi Josh,
(CC'ing the devicet...@vger.kernel.org mailing list)
Thank you for the patch.
On Friday 28 November 2014 18:28:26 Josh Wu wrote:
The master clock can be optional. It's a common clock framework clock.
It can m
Hi, Laurent
On 12/2/2014 6:14 AM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Friday 28 November 2014 18:28:27 Josh Wu wrote:
Add the document for ov2640 dt.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu
---
.../devicetree/bindings/media/i2c/ov2640.txt | 43
Add device tree support for ov2640.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu
---
drivers/media/i2c/soc_camera/ov2640.c | 95 ---
1 file changed, 89 insertions(+), 6 deletions(-)
diff --git a/drivers/media/i2c/soc_camera/ov2640.c
b/drivers/media/i2c
Add the document for ov2640 dt.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu
---
.../devicetree/bindings/media/i2c/ov2640.txt | 43 ++
1 file changed, 43 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/i2c/ov2640.txt
diff --git a
The master clock can be optional. It's a common clock framework clock.
It can make sensor output a pixel clock to the camera interface.
If you just use a external oscillator clock as the master clock, then,
just don't need set 'mck' in dt node.
Signed-off-by: Josh Wu
--
This patch series add device tree support for ov2640. And also add
the document for the devicetree properties.
Josh Wu (4):
media: ov2640: add async probe function
media: ov2640: add primary dt support
media: ov2640: add a master clock for sensor
media: ov2640: dt: add the device tree
getting code to ov2640_s_power()
function. That make ov2640 survive, as we can pass a NULL (priv-clk) to
soc_camera_set_power() function.
And if soc_camera host is probed, the when ov2640_s_power() is called,
then we can get the 'mclk' and that make us enable/disable soc_camera
host&
This patch series add device tree support for ov2640. And also add
the document for the devicetree properties.
Josh Wu (4):
media: ov2640: add async probe function
media: ov2640: add primary dt support
media: ov2640: add a master clock for sensor
media: ov2640: dt: add the device tree
Hi, Guennadi
On 11/26/2014 6:23 AM, Guennadi Liakhovetski wrote:
Hi Josh,
On Tue, 25 Nov 2014, Josh Wu wrote:
Add SVGA, UXGA and XGA size definitions to v4l2-image-sizes.h.
The definitions are sorted by alphabet order.
Signed-off-by: Josh Wu
Thanks for your patches. I'm ok with thes
SVGA height should be 600 not 680.
Reported-by: Sylwester Nawrocki
Signed-off-by: Josh Wu
---
Hi, Mauro
There a typo in my previous patch, so this patch is the fix for that.
Sorry for the incovenience.
Best Regards,
Josh Wu
include/media/v4l2-image-sizes.h | 2 +-
1 file changed, 1
Hi, Gunenadi
On 11/26/2014 6:21 AM, Guennadi Liakhovetski wrote:
Hi Josh,
On Tue, 25 Nov 2014, Josh Wu wrote:
The burst length could be BEATS_4/8/16. Before this patch, isi use default
value BEATS_4. To imporve the performance we could set it to BEATS_16.
Otherwise sometime it would cause
Hi, Sylwester and Mauro
On 11/25/2014 6:34 PM, Sylwester Nawrocki wrote:
Hi Josh,
On 25/11/14 09:54, Josh Wu wrote:
Add SVGA, UXGA and XGA size definitions to v4l2-image-sizes.h.
The definitions are sorted by alphabet order.
Signed-off-by: Josh Wu
---
include/media/v4l2-image-sizes.h | 9
The burst length could be BEATS_4/8/16. Before this patch, isi use default
value BEATS_4. To imporve the performance we could set it to BEATS_16.
Otherwise sometime it would cause the ISI overflow error.
Reported-by: Bo Shen
Signed-off-by: Josh Wu
---
drivers/media/platform/soc_camera/atmel
Reuse the v4l2 size definitions from v4l2-image-sizes.h.
So we can remove the rudundent definitions from ov2640.c.
Signed-off-by: Josh Wu
---
drivers/media/i2c/soc_camera/ov2640.c | 82 +--
1 file changed, 30 insertions(+), 52 deletions(-)
diff --git a/drivers
Add SVGA, UXGA and XGA size definitions to v4l2-image-sizes.h.
The definitions are sorted by alphabet order.
Signed-off-by: Josh Wu
---
include/media/v4l2-image-sizes.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/include/media/v4l2-image-sizes.h b/include/media/v4l2-image
This patch add the DT support for Atmel ISI driver.
It use the same v4l2 DT interface that defined in video-interfaces.txt.
Signed-off-by: Josh Wu
Cc: devicet...@vger.kernel.org
Reviewed-by: Laurent Pinchart
---
v3 -> v4:
When bus width is 10, we support both 8 & 10 bits.
Use of_ma
Signed-off-by: Josh Wu
---
v3 -> v4:
no change.
drivers/media/platform/soc_camera/atmel-isi.c | 5 +
include/media/atmel-isi.h | 4
2 files changed, 9 insertions(+)
diff --git a/drivers/media/platform/soc_camera/atmel-isi.c
b/drivers/media/platform/soc_cam
Now the platform data is initialized by allocation of isi
structure. In the future, we use pdata to store the dt parameters.
Signed-off-by: Josh Wu
---
v3 -> v4:
no change.
v2 -> v3:
use sizeof(isi->pdata) instead of using sizeof(struct).
drivers/media/platform/soc_camera/atmel-i
modified the device tree binding document to remove an optonal property.
Josh Wu (3):
atmel-isi: add v4l2 async probe support
atmel-isi: convert the pdata from pointer to structure
atmel-isi: add primary DT support
.../devicetree/bindings/media/atmel-isi.txt| 51
driv
Hi, Guennadi
On 7/27/2014 3:57 AM, Guennadi Liakhovetski wrote:
Hi Josh,
Thanks for a prompt update! A couple of minor questions:
On Fri, 25 Jul 2014, Josh Wu wrote:
This patch add the DT support for Atmel ISI driver.
It use the same v4l2 DT interface that defined in video-interfaces.txt
This patch add the DT support for Atmel ISI driver.
It use the same v4l2 DT interface that defined in video-interfaces.txt.
Signed-off-by: Josh Wu
Cc: devicet...@vger.kernel.org
Reviewed-by: Laurent Pinchart
---
v2 -> v3:
add bus-width property support.
add error handling when call
Signed-off-by: Josh Wu
---
v2 -> v3:
no change.
drivers/media/platform/soc_camera/atmel-isi.c | 5 +
include/media/atmel-isi.h | 4
2 files changed, 9 insertions(+)
diff --git a/drivers/media/platform/soc_camera/atmel-isi.c
b/drivers/media/platform/soc_cam
Now the platform data is initialized by allocation of isi
structure. In the future, we use pdata to store the dt parameters.
Signed-off-by: Josh Wu
---
v2 -> v3:
use sizeof(isi->pdata) instead of using sizeof(struct).
drivers/media/platform/soc_camera/atmel-isi.
This patch series add DT support for atmel ISI driver. It can support the
common v4l2 DT interfaces.
v2 -> v3:
support bus-width property for atmel-isi endpoint.
v1 -> v2:
modified the device tree binding document to remove an optonal property.
Josh Wu (3):
atmel-isi: add v4l2 async
subdevices]
Signed-off-by: Guennadi Liakhovetski
I tested in sama5d3xek board with Atmel-isi dt and ov2640 dt. It works fine.
Tested-by: Josh Wu
Best Regards,
Josh Wu
---
Hi Ben,
How about this version? Could you review and test?
Thanks
Guennadi
drivers/media/platform/soc_camera/soc_camera.c
Best Regards,
Josh Wu
On Monday 31 March 2014 17:05:13 Josh Wu wrote:
Dear Guennadi
On 3/31/2014 5:20 AM, Guennadi Liakhovetski wrote:
Hi Josh,
Please correct me if I'm wrong, but I don't see how this is going to work
without the central part - building asynchronous V4L2 data structu
ue, 25 Mar 2014, Josh Wu wrote:
Now the platform data is initialized by allocation of isi
structure. In the future, we use pdata to store the dt parameters.
Signed-off-by: Josh Wu
---
v1 --> v2:
no change.
drivers/media/platform/soc_camera/atmel-isi.c | 22 +++---
1
Hi, Guennadi
On 5/19/2014 5:51 AM, Guennadi Liakhovetski wrote:
On Tue, 25 Mar 2014, Josh Wu wrote:
This patch add the DT support for Atmel ISI driver.
It use the same v4l2 DT interface that defined in video-interfaces.txt.
Signed-off-by: Josh Wu
Cc: devicet...@vger.kernel.org
---
v1 -->
k. Am
I missing something?
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
Best Regards,
Josh Wu
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, Ben
On 3/31/2014 6:10 PM, Ben Dooks wrote:
On 31/03/14 10:28, Josh Wu wrote:
Hi, Ben
Thanks for the patch, I just test atmel-isi with the your patch,
I find the "mclk" registered in soc-camera driver cannot be find
by the soc-camera sensors. See comment in below:
Ok, I gues
+ icd->sasc = sasc;
> + icd->parent = ici->v4l2_dev.dev;
> +
> + snprintf(clk_name, sizeof(clk_name), "of-%s",
> + of_node_full_name(remote));
The clk_name you register here is a OF string, but for the i2c sensors, which
call the v4l2_clk_g
So I think this patch is ready for the mainline.
BTW: I will test Ben's patch with atmel-isi.
thanks and best regards,
Josh Wu
Thanks
Guennadi
On Tue, 25 Mar 2014, Josh Wu wrote:
This patch add the DT support for Atmel ISI driver.
It use the same v4l2 DT interface that defined in video
Hi, all
since v4l2_clk_get() WON'T return EPROBE_DEFER. So this version of patch
is invalid.
Please drop this version of the patch.
Sorry for the noise.
Best Regards,
Josh Wu
On 3/20/2014 5:01 PM, Josh Wu wrote:
Since the the v4l2_clk_get() may return a EPROBE_DEFER during async
probin
Hi, Sylwester
On 3/20/2014 10:44 PM, Sylwester Nawrocki wrote:
Hi Josh,
On 19/03/14 10:17, Josh Wu wrote:
On 3/15/2014 5:17 AM, Sylwester Nawrocki wrote:
On 03/14/2014 11:12 AM, Josh Wu wrote:
+clk = v4l2_clk_get(&client->dev, "mclk");
+if (IS_ERR(clk))
+ret
This patch add the DT support for Atmel ISI driver.
It use the same v4l2 DT interface that defined in video-interfaces.txt.
Signed-off-by: Josh Wu
Cc: devicet...@vger.kernel.org
---
v1 --> v2:
refine the binding document.
add port node description.
removed the optional prope
Now the platform data is initialized by allocation of isi
structure. In the future, we use pdata to store the dt parameters.
Signed-off-by: Josh Wu
---
v1 --> v2:
no change.
drivers/media/platform/soc_camera/atmel-isi.c | 22 +++---
1 file changed, 11 insertions(+),
Signed-off-by: Josh Wu
---
v1 --> v2:
no change.
drivers/media/platform/soc_camera/atmel-isi.c |5 +
include/media/atmel-isi.h |4
2 files changed, 9 insertions(+)
diff --git a/drivers/media/platform/soc_camera/atmel-isi.c
b/drivers/media/platf
This patch series add DT support for atmel ISI driver. It can support the
common v4l2 DT interfaces.
v1 --> v2:
modified the device tree binding document to remove the a optional property.
Josh Wu (3):
[media] atmel-isi: add v4l2 async probe support
[media] atmel-isi: convert the pd
Since the the v4l2_clk_get() may return a EPROBE_DEFER during async
probing. So move the v4l2_clk_get() to the beginning of the
probe(). Only when we get mclk successfully we continue the probe.
Signed-off-by: Josh Wu
---
v1 -> v2:
just return PTR_ERR(clk) as it can be -EPROBE_DEFER.
refi
Hi, Sylwester
Thanks for your review.
On 3/15/2014 5:17 AM, Sylwester Nawrocki wrote:
Hi Josh,
On 03/14/2014 11:12 AM, Josh Wu wrote:
+clk = v4l2_clk_get(&client->dev, "mclk");
+if (IS_ERR(clk))
+return -EPROBE_DEFER;
You should instead make it:
r
101 - 200 of 232 matches
Mail list logo
