= i2c_get_clientdata(client);
- kfree(dec);
+ v4l2_device_unregister_subdev(sd);
+ kfree(to_state(sd));
return 0;
}
Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo
before I forget about this patch, what was the status of this one?
On 03/06/2012 06:55 AM, Justin P. Mattock wrote:
From: Justin P. Mattockjustinmatt...@gmail.com
linux-next:
I like to spend some time reading code, in doing so I have found some typos in
some of the comments.
The patch below
On 03/16/2012 08:45 AM, Jiri Kosina wrote:
On Fri, 16 Mar 2012, Justin P. Mattock wrote:
before I forget about this patch, what was the status of this one?
As previously announced multiple times, I am ignoring patches that go to
drivers/staging and letting Greg pick them up if he wants
On 03/16/2012 08:58 AM, Greg KH wrote:
On Fri, Mar 16, 2012 at 04:45:03PM +0100, Jiri Kosina wrote:
On Fri, 16 Mar 2012, Justin P. Mattock wrote:
before I forget about this patch, what was the status of this one?
As previously announced multiple times, I am ignoring patches that go
On 03/16/2012 09:06 AM, Justin P. Mattock wrote:
On 03/16/2012 08:58 AM, Greg KH wrote:
On Fri, Mar 16, 2012 at 04:45:03PM +0100, Jiri Kosina wrote:
On Fri, 16 Mar 2012, Justin P. Mattock wrote:
before I forget about this patch, what was the status of this one?
As previously announced
From: Justin P. Mattock justinmatt...@gmail.com
linux-next:
I like to spend some time reading code, in doing so I have found some typos in
some of the comments.
The patch below fixes what I have found.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/staging/media/Kconfig
From: Justin P. Mattock justinmatt...@gmail.com
linux-next:
I like to spend some time reading code, in doing so I have found some typos in
some of the comments.
The patch below fixes what I have found.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/staging/media/Kconfig
On 03/05/2012 09:28 AM, David Santinoli wrote:
On Mon, Mar 05, 2012 at 07:49:26AM -0800, Justin P. Mattock wrote:
- The two functions bellow implements the newer ioctls
+ The two functions bellow implement the newer ioctls
There's still some room for improvement here. :-)
Cheers,
David
From: Justin P. Mattock justinmatt...@gmail.com
The below patch, changes clock_settting to clock_setting.
Note: This could be intentionally set this way from the beginning and/or is a
typo.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/media/dvb/frontends/s5h1420.c
The patch below removes an extra l in the word.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/media/video/cx18/cx23418.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/cx18/cx23418.h
b/drivers/media/video/cx18/cx23418.h
The patch below removes an extra l in the word.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/media/video/cx231xx/cx231xx.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/cx231xx/cx231xx.h
b/drivers/media/video/cx231xx
On 01/03/2011 07:01 AM, Jiri Kosina wrote:
On Fri, 31 Dec 2010, Mauro Carvalho Chehab wrote:
Em 30-12-2010 21:08, Justin P. Mattock escreveu:
The below patch fixes a typo diable to disable. Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattockjustinmatt...@gmail.com
On 01/01/2011 01:09 AM, Dan Carpenter wrote:
On Fri, Dec 31, 2010 at 11:43:30PM -0800, Justin P. Mattock wrote:
On 12/31/2010 10:48 PM, Finn Thain wrote:
-/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE
means enable, other values are diable
On 12/31/2010 02:27 AM, Mauro Carvalho Chehab wrote:
Em 30-12-2010 21:08, Justin P. Mattock escreveu:
The below patch fixes a typo diable to disable. Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattockjustinmatt...@gmail.com
Acked-by: Mauro Carvalho Chehabmche
On 12/31/2010 01:11 AM, Dan Carpenter wrote:
On Thu, Dec 30, 2010 at 10:52:30PM -0800, Justin P. Mattock wrote:
On 12/30/2010 10:45 PM, Grant Likely wrote:
On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote:
The below patch fixes a typo diable to disable. Please let me know
The below patch fixes a typo diable to disable. Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/staging/comedi/drivers/das800.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/comedi
The below patch fixes a typo diable to disable. Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/staging/xgifb/vb_setmode.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/xgifb
The below patch fixes a typo diable to disable. Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/staging/vt6655/rf.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vt6655/rf.c b
The below patch fixes a typo diable to disable. Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/scsi/lpfc/lpfc_init.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_init.c b
The below patch fixes a typo diable to disable. Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/usb/gadget/langwell_udc.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget
The below patch fixes a typo diable to disable. Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/media/video/cx18/cx23418.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/cx18
The below patch fixes a typo diable to disable. Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/media/video/tvp7002.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/tvp7002.c b
The below patch fixes a typo diable to disable. Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
include/media/davinci/vpss.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/media/davinci/vpss.h b
The below patch fixes a typo diable to disable. Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/spi/dw_spi.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/dw_spi.c b/drivers/spi
The below patch fixes a typo diable to disable. Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/isdn/mISDN/dsp_cmx.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/isdn/mISDN/dsp_cmx.c b
The below patch fixes a typo diable to disable and also fixes another typo
in a comment.
Please let me know if this is correct or not.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/usb/host/fhci-hcd.c |4 ++--
drivers/usb/host/fhci-tds.c |4 ++--
2 files changed
The below patch fixes a typo diable to disable. Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/net/wireless/iwlwifi/iwl-agn-ict.c |2 +-
drivers/net/wireless/iwlwifi/iwl-agn.c |4 ++--
drivers/net/wireless/iwlwifi
The below patch fixes a typo diable to disable. Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
arch/m68k/ifpsp060/src/fpsp.S |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/m68k/ifpsp060/src/fpsp.S b
The below patch fixes a typo diable to disable. Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/spi/dw_spi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/spi/dw_spi.c b/drivers/spi/dw_spi.c
The below patch fixes a typo diable to disable. Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/staging/rtl8187se/r8180_hw.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/rtl8187se
On 12/30/2010 10:45 PM, Grant Likely wrote:
On Thu, Dec 30, 2010 at 03:07:51PM -0800, Justin P. Mattock wrote:
The below patch fixes a typo diable to disable. Please let me know if this
is correct or not.
Signed-off-by: Justin P. Mattockjustinmatt...@gmail.com
applied, thanks.
g.
ahh
..
Tested-By: Justin P. Mattock justinmatt...@gmail.com
cheers as well,
Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
This fixes a warning I'm seeing when building:
CC [M] drivers/media/video/gspca/gspca.o
drivers/media/video/gspca/gspca.c: In function 'vidioc_reqbufs':
drivers/media/video/gspca/gspca.c:1508:2: warning: case value '7' not in
enumerated type 'enum v4l2_memory'
Signed-off-by: Justin P. Mattock
: warning: variable 'tun' set
but not used
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
Reviewed-By: Mauro Carvalho Chehab mche...@redhat.com
---
drivers/media/common/tuners/tuner-simple.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/media/common
, IFPCoff, i;
enum param_type desired_type;
struct tuner_params *t_params;
- tun = priv-tun;
-
/* IFPCoff = Video Intermediate Frequency - Vif:
940 =16*58.75 NTSC/J (Japan)
732 =16*45.75 M/N STD
Justin P. Mattock
--
To unsubscribe from
On 06/15/2010 02:19 AM, Jean Delvare wrote:
On Tue, 15 Jun 2010 07:29:44 +0200, Peter Stuge wrote:
Justin P. Mattock wrote:
*baffled* Why did you think that would work? transmit_cmd()s signature
has 4 parameters.
I have no manual in front of me. Did a quick google, but came up with
(no hits
On 06/15/2010 04:43 AM, Jean Delvare wrote:
Hi Justin,
On Mon, 14 Jun 2010 14:06:12 -0700, Justin P. Mattock wrote:
On 06/14/2010 01:53 PM, Jean Delvare wrote:
Hi Justin,
On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote:
could be a right solution, could be wrong
here
On 06/15/2010 04:38 AM, Jean Delvare wrote:
On Mon, 14 Jun 2010 13:26:47 -0700, Justin P. Mattock wrote:
Temporary fix until something is resolved
This is wrong by design, sorry. Warnings aren't blocking, and thus need
no temporary fix. Such temporary fixes would be only hiding the
warning
On 06/15/2010 11:53 AM, Sergey V. wrote:
On Tuesday 15 of June 2010 00:26:44 Justin P. Mattock wrote:
Im getting this warning when compiling:
CC drivers/char/tpm/tpm.o
drivers/char/tpm/tpm.c: In function 'tpm_gen_interrupt':
drivers/char/tpm/tpm.c:508:10: warning: variable 'rc' set
.
In any case Thanks for taking the time,
and hopefully we can get fixes for all of
this mess generated by gcc..
Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/media/common/tuners/tuner-simple.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/media/common/tuners/tuner-simple.c
b/drivers/media/common/tuners/tuner-simple.c
index 8abbcc5..4465b99 100644
Temporary fix until something is resolved
to fix the below warning:
CC [M] drivers/ieee1394/sbp2.o
drivers/ieee1394/sbp2.c: In function 'sbp2_parse_unit_directory':
drivers/ieee1394/sbp2.c:1353:6: warning: variable 'unit_characteristics' set
but not used
Signed-off-by: Justin P. Mattock
Probably not even a fix for this warning:
CC [M] drivers/gpu/drm/drm_gem.o
drivers/gpu/drm/drm_gem.c: In function 'drm_gem_handle_delete':
drivers/gpu/drm/drm_gem.c:188:21: warning: variable 'dev' set but not used
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/gpu/drm
Not sure if this is correct or not.
the below patch gets rid of this warning message
produced by gcc 4.6.0
fs/reiserfs/stree.c: In function 'search_by_key':
fs/reiserfs/stree.c:602:6: warning: variable 'right_neighbor_of_leaf_node' set
but not used
Signed-off-by: Justin P. Mattock justinmatt
The below fixes this warning:
drivers/char/hpet.c: In function 'hpet_ioctl_common':
drivers/char/hpet.c:559:23: warning: variable 'hpet' set but not used
please have a look.
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/char/hpet.c |2 --
1 files changed, 0
could be a right solution, could be wrong
here is the warning:
CC drivers/i2c/i2c-core.o
drivers/i2c/i2c-core.c: In function 'i2c_register_adapter':
drivers/i2c/i2c-core.c:757:15: warning: variable 'dummy' set but not used
Signed-off-by: Justin P. Mattock justinmatt...@gmail.com
-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/char/tpm/tpm.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/char/tpm/tpm.c b/drivers/char/tpm/tpm.c
index 05ad4a1..3d685dc 100644
--- a/drivers/char/tpm/tpm.c
+++ b/drivers/char/tpm/tpm.c
@@ -514,6
-by: Justin P. Mattock justinmatt...@gmail.com
---
drivers/bluetooth/hci_ldisc.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c
index 76a1abb..f693dfe 100644
--- a/drivers/bluetooth/hci_ldisc.c
+++ b/drivers
On 06/14/2010 01:53 PM, Jean Delvare wrote:
Hi Justin,
On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote:
could be a right solution, could be wrong
here is the warning:
CC drivers/i2c/i2c-core.o
drivers/i2c/i2c-core.c: In function 'i2c_register_adapter':
drivers/i2c/i2c
On 06/14/2010 02:05 PM, Edward Shishkin wrote:
Justin P. Mattock wrote:
Not sure if this is correct or not.
the below patch gets rid of this warning message
produced by gcc 4.6.0
fs/reiserfs/stree.c: In function 'search_by_key':
fs/reiserfs/stree.c:602:6: warning: variable
On 06/14/2010 02:47 PM, Edward Shishkin wrote:
Justin P. Mattock wrote:
On 06/14/2010 02:05 PM, Edward Shishkin wrote:
Justin P. Mattock wrote:
Not sure if this is correct or not.
the below patch gets rid of this warning message
produced by gcc 4.6.0
fs/reiserfs/stree.c: In function
On 06/14/2010 04:07 PM, Stefan Richter wrote:
On 14 Jun, Justin P. Mattock wrote:
On 06/14/2010 02:47 PM, Edward Shishkin wrote:
Whitespaces should be removed.
I recommend quilt package for managing patches:
quilt refresh --strip-trailing-whitespace is your friend..
o.k. I resent
On 06/14/2010 05:13 PM, valdis.kletni...@vt.edu wrote:
On Mon, 14 Jun 2010 13:26:44 PDT, Justin P. Mattock said:
Im getting this warning when compiling:
CC drivers/char/tpm/tpm.o
drivers/char/tpm/tpm.c: In function 'tpm_gen_interrupt':
drivers/char/tpm/tpm.c:508:10: warning: variable 'rc
On 06/14/2010 08:49 PM, valdis.kletni...@vt.edu wrote:
On Mon, 14 Jun 2010 19:12:31 PDT, Justin P. Mattock said:
what I tried was this:
if (!rc)
printk(test\n)
and everything looked good,
but as a soon as I changed
rc = transmit_cmd(chip,tpm_cmd, TPM_INTERNAL_RESULT_SIZE
On 06/14/2010 10:16 PM, Mauro Carvalho Chehab wrote:
Em 14-06-2010 23:26, Justin P. Mattock escreveu:
not sure if this is correct or not for
fixing this warning:
CC [M] drivers/media/common/tuners/tuner-simple.o
drivers/media/common/tuners/tuner-simple.c: In function 'simple_set_tv_freq
On 06/14/2010 10:16 PM, Mauro Carvalho Chehab wrote:
Em 14-06-2010 23:26, Justin P. Mattock escreveu:
not sure if this is correct or not for
fixing this warning:
CC [M] drivers/media/common/tuners/tuner-simple.o
drivers/media/common/tuners/tuner-simple.c: In function 'simple_set_tv_freq
On 06/14/2010 10:29 PM, Peter Stuge wrote:
Justin P. Mattock wrote:
*baffled* Why did you think that would work? transmit_cmd()s signature
has 4 parameters.
I have no manual in front of me. Did a quick google, but came up with
(no hits) info on what that function does. grep showed too many
-0010-8000-00389b71
Signed-off-by: Daniel Ritzdaniel.r...@gmx.ch
--
Regards,
Laurent Pinchart
I get weiredness whenever
I shutdown the machine and then boot.
If I boot, then reboot things work.
Justin P. Mattock
--
To unsubscribe from this list: send the line unsubscribe linux-media
58 matches
Mail list logo