Re: [v4,2/9] brcmsmac: split up wlc_phy_workarounds_nphy

2017-10-27 Thread Kalle Valo
Arnd Bergmann wrote: > The stack consumption in this driver is still relatively high, with one > remaining warning if the warning level is lowered to 1536 bytes: > > drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:17135:1: error: > the frame size of 1880 bytes is

Re: [v4,2/9] brcmsmac: split up wlc_phy_workarounds_nphy

2017-10-02 Thread Kalle Valo
Arnd Bergmann wrote: > The stack consumption in this driver is still relatively high, with one > remaining warning if the warning level is lowered to 1536 bytes: > > drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:17135:1: error: > the frame size of 1880 bytes is

Re: [v4, 1/9] brcmsmac: make some local variables 'static const' to reduce stack size

2017-10-02 Thread Kalle Valo
Arnd Bergmann wrote: > With KASAN and a couple of other patches applied, this driver is one > of the few remaining ones that actually use more than 2048 bytes of > kernel stack: > > broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function > 'wlc_phy_workarounds_nphy_gainctrl': >

Re: [PATCH v4 1/9] brcmsmac: make some local variables 'static const' to reduce stack size

2017-09-24 Thread Kalle Valo
ble backports. > > The other two patches do not need to be backported. > > Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> > Signed-off-by: Arnd Bergmann <a...@arndb.de> I'll queue this and the two following brcmsmac patches for 4.14. Also I'll add (only for this patch): Cc: <sta...@vger.kernel.org> -- Kalle Valo

Re: [PATCH 08/26] brcmsmac: make some local variables 'static const' to reduce stack size

2017-03-07 Thread Kalle Valo
Arnd Bergmann <a...@arndb.de> writes: > On Mon, Mar 6, 2017 at 5:19 PM, Kalle Valo <kv...@codeaurora.org> wrote: >> Arend Van Spriel <arend.vanspr...@broadcom.com> writes: >> >>> On 2-3-2017 17:38, Arnd Bergmann wrote: >>>> With KASAN and

Re: [PATCH 10/26] brcmsmac: reindent split functions

2017-03-06 Thread Kalle Valo
c| 1507 >> +--- >> 1 file changed, 697 insertions(+), 810 deletions(-) >> Arend, please edit your quotes. Leaving 1000 lines of unnecessary quotes in your reply makes my use of patchwork horrible: https://patchwork.kernel.org/patch/9601155/ -- Kalle Valo

Re: [PATCH 08/26] brcmsmac: make some local variables 'static const' to reduce stack size

2017-03-06 Thread Kalle Valo
ables as >> 'static const' as I can without changing the actual code. > > Acked-by: Arend van Spriel <arend.vanspr...@broadcom.com> Arnd, via which tree are you planning to submit these? I'm not sure what I should do with the wireless drivers patches from this series. -- Kalle Valo

Re: [PATCH][V2] [media] gp8psk: fix spelling mistake: "firmare" -> "firmware"

2016-12-30 Thread Kalle Valo
ical.com> > --- > drivers/media/usb/dvb-usb/gp8psk.c | 2 +- > drivers/net/wireless/realtek/rtlwifi/core.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Could you split the rtlwifi part to it's own patch? I can't apply patches touching media drivers. -- Kalle Val

Re: [PATCH 0/7] fix typo

2016-05-17 Thread Kalle Valo
Julia Lawall <julia.law...@lip6.fr> writes: > On Tue, 17 May 2016, Kalle Valo wrote: > >> Julia Lawall <julia.law...@lip6.fr> writes: >> >> > firmare -> firmware >> > >> > --- >> > >> > drivers/media/dvb-frontends/mn88

Re: [PATCH 0/7] fix typo

2016-05-17 Thread Kalle Valo
know in advance what tree you are planning to submit these for. For example, should I take ath6kl and mwifiex patches or someone else? -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More m