Re: [Patch v5 12/12] Documention: v4l: Documentation for HEVC CIDs

2017-06-28 Thread Kamil Debski
Hi, Please find my comments inline. On 19 June 2017 at 07:10, Smitha T Murthy wrote: > Added V4l2 controls for HEVC encoder > > Signed-off-by: Smitha T Murthy > --- > Documentation/media/uapi/v4l/extended-controls.rst | 364 > +

Re: [Patch v5 04/12] [media] s5p-mfc: Support MFCv10.10 buffer requirements

2017-06-27 Thread Kamil Debski
buf_addr1 += ctx->me_buffer_size; > + buf_size1 -= (ctx->luma_dpb_size + > ctx->chroma_dpb_size > + + ctx->me_buffer_size); > + } > } > > writel(buf_addr1, mfc_regs->e_scratch_buffer_addr); > diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.h > b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.h > index 021b8db..975bbc5 100644 > --- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.h > +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.h > @@ -26,6 +26,8 @@ > (((MB_HEIGHT(y)+1)/2)*2) * 64 + 128) > #define S5P_MFC_DEC_MV_SIZE_V10(x, y) (MB_WIDTH(x) * \ > (((MB_HEIGHT(y)+1)/2)*2) * 64 + 512) > +#define enc_lcu_width(x_size) DIV_ROUND_UP(x_size, 32) > +#define enc_lcu_height(y_size) DIV_ROUND_UP(y_size, 32) Why is this in lower case? Maybe S5P_MFC_LCU_WIDTH/HEIGHT would be better? > > /* Definition */ > #define ENC_MULTI_SLICE_MB_MAX ((1 << 30) - 1) > -- > 2.7.4 > Apart from the above, it looks good to me. Acked-by: Kamil Debski <ka...@wypas.org> Best wishes, Kamil Debski

[GIT PULL] mem2mem changes

2016-07-01 Thread Kamil Debski
The following changes since commit 0db5c79989de2c68d5abb7ba891bfdb3cd3b7e05: [media] media-devnode.h: Fix documentation (2016-06-16 08:14:56 -0300) are available in the git repository at: git://linuxtv.org/kdebski/media_tree_2.git master-20160627 for you to fetch changes up to

RE: [PATCH] media: s5p-mfc fix memory leak in s5p_mfc_remove()

2016-06-28 Thread Kamil Debski
nuxtv/master? Best wishes, -- Kamil Debski Samsung R Institute Poland > -Original Message- > From: Shuah Khan [mailto:shua...@osg.samsung.com] > Sent: Monday, June 13, 2016 9:45 PM > To: kyungmin.p...@samsung.com; k.deb...@samsung.com; > jtp.p...@samsung.com; mche...@osg.sa

[GIT PULL] mem2mem changes

2016-06-07 Thread Kamil Debski
The following changes since commit 9bd5d8696fd50a10d830e2ad7f9d4e67e0bbbae2: [media] s5p-mfc: don't close instance after free OUTPUT buffers (2016-06-07 10:45:37 -0300) are available in the git repository at: git://linuxtv.org/kdebski/media_tree_2.git master-20160607 for you to fetch

[GIT PULL] mem2mem fixes

2016-05-24 Thread Kamil Debski
The following changes since commit aff093d4bbca91f543e24cde2135f393b8130f4b: [media] exynos-gsc: avoid build warning without CONFIG_OF (2016-05-09 18:38:33 -0300) are available in the git repository at: git://linuxtv.org/kdebski/media_tree_2.git fixes-20160524 for you to fetch changes up

[GIT PULL] mem2mem changes

2015-12-18 Thread Kamil Debski
The following changes since commit ecc2fe20e63a21b7db23065ff061b66fbc08e08b: [media] cx23885: video instead of vbi register used (2015-12-18 13:37:12 -0200) are available in the git repository at: git://linuxtv.org/kdebski/media_tree_2.git for-4.5 for you to fetch changes up to

Re: [PATCHv9 14/15] cec: s5p-cec: Add s5p-cec driver

2015-10-12 Thread Kamil Debski
Hi, On 12 October 2015 at 12:50, Hans Verkuil wrote: > On 10/06/2015 12:32 AM, Russell King - ARM Linux wrote: >> On Mon, Sep 07, 2015 at 03:44:43PM +0200, Hans Verkuil wrote: >>> +if (status & CEC_STATUS_TX_DONE) { >>> +if (status & CEC_STATUS_TX_ERROR) { >>>

Re: [PATCHv9 14/15] cec: s5p-cec: Add s5p-cec driver

2015-10-12 Thread Kamil Debski
Hi, On 12 October 2015 at 14:39, Hans Verkuil <hverk...@xs4all.nl> wrote: > On 10/12/2015 02:33 PM, Kamil Debski wrote: >> Hi, >> >> On 12 October 2015 at 12:50, Hans Verkuil <hverk...@xs4all.nl> wrote: >>> On 10/06/2015 12:32 AM, Russell King - ARM Linux

[GIT PULL] mem2mem changes for 4.4

2015-10-07 Thread Kamil Debski
The following changes since commit efe98010b80ec4516b2779e1b4e4a8ce16bf89fe: [media] DocBook: Fix remaining issues with VB2 core documentation (2015-10-05 09:12:56 -0300) are available in the git repository at: git://linuxtv.org/kdebski/media_tree_2.git for-4.4 for you to fetch changes up

RE: [PATCH v2 1/2] s5p-mfc: end-of-stream handling for newer encoders

2015-10-02 Thread Kamil Debski
uffer_v6(ctx, src_y_addr, src_c_addr); > + s5p_mfc_set_enc_frame_buffer_v6(ctx, src_y_addr, > src_c_addr); > + if (src_mb->flags & MFC_BUF_FLAG_EOS) > + ctx->state = MFCINST_FINISHING; > + } > +

RE: [PATCH v2 2/2] s5p-mfc: use MFC_BUF_FLAG_EOS to identify last buffers in decoder capture queue

2015-10-02 Thread Kamil Debski
h MFC_BUF_FLAG_EOS flag and firing EOS event on de-queuing > such buffers. Checkpatch complains that lines in the description are too long. WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #23: Best wishes, -- Kamil Debski Samsung R Institute Poland >

RE: [PATCH] s5p-mfc: fix state check from encoder queue_setup

2015-08-20 Thread Kamil Debski
-by: Kamil Debski k.deb...@samsung.com Regards Andrzej Best wishes, Kamil Debski --- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c b/drivers/media/platform

Re: [PATCH 2/2] [media] m2m: fix bad unlock balance

2015-08-12 Thread Kamil Debski
Hi, On 12 August 2015 at 13:42, Marek Szyprowski m.szyprow...@samsung.com wrote: Hello Hans, I'm sorry for a delay. Once again I've been busy with some other internal stuff. On 2015-07-28 11:02, Hans Verkuil wrote: Kamil, Marek, Why does v4l2_m2m_poll unlock and lock in that function?

Re: [PATCHv7 14/15] cec: s5p-cec: Add s5p-cec driver

2015-07-23 Thread Kamil Debski
Hi, On 21 July 2015 at 15:03, Marek Szyprowski m.szyprow...@samsung.com wrote: Hello, On 2015-07-16 15:09, Hans Verkuil wrote: Marek, Kamil, On 06/29/15 12:14, Hans Verkuil wrote: From: Kamil Debski ka...@wypas.org Add CEC interface driver present in the Samsung Exynos range of SoCs

Re: [PATCH v3 1/1] V4L2: platform: Renesas R-Car JPEG codec driver

2015-06-26 Thread Kamil Debski
Hi Mikhail, On 26 June 2015 at 12:34, Mikhail Ulyanov mikhail.ulya...@cogentembedded.com wrote: Hi, Thanks everybody for comments. 2015-06-22 17:54 GMT+03:00 Kamil Debski ka...@wypas.org: Hi, I am adding Jacek Anaszewski to CC loop. He was working with the s5p-jpeg driver some time ago

Re: [PATCH 1/2] [media] v4l2-mem2mem: set the queue owner field just as vb2_ioctl_reqbufs does

2015-06-25 Thread Kamil Debski
Hi Philipp, On 25 June 2015 at 11:01, Philipp Zabel p.za...@pengutronix.de wrote: Signed-off-by: Philipp Zabel p.za...@pengutronix.de Please add the patch description no matter how simple it is and how well the subject covers the content of the patch. Best wishes, Kamil ---

Re: [URGENT FOR v4.1] [PATCH v2] vb2: Don't WARN when v4l2_buffer.bytesused is 0 for multiplanar buffers

2015-06-23 Thread Kamil Debski
Hi, Just to let you know - the patch that is applied to media_tree/master [1] and media_tree/fixes [2] is v1 and not v2. I think it should be v2. Best wishes, Kamil Debski [1] http://git.linuxtv.org/cgit.cgi/media_tree.git/commit/?id=77a3c6fd90c94f635edb00d4a65f485687538791 [2] http

Re: [PATCH v3 1/1] V4L2: platform: Renesas R-Car JPEG codec driver

2015-06-22 Thread Kamil Debski
, (CC'ing Kamil Debski) On Wednesday 06 May 2015 01:03:10 Mikhail Ulianov wrote: On Mon, 04 May 2015 02:32:05 +0300 Laurent Pinchart wrote: [snip] [snip] +/* + * + * Queue operations

Re: [URGENT FOR v4.1] [PATCH v2] vb2: Don't WARN when v4l2_buffer.bytesused is 0 for multiplanar buffers

2015-06-19 Thread Kamil Debski
Hi Laurent, First - thank you so much for the patch. I had a look into the code and it looks good. You have my Ack. Thank and best wishes, Kamil Debski On 19 June 2015 at 13:04, Hans Verkuil hverk...@xs4all.nl wrote: On 06/19/2015 02:02 PM, Laurent Pinchart wrote: Commit f61bf13b6a07 ([media

Re: [PATCH 2/2] media: s5p-mfc: add additional check for incorrect memory configuration

2015-06-18 Thread Kamil Debski
. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Kamil Debski ka...@wypas.org --- drivers/media/platform/s5p-mfc/s5p_mfc_opr.c| 11 +-- drivers/media/platform/s5p-mfc/s5p_mfc_opr.h| 2 +- drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c | 12

Re: [PATCH 1/2] media: s5p-mfc: add return value check in mfc_sys_init_cmd

2015-06-18 Thread Kamil Debski
On 3 June 2015 at 11:36, Marek Szyprowski m.szyprow...@samsung.com wrote: alloc_dev_context_buffer method might fail, so add proper return value check. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Kamil Debski ka...@wypas.org --- drivers/media/platform/s5p-mfc

RE: [PATCH] libgencec: Add userspace library for the generic CEC kernel interface

2015-05-06 Thread Kamil Debski
) or simply forgot about them ? I have to admit that I was sending the patchset in a hurry and I forgot to merge all the changes in the lib. I am sorry. I have prepared an updated version just now and I am going to send it soon. On 30 April 2015 at 11:25, Kamil Debski k.deb...@samsung.com wrote

[PATCH v3] libgencec: Add userspace library for the generic CEC kernel interface

2015-05-06 Thread Kamil Debski
Add the libGenCEC library. It was designed to act as an interface between the generic CEC kernel API and userspace applications. It provides a simple interface for applications and an example application that can be used to test the CEC functionality. Signed-off-by: Kamil Debski k.deb

[GIT PULL] mem2mem changes for v4.2

2015-05-06 Thread Kamil Debski
The following changes since commit 1555f3bf5cc172e7d23c2b8db10d656d15bec13e: [media] saa7164: fix compiler warning (2015-05-01 09:09:58 -0300) are available in the git repository at: git://linuxtv.org/kdebski/media_tree_2.git for-4.2 for you to fetch changes up to

[PATCH v6 00/11]

2015-05-04 Thread Kamil Debski
Hi, The sixth version of this patchset addresses recent comments on the mailing list. Please see the changelog below for details. Best wishes, Kamil Debski Changes since v5 - drop struct cec_timeval in favour of a __u64 that keeps the timestamp in ns - remove userspace

[PATCH v6 01/11] dts: exynos4*: add HDMI CEC pin definition to pinctrl

2015-05-04 Thread Kamil Debski
Add pinctrl nodes for the HDMI CEC device to the Exynos4210 and Exynos4x12 SoCs. These are required by the HDMI CEC device. Signed-off-by: Kamil Debski k.deb...@samsung.com --- arch/arm/boot/dts/exynos4210-pinctrl.dtsi |7 +++ arch/arm/boot/dts/exynos4x12-pinctrl.dtsi |7 +++ 2

[PATCH v6 02/11] dts: exynos4: add node for the HDMI CEC device

2015-05-04 Thread Kamil Debski
This patch adds HDMI CEC node specific to the Exynos4210/4x12 SoC series. Signed-off-by: Kamil Debski k.deb...@samsung.com --- arch/arm/boot/dts/exynos4.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index

[PATCH v6 04/11] HID: add HDMI CEC specific keycodes

2015-05-04 Thread Kamil Debski
Add HDMI CEC specific keycodes to the keycodes definition. Signed-off-by: Kamil Debski k.deb...@samsung.com --- include/uapi/linux/input.h | 12 1 file changed, 12 insertions(+) diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h index 731417c..7430a3f 100644

[PATCH v6 03/11] dts: exynos4412-odroid*: enable the HDMI CEC device

2015-05-04 Thread Kamil Debski
Add a dts node entry and enable the HDMI CEC device present in the Exynos4 family of SoCs. Signed-off-by: Kamil Debski k.deb...@samsung.com --- arch/arm/boot/dts/exynos4412-odroid-common.dtsi |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412-odroid

[PATCH v6 05/11] rc: Add HDMI CEC protoctol handling

2015-05-04 Thread Kamil Debski
Add handling of remote control events coming from the HDMI CEC bus. This patch includes a new keymap that maps values found in the CEC messages to the keys pressed and released. Also, a new protocol has been added to the core. Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/media/rc

[PATCH v6 06/11] cec: add HDMI CEC framework

2015-05-04 Thread Kamil Debski
DocBook documentation by Hans Verkuil, with minor additions] Signed-off-by: Kamil Debski k.deb...@samsung.com --- Documentation/cec.txt | 165 +++ drivers/media/Kconfig |6 + drivers/media/Makefile|2 + drivers/media/cec.c | 1191

[PATCH v6 08/11] v4l2-subdev: add HDMI CEC ops

2015-05-04 Thread Kamil Debski
From: Hans Verkuil hansv...@cisco.com Add callbacks to the v4l2_subdev_video_ops. Signed-off-by: Hans Verkuil hansv...@cisco.com [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] Signed-off-by: Kamil Debski k.deb...@samsung.com --- include/media/v4l2-subdev.h |8

[PATCH v6 07/11] DocBook/media: add CEC documentation

2015-05-04 Thread Kamil Debski
From: Hans Verkuil hverk...@xs4all.nl Add DocBook documentation for the CEC API. Signed-off-by: Hans Verkuil hansv...@cisco.com [k.deb...@samsung.com: add documentation for passthrough mode] [k.deb...@samsung.com: minor fixes and change of reserved field sizes] Signed-off-by: Kamil Debski k.deb

[PATCH v6 09/11] cec: adv7604: add cec support.

2015-05-04 Thread Kamil Debski
adv7604 to adv76xx in added functions] Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/media/i2c/adv7604.c | 207 ++- 1 file changed, 206 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c index

RE: [PATCH v6 00/11] HDMI CEC framework

2015-05-04 Thread Kamil Debski
Hi, Sorry, I missed the subject for this cover-letter. Added it in this reply. Best wishes, -- Kamil Debski Samsung RD Institute Poland -Original Message- From: Kamil Debski [mailto:k.deb...@samsung.com] Sent: Monday, May 04, 2015 7:33 PM To: dri-de...@lists.freedesktop.org; linux

[PATCH v6 11/11] cec: s5p-cec: Add s5p-cec driver

2015-05-04 Thread Kamil Debski
Add CEC interface driver present in the Samsung Exynos range of SoCs. The following files were based on work by SangPil Moon: - exynos_hdmi_cec.h - exynos_hdmi_cecctl.c Signed-off-by: Kamil Debski k.deb...@samsung.com --- .../devicetree/bindings/media/s5p-cec.txt | 33 +++ drivers

[PATCH v6 10/11] cec: adv7511: add cec support.

2015-05-04 Thread Kamil Debski
From: Hans Verkuil hansv...@cisco.com Add CEC support to the adv7511 driver. Signed-off-by: Hans Verkuil hansv...@cisco.com [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/media/i2c/adv7511.c | 347

[PATCH v2] libgencec: Add userspace library for the generic CEC kernel interface

2015-05-04 Thread Kamil Debski
/cectest.c create mode 100644 include/gencec.h create mode 100644 libgencec.pc.in create mode 100644 src/Makefile.am create mode 100644 src/gencec.c diff --git a/AUTHORS b/AUTHORS new file mode 100644 index 000..e4b7117 --- /dev/null +++ b/AUTHORS @@ -0,0 +1 @@ +Kamil Debski k.deb

RE: [PATCH] libgencec: Add userspace library for the generic CEC kernel interface

2015-04-30 Thread Kamil Debski
Hi Emil, From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Emil Velikov Sent: Wednesday, April 29, 2015 5:00 PM Hi Kamil, Allow me to put a few suggestions: On 29 April 2015 at 11:02, Kamil Debski k.deb...@samsung.com wrote

[PATCH] libgencec: Add userspace library for the generic CEC kernel interface

2015-04-29 Thread Kamil Debski
include/gencec.h create mode 100644 m4/.gitkeep create mode 100644 src/Makefile.am create mode 100644 src/gencec.c diff --git a/AUTHORS b/AUTHORS new file mode 100644 index 000..e4b7117 --- /dev/null +++ b/AUTHORS @@ -0,0 +1 @@ +Kamil Debski k.deb...@samsung.com diff --git a/INSTALL b/INSTALL

[PATCH v5 11/11] DocBook/media: add CEC documentation

2015-04-29 Thread Kamil Debski
From: Hans Verkuil hverk...@xs4all.nl Add DocBook documentation for the CEC API. Signed-off-by: Hans Verkuil hansv...@cisco.com [k.deb...@samsung.com: add documentation for passthrough mode] [k.deb...@samsung.com: minor fixes and change of reserved field sizes] Signed-off-by: Kamil Debski k.deb

[PATCH v5 09/11] cec: adv7511: add cec support.

2015-04-29 Thread Kamil Debski
From: Hans Verkuil hansv...@cisco.com Add CEC support to the adv7511 driver. Signed-off-by: Hans Verkuil hansv...@cisco.com [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/media/i2c/adv7511.c | 347

[PATCH v5 06/11] cec: add HDMI CEC framework

2015-04-29 Thread Kamil Debski
DocBook documentation by Hans Verkuil, with minor additions] Signed-off-by: Kamil Debski k.deb...@samsung.com --- Documentation/cec.txt | 396 +++ drivers/media/Kconfig |6 + drivers/media/Makefile|2 + drivers/media/cec.c | 1200

[PATCH v5 10/11] cec: s5p-cec: Add s5p-cec driver

2015-04-29 Thread Kamil Debski
Add CEC interface driver present in the Samsung Exynos range of SoCs. The following files were based on work by SangPil Moon: - exynos_hdmi_cec.h - exynos_hdmi_cecctl.c Signed-off-by: Kamil Debski k.deb...@samsung.com --- .../devicetree/bindings/media/s5p-cec.txt | 33 +++ drivers

[PATCH v5 03/11] dts: exynos4412-odroid*: enable the HDMI CEC device

2015-04-29 Thread Kamil Debski
Add a dts node entry and enable the HDMI CEC device present in the Exynos4 family of SoCs. Signed-off-by: Kamil Debski k.deb...@samsung.com --- arch/arm/boot/dts/exynos4412-odroid-common.dtsi |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412-odroid

[PATCH v5 01/11] dts: exynos4*: add HDMI CEC pin definition to pinctrl

2015-04-29 Thread Kamil Debski
Add pinctrl nodes for the HDMI CEC device to the Exynos4210 and Exynos4x12 SoCs. These are required by the HDMI CEC device. Signed-off-by: Kamil Debski k.deb...@samsung.com --- arch/arm/boot/dts/exynos4210-pinctrl.dtsi |7 +++ arch/arm/boot/dts/exynos4x12-pinctrl.dtsi |7 +++ 2

[PATCH v5 02/11] dts: exynos4: add node for the HDMI CEC device

2015-04-29 Thread Kamil Debski
This patch adds HDMI CEC node specific to the Exynos4210/4x12 SoC series. Signed-off-by: Kamil Debski k.deb...@samsung.com --- arch/arm/boot/dts/exynos4.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index

[PATCH v5 04/11] HID: add HDMI CEC specific keycodes

2015-04-29 Thread Kamil Debski
Add HDMI CEC specific keycodes to the keycodes definition. Signed-off-by: Kamil Debski k.deb...@samsung.com --- include/uapi/linux/input.h | 12 1 file changed, 12 insertions(+) diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h index 731417c..7430a3f 100644

[PATCH v5 05/11] rc: Add HDMI CEC protoctol handling

2015-04-29 Thread Kamil Debski
Add handling of remote control events coming from the HDMI CEC bus. This patch includes a new keymap that maps values found in the CEC messages to the keys pressed and released. Also, a new protocol has been added to the core. Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/media/rc

[PATCH v5 00/11] HDMI CEC framework

2015-04-29 Thread Kamil Debski
with well-mannered systems that follow the spec and have little vendor specific quirks. Comments are welcome. Best wishes, Kamil Debski Changes since v4 - add sequence numbering to transmitted messages - add sequence number handling to event hanlding - add passthrough mode - change

[PATCH v5 07/11] v4l2-subdev: add HDMI CEC ops

2015-04-29 Thread Kamil Debski
From: Hans Verkuil hansv...@cisco.com Add callbacks to the v4l2_subdev_video_ops. Signed-off-by: Hans Verkuil hansv...@cisco.com [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] Signed-off-by: Kamil Debski k.deb...@samsung.com --- include/media/v4l2-subdev.h |8

[PATCH v5 08/11] cec: adv7604: add cec support.

2015-04-29 Thread Kamil Debski
adv7604 to adv76xx in added functions] Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/media/i2c/adv7604.c | 207 ++- 1 file changed, 206 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c index

RE: [PATCH v4 06/10] cec: add HDMI CEC framework

2015-04-27 Thread Kamil Debski
propose a passthorugh mode in which handling of CEC messages by the kernel CEC framework will be very limited. I think that the three functions listed above should be enough. Any comments on this solution? thanks, Lars Op den Kamp Best wishes, -- Kamil Debski Samsung RD Institute Poland

RE: [PATCH v4 06/10] cec: add HDMI CEC framework

2015-04-27 Thread Kamil Debski
wrote: On 04/23/2015 03:03 PM, Kamil Debski wrote: From: Hans Verkuil hansv...@cisco.com The added HDMI CEC framework provides a generic kernel interface for HDMI CEC devices. Signed-off-by: Hans Verkuil hansv...@cisco.com [k.deb...@samsung.com: Merged CEC Updates commit by Hans

[PATCH v4 00/10] HDMI CEC framework

2015-04-23 Thread Kamil Debski
caused some discussion and I decided to drop it. In my opinion it can be useful for debugging, but on the other hand I believe it can be easily added at a later time, if appropriate. Best wishes, Kamil Debski Changes since v3 - remove the promiscuous mode - rewrite the devicetree

[PATCH v4 02/10] dts: exynos4: add node for the HDMI CEC device

2015-04-23 Thread Kamil Debski
This patch adds HDMI CEC node specific to the Exynos4210/4x12 SoC series. Signed-off-by: Kamil Debski k.deb...@samsung.com --- arch/arm/boot/dts/exynos4.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index

[PATCH v4 01/10] dts: exynos4*: add HDMI CEC pin definition to pinctrl

2015-04-23 Thread Kamil Debski
Add pinctrl nodes for the HDMI CEC device to the Exynos4210 and Exynos4x12 SoCs. These are required by the HDMI CEC device. Signed-off-by: Kamil Debski k.deb...@samsung.com --- arch/arm/boot/dts/exynos4210-pinctrl.dtsi |7 +++ arch/arm/boot/dts/exynos4x12-pinctrl.dtsi |7 +++ 2

[PATCH v4 03/10] dts: exynos4412-odroid*: enable the HDMI CEC device

2015-04-23 Thread Kamil Debski
Add a dts node entry and enable the HDMI CEC device present in the Exynos4 family of SoCs. Signed-off-by: Kamil Debski k.deb...@samsung.com --- arch/arm/boot/dts/exynos4412-odroid-common.dtsi |4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412-odroid

[PATCH v4 09/10] cec: adv7511: add cec support.

2015-04-23 Thread Kamil Debski
From: Hans Verkuil hansv...@cisco.com Add CEC support to the adv7511 driver. Signed-off-by: Hans Verkuil hansv...@cisco.com [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/media/i2c/adv7511.c | 347

[PATCH v4 06/10] cec: add HDMI CEC framework

2015-04-23 Thread Kamil Debski
of events and fix 32/64bit timespec problem] [k.deb...@samsung.com: add cec.h to include/uapi/linux/Kbuild] Signed-off-by: Kamil Debski k.deb...@samsung.com --- Documentation/cec.txt | 396 drivers/media/Kconfig |6 + drivers/media/Makefile|2 + drivers/media/cec.c

[PATCH v4 07/10] v4l2-subdev: add HDMI CEC ops

2015-04-23 Thread Kamil Debski
From: Hans Verkuil hansv...@cisco.com Add callbacks to the v4l2_subdev_video_ops. Signed-off-by: Hans Verkuil hansv...@cisco.com [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] Signed-off-by: Kamil Debski k.deb...@samsung.com --- include/media/v4l2-subdev.h |8

[PATCH v4 05/10] rc: Add HDMI CEC protoctol handling

2015-04-23 Thread Kamil Debski
Add handling of remote control events coming from the HDMI CEC bus. This patch includes a new keymap that maps values found in the CEC messages to the keys pressed and released. Also, a new protocol has been added to the core. Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/media/rc

[PATCH v4 04/10] HID: add HDMI CEC specific keycodes

2015-04-23 Thread Kamil Debski
Add HDMI CEC specific keycodes to the keycodes definition. Signed-off-by: Kamil Debski k.deb...@samsung.com --- include/uapi/linux/input.h | 12 1 file changed, 12 insertions(+) diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h index 731417c..7430a3f 100644

[PATCH v4 08/10] cec: adv7604: add cec support.

2015-04-23 Thread Kamil Debski
adv7604 to adv76xx in added functions] Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/media/i2c/adv7604.c | 207 ++- 1 file changed, 206 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c index

RE: [RFC v3 5/9] cec: add new driver for cec support.

2015-04-20 Thread Kamil Debski
Hi Hans, From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Hans Verkuil Sent: Friday, April 17, 2015 2:17 PM On 04/13/2015 03:19 PM, Kamil Debski wrote: Hi Hans, Thank you so much for the review. From: linux-media-ow...@vger.kernel.org

RE: [PATCH v4 2/4] [media] videobuf2: return -EPIPE from DQBUF after the last buffer

2015-04-20 Thread Kamil Debski
Hi, From: Philipp Zabel [mailto:p.za...@pengutronix.de] Sent: Monday, April 20, 2015 10:28 AM To: Kamil Debski Cc: 'Pawel Osciak'; 'LMML'; 'Hans Verkuil'; 'Laurent Pinchart'; 'Nicolas Dufresne'; 'Sakari Ailus'; ker...@pengutronix.de Subject: Re: [PATCH v4 2/4] [media] videobuf2: return

RE: [PATCH v4 2/4] [media] videobuf2: return -EPIPE from DQBUF after the last buffer

2015-04-16 Thread Kamil Debski
Hi, From: Philipp Zabel [mailto:p.za...@pengutronix.de] Sent: Monday, April 13, 2015 6:15 PM To: Pawel Osciak Cc: LMML; Hans Verkuil; Kamil Debski; Laurent Pinchart; Nicolas Dufresne; Sakari Ailus; ker...@pengutronix.de Subject: Re: [PATCH v4 2/4] [media] videobuf2: return -EPIPE from DQBUF

RE: [RFC v3 5/9] cec: add new driver for cec support.

2015-04-13 Thread Kamil Debski
. On 03/20/2015 05:52 PM, Kamil Debski wrote: Add the CEC framework. Signed-off-by: Hans Verkuil hansv...@cisco.com [k.deb...@samsung.com: Merged CEC Updates commit by Hans Verkuil] [k.deb...@samsung.com: Merged Update author commit by Hans Verkuil] [k.deb...@samsung.com: change kthread

[GIT PULL for 4.1] mem2mem changes for 4.1

2015-04-08 Thread Kamil Debski
to 8dae02ffa32db8193513ee0a3c6dcd277e653954: coda: Add tracing support (2015-04-08 11:54:12 +0200) Kamil Debski (4): vb2: split the io_flags member of vb2_queue into a bit field vb2: add allow_zero_bytesused flag to the vb2_queue

RE: [PATCH v3 0/5] Signalling last decoded frame by V4L2_BUF_FLAG_LAST and -EPIPE

2015-04-07 Thread Kamil Debski
Hi, From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Tuesday, March 17, 2015 5:09 PM On 03/17/2015 11:46 AM, Philipp Zabel wrote: Hi, Am Freitag, den 06.03.2015, 11:18 +0100 schrieb Philipp Zabel: At the V4L2 codec API session during ELC-E 2014, we agreed that for the decoder

[RFC v3 5/9] cec: add new driver for cec support.

2015-03-20 Thread Kamil Debski
...@samsung.com: add possibility to clear assigned logical addresses] Signed-off-by: Kamil Debski k.deb...@samsung.com --- Documentation/cec.txt| 321 + drivers/media/Kconfig|6 + drivers/media/Makefile |2 + drivers/media/cec.c | 1158

[RFC v3 3/9] Input: add key codes specific to the HDMI CEC bus

2015-03-20 Thread Kamil Debski
The HDMI CEC bus allows device to communicate with one another. This includes sending remote control key codes. Some of key codes defined in the CEC standard are not defined in the input.h. This patch adds the key codes that are missing. Signed-off-by: Kamil Debski k.deb...@samsung.com

[RFC v3 6/9] v4l2-subdev: add cec ops.

2015-03-20 Thread Kamil Debski
From: Hans Verkuil hansv...@cisco.com Add callbacks to the v4l2_subdev_video_ops. Signed-off-by: Hans Verkuil hansv...@cisco.com [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] Signed-off-by: Kamil Debski k.deb...@samsung.com --- include/media/v4l2-subdev.h |8

[RFC v3 7/9] adv7604: add cec support.

2015-03-20 Thread Kamil Debski
From: Hans Verkuil hansv...@cisco.com Add CEC support to the adv7604 driver. Signed-off-by: Hans Verkuil hansv...@cisco.com [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/media/i2c/adv7604.c | 182

[RFC v3 9/9] s5p-cec: Add s5p-cec driver

2015-03-20 Thread Kamil Debski
Add CEC interface driver present in the Samsung Exynos range of SoCs. The following files were based on work by SangPil Moon: - exynos_hdmi_cec.h - exynos_hdmi_cecctl.c Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/media/platform/Kconfig |7 + drivers

[RFC v3 8/9] adv7511: add cec support.

2015-03-20 Thread Kamil Debski
From: Hans Verkuil hansv...@cisco.com Add CEC support to the adv7511 driver. Signed-off-by: Hans Verkuil hansv...@cisco.com [k.deb...@samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/media/i2c/adv7511.c | 325

[RFC v3 0/9] HDMI CEC framework

2015-03-20 Thread Kamil Debski
back the discussion on a common CEC interface framework. There are a few things that were still left as TODO, I think they might need some discussion - for instance the way how the remote controls should be handled. Best wishes, Kamil Debski Original RFC by Hans Verkuil/Martin Bugge

[RFC v3 1/9] dts: add hdmi-cec to to pinctrl definitions

2015-03-20 Thread Kamil Debski
Add entry for hdmi-cec to the pinctrl_1. Signed-off-by: Kamil Debski k.deb...@samsung.com --- arch/arm/boot/dts/exynos4412-odroid-common.dtsi |7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid

RE: [PATCH 10/12] [media] coda: fail to start streaming if userspace set invalid formats

2015-03-18 Thread Kamil Debski
Hi Philipp, From: Jean-Michel Hautbois [mailto:jhautb...@gmail.com] Sent: Friday, February 27, 2015 10:00 AM To: Philipp Zabel Cc: Kamil Debski; Peter Seiderer; Linux Media Mailing List; Sascha Hauer Subject: Re: [PATCH 10/12] [media] coda: fail to start streaming if userspace set invalid

RE: [RFC v2 2/7] media: rc: Add cec protocol handling

2015-03-11 Thread Kamil Debski
Hi Mauro, I have some more comments/questions below. From: Mauro Carvalho Chehab [mailto:mche...@osg.samsung.com] Sent: Sunday, March 08, 2015 3:21 PM Em Thu, 22 Jan 2015 17:04:34 +0100 Kamil Debski k.deb...@samsung.com escreveu: (c/c linux-input ML) Add cec protocol handling the RC

RE: [RFC v2 2/7] media: rc: Add cec protocol handling

2015-03-10 Thread Kamil Debski
Hi Bastien, From: Bastien Nocera [mailto:had...@hadess.net] Sent: Monday, March 09, 2015 5:44 PM On Mon, 2015-03-09 at 17:22 +0100, Kamil Debski wrote: Hi Mauro, From: Mauro Carvalho Chehab [mailto:mche...@osg.samsung.com] Sent: Sunday, March 08, 2015 3:21 PM Em Thu, 22 Jan 2015

RE: [RFC v2 2/7] media: rc: Add cec protocol handling

2015-03-10 Thread Kamil Debski
From: Bastien Nocera [mailto:had...@hadess.net] Sent: Tuesday, March 10, 2015 3:15 PM On Tue, 2015-03-10 at 13:02 +0100, Kamil Debski wrote: Hi Bastien, From: Bastien Nocera [mailto:had...@hadess.net] Sent: Monday, March 09, 2015 5:44 PM On Mon, 2015-03-09 at 17:22 +0100, Kamil

RE: [RFC v2 3/7] cec: add new framework for cec support.

2015-03-09 Thread Kamil Debski
Hi Mauro, Thank you for your comments. From: Mauro Carvalho Chehab [mailto:mche...@osg.samsung.com] Sent: Sunday, March 08, 2015 4:42 PM Em Fri, 06 Mar 2015 17:14:50 +0100 Kamil Debski k.deb...@samsung.com escreveu: Hi Sean, Hans, I am sorry to reply so late, I was busy with other

RE: [RFC v2 2/7] media: rc: Add cec protocol handling

2015-03-09 Thread Kamil Debski
Hi Mauro, From: Mauro Carvalho Chehab [mailto:mche...@osg.samsung.com] Sent: Sunday, March 08, 2015 3:21 PM Em Thu, 22 Jan 2015 17:04:34 +0100 Kamil Debski k.deb...@samsung.com escreveu: (c/c linux-input ML) Add cec protocol handling the RC framework. I added some comments

RE: [RFC v2 3/7] cec: add new framework for cec support.

2015-03-09 Thread Kamil Debski
Hi Sean, From: Sean Young [mailto:s...@mess.org] Sent: Sunday, March 08, 2015 11:45 AM Hi Kamil, On Fri, Mar 06, 2015 at 05:14:50PM +0100, Kamil Debski wrote: 3) As you suggested - load an empty keymap whenever the pass through mode is enabled. I am not that familiar with the RC core

RE: [PATCHv2 1/2] ARM: dts: exynos5420: add nodes for jpeg codec

2015-03-09 Thread Kamil Debski
please add a description. One sentence should be enough. Best wishes, -- Kamil Debski Samsung RD Institute Poland Signed-off-by: Andrzej Pietrasiewicz andrze...@samsung.com --- arch/arm/boot/dts/exynos5420.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm

RE: [RFC v2 3/7] cec: add new framework for cec support.

2015-03-06 Thread Kamil Debski
, Kamil Debski wrote: Add the CEC framework. -snip- +Remote control handling +--- + +The CEC framework provides two ways of handling the key messages of +remote control. In the first case, the CEC framework will handle +these messages and provide the keypressed via

[PATCH] s5p-mfc: remove non necessary volatile modifiers and __iomem annotations

2015-03-05 Thread Kamil Debski
This patch removes non necessary volatile modifiers and __iomem annotations from the s5p_mfc_regs structure. Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc_opr.h | 488 +- 1 file changed, 244 insertions(+), 244 deletions

[GIT PULL] s5p-mfc fixes

2015-03-05 Thread Kamil Debski
/platform/s5p-mfc/s5p_mfc_opr_v6.c |6 +++--- 4 files changed, 8 insertions(+), 8 deletions(-) Best wishes, Kamil Debski -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

[PATCH] s5p-mfc: Fix NULL pointer dereference caused by not set q-lock

2015-03-03 Thread Kamil Debski
-off-by: Kamil Debski k.deb...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index 9fe4d90..8333fbc 100644 --- a/drivers/media/platform/s5p-mfc

RE: [PATCH] media: i2c: s5c73m3: make sure we destroy the mutex

2015-03-03 Thread Kamil Debski
to destroy a mutex. Most drivers never do this. It only helps a bit in debugging. I'll delegate this patch to Kamil, and he can decide whether or not to apply this. I agree with Hans here, the patch is not necessary. Regards, Hans Best wishes, -- Kamil Debski Samsung RD

RE: [PATCH v5 2/4] vb2: add allow_zero_bytesused flag to the vb2_queue struct

2015-02-23 Thread Kamil Debski
Hi, Thank you for the review :) From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Friday, February 20, 2015 5:52 PM Hi Kamil, One question and one typo below... On 02/20/2015 05:38 PM, Kamil Debski wrote: The vb2: fix bytesused == 0 handling (8a75ffb) patch changed the behavior

[PATCH v6 4/4] s5p-mfc: set allow_zero_bytesused flag for vb2_queue_init

2015-02-23 Thread Kamil Debski
compatibility. Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index 8e44a59..9fe4d90 100644 --- a/drivers/media

[PATCH v6 2/4] vb2: add allow_zero_bytesused flag to the vb2_queue struct

2015-02-23 Thread Kamil Debski
...@collabora.com Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/media/v4l2-core/videobuf2-core.c | 39 +- include/media/videobuf2-core.h |2 ++ 2 files changed, 35 insertions(+), 6 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-core.c

[PATCH v6 3/4] coda: set allow_zero_bytesused flag for vb2_queue_init

2015-02-23 Thread Kamil Debski
compatibility. Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/media/platform/coda/coda-common.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c index 6f32e6d..329c2a4 100644 --- a/drivers/media

[PATCH v6 1/4] vb2: split the io_flags member of vb2_queue into a bit field

2015-02-23 Thread Kamil Debski
This patch splits the io_flags member of vb2_queue into a bit field. Instead of an enum with flags separate bit fields were introduced. Signed-off-by: Kamil Debski k.deb...@samsung.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/v4l2-core/videobuf2-core.c | 17

[PATCH v5 4/4] s5p-mfc: set allow_zero_bytesused flag for vb2_queue_init

2015-02-20 Thread Kamil Debski
compatibility. Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index 8e44a59..6b08488 100644 --- a/drivers/media

[PATCH v5 2/4] vb2: add allow_zero_bytesused flag to the vb2_queue struct

2015-02-20 Thread Kamil Debski
...@collabora.com Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/media/v4l2-core/videobuf2-core.c | 39 +- include/media/videobuf2-core.h |2 ++ 2 files changed, 35 insertions(+), 6 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-core.c

[PATCH v5 1/4] vb2: split the io_flags member of vb2_queue into a bit field

2015-02-20 Thread Kamil Debski
This patch splits the io_flags member of vb2_queue into a bit field. Instead of an enum with flags separate bit fields were introduced. Signed-off-by: Kamil Debski k.deb...@samsung.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/v4l2-core/videobuf2-core.c | 17

  1   2   3   4   5   6   >