RE: [PATCH v2] [media] s5p-mfc: Dequeue sequence header after STREAMON

2014-05-15 Thread Kamil Debski
the needed number of buffers from controls? Isn't this related with number of B frames? I understand how this affects the number of buffers for OUTPUT, but I thought that a single CAPTURE buffer is always enough. I understood that a generated compressed stream is no longer used after it was created and its processing is finished. I think we need some discussion on this patch. Best wishes, -- Kamil Debski Samsung R&D Institute Poland -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[GIT PULL for 3.16] ti-vpe patches

2014-05-14 Thread Kamil Debski
The following changes since commit ba0d342ecc21fbbe2f6c178f4479944d1fb34f3b: saa7134-alsa: include vmalloc.h (2014-05-13 23:05:15 -0300) are available in the git repository at: git://linuxtv.org/kdebski/media_tree_2.git for-3.16 for you to fetch changes up to 61b2123701c3568fcf8a07e69fe1c28

[PATCH] v4l: Fix documentation of V4L2_PIX_FMT_H264_MVC and VP8 pixel formats

2014-05-14 Thread Kamil Debski
The 'Code' column in the documentation should provide the real fourcc code that is used. Changed the documentation to provide the fourcc defined in videodev2.h Signed-off-by: Kamil Debski --- Documentation/DocBook/media/v4l/pixfmt.xml |4 ++-- 1 file changed, 2 insertions(+), 2

RE: [PATCH] [media] s5p-mfc: Add a control for IVF format for VP8 encoder

2014-05-14 Thread Kamil Debski
ary stream with start codes. V4L2_PIX_FMT_H264_NO_SC 'AVC1' H264 video elementary stream without start codes. Could you confirm this? Best wishes, -- Kamil Debski Samsung R&D Institute Poland > -Original Message- > From: Arun Kumar K [mailto:arunkk.sams..

RE: [PATCH v5 2/2] [media] s5p-mfc: Add support for resolution change event

2014-05-14 Thread Kamil Debski
ignal the > userspace that a new set of buffers is required before decoding can > continue. > > Signed-off-by: Pawel Osciak > Signed-off-by: Arun Kumar K Acked-by: Kamil Debski > --- > drivers/media/platform/s5p-mfc/s5p_mfc.c |8 > drivers/media/

RE: [PATCH v2] [media] s5p-mfc: add init buffer cmd to MFCV6

2014-05-13 Thread Kamil Debski
Hi, > From: Arun Kumar K [mailto:arunkk.sams...@gmail.com] On Behalf Of Arun > Kumar K > Sent: Tuesday, March 11, 2014 10:16 AM > > From: avnd kiran > > Latest MFC v6 firmware requires tile mode and loop filter setting to be > done as part of Init buffer command, in sync with v7. Since there ar

RE: [PATCH] [media] s5p-mfc: Add IOMMU support

2014-05-08 Thread Kamil Debski
o. Arun, could you tell me how did you test this? I think that the MFC driver should not be modified to use iommu. Dma_mapping should be used. On Tizenorg there is a 3.10 kernel with an iommu driver that works with MFC without any patches to the MFC drvier. I disagree to merging this patch, sorry. T

RE: [PATCH] [media] s5p-mfc: Don't try to resubmit VP8 bitstream buffer for decode.

2014-05-08 Thread Kamil Debski
rkaround for VP8 only. (The title says that it only changes behavior of VP8 decoding, so it is misleading). - if (ctx->codec_mode != S5P_MFC_CODEC_H264_DEC && + if (ctx->codec_mode != S5P_MFC_CODEC_H264_DEC && + ctx->codec_mode !=

RE: [PATCH v2] [media] s5p-mfc: add init buffer cmd to MFCV6

2014-05-08 Thread Kamil Debski
nly way to check if the interface has changed? Maybe the major number should stay the same (6) in this case, and the minor should be updates? Do you have contact with persons writing the firmware? Also, I don't see a patch with the newer firmware posted to linux-firmware. When it is going to b

RE: [PATCH 3/3] [media] s5p-mfc: Don't allocate codec buffers on STREAMON.

2014-05-08 Thread Kamil Debski
ctx->dst_bufs_cnt = 0; > - ctx->src_bufs_cnt = 0; > - ctx->capture_state = QUEUE_FREE; > - ctx->output_state = QUEUE_FREE; > - ret = s5p_mfc_open_mfc_inst(dev, ctx); > -

RE: [PATCH v2 1/2] v4l: Add resolution change event.

2014-04-22 Thread Kamil Debski
Hi Pawel, > From: Pawel Osciak [mailto:posc...@chromium.org] > Sent: Tuesday, April 22, 2014 9:46 AM > To: Kamil Debski > Cc: Arun Kumar K; linux-media@vger.kernel.org; linux-samsung-soc; > Sylwester Nawrocki; Hans Verkuil; Laurent Pinchart > Subject: Re: [PATCH v2 1/2] v4l: Add

RE: [PATCH v2 1/2] v4l: Add resolution change event.

2014-04-22 Thread Kamil Debski
Hi Pawel, > From: Pawel Osciak [mailto:posc...@chromium.org] > Sent: Monday, April 21, 2014 12:27 PM > To: Arun Kumar K > Cc: linux-media@vger.kernel.org; linux-samsung-soc; Kamil Debski; > Sylwester Nawrocki; Hans Verkuil; Laurent Pinchart > Subject: Re: [PATCH v2 1/2] v4l: Add

RE: [ANNOUNCE] media mini-summit on May, 2 in San Jose

2014-04-14 Thread Kamil Debski
omponent framework (drivers/base/component.c) in V4L2", suggested by Laurent. Best wishes, -- Kamil Debski Samsung R&D Institute Poland > > As usual, we'll be using the media-works...@linuxtv.org ML for specific > discussions about that, so the ones interested on participa

RE: [PATCH 3/4] gsc-m2m: report correct format bytesperline and sizeimage

2014-04-07 Thread Kamil Debski
Hi Shaik, Sungchun, Exynos-gsc has no maintainers mentioned in the MAINTAINERS file. I see your activity in the development of this driver. Do you have any comments on this patch? Best wishes, -- Kamil Debski Samsung R&D Institute Poland > -Original Message- > From:

RE: [GIT PULL for 3.15 fixes] VPE fixes

2014-04-07 Thread Kamil Debski
Hi Archit, Thank you for separating the fix patches. I am waiting for 3.15-rc1 to be released. Best wishes, -- Kamil Debski Samsung R&D Institute Poland > -Original Message- > From: Archit Taneja [mailto:arc...@ti.com] > Sent: Monday, April 07, 2014 11:31 AM > To: K

RE: [PATCH 4/4] v4l2-mem2mem: allow reqbufs(0) with "in use" MMAP buffers

2014-04-07 Thread Kamil Debski
Pawel, Marek, Before taking this to my tree I wanted to get an ACK from one of the videobuf2 maintainers. Could you spare a moment to look through this patch? Best wishes, -- Kamil Debski Samsung R&D Institute Poland > -Original Message- > From: John Sheu [mailto:s...@

RE: [PATCH v4 06/14] v4l: ti-vpe: Fix some params in VPE data descriptors

2014-03-13 Thread Kamil Debski
out_dtd() helper. The > c_rect > param is used for specifying the 'composition' target, and 'width' > is added > to calculate the line stride. This patch looks ok. Passes checkpatch and compiles. I can't say much more as I have limited knowledge of the interna

RE: [PATCH v4 08/14] v4l: ti-vpe: Rename csc memory resource name

2014-03-13 Thread Kamil Debski
DT nodes in the future can use it. I understand that this is not yet used in any public dts files. Right? Best wishes, -- Kamil Debski Samsung R&D Institute Poland > > Signed-off-by: Archit Taneja > --- > drivers/media/platform/ti-vpe/csc.c | 2 +- > 1 file changed, 1 in

RE: [PATCH v4 01/14] v4l: ti-vpe: Make sure in job_ready that we have the needed number of dst_bufs

2014-03-13 Thread Kamil Debski
heck in job_ready() to make sure we have the sufficient > amount of destination buffers. > > Signed-off-by: Archit Taneja Acked-by: Kamil Debski > --- > drivers/media/platform/ti-vpe/vpe.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/media/platform/ti-

RE: [PATCH v3 01/14] v4l: ti-vpe: Make sure in job_ready that we have the needed number of dst_bufs

2014-03-13 Thread Kamil Debski
heck in job_ready() to make sure we have the sufficient > amount of destination buffers. > > Signed-off-by: Archit Taneja Acked-by: Kamil Debski Best wishes, -- Kamil Debski Samsung R&D Institute Poland > --- > drivers/media/platform/ti-vpe/vpe.c | 3 +++ > 1 file changed

RE: [PATCH v3 02/14] v4l: ti-vpe: register video device only when firmware is loaded

2014-03-13 Thread Kamil Debski
Hi, > From: Archit Taneja [mailto:arc...@ti.com] > Sent: Thursday, March 13, 2014 1:09 PM > > Hi Kamil, > > On Thursday 13 March 2014 05:18 PM, Kamil Debski wrote: > > Hi Archit, > > > >> From: Archit Taneja [mailto:arc...@ti.com] > >> Sent: Tu

RE: [PATCH v3 02/14] v4l: ti-vpe: register video device only when firmware is loaded

2014-03-13 Thread Kamil Debski
ware cannot be used in probe, thus you are using request_firmware_nowait. Why cannot the firmware be loaded on open with a regular request_firmware that is waiting? This patch seems to swap one problem for another. The possibility that open fails (because firmware is not yet loaded) is swapped for a

RE: [PATCH] [media] s5p-mfc: Don't try to resubmit VP8 bitstream buffer for decode.

2014-03-11 Thread Kamil Debski
resubmitted? Or the opposite - you are getting the frame resubmitted without the need? By the contents of this patch I guess the latter, on the other hand I do remember that at some point the idea was to be able to queue more than one frame per buffer. I don't remember exactly who was opting f

[GIT PULL for 3.15] mem2mem patches

2014-03-11 Thread Kamil Debski
The following changes since commit f2d7313534072a5fe192e7cf46204b413acef479: [media] drx-d: add missing braces in drxd_hard.c:DRXD_init (2014-03-09 09:20:50 -0300) are available in the git repository at: git://linuxtv.org/kdebski/media_tree_2.git master for you to fetch changes up to 0dceda

RE: [PATCH] [media] s5p-mfc: add init buffer cmd to MFCV6

2014-03-07 Thread Kamil Debski
s case would be less common, but still a person can update the firmware and leave the old kernel. Changing the firmware can be done by replacing a single file. In addition to the above, you need to clearly specify in the linux-firmware.git what is going on. A readme file is a must. Maybe a second

RE: [PATCH] [media] s5-mfc: remove meaningless assignment

2014-03-05 Thread Kamil Debski
Hi Seung-Woo, > From: Seung-Woo Kim [mailto:sw0312@samsung.com] > Sent: Wednesday, March 05, 2014 11:08 AM > > Signed-off-by: Seung-Woo Kim Thank you for your patch. I know that content of the patch is obvious, but please provide a description of the patch. Best wishes, --

RE: [PATCH v2 7/7] v4l: ti-vpe: Add selection API in VPE driver

2014-03-04 Thread Kamil Debski
URE) { > >> + break; > >> + } else { > > > > No need for the 'else' keywork here. > > > >> + s->r = q_data->c_rect; > >> + return 0; > >> + } > &

RE: [PATCH 7/7] v4l: ti-vpe: Add crop support in VPE driver

2014-03-03 Thread Kamil Debski
. Also, it is quite late for v3.15. I did already send a pull request to Mauro, However I have one patch pending. Could you tell me when are you planning to post v2 of these patches? I want to decide whether should I wait for your patchset or should I send the second pull request with the pending

RE: [PATCH 5/7] v4l: ti-vpe: Allow usage of smaller images

2014-03-03 Thread Kamil Debski
han 32x32 didn't make > much sense, so stopped at this. > > Signed-off-by: Archit Taneja Best wishes, -- Kamil Debski Samsung R&D Institute Poland > --- > drivers/media/platform/ti-vpe/vpe.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --gi

[GIT PULL] mem2mem patches for 3.15

2014-02-27 Thread Kamil Debski
The following changes since commit b215621049bd57221455990880fb6b906f7dac21: Merge branch 'v4l_for_linus' into to_next (2014-02-04 06:48:49 -0200) are available in the git repository at: git://linuxtv.org/kdebski/media_tree_2.git master for you to fetch changes up to 61ca9493f4f0d3c8c1b412

RE: [PATCH v5 3/7] v4l: Add timestamp source flags, mask and document them

2014-02-25 Thread Kamil Debski
> for end of frame (value zero) V4L2_BUF_FLAG_TSTAMP_SRC_SOE for start of > exposure (next value). > Changes in videobuf2-core.c look good. > Signed-off-by: Sakari Ailus Acked-by: Kamil Debski > --- > Documentation/DocBook/media/v4l/io.xml | 31 > --

RE: [PATCH v5 6/7] v4l: Copy timestamp source flags to destination on m2m devices

2014-02-25 Thread Kamil Debski
he timestamp field from source to destination. This patch looks good to me. > Signed-off-by: Sakari Ailus Acked-by: Kamil Debski > --- > drivers/media/platform/coda.c|3 +++ > drivers/media/platform/exynos-gsc/gsc-m2m.c |4 > drivers/media/plat

RE: [PATCH v5 5/7] exynos-gsc, m2m-deinterlace, mx2_emmaprp: Copy v4l2_buffer data from src to dst

2014-02-25 Thread Kamil Debski
Hi Sakari, > From: Sakari Ailus [mailto:sakari.ai...@iki.fi] > Sent: Saturday, February 15, 2014 9:53 PM > > The timestamp and timecode fields were copied from destination to > source, not the other way around as they should. Fix it. > > Signed-off-by: Sakari Ailus A

RE: [PATCH v5 2/7] v4l: Use full 32 bits for buffer flags

2014-02-24 Thread Kamil Debski
obody is actually using the timecode struct, > > but we plan to hijack that for hardware timestamps in the future > anyway. > > Is there a single driver which uses the timecode field? The fact is > that many m2m drivers copy it but that's probably mostly copying what > one of t

RE: [PATCH v2 1/2] drivers/media: v4l2: Add settings for Horizontal and Vertical MV Search Range

2014-01-30 Thread Kamil Debski
dex 1666aab..80e1def 100644 > > --- a/include/uapi/linux/v4l2-controls.h > > +++ b/include/uapi/linux/v4l2-controls.h > > @@ -372,6 +372,8 @@ enum v4l2_mpeg_video_multi_slice_mode { > > #define V4L2_CID_MPEG_VIDEO_DEC_FRAME > (V4L2_CID_MPEG_BASE+224) > > #define V4L

RE: [PATCH] [media] s5p-mfc: Add Horizontal and Vertical search range for Video Macro Blocks

2014-01-23 Thread Kamil Debski
V4L2_CID_PAN_RESET: > case V4L2_CID_TILT_RESET: > case V4L2_CID_FLASH_STROBE: > diff --git a/include/uapi/linux/v4l2-controls.h > b/include/uapi/linux/v4l2-controls.h > index 1666aab..bcce536 100644 > --- a/include/uapi/linux/v4l2-controls.h > +++ b/include/uapi/linux/

RE: using MFC memory to memery encoder, start stream and queue order problem

2014-01-13 Thread Kamil Debski
mfc encoder in 3.12. Randy, Please apply these two patches: [PATCH] media: s5p_mfc: remove s5p_mfc_get_node_type() function [PATCH] media: v4l2-dev: fix video device index assignment And try again with kernel 3.12. There was a problem with opening MFC that was introduced by other patches. > I

RE: using MFC memory to memery encoder, start stream and queue order problem

2014-01-08 Thread Kamil Debski
Hi Randy, > From: randy [mailto:lxr1...@hotmail.com] > Sent: Friday, January 03, 2014 4:17 PM > > I rewrite my program, it takes the order as below 1.request buffer. > 2.mmap input buffer with OUTPUT > 3.output buffer with CAPTURE. > 4.filled input buffer with the first frame. > 5.enqueue the fir

RE: [GIT PULL for v3.14] mem2mem patches

2014-01-08 Thread Kamil Debski
sent you a new pull request without Shaiks' patches. Shaik could you try to get an ack from a DT maintainer for this patch? Best wishes, -- Kamil Debski Samsung R&D Institute Poland > -Original Message- > From: Mauro Carvalho Chehab [mailto:m.che...@samsung.com] > Sent:

[GIT PULL for v3.14 v2] mem2mem patches

2014-01-08 Thread Kamil Debski
The following changes since commit 6892f65b7b9e14fe29b6e4f0dc4f7ed3796a6e71: exynos-scaler: Add DT bindings for SCALER driver (2013-12-24 10:37:23 +0100) are available in the git repository at: git://linuxtv.org/kdebski/media.git master for you to fetch changes up to 0f6616ebb7a04219ad7aa84

RE: using MFC memory to memery encoder, start stream and queue order problem

2014-01-02 Thread Kamil Debski
ev.org/ > > iQEcBAEBAgAGBQJSxU74AAoJEPb4VsMIzTzi2oEH/1JJqfeZhMwogvWSVz+M3J4Y > 2Bnej0RBBKF0Gu508IWrHy9t+DPg3c3wJt1M0j+GtUsv2Q+Jl2vlmDTLV/Gafzo6 > xywye4raHpqHreFv4Q55SIseDbfV79eO84uv4RuV/fXEuPpo1MlZf9SOGCiAfoQI > ozxqoOPD2l2VaSA/351gtT93lkOREF2EnmVf2Wa31WWHw0LV3aoY9/OosxOiY9Fy > mVHHpYheDwHXdPfrxHXWKEA5GOJ7h0o

[GIT PULL for v3.14] mem2mem patches

2013-12-24 Thread Kamil Debski
The following changes since commit 7d459937dc09bb8e448d9985ec4623779427d8a5: [media] Add driver for Samsung S5K5BAF camera sensor (2013-12-21 07:01:36 -0200) are available in the git repository at: git://linuxtv.org/kdebski/media.git master for you to fetch changes up to 0f6616ebb7a04219ad7

RE: [RFCv4 PATCH 7/8] vb2: return ENODATA in start_streaming in case of too few buffers.

2013-12-11 Thread Kamil Debski
ut buffer is in the incoming queue. (...)" If I understand correctly, now the ioctl will succeed with no buffers queued. Apart from the above you have my ack. Acked-by: Kamil Debski Best wishes, -- Kamil Debski Samsung R&D Institute Poland [1] - http://linuxtv.org/downloads/v4l-dvb-apis/vid

RE: Can't open mfc v5 encode but decode can

2013-12-05 Thread Kamil Debski
Hi Randy, > -Original Message- > From: randy [mailto:lxr1...@hotmail.com] > Sent: Thursday, December 05, 2013 1:27 AM > To: linux-media@vger.kernel.org > Cc: Kamil Debski; m.szyprow...@samsung.com; kyungmin.p...@samsung.com; > m.che...@samsung.com; jtp.p...@samsung

RE: Can't open mfc v5 encode but decode can

2013-12-03 Thread Kamil Debski
sure to set them appropriately. Best wishes, -- Kamil Debski Samsung R&D Institute Poland > -Original Message- > From: randy [mailto:lxr1...@hotmail.com] > Sent: Tuesday, December 03, 2013 11:15 AM > To: linux-media@vger.kernel.org > Cc: kyungmin.p...@samsung.com; k

[GIT PULL FOR v3.13] mem2mem patches - additional patches

2013-10-21 Thread Kamil Debski
Hi Mauro, These are additional mem2mem patches for v3.13. The Exynos Scaler driver was reviewed by Sylwester and he opted for it to be included for 3.13. Best wishes, Kamil Debski The following changes since commit 89ef209d3f943ab8039304f7d41de5721dd67ff5: s5p-mfc: remove deprecated

[GIT PULL FOR v3.13] mem2mem patches

2013-10-18 Thread Kamil Debski
Hi Mauro, These are the mem2mem patches for v3.13. Best wishes, Kamil Debski The following changes since commit 4699b5f34a09e6fcc006567876b0c3d35a188c62: [media] cx24117: prevent mutex to be stuck on locked state if FE init fails (2013-10-14 06:38:56 -0300) are available in the git

RE: [PATCH v2 07/10] [media] coda: prefix v4l2_ioctl_ops with coda_ instead of vidioc_

2013-10-16 Thread Kamil Debski
Hi Philipp, A small comment inline. Best wishes, -- Kamil Debski Linux Kernel Developer Samsung R&D Institute Poland > -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Philipp Zabel > Sent: Mond

RE: [PATCH v2 02/10] [media] coda: only set buffered input queue for decoder

2013-10-16 Thread Kamil Debski
Hi Philipp, I know that this patch's explanation is pretty much contained in the subject, but could you add a short description as well? Best wishes, -- Kamil Debski Linux Kernel Developer Samsung R&D Institute Poland > -Original Message- > From: linux-media-ow...@

RE: [PATCH RFC v2.1 01/10] V4L: Add mem2mem ioctl and file operation helpers

2013-10-16 Thread Kamil Debski
he case for all currently in tree v4l2 m2m > drivers. In order to use the helpers the drivers are required to use > struct v4l2_fh. > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park > Acked-by: Hans Verkuil Acked-by: Kamil Debski > --- > Changes si

RE: [PATCH RFC v2 10/10] s5p-g2d: Use mem-to-mem ioctl helpers

2013-10-16 Thread Kamil Debski
tl and vb2 helpers. > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park Acked-by: Kamil Debski > --- > Changes since v1: > - use m2m context pointer from struct v4l2_fh. > --- > drivers/media/platform/s5p-g2d/g2d.c | 124 ++ &g

RE: [PATCH RFC v2 02/10] mem2mem_testdev: Use mem-to-mem ioctl and vb2 helpers

2013-10-16 Thread Kamil Debski
y using the m2m ioctl and vb2 helpers. > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park Acked-by: Kamil Debski > --- > Changes since v1: > - dropped now redundant struct m2mtest_ctx::m2m_ctx field. > --- > drivers/media/platform/mem2mem_testdev.c

RE: [PATCH RFC v2 04/10] s5p-jpeg: Use mem-to-mem ioctl helpers

2013-10-16 Thread Kamil Debski
tl and vb2 helpers. > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park Acked-by: Kamil Debski > --- > Changes since v1: > - use m2m context pointer from struct v4l2_fh. > --- > drivers/media/platform/s5p-jpeg/jpeg-core.c | 134 +-- >

RE: [PATCH RFC v2 03/10] exynos4-is: Use mem-to-mem ioctl helpers

2013-10-16 Thread Kamil Debski
r by using the m2m ioctl and vb2 > helpers. > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park Acked-by: Kamil Debski > --- > Changes since v1: > - use m2m context pointer from struct v4l2_fh. > --- > drivers/media/platform/exynos4-is/fimc-core.h |

RE: [PATCH v4 3/4] [media] exynos-scaler: Add m2m functionality for the SCALER driver

2013-10-16 Thread Kamil Debski
licit declaration of function 'kfree' [-Werror=implicit-function-declaration] Best wishes, -- Kamil Debski Linux Kernel Developer Samsung R&D Institute Poland > -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel

RE: [PATCH v5 3/4] v4l: ti-vpe: Add VPE mem to mem driver

2013-10-15 Thread Kamil Debski
Hi Archit, Please find my comment below. > From: Hans Verkuil [mailto:hverk...@xs4all.nl] > Sent: Tuesday, October 15, 2013 3:52 PM > > Kamil, > > Can you take this driver as m2m maintainer or should I take it? > > Regards, > > Hans > > On 10/15/2013 03:47 PM, Archit Taneja wrote: > >

RE: [PATCH v5 3/4] v4l: ti-vpe: Add VPE mem to mem driver

2013-10-15 Thread Kamil Debski
Hi Hans, Now, I am a bit busy with... USB. I have to admit I have a backlog of patches to look through and prepare a tree for Mauro. I wanted to do this on Thursday or Friday. Is it ok? BTW if you see any m2m patches in patchwork feel free to delegate them to me. Best wishes, -- Kamil Debski

RE: [PATCH v1 16/19] v4l: Add encoding camera controls.

2013-09-09 Thread Kamil Debski
Hi, > From: Pawel Osciak [mailto:posc...@chromium.org] > Sent: Monday, September 09, 2013 9:59 AM > > On Mon, Sep 9, 2013 at 4:52 PM, Hans Verkuil wrote: > > On 09/09/2013 05:48 AM, Pawel Osciak wrote: > >> Hi Hans, > >> Thanks for the comments, one question inline. > >> > >> On Fri, Aug 30, 201

[PATCH] s5p-mfc: Fix build break in s5p_mfc_dec.c and s5p_mfc_enc.c

2013-08-29 Thread Kamil Debski
-off-by: Kamil Debski --- Hi Mauro, There is a build break in the current linux-next (20130829). This patch fixes the merge confilct that caused the build break. Best wishes, Kamil Debski drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 47 +++--- drivers/media/platform/s5p

[GIT PULL] For v3.12

2013-08-23 Thread Kamil Debski
The following changes since commit bfd22c490bc74f9603ea90c37823036660a313e2: v4l2-common: warning fix (W=1): add a missed function prototype (2013-08-18 10:18:30 -0300) are available in the git repository at: git://linuxtv.org/kdebski/media.git 20130823-for-v3.12 for you to fetch changes up

RE: [PATCH v6 2/3] [media] coda: Check the return value from clk_prepare_enable()

2013-08-21 Thread Kamil Debski
Hi Fabio, I still cannot apply this patch. There is something wrong. Could you rebase this patch (or even better all 3 patches) to: http://git.linuxtv.org/media_tree.git/shortlog/refs/heads/master ? I really want to send the pull request before the end of the week. Best wishes, -- Kamil

RE: [PATCH 2/2] media: s5p-mfc: remove DT hacks and simplify initialization code

2013-08-06 Thread Kamil Debski
Hi Kukjin, This patch looks good. Best wishes, Kamil Debski > From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] > Sent: Monday, August 05, 2013 2:27 PM > > This patch removes custom initialization of reserved memory regions > from s5p-mfc driver. Memory initialization can

[GIT PULL] New features for 3.12

2013-08-06 Thread Kamil Debski
The following changes since commit b43ea8068d2090cb1e44632c8a938ab40d2c7419: [media] cx23885: Fix TeVii S471 regression since introduction of ts2020 (2013-07-30 17:23:24 -0300) are available in the git repository at: git://linuxtv.org/kdebski/media.git new-for-3.12-2nd for you to fetch chan

RE: [PATCH v4 1/3] [media] coda: Fix error paths

2013-08-01 Thread Kamil Debski
> > > dma_free_coherent(&dev->plat_dev->dev, CODA_PARA_BUF_SIZE, > > ctx->parabuf.vaddr, ctx->parabuf.paddr); > > - v4l2_m2m_ctx_release(ctx->m2m_ctx); > > v4l2_ctrl_handler_free(&ctx->ctrls); > > - clk_disable_unprepare(dev->clk_per); > > + v4l2_m2m_ctx_release(ctx->m2m_ctx); > > clk_disable_unprepare(dev->clk_ahb); > > + clk_disable_unprepare(dev->clk_per); > > v4l2_fh_del(&ctx->fh); > > v4l2_fh_exit(&ctx->fh); > > clear_bit(ctx->idx, &dev->instance_mask); > > this looks better, thanks. Could you rebase the patches onto Kamil's > http://git.linuxtv.org/kdebski/media.git/shortlog/refs/heads/new-for- > 3.12 > branch? Could you rebase these patches onto http://git.linuxtv.org/kdebski/media.git/shortlog/refs/heads/new-for-3.12-2nd ? I get some conflicts and I am not sure how to resolve them. Best wishes, -- Kamil Debski Linux Kernel Developer Samsung R&D Institute Poland -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [RESEND PATCH v10 1/8] drivers: phy: add generic PHY framework

2013-07-29 Thread Kamil Debski
((dev), THIS_MODULE, (xlate)) I think this should be: + __devm_of_phy_provider_register((dev), THIS_MODULE, (xlate)) Right? > + > +static inline void phy_set_drvdata(struct phy *phy, void *data) { > + dev_set_drvdata(&phy->dev, data); > +} > + > +static inline v

[GIT PULL] For 3.12

2013-07-22 Thread Kamil Debski
The following changes since commit 348d1299b808a9e68a7dee2a4de6b555600099de: s5p-g2d: Fix registration failure (2013-07-22 14:17:28 +0200) are available in the git repository at: git://git.linuxtv.org/kdebski/media.git new-for-3.12 for you to fetch changes up to abe28f650794d42c7cc1d0ff3759

[GIT PULL] Fixes for 3.11

2013-07-22 Thread Kamil Debski
The following changes since commit cab602f1930b2c3fb023ff82d371a915f2168457: Linux 3.11-rc2 (2013-07-22 14:32:12 +0200) are available in the git repository at: git://git.linuxtv.org/kdebski/media.git fixes-for-3.11 for you to fetch changes up to 55f8d96dc132fef5b2c3f3d9b4d891d673e8ce33:

RE: [PATCH 1/1] [media] s5p-g2d: Fix registration failure

2013-07-18 Thread Kamil Debski
44) > from [] (kernel_init_freeable+0x13c/0x1d8) > [] (kernel_init_freeable+0x13c/0x1d8) from [] > (kernel_init+0xc/0x160) [] (kernel_init+0xc/0x160) from > [] (ret_from_fork+0x14/0x3c) ---[ end trace > 4e0ec028b0028e02 ]--- s5p-g2d 1280.g2d: Failed to register video > device

RE: [PATCH] media: s5p-tv: Fix Warn on driver probe

2013-07-09 Thread Kamil Debski
sent to hardware. Here you can find more information on how the timestamp field should be handled in drivers https://patchwork.linuxtv.org/patch/18813/ Best wishes, -- Kamil Debski Linux Kernel Developer Samsung R&D Institute Poland > -Original Message- > From: linu

[GIT PULL] mem2mem driver changes

2013-06-28 Thread Kamil Debski
The following changes since commit 53f501a96b81cedb8449153fd2afd533eeac3172: Merge branch 'v4l_for_linus' into patchwork (2013-06-25 15:30:23 +0200) are available in the git repository at: git://git.linuxtv.org/kdebski/media.git master for you to fetch changes up to f4603fe949a1e4ec61f4900

RE: [PATCH v2 8/8] [media] coda: add CODA7541 decoding support

2013-06-27 Thread Kamil Debski
Hi Philipp, This patch did not apply well on my tree. I find this quite strange. I did try and applied it manually, but please check here if it is correct: http://git.linuxtv.org/kdebski/media.git/shortlog/refs/heads/master Best wishes, -- Kamil Debski Linux Kernel Developer Samsung R&a

RE: [PATCH] mem2mem_testdev: fix missing v4l2_dev assignment

2013-06-26 Thread Kamil Debski
Hi Hans, > From: Hans Verkuil [mailto:hverk...@xs4all.nl] > Sent: Wednesday, June 26, 2013 8:31 AM > > Hi Kamil, > > This patch adds the missing v4l2_dev assignment as reported by > Fengguang. > > It also fixes a poorly formatted message: > > m2m-testdev m2m-testdev.0: mem2mem-testdevDevice re

RE: [PATCH v3 4/8] [media] s5p-mfc: Core support for MFC v7

2013-06-26 Thread Kamil Debski
Hi, > -Original Message- > From: Sachin Kamat [mailto:sachin.ka...@linaro.org] > Sent: Wednesday, June 26, 2013 9:05 AM > To: Arun Kumar K > Cc: Arun Kumar K; LMML; Kamil Debski; jtp.p...@samsung.com; Sylwester > Nawrocki; Hans Verkuil; avnd.ki...@samsung.com > Subje

RE: [PATCH v3 7/8] [media] V4L: Add VP8 encoder controls

2013-06-25 Thread Kamil Debski
X_GOLDEN_FRAME_SEL (V4L2_CID_MPEG_BASE+506) > +enum v4l2_vp8_golden_frame_sel { > + V4L2_VPX_GOLDEN_FRAME_USE_PREV = 0, > + V4L2_VPX_GOLDEN_FRAME_USE_REF_PERIOD= 1, > +}; > + > /* MPEG-class control IDs specific to the CX2341x driver as defined > by V4L2 */ > #define V4L2_CID_MPEG_CX2341X_BASE > (V4L2_CTRL_CLASS_MPEG | 0x1000) > #define V4L2_CID_MPEG_CX2341X_VIDEO_SPATIAL_FILTER_MODE > (V4L2_CID_MPEG_CX2341X_BASE+0) > @@ -590,7 +617,6 @@ enum v4l2_mpeg_mfc51_video_force_frame_type { > #define V4L2_CID_MPEG_MFC51_VIDEO_H264_ADAPTIVE_RC_STATIC > (V4L2_CID_MPEG_MFC51_BASE+53) > #define V4L2_CID_MPEG_MFC51_VIDEO_H264_NUM_REF_PIC_FOR_P > (V4L2_CID_MPEG_MFC51_BASE+54) > > - > /* Camera class control IDs */ > > #define V4L2_CID_CAMERA_CLASS_BASE (V4L2_CTRL_CLASS_CAMERA | > 0x900) > @@ -818,7 +844,6 @@ enum v4l2_jpeg_chroma_subsampling { > #define V4L2_CID_PIXEL_RATE > (V4L2_CID_IMAGE_PROC_CLASS_BASE + 2) > #define V4L2_CID_TEST_PATTERN > (V4L2_CID_IMAGE_PROC_CLASS_BASE + 3) > > - > /* DV-class control IDs defined by V4L2 */ > #define V4L2_CID_DV_CLASS_BASE (V4L2_CTRL_CLASS_DV | > 0x900) > #define V4L2_CID_DV_CLASS(V4L2_CTRL_CLASS_DV | 1) > -- > 1.7.9.5 Best wishes, -- Kamil Debski Linux Kernel Developer Samsung R&D Institute Poland -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH v3 5/8] [media] s5p-mfc: Update driver for v7 firmware

2013-06-25 Thread Kamil Debski
/* sei parse */ > WRITEL(ctx->sei_fp_parse & 0x1, S5P_FIMV_D_SEI_ENABLE_V6); > > @@ -1254,6 +1283,12 @@ static int s5p_mfc_init_encode_v6(struct > s5p_mfc_ctx *ctx) > return -EINVAL; > } > > + /* Set stride lengths */ > + if (IS_MFCV7(dev)) { > +

RE: [PATCH 3/6] [media] s5p-mfc: Core support for MFC v7

2013-06-18 Thread Kamil Debski
Hi Arun, Sachin, > -Original Message- > From: Sachin Kamat [mailto:sachin.ka...@linaro.org] > Sent: Tuesday, June 18, 2013 7:27 AM > To: Arun Kumar K > Cc: Kamil Debski; Arun Kumar K; LMML; jtp.p...@samsung.com; Sylwester > Nawrocki; avnd.ki...@samsung.com > Su

RE: [PATCH 3/6] [media] s5p-mfc: Core support for MFC v7

2013-06-17 Thread Kamil Debski
Hi Arun, I have read your patches. They seem alright, I back comments made by Hans and Sylwester. I have one question, which follows inline. Best wishes, -- Kamil Debski Linux Kernel Developer Samsung R&D Institute Poland > -Original Message- > From: Arun Kumar K [m

RE: [PATCH v4] [media] mem2mem: add support for hardware buffered queue

2013-06-13 Thread Kamil Debski
devices were supposed to use videobuf2 directly. Please state your opinions. Best wishes, -- Kamil Debski Linux Kernel Developer Samsung R&D Institute Poland > -Original Message- > From: Philipp Zabel [mailto:p.za...@pengutronix.de] > Sent: Monday, June 03, 2013 10:24 A

[GIT PULL FOR v3.11] Next features in mem2mem drivers

2013-05-29 Thread Kamil Debski
The following changes since commit 7eac97d7e714429f7ef1ba5d35f94c07f4c34f8e: [media] media: pci: remove duplicate checks for EPERM (2013-05-27 09:34:56 -0300) are available in the git repository at: git://git.linuxtv.org/kdebski/media.git master for you to fetch changes up to 413833e6da43c9

[GIT PULL FOR v3.10] mem2mem fixes for 3.10

2013-05-29 Thread Kamil Debski
The following changes since commit 6719a4974600fdaa4a3ac2ea2aed819a35d06605: [media] staging/solo6x10: select the desired font (2013-05-27 09:38:57 -0300) are available in the git repository at: git://git.linuxtv.org/kdebski/media.git fixes-for-3.10 for you to fetch changes up to d1b03ab0b4

RE: [RFC] [media] mem2mem: add support for hardware buffered queue

2013-05-29 Thread Kamil Debski
Hi, > -Original Message- > From: Philipp Zabel [mailto:p.za...@pengutronix.de] > Sent: Wednesday, May 29, 2013 1:13 PM > To: Kamil Debski > Cc: linux-media@vger.kernel.org; 'Mauro Carvalho Chehab'; 'Pawel > Osciak'; 'John Sheu'; 'Han

RE: [PATCH 0/9] CODA patches in preparation for decoding support

2013-05-29 Thread Kamil Debski
ine over 80 characters #588: FILE: drivers/media/platform/coda.c:1114: + value |= (q_data_src->height & CODA7_PICHEIGHT_MASK) << CODA_PICHEIGHT_OFFSET; total: 0 errors, 6 warnings, 603 lines checked Best wishes, -- Kamil Debski Linux Kernel Developer Samsung R&D Inst

RE: [PATCH 1/2] [media] v4l2-mem2mem: add v4l2_m2m_create_bufs helper

2013-05-29 Thread Kamil Debski
, struct vb2_queue *vq; vq = v4l2_m2m_get_vq(m2m_ctx, create->format.type); -return vb2_create_bufs(vq, create); + return vb2_create_bufs(vq, create); } EXPORT_SYMBOL_GPL(v4l2_m2m_create_bufs); Best wishes, -- Kamil Debski Linux Kernel Developer Samsung R&D Institute

RE: [RFC] [media] mem2mem: add support for hardware buffered queue

2013-05-29 Thread Kamil Debski
s arguments. We can get back to this discussion, if we are sure that events are not enough. Please also note that we need to keep backward compatibility. Original EOS buffer flag patches by Andrzej and part of the discussion can be found here: 1) https://linuxtv.org/patch/10624/ 2) https://l

RE: [PATCH] [media] v4l2: mem2mem: save irq flags correctly

2013-05-28 Thread Kamil Debski
Hi Sheu, Thank you for this patch. May I also ask you to add me to Cc of next mem2mem patches, as I am the mem2mem submaintainer? Best wishes, -- Kamil Debski Linux Kernel Developer Samsung R&D Institute Poland > -Original Message- > From: linux-media-ow...@vger.

RE: [PATCH 2/2] [media] s5p-mfc: Remove redundant use of of_match_ptr macro

2013-05-24 Thread Kamil Debski
Hi Sachin, Thank you for your patch. Best wishes, -- Kamil Debski Linux Kernel Developer Samsung R&D Institute Poland > -Original Message- > From: Sachin Kamat [mailto:sachin.ka...@linaro.org] > Sent: Thursday, May 23, 2013 6:51 AM > To: linux-media@vger.kernel.o

RE: [RFC PATCH for 3.10] Update Codec section in DocBook

2013-05-08 Thread Kamil Debski
Hi, > From: Hans Verkuil [mailto:hverk...@xs4all.nl] > Sent: Tuesday, May 07, 2013 6:47 PM > > On Tue 7 May 2013 17:42:57 Kamil Debski wrote: > > Hi Hans, > > > > Thanks for this patch. I remember that there was some discussion > about > > it and the conclu

RE: [RFC PATCH for 3.10] Update Codec section in DocBook

2013-05-07 Thread Kamil Debski
directly with Mauro? Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland R&D Center > -Original Message- > From: Hans Verkuil [mailto:hverk...@xs4all.nl] > Sent: Tuesday, May 07, 2013 2:06 PM > To: linux-media > Cc: Kamil Debski > Subject: [RFC PATCH

RE: [PATCH 4/7 v2] coda: Add copy time stamp handling

2013-04-25 Thread Kamil Debski
Hi Philipp, Thank you for testing the patch. I would love to add your Tested-by tag to the commit, but I had already sent the pull request to Mauro. It was already very late to post fixes. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland R&D Center > -Original

RE: [GIT PULL] m2m: Time stamp related fixes

2013-04-25 Thread Kamil Debski
Hi, > From: Mauro Carvalho Chehab [mailto:mche...@redhat.com] > Sent: Thursday, April 25, 2013 2:45 PM > > Em Thu, 25 Apr 2013 14:11:04 +0200 > Kamil Debski escreveu: > > > Hi Mauro, > > > > Sorry for posting this so late. The patches in this pull reques

[GIT PULL] m2m: Time stamp related fixes

2013-04-25 Thread Kamil Debski
Hi Mauro, Sorry for posting this so late. The patches in this pull request add timestamp_type handling to mem2mem drivers. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland R&D Center The following changes since commit 5f3f254f7c138a22a544b80ce2c14a3fc4ed

[PATCH 6/7 v2] m2m-deinterlace: Add copy time stamp handling

2013-04-25 Thread Kamil Debski
Since the introduction of the timestamp_type field, it is necessary that the driver chooses which type it will use. This patch adds support for the timestamp_type. Signed-off-by: Kamil Debski Signed-off-by: Kyungmin Park Javier Martin --- drivers/media/platform/m2m-deinterlace.c |5

[PATCH 7/7 v2] mx2-emmaprp: Add copy time stamp handling

2013-04-25 Thread Kamil Debski
Since the introduction of the timestamp_type field, it is necessary that the driver chooses which type it will use. This patch adds support for the timestamp_type. Signed-off-by: Kamil Debski Signed-off-by: Kyungmin Park Cc: Sylwester Nawrocki Cc: Hans Verkuil Cc: Thierry Reding Cc: Javier

[PATCH 5/7 v2] exynos-gsc: Add copy time stamp handling

2013-04-25 Thread Kamil Debski
Since the introduction of the timestamp_type field, it is necessary that the driver chooses which type it will use. This patch adds support for the timestamp_type. Signed-off-by: Kamil Debski Signed-off-by: Kyungmin Park Cc: Sylwester Nawrocki Cc: Shaik Ameer Basha --- drivers/media/platform

[PATCH 4/7 v2] coda: Add copy time stamp handling

2013-04-25 Thread Kamil Debski
Since the introduction of the timestamp_type field, it is necessary that the driver chooses which type it will use. This patch adds support for the timestamp_type. Signed-off-by: Kamil Debski Signed-off-by: Kyungmin Park Cc: Philipp Zabel Cc: Javier Martin Cc: Fabio Estevam --- drivers

[PATCH 3/7 v2] s5p-mfc: Optimize copy time stamp handling

2013-04-25 Thread Kamil Debski
For the sake of simplicity and readability memcpy was replaced with assignment. Signed-off-by: Kamil Debski Signed-off-by: Kyungmin Park Cc: Jeongtae Park --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH 2/7 v2] s5p-jpeg: Add copy time stamp handling

2013-04-25 Thread Kamil Debski
Since the introduction of the timestamp_type field, it is necessary that the driver chooses which type it will use. This patch adds support for the timestamp_type. Signed-off-by: Kamil Debski Signed-off-by: Kyungmin Park Cc: Sylwester Nawrocki Cc: Sachin Kamat --- drivers/media/platform/s5p

[PATCH 0/7 v2] Add copy time stamp handling to mem2mem drivers

2013-04-25 Thread Kamil Debski
messages. Best wishes, Kamil Debski Kamil Debski (7): s5p-g2d: Add copy time stamp handling s5p-jpeg: Add copy time stamp handling s5p-mfc: Optimize copy time stamp handling coda: Add copy time stamp handling exynos-gsc: Add copy time stamp handling m2m-deinterlace: Add copy time stamp

[PATCH 1/7 v2] s5p-g2d: Add copy time stamp handling

2013-04-25 Thread Kamil Debski
Since the introduction of the timestamp_type field, it is necessary that the driver chooses which type it will use. This patch adds support for the timestamp_type. Signed-off-by: Kamil Debski Signed-off-by: Kyungmin Park --- drivers/media/platform/s5p-g2d/g2d.c |5 + 1 file changed, 5

RE: [PATCH 0/7] Add copy time stamp handling to mem2mem drivers

2013-04-25 Thread Kamil Debski
Hi, > From: Hans Verkuil [mailto:hverk...@xs4all.nl] > Sent: Thursday, April 25, 2013 11:59 AM > > On Thu 25 April 2013 11:49:43 Kamil Debski wrote: > > Hi, > > > > This set of patches adds support for copy time stamp handling in the > > following mem2mem dr

<    1   2   3   4   5   6   >