v4l2_device_register_subdev_nodes() clean_up code

2014-05-30 Thread Krzysztof Czarnowski
Hi, In clean_up: section of v4l2_device_register_subdev_nodes() we have: if (!sd-devnode) break; Maybe I miss something, but shouldn't it be rather continue instead of break? Regards, Krzysztof -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a

Re: v4l2_device_register_subdev_nodes() clean_up code

2014-05-30 Thread Krzysztof Czarnowski
as an improvement suggestion. Any comments welcome, Krzysztof On Fri, May 30, 2014 at 3:47 PM, Sakari Ailus sakari.ai...@iki.fi wrote: On Fri, May 30, 2014 at 03:27:27PM +0200, Krzysztof Czarnowski wrote: Sure, a moment :-) One additional thing: I think sd-devnode should also be set as NULL

V4L2 control API - choosing base CID for private controls

2014-05-22 Thread Krzysztof Czarnowski
Hi, I got completely confused while trying to create private controls with control API and when I finally got down to sanity checks in v4l2_ctrl_new() in v4l2-ctrls.c... It would be nice if the following explanation by Hans (archive msg69922) or maybe some more elaborate version could somehow