gpio-ir-recv: use gpiolib API")
For some reason only partial patch was applied. Also include
gpio/consumer.h otherwise compile test fails.
Reported-by: kbuild test robot <fengguang...@intel.com>
Signed-off-by: Ladislav Michl <la...@linux-mips.org>
---
Changes:
-v2: replace Sea
On Thu, Oct 05, 2017 at 12:03:28PM +0100, Sean Young wrote:
> The 0-day robot reports:
>
>drivers/media/rc/gpio-ir-recv.c: In function 'gpio_ir_recv_irq':
> >> drivers/media/rc/gpio-ir-recv.c:38:8: error: implicit declaration of
> >> function 'gpiod_get_value'
On Mon, Sep 11, 2017 at 09:13:32AM +0200, Ladislav Michl wrote:
> On Mon, Sep 11, 2017 at 11:58:43AM +0900, Andi Shyti wrote:
> > Hi Ladislav,
> >
> > > > > Serie was rebased on top of current linux.git, but something
> > > > > happened there and
On Mon, Sep 11, 2017 at 11:58:43AM +0900, Andi Shyti wrote:
> Hi Ladislav,
>
> > > > Serie was rebased on top of current linux.git, but something
> > > > happened there and my userspace decoder no longer works: driver
> > > > reports completely bogus timing such as (rc-5):
> > > > ^427, _1342,
Hi Andi,
On Fri, Sep 08, 2017 at 11:21:10AM +0900, Andi Shyti wrote:
> Hi Ladislav,
>
> > Serie was rebased on top of current linux.git, but something
> > happened there and my userspace decoder no longer works: driver
> > reports completely bogus timing such as (rc-5):
> > ^427, _1342, ^945,
Gpiolib API is preferred way to access gpios.
Signed-off-by: Ladislav Michl <la...@linux-mips.org>
---
Changes:
-v2: rebased to current linux.git
drivers/media/rc/Kconfig| 1 +
drivers/media/rc/gpio-ir-recv.c | 59 +++--
2 files chang
gpio_ir_recv_platform_data are not used anywhere in kernel tree,
so remove it.
Signed-off-by: Ladislav Michl <la...@linux-mips.org>
---
Changes:
-v2: rebased to current linux.git
drivers/media/rc/gpio-ir-recv.c | 98 +++-
include/linux/platform_data
There already is standard macro providing driver name, use it.
Signed-off-by: Ladislav Michl <la...@linux-mips.org>
---
Changes:
-v2: rebased to current linux.git
drivers/media/rc/gpio-ir-recv.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/media/rc/g
Use of devm_request_irq simplifies error unwinding and as
free_irq was the last user of driver remove function,
remove it too.
Signed-off-by: Ladislav Michl <la...@linux-mips.org>
---
Changes:
-v2: rebased to current linux.git
drivers/media/rc/gpio-ir-recv.c | 22 +++
Requesting any context irq is not actually great idea since threaded
interrupt handler is run at too unpredictable time which turns
timing information wrong. Fix it by requesting regular interrupt.
Signed-off-by: Ladislav Michl <la...@linux-mips.org>
---
Changes:
-v2: rebased to c
Using explicit struct device variable makes code a bit more readable.
Signed-off-by: Ladislav Michl <la...@linux-mips.org>
---
Changes:
-v2: rebased to current linux.git
drivers/media/rc/gpio-ir-recv.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/d
Use of devm_rc_register_device simplifies error unwinding.
Signed-off-by: Ladislav Michl <la...@linux-mips.org>
---
Changes:
-v2: rebased to current linux.git
drivers/media/rc/gpio-ir-recv.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/media/rc/g
Use of devm_gpio_request_one simplifies error unwinding.
Signed-off-by: Ladislav Michl <la...@linux-mips.org>
---
Changes:
-v2: rebased to current linux.git
drivers/media/rc/gpio-ir-recv.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/media/rc/g
Use of devm_rc_allocate_device simplifies error unwinding.
Signed-off-by: Ladislav Michl <la...@linux-mips.org>
---
Changes:
-v2: rebased to current linux.git
drivers/media/rc/gpio-ir-recv.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/media/rc/g
nothing to do with my changes, I'm sending it anyway
for review, which I do not expect to happen until merge window
ends.
Ladislav Michl (10):
media: rc: gpio-ir-recv: use helper vaiable to acess device info
media: rc: gpio-ir-recv: use devm_kzalloc
media: rc: gpio-ir-recv: use
Use of devm_kzalloc simplifies error unwinding.
Signed-off-by: Ladislav Michl <la...@linux-mips.org>
---
Changes:
-v2: rebased to current linux.git
drivers/media/rc/gpio-ir-recv.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/media/rc/gpio-ir-re
Use of gpiolib API simplifies driver a bit.
Signed-off-by: Ladislav Michl <la...@linux-mips.org>
---
drivers/media/rc/Kconfig| 1 +
drivers/media/rc/gpio-ir-recv.c | 64 +
2 files changed, 27 insertions(+), 38 deletions(-)
diff --git a/d
gpio_ir_recv_platform_data are not used anywhere in kernel tree,
so remove it.
Signed-off-by: Ladislav Michl <la...@linux-mips.org>
---
drivers/media/rc/gpio-ir-recv.c | 98 +++-
include/linux/platform_data/media/gpio-ir-recv.h | 23 --
2 files c
There already is standard macro providing driver name, use it.
Signed-off-by: Ladislav Michl <la...@linux-mips.org>
---
drivers/media/rc/gpio-ir-recv.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/media/rc/gpio-ir-recv.c b/drivers/media/rc/gpio-ir-recv.c
Requesting any context irq is not actually great idea since threaded
interrupt handler is run at too unpredictable time which turns
timing information wrong. Fix it by requesting regular interrupt.
Signed-off-by: Ladislav Michl <la...@linux-mips.org>
---
drivers/media/rc/gpio-ir-recv.c | 2
Use of devm_request_irq simplifies error unwinding.
Signed-off-by: Ladislav Michl <la...@linux-mips.org>
---
drivers/media/rc/gpio-ir-recv.c | 14 +++---
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/media/rc/gpio-ir-recv.c b/drivers/media/rc/gpio-ir-recv.c
Use of devm_rc_register_device simplifies error unwinding.
Signed-off-by: Ladislav Michl <la...@linux-mips.org>
---
drivers/media/rc/gpio-ir-recv.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/media/rc/gpio-ir-recv.c b/drivers/media/rc/gpio-ir-recv.c
Use of devm_gpio_request_one simplifies error unwinding.
Signed-off-by: Ladislav Michl <la...@linux-mips.org>
---
drivers/media/rc/gpio-ir-recv.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/media/rc/gpio-ir-recv.c b/drivers/media/rc/gpio-ir-recv.c
Use of devm_rc_allocate_device simplifies error unwinding.
Signed-off-by: Ladislav Michl <la...@linux-mips.org>
---
drivers/media/rc/gpio-ir-recv.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/media/rc/gpio-ir-recv.c b/drivers/media/rc/gpio-ir-recv.c
Use of devm_kzalloc simplifies error unwinding.
Signed-off-by: Ladislav Michl <la...@linux-mips.org>
---
drivers/media/rc/gpio-ir-recv.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/media/rc/gpio-ir-recv.c b/drivers/media/rc/gpio-ir-recv.c
Using explicit struct device variable makes code a bit more readable.
Signed-off-by: Ladislav Michl <la...@linux-mips.org>
---
drivers/media/rc/gpio-ir-recv.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/media/rc/gpio-ir-recv.c b/drivers/media/r
This patch serie brings driver closer to recently used APIs
and removes no longer used gpio_ir_recv_platform_data
support.
It was done as an excercise before writing similar driver using
FIQ and hw timers as this one gives too imprecise timing.
Ladislav Michl (10):
media: rc: gpio-ir-recv: use
27 matches
Mail list logo
