Hi Uwe,
Thanks for your reviewing. Please see the comments below.
On Wed, Sep 25, 2013 at 07:47:19PM -0700, Libin Yang wrote:
In the clk enable and prepare function, we will check the NULL
pointer. So it should be no problem.
I'm not sure what you mean here and unfortunately your quoting style
Hi Russell,
-Original Message-
From: Russell King - ARM Linux [mailto:li...@arm.linux.org.uk]
Sent: Thursday, September 26, 2013 4:24 PM
To: Uwe Kleine-König
Cc: Libin Yang; Jonathan Corbet; Mauro Carvalho Chehab;
linux-media@vger.kernel.org;
linux-arm-ker...@lists.infradead.org; ker
...@lists.infradead.org; Russell King; ker...@pengutronix.de; Libin Yang
Subject: Re: [PATCH v2] [media] marvell-ccic: simplify and fix clk handling (a
bit)
On Tue, 24 Sep 2013 20:59:47 +0200
Uwe Kleine-König u.kleine-koe...@pengutronix.de wrote:
The marvell-ccic does several things wrong
Corbet
Sent: Wednesday, September 25, 2013 3:12 PM
To: Wei Yongjun
Cc: m.che...@samsung.com; yongjun_...@trendmicro.com.cn; linux-
me...@vger.kernel.org; Libin Yang
Subject: Re: [PATCH] [media] marvell-ccic: drop free_irq for devm_request_irq
allocated irq
On Tue, 24 Sep 2013 10:35:50 +0800
Wei
Hi Jonathan,
Do you have some comments?
Regards,
Libin
-Original Message-
From: Libin Yang [mailto:lby...@marvell.com]
Sent: Wednesday, July 03, 2013 1:56 PM
To: cor...@lwn.net; g.liakhovet...@gmx.de
Cc: linux-media@vger.kernel.org; albert.v.w...@gmail.com; Libin Yang
Subject: [PATCH
This patch adds the reset ccic phy operation when stop streaming.
Stop streaming without reset ccic phy, the next start streaming
may be unstable.
Also need add CCIC2 definition when PXA688/PXA2128 support dual ccics.
Signed-off-by: Albert Wang twan...@marvell.com
Signed-off-by: Libin Yang lby
Wang twan...@marvell.com
Signed-off-by: Libin Yang lby...@marvell.com
Acked-by: Jonathan Corbet cor...@lwn.net
Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
---
drivers/media/platform/marvell-ccic/mcam-core.c | 30 ---
1 file changed, 26 insertions(+), 4 deletions
changes in mcam_init_clk function
Patch 7:
A little adjustment based patch 2 change
Libin Yang (7):
marvell-ccic: add MIPI support for marvell-ccic driver
marvell-ccic: add clock tree support for marvell-ccic driver
marvell-ccic: reset ccic phy when stop streaming for stability
marvell
This patch refines mcam_set_contig_buffer() in mcam core.
It can remove redundant code line and enhance readability.
Signed-off-by: Albert Wang twan...@marvell.com
Signed-off-by: Libin Yang lby...@marvell.com
Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
Acked-by: Jonathan Corbet cor
This patch adds the clock tree support for marvell-ccic.
Signed-off-by: Libin Yang lby...@marvell.com
Signed-off-by: Albert Wang twan...@marvell.com
---
drivers/media/platform/marvell-ccic/mcam-core.h |5 ++
drivers/media/platform/marvell-ccic/mmp-driver.c | 61 ++
2
This patch adds the MIPI support for marvell-ccic.
Board driver should determine whether using MIPI or not.
Signed-off-by: Albert Wang twan...@marvell.com
Signed-off-by: Libin Yang lby...@marvell.com
---
drivers/media/platform/marvell-ccic/cafe-driver.c |4 +-
drivers/media/platform/marvell
This patch switchs to resource managed allocation and request in mmp-driver.
It can remove free resource operations.
Signed-off-by: Albert Wang twan...@marvell.com
Signed-off-by: Libin Yang lby...@marvell.com
---
drivers/media/platform/marvell-ccic/mmp-driver.c | 60 --
1
This patch adds some planar formats support for marvell-ccic.
Signed-off-by: Albert Wang twan...@marvell.com
Signed-off-by: Libin Yang lby...@marvell.com
Acked-by: Jonathan Corbet cor...@lwn.net
---
drivers/media/platform/marvell-ccic/mcam-core.c | 192 +++
drivers/media
This patch adds the MIPI support for marvell-ccic.
Board driver should determine whether using MIPI or not.
Signed-off-by: Albert Wang twan...@marvell.com
Signed-off-by: Libin Yang lby...@marvell.com
---
drivers/media/platform/marvell-ccic/cafe-driver.c |4 +-
drivers/media/platform/marvell
This patch adds the clock tree support for marvell-ccic.
Signed-off-by: Libin Yang lby...@marvell.com
Signed-off-by: Albert Wang twan...@marvell.com
---
drivers/media/platform/marvell-ccic/mcam-core.h |6 +++
drivers/media/platform/marvell-ccic/mmp-driver.c | 47 ++
2
This patch adds the reset ccic phy operation when stop streaming.
Stop streaming without reset ccic phy, the next start streaming
may be unstable.
Also need add CCIC2 definition when PXA688/PXA2128 support dual ccics.
Signed-off-by: Albert Wang twan...@marvell.com
Signed-off-by: Libin Yang lby
Wang twan...@marvell.com
Signed-off-by: Libin Yang lby...@marvell.com
Acked-by: Jonathan Corbet cor...@lwn.net
Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
---
drivers/media/platform/marvell-ccic/mcam-core.c | 30 ---
1 file changed, 26 insertions(+), 4 deletions
-EOF pair check to make the CCIC more stable
Patch 7: use resource managed allocation
Libin Yang (7):
marvell-ccic: add MIPI support for marvell-ccic driver
marvell-ccic: add clock tree support for marvell-ccic driver
marvell-ccic: reset ccic phy when stop streaming for stability
marvell-ccic
This patch adds some planar formats support for marvell-ccic.
Signed-off-by: Albert Wang twan...@marvell.com
Signed-off-by: Libin Yang lby...@marvell.com
Acked-by: Jonathan Corbet cor...@lwn.net
---
drivers/media/platform/marvell-ccic/mcam-core.c | 192 +++
drivers/media
This patch refines mcam_set_contig_buffer() in mcam core.
It can remove redundant code line and enhance readability.
Signed-off-by: Albert Wang twan...@marvell.com
Signed-off-by: Libin Yang lby...@marvell.com
Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
Acked-by: Jonathan Corbet cor
This patch switchs to resource managed allocation and request in mmp-driver.
It can remove free resource operations.
Signed-off-by: Albert Wang twan...@marvell.com
Signed-off-by: Libin Yang lby...@marvell.com
Acked-by: Jonathan Corbet cor...@lwn.net
---
drivers/media/platform/marvell-ccic/mmp
Hi Jonathan,
Sorry, it's my silly fault. I will update it.
Regards,
Libin
-Original Message-
From: Jonathan Corbet [mailto:cor...@lwn.net]
Sent: Tuesday, July 02, 2013 12:08 PM
To: Libin Yang
Cc: g.liakhovet...@gmx.de; linux-media@vger.kernel.org;
albert.v.w...@gmail.com;
Albert Wang
Hi Jonathan,
Sorry for delay reply. Please see the below comments.
Regards,
Libin
-Original Message-
From: Jonathan Corbet [mailto:cor...@lwn.net]
Sent: Saturday, June 22, 2013 1:00 AM
To: Libin Yang
Cc: g.liakhovet...@gmx.de; mche...@redhat.com;
linux-media@vger.kernel.org
Hi Jonathan,
Do you mean using IS_ERR() here directly? I think it should be OK. I will
change to IS_ERR() in next version.
Regards,
Libin
-Original Message-
From: Jonathan Corbet [mailto:cor...@lwn.net]
Sent: Saturday, June 22, 2013 1:02 AM
To: Libin Yang
Cc: g.liakhovet...@gmx.de
Hi Guennadi,
Thanks for your careful review. Please help see my comments below.
-Original Message-
From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
Sent: Tuesday, March 05, 2013 5:35 AM
To: Albert Wang
Cc: cor...@lwn.net; Linux Media Mailing List; Libin Yang
Subject: Re
Hi Guennadi,
-Original Message-
From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
Sent: Tuesday, March 12, 2013 6:08 PM
To: Libin Yang
Cc: Albert Wang; cor...@lwn.net; Linux Media Mailing List
Subject: RE: [REVIEW PATCH V4 01/12] [media] marvell-ccic: add MIPI support for
marvell
Hi Guennadi,
Below is the update for widthy, widthuv and imgsz_w setting.
-Original Message-
From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
Sent: Wednesday, January 02, 2013 12:56 AM
To: Albert Wang
Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
Subject: Re
Hi Guennadi,
Please see my comments below.
-Original Message-
From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
Sent: Wednesday, January 02, 2013 12:56 AM
To: Albert Wang
Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
Subject: Re: [PATCH V3 06/15] [media] marvell
Hi Guennadi,
Please see my comments below.
-Original Message-
From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
Sent: Friday, January 04, 2013 6:25 PM
To: Libin Yang
Cc: Albert Wang; cor...@lwn.net; linux-media@vger.kernel.org
Subject: RE: [PATCH V3 03/15] [media] marvell-ccic
Hi Guennadi,
Thanks for your review. Please see my comments below.
-Original Message-
From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
Sent: Wednesday, January 02, 2013 12:06 AM
To: Albert Wang
Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
Subject: Re: [PATCH V3
Hi Guennadi,
When I'm refining the patch based on your comments, I met an issue. Could you
please help me?
[snip]
-
/*
* Configure the controller for operation; caller holds the
* device mutex.
@@ -979,11 +1070,32 @@ static void mcam_vb_buf_queue(struct vb2_buffer
*vb) {
Hi Guennadi,
-Original Message-
From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
Sent: Tuesday, December 04, 2012 2:57 PM
To: Libin Yang
Cc: cor...@lwn.net; linux-media@vger.kernel.org
Subject: RE: [PATCH 06/15] [media] marvell-ccic: add new formats support for
marvell-ccic
Hello Guennadi,
Thanks for your suggestion, please see my comments below.
Best Regards,
Libin
-Original Message-
From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
Sent: Tuesday, 27 November, 2012 18:50
To: Albert Wang
Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
Hello Guennadi,
Please see my comments below.
Regards,
Libin
-Original Message-
From: Albert Wang
Sent: Wednesday, November 28, 2012 12:06 AM
To: Guennadi Liakhovetski
Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
Subject: RE: [PATCH 12/15] [media] marvell-ccic: add
Hello Guennadi,
Please see my comments below.
Best Regards,
Libin
-Original Message-
From: Albert Wang
Sent: Tuesday, November 27, 2012 7:21 PM
To: Guennadi Liakhovetski
Cc: cor...@lwn.net; linux-media@vger.kernel.org; Libin Yang
Subject: RE: [PATCH 02/15] [media] marvell-ccic: add
Hi Guennadi,
-Original Message-
From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de]
Sent: Wednesday, November 28, 2012 3:14 PM
To: Libin Yang
Cc: Albert Wang; cor...@lwn.net; linux-media@vger.kernel.org
Subject: RE: [PATCH 02/15] [media] marvell-ccic: add MIPI support for
marvell
Hi Guennadi,
[snip]
[Libin] Yes, you are right. We should consider the driver may be reused.
I didn't realize it. Another question is: If we use devm_clk_get(), what
I understand, the clk will be put when the device is being released. It
means the driver will hold the clk all the time the
37 matches
Mail list logo
