Re: [GIT PULL for v4.16-rc1] media updates

On Tue, Feb 6, 2018 at 2:16 PM, Stephen Rothwell wrote: >> See: https://lkml.org/lkml/2018/1/1/547 > > Looks like you missed this when doing the merge :-( Gaah. I noticed the actual conflicts, and then didn't actually notice that there had been some other __poll_t

Re: [PATCH v2 00/19] prevent bounds-check bypass via speculative execution

On Fri, Jan 12, 2018 at 4:15 PM, Tony Luck wrote: > > Here there isn't any reason for speculation. The core has the > value of 'x' in a register and the upper bound encoded into the > "cmp" instruction. Both are right there, no waiting, no speculation. So this is an

Re: [PATCH v2 00/19] prevent bounds-check bypass via speculative execution

On Thu, Jan 11, 2018 at 4:46 PM, Dan Williams wrote: > > This series incorporates Mark Rutland's latest ARM changes and adds > the x86 specific implementation of 'ifence_array_ptr'. That ifence > based approach is provided as an opt-in fallback, but the default >

Re: Re: dvb usb issues since kernel 4.9

On Tue, Jan 9, 2018 at 9:57 AM, Eric Dumazet wrote: > > Your patch considers TASKLET_SOFTIRQ being a candidate for 'immediate > handling', but TCP Small queues heavily use TASKLET, > so as far as I am concerned a revert would have the same effect. Does it actually? TCP ends

Re: dvb usb issues since kernel 4.9

On Tue, Jan 9, 2018 at 9:42 AM, Mauro Carvalho Chehab wrote: > > On my preliminar tests, writing to a file on an ext4 partition at a > USB stick loses data up to the point to make it useless (1/4 of the data > is lost!). However, writing to a class 10 microSD card is

Re: Re: dvb usb issues since kernel 4.9

On Tue, Jan 9, 2018 at 9:27 AM, Eric Dumazet wrote: > > So yes, commit 4cd13c21b207 ("softirq: Let ksoftirqd do its job") has > shown up multiple times in various 'regressions' > simply because it could surface the problem more often. > But even if you revert it, you can

Re: dvb usb issues since kernel 4.9

On Mon, Jan 8, 2018 at 11:15 AM, Alan Stern wrote: > > Both dwc2_hsotg and ehci-hcd use the tasklets embedded in the > giveback_urb_bh member of struct usb_hcd. See usb_hcd_giveback_urb() > in drivers/usb/core/hcd.c; the calls are > > else if (high_prio_bh) >

Re: dvb usb issues since kernel 4.9

On Mon, Jan 8, 2018 at 9:55 AM, Ingo Molnar wrote: > > as I doubt we have enough time to root-case this properly. Well, it's not like this is a new issue, and we don't have to get it fixed for 4.15. It's been around since 4.9, it's not a "have to suddenly fix it this week"

Re: dvb usb issues since kernel 4.9

On Sat, Jan 6, 2018 at 11:54 AM, Mauro Carvalho Chehab wrote: > > Em Sat, 6 Jan 2018 16:04:16 +0100 > "Josef Griebichler" escreveu: >> >> the causing commit has been identified. >> After reverting commit >>

Re: [GIT PULL for v4.15-rc3] media fixes

On Fri, Dec 8, 2017 at 7:56 AM, Mauro Carvalho Chehab wrote: > > - The largest amount of fixes in this series is with regards to comments > that aren't kernel-doc, but start with "/**". A new check added for > 4.15 makes it to produce a *huge* amount of new warnings

Re: [GIT PULL for v4.15-rc1] media updates

On Wed, Nov 15, 2017 at 4:28 PM, Mauro Carvalho Chehab wrote: > > PS.: This time, there is a merge from staging tree, from the same commit > you pulled on your tree, in order to solve a conflict at the > atomisp driver, as reported by Stephen Rothwell. Please

Re: [GIT PULL for v4.14-rc6] media fixes

On Mon, Oct 16, 2017 at 4:31 PM, Mauro Carvalho Chehab wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media > media/v4.14-2 No such tag. Did you forget to push out? The latest tag I see is v4.14-1. I do see the branch (v4l_for_linus) that

Re: [PATCH 08/14] Input: adxl34x - fix gcc-7 -Wint-in-bool-context warning

On Fri, Jul 14, 2017 at 2:25 AM, Arnd Bergmann wrote: > FIFO_MODE is an macro expression with a '<<' operator, which > gcc points out could be misread as a '<': Yeah, no, NAK again. We don't make the code look worse just because gcc is being a f*cking moron about things. This

Re: [PATCH, RESEND 03/14] drm/vmwgfx: avoid gcc-7 parentheses warning

On Fri, Jul 14, 2017 at 12:21 PM, Linus Torvalds <torva...@linux-foundation.org> wrote: > > NAK. This takes unintentionally insane code and turns it intentionally > insane. Any non-zero return is considered an error. > > The right fix is almost certainly to just return -E

Re: [PATCH, RESEND 03/14] drm/vmwgfx: avoid gcc-7 parentheses warning

On Fri, Jul 14, 2017 at 2:25 AM, Arnd Bergmann wrote: > - return capable(CAP_SYS_ADMIN) ? : -EINVAL; > + return capable(CAP_SYS_ADMIN) ? 1 : -EINVAL; NAK. This takes unintentionally insane code and turns it intentionally insane. Any non-zero return is considered an

Re: Lots of new warnings with gcc-7.1.1

On Tue, Jul 11, 2017 at 8:17 PM, Linus Torvalds <torva...@linux-foundation.org> wrote: > > If that's the case, I'd prefer just turning off the format-truncation > (but not overflow) warning with '-Wno-format-trunction". Doing KBUILD_CFLAGS += $(call cc-disable-warnin

Re: Lots of new warnings with gcc-7.1.1

On Tue, Jul 11, 2017 at 8:10 PM, Guenter Roeck wrote: > > The hwmon warnings are all about supporting no more than 9,999 sensors > (applesmc) to 999,999,999 sensors (scpi) of a given type. Yeah, I think that's enough. > Easy "fix" would be to replace snprintf() with

Lots of new warnings with gcc-7.1.1

[ Very random list of maintainers and mailing lists, at least partially by number of warnings generated by gcc-7.1.1 that is then correlated with the get_maintainers script ] So I upgraded one of my boxes to F26, which upgraded the compiler to gcc-7.1.1 Which in turn means that my nice clean

Re: [WARNING: A/V UNSCANNABLE][Merge tag 'media/v4.11-1' of git] ff58d005cd: BUG: unable to handle kernel NULL pointer dereference at 0000039c

On Mon, Feb 27, 2017 at 7:41 AM, Ingo Molnar wrote: > > BTW., instead of trying to avoid the scenario, wow about moving in the other > direction: making CONFIG_DEBUG_SHIRQ=y unconditional property in the IRQ core > code > starting from v4.12 or so The problem is that it's

Re: [WARNING: A/V UNSCANNABLE][Merge tag 'media/v4.11-1' of git] ff58d005cd: BUG: unable to handle kernel NULL pointer dereference at 0000039c

On Sat, Feb 25, 2017 at 1:07 AM, Ingo Molnar wrote: > > So, should we revert the hw-retrigger change: > > a9b4f08770b4 x86/ioapic: Restore IO-APIC irq_chip retrigger callback > > ... until we managed to fix CONFIG_DEBUG_SHIRQ=y? If you'd like to revert it > upstream straight

media / serial_ir: BUG: unable to handle kernel NULL pointer dereference at 0000039c

. Linus On Fri, Feb 24, 2017 at 11:15 AM, Linus Torvalds <torva...@linux-foundation.org> wrote: > Added more relevant people. I've debugged the immediate problem below, > but I think there's another problem that actually triggered this. > > On Fri, Feb 24, 2017 at 10:28 AM,

Re: [WARNING: A/V UNSCANNABLE][Merge tag 'media/v4.11-1' of git] ff58d005cd: BUG: unable to handle kernel NULL pointer dereference at 0000039c

Added more relevant people. I've debugged the immediate problem below, but I think there's another problem that actually triggered this. On Fri, Feb 24, 2017 at 10:28 AM, kernel test robot wrote: > > 0day kernel testing robot got the below dmesg and the first bad commit

Re: [Ksummit-discuss] Including images on Sphinx documents

On Sat, Nov 19, 2016 at 12:54 PM, Mauro Carvalho Chehab wrote: > > I did some research on Friday trying to identify where those images > came. It turns that, for the oldest images (before I took the media > maintainership), PDF were actually their "source", as far as I

Re: [Ksummit-discuss] Including images on Sphinx documents

On Sat, Nov 19, 2016 at 9:55 AM, David Woodhouse wrote: > > I know it's unfashionable these days, but TeX always used to be bloody > good at that kind of thing. You must have used a different TeX than I did. TeX is a horrible example. The moment you needed to insert

Re: [Ksummit-discuss] Including images on Sphinx documents

On Thu, Nov 17, 2016 at 3:07 AM, Arnd Bergmann wrote: > > [adding Linus for clarification] > > I understood the concern as being about binary files that you cannot > modify with classic 'patch', which is a separate issue. No. That is how I *noticed* the issue. Those stupid pdf

Re: [Ksummit-discuss] Including images on Sphinx documents

On Thu, Nov 17, 2016 at 8:02 AM, Linus Torvalds <torva...@linux-foundation.org> wrote: > > No. That is how I *noticed* the issue. Those stupid pdf binary files > have been around forever, I just didn't notice until the Fedora people > started complaining about the patches. Sid

Re: [PATCH v2 00/11] getting back -Wmaybe-uninitialized

On Thu, Nov 10, 2016 at 8:44 AM, Arnd Bergmann wrote: > > Please merge these directly if you are happy with the result. I will take this. I do see two warnings, but they both seem to be valid and recent, though, so I have no issues with the spurious cases. Warning #1:

Re: [v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference

On Wed, Nov 9, 2016 at 3:09 AM, Jörg Otte wrote: > > Tried patch with no success. Again a NULL ptr dereferece. That patch was pure garbage, I think. Pretty much all the other drivers that use the same approach will have the same issue. Adding that init function just for the

Re: [v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference

On Sun, Nov 6, 2016 at 7:40 AM, Jörg Otte wrote: > Since v4.9-rc4 I get following crash in dvb-usb-cinergyT2 module. Looks like it's commit 5ef8ed0e5608f ("[media] cinergyT2-core: don't do DMA on stack"), which movced the DMA data array from the stack to the "private"

Re: [PATCH 1/1] subsystem:linux-media CVE-2016-5400

On Fri, 15 Jul 2016, James Patrick-Evans wrote: > > The memory leak is caused by the probe function of the airspy driver > mishandeling errors and not freeing the corresponding control structures when > an error occours registering the device to v4l2 core. The patch causes a warning about the

Re: [PATCH] remove lots of IS_ERR_VALUE abuses

On Fri, May 27, 2016 at 2:23 PM, Arnd Bergmann wrote: > > This patch changes all users of IS_ERR_VALUE() that I could find > on 32-bit ARM randconfig builds and x86 allmodconfig. For the > moment, this doesn't change the definition of IS_ERR_VALUE() > because there are probably

Re: [PATCH] remove lots of IS_ERR_VALUE abuses

On Fri, May 27, 2016 at 2:46 PM, Andrew Morton wrote: > > So you do plan to add some sort of typechecking into IS_ERR_VALUE()? The easiest way to do it is to just turn the (x) into (unsigned long)(void *)(x), which then complains about casting an integer to a pointer

Re: [GIT PULL for v4.6-rc1] media updates

On Wed, May 4, 2016 at 12:28 PM, Stefan Lippers-Hollmann wrote: > > --- a/drivers/media/media-device.c > +++ b/drivers/media/media-device.c > @@ -875,7 +875,7 @@ void __media_device_usb_init(struct medi > const char *board_name, >

Re: [GIT PULL for v4.6-rc1] media updates

On Tue, May 3, 2016 at 9:39 PM, Stefan Lippers-Hollmann wrote: > > Just as a cross-check, this (incomplete, but au0828, cx231xx and em28xx > aren't needed/ loaded on my system) crude revert avoids the problem for > me on v4.6-rc6-113-g83858a7. Hmm. That just open-codes

Re: [GIT PULL for v4.6-rc1] media updates

On Tue, May 3, 2016 at 2:38 PM, Stefan Lippers-Hollmann wrote: > Hi > [...] >> Mauro Carvalho Chehab (95): > [...] >> [media] use v4l2_mc_usb_media_device_init() on most USB devices > [...] > > This change, as part of v4.6-rc6-85-g1248ded, breaks two systems, each > equipped

Re: ->poll() instances shouldn't be indefinitely blocking

On Fri, Nov 27, 2015 at 7:18 AM, Mauro Carvalho Chehab wrote: > Al Viro escreveu: > >> Take a look at this: >> static unsigned int gsc_m2m_poll(struct file *file, >> struct poll_table_struct *wait) >> { >>

Re: [GIT PULL for v4.2] media fixes

On Tue, Aug 18, 2015 at 1:18 PM, Mauro Carvalho Chehab mche...@osg.samsung.com wrote: - Revert the IR encode patches, as the API is not mature enough. So, better to postpone the changes to a latter Kernel; What the hell have you done with the commit messages? The first line

Re: [PATCH 29/31] parisc: handle page-less SG entries

On Wed, Aug 12, 2015 at 12:05 AM, Christoph Hellwig h...@lst.de wrote: Make all cache invalidation conditional on sg_has_page() and use sg_phys to get the physical address directly. So this worries me a bit (I'm just reacting to one random patch in the series). The reason? I think this wants

Re: [PATCH 31/31] dma-mapping-common: skip kmemleak checks for page-less SG entries

On Wed, Aug 12, 2015 at 12:05 AM, Christoph Hellwig h...@lst.de wrote: + for_each_sg(sg, s, nents, i) { + if (sg_has_page(s)) + kmemcheck_mark_initialized(sg_virt(s), s-length); + } [ Again, I'm responding to one random patch - this pattern was

[FWD] PROBLEM: there exists a wrong return value of function mantis_dma_init()

It does seem like the error handling for mantis_dma_init() is insane.. Linus On Sun, Aug 9, 2015 at 5:12 PM, RUC_Soft_Sec zy900...@163.com wrote: Summary: there exists a wrong return value of function mantis_dma_init().It's a theoretical problem. we use static analysis

Re: [GIT PULL]: few dma-buf updates for 3.20-rc1

On Fri, Feb 20, 2015 at 8:27 AM, Sumit Semwal sumit.sem...@linaro.org wrote: Could you please pull a few dma-buf changes for 3.20-rc1? Nothing fancy, minor cleanups. No. I pulled, and immediately unpulled again. This is complete shit, and the compiler even tells you so:

Fwd: divide error: 0000 in the gspca_topro

message -- From: Peter Kovář peter.ko...@reflexion.tv Date: Sun, Feb 8, 2015 at 2:18 PM Subject: divide error: in the gspca_topro To: Linus Torvalds torva...@linux-foundation.org Hi++ Linus! There is a trivial bug in the gspca_topro webcam driver. /* set the JPEG quality for sensor

Re: [GIT PULL for v3.19-rc6] media fixes

On Sat, Jan 24, 2015 at 1:26 AM, Mauro Carvalho Chehab mche...@osg.samsung.com wrote: Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media media/v3.19-4 That does not exist. The tip of that linux-media tree does match the commit you claim is the tip but

Re: [GIT PULL for v3.17] si2165 firmware changes

Yeah, this is pure crap. It doesn't even compile. drivers/media/dvb-frontends/si2165.c:1063:17: error: expected ‘,’ or ‘;’ before ‘SI2165_FIRMWARE’ MODULE_FIRMWARE(SI2165_FIRMWARE); because it should presumably say SI2165_FIRMWARE_REV_D now. Why the f*ck do you send me totally untested

Re: [GIT PULL for v3.17-rc6] media fixes

On Sun, Sep 21, 2014 at 7:50 AM, Mauro Carvalho Chehab mche...@osg.samsung.com wrote: PS.: FYI, I'm now starting to use mche...@osg.samsung.com e-mail address. The old one (m.che...@samsung.com) is still valid, but we're using the OSG subdomain for the Samsung's Open Source Group. Thanks for

Re: [PATCH] Kernel 3.15-rc2 : Peak DVB-T USB tuner device ids for rtl28xxu driver

Brian, please use ./scripts/get_maintainer -f drivers/media/usb/dvb-usb-v2/rtl28xxu.c to get the proper people to send this to, so that it doesn't get lost in the flood in lkml. The indentation of that new entry also seems to be suspect, in that it doesn't match the ones around it. Quoting

Re: [GIT PULL for v3.15-rc1] media updates

On Thu, Apr 3, 2014 at 9:11 AM, Mauro Carvalho Chehab m.che...@samsung.com wrote: PS.: You'll find some minor conflicts between this changeset and upstream, mainly due to some code that moved from V4L2 to OF subsystem. That conflict was not at all minor, unless I were willing to do the merge

Re: [GIT PULL for v3.15-rc1] media updates

On Thu, Apr 3, 2014 at 9:11 AM, Mauro Carvalho Chehab m.che...@samsung.com wrote: Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media v4l_for_linus Oh, just noticed that this seems to be the cause of a new annoying warning:

Re: sparse and anonymous unions

On Mon, Mar 31, 2014 at 12:51 AM, Hans Verkuil hverk...@xs4all.nl wrote: Here is a simple test case for this problem: == anon-union.c == struct s { union { int val; }; }; static struct s foo = { .val = 5, }; Ok, this fixes the warning, but we

Re: sparse: ioctl defines and error: bad integer constant expression

On Mon, Mar 31, 2014 at 1:06 AM, Hans Verkuil hverk...@xs4all.nl wrote: Running sparse over this gives: error: bad integer constant expression So technically sparse is correct in this case. The kernel ends up doing some questionable things that gcc allows. The index in an assignment

Re: sparse: ARRAY_SIZE and sparse array initialization

On Sun, Mar 30, 2014 at 5:03 AM, Hans Verkuil hverk...@xs4all.nl wrote: which is clearly a sparse bug somewhere. Yes. What is going on is that we create separate symbols for each declaration, and we tie them all together (and warn if they have conflicting types). But then when we look up a

Re: sparse: ARRAY_SIZE and sparse array initialization

On Sun, Mar 30, 2014 at 9:48 AM, Linus Torvalds torva...@linux-foundation.org wrote: I'll think about how to fix it cleanly. Expect a patch shortly. Ok, patch sent to linux-sparse mailing list. It fixes the particular cut-down test-case and seems pretty simple and straightforward

Re: [GIT PULL for v3.14-rc2] media fixes

On Fri, Feb 7, 2014 at 5:57 AM, Mauro Carvalho Chehab m.che...@samsung.com wrote: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media for you to fetch changes up to 57f0547fbc1e925f5e58c76f311a6632c3f37740: Grr. You missed the branch name. I can see from the SHA1 (and

Re: [GIT PULL for v3.12-rc1] media updates

On Thu, Sep 5, 2013 at 7:24 AM, Mauro Carvalho Chehab m.che...@samsung.com wrote: Also, a trivial conflict at s5p_mfc_dec.c and s5p_mfc_enc.c will happen as a macro name got renamed from IS_MFCV6 to IS_MFCV6_PLUS. I did an ugly merge when fixing that conflict up, because the stupid code at the

Re: [REGRESSION 3.11-rc1+] wm8775 9-001b: I2C: cannot write ??? to register R??

On Sat, Aug 31, 2013 at 1:00 AM, Knut Petersen knut_peter...@t-online.de wrote: Hi Linus! It would be nice to have head cx88fix of git.linuxtv.org/hverkuil/media_tree.git (git.linuxtv.org/hverkuil/media_tree.git/commit/5dce3635bf803cfe9dde84e00f5f9594439e6c02) in 3.11 as it is a trivial and

Re: [v3.8-rc1] Multimedia regression, ioctl(17,..)-API changed ?

Jörg - does current git work for you? It has a patch from Rafael that just reverts the insane error code, and fixed something very similar for him. (I just pushed out, so it might take a few minutes to mirror out to the public sites). Linus On Sun, Dec 23, 2012 at 8:46 AM, Jörg

Re: udev breakages - was: Re: Need of an .async_probe() type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

On Wed, Oct 3, 2012 at 7:36 AM, Kay Sievers k...@vrfy.org wrote: If that unfortunate module_init() lockup can't be solved properly in the kernel Stop this idiocy. The kernel doesn't have a lockup problem. udev does. As even you admit, it is *udev* that has the whole serialization issue, and

Re: udev breakages - was: Re: Need of an .async_probe() type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

On Wed, Oct 3, 2012 at 8:13 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Yes. The issue was noticed with media drivers when people started using the drivers on Fedora 17, witch came with udev-182. There's an open bugzilla there:

Re: udev breakages - was: Re: Need of an .async_probe() type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

On Wed, Oct 3, 2012 at 9:38 AM, Linus Torvalds torva...@linux-foundation.org wrote: Anyway. Attached is a really stupid patch that tries to do the direct firmware load as suggested by Ivan. It has not been tested very extensively at all (but I did test that it loaded the brcmsmac firmware

Re: udev breakages - was: Re: Need of an .async_probe() type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

On Wed, Oct 3, 2012 at 10:09 AM, Al Viro v...@zeniv.linux.org.uk wrote: + if (!S_ISREG(inode-i_mode)) + return false; + size = i_size_read(inode); Probably better to do vfs_getattr() and check mode and size in kstat; if it's sufficiently hot for that to hurt, we

Re: udev breakages - was: Re: Need of an .async_probe() type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

On Wed, Oct 3, 2012 at 10:24 AM, Kay Sievers k...@vrfy.org wrote: Nothing really breaks, It's slow and it will surely be fixed when we know what's the right fix, which we haven't sorted out at this moment. A thirty-second pause at bootup is easily long enough that some people might think the

Re: Access files from kernel

On Wed, Oct 3, 2012 at 12:48 PM, Kirill A. Shutemov kir...@shutemov.name wrote: AFAIK, accessing files on filesystem form kernel directly was no-go for a long time. What's the new rule here? Oh, we've *always* accessed files from the kernel. What we don't want is random drivers doing so

Re: udev breakages - was: Re: Need of an .async_probe() type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

On Wed, Oct 3, 2012 at 12:50 PM, Greg KH gre...@linuxfoundation.org wrote: Ok, like this? This looks good to me. Having udev do firmware loading and tieing it to the driver model may have not been such a good idea so many years ago. Doing it this way makes more sense. Ok, I wish this had

Re: udev breakages - was: Re: Need of an .async_probe() type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

On Wed, Oct 3, 2012 at 2:58 PM, Lucas De Marchi lucas.de.mar...@gmail.com wrote: So maintaining the fallback or adding a configurable entry to set the firmware paths might be good. Yeah, I do think we need to make it configurable. Probably both at kernel compile time and dynamically. The aim

Re: udev breakages - was: Re: Need of an .async_probe() type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

On Wed, Oct 3, 2012 at 3:48 PM, Andy Walls awa...@md.metrocast.net wrote: I don't know if you can remove the /sys/.../firmware ABI altogether, because there is at least one, somewhat popular udev replacement that also uses it: mdev http://git.busybox.net/busybox/plain/docs/mdev.txt Heh.

Re: udev breakages - was: Re: Need of an .async_probe() type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

On Wed, Oct 3, 2012 at 6:33 PM, Ming Lei ming@canonical.com wrote: Yes, the patch will make firmware cache not working, I would like to fix that when I return from one trip next week. BTW, firmware cache is still needed even direct loading is taken. I agree 100%, I'd have liked to do the

Re: udev breakages - was: Re: Need of an .async_probe() type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

On Tue, Oct 2, 2012 at 6:03 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: I basically tried a few different approaches, including deferred probe(), as you suggested, and request_firmware_async(), as Kay suggested. Stop this crazy. FIX UDEV ALREADY, DAMMIT. Who maintains udev these days?

Re: udev breakages - was: Re: Need of an .async_probe() type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

On Tue, Oct 2, 2012 at 2:03 PM, Ivan Kalvachev ikalvac...@gmail.com wrote: I'm not kernel developer and probably my opinion would be a little naive, but here it is. Please, make the kernel load firmware from the filesystem on its own. We probably should do that, not just for firmware, but

Re: udev breakages - was: Re: Need of an .async_probe() type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

On Tue, Oct 2, 2012 at 3:23 PM, Greg KH gre...@linuxfoundation.org wrote: which went into udev release 187 which I think corresponds to the place when people started having problems, right Mauro? According to what I've seen, people started complaining in 182, not 187. See for example

Re: udev breakages - was: Re: Need of an .async_probe() type of callback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

On Tue, Oct 2, 2012 at 5:01 PM, Jiri Kosina jkos...@suse.cz wrote: On Tue, 2 Oct 2012, Linus Torvalds wrote: And see this email from Kay Sievers that shows that it was all known about and intentional in the udev camp: http://www.spinics.net/lists/netdev/msg185742.html This seems

Re: [GIT PULL]: dma-buf updates for 3.5

On Fri, May 25, 2012 at 2:17 AM, Sumit Semwal sumit.sem...@linaro.org wrote: I am really sorry - I goofed up in the git URL (sent the ssh URL instead). I was going to send you an acerbic email asking for your private ssh key, but then noticed that you had sent another email with the public

Re: [GIT PULL for v3.5-rc1] media updates for v3.5

Btw, I only noticed now, because I normally don't build DVB on my main machine with oldconfig - why the hell does DVB add tuners with default m? Why would *anybody* with an old config ever want to get those new drivers as modules? Get rid of all the stupid default m if DVB_FE_CUSTOMISE

Re: [GIT PULL for v3.5-rc1] media updates for v3.5

On Thu, May 24, 2012 at 3:33 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: The Kconfig default for DVB_FE_CUSTOMISE is 'n'. So, if no DVB bridge is selected, nothing will be compiled. Sadly, it looks like the default for distro kernels is 'y'. Which means that if you start with a

Re: [PATCH 1/1] drivers/media/radio: Fix build error

On Sun, Apr 1, 2012 at 10:23 AM, tdent48...@gmail.com wrote: From: Tracey tj@tj-HP-2000-Notebook-PC.(none) Please fix your git config to have proper name and email (or whatever tool you used). Your 'cc' list is similarly broken. Either selecting or depending on the

Re: Broken ioctl error returns (was Re: [PATCH 2/3] block: fail SCSI passthrough ioctls on partition devices)

On Fri, Jan 6, 2012 at 8:19 AM, Arnd Bergmann a...@arndb.de wrote: For a simpler solution, we could keep the old warning message, but change the logic from (.compat_ioctl == NULL || .compat_ioctl() == -ENOIOCTL) (no generic handler) to (.ioctl != NULL .compat_ioctl == NULL) (no

Broken ioctl error returns (was Re: [PATCH 2/3] block: fail SCSI passthrough ioctls on partition devices)

On Thu, Jan 5, 2012 at 8:16 AM, Linus Torvalds torva...@linux-foundation.org wrote: Just fix the *obvious* breakage in BLKROSET. It's clearly what the code *intends* to do, it just didn't check for ENOIOCTLCMD. So it seems from quick grepping that the block layer isn't actually all

Re: Broken ioctl error returns (was Re: [PATCH 2/3] block: fail SCSI passthrough ioctls on partition devices)

On Thu, Jan 5, 2012 at 9:02 AM, Linus Torvalds torva...@linux-foundation.org wrote: Added, linux-media and Mauro to the Cc, because I'm about to commit something like the attached patch to see if anything breaks. We may have to revert it if things get too nasty, but we should have done

Re: [PATCH] [media] v4l2 core: return -ENOIOCTLCMD if an ioctl doesn't exist

On Mon, Jun 27, 2011 at 11:04 PM, Hans Verkuil hverk...@xs4all.nl wrote: Of course, since vfs_ioctl does the same thing this is clearly isn't some isolated V4L thing. Pot. Kettle. Oh, absolutely. V4L is not at all the only confused user around. The EINVAL thing goes way back, and is a

Re: [PATCH] [media] v4l2 core: return -ENOIOCTLCMD if an ioctl doesn't exist

On Mon, Jun 27, 2011 at 10:07 AM, Hans Verkuil hverk...@xs4all.nl wrote: No, what we do is perfectly consistent: i.e. we always return EINVAL when an ioctl is not supported. That's what 'consistent' means. Whether that is the *right* error code is something else. You don't even understand the

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

On Wed, Jan 26, 2011 at 2:48 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: We should be able to handle the case where scancode is valid even though it might be unmapped yet. This is regardless of what version of EVIOCGKEYCODE we use, 1 or 2, and whether it is sparse keymap or not. Is

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

On Wed, Jan 26, 2011 at 7:01 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: BTW, another issue is that evdev's ioctl returns -EINVAL for unknown ioctls so applications would have hard time figuring out whether error returned because of kernel being too old or because they are trying to

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

On Wed, Jan 26, 2011 at 8:00 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: See, it will only look into the 16-bits scancode space. There are several remote controllers with 24 bits and 32 bits, so the tool is already broken anyway. Mauro, stop blathering. The problem is that the tool

Re: Problem with em28xx driver in Gumstix Overo

Hi Marcos, [ full email quoted for new cc's ] you really would be much better off sending a diff rather than trying to explain what changes you did, but quite frankly, even if you did that, I'd still want this to go through the actual maintainers of the em28xx driver. The USB error sounds like

Re: [GIT PULL for 2.6.36] V4L/DVB fixes

On Mon, Sep 27, 2010 at 1:57 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: The following changes since commit 32163f4b2cef28a5aab8b226ffecfc6379a53786:  alpha: fix usp value in multithreaded coredumps (2010-09-25 14:38:13 -0700) are available in the git repository at:  

Re: [PATCH] dvb-core: fix initialization of feeds list in demux filter (Was: Videotext application crashes the kernel due to DVB-demux patch)

On Mon, 8 Feb 2010, Chicken Shack wrote: This is a SCANDAL, not fun! This is SCANDALOUS! I agree that this whole thread has been totally inappropriate from beginning to end. On all sides, btw. I would suggest that somebody who can't even use his own name should be the last to complain

Re: [GIT PULL for 3.2.33] Fix regressions on dvb demux

On Mon, 8 Feb 2010, Mauro Carvalho Chehab wrote: are available in the git repository at: ssh://linuxtv.org/git/fixes.git v4l_for_linus I don't have ssh access to that thing, and git:// doesn't work. You probably meant

Re: [PATCH] dvb-core: fix initialization of feeds list in demux filter (Was: Videotext application crashes the kernel due to DVB-demux patch)

On Mon, 8 Feb 2010, Chicken Shack wrote: ... Please stop emailing me. I'm simply not interested in your political troubles with the DVB people. I see with my own eyes why people have issues with your way of communication, and quite frankly, I'm not interested in discussing name-calling

Re: [PATCH 17/21] workqueue: simple reimplementation of SINGLE_THREAD workqueue

On Tue, 17 Nov 2009, Tejun Heo wrote: Do you think that usage is wide-spread? Implementing strict ordering shouldn't be too difficult but I can't help but feeling that such assumption is abuse of implementation detail. I think it would be good if it were more than an implementation detail,

Re: [PATCH 17/21] workqueue: simple reimplementation of SINGLE_THREAD workqueue

On Wed, 18 Nov 2009, Tejun Heo wrote: I might have been too early with the 'easy' part but I definitely can give it a shot. What do you think about the scheduler notifier implementation? It seems we'll end up with three callbacks. It can either be three hlist_heads in the struct_task

Re: [GIT PATCHES for 2.6.31] V4L/DVB fixes

On Wed, 12 Aug 2009, Mauro Carvalho Chehab wrote: Please pull from: ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git for_linus Already up-to-date. Forgot to push? Linus -- To unsubscribe from this list: send the line unsubscribe

Re: [BUG] drivers/video/sis: deadlock introduced by fbdev: add mutex for fb_mmap locking

On Mon, 6 Jul 2009, Krzysztof Helt wrote: Who should I send this patch to be included as a 2.6.31 regression fix? Just send the patches to me. I've got the patch, but no changelog, and so I'd like to see them again, with changelogs and the proper Acked-by: or Tested-by lines etc.

Re: [BUG] drivers/video/sis: deadlock introduced by fbdev: add mutex for fb_mmap locking

On Mon, 6 Jul 2009, Paul Mundt wrote: Why not lock as well? I had that initially, but matroxfb will break if we do that, and presently nothing cares about trying to take -lock that early on. I really would rather have consistency than some odd rules like that. In particular - if

Re: [BUG] drivers/video/sis: deadlock introduced by fbdev: add mutex for fb_mmap locking

On Mon, 6 Jul 2009, Paul Mundt wrote: Ok, here is an updated version with an updated matroxfb and the sm501fb change reverted. Wu Zhangjin, can you also confirm that this works for you (without your patch)? Linus -- To unsubscribe from this list: send the line unsubscribe

Re: [GIT PATCHES for 2.6.30] V4L/DVB updates

On Mon, 6 Apr 2009, Mauro Carvalho Chehab wrote: Please pull from: ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git for_linus Have you rebased your tree and pushed out multiple versions of it? I'm getting very confusing things from the mirrors, which are