Re: [PATCH v4] venus: venc: Fix enum frameintervals

2019-10-17 Thread Loic Poulain
Hi Stanimir, On Thu, 17 Oct 2019 at 17:47, Stanimir Varbanov wrote: > > Hi Loic, > > On 10/17/19 6:08 PM, Loic Poulain wrote: > > Hi Stanimir, > > > > On Thu, 3 Oct 2019 at 12:15, Stanimir Varbanov > > wrote: > >> > >> I have tested thi

Re: [PATCH v4] venus: venc: Fix enum frameintervals

2019-10-17 Thread Loic Poulain
Hi Stanimir, On Thu, 3 Oct 2019 at 12:15, Stanimir Varbanov wrote: > > I have tested this on db410c with following gst pipeline: > > gst-launch-1.0 -v videotestsrc ! > video/x-raw,format=NV12,width=1280,height=960,framerate=24/1 ! > v4l2h264enc > extra-controls="controls,h264_profile=4,h264_level

[PATCH v2] media: venus: core: Fix msm8996 frequency table

2019-09-11 Thread Loic Poulain
s a higher clock than decoder. In current venus driver, the unified frequency table is aligned with the downstream decoder table which causes performance issues in encoding scenarios. Fix that by aligning frequency table on worst case (encoding). Signed-off-by: Loic Poulain --- drivers/media/platform

[PATCH] media: venus: core: Fix msm8996 frequency table

2019-09-04 Thread Loic Poulain
s a higher clock than decoder. In current venus driver, the unified frequency table is aligned with the downstream decoder table which causes performance issues in decoding scenarios. Fix that by aligning frequency table on worst case (encoding). Signed-off-by: Loic Poulain --- drivers/media/platform

Re: Issues with ov5640 sensor

2019-02-13 Thread Loic Poulain
Hi Eugen, On Wed, 13 Feb 2019 at 09:02, wrote: > > Hello Loic, > > I am trying to make sensor Omnivision ov5640 work with our Atmel-isc > controller, I saw you implemented RAW mode for this sensor in the > driver, so I was hoping I can ask you some things: > > I cannot make the RAW bayer format w

[PATCH] media: i2c: ov5640: Fix post-reset delay

2019-01-30 Thread Loic Poulain
According to the ov5640 specification (2.7 power up sequence), host can access the sensor's registers 20ms after reset. Trying to access them before leads to undefined behavior and result in sporadic initialization errors. Signed-off-by: Loic Poulain --- drivers/media/i2c/ov5640.c | 2

[PATCH] media: ov5640: Add RAW bayer format support

2018-11-02 Thread Loic Poulain
OV5640 sensor supports raw image output (bayer). Configure ISP mux/format registers accordingly. Signed-off-by: Loic Poulain --- drivers/media/i2c/ov5640.c | 58 -- 1 file changed, 46 insertions(+), 12 deletions(-) diff --git a/drivers/media/i2c

Re: [PATCH v3 1/2] media: ov5640: Re-work MIPI startup sequence

2018-09-07 Thread Loic Poulain
On 6 September 2018 at 10:48, jacopo mondi wrote: > Hello Loic, > > On Thu, Sep 06, 2018 at 10:13:53AM +0200, Loic Poulain wrote: >> On 6 September 2018 at 09:48, jacopo mondi wrote: >> > Hello Loic, >> >thanks for looking into this >> > >>

Re: [PATCH v3 1/2] media: ov5640: Re-work MIPI startup sequence

2018-09-06 Thread Loic Poulain
On 6 September 2018 at 09:48, jacopo mondi wrote: > Hello Loic, >thanks for looking into this > > On Tue, Sep 04, 2018 at 07:22:50PM +0200, Loic Poulain wrote: >> Hi Jacopo, >> >> > - ret = ov5640_mod_reg(sensor, OV5640_REG_MIPI_CTRL00, BIT(5), >>

Re: [PATCH v3 1/2] media: ov5640: Re-work MIPI startup sequence

2018-09-04 Thread Loic Poulain
Hi Jacopo, > - ret = ov5640_mod_reg(sensor, OV5640_REG_MIPI_CTRL00, BIT(5), > -on ? 0 : BIT(5)); > - if (ret) > - return ret; > - ret = ov5640_write_reg(sensor, OV5640_REG_PAD_OUTPUT00, > - on ? 0x00 : 0x70);

Re: [PATCH v3 0/2] media: i2c: ov5640: Re-work MIPI startup sequence

2018-08-28 Thread Loic Poulain
. I've just tested this with a dragonboard-410c (MICPI/CSI) + OV5640 sensor. It works on my side for 1280*720, 1920*1080 and 2592*1944 formats. Tested-by: Loic Poulain

Re: [PATCH v2 00/12] media: ov5640: Misc cleanup and improvements

2018-05-04 Thread Loic Poulain
Hi, On 3 May 2018 at 17:16, Maxime Ripard wrote: > Hi, > > On Wed, May 02, 2018 at 11:11:55AM -0700, Sam Bobrowicz wrote: >> > On Wednesday, 25 April 2018 01:11:19 EEST Sam Bobrowicz wrote: >> >> FYI, still hard at work on this. Did some more experiments last week >> >> that seemed to corroborate

Re: [PATCH v2 00/12] media: ov5640: Misc cleanup and improvements

2018-05-04 Thread Loic Poulain
Hi, > Good news, MIPI is now working on my platform. I had to make several > changes to how the mipi clocking is calculated in order to get things > stable, but I think I got it figured out. Maxime's changes were really > helpful. Great, I also try to make it work with MIPI-CSI2, If you have foun

Re: [RESEND PATCH] media: i2c: ov5640: Add pixel clock support

2018-04-24 Thread Loic Poulain
Hi Sakari, >> Any comments on this change? > > https://patchwork.linuxtv.org/project/linux-media/list/?submitter=Maxime+Ripard&state=*&q=ov5640> > > There's also another set that adds PIXEL_CLOCK (as well as LINK_FREQ) > support to the driver, that seems more complete than this patch but > require

Re: [RESEND PATCH] media: i2c: ov5640: Add pixel clock support

2018-04-24 Thread Loic Poulain
ccording to the datasheet, 96MHz can be used as a pixel clock rate for > most of the modes. > > Signed-off-by: Manivannan Sadhasivam Tested-by: Loic Poulain It works for me on Dragonboard 410c + D3 camera mezzanine (ov5640) . Any comments on this change? Regards, Loic

[PATCH 1/2] media: venus: venc: configure entropy mode

2017-11-24 Thread Loic Poulain
lways supported and so the default one. Signed-off-by: Loic Poulain --- drivers/media/platform/qcom/venus/venc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c index 6f123a3..d5d824e 100644

[PATCH 2/2] media: venus: venc: Apply inloop deblocking filter

2017-11-24 Thread Loic Poulain
Deblocking filter allows to reduce blocking artifacts and improve visual quality. This is configurable via the V4L2 API but eventually not applied to the encoder. Note that alpha and beta deblocking values are 32-bit signed (-6;+6). Signed-off-by: Loic Poulain --- drivers/media/platform/qcom