Re: [PATCH RFC] DT support for omap4-iss

2019-10-07 Thread Michael Allwright
On Mon, 7 Oct 2019 at 18:34, Tony Lindgren wrote: > > Hi, > > * Sakari Ailus [190628 11:05]: > > Hi Michael, > > > > On Mon, Aug 10, 2015 at 05:16:30PM +0200, Michael Allwright wrote: > > > Hi All, > > > > > > The following PRELIMINARY pa

Re: [ANN] Topics for a media summit in Lyon in October

2019-09-12 Thread Michael Tretter
Mondi > Laurent Pinchart > Hans Verkuil > > If you are not on this list, but want to join, please let me know. I would like to attend the meeting about codec support. Michael

[PATCH v2 2/2] media: v4l2-mem2mem: reorder checks in v4l2_m2m_poll()

2019-06-27 Thread Michael Tretter
events. This ensures that if vb2_m2m_poll() signals POLLIN | POLLRDNORM for the V4L2_BUF_FLAG_LAST buffer, it signals POLLPRI for the V4L2_EOS_EVENT, too. Signed-off-by: Michael Tretter --- v1 -> v2: - rename __v4l2_m2m_poll() to v4l2_m2m_poll_for_data() --- drivers/media/v4l2-core/v4l2-mem2me

[PATCH v2 1/2] media: vb2: reorder checks in vb2_poll()

2019-06-27 Thread Michael Tretter
vb2_poll() signals POLLIN | POLLRDNORM for the V4L2_BUF_FLAG_LAST buffer, it also signals POLLPRI for the V4L2_EOS_EVENT. Signed-off-by: Michael Tretter --- v1 -> v2: - none --- drivers/media/common/videobuf2/videobuf2-v4l2.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --gi

[PATCH v2 0/2] vb2: check for events before checking for buffers

2019-06-27 Thread Michael Tretter
event between the checks and thus only signal the buffer without the event. Reordering the checks avoids the race condition. As suggested by Hans, I renamed __v4l2_m2m_poll() to v4l2_m2m_poll_for_data() in patch 2/2. Michael Changelog: v1 -> v2: - rename __v4l2_m2m_poll()

Re: [PATCH 2/2] media: v4l2-mem2mem: reorder checks in v4l2_m2m_poll()

2019-06-27 Thread Michael Tretter
On Wed, 26 Jun 2019 13:44:23 +0200, Hans Verkuil wrote: > On 6/25/19 4:11 PM, Michael Tretter wrote: > > When reaching the end of stream, V4L2 m2m clients may expect the > > V4L2_EOS_EVENT. Although the V4L2_EOS_EVENT is deprecated behavior, > > drivers must signal that e

[PATCH] media: allegro: use new v4l2_m2m_ioctl_try_encoder_cmd funcs

2019-06-25 Thread Michael Tretter
As the try_encoder_cmd is identical for many drivers, there are now helpers for this function in the mem2mem core. Use the helper in allegro. This fixes the v4l2-compliance test regarding V4L2_ENC_CMD_STOP, because the allegro-specific function rejected invalid flags. Signed-off-by: Michael

[PATCH 1/2] media: vb2: reorder checks in vb2_poll()

2019-06-25 Thread Michael Tretter
vb2_poll() signals POLLIN | POLLRDNORM for the V4L2_BUF_FLAG_LAST buffer, it also signals POLLPRI for the V4L2_EOS_EVENT. Signed-off-by: Michael Tretter --- drivers/media/common/videobuf2/videobuf2-v4l2.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/media/common

[PATCH 0/2] vb2: check for events before checking for buffers

2019-06-25 Thread Michael Tretter
event between the checks and thus only signal the buffer without the event. Reordering the checks avoids the race condition. I discovered this issue in the allegro-dvt driver [0]. Michael [0] https://lore.kernel.org/linux-media/20190527154557.62278...@litschi.hi.pengutronix.de/ Michael Tretter

[PATCH 2/2] media: v4l2-mem2mem: reorder checks in v4l2_m2m_poll()

2019-06-25 Thread Michael Tretter
events. This ensures that if vb2_m2m_poll() signals POLLIN | POLLRDNORM for the V4L2_BUF_FLAG_LAST buffer, it signals POLLPRI for the V4L2_EOS_EVENT, too. Signed-off-by: Michael Tretter --- drivers/media/v4l2-core/v4l2-mem2mem.c | 47 +++--- 1 file changed, 27 insertions(+), 20

Re: [PATCH] allegro-dvt: fix build failure

2019-05-29 Thread Michael Tretter
4.c:24:10: fatal error: nal-h264.h: > No such file or directory > #include > ^~~~ > > Signed-off-by: Hans Verkuil Reviewed-by: Michael Tretter > --- > diff --git a/drivers/staging/media/allegro-dvt/nal-h264.c > b/drivers/staging/media/allegro-dvt/na

Re: [PATCH] media: cxusb-analog: Fix some coding style issues

2019-05-28 Thread Michael Ira Krufky
Hey, so the analog support is merged? Great news! I believe that you may have missed curly brackets, `{` , `}` in the following hunks: @@ -763,7 +764,7 @@ static int cxusb_medion_v_ss_auxbuf_alloc(struct cxusb_medion_dev *cxdev, auxbuflen = framelen + urblen; buf = vmalloc(auxb

[PATCH v8 2/5] media: dt-bindings: media: document allegro-dvt bindings

2019-05-28 Thread Michael Tretter
Add device-tree bindings for the Allegro DVT video IP core found on the Xilinx ZynqMP EV family. Signed-off-by: Michael Tretter Reviewed-by: Rob Herring --- v7 -> v8: none v6 -> v7: none v5 -> v6: none v4 -> v5: none v3 -> v4: none v2 -> v3: - rename node to video-code

[PATCH v8 5/5] [media] allegro: add SPS/PPS nal unit writer

2019-05-28 Thread Michael Tretter
. The allegro driver writes the nal units into the v4l2 capture buffer in front of the actual video data which is written at an offset by the IP core. The remaining gap is filled with a filler nal unit. Signed-off-by: Michael Tretter --- v7 -> v8: - add documentation for @dev v6 -> v7: - move

[PATCH v8 0/5] Add ZynqMP VCU/Allegro DVT H.264 encoder driver

2019-05-28 Thread Michael Tretter
Video Capture: Captured 60 buffers test MMAP (select): OK Video Capture: Captured 60 buffers test MMAP (epoll): OK test USERPTR (select): OK (Not Supported) test DMABUF: Cannot test, specify --expbuf-device Total for alle

[PATCH v8 4/5] [media] allegro: add Allegro DVT video IP core driver

2019-05-28 Thread Michael Tretter
-by: Michael Tretter --- v7 -> v8: - fix smatch warning about type of 0x v6 -> v7: - move driver back into staging - add TODO file - remove unused allegro_state_get_name() v5 -> v6: - drop selection api and document visual size - drop references to the video decoder - f

[PATCH v8 1/5] videobuf2-v4l2: set last_buffer_dequeued in dqbuf

2019-05-28 Thread Michael Tretter
From: Hans Verkuil last_buffer_dequeued was set to true in __fill_v4l2_buffer, but this is called for qbuf as well. Move it to vb2_dqbuf. Signed-off-by: Hans Verkuil --- drivers/media/common/videobuf2/videobuf2-v4l2.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v8 3/5] media: dt-bindings: media: Add vendor prefix for allegro

2019-05-28 Thread Michael Tretter
Add vendor prefix for Allegro DVT, a provider of H.264/AVC, H.265/HEVC, AVS2, VP9 and AV1 compliance test suites and H.264/AVC, H.265/HEVC, and VP9 encoder, codec and decoder hardware (RTL) IPs. Signed-off-by: Michael Tretter Reviewed-by: Rob Herring --- v7 -> v8: none v6 -> v7: - conv

Re: [PATCH v7 0/5] Add ZynqMP VCU/Allegro DVT H.264 encoder driver

2019-05-28 Thread Michael Tretter
On Tue, 28 May 2019 15:54:58 +0200, Hans Verkuil wrote: > Hi Michael, > > On 5/28/19 3:09 PM, Michael Tretter wrote: > > This is v7 of the Allegro DVT H.264 encoder driver found in the EV > > family of the Xilinx ZynqMP platform. > > > > I moved the driver

[PATCH v7 0/5] Add ZynqMP VCU/Allegro DVT H.264 encoder driver

2019-05-28 Thread Michael Tretter
, Warnings: 0 Michael v6 -> v7: - move driver back into staging - convert to json format for vendor-prefixes.yaml - remove unused allegro_state_get_name() v5 -> v6: - drop selection api and document visual size - drop references to the video decoder - fix sparse warnings regarding non-

[PATCH v7 5/5] [media] allegro: add SPS/PPS nal unit writer

2019-05-28 Thread Michael Tretter
. The allegro driver writes the nal units into the v4l2 capture buffer in front of the actual video data which is written at an offset by the IP core. The remaining gap is filled with a filler nal unit. Signed-off-by: Michael Tretter --- v6 -> v7: - move driver back into staging v5 -> v6:

[PATCH v7 1/5] videobuf2-v4l2: set last_buffer_dequeued in dqbuf

2019-05-28 Thread Michael Tretter
From: Hans Verkuil last_buffer_dequeued was set to true in __fill_v4l2_buffer, but this is called for qbuf as well. Move it to vb2_dqbuf. Signed-off-by: Hans Verkuil --- drivers/media/common/videobuf2/videobuf2-v4l2.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v7 2/5] media: dt-bindings: media: document allegro-dvt bindings

2019-05-28 Thread Michael Tretter
Add device-tree bindings for the Allegro DVT video IP core found on the Xilinx ZynqMP EV family. Signed-off-by: Michael Tretter Reviewed-by: Rob Herring --- v6 -> v7: none v5 -> v6: none v4 -> v5: none v3 -> v4: none v2 -> v3: - rename node to video-codec - drop interr

[PATCH v7 4/5] [media] allegro: add Allegro DVT video IP core driver

2019-05-28 Thread Michael Tretter
-by: Michael Tretter --- v6 -> v7: - move driver back into staging - add TODO file - remove unused allegro_state_get_name() v5 -> v6: - drop selection api and document visual size - drop references to the video decoder - fix sparse warnings regarding non-static functions v4 -> v5: - mo

[PATCH v7 3/5] media: dt-bindings: media: Add vendor prefix for allegro

2019-05-28 Thread Michael Tretter
Add vendor prefix for Allegro DVT, a provider of H.264/AVC, H.265/HEVC, AVS2, VP9 and AV1 compliance test suites and H.264/AVC, H.265/HEVC, and VP9 encoder, codec and decoder hardware (RTL) IPs. Signed-off-by: Michael Tretter Reviewed-by: Rob Herring --- v6 -> v7: - convert to json format

Re: [PATCH v6 3/5] media: dt-bindings: media: Add vendor prefix for allegro

2019-05-27 Thread Michael Tretter
On Mon, 27 May 2019 16:35:24 +0200, Hans Verkuil wrote: > This patch no longer applies (vendor-prefixes.txt is now > vendor-prefixes.yaml). > Can you rebase this patch? Should I rebase the entire series and send a v7 or is it enough to rebase only this patch? Michael >

Re: [PATCH v6 0/5] Add ZynqMP VCU/Allegro DVT H.264 encoder driver

2019-05-27 Thread Michael Tretter
On Wed, 22 May 2019 15:49:45 +0200, Michael Tretter wrote: > On Wed, 22 May 2019 14:04:23 +0200, Hans Verkuil wrote: > > On 5/13/19 7:21 PM, Michael Tretter wrote: > > > This is v6 of the Allegro DVT H.264 encoder driver found in the EV > > > family of

Re: [PATCH v6 0/5] Add ZynqMP VCU/Allegro DVT H.264 encoder driver

2019-05-22 Thread Michael Tretter
On Wed, 22 May 2019 14:04:23 +0200, Hans Verkuil wrote: > On 5/13/19 7:21 PM, Michael Tretter wrote: > > This is v6 of the Allegro DVT H.264 encoder driver found in the EV > > family of the Xilinx ZynqMP platform. > > > > Only minor changes this time. I droppe

[PATCH v6 0/5] Add ZynqMP VCU/Allegro DVT H.264 encoder driver

2019-05-13 Thread Michael Tretter
nd the series anyway. Michael v5 -> v6: - drop selection api and document visual size - drop references to the video decoder - fix sparse warnings regarding non-static functions - fix return type of rbsp_read_bit v4 -> v5: - add patch for allegro vendor prefix - move driver out of staging

[PATCH v6 1/5] videobuf2-v4l2: set last_buffer_dequeued in dqbuf

2019-05-13 Thread Michael Tretter
From: Hans Verkuil last_buffer_dequeued was set to true in __fill_v4l2_buffer, but this is called for qbuf as well. Move it to vb2_dqbuf. Signed-off-by: Hans Verkuil --- drivers/media/common/videobuf2/videobuf2-v4l2.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v6 2/5] media: dt-bindings: media: document allegro-dvt bindings

2019-05-13 Thread Michael Tretter
Add device-tree bindings for the Allegro DVT video IP core found on the Xilinx ZynqMP EV family. Signed-off-by: Michael Tretter Reviewed-by: Rob Herring --- v5 -> v6: none v4 -> v5: none v3 -> v4: none v2 -> v3: - rename node to video-codec - drop interrupt-names - fix compatibl

[PATCH v6 5/5] [media] allegro: add SPS/PPS nal unit writer

2019-05-13 Thread Michael Tretter
. The allegro driver writes the nal units into the v4l2 capture buffer in front of the actual video data which is written at an offset by the IP core. The remaining gap is filled with a filler nal unit. Signed-off-by: Michael Tretter --- v5 -> v6: - fix sparse warnings regarding non-static functi

[PATCH v6 4/5] [media] allegro: add Allegro DVT video IP core driver

2019-05-13 Thread Michael Tretter
-by: Michael Tretter --- v5 -> v6: - drop selection api and document visual size - drop references to the video decoder - fix sparse warnings regarding non-static functions v4 -> v5: - move out of staging - select VIDEOBUF2_DMA_CONTIG - implement enum_framesizes - drop check in queue_setup -

[PATCH v6 3/5] media: dt-bindings: media: Add vendor prefix for allegro

2019-05-13 Thread Michael Tretter
Add vendor prefix for Allegro DVT, a provider of H.264/AVC, H.265/HEVC, AVS2, VP9 and AV1 compliance test suites and H.264/AVC, H.265/HEVC, and VP9 encoder, codec and decoder hardware (RTL) IPs. Signed-off-by: Michael Tretter Reviewed-by: Rob Herring --- v5 -> v6: none v5: - new pa

Re: [PATCH v5 4/5] [media] allegro: add Allegro DVT video IP core driver

2019-05-10 Thread Michael Tretter
On Fri, 10 May 2019 16:11:54 +0200, Hans Verkuil wrote: > On 5/10/19 3:52 PM, Michael Tretter wrote: > > On Fri, 10 May 2019 12:58:43 +0200, Hans Verkuil wrote: > >> On 5/10/19 12:28 PM, Michael Tretter wrote: > >>> On Fri, 10 May 2019 10:28:53 +0200, Hans Verkuil

Re: [PATCH v5 4/5] [media] allegro: add Allegro DVT video IP core driver

2019-05-10 Thread Michael Tretter
On Fri, 10 May 2019 12:58:43 +0200, Hans Verkuil wrote: > On 5/10/19 12:28 PM, Michael Tretter wrote: > > On Fri, 10 May 2019 10:28:53 +0200, Hans Verkuil wrote: > >> On 5/3/19 2:20 PM, Michael Tretter wrote: > >>> Add a V4L2 mem-to-mem driver for Allegro

Re: [PATCH v5 4/5] [media] allegro: add Allegro DVT video IP core driver

2019-05-10 Thread Michael Tretter
On Fri, 10 May 2019 10:28:53 +0200, Hans Verkuil wrote: > On 5/3/19 2:20 PM, Michael Tretter wrote: > > Add a V4L2 mem-to-mem driver for Allegro DVT video IP cores as found in > > the EV family of the Xilinx ZynqMP SoC. The Zynq UltraScale+ Device > > Technical Reference Man

[PATCH v5 5/5] [media] allegro: add SPS/PPS nal unit writer

2019-05-03 Thread Michael Tretter
. The allegro driver writes the nal units into the v4l2 capture buffer in front of the actual video data which is written at an offset by the IP core. The remaining gap is filled with a filler nal unit. Signed-off-by: Michael Tretter --- v4 -> v5: - completely rework implementation - move out

[PATCH v5 4/5] [media] allegro: add Allegro DVT video IP core driver

2019-05-03 Thread Michael Tretter
-by: Michael Tretter --- v4 -> v5: - move out of staging - select VIDEOBUF2_DMA_CONTIG - implement enum_framesizes - drop check in queue_setup - rework busy handling of ctrl handler - add ctrl V4L2_CID_MIN_BUFFERS_FOR_OUTPUT - use ctrl names in logging - implement g_selection - use unsigned types

[PATCH v5 1/5] videobuf2-v4l2: set last_buffer_dequeued in dqbuf

2019-05-03 Thread Michael Tretter
From: Hans Verkuil last_buffer_dequeued was set to true in __fill_v4l2_buffer, but this is called for qbuf as well. Move it to vb2_dqbuf. Signed-off-by: Hans Verkuil --- drivers/media/common/videobuf2/videobuf2-v4l2.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v5 2/5] media: dt-bindings: media: document allegro-dvt bindings

2019-05-03 Thread Michael Tretter
Add device-tree bindings for the Allegro DVT video IP core found on the Xilinx ZynqMP EV family. Signed-off-by: Michael Tretter Reviewed-by: Rob Herring --- v4 -> v5: none v3 -> v4: none v2 -> v3: - rename node to video-codec - drop interrupt-names - fix compatible in example - add

[PATCH v5 3/5] media: dt-bindings: media: Add vendor prefix for allegro

2019-05-03 Thread Michael Tretter
Add vendor prefix for Allegro DVT, a provider of H.264/AVC, H.265/HEVC, AVS2, VP9 and AV1 compliance test suites and H.264/AVC, H.265/HEVC, and VP9 encoder, codec and decoder hardware (RTL) IPs. Signed-off-by: Michael Tretter --- v5: - new patch --- Documentation/devicetree/bindings/vendor

[PATCH v5 0/5] Add ZynqMP VCU/Allegro DVT H.264 encoder driver

2019-05-03 Thread Michael Tretter
eeded: 49, Failed: 0, Warnings: 0 A more detailed changelog is attached to each patch. Michael v4 -> v5: - add patch for allegro vendor prefix - move driver out of staging - implement draining with CMD_STOP and CMD_START - rewrite NAL unit RBSP generator v3 -> v4: - fix checkpatch a

Re: Xilinx/Allegro DVT VCU firmware

2019-04-16 Thread Michael Tretter
Hi Varunkumar, On Thu, 28 Mar 2019 11:32:45 +0100, Michael Tretter wrote: > Hi Varunkumar, > > I am working on a mainline driver [0] for the VCU/video-codec that is > found on the Xilinx ZynqMP. The driver depends on a firmware for the > video codec [1], which is the same firmwa

Xilinx/Allegro DVT VCU firmware

2019-03-28 Thread Michael Tretter
myself, but having this done by someone from Xilinx would be much better. Michael [0] https://www.mail-archive.com/linux-media@vger.kernel.org/msg145294.html [1] https://github.com/Xilinx/vcu-firmware

Re: [PATCH v4 2/3] [media] allegro: add Allegro DVT video IP core driver

2019-03-28 Thread Michael Tretter
On Wed, 27 Mar 2019 14:33:40 +0100, Hans Verkuil wrote: > On 3/1/19 4:27 PM, Michael Tretter wrote: > > Add a V4L2 mem-to-mem driver for Allegro DVT video IP cores as found in > > the EV family of the Xilinx ZynqMP SoC. The Zynq UltraScale+ Device > > Technical Reference Man

Re: [PATCH v4 3/3] [media] allegro: add SPS/PPS nal unit writer

2019-03-28 Thread Michael Tretter
On Wed, 27 Mar 2019 14:45:04 +0100, Hans Verkuil wrote: > On 3/1/19 4:27 PM, Michael Tretter wrote: > > The allegro hardware encoder does not write SPS/PPS nal units into the > > encoded video stream. Therefore, we need to write the units in software. > > > > The implem

Re: [PATCH v4 1/3] media: dt-bindings: media: document allegro-dvt bindings

2019-03-28 Thread Michael Tretter
On Wed, 27 Mar 2019 13:57:10 +0100, Hans Verkuil wrote: > On 3/1/19 4:27 PM, Michael Tretter wrote: > > Add device-tree bindings for the Allegro DVT video IP core found on the > > Xilinx ZynqMP EV family. > > > > Signed-off-by: Michael Tretter > > Reviewed-by:

Re: [PATCH v4 0/3] Add ZynqMP VCU/Allegro DVT H.264 encoder driver

2019-03-26 Thread Michael Tretter
On Fri, 01 Mar 2019 16:27:15 +0100, Michael Tretter wrote: > This is v4 of the series to add support for the Allegro DVT H.264 encoder > found in the EV family of the Xilinx ZynqMP platform. Ping. Michael > > The most prominent change is the added documentation in the nal_h264.h h

[PATCH v4 3/3] [media] allegro: add SPS/PPS nal unit writer

2019-03-01 Thread Michael Tretter
. The allegro driver writes the nal units into the v4l2 capture buffer in front of the actual video data which is written at an offset by the IP core. The remaining gap is filled with a filler nal unit. Signed-off-by: Michael Tretter --- v3 -> v4: fix compiler warnings regarding printing size_t

[PATCH v4 1/3] media: dt-bindings: media: document allegro-dvt bindings

2019-03-01 Thread Michael Tretter
Add device-tree bindings for the Allegro DVT video IP core found on the Xilinx ZynqMP EV family. Signed-off-by: Michael Tretter Reviewed-by: Rob Herring --- v3 -> v4: none v2 -> v3: - rename node to video-codec - drop interrupt-names - fix compatible in example - add clocks to re

[PATCH v4 2/3] [media] allegro: add Allegro DVT video IP core driver

2019-03-01 Thread Michael Tretter
-by: Michael Tretter --- v3 -> v4: - fix checkpatch warnings - fix compiler warnings regarding printing size_t - use v4l2_m2m_buf_copy_metadata to copy buffer metadata - resolve FIXME regarding channel creation and streamon - resolve various TODOs - add mailbox format to firmware info -

[PATCH v4 0/3] Add ZynqMP VCU/Allegro DVT H.264 encoder driver

2019-03-01 Thread Michael Tretter
more detailed changelog is attached to each patch. Michael v3 -> v4: - fix checkpatch and compiler warnings - use v4l2_m2m_buf_copy_metadata to copy buffer metadata - resolve FIXME regarding channel creation and streamon - resolve various TODOs - add mailbox format to firmware info -

Re: [PATCH v3 0/3] Add ZynqMP VCU/Allegro DVT H.264 encoder driver

2019-02-13 Thread Michael Tretter
On Wed, 13 Feb 2019 18:51:21 +0100, Michael Tretter wrote: > This is v3 of the series to add support for the Allegro DVT H.264 encoder > found in the EV family of the Xilinx ZynqMP platform. > > The devicetree bindings now also include the clocks as documented in PG252 > "H.2

[PATCH v3 3/3] [media] allegro: add SPS/PPS nal unit writer

2019-02-13 Thread Michael Tretter
. The allegro driver writes the nal units into the v4l2 capture buffer in front of the actual video data which is written at an offset by the IP core. The remaining gap is filled with a filler nal unit. Signed-off-by: Michael Tretter --- v2 -> v3: none v1 -> v2: - clean up debug log levels

[PATCH v3 2/3] [media] allegro: add Allegro DVT video IP core driver

2019-02-13 Thread Michael Tretter
-by: Michael Tretter --- v2 -> v3: - drop poison_capture_buffers - cleanup allegro_queue_setup - add missing allegro_queue_ops - set device caps on video device - cleanup allegro_ioctl_ops - add missing allegro_ioctl_ops - drop unnecessary v4l2_disable_ioctl - drop unnecessary allegro_job_abort

[PATCH v3 1/3] media: dt-bindings: media: document allegro-dvt bindings

2019-02-13 Thread Michael Tretter
Add device-tree bindings for the Allegro DVT video IP core found on the Xilinx ZynqMP EV family. Signed-off-by: Michael Tretter --- v2 -> v3: - rename node to video-codec - drop interrupt-names - fix compatible in example - add clocks to required properties v1 -> v2: none --- .../devi

[PATCH v3 0/3] Add ZynqMP VCU/Allegro DVT H.264 encoder driver

2019-02-13 Thread Michael Tretter
nal to the driver and can be done later anyway. Each patch also contains a more detailed changelog. Michael [0] https://www.xilinx.com/support/documentation/ip_documentation/vcu/v1_2/pg252-vcu.pdf v2 -> v3: - add clocks to devicetree bindings - fix devicetree binding according to review comment

Re: [PATCH v2 2/3] [media] allegro: add Allegro DVT video IP core driver

2019-01-30 Thread Michael Tretter
e uses a ring buffer. With high bitrate stream, the overhead is > important. It also breaks the usage of hardware synchronization IP, > which is a key feature on the ZynqMP. I am a little bit confused about your use case. In transcoding cases there is decoder -> encoder, i.e., the decoder comes f

Re: [PATCH v2 2/3] [media] allegro: add Allegro DVT video IP core driver

2019-01-30 Thread Michael Tretter
On Tue, 29 Jan 2019 22:46:15 -0500, Nicolas Dufresne wrote: > Le mercredi 23 janvier 2019 à 15:17 +0100, Michael Tretter a écrit : > > > I have a patch pending that allows an encoder to spread the compressed > > > output over multiple buffers: > > > > > > ht

Re: [PATCH v2 2/3] [media] allegro: add Allegro DVT video IP core driver

2019-01-23 Thread Michael Tretter
Hi Hans, On Wed, 23 Jan 2019 11:44:05 +0100, Hans Verkuil wrote: > Hi Michael, > > Review comments follow: > > On 01/18/19 14:37, Michael Tretter wrote: > > Add a V4L2 mem-to-mem driver for Allegro DVT video IP cores as found in > > the EV family of the Xilinx Zynq

Re: [PATCH v2 1/3] media: dt-bindings: media: document allegro-dvt bindings

2019-01-22 Thread Michael Tretter
On Mon, 21 Jan 2019 11:13:48 -0600, Rob Herring wrote: > On Fri, Jan 18, 2019 at 02:37:14PM +0100, Michael Tretter wrote: > > Add device-tree bindings for the Allegro DVT video IP core found on the > > Xilinx ZynqMP EV family. > > > > Signed-off-by: Michael Tretter &

Re: [PATCH v2 1/3] media: dt-bindings: media: document allegro-dvt bindings

2019-01-21 Thread Michael Tretter
On Mon, 21 Jan 2019 11:17:43 -0500, Nicolas Dufresne wrote: > Le lundi 21 janvier 2019 à 11:59 +0100, Philipp Zabel a écrit : > > On Fri, 2019-01-18 at 14:37 +0100, Michael Tretter wrote: > > > Add device-tree bindings for the Allegro DVT video IP core found on the > > &

Re: [PATCH v2 0/3] Add ZynqMP VCU/Allegro DVT H.264 encoder driver

2019-01-21 Thread Michael Tretter
Hi Hans, On Fri, 18 Jan 2019 15:11:32 +0100, Hans Verkuil wrote: > Hi Michael, > > On 1/18/19 2:37 PM, Michael Tretter wrote: > > This is v2 of the series to add support for the Allegro DVT H.264 encoder > > found in the EV family of the Xilinx ZynqMP platform. > >

[PATCH v2 3/3] [media] allegro: add SPS/PPS nal unit writer

2019-01-18 Thread Michael Tretter
. The allegro driver writes the nal units into the v4l2 capture buffer in front of the actual video data which is written at an offset by the IP core. The remaining gap is filled with a filler nal unit. Signed-off-by: Michael Tretter --- Changes since v1: - clean up debug log levels - fix missing

[PATCH v2 0/3] Add ZynqMP VCU/Allegro DVT H.264 encoder driver

2019-01-18 Thread Michael Tretter
the messages themselves. I also did not address the integration with the xlnx-vcu driver, yet. Michael [0] https://lore.kernel.org/linux-media/20190109113037.28430-1-m.tret...@pengutronix.de/ Changes since v1: - clean up debug log levels - fix unused variable in allegro_mbox_init - fix

[PATCH v2 1/3] media: dt-bindings: media: document allegro-dvt bindings

2019-01-18 Thread Michael Tretter
Add device-tree bindings for the Allegro DVT video IP core found on the Xilinx ZynqMP EV family. Signed-off-by: Michael Tretter --- Changes since v1: none --- .../devicetree/bindings/media/allegro.txt | 35 +++ 1 file changed, 35 insertions(+) create mode 100644

[PATCH v2 2/3] [media] allegro: add Allegro DVT video IP core driver

2019-01-18 Thread Michael Tretter
-by: Michael Tretter --- Changes since v1: - clean up debug log levels - fix unused variable in allegro_mbox_init - fix uninitialized variable in allegro_mbox_write - fix global module parameters - fix Kconfig dependencies - return h264 as default codec for mcu - implement device reset as documented

[PATCH 1/3] media: dt-bindings: media: document allegro-dvt bindings

2019-01-09 Thread Michael Tretter
Add device-tree bindings for the Allegro DVT video IP core found on the Xilinx ZynqMP EV family. Signed-off-by: Michael Tretter --- .../devicetree/bindings/media/allegro.txt | 35 +++ 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH 0/3] Add ZynqMP VCU/Allegro DVT H.264 encoder driver

2019-01-09 Thread Michael Tretter
to configure the clocks. I ran v4l2-compliance without failures on the driver, but I think adding the test results right now only distracts from more important open issues in the driver. Michael [0] https://github.com/Xilinx/vcu-firmware/tree/xilinx-v2018.2 Michael Tretter (3): media: dt

[PATCH 2/3] [media] allegro: add Allegro DVT video IP core driver

2019-01-09 Thread Michael Tretter
-by: Michael Tretter --- MAINTAINERS |6 + drivers/staging/media/Kconfig |2 + drivers/staging/media/Makefile|1 + drivers/staging/media/allegro-dvt/Kconfig |6 + drivers/staging/media/allegro-dvt/Makefile

[PATCH 3/3] [media] allegro: add SPS/PPS nal unit writer

2019-01-09 Thread Michael Tretter
. The allegro driver writes the nal units into the v4l2 capture buffer in front of the actual video data which is written at an offset by the IP core. The remaining gap is filled with a filler nal unit. Signed-off-by: Michael Tretter --- drivers/staging/media/allegro-dvt/Makefile|4

Re: [PATCH] usb: dvb: check status of mxl111sf_read_reg

2018-12-26 Thread Michael Ira Krufky
Kangjie, On Wed, Dec 26, 2018 at 12:59 AM Kangjie Lu wrote: > > When mxl111sf_read_reg fails, we shouldn't use "mode". The fix checks > its return value using mxl_fail > > Signed-off-by: Kangjie Lu > --- > drivers/media/usb/dvb-usb-v2/mxl111sf-phy.c | 3 ++- > 1 file changed, 2 insertions(+), 1

Re: [PATCH v4 0/6] media/sun6i: Allwinner A64 CSI support

2018-12-19 Thread Michael Nazzareno Trimarchi
ple, we have a full working platform with ov5640 that support all the resolutions, that can be test by anyone and we have an industrial product that has some problem on high xvclk because it can not give us a clear image but this is limited on another design and another camera module vendor. Problem is n

Re: Configure video PAL decoder into media pipeline

2018-12-12 Thread Michael Nazzareno Trimarchi
Hi On Wed, Dec 12, 2018 at 9:55 AM jacopo mondi wrote: > > On Wed, Dec 12, 2018 at 09:43:23AM +0100, Michael Nazzareno Trimarchi wrote: > > Hi > > > > On Wed, Dec 12, 2018 at 9:39 AM jacopo mondi wrote: > > > > > > Hi Michael, > > > >

Re: Configure video PAL decoder into media pipeline

2018-12-12 Thread Michael Nazzareno Trimarchi
Hi On Wed, Dec 12, 2018 at 9:39 AM jacopo mondi wrote: > > Hi Michael, > > On Tue, Dec 11, 2018 at 02:53:24PM +0100, Michael Nazzareno Trimarchi wrote: > > Hi Jacopo > > > > On Tue, Dec 11, 2018 at 12:39 PM jacopo mondi wrote: > > > > > > Hi Mi

Re: Configure video PAL decoder into media pipeline

2018-12-11 Thread Michael Nazzareno Trimarchi
Hi Jacopo On Tue, Dec 11, 2018 at 12:39 PM jacopo mondi wrote: > > Hi Michael, > > On Mon, Dec 10, 2018 at 10:45:02PM +0100, Michael Nazzareno Trimarchi wrote: > > Hi Jacopo > > > > Let's see what I have done > > > > On Sun, Dec 9, 2018 at 8:39

Re: Configure video PAL decoder into media pipeline

2018-12-10 Thread Michael Nazzareno Trimarchi
Hi Jacopo Let's see what I have done On Sun, Dec 9, 2018 at 8:39 PM jacopo mondi wrote: > > Hi Michael, Jagan, Hans, > > On Sat, Dec 08, 2018 at 06:07:04PM +0100, Michael Nazzareno Trimarchi wrote: > > Hi > > > > Down you have my tentative of connection &

Re: Configure video PAL decoder into media pipeline

2018-12-09 Thread Michael Nazzareno Trimarchi
Hi On Sun, Dec 9, 2018 at 8:39 PM jacopo mondi wrote: > > Hi Michael, Jagan, Hans, > > On Sat, Dec 08, 2018 at 06:07:04PM +0100, Michael Nazzareno Trimarchi wrote: > > Hi > > > > Down you have my tentative of connection > > > > I need to hack a bit to

Re: Configure video PAL decoder into media pipeline

2018-12-08 Thread Michael Nazzareno Trimarchi
Hi Down you have my tentative of connection I need to hack a bit to have tuner registered. I'm using imx-media On Sat, Dec 8, 2018 at 12:48 PM Michael Nazzareno Trimarchi wrote: > > Hi > > On Fri, Dec 7, 2018 at 1:11 PM Hans Verkuil wrote: > > > > On 12/07/20

Re: Configure video PAL decoder into media pipeline

2018-12-08 Thread Michael Nazzareno Trimarchi
can configure pads, links like what we do on > > conventional pipeline or it should not to be part of media pipeline? > > Yes, I would say it should be part of the pipeline. > Ok I have created a draft patch to add the adv some new endpoint but is sufficient to declare tuner type in media

Re: [PATCH 4/5 RESEND] si470x-i2c: Add optional reset-gpio support

2018-12-07 Thread Michael Nazzareno Trimarchi
ideo_unregister_device(&radio->videodev); > + if (radio->gpio_reset) > + gpiod_set_value(radio->gpio_reset, 0); I have a question for you. If the gpio is the last of the bank acquired for this cpu, when you put to 0, then the gpio will be free on remove and

Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread Michael Schmitz
anyone get offended by reading technical comments? This is all beyond me... Agree, this is insanity. Irony? Parody? That's what crossed my mind, to be brutally honest. Group hug, anyone? For the VME vectors case: no need to hug, just don't mess with them. Cheers, Michael (W

Re: [PATCH V2] mm: Replace all open encodings for NUMA_NO_NODE

2018-11-26 Thread Michael Ellerman
; arch/ia64/mm/discontig.c | 6 +++--- > arch/ia64/sn/kernel/io_common.c | 3 ++- > arch/powerpc/include/asm/pci-bridge.h | 3 ++- > arch/powerpc/kernel/paca.c| 3 ++- > arch/powerpc/kernel/pci-common.c | 3 ++

[PATCH v2 2/2] media: hdcapm: add support for usb2hdcapm hdmi2usb framegrabber from startech

2018-11-26 Thread Michael Grzeschik
From: Steven Toth This patch is based on the work of Steven Toth. He reverse engineered the driver by tracing the windows driver. https://github.com/stoth68000/hdcapm/ Signed-off-by: Steven Toth Signed-off-by: Michael Grzeschik --- drivers/media/usb/Kconfig| 1

[PATCH 1/2] [media] v4l2-pci-skeleton: depend on CONFIG_SAMPLES

2018-11-26 Thread Michael Tretter
river, but SAMPLES needs to be enabled, too. Let VIDEO_PCI_SKELETON depend on SAMPLES. Signed-off-by: Michael Tretter --- drivers/media/v4l2-core/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/v4l2-core/Kconfig b/drivers/media/v4l2-core/Kconfig index b97090e85996..c0

[PATCH 0/2] Fix v4l2-pci-skeleton driver

2018-11-26 Thread Michael Tretter
This series fixes the v4l2-pci-skeleton driver to make it usable as a reference for new v4l2 drivers again. The driver was skipped when replacing vb2_buffer with vb2_v4l2_buffers for v4l2 drivers. Moreover, VIDEO_PCI_SKELETON did not ensure that it is actually build. Michael Tretter (2

[PATCH v2 1/2] media: mst3367: add support for mstar mst3367 HDMI RX

2018-11-26 Thread Michael Grzeschik
From: Steven Toth This patch is based on the work of Steven Toth. He reverse engineered the driver by tracing the windows driver. https://github.com/stoth68000/hdcapm/ Signed-off-by: Steven Toth Signed-off-by: Michael Grzeschik --- drivers/media/i2c/Kconfig | 10 + drivers/media/i2c

[PATCH 2/2] [media] v4l2-pci-skeleton: replace vb2_buffer with vb2_v4l2_buffer

2018-11-26 Thread Michael Tretter
uffer is a vb2_v4l2_buffer. This is not the case if the skel_buffer is based on vb2_buffer instead of vb2_v4l2_buffer. Replace vb2_buffer with vb2_v4l2_buffer in the skeleton to make sure that future drivers that are based on the skeleton use vb2_v4l2_buffer. Signed-off-by: Michael Tretter --- s

[PATCH v2 0/2] media: Startech usb2hdcapm hdmi2usb framegrabber support

2018-11-26 Thread Michael Grzeschik
This series adds support for the Startech usb2hdcapm framegrabber. The code is based on the external kernel module code from Steven Toth's github page: https://github.com/stoth68000/hdcapm/ We applied checkpatch.pl --strict and cleaned up the 80 character length, whitespace issues and replaced si

Re: [PATCH 1/2] media: mst3367: add support for mstar mst3367 HDMI RX

2018-11-07 Thread Michael Grzeschik
On Fri, Oct 19, 2018 at 01:02:19PM +0200, Lucas Stach wrote: > Am Freitag, den 19.10.2018, 12:54 +0200 schrieb Michael Grzeschik: > > > From: Steven Toth > > > > This patch is based on the work of Steven Toth. He reverse engineered > > the driver by tracing the

Re: [PATCH] lirc.4: remove ioctls and feature bits which were never implemented

2018-10-30 Thread Michael Kerrisk (man-pages)
t/commit/?id=d55f09abe24b4dfadab246b6f217da547361cdb6 > > Signed-off-by: Sean Young Thanks for your persistence. Mauro, Alec, thanks for your input. Patch Applied. Thanks! Michael > --- > man4/lirc.4 | 92 > ++--- > 1 file changed, 2 insertions(+), 90

[PATCH 2/2] media: hdcapm: add support for usb2hdcapm hdmi2usb framegrabber from startech

2018-10-19 Thread Michael Grzeschik
From: Steven Toth This patch is based on the work of Steven Toth. He reverse engineered the driver by tracing the windows driver. https://github.com/stoth68000/hdcapm/ Signed-off-by: Steven Toth Signed-off-by: Michael Grzeschik --- MAINTAINERS | 6

[PATCH 1/2] media: mst3367: add support for mstar mst3367 HDMI RX

2018-10-19 Thread Michael Grzeschik
From: Steven Toth This patch is based on the work of Steven Toth. He reverse engineered the driver by tracing the windows driver. https://github.com/stoth68000/hdcapm/ Signed-off-by: Steven Toth Signed-off-by: Michael Grzeschik --- MAINTAINERS |6 + drivers/media/i2c

[PATCH 0/2] media: Startech usb2hdcapm hdmi2usb framegrabber support

2018-10-19 Thread Michael Grzeschik
This series adds support for the Startech usb2hdcapm framegrabber. The code is based on the external kernel module code from Steven Toth's github page: https://github.com/stoth68000/hdcapm/ We applied checkpatch.pl --strict and cleaned up the 80 character length, whitespace issues and replaced si

Re: [PATCH] Documentation/media: uapi: Explicitly say there are no Invariant Sections

2018-08-09 Thread Michael Ira Krufky
-any later version published by the Free Software Foundation. A copy of > > -the license is included in the chapter entitled "GNU Free Documentation > > -License". > > +any later version published by the Free Software Foundation, with no > > +Invariant Sections. A copy of the license is included in the chapter > > +entitled "GNU Free Documentation License". The original founders / authors / coders of LinuxDVB have signed off on this, and that is most important to me. Signed-off-by: Michael Ira Krufky

[GIT PULL] [RESEND] urgent em28xx bug fixes for immediate merge

2018-07-26 Thread Michael Ira Krufky
em28xx: Fix DualHD disconnect oops em28xx: Remove duplicate PID drivers/media/usb/em28xx/em28xx-cards.c | 6 +++--- drivers/media/usb/em28xx/em28xx-dvb.c | 4 +++- 2 files changed, 6 insertions(+), 4 deletions(-) On Thu, Jul 26, 2018 at 8:27 AM Michael Ira Krufky wrote: > > This is a

[PULL] urgent em28xx bug fixes for immediate merge

2018-07-26 Thread Michael Ira Krufky
This is a resend of https://patchwork.linuxtv.org/patch/51227/ - I forgot to include an email subject in the pull request :-/ Hello Mauro, The following three patches from Brad Love are urgently needed for merge ASAP. One just removes a duplicated PID, so it's not as important but should be merg

[no subject]

2018-07-26 Thread Michael Ira Krufky
Hello Mauro, The following three patches from Brad Love are urgently needed for merge ASAP. One just removes a duplicated PID, so it's not as important but should be merged ASAP nonetheless. The other two fix an OOPS along with broken dual transport streaming operation. Please merge ASAP. The

Re: [PATCH 1/2] media: dvb: convert tuner_info frequencies to Hz

2018-07-05 Thread Michael Büsch
quot;, > > - .frequency_min = 4500, > - .frequency_max = 10, > + .frequency_min_hz = 45 * MHz, > + .frequency_max_hz = 1000 * MHz, > }, > > .release= fc0011_release, Acked

  1   2   3   4   5   6   7   8   9   10   >