[PATCH v2 1/4] media: i2c: tvp5150: Add a space after commas

2018-04-02 Thread Nasser Afshin
This patch resolves checkpatch.pl errors: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Nasser Afshin <afshin.nas...@gmail.com> --- drivers/media/i2c/tvp5150.c | 134 ++-- 1 file changed, 67 insertions(+), 67 deletions(-) diff

[PATCH v2 4/4] media: i2c: tvp5150: Use parentheses for sizeof

2018-04-02 Thread Nasser Afshin
This patch resolves a checkpatch.pl warning: WARNING: sizeof *cap should be sizeof(*cap) Signed-off-by: Nasser Afshin <afshin.nas...@gmail.com> --- drivers/media/i2c/tvp5150.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/tvp5150.c b/drivers/med

[PATCH v2 2/4] media: i2c: tvp5150: Use the correct comment style

2018-04-02 Thread Nasser Afshin
This patch resolves checkpatch.pl warnings: WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Nasser Afshin <afshin.nas...@gmail.com> --- drivers/media/i2c/tvp5150.c | 19 --- 1 file chang

[PATCH v2 3/4] media: i2c: tvp5150: Fix open brace placement codding style

2018-04-02 Thread Nasser Afshin
This patch resolves the following checkpatch.pl error: ERROR: that open brace { should be on the previous line Signed-off-by: Nasser Afshin <afshin.nas...@gmail.com> --- drivers/media/i2c/tvp5150.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/med

[PATCH v2 0/4] media: i2c: tvp5150: resolve checkpatch errors

2018-04-02 Thread Nasser Afshin
This patch series tries to resolve some checkpatch.pl errors and warnings. Nasser Afshin (4): media: i2c: tvp5150: Add a space after commas media: i2c: tvp5150: Use the correct comment style media: i2c: tvp5150: Fix open brace placement codding style media: i2c: tvp5150: Use parentheses

[PATCH 1/3] media: i2c: tvp5150: Add a space after commas

2018-04-02 Thread Nasser Afshin
This patch resolves checkpatch.pl errors: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Nasser Afshin <afshin.nas...@gmail.com> --- drivers/media/i2c/tvp5150.c | 134 ++-- 1 file changed, 67 insertions(+), 67 deletions(-) diff

[PATCH 0/3] media: i2c: tvp5150: resolve checkpatch errors

2018-04-02 Thread Nasser Afshin
This patch series tries to resolve some checkpatch.pl errors and warnings. Nasser Afshin (3): media: i2c: tvp5150: Add a space after commas media: i2c: tvp5150: Use the correct comment style media: i2c: tvp5150: Use parentheses for sizeof drivers/media/i2c/tvp5150.c | 159

[PATCH 2/3] media: i2c: tvp5150: Use the correct comment style

2018-04-02 Thread Nasser Afshin
This patch resolves some checkpatch.pl warnings about comments. Signed-off-by: Nasser Afshin <afshin.nas...@gmail.com> --- drivers/media/i2c/tvp5150.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/media/i2c/tvp5150.c b/drivers/med

[PATCH 3/3] media: i2c: tvp5150: Use parentheses for sizeof

2018-04-02 Thread Nasser Afshin
This patch resolves a checkpatch.pl warning Signed-off-by: Nasser Afshin <afshin.nas...@gmail.com> --- drivers/media/i2c/tvp5150.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c index d561d87d219a..d528fddbea16

[PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

2018-03-25 Thread Nasser Afshin
According to the datasheet, INTREQ/GPCL/VBLK should have a pull-up/down resistor if it's been disabled. On hardware that does not have such resistor, we should use the default output enable value. This prevents the color burst lock instability problem. Signed-off-by: Nasser Afshin <afshin.