Re: [PATCH 1/2] drivers/media/rc/ir-nec-decode : add toggle feature

2014-07-26 Thread Niels Laukens
On 2014-07-26 17:47, Mauro Carvalho Chehab wrote: > Em Thu, 19 Jun 2014 13:59:49 +0200 > Niels Laukens escreveu: > >> On 2014-06-19 11:05, David Härdeman wrote: >>> On Thu, Jun 19, 2014 at 10:25:29AM +0200, Niels Laukens wrote: >>>> Made the distinction betwee

Re: [PATCH 1/2] drivers/media/rc/ir-nec-decode : add toggle feature

2014-06-19 Thread Niels Laukens
On 2014-06-19 11:05, David Härdeman wrote: > On Thu, Jun 19, 2014 at 10:25:29AM +0200, Niels Laukens wrote: >> Made the distinction between repeated key presses, and a single long >> press. The NEC-protocol does not have a toggle-bit (cfr RC5/RC6), but >> has specific repea

[PATCH 1/2] drivers/media/rc/ir-nec-decode : add toggle feature

2014-06-19 Thread Niels Laukens
>From 83aa9f9fa0eaf9eb8005af49f5ce93d24a0b9f2e Mon Sep 17 00:00:00 2001 From: Niels Laukens Date: Thu, 19 Jun 2014 10:05:11 +0200 Subject: [PATCH 1/2] drivers/media/rc/ir-nec-decode : add toggle feature (1/2) Made the distinction between repeated key presses, and a single long press. The

[PATCH 2/2] drivers/media/rc/ir-nec-decode : add toggle feature (2/2)

2014-06-19 Thread Niels Laukens
>From a8fca4a8c37cb35ea4527a708a6894745f81c661 Mon Sep 17 00:00:00 2001 From: Niels Laukens Date: Thu, 19 Jun 2014 10:06:00 +0200 Subject: [PATCH 2/2] drivers/media/rc/ir-nec-decode : add toggle feature (2/2) Fixes indentation. Kept as separate patch to keep patch 1/2 more to the point. Sig

[PATCH 0/2] drivers/media/rc/ir-nec-decode : add toggle feature

2014-06-19 Thread Niels Laukens
Hi, The IR NEC protocol decoder does not handle repeated key presses very well. It is regarded the same as a long key press, an thus triggers the auto-repeat functionality, which is not what I expected. The first patch solves the issue; the second patch fixes indentation inside the (new) if-block

Re: [BUG & PATCH] media/rc/ir-nec-decode : phantom keypress

2014-06-12 Thread Niels Laukens
On 2014-06-12 14:42, David Härdeman wrote: > Could you paste the output from lsmod? At the end of this mail. > Where did you get the driver? Is it this one? > http://www.tbsdtv.com/download/document/common/tbs-linux-drivers_v140425.zip Yes, inside the zip is `linux-tbs-drivers.tar.bz2`, where t

Re: [BUG & PATCH] media/rc/ir-nec-decode : phantom keypress

2014-06-12 Thread Niels Laukens
On 2014-06-12 13:51, David Härdeman wrote: > On 2014-06-12 13:22, Niels Laukens wrote: >> In that case, the alternative would be to start a timer when the >> TRAILING_SPACE is entered, and trigger the key-event after, say 2 >> bit-times. > > Another alternative is fi

Re: [BUG & PATCH] media/rc/ir-nec-decode : phantom keypress

2014-06-12 Thread Niels Laukens
ot;reasonable" means. I've found 300+ms, which is unusable long. Niels > On 2014-06-11 10:06, Niels Laukens wrote: >> I have not received any response on this email... so I hope to bump this >> thread back to the more active region in most people's in-boxes. >> &

Re: [BUG & PATCH] media/rc/ir-nec-decode : phantom keypress

2014-06-11 Thread Niels Laukens
I have not received any response on this email... so I hope to bump this thread back to the more active region in most people's in-boxes. On 2014-05-31 10:37, Niels Laukens wrote: > Hi, > > I believe I've found a bug in the NEC decoder for InfraRed remote > controls.

[BUG & PATCH] media/rc/ir-nec-decode : phantom keypress

2014-05-31 Thread Niels Laukens
ased on 3.13), and it solves the bug. I've compared this TBS-version with the current master (1487385). There are 8 (non-comment) lines that differ, none affect this patch. This patch applies cleanly to the current master. Regards, Niels >From 071c316e9315f22a055d6713cc8cdcdc73642193 Mon Se