Re: [PATCH v3 2/2] media: rc: remove ir-rx51 in favour of generic pwm-ir-tx

2018-07-15 Thread Pali Rohár
al HW, however I am on a > holiday for the next week so won't be able to test till I am back. > > @Pali - do you have n900 with fremantle, upstream kernel and pierogi to test > pwm-ir-tx on it? Hi! Currently on my N900 with Maemo Fremantle is 2.6.28 and 3.12 kernels. And 3.12

Re: [PATCH] media: rc: remove ir-rx51 in favour of generic pwm-ir-tx

2017-11-01 Thread Pali Rohár
current process is not in interruptable sleep. The > process is not put to sleep until the transmit completes. Hello, have you tested this patch that IR transmitter is still working fine on the real Nokia N900 device? > Cc: Ivaylo Dimitrov <ivo.g.dimitrov...@gmail.com> > Cc: Pali Roh

Re: [patch] libv4l2: SDL test application

2017-10-30 Thread Pali Rohár
directory '/home/hans/work/src/v4l/v4l-utils' > Makefile:516: recipe for target 'all' failed > make: *** [all] Error 2 > > I had to add -lm -ldl -lrt to sdlcam_LDFLAGS. Is that correct? Is not for <> needed just -lm? log2 should be in mathematical library. -- Pali Rohár pali.ro...@gmail.com

Re: support autofocus / autogain in libv4l2

2017-04-25 Thread Pali Rohár
On Tuesday 25 April 2017 14:28:20 Pavel Machek wrote: > On Tue 2017-04-25 13:30:09, Pali Rohár wrote: > > On Tuesday 25 April 2017 13:23:30 Pavel Machek wrote: > > > Hi! > > > On Tue 2017-04-25 10:08:15, Pali Rohár wrote: > > > > On Tuesday 25

Re: support autofocus / autogain in libv4l2

2017-04-25 Thread Pali Rohár
On Tuesday 25 April 2017 13:23:30 Pavel Machek wrote: > Hi! > On Tue 2017-04-25 10:08:15, Pali Rohár wrote: > > On Tuesday 25 April 2017 10:05:38 Pavel Machek wrote: > > > > > It would be nice if more than one application could be accessing the > > > > >

Re: support autofocus / autogain in libv4l2

2017-04-25 Thread Pali Rohár
cam video, like pulseaudio server for accessing more applications to microphone input. -- Pali Rohár pali.ro...@gmail.com

Re: [RFC 08/13] smiapp-pll: Take existing divisor into account in minimum divisor check

2017-02-15 Thread Pali Rohár
ds: Message-Id: <1364719448-29894-1-git-send-email-sakari.ai...@iki.fi> Message-ID: <5728ed34.3060...@gmail.com> I think I already resent those information again :-) -- Pali Rohár pali.ro...@gmail.com

Re: [PATCH] devicetree: Add video bus switch

2017-02-03 Thread Pali Rohár
s on N900 there are two GPIOs. Should not you have both in switch driver? -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5] media: Driver for Toshiba et8ek8 5MP sensor

2016-12-14 Thread Pali Rohár
; + > > > +/* > > > + * Stingray sensor mode settings for Scooby > > > + */ > > > > Are settings for this sensor Stingray enough? > > Seems to work well enough for me. If more modes are needed, we can add > them later. Ok. > > It was me who co

Re: [PATCHv6] support for AD5820 camera auto-focus coil

2016-12-14 Thread Pali Rohár
ngs correctly, both DTS patch and this > patch are waiting in your tree, so we should be good to go for 4.9 > (unless some unexpected problems surface)? > > Best regards, > Pavel Was DTS patch merged into 4.9? At

Re: [PATCH v5] media: Driver for Toshiba et8ek8 5MP sensor

2016-12-14 Thread Pali Rohár
Hi! See inlined some my notes. On Wednesday 14 December 2016 13:24:51 Pavel Machek wrote: > > Add driver for et8ek8 sensor, found in Nokia N900 main camera. Can be > used for taking photos in 2.5MP resolution with fcam-dev. > > Signed-off-by: Ivaylo Dimitrov >

Re: v4.9-rc1: smiapp divides by zero

2016-10-23 Thread Pali Rohár
z / i; > + if (!mul) { > + dev_err(dev, "forcing mul to 1\n"); > + mul = 1; > + } > dev_dbg(dev, "mul %u / div %u\n", mul, div); > > min_pre_pll_clk_div = Is not this patch still enough? https://patchwork.kernel.org/patch/8921761/ -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [PATCHv6] support for AD5820 camera auto-focus coil

2016-08-10 Thread Pali Rohár
OCUS_ABSOLUTE, as is in the patch. If we get something > better in the future, we'll switch to that then. Ok, and what with AD5820_RAMP_TIME and AD5820_RAMP_MODE? > I've applied this to ad5820 branch in my tree. Are you going to finally send this patch to media tree or pull request to Linu

Re: [PATCHv6] support for AD5820 camera auto-focus coil

2016-08-05 Thread Pali Rohár
On Friday 05 August 2016 12:26:11 Pavel Machek wrote: > > This adds support for AD5820 autofocus coil, found for example in > Nokia N900 smartphone. > > Signed-off-by: Pavel Machek <pa...@ucw.cz> Acked-by: Pali Rohár <pali.ro...@gmail.com> > --- > v2: simple cl

Re: [RESEND PATCH v2 0/5] ir-rx51 driver fixes

2016-06-23 Thread Pali Rohár
12 +- include/linux/platform_data/media/ir-rx51.h| > 3 - > 8 files changed, 111 insertions(+), 174 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/media/nokia,n900-ir Looks good, you can add my Acked-by. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [RESEND PATCH v2 1/5] ir-rx51: Fix build after multiarch changes broke it

2016-06-23 Thread Pali Rohár
it message. Just for email discussion. > Cc: Mauro Carvalho Chehab <mche...@osg.samsung.com> > Cc: Neil Armstrong <narmstr...@baylibre.com> > Cc: linux-media@vger.kernel.org > Signed-off-by: Tony Lindgren <t...@atomide.com> > Signed-off-by: Ivaylo Dimitrov <i

Re: [PATCH v3 1/2] media: Driver for Toshiba et8ek8 5MP sensor

2016-06-18 Thread Pali Rohár
that original stingraytsb_v14_simple.ini file: https://gitorious.org/omap3camera/camera-firmware?p=omap3camera:camera-firmware.git;a=tree;f=ini Looks like are are some "non simple" stingraytsb_v14 files too, but I have no idea which modes defines... Sakari, any idea? Which we should include into kernel et8ek8 kernel driver? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [PATCH v3 1/2] media: Driver for Toshiba et8ek8 5MP sensor

2016-06-18 Thread Pali Rohár
. For me this sounds like a big overkill, so I included above reglist code direcly into et8ek8 kernel driver to avoid request_firmware() and separate userspace storage... And for smia-sensor (front webcam) in that gitorious repository is also reglist structure. It is not needed? Can somebody investigate why it is not needed? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [PATCH 0/7] ir-rx51 driver fixes

2016-06-13 Thread Pali Rohár
> | 12 +- include/linux/platform_data/media/ir-rx51.h| > 3 - > 11 files changed, 131 insertions(+), 175 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/media/nokia,lirc-rx51 Patch series looks good, you can add my Acked-by. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [RFC PATCH 04/24] smiapp-pll: Take existing divisor into account in minimum divisor check

2016-05-24 Thread Pali Rohár
r writing the patch, but I don't remember what for, or whether it > was really needed. Does the secondary sensor work without this one? Hi! You sent me this patch more then 3 years ago. Look at our private email discussion, e.g. email with Message-Id <201303281524.10538@pali> and subjec

Re: [PATCHv3] support for AD5820 camera auto-focus coil

2016-05-23 Thread Pali Rohár
vice, > >subdev) > >+ > >+struct ad5820_device { > >+struct v4l2_subdev subdev; > >+struct ad5820_platform_data *platform_data; > >+ struct regulator *vana; > >+ > >+struct v4l2_ctrl_handler ctrls; > >+u32 focus_absolute; > >+u32 f

Re: camera application for testing (was Re: v4l subdevs without big device)

2016-04-29 Thread Pali Rohár
On Saturday 30 April 2016 00:13:59 Pavel Machek wrote: > Any other application I should look at? Thanks, Maybe camera-ui, which is part of CSSU? https://github.com/community-ssu/camera-ui -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: v4l subdevs without big device was Re: drivers/media/i2c/adp1653.c: does not show as /dev/video* or v4l-subdev*

2016-04-29 Thread Pali Rohár
gt; leds-as3645a > > Yeah, that works, too. git alias has been added some three weeks ago so > there seem to be something strange going on with DNS. Maybe update SOA record? -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-media"

Re: [RFC PATCH 00/24] Make Nokia N900 cameras working

2016-04-25 Thread Pali Rohár
On Monday 25 April 2016 16:14:41 Pali Rohár wrote: > > Anyway, does anyone know where to get the media-ctl tool? > > Looks like it is part of v4l-utils package. At least in git: > https://git.linuxtv.org/v4l-utils.git/tree/utils/media-ctl > > > It does not seem to be

Re: [RFC PATCH 00/24] Make Nokia N900 cameras working

2016-04-25 Thread Pali Rohár
ool? Looks like it is part of v4l-utils package. At least in git: https://git.linuxtv.org/v4l-utils.git/tree/utils/media-ctl > It does not seem to be in debian 7 or debian 8... I do not see it in debian too, but there is some version in ubuntu: http://packages.ubuntu.com/trusty/media-ctl

Re: [RFC PATCH 00/24] Make Nokia N900 cameras working

2016-04-25 Thread Pali Rohár
864x656]' > media-ctl -V '"OMAP3 ISP resizer":1 [UYVY 800x600]' > > > mplayer -tv driver=v4l2:width=800:height=600:outfmt=uyvy:device=/dev/video6 > -vo xv -vf screenshot tv:// Hey!!! That is crazy! Who created such retard API?? In both cases you are going to show vide

Re: [PATCH] Staging: media/bcm2048: Fix line over 80 characters warning as detected by checkpatch.pl

2015-08-12 Thread Pali Rohár
] |= 0x80; Hi! I think that code after this change is less readable as before. -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

[PATCH v2] radio-bcm2048: Fix region selection

2015-06-09 Thread Pali Rohár
From: Jan Roemisch m...@spaceboyz.net This patch fixes region selection for lower bottom_frequency in BCM2048 FM receiver. It also removes Japan wide band region since this is impossible to do just like that. Signed-off-by: Jan Roemisch m...@spaceboyz.net Acked-by: Pali Rohár pali.ro

Re: [PATCH] radio-bcm2048: Fix region selection

2015-06-05 Thread Pali Rohár
On Friday 05 June 2015 13:36:40 Hans Verkuil wrote: On 05/15/2015 11:32 PM, Pali Rohár wrote: From: maxx m...@spaceboyz.net This actually fixes region selection for BCM2048 FM receiver. To select the japanese FM-band an additional bit in FM_CTRL register needs to be set. This might

[PATCH] radio-bcm2048: Enable access to automute and ctrl registers

2015-05-15 Thread Pali Rohár
-by: Pali Rohár pali.ro...@gmail.com Cc: m...@spaceboyz.net --- drivers/staging/media/bcm2048/radio-bcm2048.c | 96 + 1 file changed, 96 insertions(+) diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c index 1482d4b

[PATCH] radio-bcm2048: Fix region selection

2015-05-15 Thread Pali Rohár
below normal FM-band. Patch writen by m...@spaceboyz.net Signed-off-by: Pali Rohár pali.ro...@gmail.com Cc: m...@spaceboyz.net --- drivers/staging/media/bcm2048/radio-bcm2048.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b

Re: [PATCH] radio-bcm2048: remove unused var

2015-04-28 Thread Pali Rohár
: if (client-irq) free_irq(client-irq, bdev); Looks good to me, so Acked-by: Pali Rohár pali.ro...@gmail.com -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] media: bcm2048: remove unused return of function

2015-02-09 Thread Pali Rohár
insertion(+), 3 deletions(-) Looks good, Acked-by: Pali Rohár pali.ro...@gmail.com -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [PATCH 2/5] radio-bcm2048: use unlocked_ioctl instead of ioctl

2015-02-03 Thread Pali Rohár
On Tuesday 03 February 2015 13:47:23 Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com This driver does its own locking, so there is no need to use ioctl instead of unlocked_ioctl. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Looks good, Acked-by: Pali Rohár pali.ro

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-17 Thread Pali Rohár
legacy board camera code in file board-rx51-camera.c. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-17 Thread Pali Rohár
On Monday 17 November 2014 11:05:19 Pavel Machek wrote: Hi! On Mon 2014-11-17 09:43:19, Pali Rohár wrote: On Sunday 16 November 2014 08:59:28 Pavel Machek wrote: For device tree people: Yes, I know I'll have to create file in documentation, but does the binding below look acceptable

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-17 Thread Pali Rohár
On Monday 17 November 2014 15:55:46 Tony Lindgren wrote: * Pavel Machek pa...@ucw.cz [141117 02:17]: On Mon 2014-11-17 11:09:45, Pali Rohár wrote: On Monday 17 November 2014 11:05:19 Pavel Machek wrote: Hi! On Mon 2014-11-17 09:43:19, Pali Rohár wrote: On Sunday 16 November

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-17 Thread Pali Rohár
On Monday 17 November 2014 16:04:07 Sakari Ailus wrote: Hi Pali, On Mon, Nov 17, 2014 at 04:01:31PM +0100, Pali Rohár wrote: On Monday 17 November 2014 15:55:46 Tony Lindgren wrote: * Pavel Machek pa...@ucw.cz [141117 02:17]: On Mon 2014-11-17 11:09:45, Pali Rohár wrote

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-17 Thread Pali Rohár
On Monday 17 November 2014 16:06:17 Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [141117 07:03]: On Monday 17 November 2014 15:55:46 Tony Lindgren wrote: There's nothing stopping us from initializing the camera code from pdata-quirks.c for now to keep it working. Certainly

Re: [PATCH v2] radio-bcm2048.c: fix wrong overflow check

2014-05-09 Thread Pali Rohár
On Monday 05 May 2014 15:34:29 Jiri Kosina wrote: On Tue, 22 Apr 2014, Dan Carpenter wrote: From: Pali Rohár pali.ro...@gmail.com This patch fixes an off by one check in bcm2048_set_region(). Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Pali Rohár pali.ro

Re: [PATCH] radio-bcm2048.c: fix wrong overflow check

2014-04-22 Thread Pali Rohár
On Tuesday 22 April 2014 11:38:36 Pavel Machek wrote: On Tue 2014-04-22 12:16:56, Dan Carpenter wrote: On Tue, Apr 22, 2014 at 10:55:53AM +0200, Pali Rohár wrote: On Tuesday 22 April 2014 10:39:17 Dan Carpenter wrote: On Sun, Apr 20, 2014 at 04:56:22PM +0200, Pavel Machek wrote

Re: [PATCH] media: Add BCM2048 radio driver

2013-12-05 Thread Pali Rohár
On Thursday 05 December 2013 08:52:30 Hans Verkuil wrote: On 12/02/2013 09:51 PM, Pali Rohár wrote: On Monday 04 November 2013 12:39:44 Hans Verkuil wrote: Hi Pali, On 10/26/2013 10:45 PM, Pali Rohár wrote: On Saturday 26 October 2013 22:22:09 Hans Verkuil wrote: Hans, so can

Re: [PATCH] media: Add BCM2048 radio driver

2013-12-02 Thread Pali Rohár
On Monday 04 November 2013 12:39:44 Hans Verkuil wrote: Hi Pali, On 10/26/2013 10:45 PM, Pali Rohár wrote: On Saturday 26 October 2013 22:22:09 Hans Verkuil wrote: Hans, so can it be added to drivers/staging/media tree? Yes, that is an option. It's up to you to decide what you want

Re: [PATCH] media: Add BCM2048 radio driver

2013-10-26 Thread Pali Rohár
Hans, so can it be added to drivers/staging/media tree? On Thursday 17 October 2013 21:31:04 Pali Rohár wrote: Hello, so what do you suggest? Add it to staging for now (or not)? On Tuesday 15 October 2013 17:08:39 Hans Verkuil wrote: Hi Pali, Thanks for the patch, but I am afraid

Re: [PATCH] media: Add BCM2048 radio driver

2013-10-26 Thread Pali Rohár
. Regards, Hans Ok, so if you can add it to staging tree. When driver will be in mainline other developers can look at it too. Now when driver is hidden, nobody know where to find it... You can see how upstream development for Nokia N900 HW going on: http://elinux.org/N900 -- Pali Rohár

Re: [PATCH] media: Add BCM2048 radio driver

2013-10-17 Thread Pali Rohár
very useful to run v4l2-compliance (available in the v4l-utils.git repo on git.linuxtv.org). That does lots of sanity checks. Another option is to add the driver as-is to drivers/staging/media, and clean it up bit by bit. Regards, Hans On 10/15/2013 04:26 PM, Pali Rohár wrote

[PATCH] rc: ir-rx51: Fix compilation

2013-02-28 Thread Pali Rohár
From: Joni Lapilainen joni.lapilai...@gmail.com Signed-off-by: Joni Lapilainen joni.lapilai...@gmail.com --- drivers/media/rc/ir-rx51.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/rc/ir-rx51.c b/drivers/media/rc/ir-rx51.c index 8ead492..3971192