Signed-off-by: Phil Edworthy phil.edwor...@renesas.com
---
v2:
- Fix silly mistake with missing break.
drivers/media/platform/soc_camera/rcar_vin.c |9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/media/platform/soc_camera/rcar_vin.c
b/drivers/media/platform/soc_camera
Signed-off-by: Phil Edworthy phil.edwor...@renesas.com
---
drivers/media/platform/soc_camera/rcar_vin.c |7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/media/platform/soc_camera/rcar_vin.c
b/drivers/media/platform/soc_camera/rcar_vin.c
index 3b1c05a..9929375 100644
Hi Guennadi,
Ok, now I see. My comment about the sensor output size changing is
wrong.
The sensor doesn't do any scaling, so we are cropping it.
Ah, ok, then you shouldn't change video sizes in your .s_fmt(), just
return the current cropping rectangle.
I'm reworking the code but
Hi Guennadi,
+{
+ struct i2c_client *client = v4l2_get_subdevdata(sd);
+ struct ov10635_priv *priv = to_ov10635(client);
+ struct v4l2_captureparm *cp = parms-parm.capture;
+ enum v4l2_mbus_pixelcode code;
+ int ret;
+
+ if (parms-type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
Hi Guennadi,
There is one issue with setting the camera to achieve different
framerate.
The camera can work at up to 60fps with lower resolutions, i.e. when
vertical sub-sampling is used. However, the API uses separate
functions
for changing resolution and framerate. So, userspace
Hi Laurent,
From: Laurent Pinchart laurent.pinch...@ideasonboard.com
To: Phil Edworthy phil.edwor...@renesas.com,
Cc: linux-media@vger.kernel.org, Jean-Philippe Francois
jp.franc...@cynove.com, Hans Verkuil hverk...@xs4all.nl, Guennadi
Liakhovetski g.liakhovet...@gmx.de, Mauro Carvalho
Hi Guennadi,
Thanks for the review.
I'll comment to this version, although the driver has to be updated to
the
V4L2 clock API at least, preferably also to asynchronous probing.
Ok, I'll have to look into that.
snip
+ * FIXME:
+ * Horizontal flip (mirroring) does not work correctly.
Hi Guennadi,
+/* read a register */
+static int ov10635_reg_read(struct i2c_client *client, u16 reg,
u8
*val)
+{
+ int ret;
+ u8 data[2] = { reg 8, reg 0xff };
+ struct i2c_msg msg = {
+ .addr = client-addr,
+ .flags = 0,
+ .len
Hi Guennadi,
snip
Well, I think, both of you will agree, that these register value lists
look horrible and actually have little to do with open-source software,
but I don't know what to do about them either. We could just reject them
and only accept drivers, properly describing what they
Signed-off-by: Phil Edworthy phil.edwor...@renesas.com
---
v3:
- Removed dupplicated writes to reg 0x3042
- Program all the standard registers after checking the ID
v2:
- Simplified flow in ov10635_s_ctrl.
- Removed chip ident code - build tested only
drivers/media/i2c/soc_camera/Kconfig
Hi Guennadi,
Thanks for the patch. I'll look at it in more detail hopefully soon
enough... One remark so far to Jean-Philippe's comment:
[snip]
Register 0x3042 is only touched by the enable part, not by the change
mode part
I think you could move the {0x3042, 0xf0} sequence in the
Hi Jean-Philippe,
Thanks for the review.
snip
+static const struct ov10635_reg ov10635_regs_enable[] = {
+ { 0x3042, 0xf0 }, { 0x3042, 0xf0 }, { 0x3042, 0xf0 }, {
0x3042, 0xf0 },
+ { 0x3042, 0xf0 }, { 0x3042, 0xf0 }, { 0x3042, 0xf0 }, {
0x3042, 0xf0 },
+ { 0x3042,
Signed-off-by: Phil Edworthy phil.edwor...@renesas.com
---
drivers/media/i2c/soc_camera/Kconfig |6 +
drivers/media/i2c/soc_camera/Makefile |1 +
drivers/media/i2c/soc_camera/ov10635.c | 1169
include/media/v4l2-chip-ident.h|1 +
4 files
Hi Hans,
Subject: Re: [PATCH] ov10635: Add OmniVision ov10635 SoC camera driver
snip
+#include media/v4l2-chip-ident.h
Don't implement chip_ident or use this header: it's going to be
removed in 3.11.
snip
+/* Set status of additional camera capabilities */
+static int
Signed-off-by: Phil Edworthy phil.edwor...@renesas.com
---
v2:
- Simplified flow in ov10635_s_ctrl.
- Removed chip ident code - build tested only
drivers/media/i2c/soc_camera/Kconfig |6 +
drivers/media/i2c/soc_camera/Makefile |1 +
drivers/media/i2c/soc_camera/ov10635.c | 1141
Hi Sergei, Vladimir,
Oops, the comments about the captured image contents are my fault.
However, the unhandled irq after stopping capture is still an issue.
Thanks for letting us know.
The good news is that your driver works fine.
The problem I saw only occurs when your patches were
Hi Sergei, Vladimir,
Subject: [PATCH v5] V4L2: soc_camera: Renesas R-Car VIN driver
From: Vladimir Barinov vladimir.bari...@cogentembedded.com
Add Renesas R-Car VIN (Video In) V4L2 driver.
Based on the patch by Phil Edworthy phil.edwor...@renesas.com.
I've seen old patches
Hi Sergei, Vladimir,
Subject: [PATCH v5] V4L2: soc_camera: Renesas R-Car VIN driver
From: Vladimir Barinov vladimir.bari...@cogentembedded.com
Add Renesas R-Car VIN (Video In) V4L2 driver.
Based on the patch by Phil Edworthy phil.edwor...@renesas.com.
I've seen old
Hi Sergei, Vladimir,
Subject: [PATCH v5] V4L2: soc_camera: Renesas R-Car VIN driver
From: Vladimir Barinov vladimir.bari...@cogentembedded.com
Add Renesas R-Car VIN (Video In) V4L2 driver.
Based on the patch by Phil Edworthy phil.edwor...@renesas.com.
I've seen old patches that add VIN
Hi Guennadi,
From: Guennadi Liakhovetski g.liakhovet...@gmx.de
To: phil.edwor...@renesas.com,
Cc: linux-media@vger.kernel.org, Mauro Carvalho Chehab
mche...@redhat.com
Date: 26/04/2013 22:00
Subject: Re: [PATCH] soc_camera: Add V4L2_MBUS_FMT_YUYV10_2X10 format
Hi Phil
On Fri, 26 Apr
Hi Guennadi,
snip
Wow, what kind of host can pack two 10-bit samples into 3 bytes
and
write
3-byte pixels to memory?
I think I might have misunderstood how this is used. From my
understanding, the MBUS formats are used to describe the hardware
interfaces to cameras,
Hi Guennadi,
Thanks for the review!
On Wed, 17 Apr 2013, Phil Edworthy wrote:
The V4L2_MBUS_FMT_YUYV10_2X10 format has already been added to
mediabus, so
this patch just adds SoC camera support.
Signed-off-by: Phil Edworthy phil.edwor...@renesas.com
---
drivers/media/platform
Hi Guennadi,
On Wed, 17 Apr 2013, Phil Edworthy wrote:
The V4L2_MBUS_FMT_YUYV10_2X10 format has already been added to
mediabus, so
this patch just adds SoC camera support.
Signed-off-by: Phil Edworthy phil.edwor...@renesas.com
---
drivers/media/platform
The V4L2_MBUS_FMT_YUYV10_2X10 format has already been added to mediabus, so
this patch just adds SoC camera support.
Signed-off-by: Phil Edworthy phil.edwor...@renesas.com
---
drivers/media/platform/soc_camera/soc_mediabus.c | 15 +++
include/media/soc_mediabus.h
Based on work done by Katsuya Matsubara.
Signed-off-by: Phil Edworthy phil.edwor...@renesas.com
---
v2:
- Added documentation.
- Added SOCAM_DATAWIDTH_12 definition.
Documentation/DocBook/media/v4l/subdev-formats.xml | 206 +++-
Documentation/DocBook/media_api.tmpl
Hi Guennadi,
Thanks for the review, I'll try to find some time to fix send a new
version.
Phil
On Thu, 14 Feb 2013, Phil Edworthy wrote:
Based on work done by Katsuya Matsubara.
Signed-off-by: Phil Edworthy phil.edwor...@renesas.com
Looks mostly good to me, but please also
Hi Guennadi,
From: Guennadi Liakhovetski g.liakhovet...@gmx.de
To: Phil Edworthy phil.edwor...@renesas.com,
Cc: Mauro Carvalho Chehab mche...@redhat.com,
linux-media@vger.kernel.org
Date: 08/03/2013 13:30
Subject: Re: [PATCH] soc_camera: Add RGB666 RGB888 formats
Hi Phil
On Thu, 14
Based on work done by Katsuya Matsubara.
Signed-off-by: Phil Edworthy phil.edwor...@renesas.com
---
drivers/media/platform/soc_camera/soc_mediabus.c | 42 ++
include/media/soc_camera.h |6 +++-
include/media/soc_mediabus.h
Hi Guennadi, Morimoto-san,
Both are needed.
These are bug fix patches
I tried to capture several frames beginning with the very first one
(as
much as performance allowed), and I do see several black or wrongly
coloured framed in the beginning, but none of those patches,
29 matches
Mail list logo
