[PATCH] davinci: vpbe: fix module build

2013-03-08 Thread Prabhakar lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com add a null entry in platform_device_id {}. This patch fixes following error: drivers/media/platform/davinci/vpbe_venc: struct platform_device_id is 24 bytes. The last of 3 is: 0x64 0x6d 0x33 0x35 0x35 0x2c 0x76 0x70 0x62 0x65 0x2d 0x76 0x65 0x6e

Re: Error while building vpbe display as module

2013-03-08 Thread Prabhakar Lad
Sekhar, On Fri, Mar 8, 2013 at 3:00 PM, Sekhar Nori nsek...@ti.com wrote: Prabhakar, Building with CONFIG_VIDEO_DAVINCI_VPBE_DISPLAY=m in latest mainline gives the error: MODPOST 130 modules drivers/media/platform/davinci/vpbe_osd: struct platform_device_id is 24 bytes. The last of 3

[PATCH v2] davinci: vpif: Fix module build for capture and display

2013-03-08 Thread Prabhakar lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com export the symbols which are used by two modules vpif_capture and vpif_display. This patch fixes following error: ERROR: ch_params [drivers/media/platform/davinci/vpif_display.ko] undefined! ERROR: vpif_ch_params_count

Re: [PATCH 1/1] [media] davinci_vpfe: Use module_platform_driver macro

2013-03-07 Thread Prabhakar Lad
Hi Sachin, On Thu, Mar 7, 2013 at 1:36 PM, Sachin Kamat sachin.ka...@linaro.org wrote: Hi Prabhakar, BTW, who is supposed to pick this patch? I'll queue it for 3.10 and a issue a pull request to Mauro soon. Or if you have a branch and want to issue a pull no problem(anyways I have Acked

Re: [PATCH] media: davinci: kconfig: fix incorrect selects

2013-03-07 Thread Prabhakar Lad
Hi Sekhar, On Thu, Mar 7, 2013 at 4:54 PM, Sekhar Nori nsek...@ti.com wrote: On 3/7/2013 12:47 PM, Prabhakar Lad wrote: On Wed, Mar 6, 2013 at 7:51 PM, Sekhar Nori nsek...@ti.com wrote: So instead of presenting a non-useful vpif selection to users, vpif.c dependency is better handled

Re: [PATCH] media: davinci: kconfig: fix incorrect selects

2013-03-06 Thread Prabhakar Lad
' and 'MACH_DAVINCI_DA850_EVM' dependency from VIDEO_DAVINCI_VPIF_DISPLAY and VIDEO_DAVINCI_VPIF_CAPTURE. So it would be just 'depends on VIDEO_DEV VIDEO_DAVINCI_VPIF' BTW this patch doesn’t apply on3.9.0-rc1. Regards, --Prabhakar Lad help Support for DaVinci VPIF Driver. @@ -56,8 +54,7

Re: [PATCH] media: davinci: kconfig: fix incorrect selects

2013-03-06 Thread Prabhakar Lad
Sekhar, On Wed, Mar 6, 2013 at 3:37 PM, Sekhar Nori nsek...@ti.com wrote: On 3/6/2013 2:59 PM, Prabhakar Lad wrote: config VIDEO_DAVINCI_VPIF_DISPLAY tristate DM646x/DA850/OMAPL138 EVM Video Display - depends on VIDEO_DEV (MACH_DAVINCI_DM6467_EVM || MACH_DAVINCI_DA850_EVM

Re: [PATCH] media: davinci: kconfig: fix incorrect selects

2013-03-06 Thread Prabhakar Lad
Sekhar, On Wed, Mar 6, 2013 at 3:46 PM, Prabhakar Lad prabhakar.cse...@gmail.com wrote: Sekhar, On Wed, Mar 6, 2013 at 3:37 PM, Sekhar Nori nsek...@ti.com wrote: On 3/6/2013 2:59 PM, Prabhakar Lad wrote: config VIDEO_DAVINCI_VPIF_DISPLAY tristate DM646x/DA850/OMAPL138 EVM Video

Re: [PATCH] media: davinci: kconfig: fix incorrect selects

2013-03-06 Thread Prabhakar Lad
On Wed, Mar 6, 2013 at 3:53 PM, Sekhar Nori nsek...@ti.com wrote: On 3/6/2013 3:46 PM, Prabhakar Lad wrote: Sekhar, On Wed, Mar 6, 2013 at 3:37 PM, Sekhar Nori nsek...@ti.com wrote: On 3/6/2013 2:59 PM, Prabhakar Lad wrote: config VIDEO_DAVINCI_VPIF_DISPLAY tristate DM646x/DA850

[PATCH] davinci: vpif: Fix module build for capture and display

2013-03-06 Thread Prabhakar lad
From: Lad, Prabhakar prabhakar@ti.com export the symbols which are used by two modules vpif_capture and vpif_display. This patch fixes following error: ERROR: ch_params [drivers/media/platform/davinci/vpif_display.ko] undefined! ERROR: vpif_ch_params_count

Re: [PATCH] media: davinci: kconfig: fix incorrect selects

2013-03-06 Thread Prabhakar Lad
Sekhar, On Wed, Mar 6, 2013 at 7:51 PM, Sekhar Nori nsek...@ti.com wrote: On 3/6/2013 4:05 PM, Prabhakar Lad wrote: On Wed, Mar 6, 2013 at 3:53 PM, Sekhar Nori nsek...@ti.com wrote: On 3/6/2013 3:46 PM, Prabhakar Lad wrote: Sekhar, On Wed, Mar 6, 2013 at 3:37 PM, Sekhar Nori nsek...@ti.com

Re: [PATCH 1/1] [media] davinci_vpfe: Use module_platform_driver macro

2013-03-06 Thread Prabhakar Lad
Hi Sachin, On Thu, Mar 7, 2013 at 12:46 PM, Sachin Kamat sachin.ka...@linaro.org wrote: On 5 March 2013 17:46, Prabhakar Lad prabhakar.cse...@gmail.com wrote: Hi Sachin, Thanks for the patch! On Tue, Mar 5, 2013 at 5:22 PM, Sachin Kamat sachin.ka...@linaro.org wrote: module_platform_driver

Re: [PATCH 1/1] [media] davinci_vpfe: Use module_platform_driver macro

2013-03-05 Thread Prabhakar Lad
Regards, --Prabhakar Lad --- .../staging/media/davinci_vpfe/vpfe_mc_capture.c | 20 +--- 1 files changed, 1 insertions(+), 19 deletions(-) diff --git a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c index 7b35171

Re: [REVIEW PATCH 09/11] davinci/vpfe_capture: remove current_norm

2013-03-04 Thread Prabhakar Lad
hans.verk...@cisco.com Acked-by: Lad, Prabhakar prabhakar@ti.com Regards, --Prabhakar Lad --- drivers/media/platform/davinci/vpfe_capture.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/davinci/vpfe_capture.c b/drivers/media/platform/davinci/vpfe_capture.c index

Re: [REVIEW PATCH 07/11] davinci/vpfe_capture: convert to the control framework.

2013-03-04 Thread Prabhakar Lad
Hi Hans, On Mon, Mar 4, 2013 at 2:35 PM, Hans Verkuil hverk...@xs4all.nl wrote: From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Lad, Prabhakar prabhakar@ti.com Regards, --Prabhakar Lad --- drivers/media/platform/davinci

Re: [REVIEW PATCH 08/11] davinci/vpbe_display: remove deprecated current_norm.

2013-03-04 Thread Prabhakar Lad
...@cisco.com Acked-by: Lad, Prabhakar prabhakar@ti.com Regards, --Prabhakar Lad --- drivers/media/platform/davinci/vpbe_display.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/media/platform/davinci/vpbe_display.c b/drivers/media/platform/davinci

Re: [REVIEW PATCH 10/11] davinci/dm644x_ccdc: fix compiler warning

2013-03-04 Thread Prabhakar Lad
ccdc_gama_width’ and ‘enum ccdc_data_size’ [-Wenum-compare] please refer this discussion [1], where Mauro has suggested few options for fixing it. Regards, --Prabhakar Lad [1] https://patchwork.kernel.org/patch/1923091/ Signed-off-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media

Re: [REVIEW PATCH 10/11] davinci/dm644x_ccdc: fix compiler warning

2013-03-04 Thread Prabhakar Lad
Hi Hans, On Mon, Mar 4, 2013 at 3:06 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Mon March 4 2013 10:29:26 Prabhakar Lad wrote: Hi Hans, On Mon, Mar 4, 2013 at 2:35 PM, Hans Verkuil hverk...@xs4all.nl wrote: From: Hans Verkuil hans.verk...@cisco.com drivers/media/platform/davinci

Re: [REVIEW PATCH 2/2] davinci: more gama - gamma typo fixes.

2013-03-04 Thread Prabhakar Lad
Hi Hans, Thanks for the patch! On Mon, Mar 4, 2013 at 4:49 PM, Hans Verkuil hverk...@xs4all.nl wrote: From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Lad, Prabhakar prabhakar@ti.com Regards, --Prabhakar Lad --- drivers/media

Re: [REVIEW PATCH 1/2] davinci/dm644x_ccdc: fix compiler warning

2013-03-04 Thread Prabhakar Lad
of the code the same (except for fixing the 'gama' typo). Signed-off-by: Hans Verkuil hans.verk...@cisco.com Acked-by: Lad, Prabhakar prabhakar@ti.com Regards, --Prabhakar Lad --- drivers/media/platform/davinci/dm644x_ccdc.c | 13 ++- drivers/media/platform/davinci

[PATCH v4] media: ths7353: add support for ths7353 video amplifier

2013-02-18 Thread Prabhakar lad
From: Lad, Prabhakar prabhakar@ti.com The patch adds support for THS7353 video amplifier. The the THS7353 amplifier is very much similar to the existing THS7303 video amplifier driver. This patch appropriately makes changes to the existing ths7303 driver and adds support for the THS7353. This

Re: [RFC PATCH 04/18] davinci_vpfe: fix copy-paste errors in several comments.

2013-02-16 Thread Prabhakar Lad
: Prabhakar Lad prabhakar.cse...@gmail.com Acked-by: Lad, Prabhakar prabhakar@ti.com Regards, --Prabhakar --- drivers/staging/media/davinci_vpfe/vpfe_video.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c b

Re: [RFC PATCH 05/18] davinci: remove VPBE_ENC_DV_PRESET and rename VPBE_ENC_CUSTOM_TIMINGS

2013-02-16 Thread Prabhakar Lad
is renamed to VPBE_ENC_DV_TIMINGS since the old CUSTOM_TIMINGS name is deprecated in favor of DV_TIMINGS. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Prabhakar Lad prabhakar.cse...@gmail.com Acked-by: Lad, Prabhakar prabhakar@ti.com Regards, --Prabhakar --- arch/arm/mach

Re: [RFC PATCH 06/18] davinci: replace V4L2_OUT_CAP_CUSTOM_TIMINGS by V4L2_OUT_CAP_DV_TIMINGS

2013-02-16 Thread Prabhakar Lad
instead. Note that V4L2_OUT_CAP_CUSTOM_TIMINGS is just a #define for V4L2_OUT_CAP_DV_TIMINGS. At some point in the future these CUSTOM_TIMINGS defines might be removed. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Prabhakar Lad prabhakar.cse...@gmail.com Acked-by: Lad, Prabhakar

Re: [RFC PATCH 01/18] tvp7002: replace 'preset' by 'timings' in various structs/variables.

2013-02-16 Thread Prabhakar Lad
Hi Hans, On Sat, Feb 16, 2013 at 2:58 PM, Hans Verkuil hverk...@xs4all.nl wrote: From: Hans Verkuil hans.verk...@cisco.com This is the first step towards removing the deprecated preset support of this driver. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Prabhakar Lad

Re: [RFC PATCH 03/18] tvp7002: remove dv_preset support.

2013-02-16 Thread Prabhakar Lad
ops were no longer called and can be removed safely. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Prabhakar Lad prabhakar.cse...@gmail.com Acked-by: Lad, Prabhakar prabhakar@ti.com Regards, --Prabhakar --- drivers/media/i2c/tvp7002.c | 70

Re: [RFC PATCH 02/18] tvp7002: use dv_timings structs instead of presets.

2013-02-16 Thread Prabhakar Lad
and functions. This is the second step towards removing the deprecated preset support of this driver. Signed-off-by: Hans Verkuil hans.verk...@cisco.com Cc: Prabhakar Lad prabhakar.cse...@gmail.com Acked-by: Lad, Prabhakar prabhakar@ti.com Regards, --Prabhakar --- drivers/media/i2c/tvp7002.c

Re: [PATCH 9/9] [media] davinci: do not include mach/hardware.h

2013-02-14 Thread Prabhakar Lad
Hi Arnd, Thanks for the patch. On Fri, Feb 15, 2013 at 4:17 AM, Arnd Bergmann a...@arndb.de wrote: It is now possible to build the davinci vpss code on multiplatform kernels, which causes a problem since the driver tries to incude the davinci platform specific mach/hardware.h file.

Re: [PATCH v3] media: ths7353: add support for ths7353 video amplifier

2013-02-14 Thread Prabhakar Lad
Hi Mauro, Thanks for the review. On Thu, Feb 14, 2013 at 12:47 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em Thu, 7 Feb 2013 11:10:28 +0530 Prabhakar lad prabhakar.cse...@gmail.com escreveu: From: Lad, Prabhakar prabhakar@ti.com The patch adds support for THS7353 video

[GIT PULL FOR v3.9] media i2c feature enhancements

2013-02-10 Thread Prabhakar Lad
Hi Mauro, Please pull the following patches for media-i2c. The first patch adds support for ths7353 video amplifier, the second patch adds decoder as media entity and the third and fourth patch enables media controller support usage for tvp7002 and tvp514x respectively. Regards, --Prabhakar Lad

Re: [PATCH v2] media: add support for decoder as one of media entity types

2013-02-07 Thread Prabhakar Lad
Hi Sylwester, On Thu, Feb 7, 2013 at 5:18 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: Hi Prabhakar, On 01/28/2013 12:50 PM, Prabhakar Lad wrote: diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h index 0ef8833..dac06d7 100644 --- a/include/uapi/linux/media.h

[PATCH v3] media: add support for decoder as one of media entity types

2013-02-07 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com A lot of SOCs including Texas Instruments Davinci family mainly use video decoders as input devices. This patch adds a flag 'MEDIA_ENT_T_V4L2_SUBDEV_DECODER' media entity type for decoder's. Along side updates the documentation for this media entity

Re: [PATCH v2] media: ths7353: add support for ths7353 video amplifier

2013-02-06 Thread Prabhakar Lad
Hi Hans, Thanks for the review. On Wed, Feb 6, 2013 at 2:33 PM, Hans Verkuil hansv...@cisco.com wrote: Hi Prabhakar, Here is my review. There are a few things that need to be fixed before I can Ack it. OK On Tue 5 February 2013 20:20:21 Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar

[PATCH v3] media: ths7353: add support for ths7353 video amplifier

2013-02-06 Thread Prabhakar lad
From: Lad, Prabhakar prabhakar@ti.com The patch adds support for THS7353 video amplifier. The the THS7353 amplifier is very much similar to the existing THS7303 video amplifier driver. This patch appropriately makes changes to the existing ths7303 driver and adds support for the THS7353. This

Re: [PATCH] davinci: dm644x: fix enum ccdc_gama_width and enum ccdc_data_size comparision warning

2013-02-05 Thread Prabhakar Lad
Hi Mauro, On Tue, Feb 5, 2013 at 9:54 PM, Mauro Carvalho Chehab mche...@infradead.org wrote: Em Wed, 2 Jan 2013 17:23:50 +0530 Lad, Prabhakar prabhakar.cse...@gmail.com escreveu: while the effect is harmless this patch I disagree that this is a harmless warning. It is here for a reason:

[PATCH v2] media: ths7353: add support for ths7353 video amplifier

2013-02-05 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com The patch adds support for THS7353 video amplifier. The the THS7353 amplifier is very much similar to the existing THS7303 video amplifier driver. This patch appropriately makes changes to the existing ths7303 driver and adds support for the THS7353. This

Re: [PATCH RFC v2] media: tvp514x: add OF support

2013-02-03 Thread Prabhakar Lad
Hi Sylwester, Thanks for the review. On Sat, Feb 2, 2013 at 4:07 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: Hi Prabhakar, On 01/29/2013 02:07 PM, Prabhakar Lad wrote: [...] diff --git a/Documentation/devicetree/bindings/media/i2c/tvp514x.txt b/Documentation/devicetree

Re: [PATCH RFC v2] media: tvp514x: add OF support

2013-02-03 Thread Prabhakar Lad
Sekhar, On Sun, Feb 3, 2013 at 6:40 PM, Sekhar Nori nsek...@ti.com wrote: On 2/3/2013 3:43 PM, Prabhakar Lad wrote: Hi Sylwester, Thanks for the review. On Sat, Feb 2, 2013 at 4:07 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: Hi Prabhakar, On 01/29/2013 02:07 PM, Prabhakar

Re: [PATCH RFC v2] media: tvp514x: add OF support

2013-02-03 Thread Prabhakar Lad
Hi Laurent, On Sun, Feb 3, 2013 at 6:44 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Prabhakar, On Sunday 03 February 2013 15:43:49 Prabhakar Lad wrote: On Sat, Feb 2, 2013 at 4:07 AM, Sylwester Nawrocki wrote: On 01/29/2013 02:07 PM, Prabhakar Lad wrote

Re: [PATCH RFC v2] media: tvp514x: add OF support

2013-02-03 Thread Prabhakar Lad
Hi Sylwester, On Sun, Feb 3, 2013 at 6:57 PM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: Hi Prabhakar, On 02/03/2013 11:13 AM, Prabhakar Lad wrote: [...] +Required Properties : +- compatible: Must be ti,tvp514x-decoder There are no significant differences among TVP514

[QUERY] V4L async api

2013-01-30 Thread Prabhakar Lad
Hi Guennadi, I am working on adding v4l-asyn for capture and display device.. Here is my hw details:-- 1: The capture device has two subdevs tvp514x @0x5c and tvp514x @0x5d. 2: The display device has a one subdev adv7343 @0x2a. Note:- I have added async support for all the subdevices and the

Re: [FYI PATCH] Cisco's ths7353 driver...

2013-01-29 Thread Prabhakar Lad
Hi Hans, On Fri, Jan 25, 2013 at 5:27 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Prabhakar, As mentioned in my review of your ths7353 driver we (Cisco) have a driver for this device as well. Below is our driver so you can take the best bits of both. Thanks for sharing the patch.

[PATCH RFC v2] media: tvp514x: add OF support

2013-01-29 Thread Prabhakar Lad
/tvp514x.c @@ -12,6 +12,7 @@ * Hardik Shah hardik.s...@ti.com * Manjunath Hadli m...@ti.com * Karicheri Muralidharan m-kariche...@ti.com + * Prabhakar Lad prabhakar@ti.com * * This package is free software; you can redistribute it and/or modify * it under the terms of the GNU

[GIT PULL for v3.8-rc] DaVinci media fixes for v3.8

2013-01-23 Thread Prabhakar Lad
Hi Mauro, Please pull the following patches which fixes display on DA850 EVM . To avoid conflicts I have included a arm patch, which has been Acked by its maintainer. Fixes : - adv7343 encoder: fix configuring the encoder. - da850: pass data for adv7343 encoder for required

Re: [PATCH] media: adv7343: accept configuration through platform data

2013-01-21 Thread Prabhakar Lad
Hi Hans, Thanks for the review! On Mon, Jan 21, 2013 at 3:31 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Tue January 15 2013 09:00:53 Lad, Prabhakar wrote: The current code was implemented with some default configurations, this default configuration works on board and doesn't work on other.

[GIT PULL FOR v3.9] media i2c devices trivial fixes

2013-01-15 Thread Prabhakar Lad
Hi Mauro, Please pull the following patches, which use devm_kzalloc() instead of kzalloc(). Regards, --Prabhakar Lad The following changes since commit 3151d14aa6e983aa36d51a80d0477859f9ba12af: [media] media: remove __dev* annotations (2013-01-11 13:03:24 -0200) are available in the git

[GIT PULL FOR v3.9] Davinci media trivial fixes

2013-01-15 Thread Prabhakar Lad
Hi Mauro, Please pull the following patches for DaVinci media, fixing trivial issues. Regards, --Prabhakar Lad The following changes since commit 3151d14aa6e983aa36d51a80d0477859f9ba12af: [media] media: remove __dev* annotations (2013-01-11 13:03:24 -0200) are available in the git

Re: [PATCH RFC 1/3] davinci: vpif: capture: add V4L2-async support

2013-01-09 Thread Prabhakar Lad
Hi Hans, Thanks for the review! On Wed, Jan 9, 2013 at 9:12 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Wed 9 January 2013 14:41:25 Lad, Prabhakar wrote: Add support for asynchronous subdevice probing, using the v4l2-async API. The legacy synchronous mode is still supported too, which

Re: [PATCH 1/6 v5] media: V4L2: support asynchronous subdevice registration

2013-01-09 Thread Prabhakar Lad
video subsystem configuration from its callbacks. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de Tested-by: Lad, Prabhakar prabhakar@ti.com Regards, --Prabhakar Lad --- v5: Now really fix the case, when subdevices probe successfully before the bridge, thanks to Prabhakar

Re: Status of the patches under review at LMML (35 patches)

2013-01-07 Thread Prabhakar Lad
Hi Laurent, On Mon, Jan 7, 2013 at 5:43 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Prabhakar, On Monday 07 January 2013 11:26:01 Prabhakar Lad wrote: On Sun, Jan 6, 2013 at 7:04 PM, Mauro Carvalho Chehab wrote: This is the summary of the patches that are currently

Re: [PATCH] [media] davinci: vpbe: fix missing unlock on error in vpbe_initialize()

2013-01-06 Thread Prabhakar Lad
Acked-by: Prabhakar Lad prabhakar@ti.com --- no test --- drivers/media/platform/davinci/vpbe.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/davinci/vpbe.c b/drivers/media/platform/davinci/vpbe.c index 69d7a58..875e63d 100644

Re: Status of the patches under review at LMML (35 patches)

2013-01-06 Thread Prabhakar Lad
) and the patchwork link (if submitted via email). Snip == Prabhakar Lad prabhakar@ti.com == Aug,24 2012: Corrected Oops on omap_vout when no manager is connected http://patchwork.linuxtv.org/patch/14033 Federico Fuga f...@studiofuga.com Tomi can you take care

Re: DT bindings for subdevices

2013-01-04 Thread Prabhakar Lad
Hi Guennadi, On Wed, Jan 2, 2013 at 3:49 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Hi Prabhakar On Wed, 2 Jan 2013, Prabhakar Lad wrote: Hi, This is my first step towards DT support for media, Question might be bit amateur :) No worries, we're all doing our first steps

Re: [PATCH] tvp7002: use devm_kzalloc() instead of kzalloc()

2013-01-03 Thread Prabhakar Lad
Hi Laurent, Thanks for the quick review! On Thu, Jan 3, 2013 at 7:02 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: On Thursday 03 January 2013 14:31:20 Laurent Pinchart wrote: On Thursday 03 January 2013 18:52:42 Lad, Prabhakar wrote: I2C drivers can use devm_kzalloc() too in

Re: DT bindings for subdevices

2013-01-02 Thread Prabhakar Lad
Hi Guennadi, Thanks for your response! On Wed, Jan 2, 2013 at 3:49 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Hi Prabhakar On Wed, 2 Jan 2013, Prabhakar Lad wrote: Hi, This is my first step towards DT support for media, Question might be bit amateur :) No worries, we're all

[GIT PULL FOR v3.9] Davinci VPFE Media Controller capture driver for DM365

2012-12-21 Thread Prabhakar Lad
Hi Mauro, Please pull the following patches for DaVinci VPFE driver for DM365. The patches have gone through good amount of reviews, and Acked by Laurent, Hans and Sakari and is agreed to be part of the staging. Regards, --Prabhakar The following changes since commit

[GIT PULL FOR v3.9] Davinci VPBE Trivial Fixes

2012-12-21 Thread Prabhakar Lad
Hi Mauro, Please pull the following patches for DaVinci VPBE driver. One of the patch has ARM changes and is Acked-by the ARM maintainer. Thanks and Regards, --Prabhakar Lad The following changes since commit 4bb891ebf60eb43ebd04e09bbcad24013067873f: [media] ivtv: ivtv-driver: Replace

[GIT PULL FOR v3.9] Davinci VPSS Updates

2012-12-20 Thread Prabhakar Lad
Hi Mauro, Please pull the following patches for DaVinci VPSS driver. These patches have undergone under enormous reviews and are ready to be queued. Thanks and Regards, --Prabhakar Lad The following changes since commit 4bb891ebf60eb43ebd04e09bbcad24013067873f: [media] ivtv: ivtv-driver

Re: [PATCH RFC v2] media: v4l2-ctrl: Add gain controls

2012-12-11 Thread Prabhakar Lad
Hi Hans, On Tue, Dec 11, 2012 at 2:26 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Thu 6 December 2012 10:54:32 Sakari Ailus wrote: Hi Prabhakar and Hans, On Thu, Dec 06, 2012 at 10:24:18AM +0530, Prabhakar Lad wrote: Hi Hans, On Wed, Dec 5, 2012 at 5:38 PM, Hans Verkuil hverk

Re: [PATCH 2/5] media: davinci: fix return value check in vpbe_display_reqbufs().

2012-12-11 Thread Prabhakar Lad
/patch/1830231/ Regards, --Prabhakar Lad Signed-off-by: Cyril Roelandt tipec...@gmail.com --- drivers/media/platform/davinci/vpbe_display.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/davinci/vpbe_display.c b/drivers/media/platform/davinci

[PATCH RFC v2] media: v4l2-ctrl: Add gain controls

2012-12-05 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com add support for per color component digital/analog gain controls and also their corresponding offset. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cc: Sakari Ailus sakari.ai...@iki.fi Cc: Laurent Pinchart

Re: [PATCH RFC v2] media: v4l2-ctrl: Add gain controls

2012-12-05 Thread Prabhakar Lad
Hi Hans, On Wed, Dec 5, 2012 at 5:38 PM, Hans Verkuil hverk...@xs4all.nl wrote: (resend without HTML formatting) On Wed 5 December 2012 12:49:29 Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com add support for per color component digital/analog gain controls and also

Re: [PATCH 444/493] media: remove use of __devexit

2012-12-05 Thread Prabhakar Lad
+- drivers/media/platform/davinci/vpss.c| 2 +- Acked-by: Prabhakar Lad prabhakar@ti.com Regards, --Prabhakar [snip] -- 1.8.0 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 234/493] media: remove use of __devinit

2012-12-05 Thread Prabhakar Lad
+- drivers/media/platform/davinci/vpss.c | 2 +- Acked-by: Prabhakar Lad prabhakar@ti.com Regards, --Prabhakar -- 1.8.0 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH -next] [media] davinci: vpbe: remove unused variable in vpbe_initialize()

2012-12-02 Thread Prabhakar Lad
...@trendmicro.com.cn Acked-by: Prabhakar Lad prabhakar@ti.com Regards, --Prabhakar --- drivers/media/platform/davinci/vpbe.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platform/davinci/vpbe.c b/drivers/media/platform/davinci/vpbe.c index 7f5cf9b..e0c79c1 100644

Re: [PATCH -next] [media] media: davinci: vpbe: return error code on error in vpbe_display_g_crop()

2012-12-02 Thread Prabhakar Lad
-by: Wei Yongjun yongjun_...@trendmicro.com.cn Acked-by: Prabhakar Lad prabhakar@ti.com Regards, --Prabhakar --- drivers/media/platform/davinci/vpbe_display.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/platform/davinci/vpbe_display.c b/drivers/media

Re: [PATCH -next] [media] media: davinci: vpbe: fix return value check in vpbe_display_reqbufs()

2012-12-02 Thread Prabhakar Lad
(). Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn Acked-by: Prabhakar Lad prabhakar@ti.com Regards, --Prabhakar --- drivers/media/platform/davinci/vpbe_display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/davinci

[PATCH v4 0/3] Davinci VPSS helper functions for VPFE

2012-11-30 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com This patch series adds helper functions and enables the VPSS and ISP registers required for VPFE to work. Changes for v4: 1: Fixed review comment from Sakari. Manjunath Hadli (3): davinci: vpss: dm365: enable ISP registers davinci: vpss: dm365: set

[PATCH v4 1/3] davinci: vpss: dm365: enable ISP registers

2012-11-30 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com enable the clocks required for VPFE to work in PCCR register, and enbale ISIF out on BCR to get the correct operation from ISIF. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com ---

[PATCH v4 2/3] davinci: vpss: dm365: set vpss clk ctrl

2012-11-30 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com request_mem_region for VPSS_CLK_CTRL register and ioremap. and enable clocks appropriately. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com --- drivers/media/platform/davinci/vpss.c | 15

[PATCH v4 3/3] davinci: vpss: dm365: add vpss helper functions to be used in the main driver for setting hardware parameters

2012-11-30 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com add interface functions to set sync polarity, interrupt completion and pageframe size in vpss to be used by the main driver. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com ---

[PATCH v4 0/9] Media Controller capture driver for DM365

2012-11-30 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com The below series of patches have gone through good amount of reviews, and agreed by Laurent, Hans and Sakari to be part of the staging tree. This patch set adds media controller based capture driver for DM365. This driver bases its design on Laurent

[PATCH v4 2/9] davinci: vpfe: add v4l2 video driver support

2012-11-30 Thread Prabhakar Lad
+ * Prabhakar Lad prabhakar@ti.com + */ + +#include linux/module.h +#include linux/slab.h + +#include media/v4l2-ioctl.h + +#include vpfe.h +#include vpfe_mc_capture.h + +/* minimum number of buffers needed in cont-mode */ +#define MIN_NUM_BUFFERS3 + +static int

[PATCH v4 3/9] davinci: vpfe: dm365: add IPIPEIF driver based on media framework

2012-11-30 Thread Prabhakar Lad
General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * Contributors: + * Manjunath Hadli manjunath.ha...@ti.com + * Prabhakar Lad prabhakar@ti.com + */ + +#include

[PATCH v4 6/9] davinci: vpfe: dm365: add IPIPE hardware layer support

2012-11-30 Thread Prabhakar Lad
; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * Contributors: + * Manjunath Hadli manjunath.ha...@ti.com + * Prabhakar Lad prabhakar@ti.com + */ + +#include dm365_ipipe_hw.h + +#define IPIPE_MODE_CONTINUOUS 0

[PATCH v4 8/9] davinci: vpfe: dm365: add build infrastructure for capture driver

2012-11-30 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com add build infrastructure for dm365 specific modules for VPFE capture driver. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com

[PATCH v4 9/9] davinci: vpfe: Add documentation and TODO

2012-11-30 Thread Prabhakar Lad
/null +++ b/drivers/staging/media/davinci_vpfe/davinci-vpfe-mc.txt @@ -0,0 +1,154 @@ +Davinci Video processing Front End (VPFE) driver + +Copyright (C) 2012 Texas Instruments Inc + +Contacts: Manjunath Hadli manjunath.ha...@ti.com + Prabhakar Lad prabhakar@ti.com + + +Introduction

Re: [PATCH] [media] v4l: Add mt9v034 sensor driver

2012-11-29 Thread Prabhakar Lad
+ */ + +#define V4L2_CID_TEST_PATTERN (V4L2_CID_USER_BASE | 0x1001) + Now this is a standard control. Refer mt9p031/mt9t001/mt9v032 driver's for usage. Regards, --Prabhakar Lad +static int mt9v034_s_ctrl(struct v4l2_ctrl *ctrl) +{ + struct mt9v034 *mt9v034

[PATCH v3 0/9] Media Controller capture driver for DM365

2012-11-28 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com Mauro/Greg, The below series of patches have gone through good amount of reviews, and agreed by Laurent, Hans and Sakari to be part of the staging tree. I am combining the patchs with the pull request so we can get them into the 3.8 kernel. Please

[PATCH v3 2/9] davinci: vpfe: add v4l2 video driver support

2012-11-28 Thread Prabhakar Lad
Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * Contributors: + * Manjunath Hadli manjunath.ha...@ti.com + * Prabhakar Lad prabhakar@ti.com + */ + +#include linux/module.h +#include linux/slab.h + +#include media/v4l2-ioctl.h + +#include vpfe.h

[PATCH v3 3/9] davinci: vpfe: dm365: add IPIPEIF driver based on media framework

2012-11-28 Thread Prabhakar Lad
02111-1307 USA + * + * Contributors: + * Manjunath Hadli manjunath.ha...@ti.com + * Prabhakar Lad prabhakar@ti.com + */ + +#include dm365_ipipeif.h +#include vpfe_mc_capture.h + +static const unsigned int ipipeif_input_fmts[] = { + V4L2_MBUS_FMT_UYVY8_2X8

[PATCH v3 8/9] davinci: vpfe: dm365: add build infrastructure for capture driver

2012-11-28 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com add build infrastructure for dm365 specific modules for VPFE capture driver. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com --- drivers/staging/media/Kconfig |2 ++

[PATCH v3 9/9] davinci: vpfe: Add documentation and TODO

2012-11-28 Thread Prabhakar Lad
@@ +Davinci Video processing Front End (VPFE) driver + +Copyright (C) 2012 Texas Instruments Inc + +Contacts: Manjunath Hadli manjunath.ha...@ti.com + Prabhakar Lad prabhakar@ti.com + + +Introduction + + +This file documents the Texas Instruments Davinci Video processing Front

[PATCH v3 6/9] davinci: vpfe: dm365: add IPIPE hardware layer support

2012-11-28 Thread Prabhakar Lad
manjunath.ha...@ti.com + * Prabhakar Lad prabhakar@ti.com + */ + +#include dm365_ipipe_hw.h + +#define IPIPE_MODE_CONTINUOUS 0 +#define IPIPE_MODE_SINGLE_SHOT 1 + +static void ipipe_clock_enable(void *__iomem base_addr) +{ + /* enable IPIPE MMR for register write

[PATCH v3 3/3] davinci: vpss: dm365: add vpss helper functions to be used in the main driver for setting hardware parameters

2012-11-28 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com add interface functions to set sync polarity, interrupt completion and pageframe size in vpss to be used by the main driver. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com ---

[PATCH v3 0/3] Davinci VPSS helper functions for VPFE

2012-11-28 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com Hi Mauro, This patchset, was part of the DM365 capture driver series, I have split them up and made as separate series as the capture patches will now be going under staging and made as version V3. This patches have undergone several reviews along

[PATCH v3 1/3] davinci: vpss: dm365: enable ISP registers

2012-11-28 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com enable PPCR, enbale ISIF out on BCR and disable all events to get the correct operation from ISIF. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com --- drivers/media/platform/davinci/vpss.c |

[PATCH v3 2/3] davinci: vpss: dm365: set vpss clk ctrl

2012-11-28 Thread Prabhakar Lad
From: Manjunath Hadli manjunath.ha...@ti.com request_mem_region for VPSS_CLK_CTRL register and ioremap. and enable clocks appropriately. Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Lad, Prabhakar prabhakar@ti.com --- drivers/media/platform/davinci/vpss.c | 14

[GIT PULL FOR v3.8] Mediabus And Pixel format supported by DM365

2012-11-28 Thread Prabhakar Lad
for the drivers using this formats http://patchwork.linuxtv.org/patch/15690/ . Thanks and Regards, --Prabhakar Lad The following changes since commit c6c22955f80f2db9614b01fe5a3d1cfcd8b3d848: [media] dma-mapping: fix dma_common_get_sgtable() conditional compilation (2012-11-27 09:42:31 -0200

[PATCH] media: davinci: vpbe: enable building of vpbe driver for DM355 and DM365

2012-11-28 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar@ti.com This patch allows enabling building of VPBE display driver for DM365 and DM355. This also removes unnecessary entry VIDEO_DM644X_VPBE in Kconfig, which could have been done with single entry, and appropriate changes in Makefile for building.

Re: [PATCH v3 2/3] davinci: vpss: dm365: set vpss clk ctrl

2012-11-28 Thread Prabhakar Lad
Hi Sakari, Thanks for the quick review. On Thu, Nov 29, 2012 at 1:48 AM, Sakari Ailus sakari.ai...@iki.fi wrote: Hi Prabhakar, On Wed, Nov 28, 2012 at 04:25:33PM +0530, Prabhakar Lad wrote: From: Manjunath Hadli manjunath.ha...@ti.com request_mem_region for VPSS_CLK_CTRL register

Re: [PATCH v3 1/3] davinci: vpss: dm365: enable ISP registers

2012-11-28 Thread Prabhakar Lad
Hi Sakari, Thanks for the quick review. On Thu, Nov 29, 2012 at 1:38 AM, Sakari Ailus sakari.ai...@iki.fi wrote: On Wed, Nov 28, 2012 at 04:25:32PM +0530, Prabhakar Lad wrote: From: Manjunath Hadli manjunath.ha...@ti.com enable PPCR, enbale ISIF out on BCR and disable all events to get

Re: [PATCH v3 9/9] davinci: vpfe: Add documentation and TODO

2012-11-28 Thread Prabhakar Lad
wrote: Hi Prabhakar, Em Wed, 28 Nov 2012 16:12:09 +0530 Prabhakar Lad prabhakar.cse...@gmail.com escreveu: +Introduction + + + This file documents the Texas Instruments Davinci Video processing Front + End (VPFE) driver located under drivers/media/platform

Re: [PATCH] media: fix a typo CONFIG_HAVE_GENERIC_DMA_COHERENT in videobuf2-dma-contig.c

2012-11-27 Thread Prabhakar Lad
Hi, On Tue, Nov 27, 2012 at 1:21 PM, Marek Szyprowski m.szyprow...@samsung.com wrote: Hello, On 11/27/2012 8:39 AM, Prabhakar Lad wrote: Hi Marek, On Tue, Nov 27, 2012 at 12:53 PM, Marek Szyprowski m.szyprow...@samsung.com wrote: Hello, On 11/27/2012 6:59 AM, Prabhakar Lad wrote

Re: [PATCH] media: fix a typo CONFIG_HAVE_GENERIC_DMA_COHERENT in videobuf2-dma-contig.c

2012-11-26 Thread Prabhakar Lad
*/ /*/ -#ifdef HAVE_GENERIC_DMA_COHERENT +#ifdef CONFIG_HAVE_GENERIC_DMA_COHERENT struct vb2_dc_attachment { struct sg_table sgt; Regards, --Prabhakar Thank you, Kyungmin Park On 11/27/12, Prabhakar Lad prabhakar.cse...@gmail.com wrote: From: Lad, Prabhakar prabhakar@ti.com from

Re: [PATCH] media: fix a typo CONFIG_HAVE_GENERIC_DMA_COHERENT in videobuf2-dma-contig.c

2012-11-26 Thread Prabhakar Lad
Hi Marek, On Tue, Nov 27, 2012 at 12:53 PM, Marek Szyprowski m.szyprow...@samsung.com wrote: Hello, On 11/27/2012 6:59 AM, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar@ti.com from commit 93049b9368a2e257ace66252ab2cc066f3399cad, which adds a check HAVE_GENERIC_DMA_COHERENT

Re: [PATCH v2 00/12] Media Controller capture driver for DM365

2012-11-25 Thread Prabhakar Lad
Hi, On Fri, Nov 23, 2012 at 7:31 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Fri November 23 2012 14:57:53 Sakari Ailus wrote: Hi Prabhakar, On Fri, Nov 23, 2012 at 06:51:28PM +0530, Prabhakar Lad wrote: Hi Sakari, On Fri, Nov 23, 2012 at 6:43 PM, Sakari Ailus sakari.ai...@iki.fi

Re: [PATCH v2 00/12] Media Controller capture driver for DM365

2012-11-25 Thread Prabhakar Lad
HI Sakari, On Mon, Nov 26, 2012 at 5:58 AM, Sakari Ailus sakari.ai...@iki.fi wrote: Hi Prabhakar, On Sun, Nov 25, 2012 at 09:57:23PM +0530, Prabhakar Lad wrote: On Fri, Nov 23, 2012 at 7:31 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Fri November 23 2012 14:57:53 Sakari Ailus wrote

Re: [PATCH v2 00/12] Media Controller capture driver for DM365

2012-11-23 Thread Prabhakar Lad
Hi Sakari, On Fri, Nov 23, 2012 at 6:43 PM, Sakari Ailus sakari.ai...@iki.fi wrote: Hi Prabhakar and others, (Just resending; Laurent's e-mail address corrected, cc Hans, too.) On Fri, Nov 16, 2012 at 08:15:02PM +0530, Prabhakar Lad wrote: From: Manjunath Hadli manjunath.ha...@ti.com

Re: [PATCH 133/493] remove use of __devexit_p

2012-11-22 Thread Prabhakar Lad
/vpss.c| 2 +- Acked-by: Prabhakar Lad prabhakar@ti.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

<    1   2   3   4   5   6   7   >