From: Markus Elfring
Date: Mon, 18 Sep 2017 17:47:58 +0200
Omit extra messages for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Mon, 18 Sep 2017 14:35:43 +0200
The variable "ret" will eventually be set to an appropriate value
a bit later. Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Mon, 18 Sep 2017 14:28:59 +0200
Add jump targets so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
From: Markus Elfring
Date: Mon, 18 Sep 2017 13:50:45 +0200
Adjust jump targets so that a bit of exception handling can be better
reused at the end of this function.
This refactoring might fix also an error situation where the
function "i2c_unregister_device" was
From: Markus Elfring
Date: Mon, 18 Sep 2017 11:27:30 +0200
Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style
From: Markus Elfring
Date: Mon, 18 Sep 2017 11:13:27 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written …
Thus
From: Markus Elfring
Date: Mon, 18 Sep 2017 10:52:42 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Mon, 18 Sep 2017 14:54:32 +0200
Some update suggestions were taken into account
from static source code analysis.
Markus Elfring (6):
Delete an error message for a failed memory allocation in
go7007_load_encoder()
Adjust 35 checks
From: Markus Elfring
Date: Mon, 18 Sep 2017 09:36:33 +0200
Replace the specification of data structures by variable references
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style
From: Markus Elfring
Date: Mon, 18 Sep 2017 09:25:19 +0200
Omit extra messages for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Mon, 18 Sep 2017 09:51:23 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete two error messages for a failed memory allocation in dvb_usbv2_probe()
Improve a size
From: Markus Elfring
Date: Sun, 17 Sep 2017 21:07:39 +0200
Add jump targets so that a bit of exception handling can be better reused
at the end of this function.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Sun, 17 Sep 2017 20:22:15 +0200
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
From: Markus Elfring
Date: Sun, 17 Sep 2017 20:28:00 +0200
The local variable "ret" will be set to an appropriate value a bit later.
Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Sun, 17 Sep 2017 20:10:34 +0200
Add jump targets so that a bit of exception handling can be better reused
at the end of this function.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Sun, 17 Sep 2017 18:53:16 +0200
The variable "result" will eventually be set to an appropriate value
a bit later. Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Sun, 17 Sep 2017 18:38:50 +0200
Replace the specification of data structures by variable references
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style
From: Markus Elfring
Date: Sun, 17 Sep 2017 18:23:06 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written …
Thus
From: Markus Elfring
Date: Sun, 17 Sep 2017 17:43:47 +0200
Omit extra messages for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Sun, 17 Sep 2017 21:30:12 +0200
Some update suggestions were taken into account
from static source code analysis.
Markus Elfring (8):
Delete eight error messages for a failed memory allocation
Adjust 56 checks for null pointers
From: Markus Elfring
Date: Sun, 17 Sep 2017 13:32:45 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: void function return statements are not generally useful
Thus remove such a statement in the affected function.
From: Markus Elfring
Date: Sun, 17 Sep 2017 13:23:47 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: kfree(NULL) is safe and this check is probably not required
Thus fix the affected source code place.
Signed-off-by: Markus
From: Markus Elfring
Date: Sun, 17 Sep 2017 12:56:50 +0200
The script "checkpatch.pl" pointed information out like the following.
ERROR: do not use assignment in if condition
Thus fix the affected source code places.
Signed-off-by: Markus Elfring
From: Markus Elfring
Date: Sun, 17 Sep 2017 12:40:14 +0200
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
From: Markus Elfring
Date: Sun, 17 Sep 2017 15:25:35 +0200
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (4):
Use common error handling code in cpia2_usb_probe()
Adjust two function calls together with a
From: Markus Elfring
Date: Sun, 17 Sep 2017 11:40:31 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Sun, 17 Sep 2017 11:03:21 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style
From: Markus Elfring
Date: Sun, 17 Sep 2017 11:00:09 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Sun, 17 Sep 2017 11:11:02 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination
From: Markus Elfring
Date: Sun, 17 Sep 2017 09:42:17 +0200
Replace the specification of data structures by variable references
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style
From: Markus Elfring
Date: Sun, 17 Sep 2017 09:33:58 +0200
* Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
* Add a jump target so that the function "kfree" will be always called
From: Markus Elfring
Date: Sun, 17 Sep 2017 10:03:45 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve three size determinations
From: Markus Elfring
Date: Sun, 17 Sep 2017 08:32:17 +0200
Replace the specification of data structures by variable references
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style
From: Markus Elfring
Date: Sun, 17 Sep 2017 08:20:04 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Sun, 17 Sep 2017 08:48:24 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination in two functions
From: Markus Elfring
Date: Sat, 16 Sep 2017 21:38:03 +0200
Replace the specification of data structures by variable references
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style
From: Markus Elfring
Date: Sat, 16 Sep 2017 21:24:27 +0200
* Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
* Add a jump target so that the function "kfree" will be always called
From: Markus Elfring
Date: Sat, 16 Sep 2017 21:48:45 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve three size determinations
From: Markus Elfring
Date: Sat, 16 Sep 2017 20:06:01 +0200
Replace the specification of data structures by variable references
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style
From: Markus Elfring
Date: Sat, 16 Sep 2017 19:40:47 +0200
* Omit extra messages for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
* Delete the label "err" and the variable "ret" which became unnecessary
From: Markus Elfring
Date: Sat, 16 Sep 2017 20:12:34 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete two error messages for a failed memory allocation
Improve three size determinations
From: Markus Elfring
Date: Sat, 16 Sep 2017 17:55:27 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style
From: Markus Elfring
Date: Sat, 16 Sep 2017 17:47:52 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Sat, 16 Sep 2017 18:03:21 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination
From: Markus Elfring
Date: Sat, 16 Sep 2017 16:15:44 +0200
Omit an extra message for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Sat, 16 Sep 2017 15:08:39 +0200
The variable "retval" will eventually be set to an appropriate value
a bit later. Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Sat, 16 Sep 2017 14:58:06 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style
From: Markus Elfring
Date: Sat, 16 Sep 2017 14:53:49 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Sat, 16 Sep 2017 15:16:17 +0200
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Delete an error message for a failed memory allocation
Improve a size determination
Delete an
From: Markus Elfring
Date: Sat, 16 Sep 2017 13:55:56 +0200
The local variable "r" will be set to an appropriate value a bit later.
Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Sat, 16 Sep 2017 13:53:22 +0200
* Remove an extra goto statement.
* Delete the label "out" which became unnecessary with this refactoring.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Sat, 16 Sep 2017 13:28:38 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Sat, 16 Sep 2017 14:05:45 +0200
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Delete an error message for a failed memory allocation
Delete an unnecessary goto statement
From: Markus Elfring
Date: Sat, 16 Sep 2017 11:39:50 +0200
The variable "retval" will eventually be set to an appropriate value
a bit later. Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Sat, 16 Sep 2017 11:34:11 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style
From: Markus Elfring
Date: Sat, 16 Sep 2017 11:23:53 +0200
Omit extra messages for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Sat, 16 Sep 2017 12:35:43 +0200
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Delete two error messages for a failed memory allocation
Improve a size determination
Delete an
From: Markus Elfring
Date: Sat, 16 Sep 2017 10:15:29 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Fri, 15 Sep 2017 22:23:42 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style
From: Markus Elfring
Date: Fri, 15 Sep 2017 22:20:04 +0200
Omit extra messages for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Fri, 15 Sep 2017 22:31:23 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete two error messages for a failed memory allocation
Improve a size determination
>> +memcpy(dcmi->sd_formats, sd_fmts, num_fmts * sizeof(*dcmi->sd_formats));
>
> devm_kmemdup
Are function variants provided which handle memory duplications
for arrays explicitly?
Regards,
Markus
From: Markus Elfring
Date: Fri, 15 Sep 2017 20:22:44 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written !…
Thus
From: Markus Elfring
Date: Fri, 15 Sep 2017 20:15:17 +0200
Omit an extra message for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Fri, 15 Sep 2017 20:30:40 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation in two functions
Adjust nine checks for null
From: Markus Elfring
Date: Fri, 15 Sep 2017 18:48:14 +0200
Replace the specification of data types by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style
From: Markus Elfring
Date: Fri, 15 Sep 2017 18:38:25 +0200
Omit an extra message for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Fri, 15 Sep 2017 19:01:23 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation in two functions
Improve four size
From: Markus Elfring
Date: Fri, 15 Sep 2017 17:30:38 +0200
Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style
From: Markus Elfring
Date: Fri, 15 Sep 2017 17:20:48 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Fri, 15 Sep 2017 17:55:43 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve two size determinations
From: Markus Elfring
Date: Fri, 15 Sep 2017 16:15:47 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Fri, 15 Sep 2017 08:02:33 +0200
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Fri, 15 Sep 2017 07:47:41 +0200
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Fri, 15 Sep 2017 07:33:24 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style
From: Markus Elfring
Date: Thu, 14 Sep 2017 16:26:42 +0200
Add a jump target so that a bit of exception handling can be better reused
in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
From: Markus Elfring
Date: Thu, 14 Sep 2017 16:13:56 +0200
The local variable "rc" will be set to an appropriate value a bit later.
Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Thu, 14 Sep 2017 16:11:55 +0200
* Adjust jump targets so that the function "kfree" will be always called
with a non-null pointer.
* Delete an initialisation for the local variable "dev"
which became unnecessary with this refactoring.
From: Markus Elfring
Date: Thu, 14 Sep 2017 16:00:47 +0200
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Thu, 14 Sep 2017 14:51:15 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written …
Thus
From: Markus Elfring
Date: Thu, 14 Sep 2017 14:34:39 +0200
Omit extra messages for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Fri, 15 Sep 2017 08:24:56 +0200
Some update suggestions were taken into account
from static source code analysis.
Markus Elfring (9):
Delete seven error messages for a failed memory allocation
Adjust seven checks for null pointers
From: Markus Elfring
Date: Wed, 13 Sep 2017 22:22:41 +0200
The script "checkpatch.pl" pointed information out like the following.
ERROR: space prohibited after that open parenthesis '('
Thus fix affected source code places.
Signed-off-by: Markus Elfring
From: Markus Elfring
Date: Wed, 13 Sep 2017 22:12:07 +0200
The script "checkpatch.pl" pointed information out like the following.
ERROR: spaces required around that '=' (ctx:VxV)
Thus fix the affected source code places.
Signed-off-by: Markus Elfring
From: Markus Elfring
Date: Wed, 13 Sep 2017 21:23:29 +0200
* Move the definition for the local variables "b", "d" and "length" into
an if branch so that the corresponding setting will only be performed
if a memory allocation succeeded in this function.
*
From: Markus Elfring
Date: Wed, 13 Sep 2017 20:32:25 +0200
Assign a pointer to a data structure member without using an intermediate
local variable.
Signed-off-by: Markus Elfring
---
drivers/media/usb/ttusb-dec/ttusb_dec.c | 6
From: Markus Elfring
Date: Wed, 13 Sep 2017 20:10:39 +0200
Omit an extra message for a memory allocation failure in this function.
Signed-off-by: Markus Elfring
---
drivers/media/usb/ttusb-dec/ttusb_dec.c | 4 +---
1 file changed,
From: Markus Elfring
Date: Wed, 13 Sep 2017 19:56:38 +0200
* The script "checkpatch.pl" pointed information out like the following.
ERROR: do not use assignment in if condition
Thus fix a few source code places.
* Replace the specification of data structures
From: Markus Elfring
Date: Wed, 13 Sep 2017 18:22:35 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written …
Thus
From: Markus Elfring
Date: Wed, 13 Sep 2017 18:08:19 +0200
Add jump targets so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
From: Markus Elfring
Date: Thu, 14 Sep 2017 12:26:24 +0200
Some update suggestions were taken into account
from static source code analysis.
Markus Elfring (8):
Use common error handling code in ttusb_dec_init_dvb()
Adjust five checks for null pointers
> Generating patch is only part of the story,
I can follow this view in principle.
> it seems the patch is not sent properly
I got an other impression.
> and tags which should be in SMTP header end up in the message body.
I agree that extra message fields were presented by the git software
>> * Do you care to preserve an information like the author date?
>
> In this case not, but actually the Date line is not an issue.
Thanks for your information.
It seems then that you quoted a line too much.
> Anyway the patch is malformed, …
I have got doubts for this view because the file
> Could you make the commit summary shorter, to keep it
> below 70 characters [1]? With that changed feel free to add
>
> Acked-by: Sylwester Nawrocki
…
> [1] Documentation/process/submitting-patches.rst
Will it be sufficient that a patch committer will adjust
the
>> Date: Fri, 8 Sep 2017 22:37:00 +0200
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>
> Can you resend with that 4 lines removed?
* Do you care to preserve an information like the author date?
* Would you like to support special characters
From: Markus Elfring
Date: Sat, 9 Sep 2017 22:07:04 +0200
Add jump targets so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
From: Markus Elfring
Date: Sat, 9 Sep 2017 21:48:58 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written !…
Thus
From: Markus Elfring
Date: Sat, 9 Sep 2017 21:30:11 +0200
Omit extra messages for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Sat, 9 Sep 2017 22:18:22 +0200
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Delete two error messages for a failed memory allocation
Adjust two null pointer checks
Use
From: Markus Elfring
Date: Sat, 9 Sep 2017 20:55:14 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written !…
Thus
101 - 200 of 516 matches
Mail list logo