[PATCH] [media] gspca: Delete two error messages for a failed memory allocation in gspca_dev_probe2()

2017-09-18 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 18 Sep 2017 17:47:58 +0200 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 6/6] [media] go7007: Delete an unnecessary variable initialisation in go7007_snd_init()

2017-09-18 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 18 Sep 2017 14:35:43 +0200 The variable "ret" will eventually be set to an appropriate value a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring ---

[PATCH 5/6] [media] go7007: Use common error handling code in go7007_snd_init()

2017-09-18 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 18 Sep 2017 14:28:59 +0200 Add jump targets so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 4/6] [media] go7007: Use common error handling code in s2250_probe()

2017-09-18 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 18 Sep 2017 13:50:45 +0200 Adjust jump targets so that a bit of exception handling can be better reused at the end of this function. This refactoring might fix also an error situation where the function "i2c_unregister_device" was

[PATCH 3/6] [media] go7007: Improve a size determination in four functions

2017-09-18 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 18 Sep 2017 11:27:30 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/6] [media] go7007: Adjust 35 checks for null pointers

2017-09-18 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 18 Sep 2017 11:13:27 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus

[PATCH 1/6] [media] go7007: Delete an error message for a failed memory allocation in go7007_load_encoder()

2017-09-18 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 18 Sep 2017 10:52:42 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/6] [media] Go7007: Adjustments for some function implementations

2017-09-18 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 18 Sep 2017 14:54:32 +0200 Some update suggestions were taken into account from static source code analysis. Markus Elfring (6): Delete an error message for a failed memory allocation in go7007_load_encoder() Adjust 35 checks

[PATCH 2/2] [media] dvb_usb_core: Improve a size determination in two functions

2017-09-18 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 18 Sep 2017 09:36:33 +0200 Replace the specification of data structures by variable references as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 1/2] [media] dvb_usb_core: Delete two error messages for a failed memory allocation in dvb_usbv2_probe()

2017-09-18 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 18 Sep 2017 09:25:19 +0200 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/2] [media] dvb_usb_core: Adjustments for two function implementations

2017-09-18 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 18 Sep 2017 09:51:23 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete two error messages for a failed memory allocation in dvb_usbv2_probe() Improve a size

[PATCH 8/8] [media] cx231xx: Use common error handling code in cx231xx_load_firmware()

2017-09-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Sep 2017 21:07:39 +0200 Add jump targets so that a bit of exception handling can be better reused at the end of this function. Signed-off-by: Markus Elfring ---

[PATCH 6/8] [media] cx231xx: Use common error handling code in read_eeprom()

2017-09-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Sep 2017 20:22:15 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 7/8] [media] cx231xx: Delete an unnecessary variable initialisation in read_eeprom()

2017-09-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Sep 2017 20:28:00 +0200 The local variable "ret" will be set to an appropriate value a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring ---

[PATCH 5/8] [media] cx231xx: Use common error handling code in dvb_init()

2017-09-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Sep 2017 20:10:34 +0200 Add jump targets so that a bit of exception handling can be better reused at the end of this function. Signed-off-by: Markus Elfring ---

[PATCH 4/8] [media] cx231xx: Delete an unnecessary variable initialisation in dvb_init()

2017-09-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Sep 2017 18:53:16 +0200 The variable "result" will eventually be set to an appropriate value a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring ---

[PATCH 3/8] [media] cx231xx: Improve six size determinations

2017-09-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Sep 2017 18:38:50 +0200 Replace the specification of data structures by variable references as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/8] [media] cx231xx: Adjust 56 checks for null pointers

2017-09-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Sep 2017 18:23:06 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus

[PATCH 1/8] [media] cx231xx: Delete eight error messages for a failed memory allocation

2017-09-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Sep 2017 17:43:47 +0200 Omit extra messages for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/8] [media] Cx231xx: Adjustments for several function implementations

2017-09-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Sep 2017 21:30:12 +0200 Some update suggestions were taken into account from static source code analysis. Markus Elfring (8): Delete eight error messages for a failed memory allocation Adjust 56 checks for null pointers

[PATCH 4/4] [media] cpia2: Delete an unnecessary return statement in process_frame()

2017-09-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Sep 2017 13:32:45 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: void function return statements are not generally useful Thus remove such a statement in the affected function.

[PATCH 3/4] [media] cpia2: Delete unnecessary null pointer checks in free_sbufs()

2017-09-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Sep 2017 13:23:47 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: kfree(NULL) is safe and this check is probably not required Thus fix the affected source code place. Signed-off-by: Markus

[PATCH 2/4] [media] cpia2: Adjust two function calls together with a variable assignment

2017-09-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Sep 2017 12:56:50 +0200 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code places. Signed-off-by: Markus Elfring

[PATCH 1/4] [media] cpia2: Use common error handling code in cpia2_usb_probe()

2017-09-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Sep 2017 12:40:14 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 0/4] [media] CPia2: Fine-tuning for four function implementations

2017-09-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Sep 2017 15:25:35 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (4): Use common error handling code in cpia2_usb_probe() Adjust two function calls together with a

[PATCH] [media] au0828: Delete an error message for a failed memory allocation in au0828_usb_probe()

2017-09-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Sep 2017 11:40:31 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 2/2] [media] airspy: Improve a size determination in airspy_probe()

2017-09-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Sep 2017 11:03:21 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 1/2] [media] airspy: Delete an error message for a failed memory allocation in airspy_probe()

2017-09-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Sep 2017 11:00:09 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/2] [media] AirSpy: Adjustments for airspy_probe()

2017-09-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Sep 2017 11:11:02 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination

[PATCH 2/2] [media] tda18212: Improve three size determinations

2017-09-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Sep 2017 09:42:17 +0200 Replace the specification of data structures by variable references as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 1/2] [media] tda18212: Delete an error message for a failed memory allocation in tda18212_probe()

2017-09-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Sep 2017 09:33:58 +0200 * Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. * Add a jump target so that the function "kfree" will be always called

[PATCH 0/2] [media] TDA18212HN: Adjustments for two function implementations

2017-09-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Sep 2017 10:03:45 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve three size determinations

[PATCH 2/2] [media] si2157: Improve a size determination in two functions

2017-09-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Sep 2017 08:32:17 +0200 Replace the specification of data structures by variable references as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 1/2] [media] si2157: Delete an error message for a failed memory allocation in si2157_probe()

2017-09-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Sep 2017 08:20:04 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/2] [media] Si2157: Adjustments for two function implementations

2017-09-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 17 Sep 2017 08:48:24 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination in two functions

[PATCH 2/2] [media] m88rs6000t: Improve three size determinations

2017-09-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 16 Sep 2017 21:38:03 +0200 Replace the specification of data structures by variable references as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 1/2] [media] tuners: Delete an error message for a failed memory allocation in m88rs6000t_probe()

2017-09-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 16 Sep 2017 21:24:27 +0200 * Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. * Add a jump target so that the function "kfree" will be always called

[PATCH 0/2] [media] M88RS6000T: Adjustments for two function implementations

2017-09-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 16 Sep 2017 21:48:45 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve three size determinations

[PATCH 2/2] [media] it913x: Improve three size determinations

2017-09-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 16 Sep 2017 20:06:01 +0200 Replace the specification of data structures by variable references as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 1/2] [media] it913x: Delete two error messages for a failed memory allocation in it913x_probe()

2017-09-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 16 Sep 2017 19:40:47 +0200 * Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. * Delete the label "err" and the variable "ret" which became unnecessary

[PATCH 0/2] [media] IT913X: Adjustments for two function implementations

2017-09-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 16 Sep 2017 20:12:34 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete two error messages for a failed memory allocation Improve three size determinations

[PATCH 2/2] [media] fc0012: Improve a size determination in fc0012_attach()

2017-09-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 16 Sep 2017 17:55:27 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 1/2] [media] fc0012: Delete an error message for a failed memory allocation in fc0012_attach()

2017-09-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 16 Sep 2017 17:47:52 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/2] [media] FC0012: Adjustments for fc0012_attach()

2017-09-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 16 Sep 2017 18:03:21 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination

[PATCH] [media] Si4713: Delete an error message for a failed memory allocation in two functions

2017-09-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 16 Sep 2017 16:15:44 +0200 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 3/3] [media] si470x: Delete an unnecessary variable initialisation in si470x_usb_driver_probe()

2017-09-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 16 Sep 2017 15:08:39 +0200 The variable "retval" will eventually be set to an appropriate value a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring ---

[PATCH 2/3] [media] si470x: Improve a size determination in si470x_usb_driver_probe()

2017-09-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 16 Sep 2017 14:58:06 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 1/3] [media] si470x: Delete an error message for a failed memory allocation in si470x_usb_driver_probe()

2017-09-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 16 Sep 2017 14:53:49 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/3] [media] si470x: Adjustments for si470x_usb_driver_probe()

2017-09-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 16 Sep 2017 15:16:17 +0200 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete an error message for a failed memory allocation Improve a size determination Delete an

[PATCH 3/3] [media] WL1273: Delete an unnecessary variable initialisation in wl1273_fm_suspend()

2017-09-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 16 Sep 2017 13:55:56 +0200 The local variable "r" will be set to an appropriate value a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring ---

[PATCH 2/3] [media] WL1273: Delete an unnecessary goto statement in wl1273_fm_suspend()

2017-09-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 16 Sep 2017 13:53:22 +0200 * Remove an extra goto statement. * Delete the label "out" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring ---

[PATCH 1/3] [media] WL1273: Delete an error message for a failed memory allocation in wl1273_fm_radio_probe()

2017-09-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 16 Sep 2017 13:28:38 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/3] [media] WL1273: Adjustments for two function implementations

2017-09-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 16 Sep 2017 14:05:45 +0200 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete an error message for a failed memory allocation Delete an unnecessary goto statement

[PATCH 3/3] [media] mr800: Delete an unnecessary variable initialisation in usb_amradio_probe()

2017-09-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 16 Sep 2017 11:39:50 +0200 The variable "retval" will eventually be set to an appropriate value a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring ---

[PATCH 2/3] [media] mr800: Improve a size determination in usb_amradio_probe()

2017-09-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 16 Sep 2017 11:34:11 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 1/3] [media] mr800: Delete two error messages for a failed memory allocation in usb_amradio_probe()

2017-09-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 16 Sep 2017 11:23:53 +0200 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/3] [media] MR800: Adjustments for usb_amradio_probe()

2017-09-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 16 Sep 2017 12:35:43 +0200 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete two error messages for a failed memory allocation Improve a size determination Delete an

[PATCH] [media] Maxi Radio: Delete an error message for a failed memory allocation in maxiradio_probe()

2017-09-16 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 16 Sep 2017 10:15:29 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 2/2] [media] ma901: Improve a size determination in usb_ma901radio_probe()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 22:23:42 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 1/2] [media] ma901: Delete two error messages for a failed memory allocation in usb_ma901radio_probe()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 22:20:04 +0200 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/2] [media] MA901: Adjustments for usb_ma901radio_probe()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 22:31:23 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete two error messages for a failed memory allocation Improve a size determination

Re: [media] stm32-dcmi: Improve four size determinations

2017-09-15 Thread SF Markus Elfring
>> +memcpy(dcmi->sd_formats, sd_fmts, num_fmts * sizeof(*dcmi->sd_formats)); > > devm_kmemdup Are function variants provided which handle memory duplications for arrays explicitly? Regards, Markus

[PATCH 2/2] [media] ti-vpe: Adjust nine checks for null pointers

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 20:22:44 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus

[PATCH 1/2] [media] ti-vpe: Delete an error message for a failed memory allocation in two functions

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 20:15:17 +0200 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/2] [media] TI-VPE: Adjustments for five function implementations

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 20:30:40 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in two functions Adjust nine checks for null

[PATCH 2/2] [media] stm32-dcmi: Improve four size determinations

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 18:48:14 +0200 Replace the specification of data types by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 1/2] [media] stm32-dcmi: Delete an error message for a failed memory allocation in two functions

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 18:38:25 +0200 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/2] [media] STM32-DCMI: Adjustments for three function implementations

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 19:01:23 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in two functions Improve four size

[PATCH 2/2] [media] c8sectpfe: Improve two size determinations in c8sectpfe_frontend_attach()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 17:30:38 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 1/2] [media] c8sectpfe: Delete an error message for a failed memory allocation in c8sectpfe_frontend_attach()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 17:20:48 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/2] [media] C8SECTPFE: Adjustments for c8sectpfe_frontend_attach()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 17:55:43 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve two size determinations

[PATCH] [media] sh_mobile_ceu_camera: Delete an error message for a failed memory allocation in sh_mobile_ceu_probe()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 16:15:47 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 9/9] [media] tm6000: Use common error handling code in tm6000_prepare_isoc()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 08:02:33 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. Signed-off-by: Markus Elfring ---

[PATCH 8/9] [media] tm6000: Use common error handling code in tm6000_start_stream()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 07:47:41 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. Signed-off-by: Markus Elfring ---

[PATCH 7/9] [media] tm6000: Improve a size determination in dvb_init()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 07:33:24 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 6/9] [media] tm6000: Use common error handling code in tm6000_cards_setup()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 14 Sep 2017 16:26:42 +0200 Add a jump target so that a bit of exception handling can be better reused in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 5/9] [media] tm6000: Delete an unnecessary variable initialisation in tm6000_usb_probe()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 14 Sep 2017 16:13:56 +0200 The local variable "rc" will be set to an appropriate value a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring ---

[PATCH 4/9] [media] tm6000: One function call less in tm6000_usb_probe() after error detection

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 14 Sep 2017 16:11:55 +0200 * Adjust jump targets so that the function "kfree" will be always called with a non-null pointer. * Delete an initialisation for the local variable "dev" which became unnecessary with this refactoring.

[PATCH 3/9] [media] tm6000: Use common error handling code in tm6000_usb_probe()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 14 Sep 2017 16:00:47 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. Signed-off-by: Markus Elfring ---

[PATCH 2/9] [media] tm6000: Adjust seven checks for null pointers

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 14 Sep 2017 14:51:15 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus

[PATCH 1/9] [media] tm6000: Delete seven error messages for a failed memory allocation

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 14 Sep 2017 14:34:39 +0200 Omit extra messages for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/9] [media] TM6000: Adjustments for some function implementations

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 08:24:56 +0200 Some update suggestions were taken into account from static source code analysis. Markus Elfring (9): Delete seven error messages for a failed memory allocation Adjust seven checks for null pointers

[PATCH 8/8] [media] ttusb_dec: Delete four unwanted spaces

2017-09-14 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 13 Sep 2017 22:22:41 +0200 The script "checkpatch.pl" pointed information out like the following. ERROR: space prohibited after that open parenthesis '(' Thus fix affected source code places. Signed-off-by: Markus Elfring

[PATCH 7/8] [media] ttusb_dec: Add spaces for better code readability

2017-09-14 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 13 Sep 2017 22:12:07 +0200 The script "checkpatch.pl" pointed information out like the following. ERROR: spaces required around that '=' (ctx:VxV) Thus fix the affected source code places. Signed-off-by: Markus Elfring

[PATCH 6/8] [media] ttusb_dec: Reduce the scope for three variables in ttusb_dec_process_urb()

2017-09-14 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 13 Sep 2017 21:23:29 +0200 * Move the definition for the local variables "b", "d" and "length" into an if branch so that the corresponding setting will only be performed if a memory allocation succeeded in this function. *

[PATCH 5/8] [media] ttusb_dec: Move an assignment in ttusb_dec_probe()

2017-09-14 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 13 Sep 2017 20:32:25 +0200 Assign a pointer to a data structure member without using an intermediate local variable. Signed-off-by: Markus Elfring --- drivers/media/usb/ttusb-dec/ttusb_dec.c | 6

[PATCH 4/8] [media] ttusb_dec: Delete an error message for a failed memory allocation in ttusb_dec_probe()

2017-09-14 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 13 Sep 2017 20:10:39 +0200 Omit an extra message for a memory allocation failure in this function. Signed-off-by: Markus Elfring --- drivers/media/usb/ttusb-dec/ttusb_dec.c | 4 +--- 1 file changed,

[PATCH 3/8] [media] ttusb_dec: Improve a size determination in three functions

2017-09-14 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 13 Sep 2017 19:56:38 +0200 * The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix a few source code places. * Replace the specification of data structures

[PATCH 2/8] [media] ttusb_dec: Adjust five checks for null pointers

2017-09-14 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 13 Sep 2017 18:22:35 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus

[PATCH 1/8] [media] ttusb_dec: Use common error handling code in ttusb_dec_init_dvb()

2017-09-14 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 13 Sep 2017 18:08:19 +0200 Add jump targets so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 0/8] [media] ttusb_dec: Fine-tuning for some function implementations

2017-09-14 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 14 Sep 2017 12:26:24 +0200 Some update suggestions were taken into account from static source code analysis. Markus Elfring (8): Use common error handling code in ttusb_dec_init_dvb() Adjust five checks for null pointers

Re: [media] s5p-mfc: Adjust a null pointer check in four functions

2017-09-12 Thread SF Markus Elfring
> Generating patch is only part of the story, I can follow this view in principle. > it seems the patch is not sent properly I got an other impression. > and tags which should be in SMTP header end up in the message body. I agree that extra message fields were presented by the git software

Re: [media] s5p-mfc: Adjust a null pointer check in four functions

2017-09-12 Thread SF Markus Elfring
>> * Do you care to preserve an information like the author date? > > In this case not, but actually the Date line is not an issue. Thanks for your information. It seems then that you quoted a line too much. > Anyway the patch is malformed, … I have got doubts for this view because the file

Re: [media] s5p-mfc: Delete an error message for a failed memory allocation in s5p_mfc_probe()

2017-09-11 Thread SF Markus Elfring
> Could you make the commit summary shorter, to keep it > below 70 characters [1]? With that changed feel free to add > > Acked-by: Sylwester Nawrocki … > [1] Documentation/process/submitting-patches.rst Will it be sufficient that a patch committer will adjust the

Re: [media] s5p-mfc: Adjust a null pointer check in four functions

2017-09-11 Thread SF Markus Elfring
>> Date: Fri, 8 Sep 2017 22:37:00 +0200 >> MIME-Version: 1.0 >> Content-Type: text/plain; charset=UTF-8 >> Content-Transfer-Encoding: 8bit > > Can you resend with that 4 lines removed? * Do you care to preserve an information like the author date? * Would you like to support special characters

[PATCH 3/3] [media] xc2028: Use common error handling code in load_firmware()

2017-09-09 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 9 Sep 2017 22:07:04 +0200 Add jump targets so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 2/3] [media] xc2028: Adjust two null pointer checks in load_all_firmwares()

2017-09-09 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 9 Sep 2017 21:48:58 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus

[PATCH 1/3] [media] xc2028: Delete two error messages for a failed memory allocation in load_all_firmwares()

2017-09-09 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 9 Sep 2017 21:30:11 +0200 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 0/3] [media] xc2028: Adjustments for two function implementations

2017-09-09 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 9 Sep 2017 22:18:22 +0200 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete two error messages for a failed memory allocation Adjust two null pointer checks Use

[PATCH 2/2] [media] xc4000: Adjust two null pointer checks in xc4000_fwupload()

2017-09-09 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 9 Sep 2017 20:55:14 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus

<    1   2   3   4   5   6   >