Re: [PATCH v4 01/12] media: ov5640: Adjust the clock based on the expected rate

Hello Maxime and Jacopo (and other ov5640-ers), I just submitted my version of this patch to the mailing list as RFC. It is working on my MIPI platform. Please try it if you have time. Hopefully we can merge these two into a single patch that doesn't break any platforms. Thanks, Sam Additional

[RFC PATCH] media: ov5640: calculate PLL settings for modes

blob that helps ensure the following DPHY spec requirement is met: MIN HS_ZERO + MIN HS_PREPARE > 145 + t_UI * 10 Signed-off-by: Sam Bobrowicz --- This is a modified version of Maxime's patch that works on my platform. My platform is a dual-lane MIPI CSI2 module with xclk=24MHz connec

[PATCH 1/4] media: ov5640: fix resolution update

set_fmt was not properly triggering a mode change when a new mode was set that happened to have the same format as the previous mode (for example, when only changing the frame dimensions). Fix this. Signed-off-by: Sam Bobrowicz --- drivers/media/i2c/ov5640.c | 8 1 file changed, 4

[PATCH 3/4] media: ov5640: Don't access ctrl regs when off

Add a check to g_volatile_ctrl to prevent trying to read registers when the sensor is not powered. Signed-off-by: Sam Bobrowicz --- drivers/media/i2c/ov5640.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c index f183222

[PATCH 0/4] ov5640: small fixes for compatibility

These patches include fixes for some minor annoyances and also help increase compatibility with some CSI2 drivers. Based on latest media_tree commit: "media: ov5640: fix framerate update" Sam Bobrowicz (4): media: ov5640: fix resolution update media: ov5640: fix get_light_fr

[PATCH 4/4] media: ov5640: Add additional media bus formats

support for the 1X16 formats. Signed-off-by: Sam Bobrowicz --- drivers/media/i2c/ov5640.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c index a50d884..ca9de56 100644 --- a/drivers/media/i2c/ov5640.c +++ b/drivers/media/i2c/ov5640.c

[PATCH 2/4] media: ov5640: fix get_light_freq on auto

Light frequency was not properly returned when in auto mode and the detected frequency was 60Hz. Fix this. Signed-off-by: Sam Bobrowicz --- drivers/media/i2c/ov5640.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c index 5031aab

Re: [PATCH v3 03/12] media: ov5640: Remove the clocks registers initialization

>> On May 21, 2018, at 12:39 AM, Maxime Ripard >> wrote: >> >>> On Fri, May 18, 2018 at 07:42:34PM -0700, Sam Bobrowicz wrote: >>>> On Fri, May 18, 2018 at 3:35 AM, Daniel Mack wrote: >>>> On Thursday, May 17, 2018 10:53 AM, Maxime Ripard wr

Re: [PATCH v3 03/12] media: ov5640: Remove the clocks registers initialization

On Fri, May 18, 2018 at 3:35 AM, Daniel Mack wrote: > On Thursday, May 17, 2018 10:53 AM, Maxime Ripard wrote: >> >> Part of the hardcoded initialization sequence is to set up the proper >> clock >> dividers. However, this is now done dynamically through proper code and as >>

Re: [PATCH v2 00/12] media: ov5640: Misc cleanup and improvements

> Hi, > > Here is a "small" series that mostly cleans up the ov5640 driver code, > slowly getting rid of the big data array for more understandable code > (hopefully). > > The biggest addition would be the clock rate computation at runtime, > instead of relying on those arrays to setup the clock

Re: [PATCH v2 00/12] media: ov5640: Misc cleanup and improvements

> Hi, > >> Good news, MIPI is now working on my platform. I had to make several >> changes to how the mipi clocking is calculated in order to get things >> stable, but I think I got it figured out. Maxime's changes were really >> helpful. > > Great, I also try to make it work with MIPI-CSI2, If

Re: [PATCH v2 00/12] media: ov5640: Misc cleanup and improvements

> Hi, > > On 3 May 2018 at 17:16, Maxime Ripard <maxime.rip...@bootlin.com> wrote: > > Hi, > > > > On Wed, May 02, 2018 at 11:11:55AM -0700, Sam Bobrowicz wrote: > >> > On Wednesday, 25 April 2018 01:11:19 EEST Sam Bobrowicz wrote: > >> >>

Re: [PATCH v2 00/12] media: ov5640: Misc cleanup and improvements

On Fri, Apr 27, 2018 at 2:27 AM, Laurent Pinchart <laurent.pinch...@ideasonboard.com> wrote: > Hi Sam, > > On Wednesday, 25 April 2018 01:11:19 EEST Sam Bobrowicz wrote: >> FYI, still hard at work on this. Did some more experiments last week >> that seemed to

Re: [PATCH v2 00/12] media: ov5640: Misc cleanup and improvements

t. I'm new to this process :) --Sam ------- Sam Bobrowicz Elite Embedded Consulting LLC elite-embedded.com On Thu, Apr 19, 2018 at 5:32 AM, Maxime Ripard <maxime.rip...@bootlin.com> wrote: > Hi Samuel, > > On Wed, Apr 18, 2018 at 04:39:06PM -0700, Samuel Bobrowicz wrote: