Re: [PATCH v3 8/9] media: rcar-vin: Rename _rcar_info to rcar_info

2018-05-19 Thread Sergei Shtylyov
Hello! On 5/18/2018 5:40 PM, Jacopo Mondi wrote: Remove trailing underscore to align all rcar_group_route structure Leading, not trailing (judging on the patch). declarations. Signed-off-by: Jacopo Mondi --- drivers/media/platform/rcar-vin/rcar-core.c | 4

Re: [PATCH] dt-bindings: media: rcar_vin: fix style for ports and endpoints

2018-05-17 Thread Sergei Shtylyov
On 5/17/2018 2:32 AM, Niklas Söderlund wrote: The style for referring to ports and endpoint are wrong. Refer to them using lowercase and a unit address, port@x and endpoint@x. Signed-off-by: Niklas Söderlund Reported-by: Geert Uytterhoeven

Re: [PATCH] rcar-vin: sync which hardware buffer to start capture from

2018-05-17 Thread Sergei Shtylyov
Hello! On 5/17/2018 2:22 AM, Niklas Söderlund wrote: When starting the VIN capture procedure we are not guaranteed that the first buffer writing to is VnMB1 to which we assigned the first buffer Written, perhaps? queued. This is problematic for two reasons. Buffers might not be dequeued

Re: [PATCH 3/6] media: rcar-vin: Handle data-active property

2018-05-17 Thread Sergei Shtylyov
Hello! On 5/16/2018 7:32 PM, Jacopo Mondi wrote: The data-active property has to be specified when running with embedded Prop names are typically enclosed in "". synchronization. The VIN peripheral can use HSYNC in place of CLOCKENB CLKENB, maybe? when the CLOCKENB pin is not

Re: [PATCH 5/5] media: rcar-vin: Use FTEV for digital input

2018-05-12 Thread Sergei Shtylyov
Hello! On 5/11/2018 12:59 PM, Jacopo Mondi wrote: Since commit (015060cb Need 12 digits here, and SHA1 ID should be cited outside the parens. "media: rcar-vin: enable field toggle after a set number of lines for Gen3) The commit summary must be enclosed in (""). And I think

Re: [PATCH v2 2/2] rcar-vin: fix crop and compose handling for Gen3

2018-05-11 Thread Sergei Shtylyov
Hello! On 05/11/2018 05:41 PM, Niklas Söderlund wrote: > When refactoring the Gen3 enablement series crop and compose handling > where broken. This went unnoticed but can result in writing out side the s/Where/Were/? > capture buffer. Fix this by restoring the crop and compose to reflect >

Re: [PATCH] v4l: vsp1: Fix vsp1_regs.h license header

2018-04-28 Thread Sergei Shtylyov
<nobuhiro.iwamatsu...@renesas.com> Cc: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Cc: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Cc: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Cc: Wolfram Sang <wsa+rene...@sang-engineering.com> S

Re: [PATCH 4/8] sh_eth: Change platform check to CONFIG_ARCH_RENESAS

2018-04-20 Thread Sergei Shtylyov
le SoCs are still covered by the CONFIG_CPU_SH4 > check. > > This will allow to drop ARCH_SHMOBILE on ARM and ARM64 in the near > future. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> [...] Acked-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> MBR, Sergei

Re: [PATCH 1/8] arm: shmobile: Change platform dependency to ARCH_RENESAS

2018-04-20 Thread Sergei Shtylyov
On 04/20/2018 04:28 PM, Geert Uytterhoeven wrote: > Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") > is ARCH_RENESAS a more appropriate platform dependency than the legacy "ARCH_RENESAS is", no? > ARCH_SHMOBILE, hence use the former. > > This will allow to drop

Re: [PATCH v7] media: platform: Renesas IMR driver

2018-04-16 Thread Sergei Shtylyov
> can be added later... >> >> Based on the original patch by Konstantin Kozhevnikov. >> >> Signed-off-by: Konstantin Kozhevnikov >> <konstantin.kozhevni...@cogentembedded.com> >> Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com>

Re: [PATCH 02/15] v4l: vsp1: Remove outdated comment

2018-02-27 Thread Sergei Shtylyov
Hello! On 2/27/2018 12:45 AM, Laurent Pinchart wrote: The entities in the pipeline are all started when the LIF is setup. Remove the outdated comment that state otherwise. States? Signed-off-by: Laurent Pinchart [...] MBR, Sergei

Re: [PATCH v4] v4l: vsp1: Fix video output on R8A77970

2018-02-22 Thread Sergei Shtylyov
On 02/22/2018 09:46 PM, Laurent Pinchart wrote: >>> From: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> >>> >>> Commit d455b45f8393 ("v4l: vsp1: Add support for new VSP2-BS, VSP2-DL, >>> and VSP2-D instances") added support for the VSP2-D

Re: [PATCH v3] vsp1: fix video output on R8A77970

2018-02-22 Thread Sergei Shtylyov
On 02/22/2018 07:26 PM, Laurent Pinchart wrote: > Hi Sergei, > > Thank you for the patch. > > On Thursday, 18 January 2018 16:05:51 EET Sergei Shtylyov wrote: >> Commit d455b45f8393 ("v4l: vsp1: Add support for new VSP2-BS, VSP2-DL, >> and VSP2-D instances"

Re: [PATCH v4] v4l: vsp1: Fix video output on R8A77970

2018-02-22 Thread Sergei Shtylyov
On 02/22/2018 07:32 PM, Laurent Pinchart wrote: > From: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> > > Commit d455b45f8393 ("v4l: vsp1: Add support for new VSP2-BS, VSP2-DL, > and VSP2-D instances") added support for the VSP2-D found in the R-Car > V3M

Re: [PATCH v8 04/11] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

2018-01-31 Thread Sergei Shtylyov
Hello! On 1/30/2018 12:58 PM, Jacopo Mondi wrote: Add Capture Engine Unit (CEU) node to device tree. Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Acked-by:

[PATCH v3] vsp1: fix video output on R8A77970

2018-01-18 Thread Sergei Shtylyov
new VSP2-BS, VSP2-DL and VSP2-D instances") Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- This patch is against the 'media_tree.git' repo's 'fixes' branch. Changes in version 3: - reworded the comment in lif_configure(); - reworded the patch description

Re: [PATCH -next] media: rcar_drif: fix error return code in rcar_drif_alloc_dmachannels()

2018-01-17 Thread Sergei Shtylyov
Hello! On 01/17/2018 02:24 PM, Wei Yongjun wrote: Fix to return error code -ENODEV from the dma_request_slave_channel() error handling case instead of 0, as done elsewhere in this function. rc can be overwrite to 0 by dmaengine_slave_config() in the for loop. Overwritten. Signed-off-by:

Re: [PATCH v2] vsp1: fix video output on R8A77970

2018-01-15 Thread Sergei Shtylyov
Hello! On 01/15/2018 03:51 PM, Laurent Pinchart wrote: On Tuesday, 26 December 2017 23:14:12 EET Sergei Shtylyov wrote: Laurent has added support for the VSP2-D found on R-Car V3M (R8A77970) but I'm not sure there's a need to state my name in the commit message. You were the author

[PATCH v2] vsp1: fix video output on R8A77970

2017-12-26 Thread Sergei Shtylyov
of a magic value for the LIF to work correctly... Based on the original (and large) patch by Daisuke Matsushita <daisuke.matsushita...@hitachi.com>. Fixes: d455b45f8393 ("v4l: vsp1: Add support for new VSP2-BS, VSP2-DL and VSP2-D instances") Signed-off-by: Sergei Shtyly

Re: [PATCH] vsp1: fix video output on R8A77970

2017-12-26 Thread Sergei Shtylyov
Hello! On 12/26/2017 12:21 AM, Sergei Shtylyov wrote: Laurent has added support for the VSP2-D found on R-Car V3M (R8A77970) but the video output that VSP2-D sends to DU has a greenish garbage-like line repeated every 8 or so screen rows. It turns out that V3M has a teeny LIF register

[PATCH] vsp1: fix video output on R8A77970

2017-12-25 Thread Sergei Shtylyov
of a magic value for the LIF to work correctly... Based on the original (and large) patch by Daisuke Matsushita <daisuke.matsushita...@hitachi.com>. Fixes: d455b45f8393 ("v4l: vsp1: Add support for new VSP2-BS, VSP2-DL and VSP2-D instances") Signed-off-by: Sergei Shtyly

Re: [PATCH 5/9] v4l: vsp1: Document the vsp1_du_atomic_config structure

2017-12-04 Thread Sergei Shtylyov
Hello! On 12/3/2017 1:57 PM, Laurent Pinchart wrote: The structure is used in the API that the VSP1 driver exposes to the DU driver. Documenting it is thus important. Signed-off-by: Laurent Pinchart --- include/media/vsp1.h | 10 ++ 1

Re: [PATCH 07/13] media: soc_camera pad-aware driver initialisation

2017-10-27 Thread Sergei Shtylyov
On 10/27/2017 10:52 AM, Sergei Shtylyov wrote: Add detection of source pad number for drivers aware of the media controller API, so that the combination of soc_camera and rcar_vin can create device nodes to support modern drivers such as adv7604.c (for HDMI on Lager) and the converted adv7180.c

Re: [PATCH 07/13] media: soc_camera pad-aware driver initialisation

2017-10-27 Thread Sergei Shtylyov
Hello! On 7/23/2015 2:21 PM, William Towle wrote: Add detection of source pad number for drivers aware of the media controller API, so that the combination of soc_camera and rcar_vin can create device nodes to support modern drivers such as adv7604.c (for HDMI on Lager) and the converted

Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock

2017-09-19 Thread Sergei Shtylyov
On 09/19/2017 01:59 PM, Hans Verkuil wrote: From: Hans Verkuil Document the cec clock binding. Signed-off-by: Hans Verkuil Acked-by: Rob Herring --- Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt | 4

Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock

2017-09-19 Thread Sergei Shtylyov
On 9/19/2017 1:35 PM, Hans Verkuil wrote: From: Hans Verkuil Document the cec clock binding. Signed-off-by: Hans Verkuil Acked-by: Rob Herring --- Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt | 4

Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock

2017-09-19 Thread Sergei Shtylyov
On 9/19/2017 1:07 PM, Hans Verkuil wrote: From: Hans Verkuil Document the cec clock binding. Signed-off-by: Hans Verkuil Acked-by: Rob Herring --- Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt | 4

Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock

2017-09-19 Thread Sergei Shtylyov
On 9/19/2017 12:29 PM, Hans Verkuil wrote: From: Hans Verkuil Document the cec clock binding. Signed-off-by: Hans Verkuil Acked-by: Rob Herring --- Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt | 4

Re: [PATCHv2 1/2] dt-bindings: adi,adv7511.txt: document cec clock

2017-09-19 Thread Sergei Shtylyov
Hello! On 9/19/2017 10:33 AM, Hans Verkuil wrote: From: Hans Verkuil Document the cec clock binding. Signed-off-by: Hans Verkuil Acked-by: Rob Herring --- Documentation/devicetree/bindings/display/bridge/adi,adv7511.txt |

Re: [PATCH v7] media: platform: Renesas IMR driver

2017-08-17 Thread Sergei Shtylyov
Hello! On 08/17/2017 10:59 AM, Hans Verkuil wrote: A quick review. I'm concentrating on the mesh ioctl, since that's what sets this driver apart. OK, waiting for the detailed review... Index: media_tree/Documentation/media/v4l-drivers/rcar_imr.rst

[PATCH v7] media: platform: Renesas IMR driver

2017-08-04 Thread Sergei Shtylyov
<konstantin.kozhevni...@cogentembedded.com> Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Acked-by: Rob Herring <r...@kernel.org> --- The patch is against the 'media_tree.git' repo's 'master' branch. Changes in version 7: - switched to using 'v4l2_fh::m2m_ctx' whi

Re: [PATCH v6] media: platform: Renesas IMR driver

2017-07-12 Thread Sergei Shtylyov
Hello! On 07/06/2017 09:16 PM, Sergei Shtylyov wrote: [...] += + +This file documents some driver-specific aspects of the IMR driver, such as +driver-specific ioctls. + +The ioctl reference +~~~ + +VIDIOC_IMR_MESH - Set mapping data

Re: [PATCH v6] media: platform: Renesas IMR driver

2017-07-06 Thread Sergei Shtylyov
Hello! On 07/03/2017 03:43 PM, Hans Verkuil wrote: Index: media_tree/Documentation/media/v4l-drivers/rcar_imr.rst === --- /dev/null +++ media_tree/Documentation/media/v4l-drivers/rcar_imr.rst @@ -0,0 +1,86 @@ +Renesas R-Car Image

Re: [PATCH v6] media: platform: Renesas IMR driver

2017-07-05 Thread Sergei Shtylyov
Hello! On 07/03/2017 03:25 PM, Hans Verkuil wrote: From: Konstantin Kozhevnikov The image renderer, or the distortion correction engine, is a drawing processor with a simple instruction system capable of referencing video capture data or data in an

Re: [PATCH v3] media: platform: rcar_imr: add IMR-LSX3 support

2017-06-30 Thread Sergei Shtylyov
-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- This patch is against the 'media_tree.git' repo's 'master' branch plus the latest version of the Renesas IMR driver... Changes in version 3: - fixed compilation errors, resolved rejects, refreshed the patch atop of the IMR driver

[PATCH v2] media: platform: rcar_imr: add IMR-LX3 support

2017-06-28 Thread Sergei Shtylyov
Add support for the image renderer light extended 3 (IMR-LX3) found only in the R-Car V2H (R8A7792) SoC. It's mostly the same as IMR-LSX3 but doesn't support video capture data as a source of 2D textures. Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- This

[PATCH v3] media: platform: rcar_imr: add IMR-LSX3 support

2017-06-28 Thread Sergei Shtylyov
Add support for the image renderer light SRAM extended 3 (IMR-LSX3) found only in the R-Car V2H (R8A7792) SoC. It differs from IMR-LX4 in that it supports only planar video formats but can use the video capture data for the textures. Signed-off-by: Sergei Shtylyov <sergei.sh

Re: [PATCH v6] media: platform: Renesas IMR driver

2017-06-26 Thread Sergei Shtylyov
. If they did, it should all be separate commits. AFAIK this is a way that's things are dealt with when you submit somebody else's work with your changes. Sorry if the list is too long... Signed-off-by: Konstantin Kozhevnikov <konstantin.kozhevni...@cogentembedded.com> Signed-off

Re: [PATCH v5] media: platform: Renesas IMR driver

2017-06-24 Thread Sergei Shtylyov
closed the macro parameters in parens, exchanged the values of IMR_MAP_AUTO{S|D}G macros.] Signed-off-by: Konstantin Kozhevnikov <konstantin.kozhevni...@cogentembedded.com> Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> [...] Index: media_tree/drivers/media/p

[PATCH v6] media: platform: Renesas IMR driver

2017-06-23 Thread Sergei Shtylyov
parens, exchanged the values of IMR_MAP_AUTO{S|D}G macros.] Signed-off-by: Konstantin Kozhevnikov <konstantin.kozhevni...@cogentembedded.com> Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- Changes in version 6: - fixed the bug where if imr_cfg_create() fails,

Re: [PATCH v5] media: platform: Renesas IMR driver

2017-06-07 Thread Sergei Shtylyov
Hello! On 06/07/2017 10:26 AM, Hans Verkuil wrote: Any progress on this? Yes. :-) There where a bunch of comments, I think I've addresses most of those (except those I didn't quite understand). but I haven't seen anything since. I'm still busy documenting the driver. :-(

Re: [PATCH] ALSA: hda - Fix applying MSI dual-codec mobo quirk

2017-06-02 Thread Sergei Shtylyov
Hello! On 6/1/2017 11:58 PM, Takashi Iwai wrote: The previous commit [63691587f7b0: ALSA: hda - Apply dual-codec quirk for MSI Z270-Gaming mobo] attempted to apply the existing dual-codec The standard way of citing a commit is: commit 63691587f7b0 ("ALSA: hda - Apply dual-codec quirk for

Re: [PATCH 6/7] [media] soc_camera: rcar_vin: use proper name for the R-Car SoC

2017-05-29 Thread Sergei Shtylyov
Hello! Why "soc_camera:" in the subject? The 'soc_camera" driver has been removed (replaced by a "normal" V4L2 driver). MBR, Sergei

Re: [PATCH v2 17/17] rcar-vin: fix bug in pixelformat selection

2017-05-24 Thread Sergei Shtylyov
Hello! On 5/24/2017 3:15 AM, Niklas Söderlund wrote: From: Niklas Söderlund If the requested pixelformat is not supported fallback to the default format, do not revert the entire format. Signed-off-by: Niklas Söderlund

Re: [PATCH 1/2] v4l: vsp1: Add support for colorkey alpha blending

2017-05-04 Thread Sergei Shtylyov
On 05/04/2017 01:53 PM, agheorghe wrote: The vsp2 hw supports changing of the alpha of pixels that match a color key, this patch adds support for this feature in order to be used by the rcar-du driver. The colorkey is interpreted different depending of the pixel format: * RGB - all

Re: [PATCH 4/5] arm64: dts: r8a7795: salvator-x: enable VIN, CSI and ADV7482

2017-04-28 Thread Sergei Shtylyov
Hello! On 4/27/2017 9:26 PM, Kieran Bingham wrote: From: Kieran Bingham Provide bindings between the VIN, CSI and the ADV7482 on the r8a7795. Signed-off-by: Kieran Bingham ---

[PATCH] media: platform: rcar_imr: add IMR-LX3 support

2017-03-17 Thread Sergei Shtylyov
Add support for the image renderer light extended 3 (IMR-LX3) found only in the R-Car V2H (R8A7792) SoC. It's mostly the same as IMR-LSX3 but doesn't support video capture data as a source of 2D textures. Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- This

Re: [PATCH v2] media: platform: rcar_imr: add IMR-LSX3 support

2017-03-17 Thread Sergei Shtylyov
-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> [...] Index: media_tree/drivers/media/platform/rcar_imr.c === --- media_tree.orig/drivers/media/platform/rcar_imr.c +++ media_tree/drivers/media/platform/rcar

[PATCH v2] media: platform: rcar_imr: add IMR-LSX3 support

2017-03-16 Thread Sergei Shtylyov
Add support for the image renderer light SRAM extended 3 (IMR-LSX3) found only in the R-Car V2H (R8A7792) SoC. It differs from IMR-LX4 in that it supports only planar video formats but can use the video capture data for the textures. Signed-off-by: Sergei Shtylyov <sergei.sh

Re: [PATCH v3 06/27] rcar-vin: move max width and height information to chip information

2017-03-15 Thread Sergei Shtylyov
On 3/14/2017 10:02 PM, Niklas Söderlund wrote: On Gen3 the max supported width and height will be different from Gen2. Move the limits to the struct chip_info to prepare for Gen3 support. Maybe rvin_info? Signed-off-by: Niklas Söderlund ---

Re: [PATCH 03/16] rcar-vin: fix how pads are handled for v4l2 subdevice operations

2017-03-15 Thread Sergei Shtylyov
Hello! On 3/14/2017 9:59 PM, Niklas Söderlund wrote: The rcar-vin driver only uses one pad, pad number 0. - All v4l2 operations that did not check that the requested operation was for pad 0 have been updated with a check to enforce this. - All v4l2 operations that stored (and later

Re: [PATCH 01/16] rcar-vin: reset bytesperline and sizeimage when resetting format

2017-03-15 Thread Sergei Shtylyov
Hello! On 3/14/2017 9:59 PM, Niklas Söderlund wrote: These two where forgotten when refactoring the format reset code. If s/where/were/? they are not also reset at the same time as width and height the format returned from G_FMT will not match reality. Signed-off-by: Niklas Söderlund

[PATCH] media: platform: rcar_imr: add IMR-LSX3 support

2017-03-13 Thread Sergei Shtylyov
Add support for the image renderer light SRAM extended 3 (IMR-LSX3) found only in the R-Car V2H (R8A7792) SoC. It differs from IMR-LX4 in that it supports only planar video formats but can use the video capture data for the textures. Signed-off-by: Sergei Shtylyov <sergei.sh

Re: [PATCH RESEND 1/1] media: platform: Renesas IMR driver

2017-03-13 Thread Sergei Shtylyov
Hello! On 02/22/2017 10:05 PM, Sergei Shtylyov wrote: From: Konstantin Kozhevnikov <konstantin.kozhevni...@cogentembedded.com> The image renderer light extended 4 (IMR-LX4) or the distortion correction engine is a drawing processor with a simple instruction system capable of referencin

[PATCH v5] media: platform: Renesas IMR driver

2017-03-09 Thread Sergei Shtylyov
macro parameters in parens, exchanged the values of IMR_MAP_AUTO{S|D}G macros.] Signed-off-by: Konstantin Kozhevnikov <konstantin.kozhevni...@cogentembedded.com> Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- This patch is against the 'media_tree.git' repo's 'master

[PATCH v4] media: platform: Renesas IMR driver

2017-03-07 Thread Sergei Shtylyov
closed the macro parameters in parens, exchanged the values of IMR_MAP_AUTO{S|D}G macros.] Signed-off-by: Konstantin Kozhevnikov <konstantin.kozhevni...@cogentembedded.com> Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- This patch is against the 'media_tree.g

Re: [PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t

2017-03-07 Thread Sergei Shtylyov
On 3/7/2017 10:52 AM, Reshetova, Elena wrote: refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by: Elena

[PATCH v3] media: platform: Renesas IMR driver

2017-03-06 Thread Sergei Shtylyov
macro parameters in parens, exchanged the values of IMR_MAP_AUTO{S|D}G macros.] Signed-off-by: Konstantin Kozhevnikov <konstantin.kozhevni...@cogentembedded.com> Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- This patch is against the 'media_tree.git' repo

Re: [PATCH] media: platform: Renesas IMR driver

2017-03-06 Thread Sergei Shtylyov
'... On Fri, Mar 3, 2017 at 9:03 PM, Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> wrote: On 03/03/2017 02:58 PM, Geert Uytterhoeven wrote: + - "renesas,imr-lx4-v3m" for R-Car V3M. "renesas,-EPROBE_DEFER-imr-lx4" Huh? :-) Do you know the part number o

Re: [PATCH 11/29] drivers, media: convert cx88_core.refcount from atomic_t to refcount_t

2017-03-06 Thread Sergei Shtylyov
Hello. On 03/06/2017 05:20 PM, Elena Reshetova wrote: refcount_t type and corresponding API should be used instead of atomic_t when the variable is used as a reference counter. This allows to avoid accidental refcounter overflows that might lead to use-after-free situations. Signed-off-by:

Re: [PATCH v3 3/3] drm: rcar-du: Register a completion callback with VSP1

2017-03-05 Thread Sergei Shtylyov
Hello! On 03/05/2017 07:00 PM, Kieran Bingham wrote: Currently we process page flip events on every display interrupt, however this does not take into consideration the processing time needed by the VSP1 utilised in the pipeline. Register a callback with the VSP driver to obtain completion

Re: [PATCH] media: platform: Renesas IMR driver

2017-03-03 Thread Sergei Shtylyov
On 03/03/2017 02:58 PM, Geert Uytterhoeven wrote: + - "renesas,imr-lx4-v3m" for R-Car V3M. "renesas,-EPROBE_DEFER-imr-lx4" Huh? :-) Do you know the part number of V3M? No, but using the names from the manual I don't need it. Gr{oetje,eeting}s, Geert

Re: [PATCH] media: platform: Renesas IMR driver

2017-03-03 Thread Sergei Shtylyov
Hello! On 03/03/2017 02:24 PM, Geert Uytterhoeven wrote: --- /dev/null +++ media_tree/Documentation/devicetree/bindings/media/rcar_imr.txt +- compatible: "renesas,imr-lx4-", "renesas,imr-lx4" as a fallback for "renesas,-imr-lx4" + the image renderer light extended 4 (IMR-LX4) found in

[PATCH] media: platform: Renesas IMR driver

2017-03-02 Thread Sergei Shtylyov
vnikov <konstantin.kozhevni...@cogentembedded.com> Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- Changes in version 2: - renamed the ICR bits to match the manual; - added/used the IMR bits; - changed the prefixes of the CMRCR[2]/TRI{M|C}R bits/fields to match the

Re: [PATCH RESEND 1/1] media: platform: Renesas IMR driver

2017-02-22 Thread Sergei Shtylyov
edded.com> Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- This patch is against the 'media_tree.git' repo's 'master' branch. Documentation/devicetree/bindings/media/rcar_imr.txt | 23 drivers/media/platform/Kconfig | 13 drivers/media

[PATCH RESEND 1/1] media: platform: Renesas IMR driver

2017-02-11 Thread Sergei Shtylyov
d code duplication in the IRQ handler, used '__packed' for the UAPI structures, enclosed the macro parameters in parens, exchanged the values of IMR_MAP_AUTO[SD]G macros.] Signed-off-by: Konstantin Kozhevnikov <konstantin.kozhevni...@cogentembedded.com> Signed-off-by: Sergei Shtylyov &

Re: [PATCH 1/1] media: platform: Renesas IMR driver

2017-02-11 Thread Sergei Shtylyov
Just noticed that quilt has swallowed From: in the patch body while I meant to keep Konstantin as an author... will repost. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH 1/1] media: platform: Renesas IMR driver

2017-02-10 Thread Sergei Shtylyov
, enclosed the macro parameters in parens, exchanged the values of IMR_MAP_AUTO[SD]G macros.] Signed-off-by: Konstantin Kozhevnikov <konstantin.kozhevni...@cogentembedded.com> Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- This patch is against the 'media_tree

[PATCH 1/1] media: platform: Renesas IMR driver

2017-02-10 Thread Sergei Shtylyov
, enclosed the macro parameters in parens, exchanged the values of IMR_MAP_AUTO[SD]G macros.] Signed-off-by: Konstantin Kozhevnikov <konstantin.kozhevni...@cogentembedded.com> Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- This patch is against the 'media_tree

[PATCH] vsp1: remove UAPI support for R-Car gen2 VSPDs

2016-12-13 Thread Sergei Shtylyov
We are going to use the R-Car gen2 VSPDs as the DU compositors, so will have to disable the UAPI support for them... Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- This patch is against the 'media_tree.git' repo's 'master' branch. drivers/media/platfor

Re: [PATCH 20/32] media: rcar-vin: expose a sink pad if we are on Gen3

2016-11-02 Thread Sergei Shtylyov
On 11/02/2016 04:23 PM, Niklas Söderlund wrote: Refactor the probe code path to look for the digital subdevice, if one is found use it just like the driver did before (Gen2 mode) but if it's not found prepare for a Gen3 mode by registering a pad for the media controller API to use.

Re: [PATCH 03/32] media: rcar-vin: reset bytesperline and sizeimage when resetting format

2016-11-02 Thread Sergei Shtylyov
Hello. On 11/02/2016 04:23 PM, Niklas Söderlund wrote: These two fields where forgotten when refactoring the format reset code path. If they are not also reset at the same time as width and hight the format read using G_FMT will not match realty. Reality? Signed-off-by: Niklas Söderlund

Re: [PATCH 1/2] ARM: dts: lager: Add entries for VIN HDMI input support

2016-09-17 Thread Sergei Shtylyov
Hello. On 9/16/2016 4:09 PM, Ulrich Hecht wrote: From: William Towle Add DT entries for vin0, vin0_pins, and adv7612. Sets the 'default-input' property for ADV7612, enabling image and video capture without the need to have userspace specifying routing.

Re: [PATCH] vsp1: add R8A7792 VSP1V support

2016-09-03 Thread Sergei Shtylyov
Hello. On 09/02/2016 01:47 AM, Laurent Pinchart wrote: Add support for the R8A7792 VSP1V cores which are different from the other gen2 VSP1 cores... Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- This patch is against the 'media_tree.git' repo's 'master'

Re: [PATCHv3 09/10] [media] rcar-vin: rework how subdeivce is found and bound

2016-09-03 Thread Sergei Shtylyov
Hello. On 08/15/2016 06:06 PM, Niklas Söderlund wrote: The original drivers code to find a subdevice by looking in the DT grpah s/grpah/graph/. and how the callbacks to the v4l2 async bind framework where poorly written. The most obvious example of badness was the duplication of data in

Re: [PATCHv3 05/10] [media] rcar-vin: return correct error from platform_get_irq()

2016-09-03 Thread Sergei Shtylyov
On 08/15/2016 06:06 PM, Niklas Söderlund wrote: Fix a error from the original driver where the wrong error code is returned if the driver fails to get a IRQ number from platform_get_irq(). Signed-off-by: Niklas Söderlund ---

Re: [PATCHv3 06/10] [media] rcar-vin: do not use v4l2_device_call_until_err()

2016-09-03 Thread Sergei Shtylyov
On 08/15/2016 06:06 PM, Niklas Söderlund wrote: Fix a error from the original driver where v4l2_device_call_until_err() where used for the pad specific v4l2 operation set_fmt. Also fix up the error path from this fix so if there is an error it will be propagated to the caller. The error

Re: [PATCHv3 04/10] [media] rcar-vin: rename entity to digital

2016-09-03 Thread Sergei Shtylyov
Hello. On 08/15/2016 06:06 PM, Niklas Söderlund wrote: When Gen3 support is added to the driver more then one possible video s/then/than/. source entity will be possible. Knowing that the name entity is a bad one, rename it to digital since it will deal with the digital input source.

[PATCH] vsp1: add R8A7792 VSP1V support

2016-08-19 Thread Sergei Shtylyov
Add support for the R8A7792 VSP1V cores which are different from the other gen2 VSP1 cores... Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- This patch is against the 'media_tree.git' repo's 'master' branch. drivers/media/platform/vsp1/vsp1_drv.c

Re: [PATCHv2 4/7] media: rcar-vin: fix height for TOP and BOTTOM fields

2016-08-03 Thread Sergei Shtylyov
On 08/02/2016 05:51 PM, Niklas Söderlund wrote: The height used for V4L2_FIELD_TOP and V4L2_FIELD_BOTTOM where wrong. The frames only contain one filed so the height should be half of the s/filed/field/. frame. Signed-off-by: Niklas Söderlund

Re: [PATCHv2 1/7] media: rcar-vin: make V4L2_FIELD_INTERLACED standard dependent

2016-08-03 Thread Sergei Shtylyov
On 08/02/2016 05:51 PM, Niklas Söderlund wrote: The field V4L2_FIELD_INTERLACED is standard dependent and should not unconditionally be equivalent to V4L2_FIELD_INTERLACED_TB. This patch adds a check to see if the video standard can be obtained and if it's a 60 Hz format. If the condition is

Re: [PATCHv2 5/7] media: rcar-vin: add support for V4L2_FIELD_ALTERNATE

2016-08-03 Thread Sergei Shtylyov
Hello. On 08/02/2016 05:51 PM, Niklas Söderlund wrote: The HW can capture both ODD and EVEN fields in separate buffers so it's possible to support V4L2_FIELD_ALTERNATE. This patch add support for this mode. At probe time and when S_STD is called the driver will default to use

[PATCH] rcar_vin: add support for V4L2_FIELD_ALTERNATE

2016-07-31 Thread Sergei Shtylyov
The hardware can capture both odd and even fields in the separate buffers, so it's possible to support this field mode. However, if the subdevice presents data in this mode, we prefer to use the hardware deinterlacing... Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.

Re: [PATCH 4/6] media: rcar-vin: add support for V4L2_FIELD_ALTERNATE

2016-07-30 Thread Sergei Shtylyov
Hello. On 07/29/2016 08:40 PM, Niklas Söderlund wrote: The HW can capture both ODD and EVEN fields in separate buffers so it's possible to support this field mode. Signed-off-by: Niklas Söderlund It's probably worth adding that if the subdevice presents the video data in this mode, we

Re: [PATCH 1/6] media: rcar-vin: allow field to be changed

2016-07-29 Thread Sergei Shtylyov
On 07/29/2016 08:40 PM, Niklas Söderlund wrote: The driver forced whatever field was set by the source subdevice to be used. This patch allows the user to change from the default field. Signed-off-by: Niklas Söderlund I didn't apply this patch at

Re: [PATCH 6/6] media: adv7180: fix field type

2016-07-29 Thread Sergei Shtylyov
etting the field mode, set the field mode to V4L2_FIELD_ALTERNATE. Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> [Niklas: changed filed type from V4L2_FIELD_SEQ_{TB,BT} to V4L2_FIELD_ALTERNATE] Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Tested-b

Re: [PATCH] rcar-vin: add R-Car gen2 fallback compatibility string

2016-07-26 Thread Sergei Shtylyov
On 7/26/2016 9:05 AM, Niklas Söderlund wrote: Such fallback string is present in the 'soc_camera' version of the R-Car VIN driver, so need to add it here as well... Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Acked-by: Niklas Söderlund <niklas.soder

[PATCH] rcar-vin: add R-Car gen2 fallback compatibility string

2016-07-25 Thread Sergei Shtylyov
Such fallback string is present in the 'soc_camera' version of the R-Car VIN driver, so need to add it here as well... Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- This patch is against the 'media_tree.git' repo's 'master' branch. This patch conflicts with

Re: [PATCH v6 1/4] media: adv7604: automatic "default-input" selection

2016-07-22 Thread Sergei Shtylyov
On 07/22/2016 12:09 PM, Ulrich Hecht wrote: Fall back to input 0 if "default-input" property is not present. Additionally, documentation in commit bf9c82278c34 ("[media] media: adv7604: ability to read default input port from DT") states that the "default-input" property should reside directly

Re: [PATCHv2 04/16] [media] rcar-vin: return correct error from platform_get_irq

2016-07-19 Thread Sergei Shtylyov
Hello. On 07/19/2016 05:20 PM, Niklas Söderlund wrote: Fix a error from the original driver where the wrong error code is returned if the driver fails to get a IRQ number from platform_get_irq(). Signed-off-by: Niklas Söderlund ---

Re: [PATCH 8/8] [media] rcar-vin: add Gen2 and Gen3 fallback compatibility strings

2016-05-27 Thread Sergei Shtylyov
Hello. On 05/27/2016 02:36 PM, Niklas Söderlund wrote: From: Niklas Söderlund These are present in the soc-camera version of this driver and it's time to add them to this driver as well. Signed-off-by: Niklas Söderlund

Re: [PATCH 8/8] [media] rcar-vin: add Gen2 and Gen3 fallback compatibility strings

2016-05-25 Thread Sergei Shtylyov
On 05/25/2016 10:10 PM, Niklas Söderlund wrote: From: Niklas Söderlund These are present in the soc-camera version of this driver and it's time to add them to this driver as well. Signed-off-by: Niklas Söderlund

Re: [PATCH v2 08/13] v4l: vsp1: Make vsp1_entity_get_pad_compose() more generic

2016-04-26 Thread Sergei Shtylyov
Hello. On 04/26/2016 12:36 AM, Laurent Pinchart wrote: Turn the helper into a function that can retrieve crop and compose selection rectangles. Signed-off-by: Laurent Pinchart --- drivers/media/platform/vsp1/vsp1_entity.c | 24

Re: [PATCH v2 8/9] ARM: shmobile: lager dts: Add entries for VIN HDMI input support

2016-03-02 Thread Sergei Shtylyov
The new way of writing the subject prefix is "ARM: dts: lager: ..." -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] media: platform: rcar_jpu, sh_vou, vsp1: Use ARCH_RENESAS

2016-03-02 Thread Sergei Shtylyov
Hello. On 3/2/2016 4:14 AM, Simon Horman wrote: Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. This is part of an ongoing process to migrate from ARCH_SHMOBILE to ARCH_RENESAS the motivation for which being that RENESAS seems to be a more appropriate name than SHMOBILE for the majority

Re: [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq

2015-12-27 Thread Sergei Shtylyov
On 12/27/2015 9:13 AM, Julia Lawall wrote: Well, looking again, the patch should be good. I just thought its goal was to fix the code as well... I could do that for the irq < 0 case, but I think that in that case, kbuild will only run the patch version, and the <= cases will not be

Re: [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq

2015-12-26 Thread Sergei Shtylyov
On 12/27/2015 01:32 AM, Julia Lawall wrote: The error return value of platform_get_irq seems to often get dropped. Signed-off-by: Julia Lawall --- v2: Check for the direct return case also. Added some mailing lists of common offenders. diff --git

Re: [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq

2015-12-26 Thread Sergei Shtylyov
On 12/26/2015 11:58 PM, Julia Lawall wrote: The error return value of platform_get_irq seems to often get dropped. Signed-off-by: Julia Lawall --- v2: Check for the direct return case also. Added some mailing lists of common offenders. diff --git

Re: [PATCH v2] adv7604: add direct interrupt handling

2015-12-22 Thread Sergei Shtylyov
Hello. On 12/22/2015 05:21 PM, Ulrich Hecht wrote: When probed from device tree, the i2c client driver can handle the interrupt on its own. Signed-off-by: Ulrich Hecht Reviewed-by: Laurent Pinchart --- This revision

Re: [PATCH] media: soc_camera: rcar_vin: Add R-Car Gen3 support

2015-12-13 Thread Sergei Shtylyov
On 12/13/2015 06:27 PM, Yoshihiro Kaneko wrote: From: Yoshihiko Mori Add chip identification for R-Car Gen3. Signed-off-by: Yoshihiko Mori Signed-off-by: Yoshihiro Kaneko [...] diff --git

  1   2   3   4   >