[PATCH] s5p-mfc: fix state check from encoder queue_setup

2015-05-13 Thread Seung-Woo Kim
from queue_setup. Signed-off-by: Seung-Woo Kim sw0312@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c

Re: [Linaro-mm-sig] [PATCH] dma-buf: add meta data attachment

2014-03-25 Thread Seung-Woo Kim
really be added as part of the dma_buf_attachment, and not separately. This is basic concept of my RFC patch. http://www.kernelhub.org/?p=2msg=268056 Best Regards, - Seung-Woo Kim The meta-data here can be any kind of data related to the dmabuf, , it's specific for each dmabuf. For example

[PATCH] [media] s5-mfc: remove meaningless assignment

2014-03-05 Thread Seung-Woo Kim
Signed-off-by: Seung-Woo Kim sw0312@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c b/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c index 2475a3c..ee05f2d

[PATCH] [media] s5-mfc: remove meaningless memory bank assignment

2014-03-05 Thread Seung-Woo Kim
There was assignment of memory bank with dma address converted from physical address. But allocation has been changed with dma function, so the assignment is not necessary. Signed-off-by: Seung-Woo Kim sw0312@samsung.com --- change from v1 - fixes subject and adds proper description

Re: [PATCH] [media] s5-mfc: remove meaningless memory bank assignment

2014-03-05 Thread Seung-Woo Kim
Hello Sachin, On 2014년 03월 05일 20:42, Sachin Kamat wrote: On 5 March 2014 16:38, Seung-Woo Kim sw0312@samsung.com wrote: (...) - dev-bank1 = dev-bank1; Are you sure this isn't some kind of typo? If not then your commit description is too verbose to actually say that the code

Re: [PATCH] [media] s5-mfc: remove meaningless memory bank assignment

2014-03-05 Thread Seung-Woo Kim
Hello Sachin, On 2014년 03월 06일 12:28, Sachin Kamat wrote: Hi Seung-Woo, On 6 March 2014 07:43, Seung-Woo Kim sw0312@samsung.com wrote: Hello Sachin, On 2014년 03월 05일 20:42, Sachin Kamat wrote: On 5 March 2014 16:38, Seung-Woo Kim sw0312@samsung.com wrote: (...) - dev

Re: DMABUF doesn't work when frame size not equal to the size of GPU bo

2014-01-07 Thread Seung-Woo Kim
queue_setup in the __qbuf_dmabuf() like __vb2_buf_mem_alloc() or vb2_mmap(). Regards, - Seung-Woo Kim The fd in v4l2_buffer structure is fd of gem object created by DRM_IOCTL_MODE_CREATE_DUMB. I've upload the program that can reproduce this issue on intel platform. You just need to clone

[PATCH] [media] videobuf2: Add log for size checking error in __qbuf_dmabuf

2013-11-28 Thread Seung-Woo Kim
__qbuf_dmabuf checks whether size of provided dmabuf is large enough, and it returns error without any log. So this patch adds error log in the case. Signed-off-by: Seung-Woo Kim sw0312@samsung.com --- drivers/media/v4l2-core/videobuf2-core.c |2 ++ 1 files changed, 2 insertions(+), 0

Re: [PATCH] s5p-jpeg: fix uninitialized use in hdr parse

2013-10-13 Thread Seung-Woo Kim
Hi Sylwester, Thanks for you comment. On 2013년 10월 12일 18:39, Sylwester Nawrocki wrote: Hi Seung-Woo, On 10/10/2013 09:06 AM, Seung-Woo Kim wrote: For hdr parse error, it can return false without any assignments which cause build warning. Signed-off-by: Seung-Woo Kimsw0312

[PATCH v2] s5p-jpeg: fix uninitialized use in hdr parse

2013-10-13 Thread Seung-Woo Kim
drivers/media/platform/s5p-jpeg/jpeg-core.c:433: warning: 'height' may be used uninitialized in this function drivers/media/platform/s5p-jpeg/jpeg-core.c:433: warning: 'width' may be used uninitialized in this function Signed-off-by: Seung-Woo Kim sw0312@samsung.com --- change from v1 - add

[PATCH] s5p-jpeg: fix uninitialized use in hdr parse

2013-10-10 Thread Seung-Woo Kim
For hdr parse error, it can return false without any assignments which cause build warning. Signed-off-by: Seung-Woo Kim sw0312@samsung.com --- drivers/media/platform/s5p-jpeg/jpeg-core.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s5p

[PATCH] s5p-jpeg: fix encoder and decoder video dev names

2013-10-10 Thread Seung-Woo Kim
It is hard to distinguish between decoder and encoder video device because their names are same. So this patch fixes the names. Signed-off-by: Seung-Woo Kim sw0312@samsung.com --- drivers/media/platform/s5p-jpeg/jpeg-core.c |8 1 files changed, 4 insertions(+), 4 deletions

[PATCH] media: vb2: add log for size checking error in __qbuf_userptr

2013-08-20 Thread Seung-Woo Kim
__qbuf_userptr checks whether provided buffer is large enough, and it returns error without any log. Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Heejin Woo heejin@samsung.com --- drivers/media/v4l2-core/videobuf2-core.c |4 1 files changed, 4 insertions(+), 0

[RFC][PATCH 0/2] dma-buf: add importer private data for reimporting

2013-05-31 Thread Seung-Woo Kim
importer private data in dma-buf attachment can be used by importer to reimport same dma-buf. Seung-Woo Kim (2): dma-buf: add importer private data to attachment drm/prime: find gem object from the reimported dma-buf drivers/base/dma-buf.c | 31

[RFC][PATCH 2/2] drm/prime: find gem object from the reimported dma-buf

2013-05-31 Thread Seung-Woo Kim
be used at reimport time if it is assigned with drm gem object at first import. This can also remove remapping dma address for the hardware having its own iommu. Signed-off-by: Seung-Woo Kim sw0312@samsung.com --- drivers/gpu/drm/drm_prime.c| 19 ++- drivers/gpu

[RFC][PATCH 1/2] dma-buf: add importer private data to attachment

2013-05-31 Thread Seung-Woo Kim
-by: Seung-Woo Kim sw0312@samsung.com --- drivers/base/dma-buf.c | 31 +++ include/linux/dma-buf.h |4 2 files changed, 35 insertions(+), 0 deletions(-) diff --git a/drivers/base/dma-buf.c b/drivers/base/dma-buf.c index 08fe897..a1eaaf2 100644

[RESEND][PATCH 0/2] media: fix polling not to wait if a buffer is available

2013-05-20 Thread Seung-Woo Kim
() or queue is cancelled. So I add check routine for done_list before calling poll_wait(). But I'm not sure that locking for done_lock of queue is also needed in this case or not because done_list of queue is checked without locking in some other parts of vb2. Seung-Woo Kim (2): media: vb2: return

[RESEND][PATCH 1/2] media: vb2: return for polling if a buffer is available

2013-05-20 Thread Seung-Woo Kim
The vb2_poll() does not need to wait next vb_buffer_done() if there is already a buffer in done_list of queue, but current vb2_poll() always waits. So done_list is checked before calling poll_wait(). Signed-off-by: Seung-Woo Kim sw0312@samsung.com Acked-by: Marek Szyprowski m.szyprow

[RESEND][PATCH 2/2] media: v4l2-mem2mem: return for polling if a buffer is available

2013-05-20 Thread Seung-Woo Kim
The v4l2_m2m_poll() does not need to wait if there is already a buffer in done_list of source and destination queues, but current v4l2_m2m_poll() always waits. So done_list of each queue is checked before calling poll_wait(). Signed-off-by: Seung-Woo Kim sw0312@samsung.com Acked-by: Marek

[PATCH] media: vb2: add length check for mmap

2013-04-11 Thread Seung-Woo Kim
The length of mmap() can be bigger than length of vb2 buffer, so it should be checked. Signed-off-by: Seung-Woo Kim sw0312@samsung.com --- drivers/media/v4l2-core/videobuf2-core.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2

[RFC][PATCH 0/2] media: fix polling not to wait if a buffer is available

2013-04-01 Thread Seung-Woo Kim
() or queue is cancelled. So I add check routine for done_list before calling poll_wait(). But I'm not sure that locking for done_lock of queue is also needed in this case or not because done_list of queue is checked without locking in some other parts of vb2. Seung-Woo Kim (2): media: vb2: return

[RFC][PATCH 1/2] media: vb2: return for polling if a buffer is available

2013-04-01 Thread Seung-Woo Kim
The vb2_poll() does not need to wait next vb_buffer_done() if there is already a buffer in done_list of queue, but current vb2_poll() always waits. So done_list is checked before calling poll_wait(). Signed-off-by: Seung-Woo Kim sw0312@samsung.com --- drivers/media/v4l2-core/videobuf2-core.c

[RFC][PATCH 2/2] media: v4l2-mem2mem: return for polling if a buffer is available

2013-04-01 Thread Seung-Woo Kim
The v4l2_m2m_poll() does not need to wait if there is already a buffer in done_list of source and destination queues, but current v4l2_m2m_poll() always waits. So done_list of each queue is checked before calling poll_wait(). Signed-off-by: Seung-Woo Kim sw0312@samsung.com --- drivers/media