[PATCH v9 1/6] video: add display_timing and videomode

2012-11-14 Thread Steffen Trumtrar
videomode structure. This videomode can then be converted to the corresponding subsystem mode representation (e.g. fb_videomode). Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- drivers/video/Kconfig |6 drivers/video/Makefile |2 ++ drivers/video

[PATCH v9 5/6] drm_modes: add videomode helpers

2012-11-14 Thread Steffen Trumtrar
Add conversion from videomode to drm_display_mode Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- drivers/gpu/drm/drm_modes.c | 36 include/drm/drmP.h |6 ++ 2 files changed, 42 insertions(+) diff --git a/drivers/gpu/drm

[PATCH v9 0/6] of: add display helper

2012-11-14 Thread Steffen Trumtrar
Hi! Changes since v8: - fix memory leaks - change API to be more consistent (foo_from_bar(struct bar, struct foo)) - include headers were necessary - misc minor bufixes Regards, Steffen Steffen Trumtrar (6): video: add display_timing and videomode video

[PATCH v9 3/6] fbmon: add videomode helpers

2012-11-14 Thread Steffen Trumtrar
Add a function to convert from the generic videomode to a fb_videomode. Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- drivers/video/fbmon.c | 38 ++ include/linux/fb.h|5 + 2 files changed, 43 insertions(+) diff --git a/drivers

[PATCH v9 4/6] fbmon: add of_videomode helpers

2012-11-14 Thread Steffen Trumtrar
Add helper to get fb_videomode from devicetree. Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- drivers/video/fbmon.c | 42 +- include/linux/fb.h|6 ++ 2 files changed, 47 insertions(+), 1 deletion(-) diff --git a/drivers/video

[PATCH v9 2/6] video: add of helper for videomode

2012-11-14 Thread Steffen Trumtrar
converts exactly one of that timings to a struct videomode. Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de Signed-off-by: Philipp Zabel p.za...@pengutronix.de Acked-by: Stephen Warren swar...@nvidia.com --- .../devicetree/bindings/video/display-timings.txt | 107 ++ drivers/video

Re: [PATCH v9 2/6] video: add of helper for videomode

2012-11-14 Thread Steffen Trumtrar
On Wed, Nov 14, 2012 at 01:00:45PM +0100, Thierry Reding wrote: On Wed, Nov 14, 2012 at 12:43:19PM +0100, Steffen Trumtrar wrote: [...] +display-timings bindings + + +display timings node I didn't express myself very clearly here =). The way I think

Re: [PATCH v9 3/6] fbmon: add videomode helpers

2012-11-14 Thread Steffen Trumtrar
On Wed, Nov 14, 2012 at 01:12:07PM +0100, Thierry Reding wrote: On Wed, Nov 14, 2012 at 12:43:20PM +0100, Steffen Trumtrar wrote: Add a function to convert from the generic videomode to a fb_videomode. Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- drivers/video/fbmon.c

Re: [PATCH v9 5/6] drm_modes: add videomode helpers

2012-11-14 Thread Steffen Trumtrar
On Wed, Nov 14, 2012 at 01:49:44PM +0100, Thierry Reding wrote: On Wed, Nov 14, 2012 at 12:43:22PM +0100, Steffen Trumtrar wrote: [...] diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c [...] @@ -504,6 +505,41 @@ drm_gtf_mode(struct drm_device *dev, int hdisplay, int

Re: [PATCH v8 2/6] video: add of helper for videomode

2012-11-13 Thread Steffen Trumtrar
Hi! On Mon, Nov 12, 2012 at 07:58:40PM +0100, Sascha Hauer wrote: Hi Steffen, You lose memory in several places: On Mon, Nov 12, 2012 at 04:37:02PM +0100, Steffen Trumtrar wrote: +static struct display_timing *of_get_display_timing(struct device_node *np) +{ + struct display_timing

Re: [PATCH v8 2/6] video: add of helper for videomode

2012-11-13 Thread Steffen Trumtrar
On Mon, Nov 12, 2012 at 11:00:37PM +0400, Alexey Klimov wrote: Hello Steffen, On Mon, Nov 12, 2012 at 7:37 PM, Steffen Trumtrar s.trumt...@pengutronix.de wrote: This adds support for reading display timings from DT or/and convert one of those timings to a videomode

Re: [PATCH v8 2/6] video: add of helper for videomode

2012-11-13 Thread Steffen Trumtrar
On Mon, Nov 12, 2012 at 01:40:12PM -0700, Stephen Warren wrote: On 11/12/2012 08:37 AM, Steffen Trumtrar wrote: This adds support for reading display timings from DT or/and convert one of those timings to a videomode. The of_display_timing implementation supports multiple children where

Re: [PATCH v8 1/6] video: add display_timing and videomode

2012-11-13 Thread Steffen Trumtrar
On Tue, Nov 13, 2012 at 11:41:59AM +0100, Thierry Reding wrote: On Mon, Nov 12, 2012 at 04:37:01PM +0100, Steffen Trumtrar wrote: [...] diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index d08d799..2a23b18 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig

Re: [PATCH v8 3/6] fbmon: add videomode helpers

2012-11-13 Thread Steffen Trumtrar
On Tue, Nov 13, 2012 at 12:22:58PM +0100, Thierry Reding wrote: On Mon, Nov 12, 2012 at 04:37:03PM +0100, Steffen Trumtrar wrote: [...] +#if IS_ENABLED(CONFIG_VIDEOMODE) +int videomode_to_fb_videomode(struct videomode *vm, struct fb_videomode *fbmode) The other helpers are named

Re: [PATCH v8 6/6] drm_modes: add of_videomode helpers

2012-11-13 Thread Steffen Trumtrar
On Tue, Nov 13, 2012 at 12:35:18PM +0100, Thierry Reding wrote: On Mon, Nov 12, 2012 at 04:37:06PM +0100, Steffen Trumtrar wrote: [...] +#if IS_ENABLED(CONFIG_OF_VIDEOMODE) +static void dump_drm_displaymode(struct drm_display_mode *m) +{ + pr_debug(drm_displaymode = %d %d %d %d %d %d

[PATCH v8 2/6] video: add of helper for videomode

2012-11-12 Thread Steffen Trumtrar
converts exactly one of that timings to a struct videomode. Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- .../devicetree/bindings/video/display-timings.txt | 107 +++ drivers/video/Kconfig | 13

Re: [PATCH v7 0/8] of: add display helper

2012-11-09 Thread Steffen Trumtrar
On Thu, Nov 08, 2012 at 03:35:47PM -0600, Rob Herring wrote: On 10/31/2012 04:28 AM, Steffen Trumtrar wrote: Hi! Finally, v7 of the series. Changes since v6: - get rid of some empty lines etc. - move functions to their subsystems - split of_ from non-of_ functions

Re: [PATCH v7 5/8] fbmon: add videomode helpers

2012-11-09 Thread Steffen Trumtrar
Hi! On Fri, Nov 09, 2012 at 04:54:16PM +, Manjunathappa, Prakash wrote: Hi Steffen, On Fri, Nov 09, 2012 at 02:55:45, Steffen Trumtrar wrote: Hi! On Wed, Oct 31, 2012 at 03:30:03PM +, Manjunathappa, Prakash wrote: Hi Steffen, On Wed, Oct 31, 2012 at 14:58:05, Steffen

Re: [PATCH v7 5/8] fbmon: add videomode helpers

2012-11-08 Thread Steffen Trumtrar
Hi! On Wed, Oct 31, 2012 at 03:30:03PM +, Manjunathappa, Prakash wrote: Hi Steffen, On Wed, Oct 31, 2012 at 14:58:05, Steffen Trumtrar wrote: +#if IS_ENABLED(CONFIG_VIDEOMODE) +int videomode_to_fb_videomode(struct videomode *vm, struct fb_videomode *fbmode) +{ + fbmode-xres

Re: [PATCH v7 1/8] video: add display_timing struct and helpers

2012-11-04 Thread Steffen Trumtrar
On Thu, Nov 01, 2012 at 09:08:42PM +0100, Thierry Reding wrote: On Wed, Oct 31, 2012 at 10:28:01AM +0100, Steffen Trumtrar wrote: [...] +void timings_release(struct display_timings *disp) +{ + int i; + + for (i = 0; i disp-num_timings; i++) + kfree(disp-timings[i

Re: [PATCH v7 2/8] of: add helper to parse display timings

2012-11-04 Thread Steffen Trumtrar
On Thu, Nov 01, 2012 at 09:15:10PM +0100, Thierry Reding wrote: On Wed, Oct 31, 2012 at 10:28:02AM +0100, Steffen Trumtrar wrote: [...] diff --git a/Documentation/devicetree/bindings/video/display-timings.txt b/Documentation/devicetree/bindings/video/display-timings.txt [...] @@ -0,0

Re: [PATCH v7 2/8] of: add helper to parse display timings

2012-11-04 Thread Steffen Trumtrar
Hi! On Fri, Nov 02, 2012 at 10:49:47PM +0530, Leela Krishna Amudala wrote: Hello Steffen, On Wed, Oct 31, 2012 at 2:58 PM, Steffen Trumtrar +static int parse_property(struct device_node *np, char *name, + struct timing_entry *result) +{ + struct

[PATCH v7 0/8] of: add display helper

2012-10-31 Thread Steffen Trumtrar
Hi! Finally, v7 of the series. Changes since v6: - get rid of some empty lines etc. - move functions to their subsystems - split of_ from non-of_ functions - add at least some kerneldoc to some functions Regards, Steffen Steffen Trumtrar (8): video: add

[PATCH v7 1/8] video: add display_timing struct and helpers

2012-10-31 Thread Steffen Trumtrar
Add display_timing structure and the according helper functions. This allows the description of a display via its supported timing parameters. Every timing parameter can be specified as a single value or a range min typ max. Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- drivers

[PATCH v7 2/8] of: add helper to parse display timings

2012-10-31 Thread Steffen Trumtrar
Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- .../devicetree/bindings/video/display-timings.txt | 139 +++ drivers/of/Kconfig |6 + drivers/of/Makefile|1 + drivers/of/of_display_timings.c

[PATCH v7 4/8] video: add videomode helpers

2012-10-31 Thread Steffen Trumtrar
Add helper functions to convert from display timings to a generic videomode structure. This videomode can then be converted to the corresponding subsystem mode representation (e.g. fb_videomode). Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- drivers/video/Kconfig |6

[PATCH v7 5/8] fbmon: add videomode helpers

2012-10-31 Thread Steffen Trumtrar
Add a function to convert from the generic videomode to a fb_videomode. Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- drivers/video/fbmon.c | 36 include/linux/fb.h|2 ++ 2 files changed, 38 insertions(+) diff --git a/drivers/video

[PATCH v7 6/8] fbmon: add of_videomode helpers

2012-10-31 Thread Steffen Trumtrar
Add helper to get fb_videomode from devicetree. Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- drivers/video/fbmon.c | 40 include/linux/fb.h|3 +++ 2 files changed, 43 insertions(+) diff --git a/drivers/video/fbmon.c b/drivers

[PATCH v7 7/8] drm_modes: add videomode helpers

2012-10-31 Thread Steffen Trumtrar
Add conversion from videomode to drm_display_mode Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- drivers/gpu/drm/drm_modes.c | 36 include/drm/drmP.h |3 +++ 2 files changed, 39 insertions(+) diff --git a/drivers/gpu/drm

[PATCH v7 3/8] of: add generic videomode description

2012-10-31 Thread Steffen Trumtrar
Get videomode from devicetree in a format appropriate for the backend. drm_display_mode and fb_videomode are supported atm. Uses the display signal timings from of_display_timings Signed-off-by: Philipp Zabel p.za...@pengutronix.de Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de

[PATCH v7 8/8] drm_modes: add of_videomode helpers

2012-10-31 Thread Steffen Trumtrar
Add helper to get drm_display_mode from devicetree. Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- drivers/gpu/drm/drm_modes.c | 42 ++ include/drm/drmP.h |5 + 2 files changed, 47 insertions(+) diff --git a/drivers/gpu

Re: [PATCH v7 5/8] fbmon: add videomode helpers

2012-10-31 Thread Steffen Trumtrar
Hi Prakash! On Wed, Oct 31, 2012 at 03:30:03PM +, Manjunathappa, Prakash wrote: Hi Steffen, On Wed, Oct 31, 2012 at 14:58:05, Steffen Trumtrar wrote: Add a function to convert from the generic videomode to a fb_videomode. Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de

Re: [PATCH 2/2 v6] of: add generic videomode description

2012-10-22 Thread Steffen Trumtrar
On Sat, Oct 20, 2012 at 01:04:12PM +0200, Thierry Reding wrote: On Thu, Oct 04, 2012 at 07:59:20PM +0200, Steffen Trumtrar wrote: [...] diff --git a/drivers/of/of_videomode.c b/drivers/of/of_videomode.c [...] +#if defined(CONFIG_DRM) This should be: #if IS_ENABLED(CONFIG_DRM

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-22 Thread Steffen Trumtrar
On Sat, Oct 20, 2012 at 09:59:51PM +0200, Thierry Reding wrote: On Thu, Oct 04, 2012 at 07:59:19PM +0200, Steffen Trumtrar wrote: [...] diff --git a/include/linux/of_display_timings.h b/include/linux/of_display_timings.h [...] +struct display_timings { + unsigned int num_timings

Re: [PATCH 0/2 v6] of: add display helper

2012-10-15 Thread Steffen Trumtrar
Hi Leela, On Mon, Oct 15, 2012 at 04:24:43PM +0530, Leela Krishna Amudala wrote: Hello Steffen, To which version of the kernel we can expect this patch set to be merged into? Because I'm waiting for this from long time to add DT support for my display controller :) I have no idea, sorry.

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-12 Thread Steffen Trumtrar
On Thu, Oct 11, 2012 at 09:31:18PM +0200, Thierry Reding wrote: On Mon, Oct 08, 2012 at 09:49:21AM +0200, Steffen Trumtrar wrote: On Mon, Oct 08, 2012 at 10:07:45AM +0300, Tomi Valkeinen wrote: On Thu, 2012-10-04 at 19:59 +0200, Steffen Trumtrar wrote: [...] + + disp

Re: [PATCH 2/2 v6] of: add generic videomode description

2012-10-09 Thread Steffen Trumtrar
Hi Laurent, On Mon, Oct 08, 2012 at 10:52:04PM +0200, Laurent Pinchart wrote: Hi Steffen, On Monday 08 October 2012 14:48:01 Steffen Trumtrar wrote: On Mon, Oct 08, 2012 at 02:13:50PM +0200, Laurent Pinchart wrote: On Thursday 04 October 2012 19:59:20 Steffen Trumtrar wrote: Get

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-08 Thread Steffen Trumtrar
On Sun, Oct 07, 2012 at 03:38:25PM +0200, Laurent Pinchart wrote: Hi Steffen, On Friday 05 October 2012 18:38:58 Steffen Trumtrar wrote: On Fri, Oct 05, 2012 at 10:21:37AM -0600, Stephen Warren wrote: On 10/05/2012 10:16 AM, Steffen Trumtrar wrote: On Thu, Oct 04, 2012 at 12:47:16PM

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-08 Thread Steffen Trumtrar
Hi, On Mon, Oct 08, 2012 at 10:07:45AM +0300, Tomi Valkeinen wrote: Hi, On Thu, 2012-10-04 at 19:59 +0200, Steffen Trumtrar wrote: Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- .../devicetree/bindings/video/display-timings.txt | 222 drivers

Re: [PATCH 2/2 v6] of: add generic videomode description

2012-10-08 Thread Steffen Trumtrar
On Mon, Oct 08, 2012 at 10:21:53AM +0300, Tomi Valkeinen wrote: On Thu, 2012-10-04 at 19:59 +0200, Steffen Trumtrar wrote: Get videomode from devicetree in a format appropriate for the backend. drm_display_mode and fb_videomode are supported atm. Uses the display signal timings from

Re: [PATCH 2/2 v6] of: add generic videomode description

2012-10-08 Thread Steffen Trumtrar
On Mon, Oct 08, 2012 at 02:13:50PM +0200, Laurent Pinchart wrote: Hi Steffen, Thanks for the patch. On Thursday 04 October 2012 19:59:20 Steffen Trumtrar wrote: Get videomode from devicetree in a format appropriate for the backend. drm_display_mode and fb_videomode are supported atm

Re: [PATCH 2/2 v6] of: add generic videomode description

2012-10-05 Thread Steffen Trumtrar
On Thu, Oct 04, 2012 at 12:51:00PM -0600, Stephen Warren wrote: On 10/04/2012 11:59 AM, Steffen Trumtrar wrote: Get videomode from devicetree in a format appropriate for the backend. drm_display_mode and fb_videomode are supported atm. Uses the display signal timings from of_display_timings

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-05 Thread Steffen Trumtrar
On Thu, Oct 04, 2012 at 12:47:16PM -0600, Stephen Warren wrote: On 10/04/2012 11:59 AM, Steffen Trumtrar wrote: A patch description would be useful for something like this. Yes. Shame on me. diff --git a/Documentation/devicetree/bindings/video/display-timings.txt b/Documentation

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-05 Thread Steffen Trumtrar
Trumtrar wrote: Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- .../devicetree/bindings/video/display-timings.txt | 222 drivers/of/Kconfig |5 + drivers/of/Makefile|1

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-05 Thread Steffen Trumtrar
On Fri, Oct 05, 2012 at 10:21:37AM -0600, Stephen Warren wrote: On 10/05/2012 10:16 AM, Steffen Trumtrar wrote: On Thu, Oct 04, 2012 at 12:47:16PM -0600, Stephen Warren wrote: On 10/04/2012 11:59 AM, Steffen Trumtrar wrote: ... + for_each_child_of_node(timings_np, entry

[PATCH 0/2 v6] of: add display helper

2012-10-04 Thread Steffen Trumtrar
Hi! In accordance with Stepehn Warren, I downsized the binding. Now, just the display-timing is described, as I think, it is way easier to agree on those and have a complete binding. Regards, Steffen Steffen Trumtrar (2): of: add helper to parse display timings of: add generic videomode

[PATCH 1/2 v6] of: add helper to parse display timings

2012-10-04 Thread Steffen Trumtrar
Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- .../devicetree/bindings/video/display-timings.txt | 222 drivers/of/Kconfig |5 + drivers/of/Makefile|1 + drivers/of/of_display_timings.c

[PATCH 2/2 v6] of: add generic videomode description

2012-10-04 Thread Steffen Trumtrar
Get videomode from devicetree in a format appropriate for the backend. drm_display_mode and fb_videomode are supported atm. Uses the display signal timings from of_display_timings Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- drivers/of/Kconfig |5 + drivers

Re: [PATCH 1/2] of: add helper to parse display specs

2012-10-03 Thread Steffen Trumtrar
On Mon, Oct 01, 2012 at 10:53:08AM -0600, Stephen Warren wrote: On 09/24/2012 09:35 AM, Steffen Trumtrar wrote: Parse a display-node with timings and hardware-specs from devictree. diff --git a/Documentation/devicetree/bindings/video/display b/Documentation/devicetree/bindings/video

[PATCH v5] of: add display helper (was: of: add videomode helper)

2012-09-24 Thread Steffen Trumtrar
Steffen Trumtrar (2): of: add helper to parse display specs video: add generic videomode description Documentation/devicetree/bindings/video/display | 208

[PATCH 1/2] of: add helper to parse display specs

2012-09-24 Thread Steffen Trumtrar
Parse a display-node with timings and hardware-specs from devictree. Signed-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- Documentation/devicetree/bindings/video/display | 208 +++ drivers/of/Kconfig |5 + drivers/of/Makefile

[PATCH 2/2] video: add generic videomode description

2012-09-24 Thread Steffen Trumtrar
-off-by: Steffen Trumtrar s.trumt...@pengutronix.de --- drivers/video/Makefile|1 + drivers/video/videomode.c | 146 + include/linux/videomode.h | 38 3 files changed, 185 insertions(+) create mode 100644 drivers/video/videomode.c

Re: [PATCH v4] of: Add videomode helper

2012-09-21 Thread Steffen Trumtrar
On Thu, Sep 20, 2012 at 11:29:42PM +0200, Laurent Pinchart wrote: Hi, (CC'ing the linux-media mailing list, as video modes are of interest there as well) On Wednesday 19 September 2012 12:19:22 Tomi Valkeinen wrote: On Wed, 2012-09-19 at 10:20 +0200, Steffen Trumtrar wrote

<    1   2