Re: [PATCH RFC] media: rc: OF: Add Generic bindings for remote-control

2013-10-02 Thread Stephen Warren
On 10/02/2013 11:33 AM, Mauro Carvalho Chehab wrote: ... Well, from userspace PoV, it should have just one devnode for each TX/RX. I'm fine with that. So, if the device has N TX and/or RX simultaneous connections, it should be exposing N device nodes, and the DT should for it should have N

Re: [PATCH v4] media: st-rc: Add ST remote control driver

2013-09-24 Thread Stephen Warren
On 09/24/2013 02:08 AM, Srinivas KANDAGATLA wrote: Thanks Stephen, On 23/09/13 21:40, Stephen Warren wrote: On 09/19/2013 02:59 AM, Srinivas KANDAGATLA wrote: This patch adds support to ST RC driver, which is basically a IR/UHF receiver and transmitter. This IP (IRB) is common across all

Re: [PATCH v4] media: st-rc: Add ST remote control driver

2013-09-23 Thread Stephen Warren
On 09/19/2013 02:59 AM, Srinivas KANDAGATLA wrote: This patch adds support to ST RC driver, which is basically a IR/UHF receiver and transmitter. This IP (IRB) is common across all the ST parts for settop box platforms. IRB is embedded in ST COMMS IP block. It supports both Rx Tx

Re: [PATCH] media: i2c: adv7343: fix the DT binding properties

2013-09-23 Thread Stephen Warren
On 09/23/2013 05:50 AM, Laurent Pinchart wrote: On Monday 23 September 2013 08:18:52 Prabhakar Lad wrote: On Fri, Sep 20, 2013 at 3:22 PM, Sylwester Nawrocki wrote: On 09/20/2013 10:11 AM, Prabhakar Lad wrote: OK I will, just send out a fix up patch which fixes the mismatch between names for

Re: [PATCH] media: i2c: adv7343: fix the DT binding properties

2013-09-16 Thread Stephen Warren
On 09/13/2013 11:23 PM, Prabhakar Lad wrote: Hi Stephen, This patch should have been marked as RFC. Thanks for the review. On Sat, Sep 14, 2013 at 4:16 AM, Stephen Warren swar...@wwwdotorg.org wrote: On 09/13/2013 05:57 AM, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse

Re: [PATCH] media: i2c: adv7343: fix the DT binding properties

2013-09-13 Thread Stephen Warren
On 09/13/2013 05:57 AM, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch fixes the DT binding properties of adv7343 decoder. The pdata which was being read from the DT property, is removed as this can done internally in the driver using cable detection

Re: [PATCH] s5p-jpeg: Add initial device tree support for S5PV210/Exynos4210 SoCs

2013-08-23 Thread Stephen Warren
for them will be added in subsequent patches. Cc: Andrzej Pietrasiewicz andrze...@samsung.com Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Could a DT maintainer review/Ack the binding in this patch ? The binding looks reasonable to me, so, Acked-by: Stephen Warren swar...@nvidia.com

Re: [PATCH v7] s5k5baf: add camera sensor driver

2013-08-22 Thread Stephen Warren
Processor, formats up to 1600x1200, pre/post ISP cropping, downscaling via selection API, controls. The binding, Acked-by: Stephen Warren swar...@nvidia.com (although it would be great if another DT binding maintainer gave it a quick look-over to make sure I didn't miss anything!) -- To unsubscribe

Re: [PATCH v6] s5k5baf: add camera sensor driver

2013-08-20 Thread Stephen Warren
On 08/20/2013 10:03 AM, Andrzej Hajda wrote: Driver for Samsung S5K5BAF UXGA 1/5 2M CMOS Image Sensor with embedded SoC ISP. The driver exposes the sensor as two V4L2 subdevices: - S5K5BAF-CIS - pure CMOS Image Sensor, fixed 1600x1200 format, no controls. - S5K5BAF-ISP - Image Signal

Re: [PATCH RFC v5] s5k5baf: add camera sensor driver

2013-08-19 Thread Stephen Warren
On 08/19/2013 11:25 AM, Sylwester Nawrocki wrote: On 08/19/2013 03:25 PM, Pawel Moll wrote: On Mon, 2013-08-19 at 14:18 +0100, Andrzej Hajda wrote: +++ b/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt @@ -0,0 +1,51 @@ +Samsung S5K5BAF UXGA 1/5 2M CMOS Image Sensor with embedded

Re: [PATCH RFC v5] s5k5baf: add camera sensor driver

2013-08-19 Thread Stephen Warren
On 08/19/2013 04:53 PM, Tomasz Figa wrote: On Monday 19 of August 2013 16:30:45 Stephen Warren wrote: On 08/19/2013 11:25 AM, Sylwester Nawrocki wrote: On 08/19/2013 03:25 PM, Pawel Moll wrote: On Mon, 2013-08-19 at 14:18 +0100, Andrzej Hajda wrote: +++ b/Documentation/devicetree/bindings

Re: [RFC v3 02/13] [media] exynos5-fimc-is: Add Exynos5 FIMC-IS device tree bindings documentation

2013-08-08 Thread Stephen Warren
On 08/05/2013 04:37 PM, Sylwester Nawrocki wrote: On 08/05/2013 06:53 PM, Stephen Warren wrote: On 08/03/2013 03:41 PM, Sylwester Nawrocki wrote: On 08/02/2013 05:02 PM, Arun Kumar K wrote: The patch adds the DT binding documentation for Samsung Exynos5 SoC series imaging subsystem (FIMC

Re: [PATCH 1/2] ARM: Exynos: replace custom MFC reserved memory handling with generic code

2013-08-08 Thread Stephen Warren
On 08/05/2013 06:26 AM, Marek Szyprowski wrote: MFC driver use custom bindings for managing reserved memory. Those bindings are not really specific to MFC device and no even well discussed. They can be easily replaced with generic, platform independent code for handling reserved and contiguous

Re: [PATCH 1/2] ARM: Exynos: replace custom MFC reserved memory handling with generic code

2013-08-08 Thread Stephen Warren
On 08/08/2013 03:19 PM, Tomasz Figa wrote: Hi Stephen, On Thursday 08 of August 2013 15:00:52 Stephen Warren wrote: On 08/05/2013 06:26 AM, Marek Szyprowski wrote: MFC driver use custom bindings for managing reserved memory. Those bindings are not really specific to MFC device and no even

Re: [PATCH 1/2] ARM: Exynos: replace custom MFC reserved memory handling with generic code

2013-08-08 Thread Stephen Warren
On 08/08/2013 04:10 PM, Tomasz Figa wrote: On Thursday 08 of August 2013 15:47:19 Stephen Warren wrote: On 08/08/2013 03:19 PM, Tomasz Figa wrote: On Thursday 08 of August 2013 15:00:52 Stephen Warren wrote: On 08/05/2013 06:26 AM, Marek Szyprowski wrote: MFC driver use custom bindings

Re: [RFC v3 02/13] [media] exynos5-fimc-is: Add Exynos5 FIMC-IS device tree bindings documentation

2013-08-05 Thread Stephen Warren
On 08/03/2013 03:41 PM, Sylwester Nawrocki wrote: On 08/02/2013 05:02 PM, Arun Kumar K wrote: The patch adds the DT binding documentation for Samsung Exynos5 SoC series imaging subsystem (FIMC-IS). diff --git a/Documentation/devicetree/bindings/media/exynos5-fimc-is.txt

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-19 Thread Stephen Warren
On 07/19/2013 12:36 AM, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:59 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:25:44AM +0530, Kishon Vijay Abraham I wrote: Hi, On Friday 19 July 2013 11:13 AM, Greg KH wrote: On Fri, Jul 19, 2013 at 11:07:10AM +0530, Kishon Vijay

Re: [PATCH v7] [media] Add common video interfaces OF bindings documentation

2013-04-04 Thread Stephen Warren
defined by standards such as ITU-R BT.656 or MIPI-CSI2. It also documents a method of describing data links between devices. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Acked-by: Stephen Warren swar...@nvidia.com

Re: [PATCH v4 02/10] s5p-fimc: Add device tree support for FIMC devices

2013-02-13 Thread Stephen Warren
On 02/12/2013 03:39 PM, Sylwester Nawrocki wrote: On 02/11/2013 10:50 PM, Stephen Warren wrote: On 02/09/2013 03:29 PM, Sylwester Nawrocki wrote: On 02/09/2013 01:32 AM, Stephen Warren wrote: On 02/08/2013 05:05 PM, Sylwester Nawrocki wrote: On 02/09/2013 12:21 AM, Stephen Warren wrote

Re: [PATCH v4 02/10] s5p-fimc: Add device tree support for FIMC devices

2013-02-11 Thread Stephen Warren
On 02/09/2013 03:29 PM, Sylwester Nawrocki wrote: On 02/09/2013 01:32 AM, Stephen Warren wrote: On 02/08/2013 05:05 PM, Sylwester Nawrocki wrote: On 02/09/2013 12:21 AM, Stephen Warren wrote: On 02/08/2013 04:16 PM, Sylwester Nawrocki wrote: On 02/07/2013 12:40 AM, Stephen Warren wrote: diff

Re: [PATCH v4 02/10] s5p-fimc: Add device tree support for FIMC devices

2013-02-08 Thread Stephen Warren
On 02/08/2013 04:16 PM, Sylwester Nawrocki wrote: On 02/07/2013 12:40 AM, Stephen Warren wrote: diff --git a/Documentation/devicetree/bindings/media/soc/samsung-fimc.txt b/Documentation/devicetree/bindings/media/soc/samsung-fimc.txt +Samsung S5P/EXYNOS SoC Camera Subsystem (FIMC

Re: [PATCH v4 01/10] s5p-csis: Add device tree support

2013-02-08 Thread Stephen Warren
On 02/08/2013 03:29 PM, Sylwester Nawrocki wrote: On 02/07/2013 12:36 AM, Stephen Warren wrote: On 02/01/2013 12:09 PM, Sylwester Nawrocki wrote: s5p-csis is platform device driver for MIPI-CSI frontend to the FIMC device. This patch support for binding the driver to the MIPI-CSIS devices

Re: [PATCH v4 02/10] s5p-fimc: Add device tree support for FIMC devices

2013-02-08 Thread Stephen Warren
On 02/08/2013 05:05 PM, Sylwester Nawrocki wrote: On 02/09/2013 12:21 AM, Stephen Warren wrote: On 02/08/2013 04:16 PM, Sylwester Nawrocki wrote: On 02/07/2013 12:40 AM, Stephen Warren wrote: diff --git a/Documentation/devicetree/bindings/media/soc/samsung-fimc.txt b/Documentation/devicetree

Re: [PATCH v4 01/10] s5p-csis: Add device tree support

2013-02-06 Thread Stephen Warren
On 02/01/2013 12:09 PM, Sylwester Nawrocki wrote: s5p-csis is platform device driver for MIPI-CSI frontend to the FIMC device. This patch support for binding the driver to the MIPI-CSIS devices instantiated from device tree and for parsing all SoC and board specific properties. diff --git

Re: [PATCH v4 02/10] s5p-fimc: Add device tree support for FIMC devices

2013-02-06 Thread Stephen Warren
On 02/01/2013 12:09 PM, Sylwester Nawrocki wrote: This patch adds support for FIMC devices instantiated from devicetree for S5PV210 and Exynos4 SoCs. The FIMC IP features include colorspace conversion and scaling (mem-to-mem) and parallel/MIPI CSI2 bus video capture interface. Multiple SoC

Re: [PATCH v4 05/10] s5p-fimc: Add device tree based sensors registration

2013-02-06 Thread Stephen Warren
On 02/01/2013 12:09 PM, Sylwester Nawrocki wrote: The sensor (I2C and/or SPI client) devices are instantiated by their corresponding control bus drivers. Since the I2C client's master clock is often provided by a video bus receiver (host interface) or other than I2C/SPI controller device, the

Re: [PATCH v4 06/10] s5p-fimc: Use pinctrl API for camera ports configuration

2013-02-06 Thread Stephen Warren
On 02/01/2013 12:09 PM, Sylwester Nawrocki wrote: Before the camera ports can be used the pinmux needs to be configured properly. This patch adds a function to set the camera ports pinctrl to a default state within the media driver's probe(). The camera port(s) are then configured for the

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-01-31 Thread Stephen Warren
On 01/31/2013 06:27 PM, Inki Dae wrote: Hi Kukjin, -Original Message- From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Kukjin Kim Sent: Friday, February 01, 2013 9:15 AM To: 'Sylwester Nawrocki'; 'Inki Dae' Cc: 'Sachin Kamat';

Re: [PATCH] [media] Add common binding documentation for video interfaces

2012-12-18 Thread Stephen Warren
defined in standards like ITU-R BT.656 or MIPI CSI-2. It also documents a method of describing data links between devices. (quickly/briefly) Reviewed-by: Stephen Warren swar...@nvidia.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

Re: [PATCH v8 2/6] video: add of helper for videomode

2012-11-13 Thread Stephen Warren
On 11/13/2012 04:08 AM, Thierry Reding wrote: On Mon, Nov 12, 2012 at 04:37:02PM +0100, Steffen Trumtrar wrote: This adds support for reading display timings from DT or/and convert one of those timings to a videomode. The of_display_timing implementation supports multiple children where each

Re: [PATCH v7 2/8] of: add helper to parse display timings

2012-11-01 Thread Stephen Warren
On 10/31/2012 03:28 AM, Steffen Trumtrar wrote: Patch description? The patch defines the DT binding as well, which isn't mentioned in the patch subject. new file mode 100644 index 000..04c94a3 --- /dev/null +++ b/Documentation/devicetree/bindings/video/display-timings.txt +Usage in

Re: [PATCH 05/14] media: add a V4L2 OF parser

2012-10-11 Thread Stephen Warren
On 10/10/2012 04:51 PM, Laurent Pinchart wrote: On Wednesday 10 October 2012 10:50:20 Stephen Warren wrote: On 10/10/2012 07:18 AM, Laurent Pinchart wrote: On Monday 08 October 2012 17:15:53 Guennadi Liakhovetski wrote: ... But how do you get the subdev pointer? With the notifier I get

Re: [PATCH 05/14] media: add a V4L2 OF parser

2012-10-10 Thread Stephen Warren
On 10/10/2012 07:18 AM, Laurent Pinchart wrote: On Monday 08 October 2012 17:15:53 Guennadi Liakhovetski wrote: ... But how do you get the subdev pointer? With the notifier I get it from i2c_get_clientdata(client) and what do you do without it? How do you get to the client? And can't it get

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-08 Thread Stephen Warren
On 10/08/2012 02:25 AM, Guennadi Liakhovetski wrote: On Fri, 5 Oct 2012, Stephen Warren wrote: On 10/04/2012 03:35 PM, Guennadi Liakhovetski wrote: Hi Steffen Sorry for chiming in so late in the game, but I've long been wanting to have a look at this and compare with what we do for V4L2

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-08 Thread Stephen Warren
On 10/08/2012 06:20 AM, Tomi Valkeinen wrote: On Mon, 2012-10-08 at 14:04 +0200, Laurent Pinchart wrote: On Monday 08 October 2012 12:01:18 Tomi Valkeinen wrote: On Mon, 2012-10-08 at 10:25 +0200, Guennadi Liakhovetski wrote: ... Of course, if this is about describing the hardware, the

Re: [PATCH 04/14] media: add V4L2 DT binding documentation

2012-10-08 Thread Stephen Warren
On 10/02/2012 08:33 AM, Guennadi Liakhovetski wrote: On Tue, 2 Oct 2012, Rob Herring wrote: On 09/27/2012 09:07 AM, Guennadi Liakhovetski wrote: This patch adds a document, describing common V4L2 device tree bindings. diff --git a/Documentation/devicetree/bindings/media/v4l2.txt

Re: [PATCH 04/14] media: add V4L2 DT binding documentation

2012-10-08 Thread Stephen Warren
On 09/27/2012 08:07 AM, Guennadi Liakhovetski wrote: This patch adds a document, describing common V4L2 device tree bindings. Co-authored-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de I think this looks reasonable now, touch wood:-)

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-05 Thread Stephen Warren
On 10/04/2012 03:35 PM, Guennadi Liakhovetski wrote: Hi Steffen Sorry for chiming in so late in the game, but I've long been wanting to have a look at this and compare with what we do for V4L2, so, this seems a great opportunity to me:-) On Thu, 4 Oct 2012, Steffen Trumtrar wrote:

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-05 Thread Stephen Warren
On 10/05/2012 10:16 AM, Steffen Trumtrar wrote: On Thu, Oct 04, 2012 at 12:47:16PM -0600, Stephen Warren wrote: On 10/04/2012 11:59 AM, Steffen Trumtrar wrote: ... + for_each_child_of_node(timings_np, entry) { + struct signal_timing *st; + + st = of_get_display_timing

Re: [PATCH 1/2 v6] of: add helper to parse display timings

2012-10-04 Thread Stephen Warren
On 10/04/2012 11:59 AM, Steffen Trumtrar wrote: A patch description would be useful for something like this. diff --git a/Documentation/devicetree/bindings/video/display-timings.txt b/Documentation/devicetree/bindings/video/display-timings.txt new file mode 100644 ... +Usage in backend

Re: [PATCH 2/2 v6] of: add generic videomode description

2012-10-04 Thread Stephen Warren
On 10/04/2012 11:59 AM, Steffen Trumtrar wrote: Get videomode from devicetree in a format appropriate for the backend. drm_display_mode and fb_videomode are supported atm. Uses the display signal timings from of_display_timings +++ b/drivers/of/of_videomode.c +int

Re: [PATCH 1/2] of: add helper to parse display specs

2012-10-01 Thread Stephen Warren
On 09/24/2012 09:35 AM, Steffen Trumtrar wrote: Parse a display-node with timings and hardware-specs from devictree. diff --git a/Documentation/devicetree/bindings/video/display b/Documentation/devicetree/bindings/video/display new file mode 100644 index 000..722766a --- /dev/null +++

Re: [PATCH 1/2] of: add helper to parse display specs

2012-10-01 Thread Stephen Warren
On 10/01/2012 01:16 PM, Mitch Bradley wrote: On 10/1/2012 6:53 AM, Stephen Warren wrote: On 09/24/2012 09:35 AM, Steffen Trumtrar wrote: Parse a display-node with timings and hardware-specs from devictree. diff --git a/Documentation/devicetree/bindings/video/display b/Documentation

Re: [PATCH] media: add V4L2 DT binding documentation

2012-09-12 Thread Stephen Warren
: Acked-by: Stephen Warren swar...@wwwdotorg.org Just a couple comments: +++ b/Documentation/devicetree/bindings/media/v4l2.txt + ceu0: ceu@0xfe91 { + mclk: master_clock { + compatible = renesas,ceu-clock; + #clock-cells = 1; Why

Re: [PATCH] media: add V4L2 DT binding documentation

2012-09-12 Thread Stephen Warren
On 09/12/2012 01:28 PM, Guennadi Liakhovetski wrote: Hi Stephen On Wed, 12 Sep 2012, Stephen Warren wrote: On 09/11/2012 09:51 AM, Guennadi Liakhovetski wrote: This patch adds a document, describing common V4L2 device tree bindings. Co-authored-by: Sylwester Nawrocki s.nawro

Re: [PATCH] media: add V4L2 DT binding documentation

2012-09-12 Thread Stephen Warren
On 09/12/2012 03:17 PM, Guennadi Liakhovetski wrote: On Wed, 12 Sep 2012, Stephen Warren wrote: On 09/12/2012 01:28 PM, Guennadi Liakhovetski wrote: Hi Stephen On Wed, 12 Sep 2012, Stephen Warren wrote: On 09/11/2012 09:51 AM, Guennadi Liakhovetski wrote: This patch adds a document

Re: [RFC v5] V4L DT bindings

2012-09-11 Thread Stephen Warren
On 09/11/2012 08:02 AM, Guennadi Liakhovetski wrote: Hi Stephen Thanks for the review. On Wed, 5 Sep 2012, Stephen Warren wrote: On 09/05/2012 04:57 AM, Guennadi Liakhovetski wrote: Hi all Version 5 of this RFC is a result of a discussion of its version 4, which took place during

Re: [RFC v5] V4L DT bindings

2012-09-05 Thread Stephen Warren
On 09/05/2012 04:57 AM, Guennadi Liakhovetski wrote: Hi all Version 5 of this RFC is a result of a discussion of its version 4, which took place during the recent Linux Plumbers conference in San Diego. Changes are: (1) remove bus-width properties from device (bridge and client) top

Re: [RFC] media DT bindings

2012-08-01 Thread Stephen Warren
On 07/31/2012 11:59 PM, Laurent Pinchart wrote: Hi Stephen, On Tuesday 31 July 2012 17:29:24 Stephen Warren wrote: On 07/31/2012 03:22 PM, Laurent Pinchart wrote: On Tuesday 31 July 2012 14:39:07 Guennadi Liakhovetski wrote: ... Ok, then, how about #address-cells = 1

Re: [RFC] media DT bindings

2012-07-31 Thread Stephen Warren
On 07/31/2012 03:22 PM, Laurent Pinchart wrote: On Tuesday 31 July 2012 14:39:07 Guennadi Liakhovetski wrote: ... Ok, then, how about #address-cells = 1; #size-cells = 0; ... ov772x-1 = { reg = 1;