Re: [PATCH v6 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-12-12 Thread Steven Rostedt
On Wed, 12 Dec 2018 08:56:22 -0500 Steven Rostedt wrote: > Can someone please take this patch or at least say what's wrong with it > if you have a problem? > > Matwey has been patiently pinging us once every other week for over a > month asking for a reply. I've alr

Re: [PATCH v6 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-12-12 Thread Steven Rostedt
Can someone please take this patch or at least say what's wrong with it if you have a problem? Matwey has been patiently pinging us once every other week for over a month asking for a reply. I've already given my Reviewed-by from a tracing perspective. Ignoring patches is not a friendly gesture

Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread Steven Rostedt
On Fri, 30 Nov 2018 12:55:21 -0800 Jarkko Sakkinen wrote: > On Fri, Nov 30, 2018 at 11:56:52AM -0800, Davidlohr Bueso wrote: > > On Fri, 30 Nov 2018, Kees Cook wrote: > > > > > On Fri, Nov 30, 2018 at 11:27 AM Jarkko Sakkinen > > > wrote: > > > > > > > > In order to comply with the CoC, re

Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread Steven Rostedt
On Fri, 30 Nov 2018 20:39:01 + Abuse wrote: > On Friday, 30 November 2018 20:35:07 GMT David Miller wrote: > > From: Jens Axboe > > Date: Fri, 30 Nov 2018 13:12:26 -0700 > > > > > On 11/30/18 12:56 PM, Davidlohr Bueso wrote: > > >> On Fri, 30 Nov 2018, Kees Cook wrote: > > >> > > >>>

Re: [PATCH v6 1/2] media: usb: pwc: Introduce TRACE_EVENTs for pwc_isoc_handler()

2018-11-09 Thread Steven Rostedt
e, I don't see anything wrong with this patch. Reviewed-by: Steven Rostedt (VMware) -- Steve > > Signed-off-by: Matwey V. Kornilov > --- > drivers/media/usb/pwc/pwc-if.c | 7 + > include/trace/events/pwc.h | 65 > ++ >

Re: [very-RFC 6/8] Add TSN event-tracing

2016-06-12 Thread Steven Rostedt
On Sun, 12 Jun 2016 23:25:10 +0200 Henrik Austad wrote: > > > +#include > > > +#include > > > +/* #include */ > > > + > > > +/* FIXME: update to TRACE_CLASS to reduce overhead */ > > > > I'm curious to why I didn't do this now. A class would make less > > duplication of typing too ;-) >

Re: [very-RFC 6/8] Add TSN event-tracing

2016-06-12 Thread Steven Rostedt
On Sun, 12 Jun 2016 01:01:34 +0200 Henrik Austad wrote: > From: Henrik Austad > > This needs refactoring and should be updated to use TRACE_CLASS, but for > now it provides a fair debug-window into TSN. > > Cc: "David S. Miller" > Cc: Steven Rostedt (mainta

[PATCH] cx231xx: Use wake_up_interruptible() instead of wake_up_interruptible_nr()

2015-08-20 Thread Steven Rostedt
even remove the function wake_up_interruptible_nr(). Signed-off-by: Steven Rostedt --- diff --git a/drivers/media/usb/cx231xx/cx231xx-video.c b/drivers/media/usb/cx231xx/cx231xx-video.c index c6ff896..9798160 100644 --- a/drivers/media/usb/cx231xx/cx231xx-video.c +++ b/drivers/media/usb/cx231xx

Re: [PATCH] [media] v4l2: move tracepoint generation into separate file

2015-08-06 Thread Steven Rostedt
ERROR: "__tracepoint_vb2_qbuf" undefined! > ERROR: "__tracepoint_vb2_buf_queue" undefined! > Suggested-by: Steven Rostedt ;-) -- Steve > Signed-off-by: Philipp Zabel > --- -- To unsubscribe from this list: send the line "unsubscribe linux-media" i

Re: [PATCH v3 3/3] [media] videobuf2: add trace events

2015-08-03 Thread Steven Rostedt
On Tue, 28 Jul 2015 09:53:20 +0200 Philipp Zabel wrote: > I tried this yesterday and failed to figure out a satisfactory way to do > it since the vb2 trace point macros reuse the v4l2 enum definitions and > __print_symbolic/flags macros. The alternative would be to just export > the vb2 trace po

Re: [PATCH 2/2] [media] videobuf2: add trace events

2015-06-25 Thread Steven Rostedt
On Thu, 25 Jun 2015 12:01:27 +0200 Philipp Zabel wrote: > diff --git a/include/trace/events/v4l2.h b/include/trace/events/v4l2.h > index 89d0497..3d15cf1 100644 > --- a/include/trace/events/v4l2.h > +++ b/include/trace/events/v4l2.h > @@ -175,9 +175,108 @@ SHOW_FIELD > )

Re: [RESUBMIT] [PATCH] Replace mentions of "list_struct" to "list_head"

2014-11-13 Thread Steven Rostedt
On Fri, 14 Nov 2014 05:09:55 +0400 Andrey Utkin wrote: > There's no such thing as "list_struct". I guess there isn't. > > Signed-off-by: Andrey Utkin Acked-by: Steven Rostedt -- Steve > --- > drivers/gpu/drm/radeon/mkregtable.c | 24 ---

Re: [PATCH] [RFC] mutex: w/w mutex slowpath debugging

2013-04-30 Thread Steven Rostedt
On Tue, 2013-04-30 at 20:45 +0200, Daniel Vetter wrote: > /** > diff --git a/kernel/mutex.c b/kernel/mutex.c > index 66807c7..1cc3487 100644 > --- a/kernel/mutex.c > +++ b/kernel/mutex.c > @@ -827,6 +827,35 @@ int __sched mutex_trylock(struct mutex *lock) > EXPORT_SYMBOL(mutex_trylock); > > #if

Re: [PATCH v2 2/3] mutex: add support for reservation style locks, v2

2013-04-09 Thread Steven Rostedt
On Thu, Apr 04, 2013 at 06:56:58PM +0200, Daniel Vetter wrote: > > I think for starters we need to have a slightly more interesting example: > > 3 threads O, M, Y: O has the oldest ww_age/ticket, Y the youngest, M > is in between. > 2 ww_mutexes: A, B > > Y has already acquired ww_mutex A, M has

Re: [PATCH v2 2/3] mutex: add support for reservation style locks, v2

2013-04-09 Thread Steven Rostedt
On Thu, Apr 04, 2013 at 06:41:02PM +0200, Peter Zijlstra wrote: > On Thu, 2013-04-04 at 15:31 +0200, Daniel Vetter wrote: > > The thing is now that you're not expected to hold these locks for a > > long > > time - if you need to synchronously stall while holding a lock > > performance > > will go d

Re: [PATCH v2 2/3] mutex: add support for reservation style locks, v2

2013-04-09 Thread Steven Rostedt
On Thu, Apr 04, 2013 at 06:38:36PM +0200, Peter Zijlstra wrote: > On Thu, 2013-04-04 at 15:31 +0200, Daniel Vetter wrote: > > Hm, I guess your aim with the TASK_DEADLOCK wakeup is to bound the > > wait > > times of older task. > > No, imagine the following: > > struct ww_mutex A, B; > struct mute

Re: [PATCH v2 2/3] mutex: add support for reservation style locks, v2

2013-04-09 Thread Steven Rostedt
On Tue, Apr 02, 2013 at 06:59:14PM +0200, Peter Zijlstra wrote: > > So how about we call the thing something like: > > struct ww_mutex; /* wound/wait */ Reading this I can't help but think of Elmer Fudd saying "Round Robin" as "Wound Wobin" -- Steve > > int mutex_wound_lock(struct ww_mute

Re: [PATCH 05/12] mm: alloc_contig_range() added

2011-03-31 Thread Steven Rostedt
On Thu, Mar 31, 2011 at 06:26:45PM +0200, Michal Nazarewicz wrote: > >In any case, please pull the ++ret bit out of the WARN_ON(). Some > >people like to do: > > > >#define WARN_ON(...) do{}while(0) > > > >to save space on some systems. > > I don't think that's the case. Even if WARN_ON() decide

Re: [PATCH 05/12] mm: alloc_contig_range() added

2011-03-31 Thread Steven Rostedt
On Thu, Mar 31, 2011 at 09:02:41AM -0700, Dave Hansen wrote: > On Thu, 2011-03-31 at 15:16 +0200, Marek Szyprowski wrote: > > + ret = 0; > > + while (!PageBuddy(pfn_to_page(start & (~0UL << ret > > + if (WARN_ON(++ret >= MAX_ORDER)) > > + return -

Re: [PATCH 04/12] mm: alloc_contig_freed_pages() added

2011-03-31 Thread Steven Rostedt
On Thu, Mar 31, 2011 at 08:58:03AM -0700, Dave Hansen wrote: > On Thu, 2011-03-31 at 15:16 +0200, Marek Szyprowski wrote: > > > > +unsigned long alloc_contig_freed_pages(unsigned long start, unsigned long > > end, > > + gfp_t flag) > > +{ > > + unsigned

[PATCH] saa7134: Fix strange kconfig dependency on RC_CORE

2011-03-10 Thread Steven Rostedt
the kernel (y). Suggested-by: Mauro Carvalho Chehab Cc: Michal Marek Cc: linux-kbuild Signed-off-by: Steven Rostedt --- drivers/media/video/saa7134/Kconfig |1 + 1 file changed, 1 insertion(+) Index: linux-test.git/drive

Re: Failed build on randconfig for DVB_DIB modules

2010-11-12 Thread Steven Rostedt
On Fri, 2010-11-12 at 22:54 -0500, Steven Rostedt wrote: > Or we just don't test for define(MODULE). If either CONFIG_DVB_DIB3000MC > or CONFIG_DVB_DIB3000MC_MODULE are defined, the code must be there, > because, if this code is built as both a module and builtin, only the >

Re: Failed build on randconfig for DVB_DIB modules

2010-11-12 Thread Steven Rostedt
Sorry for the late reply, but KS and LPC got in the way. Also added kbuild to the Cc. On Tue, 2010-10-26 at 09:37 -0200, Mauro Carvalho Chehab wrote: > Hi Steven, > > Em 26-10-2010 02:15, Steven Rostedt escreveu: > > I'm currently finishing up an automated test pro

Re: [Ksummit-2010-discuss] [v2] Remaining BKL users, what to do

2010-10-19 Thread Steven Rostedt
On Tue, 2010-10-19 at 09:26 +0200, Arnd Bergmann wrote: > On Tuesday 19 October 2010 06:52:32 Dave Airlie wrote: > > > I might be able to find some hardware still lying around here that uses an > > > i810. Not sure unless I go hunting it. But I get the impression that if > > > the kernel is a singl

Re: [Ksummit-2010-discuss] [v2] Remaining BKL users, what to do

2010-10-18 Thread Steven Rostedt
On Tue, 2010-10-19 at 12:45 +1000, Dave Airlie wrote: > On Tue, Oct 19, 2010 at 12:24 PM, Greg KH wrote: > > So, there is no need for the i830 driver? Can it just be removed > > because i915 works instead? > > No because it provides a different userspace ABI to the i915 driver to > a different

Re: Remaining BKL users, what to do

2010-09-16 Thread Steven Rostedt
On Thu, 2010-09-16 at 16:32 +0200, Arnd Bergmann wrote: > The big kernel lock is gone from almost all code in linux-next, this is > the status of what I think will happen to the remaining users: > kernel/trace/blktrace.c: > Should be easy. Ingo? Steven? > Jens, Git blame shows this to be

Re: [PATCH] fix lock imbalances in /drivers/media/video/cafe_ccic.c

2009-09-10 Thread Steven Rostedt
On Thu, Sep 10, 2009 at 09:30:03AM -0600, Jonathan Corbet wrote: > On Thu, 10 Sep 2009 18:37:34 + > iceberg wrote: > > > In ./drivers/media/video/cafe_ccic.c, in function cafe_pci_probe: > > Mutex must be unlocked before exit > > 1. On paths starting with mutex lock in line 1912, then co