Re: [PATCH 04/12] v4l: vb2-dma-contig: add setup of sglist for MMAP buffers

2012-06-11 Thread Subash Patel
Hi Laurent, Tomasz, On 06/10/2012 11:28 PM, Laurent Pinchart wrote: Hi Tomasz, On Friday 08 June 2012 16:31:31 Tomasz Stanislawski wrote: Hi Laurent and Subash, I confirm the issue found by Subash. The function vb2_dc_kaddr_to_pages does fail for some occasions. The failures are rather

Re: [PATCH 04/12] v4l: vb2-dma-contig: add setup of sglist for MMAP buffers

2012-06-07 Thread Subash Patel
. Hence I created a patch(attached) which is based on [1] series. One can apply it for using your present patch-set in the meantime. Regards, Subash [1] http://www.spinics.net/lists/kernel/msg1343092.html From f9b2eace2eef0038a1830e5e6dd55f3bb6017e1a Mon Sep 17 00:00:00 2001 From: Subash Patel

Re: [PATCHv5 08/13] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-05-09 Thread Subash Patel
Hello Tomasz, Laurent, I have printed some logs during the dmabuf export and attach for the SGT issue below. Please find it in the attachment. I hope it will be useful. Regards, Subash On 05/08/2012 04:45 PM, Subash Patel wrote: Hi Laurent, On 05/08/2012 02:44 PM, Laurent Pinchart wrote

Re: [PATCHv5 08/13] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-05-08 Thread Subash Patel
Hi Laurent, On 05/08/2012 02:44 PM, Laurent Pinchart wrote: Hi Subash, On Monday 07 May 2012 20:08:25 Subash Patel wrote: Hello Thomasz, Laurent, I found an issue in the function vb2_dc_pages_to_sgt() below. I saw that during the attach, the size of the SGT and size requested mis-matched

Re: [PATCHv5 08/13] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-05-07 Thread Subash Patel
Hello Thomasz, Laurent, I found an issue in the function vb2_dc_pages_to_sgt() below. I saw that during the attach, the size of the SGT and size requested mis-matched (by atleast 8k bytes). Hence I made a small correction to the code as below. I could then attach the importer properly.

Re: [PATCHv5 08/13] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-05-07 Thread Subash Patel
Hi Thomasz, I have extended the MFC-FIMC testcase posted by Kamil sometime ago to sanity test the UMM patches. This test is multi-threaded(further explanation for developers who may not have seen it yet), where thread one parses the encoded stream and feeds into the codec IP driver(aka MFC

Re: [Linaro-mm-sig] [PATCH 05/10] v4l: add buffer exporting via dmabuf

2012-01-27 Thread Subash Patel
Hello Tomasz, Sorry for a late reply. Please find my answers inline. On 01/24/2012 05:36 PM, Tomasz Stanislawski wrote: Hi, On 01/24/2012 12:07 PM, Subash Patel wrote: Hello Thomasz, Instead of adding another IOCTL to query the file-descriptor in user-space, why dont we extend the existing

Re: [Linaro-mm-sig] [PATCH 05/10] v4l: add buffer exporting via dmabuf

2012-01-24 Thread Subash Patel
Hello Thomasz, Instead of adding another IOCTL to query the file-descriptor in user-space, why dont we extend the existing ones in v4l2/vb2? When the memory type set is V4L2_MEMORY_DMABUF, call to VIDIOC_REQBUFS /VIDIOC_QUERYBUF from driver can take/return the fd. We will need to add

Re: [Linaro-mm-sig] [PATCH 8/9] ARM: integrate CMA with DMA-mapping subsystem

2011-10-13 Thread Subash Patel
Hi Marek, As informed to you in private over IRC, below piece of code broke during booting EXYNOS4:SMDKV310 with ZONE_DMA enabled. On 10/06/2011 07:24 PM, Marek Szyprowski wrote: ... diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c index fbdd12e..9c27fbd 100644 --- a/arch/arm/mm/init.c

Re: [PATCH 1/1] [media] MFC: Change MFC firmware binary name

2011-09-30 Thread Subash Patel
Hello, There is option in menu-Device Drivers-Generic Driver Options-External firmware blobs to build into the kernel binary. I have used this many times instead of /lib/firmware mechanism. If someone chooses to add firmware in that way, and gives different name, then this code too can break.

Re: [PATCH 1/3] v4l: Extend V4L2_CID_COLORFX control with AQUA effect

2011-09-19 Thread Subash Patel
Hi Laurent, I am not representing Sylwester :), But with a similar sensor I use, Aqua means cool tone which is Cb/Cr manipulations. Regards, Subash On 09/19/2011 04:38 AM, Laurent Pinchart wrote: Hi Sylwester, Thanks for the patch. On Friday 16 September 2011 19:05:28 Sylwester Nawrocki

Re: [RFC] New class for low level sensors controls?

2011-09-08 Thread Subash Patel
Hi Sakari, On 09/06/2011 05:52 PM, Sakari Ailus wrote: On Tue, Sep 06, 2011 at 01:41:11PM +0200, Laurent Pinchart wrote: Hi Sakari, On Tuesday 06 September 2011 13:36:53 Sakari Ailus wrote: Hi all, We are beginning to have raw bayer image sensor drivers in the mainline. Typically such

Re: [ANN] Meeting minutes of the Cambourne meeting

2011-08-09 Thread Subash Patel
Hi Sakari, I have a point with the pixel clock. During discussion we found that pixel clock get/set is required for user space to do fine control over the frame-rate etc. What if the user sets the pixel array clock which is above the system/if bus clock? Suppose we are setting the pixel clock

Re: [PATCH v3 08/19] s5p-fimc: Add the media device driver

2011-07-22 Thread Subash Patel
Hi Sylwester, On 07/04/2011 11:24 PM, Sylwester Nawrocki wrote: The fimc media device driver is hooked onto s5p-fimc-md platform device. Such a platform device need to be added in a board initialization code and then camera sensors need to be specified as it's platform data. The s5p-fimc-md

Re: [PATCH v3 08/19] s5p-fimc: Add the media device driver

2011-07-22 Thread Subash Patel
Hi Sylwester, On 07/22/2011 02:29 PM, Sylwester Nawrocki wrote: Hi Subash, On 07/22/2011 08:26 AM, Subash Patel wrote: Hi Sylwester, On 07/04/2011 11:24 PM, Sylwester Nawrocki wrote: The fimc media device driver is hooked onto s5p-fimc-md platform device. Such a platform device need

Re: [PATCH 4/4 v9] MFC: Add MFC 5.1 V4L2 driver

2011-06-19 Thread Subash Patel
Hi Kamil, I went through the decoder flow (not codec specific yet) of your MFC driver. Since I havent acquired/produced a v4l2 based test case, I didnt check the functionality yet. Below are some of minor comments I found during my review. Regards, Subash SISO-SLG On 06/14/2011 10:06 PM,

Re: [PATCH 08/10] mm: cma: Contiguous Memory Allocator added

2011-06-15 Thread Subash Patel
Hi Arnd, On 06/14/2011 09:33 PM, Arnd Bergmann wrote: On Tuesday 14 June 2011, Michal Nazarewicz wrote: On Tue, 14 Jun 2011 15:49:29 +0200, Arnd Bergmanna...@arndb.de wrote: Please explain the exact requirements that lead you to defining multiple contexts. Some devices may have access only

Re: [Query] VIDIOC_QBUF and VIDIOC_STREAMON order

2011-03-14 Thread Subash Patel
VIDIOC_STREAMON expects buffers to be queued before hardware part of image/video pipe is enabled. From my experience of V4L2 user space, I have always QBUFfed before invoking the STREAMON. Below is the API specification which also speaks something same:

Re: [Query] VIDIOC_QBUF and VIDIOC_STREAMON order

2011-03-14 Thread Subash Patel
, Mar 14, 2011 at 03:49, Subash Patel subas...@gmail.com wrote: VIDIOC_STREAMON expects buffers to be queued before hardware part of image/video pipe is enabled. From my experience of V4L2 user space, I have always QBUFfed before invoking the STREAMON. Below is the API specification which also